GNU bug report logs - #54223
[PATCH] (guix-data-service) Add nl_NL.UTF-8 locale

Previous Next

Package: guix-patches;

Reported by: Maxime Devos <maximedevos <at> telenet.be>

Date: Wed, 2 Mar 2022 19:47:01 UTC

Severity: normal

Tags: patch

To reply to this bug, email your comments to 54223 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#54223; Package guix-patches. (Wed, 02 Mar 2022 19:47:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Maxime Devos <maximedevos <at> telenet.be>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 02 Mar 2022 19:47:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Cc: mail <at> cbaines.net
Subject: [PATCH] (guix-data-service) Add nl_NL.UTF-8 locale
Date: Wed, 02 Mar 2022 20:46:22 +0100
[Message part 1 (text/plain, inline)]
Hi guix(-data-service),

The nl_NL.UTF-8 translation (*) are currently almost 100%.
How about adding the nl_NL.UTF-8 locale?  I sent a patch
doing this to guix-devel as suggested in the README, but
it seems to have been lost (see
https://lists.gnu.org/r/guix-devel/2021-08/msg00132.html).

(*) at least for the "guix" domain, the packages aren't translated much
yet.

Perhaps the locale list needs to be modified in other
places as well (maybe
<https://git.savannah.gnu.org/cgit/guix/data-service.git/tree/guix-data-service/jobs/load-new-guix-revision.scm?id=3a9079856742b4d97bc434837323ff02eb9d32c3#n422>?).


Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#54223; Package guix-patches. (Wed, 02 Mar 2022 21:22:01 GMT) Full text and rfc822 format available.

Message #8 received at 54223 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 54223 <at> debbugs.gnu.org
Subject: Re: [PATCH] (guix-data-service) Add nl_NL.UTF-8 locale
Date: Wed, 02 Mar 2022 21:19:49 +0000
[Message part 1 (text/plain, inline)]
Maxime Devos <maximedevos <at> telenet.be> writes:

> The nl_NL.UTF-8 translation (*) are currently almost 100%.
> How about adding the nl_NL.UTF-8 locale?  I sent a patch
> doing this to guix-devel as suggested in the README, but
> it seems to have been lost (see
> https://lists.gnu.org/r/guix-devel/2021-08/msg00132.html).
>
> (*) at least for the "guix" domain, the packages aren't translated much
> yet.
>
> Perhaps the locale list needs to be modified in other
> places as well (maybe
> <https://git.savannah.gnu.org/cgit/guix/data-service.git/tree/guix-data-service/jobs/load-new-guix-revision.scm?id=3a9079856742b4d97bc434837323ff02eb9d32c3#n422>?).

Hey Maxime,

Your email last year did reach me, but obviously I overlooked it.

I've gone ahead and pushed your patch as
8ab72e633ae700fe58bb3bf72aa155d62c2bc22e, I'll deploy it to
data.guix.gnu.org within the next few days.

Note that the Guix Data Service only stores translated strings for lint
warnings, and package synopsis+descriptions, and that the storage
happens when a revision is processed, so this change will only have an
effect for revisions processed after it's made.

I tweaked the commit message slightly, and I also added nl_NL to the
second list of locales you spotted.

Ideally, the data service would get the list of locales from Guix
somehow, I'm not sure if that information is available, or quite how to
make it available, but these hardcoded locale lists are a bit of a hack.

Thanks,

Chris
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#54223; Package guix-patches. (Wed, 02 Mar 2022 21:35:02 GMT) Full text and rfc822 format available.

Message #11 received at 54223 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 54223 <at> debbugs.gnu.org
Subject: Re: [PATCH] (guix-data-service) Add nl_NL.UTF-8 locale
Date: Wed, 02 Mar 2022 22:34:08 +0100
[Message part 1 (text/plain, inline)]
Christopher Baines schreef op wo 02-03-2022 om 21:19 [+0000]:
> Hey Maxime,
> 
> Your email last year did reach me, but obviously I overlooked it.
> 
> I've gone ahead and pushed your patch as
> 8ab72e633ae700fe58bb3bf72aa155d62c2bc22e, I'll deploy it to
> data.guix.gnu.org within the next few days. [...]

Thanks!

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#54223; Package guix-patches. (Sat, 09 Apr 2022 21:04:01 GMT) Full text and rfc822 format available.

Message #14 received at 54223 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 54223 <at> debbugs.gnu.org
Subject: Re: [PATCH] (guix-data-service) Add nl_NL.UTF-8 locale
Date: Sat, 09 Apr 2022 23:03:23 +0200
[Message part 1 (text/plain, inline)]
Christopher Baines schreef op wo 02-03-2022 om 21:19 [+0000]:
> Ideally, the data service would get the list of locales from Guix
> somehow, I'm not sure if that information is available, or quite how
> to make it available, but these hardcoded locale lists are a bit of a
> hack.

Suggestion:

scheme@(guix-user)> (bindtextdomain "guix")
$1 = "/gnu/store/2bbmkgk8x4zqr4gjvb92zgji5d7m70gx-guix-1.3.0-23.a27e47f"

user <at> host:~$ ls /gnu/store/mp8yfgzxs3ww5kj8rpnkn133pmm16jd6-guix-locale-guix
> cs  da  de  eo  es  fa  fi  fr  hu  it  ko  nl  oc  pl  pt_BR  ru  si   sk  sr  sv  ta  uk  vi  zh_CN

scheme@(guix-user)> (bindtextdomain "guix-packages")
$2 = "/gnu/store/wbljwj8yfpxqgxs79vhxb41s5ypj96xd-guix-locale-guix-packages"
[...]

Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 2 years and 16 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.