X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 23 Mar 2022 18:48:01 +0000
Resent-Message-ID: <handler.54539.B.16480612674424 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 54539 <at> debbugs.gnu.org
X-Debbugs-Original-To: guix-patches@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.16480612674424
(code B ref -1); Wed, 23 Mar 2022 18:48:01 +0000
Received: (at submit) by debbugs.gnu.org; 23 Mar 2022 18:47:47 +0000
Received: from localhost ([127.0.0.1]:45986 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nX61L-00019H-3V
for submit <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:47:47 -0400
Received: from lists.gnu.org ([209.51.188.17]:53708)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nX61I-00018u-G9
for submit <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:47:45 -0400
Received: from eggs.gnu.org ([209.51.188.92]:43358)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <maximedevos@HIDDEN>)
id 1nX61I-00056R-14
for guix-patches@HIDDEN; Wed, 23 Mar 2022 14:47:44 -0400
Received: from newton.telenet-ops.be ([195.130.132.45]:38894)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <maximedevos@HIDDEN>)
id 1nX615-0001Lg-Fu
for guix-patches@HIDDEN; Wed, 23 Mar 2022 14:47:43 -0400
Received: from xavier.telenet-ops.be (xavier.telenet-ops.be
[IPv6:2a02:1800:120:4::f00:14])
by newton.telenet-ops.be (Postfix) with ESMTPS id 4KNy5N5GMkzMqZMv
for <guix-patches@HIDDEN>; Wed, 23 Mar 2022 19:47:20 +0100 (CET)
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by xavier.telenet-ops.be with bizsmtp
id 9un22700F4UW6Th01un2cv; Wed, 23 Mar 2022 19:47:02 +0100
Message-ID: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Wed, 23 Mar 2022 19:46:57 +0100
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-pqrWk31N9h+ySjicHvEB"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1648061222; bh=Gi4jT7fcP/r3pm2G8pXXZSp00HsJx9UH0v8ThIkGns8=;
h=Subject:From:To:Date;
b=Npz6j4f7z+oq1Die+/IfWlOYR/i9dU2KFrALSI72EaIr4bmC4PDjaVaiAGShWua3m
UHBYQgZU0PS6nR3wFf1NeE5d29qR1nBE9ILsU+xMZl33qeqXogolDQ7CRfl4d5x4Cy
F7lgoGUC3ecjQ6Ef6kVEVBOq7zatT6J8D3QsqHOylt6Am+GKVqYyST6L1YFgOI8O4V
0uotJ/x55Wa/WS9xg5b3DLD7Ot9rzL7dMTymT1XHHMPQlDwotrOMFE+WPCUSs50Ri0
cbIiQMF4S0tq+gOnxMBXyMDf4K0kbhJLH6NMNCWcEuBk4PTcY8rP5sUcuwZaHV8igD
3I+6GDMIccT7g==
Received-SPF: pass client-ip=195.130.132.45;
envelope-from=maximedevos@HIDDEN; helo=newton.telenet-ops.be
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
--=-pqrWk31N9h+ySjicHvEB
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Import cycles make some packaging things harder and prevent some
proposed optimisations to "guix pull", let's start eliminating them.
TBC ...
--=-pqrWk31N9h+ySjicHvEB
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjtrIRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7li0AP98/ho0PuUq8YYRyiOtjRyDpCUD
BAWS1GEvkOUMkl6MiQEAobYmoMUCMyqmlkXPQ/iZ6XaONdrD0CUi0s4f41mGeQg=
=SK03
-----END PGP SIGNATURE-----
--=-pqrWk31N9h+ySjicHvEB--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Maxime Devos <maximedevos@HIDDEN> Subject: bug#54539: Acknowledgement ([PATCH 0/6] Start breaking up import cycles) Message-ID: <handler.54539.B.16480612674424.ack <at> debbugs.gnu.org> References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN> X-Gnu-PR-Message: ack 54539 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 54539 <at> debbugs.gnu.org Date: Wed, 23 Mar 2022 18:48:01 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): guix-patches@HIDDEN If you wish to submit further information on this problem, please send it to 54539 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 54539: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D54539 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 2/6] gnu: xsensors: Move to (gnu packages xorg) to break cycles.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 23 Mar 2022 18:50:02 +0000
Resent-Message-ID: <handler.54539.B54539.16480613524687 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 54539 <at> debbugs.gnu.org
Cc: Maxime Devos <maximedevos@HIDDEN>
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.16480613524687
(code B ref 54539); Wed, 23 Mar 2022 18:50:02 +0000
Received: (at 54539) by debbugs.gnu.org; 23 Mar 2022 18:49:12 +0000
Received: from localhost ([127.0.0.1]:46004 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nX62c-0001DK-Gi
for submit <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:49:12 -0400
Received: from baptiste.telenet-ops.be ([195.130.132.51]:33950)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nX62Z-0001Ci-Hs
for 54539 <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:49:04 -0400
Received: from localhost.localdomain
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by baptiste.telenet-ops.be with bizsmtp
id 9up12700i4UW6Th01up2o7; Wed, 23 Mar 2022 19:49:02 +0100
From: Maxime Devos <maximedevos@HIDDEN>
Date: Wed, 23 Mar 2022 18:48:51 +0000
Message-Id: <20220323184855.25241-2-maximedevos@HIDDEN>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220323184855.25241-1-maximedevos@HIDDEN>
References: <20220323184855.25241-1-maximedevos@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1648061342; bh=4f4R0oYMus6qnBnpKBPLIZPl+aNwzxDiZ0MW4WFy9rA=;
h=From:To:Cc:Subject:Date:In-Reply-To:References;
b=FCzxaXiY4snMR/yhyM9Ol60ClNzT8veF3k8d/ifliEXuXYRO3gxygzPtymo694x5G
2wKJMaT5pryQnINrgoGlgazBvGWJeH7lr+nqW0yyaoi2z6s6d/4cBNl6JGm6HbiQDZ
MrYYNqoadFtofmjyIJMWUp171EFLrGBHxz6kpuk/ym1gkiK4F2BnlqR2OBoBcJnaY6
BJY8E6EMAxIA5dhAdBCwKiy8ZQQNTBCYlD+jq0cLxYoXih4cUpYkZPr1NN2TmR4IQU
fckhyAW+V6rqzTXhDegnrkiBzXZ75JzB8A7VNEW8fgX1xIDLTxO6M5BIfcgt9ebKzU
GixlSgj/19Sbg==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
This partially breaks a cycle between (gnu packages linux) and
(gnu packages gtk). It is not sufficient though, see next patch.
* gnu/packages/linux.scm (xensors): Move to ...
* gnu/packages/xorg.scm: ... this module.
---
gnu/packages/linux.scm | 38 --------------------------------------
gnu/packages/xorg.scm | 41 +++++++++++++++++++++++++++++++++++++++++
2 files changed, 41 insertions(+), 38 deletions(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 8d9dc01839..dc4f91d48f 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4502,44 +4502,6 @@ SMBus access.")
#~(list (string-append "prefix=" #$output)
(string-append "CC=" #$(cc-for-target))))))))
-(define-public xsensors
- (package
- (name "xsensors")
- (version "0.70")
- (source (origin
- (method url-fetch)
- (uri (string-append
- "http://www.linuxhardware.org/xsensors/xsensors-"
- version ".tar.gz"))
- (sha256
- (base32
- "1siplsfgvcxamyqf44h71jx6jdfmvhfm7mh0y1q8ps4zs6pj2zwh"))))
- (build-system gnu-build-system)
- (inputs `(("lm-sensors" ,lm-sensors "lib")
- ("gtk" ,gtk+-2)))
- (native-inputs (list pkg-config))
- (arguments
- `(#:phases
- (modify-phases %standard-phases
- (add-before 'configure 'enable-deprecated
- (lambda _
- (substitute* "src/Makefile.in"
- (("-DGDK_DISABLE_DEPRECATED") "")
- (("-DGTK_DISABLE_DEPRECATED") ""))
- #t))
- (add-before 'configure 'remove-Werror
- (lambda _
- (substitute* '("configure" "src/Makefile.in")
- (("-Werror") ""))
- #t)))))
- (home-page "http://www.linuxhardware.org/xsensors/")
- (synopsis "Hardware health information viewer")
- (description
- "Xsensors reads data from the libsensors library regarding hardware
-health such as temperature, voltage and fan speed and displays the information
-in a digital read-out.")
- (license license:gpl2+)))
-
(define-public perf
(package
(name "perf")
diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index 14cd3bc789..7e905842be 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -10,6 +10,7 @@
;;; Copyright © 2016 Nikita <nikita@HIDDEN>
;;; Copyright © 2016 Alex Kost <alezost@HIDDEN>
;;; Copyright © 2016 David Craven <david@HIDDEN>
+;;; Copyright © 2017 Dave Love <fx@HIDDEN>
;;; Copyright © 2016, 2017 John Darrington <jmd@HIDDEN>
;;; Copyright © 2017, 2018, 2019, 2020, 2021 Marius Bakke <marius@HIDDEN>
;;; Copyright © 2017, 2018, 2019 Rutger Helling <rhelling@HIDDEN>
@@ -6131,6 +6132,46 @@ on a button to dismiss it or can select one of several buttons
to answer a question. Xmessage can also exit after a specified time.")
(license license:x11)))
+;; Don't put this in (gnu packages linux) because that would create a
+;; cycle between (gnu packages linux) and (gnu packages gtk).
+(define-public xsensors
+ (package
+ (name "xsensors")
+ (version "0.70")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append
+ "http://www.linuxhardware.org/xsensors/xsensors-"
+ version ".tar.gz"))
+ (sha256
+ (base32
+ "1siplsfgvcxamyqf44h71jx6jdfmvhfm7mh0y1q8ps4zs6pj2zwh"))))
+ (build-system gnu-build-system)
+ (inputs `(("lm-sensors" ,lm-sensors "lib")
+ ("gtk" ,gtk+-2)))
+ (native-inputs (list pkg-config))
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-before 'configure 'enable-deprecated
+ (lambda _
+ (substitute* "src/Makefile.in"
+ (("-DGDK_DISABLE_DEPRECATED") "")
+ (("-DGTK_DISABLE_DEPRECATED") ""))
+ #t))
+ (add-before 'configure 'remove-Werror
+ (lambda _
+ (substitute* '("configure" "src/Makefile.in")
+ (("-Werror") ""))
+ #t)))))
+ (home-page "http://www.linuxhardware.org/xsensors/")
+ (synopsis "Hardware health information viewer")
+ (description
+ "Xsensors reads data from the libsensors library regarding hardware
+health such as temperature, voltage and fan speed and displays the information
+in a digital read-out.")
+ (license license:gpl2+)))
+
(define-public xterm
(package
(name "xterm")
--
2.30.2
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 1/6] gnu: audacity: Move into new module to break cycles.
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
In-Reply-To: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 23 Mar 2022 18:50:02 +0000
Resent-Message-ID: <handler.54539.B54539.16480613524695 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 54539 <at> debbugs.gnu.org
Cc: Maxime Devos <maximedevos@HIDDEN>
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.16480613524695
(code B ref 54539); Wed, 23 Mar 2022 18:50:02 +0000
Received: (at 54539) by debbugs.gnu.org; 23 Mar 2022 18:49:12 +0000
Received: from localhost ([127.0.0.1]:46006 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nX62i-0001DY-8e
for submit <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:49:12 -0400
Received: from baptiste.telenet-ops.be ([195.130.132.51]:33940)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nX62Z-0001Ch-I3
for 54539 <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:49:04 -0400
Received: from localhost.localdomain
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by baptiste.telenet-ops.be with bizsmtp
id 9up12700i4UW6Th01up2o3; Wed, 23 Mar 2022 19:49:02 +0100
From: Maxime Devos <maximedevos@HIDDEN>
Date: Wed, 23 Mar 2022 18:48:50 +0000
Message-Id: <20220323184855.25241-1-maximedevos@HIDDEN>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1648061342; bh=j7AIw2Ij5pJjRkyWDfBZx1Jgk82zP3FRUmeYnSP81A8=;
h=From:To:Cc:Subject:Date;
b=ZJ7J393a3jONvxq97dOSCEPV4i6p0FMrHwfIh1/FMtIpbdYuYUuzxqrcBsbCYUIHk
1YAyuP4/Zx0r/l1sFYt+ZAAZmbed9HwUTfKZB2yZgjOdn5890CKgwewQgYlW7A32Wa
6C4mUhnlrpd1b/0tWH1cRBiytbmX2r9psnZ4sGNo9+WDBDHoKRXFoCg1EQ7T/1VHNT
+u+2pXVAj5wq+uhv2kNEJ6hr8C2FdRY68wquoPrbsW9v05oxOghXnYsVBt8nFXz8PQ
EH3rsXi70ukol9X4WK86iAdk1f2dpXZMdKi2C9rUwgjb2hWoiAwmbUm0lNbRrpGBXr
s/LPqusjLON4A==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Currently, there's a cycle between ncurses, linux, audio and music.
By moving audacity to its own module, 'audio' does not have to import
'music' and 'linux' anymore. Looking at the output of
"guix graph --type=module", there still appears to be cycles, so
this commit will not sufficient by itself.
* gnu/packages/audio.scm (audacity): Move to ...
* gnu/packages/audacity.scm: This new module. Remove unneeded imports
from the old module. Add a few comments to the old module to discourage
re-importing the 'linux' and 'music' module in the future.
* gnu/local.mk (GNU_SYSTEM_MODULES): Register new module.
---
gnu/local.mk | 1 +
gnu/packages/audio.scm | 140 ++---------------------------------------
2 files changed, 5 insertions(+), 136 deletions(-)
diff --git a/gnu/local.mk b/gnu/local.mk
index ad39e648f7..aab22d32d4 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -112,6 +112,7 @@ GNU_SYSTEM_MODULES = \
%D%/packages/assembly.scm \
%D%/packages/astronomy.scm \
%D%/packages/attr.scm \
+ %D%/packages/audacity.scm \
%D%/packages/audio.scm \
%D%/packages/augeas.scm \
%D%/packages/authentication.scm \
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 13e0f02837..d74f8de1ab 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -90,14 +90,16 @@
#:use-module (gnu packages libbsd)
#:use-module (gnu packages libffi)
#:use-module (gnu packages libusb)
- #:use-module (gnu packages linux)
#:use-module (gnu packages llvm)
+ ;; Don't import that module here, otherwise a cycle would result.
+ ;; #:use-module (gnu packages linux)
#:use-module (gnu packages machine-learning)
#:use-module (gnu packages man)
#:use-module (gnu packages maths)
#:use-module (gnu packages mp3) ;taglib
#:use-module (gnu packages multiprecision)
- #:use-module (gnu packages music)
+ ;; Don't import that module here, otherwise a cycle would result.
+ ;; #:use-module (gnu packages music)
#:use-module (gnu packages ncurses)
#:use-module (gnu packages networking)
#:use-module (gnu packages onc-rpc)
@@ -122,7 +124,6 @@
#:use-module (gnu packages vim) ;xxd
#:use-module (gnu packages web)
#:use-module (gnu packages webkit)
- #:use-module (gnu packages wxwidgets)
#:use-module (gnu packages xiph)
#:use-module (gnu packages xml)
#:use-module (gnu packages xorg)
@@ -761,139 +762,6 @@ record, edit, mix and master audio and MIDI projects. It is targeted at audio
engineers, musicians, soundtrack editors and composers.")
(license license:gpl2+)))
-(define-public audacity
- (package
- (name "audacity")
- (version "3.1.3")
- (source
- (origin
- ;; If built from the release tag, Audacity will describe itself
- ;; as an "Alpha test version" and suggest to users that they use
- ;; the "latest stable released version".
- (method url-fetch)
- (uri (string-append "https://github.com/audacity/audacity/releases/download/"
- "Audacity-" version "/audacity-" version
- "-source.tar.gz"))
- (sha256
- (base32
- "189agx11361k9j958s6q5bngnnfx0rwaf0dwbjxy6fwvsb1wv3px"))
- (patches (search-patches "audacity-ffmpeg-fallback.patch"))
- (modules '((guix build utils)))
- (snippet
- ;; Remove bundled libraries.
- '(begin
- (for-each
- (lambda (dir)
- (delete-file-recursively (string-append "lib-src/" dir)))
- '("libsoxr" "libvamp" "lv2" "soundtouch" "sqlite" "twolame"
- ;; FIXME: these libraries have not been packaged yet:
- ;; "libnyquist"
- ;; "libscorealign"
- ;; "portburn"
- ;; "portsmf"
- ;; "portmixer"
-
- ;; FIXME: we have this library, but it differs in that the Slide
- ;; class does not have a member "getInverseStretchedTime".
- ;; "sbsms"
- ))
- #t))))
- (build-system cmake-build-system)
- (inputs
- (list wxwidgets-3.1
- gtk+
- alsa-lib
- jack-1
- expat
- lame
- linux-libre-headers
- flac
- ffmpeg
- libid3tag
- libjpeg-turbo
- libmad
- ;;("libsbsms" ,libsbsms) ;bundled version is modified
- libsndfile
- soundtouch
- soxr ;replaces libsamplerate
- sqlite
- twolame
- vamp
- libvorbis
- lv2
- lilv ;for lv2
- suil ;for lv2
- portaudio
- portmidi))
- (native-inputs
- `(("autoconf" ,autoconf)
- ("automake" ,automake)
- ("gettext" ,gettext-minimal) ;for msgfmt
- ("libtool" ,libtool)
- ("pkg-config" ,pkg-config)
- ("python" ,python)
- ("which" ,which)))
- (arguments
- `(#:configure-flags
- (list
- "-Daudacity_conan_enabled=off"
- "-Daudacity_lib_preference=system"
- ;; TODO: enable this flag once we've packaged all dependencies
- ;; "-Daudacity_obey_system_dependencies=on"
- ;; disable crash reports, updates, ..., anything that phones home
- "-Daudacity_has_networking=off")
- #:imported-modules ((guix build glib-or-gtk-build-system)
- ,@%cmake-build-system-modules)
- #:modules
- ((guix build utils)
- (guix build cmake-build-system)
- ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:))
- #:phases
- (modify-phases %standard-phases
- (add-after 'unpack 'fix-cmake-rpath
- (lambda* (#:key outputs #:allow-other-keys)
- (substitute* "CMakeLists.txt"
- (("\\$ORIGIN/\\.\\./\\$\\{_PKGLIB\\}")
- (string-append (assoc-ref outputs "out") "/lib/audacity"))
- (("CMAKE_BUILD_WITH_INSTALL_RPATH [A-Z]*")
- "CMAKE_BUILD_WITH_INSTALL_RPATH TRUE")
- (("CMAKE_INSTALL_RPATH_USE_LINK_PATH [A-Z]*")
- "CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE"))
- (substitute* "src/CMakeLists.txt"
- (("-Wl,--disable-new-dtags") "-Wl,--enable-new-dtags"))))
- (add-after 'unpack 'comment-out-revision-ident
- (lambda _
- (substitute* "src/CMakeLists.txt"
- (("file\\( TOUCH \".*RevisionIdent\\.h\" \\)" directive)
- (string-append "# " directive)))
- (substitute* "src/AboutDialog.cpp"
- (("(.*RevisionIdent\\.h.*)" include-line)
- (string-append "// " include-line)))))
- (add-after 'unpack 'use-upstream-headers
- (lambda* (#:key inputs #:allow-other-keys)
- (substitute* '("libraries/lib-files/FileNames.cpp")
- (("\"/usr/include/linux/magic.h\"") "<linux/magic.h>"))))
- (add-after 'wrap-program 'glib-or-gtk-wrap
- (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))
- ;; The test suite is not "well exercised" according to the developers,
- ;; and fails with various errors. See
- ;; <http://sourceforge.net/p/audacity/mailman/message/33524292/>.
- #:tests? #f))
- (native-search-paths
- (list (search-path-specification
- (variable "AUDACITY_MODULES_PATH")
- (files '("lib/audacity/modules")))
- (search-path-specification
- (variable "AUDACITY_PATH")
- (files '("share/audacity")))))
- (home-page "https://www.audacityteam.org/")
- (synopsis "Software for recording and editing sounds")
- (description
- "Audacity is a multi-track audio editor designed for recording, playing
-and editing digital audio. It features digital effects and spectrum analysis
-tools.")
- (license license:gpl2+)))
-
(define-public audiofile
(package
(name "audiofile")
base-commit: 9a31942cabb5c73174aee96ecd873fcf89955a9d
prerequisite-patch-id: f64e340873270246660f566eabe4af5e20ede85f
--
2.30.2
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 4/6] gnu: go-netlink: Move to (gnu packages networking) to break cycles.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 23 Mar 2022 18:50:03 +0000
Resent-Message-ID: <handler.54539.B54539.16480613534702 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 54539 <at> debbugs.gnu.org
Cc: Maxime Devos <maximedevos@HIDDEN>
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.16480613534702
(code B ref 54539); Wed, 23 Mar 2022 18:50:03 +0000
Received: (at 54539) by debbugs.gnu.org; 23 Mar 2022 18:49:13 +0000
Received: from localhost ([127.0.0.1]:46008 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nX62i-0001Dg-Q2
for submit <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:49:13 -0400
Received: from baptiste.telenet-ops.be ([195.130.132.51]:33982)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nX62Z-0001Ck-Ja
for 54539 <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:49:05 -0400
Received: from localhost.localdomain
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by baptiste.telenet-ops.be with bizsmtp
id 9up12700i4UW6Th01up2oK; Wed, 23 Mar 2022 19:49:02 +0100
From: Maxime Devos <maximedevos@HIDDEN>
Date: Wed, 23 Mar 2022 18:48:53 +0000
Message-Id: <20220323184855.25241-4-maximedevos@HIDDEN>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220323184855.25241-1-maximedevos@HIDDEN>
References: <20220323184855.25241-1-maximedevos@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1648061342; bh=r68AuVIPLdqOwyIpAkR7zIOnNLB0Y0HfiXxBPvpnuY4=;
h=From:To:Cc:Subject:Date:In-Reply-To:References;
b=Mx2y8MvZT84hWvsHX3gnLjcePMrocv8nZrBqR0+va4vvdE4fg2sRsxvCHUQNWPdoh
5/jMwcNh2wLpyOTGJMBkTI/aXQmwaTCsftsQONDFP5+OmuLOtKlC0gNo1X7tgA6yLz
4sQDCXsIPE7XIUNLeEMs8F3IhWLr8Lko93Ht0+SL8I7bwi+1om01IpWbOwpj7kbfZH
cELFnn8YmiNPVfOgVu9oubiC85D3EvVJjwAtCkoLDqphFmRgMbBxxgJFUcChq8LNnS
XRaCg8AnxD1RTiGn6QQt6C6w4JVVNjDSschSUhzKNouv8PjwGwIHwo+xsov6g+9mUX
PGLKPENgJZU1A==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
This (partially?) breaks a cycle between (gnu packages linux) and
(gnu packages networking).
* gnu/packages/linux.scm (go-netlink): Move to ...
* gnu/packages/networking.scm: ... this module.
---
gnu/packages/linux.scm | 30 ++----------------------------
gnu/packages/networking.scm | 28 ++++++++++++++++++++++++++++
2 files changed, 30 insertions(+), 28 deletions(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 6ce640ddf2..5a0c5650e4 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -125,7 +125,8 @@
#:use-module (gnu packages multiprecision)
#:use-module (gnu packages ncurses)
#:use-module (gnu packages netpbm)
- #:use-module (gnu packages networking)
+ ;; Don't import that module here, otherwise a cycle would result.
+ ;; #:use-module (gnu packages networking)
#:use-module (gnu packages ninja)
#:use-module (gnu packages nss)
#:use-module (gnu packages perl)
@@ -159,7 +160,6 @@
#:use-module (guix build-system cmake)
#:use-module (guix build-system copy)
#:use-module (guix build-system gnu)
- #:use-module (guix build-system go)
#:use-module (guix build-system meson)
#:use-module (guix build-system python)
#:use-module (guix build-system trivial)
@@ -7620,32 +7620,6 @@ nfnetlink_queue, nfnetlink_conntrack) and their respective users and/or
management tools in userspace.")
(license license:gpl2)))
-(define-public go-netlink
- (package
- (name "go-netlink")
- (version "1.0.0")
- (source (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://github.com/vishvananda/netlink")
- (commit (string-append "v" version))))
- (file-name (git-file-name name version))
- (sha256
- (base32
- "0hpzghf1a4cwawzhkiwdzin80h6hd09fskl77d5ppgc084yvj8x0"))))
- (build-system go-build-system)
- (arguments
- `(#:import-path "github.com/vishvananda/netlink"))
- (native-inputs
- (list go-golang-org-x-sys go-netns))
- (home-page "https://github.com/vishvananda/netlink")
- (synopsis "Simple netlink library for Go")
- (description "The netlink package provides a simple netlink library for
-Go. Netlink is the interface a user-space program in Linux uses to
-communicate with the kernel. It can be used to add and remove interfaces, set
-IP addresses and routes, and configure IPsec.")
- (license license:asl2.0)))
-
(define-public libinih
(package
(name "libinih")
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index b45f2f79f2..e8720e0faf 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -1663,6 +1663,34 @@ manage, and delete Internet resources from Gandi.net such as domain names,
virtual machines, and certificates.")
(license license:gpl3+)))
+;; Don't put this in (gnu packages linux) even though it is Linux-specific,
+;; because that would create cycles.
+(define-public go-netlink
+ (package
+ (name "go-netlink")
+ (version "1.0.0")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/vishvananda/netlink")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0hpzghf1a4cwawzhkiwdzin80h6hd09fskl77d5ppgc084yvj8x0"))))
+ (build-system go-build-system)
+ (arguments
+ `(#:import-path "github.com/vishvananda/netlink"))
+ (native-inputs
+ (list go-golang-org-x-sys go-netns))
+ (home-page "https://github.com/vishvananda/netlink")
+ (synopsis "Simple netlink library for Go")
+ (description "The netlink package provides a simple netlink library for
+Go. Netlink is the interface a user-space program in Linux uses to
+communicate with the kernel. It can be used to add and remove interfaces, set
+IP addresses and routes, and configure IPsec.")
+ (license license:asl2.0)))
+
(define-public go-netns
(let ((commit "13995c7128ccc8e51e9a6bd2b551020a27180abd")
(revision "1"))
--
2.30.2
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 5/6] gnu: earlyoom: Avoid importing Goland and Haskelland to break cycles.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 23 Mar 2022 18:50:03 +0000
Resent-Message-ID: <handler.54539.B54539.16480613534710 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 54539 <at> debbugs.gnu.org
Cc: Maxime Devos <maximedevos@HIDDEN>
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.16480613534710
(code B ref 54539); Wed, 23 Mar 2022 18:50:03 +0000
Received: (at 54539) by debbugs.gnu.org; 23 Mar 2022 18:49:13 +0000
Received: from localhost ([127.0.0.1]:46010 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nX62j-0001Dn-7z
for submit <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:49:13 -0400
Received: from baptiste.telenet-ops.be ([195.130.132.51]:33988)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nX62Z-0001Cl-OT
for 54539 <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:49:05 -0400
Received: from localhost.localdomain
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by baptiste.telenet-ops.be with bizsmtp
id 9up12700i4UW6Th01up2oM; Wed, 23 Mar 2022 19:49:03 +0100
From: Maxime Devos <maximedevos@HIDDEN>
Date: Wed, 23 Mar 2022 18:48:54 +0000
Message-Id: <20220323184855.25241-5-maximedevos@HIDDEN>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220323184855.25241-1-maximedevos@HIDDEN>
References: <20220323184855.25241-1-maximedevos@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1648061343; bh=nFb6CvzUz3RXDGjRAiW/qxxObFrfdZz5S4mjDITBWbw=;
h=From:To:Cc:Subject:Date:In-Reply-To:References;
b=ntvIyHggthW2KnUEbxGGn3AaSxvl55RRAMQEV4NR5ZHhtpQhG/zYKbwdTtz4jqvIB
yS8MV5rlBUKsWJmSUYmP8imtHXL1U9pBgdczDsd8yiXbNPYLmoFRacK/qBYvZEZGcj
n+XeCH1lLApwfRZlCU11XYkdVznPpDHAKz6TxA2g5FCwt68WNGtGB0RWe9ekhBXZQK
K6yG3VQgL53MSMNb2xSVqYiVFrZpRgQprj87wABftsX5lgZCOMt3LH3JEjztHpLN4u
ztQ/4CPt0QUK2sQKtH+rwWEUQuubkOhgEaUqIr/uy1Bx/E/fWwDt24ADevP+jV4vUX
HFxxcjyGSseKg==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
This (partially?) breaks a cycle between (gnu packages linux),
(gnu packages haskell-xyz) and (gnu packages golang).
It seems a bit cheaty to me but it works.
* gnu/packages/linux.scm (earlyoom): Use 'module-ref' and friends to access
'go' and 'pandoc'. Remove now unneeded imports.
---
gnu/packages/linux.scm | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 5a0c5650e4..c47204dc76 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -52,7 +52,7 @@
;;; Copyright © 2020 pukkamustard <pukkamustard@HIDDEN>
;;; Copyright © 2021 B. Wilson <elaexuotee@HIDDEN>
;;; Copyright © 2021 Ivan Gankevich <i.gankevich@HIDDEN>
-;;; Copyright © 2021 Maxime Devos <maximedevos@HIDDEN>
+;;; Copyright © 2021,2022 Maxime Devos <maximedevos@HIDDEN>
;;; Copyright © 2021 Guillaume Le Vaillant <glv@HIDDEN>
;;; Copyright © 2021 Sarah Morgensen <iskarian@HIDDEN>
;;; Copyright © 2021 Felix Gruber <felgru@HIDDEN>
@@ -110,12 +110,13 @@
#:use-module (gnu packages gettext)
#:use-module (gnu packages glib)
#:use-module (gnu packages gnupg)
- #:use-module (gnu packages golang)
+ ;; Don't import these modules here, otherwise a cycle would result.
+ ;; #:use-module (gnu packages golang)
#:use-module (gnu packages gperf)
#:use-module (gnu packages gstreamer)
- ;; Don't import that module here, otherwise a cycle would result.
+ ;; Don't import these modules here, otherwise a cycle would result.
;; #:use-module (gnu packages gtk)
- #:use-module (gnu packages haskell-xyz)
+ ;; #:use-module (gnu packages haskell-xyz)
#:use-module (gnu packages libunwind)
#:use-module (gnu packages libusb)
#:use-module (gnu packages llvm)
@@ -3771,12 +3772,17 @@ from the module-init-tools project.")
(append
;; To generate the manpage.
(if (or (target-x86-64?) (target-x86-32?))
- (list pandoc)
+ ;; Avoid adding Haskelland to the module closure
+ ;; when all we need is util-linux.
+ (list (module-ref (resolve-interface '(gnu packages haskell-xyz))
+ 'pandoc))
'())
(list
;; For the test suite.
cppcheck
- go)))
+ ;; Avoid adding 'golang' and its dependencies Rubyland and
+ ;; Nodeland to the module closure when all we need is util-linux.
+ (module-ref (resolve-interface '(gnu packages golang)) 'go))))
(home-page "https://github.com/rfjakob/earlyoom")
(synopsis "Simple out of memory (OOM) daemon for the Linux kernel")
(description "Early OOM is a minimalist out of memory (OOM) daemon that
--
2.30.2
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 6/6] gnu: linux: Avoid importing (gnu packages check) to break cycles.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 23 Mar 2022 18:50:04 +0000
Resent-Message-ID: <handler.54539.B54539.16480613544716 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 54539 <at> debbugs.gnu.org
Cc: Maxime Devos <maximedevos@HIDDEN>
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.16480613544716
(code B ref 54539); Wed, 23 Mar 2022 18:50:04 +0000
Received: (at 54539) by debbugs.gnu.org; 23 Mar 2022 18:49:14 +0000
Received: from localhost ([127.0.0.1]:46012 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nX62j-0001Dv-LN
for submit <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:49:14 -0400
Received: from baptiste.telenet-ops.be ([195.130.132.51]:33998)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nX62Z-0001Cm-Sl
for 54539 <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:49:05 -0400
Received: from localhost.localdomain
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by baptiste.telenet-ops.be with bizsmtp
id 9up12700i4UW6Th01up3oP; Wed, 23 Mar 2022 19:49:03 +0100
From: Maxime Devos <maximedevos@HIDDEN>
Date: Wed, 23 Mar 2022 18:48:55 +0000
Message-Id: <20220323184855.25241-6-maximedevos@HIDDEN>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220323184855.25241-1-maximedevos@HIDDEN>
References: <20220323184855.25241-1-maximedevos@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1648061343; bh=BTuP7W7CivJKtyGhDtNZyfv9SEmp1sqFHFJFh+iEacE=;
h=From:To:Cc:Subject:Date:In-Reply-To:References;
b=ezcefkVO4F3qZsrnbVyqGBd4/51FqRc+6hqVGHLMOsPGvBz4dO1/IkSLLBX4mhfL+
QtcjoWQTZhEg479uxBpkxerNdCgR/cx4d99OASkn0V22Jwslh4lQMDsgLMuBNKpWQ1
4+Py5o0bUhMo8JijEroN06anSFk4qo87eXuuqr9HGl3UelQMFk8zlyRcKBxokIXRZ3
dtUSWiLRA7Mfh+5JK2p3tGp8XBqDK3vVOB56q80nR/XW5kc2HGe/LIquWcODyEp10N
5jXUNw9z9x+RjUBo3YlNES2syEUgalI6m1qQliTri7jMtO5EWe2kRvi9PI/BnmzUDJ
cWZVZ8fsrTHmw==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
This (partially?) breaks a cycle between (gnu packages linux)
and (gnu packages check). There's more work to be done though,
see future patches -- stay tuned!
* gnu/packages/linux.scm
(python-pamela,earlyoom,multipath-tools,mtd-utils,procenv):
Don't import (gnu packages check), instead access that module
via 'module-ref' + 'resolve-interface'.
---
gnu/packages/linux.scm | 31 +++++++++++++++++++++++++------
1 file changed, 25 insertions(+), 6 deletions(-)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index c47204dc76..8176533d68 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -92,7 +92,9 @@
#:use-module (gnu packages bison)
#:use-module (gnu packages boost)
#:use-module (gnu packages calendar)
- #:use-module (gnu packages check)
+ ;; Don't import these modules here, otherwise a cycle would result.
+ ;; If needed, use 'module-ref' + 'resolve-interface'.
+ ;; #:use-module (gnu packages check)
#:use-module (gnu packages cpio)
#:use-module (gnu packages crypto)
#:use-module (gnu packages cryptsetup)
@@ -1681,7 +1683,10 @@ at login. Local and dynamic reconfiguration are its key features.")
(inputs
(list linux-pam))
(native-inputs
- (list python-pytest))
+ ;; Avoid adding Pythonland and GNOMEland to the module closure when
+ ;; all we need is util-linux.
+ (list (module-ref (resolve-interface '(gnu packages check))
+ 'python-pytest)))
(home-page "https://github.com/minrk/pamela")
(synopsis "PAM interface using ctypes")
(description "This package provides a PAM interface using @code{ctypes}.")
@@ -3779,7 +3784,10 @@ from the module-init-tools project.")
'())
(list
;; For the test suite.
- cppcheck
+ ;; Avoid adding Pythonland and GNOMEland to the module closure when
+ ;; all we need is util-linux.
+ (module-ref (resolve-interface '(gnu packages check))
+ 'cppcheck)
;; Avoid adding 'golang' and its dependencies Rubyland and
;; Nodeland to the module closure when all we need is util-linux.
(module-ref (resolve-interface '(gnu packages golang)) 'go))))
@@ -5183,7 +5191,10 @@ arrays when needed.")
(native-inputs
(list perl pkg-config valgrind
;; For tests.
- cmocka))
+ ;; Avoid adding Pythonland and GNOMEland to the module closure when
+ ;; all we need is util-linux.
+ (module-ref (resolve-interface '(gnu packages check))
+ 'cmocka)))
(inputs
`(("json-c" ,json-c)
("libaio" ,libaio)
@@ -6594,7 +6605,11 @@ exceeded.")
#~(list)
#~(list "--enable-unit-tests"))))
(native-inputs
- (list cmocka pkg-config))
+ (list ;; Avoid adding Pythonland and GNOMEland to the module closure when
+ ;; all we need is util-linux.
+ (module-ref (resolve-interface '(gnu packages check))
+ 'cmocka)
+ pkg-config))
(inputs
`(("acl" ,acl) ; extended attributes (xattr)
("libuuid" ,util-linux "lib")
@@ -7243,7 +7258,11 @@ the MTP device as a file system.")
(native-inputs
(list pkg-config
;; For tests.
- check groff))
+ ;; Avoid adding Pythonland and GNOMEland to the module closure when
+ ;; all we need is util-linux.
+ (module-ref (resolve-interface '(gnu packages check))
+ 'check)
+ groff))
(inputs
(list expat libcap libselinux))
(synopsis "Utility to show process environment")
--
2.30.2
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 3/6] gnu: tlp: Move tlp and friends to new module to break cycles.
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 23 Mar 2022 18:50:04 +0000
Resent-Message-ID: <handler.54539.B54539.16480613624732 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 54539 <at> debbugs.gnu.org
Cc: Maxime Devos <maximedevos@HIDDEN>
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.16480613624732
(code B ref 54539); Wed, 23 Mar 2022 18:50:04 +0000
Received: (at 54539) by debbugs.gnu.org; 23 Mar 2022 18:49:22 +0000
Received: from localhost ([127.0.0.1]:46014 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nX62n-0001EB-3E
for submit <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:49:22 -0400
Received: from baptiste.telenet-ops.be ([195.130.132.51]:33972)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nX62Z-0001Cj-Jy
for 54539 <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:49:08 -0400
Received: from localhost.localdomain
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by baptiste.telenet-ops.be with bizsmtp
id 9up12700i4UW6Th01up2o9; Wed, 23 Mar 2022 19:49:02 +0100
From: Maxime Devos <maximedevos@HIDDEN>
Date: Wed, 23 Mar 2022 18:48:52 +0000
Message-Id: <20220323184855.25241-3-maximedevos@HIDDEN>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220323184855.25241-1-maximedevos@HIDDEN>
References: <20220323184855.25241-1-maximedevos@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1648061342; bh=+k2smBwbQdMTo7r9Yjnd0YVnA19ENKGaQNZlaeMoxiw=;
h=From:To:Cc:Subject:Date:In-Reply-To:References;
b=URYGGc39csoQfNQ8izL6n5dLw5uHot5S2xLsbEshQ8OhTtm+FsLAZFF4QEKK8lBP9
YwqkyNGX5gjRdIInWnql/y7sOxWN8+Iunl12G2eS9iuRu800YE7oTNnlG/mwSr5tsd
gBJOVZiH0TiSWxWY5r7lfivsd+xAPfnDl40LTko1+3NuLQhsgAoET7NtwY9josEDAl
YQ0mwk80wrtMB8l63Rbzu0p1hPMnZ02VyPLjbNSgBq386z4iZFE0x/q/35eN+Nn/Ez
js/6xSWK3IGtKV0fgkg5TIGG4xAk85HwLjPHTayV6yxzkws/lTEcN5yh2PBxKLTH9a
WlH7qB4OTRkTQ==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
This partially breaks a cycle between (gnu packages linux) and
(gnu packages gtk). It is not sufficient though, see next patch.
* gnu/packages/linux.scm (tlp,tlpui): Move to ...
* gnu/packages/tlp.scm: ... this new module.
* gnu/local.mk (GNU_SYSTEM_MODULES): Register new module.
---
gnu/local.mk | 1 +
gnu/packages/linux.scm | 192 +---------------------------------
gnu/packages/tlp.scm | 228 +++++++++++++++++++++++++++++++++++++++++
3 files changed, 231 insertions(+), 190 deletions(-)
create mode 100644 gnu/packages/tlp.scm
diff --git a/gnu/local.mk b/gnu/local.mk
index aab22d32d4..ad24234ae5 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -582,6 +582,7 @@ GNU_SYSTEM_MODULES = \
%D%/packages/textutils.scm \
%D%/packages/text-editors.scm \
%D%/packages/time.scm \
+ %D%/packages/tlp.scm \
%D%/packages/tls.scm \
%D%/packages/tmux.scm \
%D%/packages/toolkits.scm \
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index dc4f91d48f..6ce640ddf2 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -113,8 +113,8 @@
#:use-module (gnu packages golang)
#:use-module (gnu packages gperf)
#:use-module (gnu packages gstreamer)
- #:use-module (gnu packages gtk)
- #:use-module (gnu packages haskell-apps)
+ ;; Don't import that module here, otherwise a cycle would result.
+ ;; #:use-module (gnu packages gtk)
#:use-module (gnu packages haskell-xyz)
#:use-module (gnu packages libunwind)
#:use-module (gnu packages libusb)
@@ -6897,194 +6897,6 @@ The appropriate permissions must be set on the backlight or LED control
interface in sysfs, which can be accomplished with the included udev rules.")
(license license:expat)))
-(define-public tlp
- (package
- (name "tlp")
- (version "1.5.0")
- (source
- (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://github.com/linrunner/TLP")
- (commit version)))
- (file-name (git-file-name name version))
- (sha256
- (base32 "0cssclk2brhwvn9dm7h5snm2svwy0c8cfr4z2cgkdkac2pfaaxw4"))))
- (native-inputs
- (list shellcheck))
- (inputs
- `(("bash" ,bash)
- ("dbus" ,dbus)
- ("ethtool" ,ethtool)
- ("eudev" ,eudev)
- ("grep" ,grep)
- ("hdparm" ,hdparm)
- ("inetutils" ,inetutils)
- ("iw" ,iw)
- ("kmod" ,kmod)
- ("pciutils" ,pciutils)
- ("perl" ,perl)
- ("rfkill" ,rfkill)
- ("sed" ,sed)
- ("usbutils" ,usbutils)
- ("util-linux" ,util-linux)
- ("wireless-tools" ,wireless-tools)
- ,@(if (let ((system (or (%current-target-system)
- (%current-system))))
- (or (string-prefix? "i686-" system)
- (string-prefix? "x86_64-" system)))
- `(("x86-energy-perf-policy" ,x86-energy-perf-policy))
- '())))
- (build-system gnu-build-system)
- (arguments
- ;; XXX: The full test suite is run with "checkall" but it requires
- ;; "checkbashisms" and "perlcritic", not yet packaged in Guix.
- `(#:test-target "shellcheck"
- #:modules ((guix build gnu-build-system)
- (guix build utils)
- (srfi srfi-1))
- #:phases
- (modify-phases %standard-phases
- (delete 'configure) ; no configure script
- (add-before 'build 'setenv
- (lambda* (#:key outputs #:allow-other-keys)
- (let ((out (assoc-ref outputs "out")))
- (setenv "TLP_WITH_SYSTEMD" "0")
- (setenv "TLP_NO_INIT" "1")
- (setenv "TLP_NO_PMUTILS" "1")
- (setenv "TLP_SBIN" (string-append out "/bin"))
- (setenv "TLP_BATD" (string-append out "/share/tlp/bat.d"))
- (setenv "TLP_BIN" (string-append out "/bin"))
- (setenv "TLP_TLIB" (string-append out "/share/tlp"))
- (setenv "TLP_FLIB" (string-append out "/share/tlp/func.d"))
- (setenv "TLP_ULIB" (string-append out "/lib/udev"))
- (setenv "TLP_CONFDEF"
- (string-append out "/share/tlp/defaults.conf"))
- (setenv "TLP_CONFDIR" (string-append out "/etc/tlp.d"))
- (setenv "TLP_CONFREN"
- (string-append out "/share/tlp/rename.conf"))
- (setenv "TLP_ELOD"
- (string-append out "/lib/elogind/system-sleep"))
- (setenv "TLP_SHCPL"
- (string-append out "/share/bash-completion/completions"))
- (setenv "TLP_MAN" (string-append out "/share/man"))
- (setenv "TLP_META" (string-append out "/share/metainfo")))))
- (add-before 'install 'fix-installation
- (lambda _
- ;; Stop the Makefile from trying to create system directories.
- (substitute* "Makefile"
- (("\\[ -f \\$\\(_CONFUSR\\) \\]") "#")
- (("install -d -m 755 \\$\\(_VAR\\)") "#"))))
- (replace 'install
- (lambda _ (invoke "make" "install-tlp" "install-man-tlp")))
- (add-after 'install 'wrap
- (lambda* (#:key inputs outputs #:allow-other-keys)
- (let* ((bin (string-append (assoc-ref outputs "out") "/bin"))
- (bin-files (find-files bin ".*")))
- (define (bin-directory input-name)
- (let ((p (assoc-ref inputs input-name)))
- (and p (string-append p "/bin"))))
- (define (sbin-directory input-name)
- (string-append (assoc-ref inputs input-name) "/sbin"))
- (for-each (lambda (program)
- (wrap-program program
- `("PATH" ":" prefix
- ,(append
- (filter-map bin-directory
- '("bash"
- "coreutils"
- "dbus"
- "eudev"
- "grep"
- "inetutils"
- "kmod"
- "perl"
- "sed"
- "usbutils"
- "util-linux"
- "x86-energy-perf-policy"))
- (filter-map sbin-directory
- '("ethtool"
- "hdparm"
- "iw"
- "pciutils"
- "rfkill"
- "wireless-tools"))))))
- bin-files)))))))
- (home-page "https://linrunner.de/en/tlp/tlp.html")
- (synopsis "Power management tool for Linux")
- (description "TLP is a power management tool for Linux. It comes with
-a default configuration already optimized for battery life. Nevertheless,
-TLP is customizable to fulfil system requirements. TLP settings are applied
-every time the power supply source is changed.")
- ;; 'COPYING' is a custom version that says that one file is GPLv3+ and the
- ;; rest is GPLv2+.
- (license (list license:gpl2+ license:gpl3+))))
-
-(define-public tlpui
- (package
- (name "tlpui")
- (version "1.5.0")
- (source
- (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://github.com/d4nj1/TLPUI")
- (commit (string-append "tlpui-" version))))
- (file-name (git-file-name name version))
- (sha256
- (base32 "0ca18hazxksx516nkh28f6rd0l1039nkn7mszqfy68c461061q1h"))))
- (build-system python-build-system)
- (arguments
- `(#:phases
- (modify-phases %standard-phases
- (add-after 'unpack 'patch-setup.py
- ;; Install data_files to $out/share instead of /usr/share.
- (lambda _
- (substitute* "setup.py"
- (("/usr/") ""))))
- (add-after 'unpack 'use-tlp-input
- ;; Hard-code tlp-stat filename to avoid propagating "tlp".
- (lambda* (#:key inputs #:allow-other-keys)
- (let ((tlp-stat (search-input-file inputs "/bin/tlp-stat")))
- (with-directory-excursion "tlpui"
- (substitute* '("file.py" "settingshelper.py" "statui.py")
- (("which\\(\"tlp-stat\"\\)")
- (string-append "'" tlp-stat "'"))
- (("\"tlp-stat\"")
- (string-append "'" tlp-stat "'")))))))
- (add-before 'check 'fix-home-directory
- (lambda _
- ;; Tests fail with "Permission denied:
- ;; '/homeless-shelter'".
- (setenv "HOME" "/tmp")))
- ;; `sanity-check' phase errors out with the following
- ;; messages: "Unable to init server: Could not connect:
- ;; Connection refused" and "Error: cannot read user
- ;; configuration from /etc/tlp.conf or /etc/default/tlp".
- (delete 'sanity-check)
- (replace 'check
- (lambda _
- (invoke "python" "-m" "discover")))
- (add-after 'install 'wrap-gi-python
- (lambda* (#:key outputs #:allow-other-keys)
- (let ((out (assoc-ref outputs "out"))
- (gi-typelib-path (getenv "GI_TYPELIB_PATH")))
- (wrap-program (string-append out "/bin/tlpui")
- `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
- (native-inputs
- (list `(,glib "bin") gobject-introspection python-discover))
- (inputs
- (list gtk+ python-pygobject tlp))
- (home-page "https://github.com/d4nj1/TLPUI")
- (synopsis "User interface for TLP written in Python")
- (description
- "The Python scripts in this project generate a GTK-UI to change
-TLP configuration files easily. It aims to protect users from setting
-bad configuration and to deliver a basic overview of all the valid
-configuration values.")
- (license license:gpl2+)))
-
(define-public lshw
(package
(name "lshw")
diff --git a/gnu/packages/tlp.scm b/gnu/packages/tlp.scm
new file mode 100644
index 0000000000..dfe7d3616b
--- /dev/null
+++ b/gnu/packages/tlp.scm
@@ -0,0 +1,228 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2021 Brice Waegeneire <brice@HIDDEN>
+;;; Copyright © 2018-2022 Nicolas Goaziou <mail@HIDDEN>
+;;; Copyright © 2019 Stefan Stefanović <stefanx2ovic@HIDDEN>
+;;; Copyright © 2019 Ludovic Courtès <ludo@HIDDEN>
+;;; Copyright © 2017 Tobias Geerinckx-Rice <me@HIDDEN>
+;;; Copyright © 2017 Mathieu Othacehe <m.othacehe@HIDDEN>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages tlp)
+ #:use-module (guix packages)
+ #:use-module (guix build-system gnu)
+ #:use-module (guix build-system python)
+ #:use-module (guix git-download)
+ #:use-module (gnu packages admin) ;inetutils
+ #:use-module (gnu packages base) ;grep
+ #:use-module (gnu packages bash)
+ #:use-module (gnu packages check) ;python-discover
+ #:use-module (gnu packages glib) ;dbus
+ #:use-module (gnu packages haskell-apps) ;shellcheck
+ #:use-module (gnu packages gtk)
+ #:use-module (gnu packages linux) ;eudev
+ #:use-module (gnu packages networking) ;ethtool
+ #:use-module (gnu packages pciutils)
+ #:use-module (gnu packages perl) ;ethtool
+ #:use-module ((guix licenses) #:prefix license:))
+
+(define-public tlp
+ (package
+ (name "tlp")
+ (version "1.5.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/linrunner/TLP")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "0cssclk2brhwvn9dm7h5snm2svwy0c8cfr4z2cgkdkac2pfaaxw4"))))
+ (native-inputs
+ (list shellcheck))
+ (inputs
+ `(("bash" ,bash)
+ ("dbus" ,dbus)
+ ("ethtool" ,ethtool)
+ ("eudev" ,eudev)
+ ("grep" ,grep)
+ ("hdparm" ,hdparm)
+ ("inetutils" ,inetutils)
+ ("iw" ,iw)
+ ("kmod" ,kmod)
+ ("pciutils" ,pciutils)
+ ("perl" ,perl)
+ ("rfkill" ,rfkill)
+ ("sed" ,sed)
+ ("usbutils" ,usbutils)
+ ("util-linux" ,util-linux)
+ ("wireless-tools" ,wireless-tools)
+ ,@(if (let ((system (or (%current-target-system)
+ (%current-system))))
+ (or (string-prefix? "i686-" system)
+ (string-prefix? "x86_64-" system)))
+ `(("x86-energy-perf-policy" ,x86-energy-perf-policy))
+ '())))
+ (build-system gnu-build-system)
+ (arguments
+ ;; XXX: The full test suite is run with "checkall" but it requires
+ ;; "checkbashisms" and "perlcritic", not yet packaged in Guix.
+ `(#:test-target "shellcheck"
+ #:modules ((guix build gnu-build-system)
+ (guix build utils)
+ (srfi srfi-1))
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure) ; no configure script
+ (add-before 'build 'setenv
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out")))
+ (setenv "TLP_WITH_SYSTEMD" "0")
+ (setenv "TLP_NO_INIT" "1")
+ (setenv "TLP_NO_PMUTILS" "1")
+ (setenv "TLP_SBIN" (string-append out "/bin"))
+ (setenv "TLP_BATD" (string-append out "/share/tlp/bat.d"))
+ (setenv "TLP_BIN" (string-append out "/bin"))
+ (setenv "TLP_TLIB" (string-append out "/share/tlp"))
+ (setenv "TLP_FLIB" (string-append out "/share/tlp/func.d"))
+ (setenv "TLP_ULIB" (string-append out "/lib/udev"))
+ (setenv "TLP_CONFDEF"
+ (string-append out "/share/tlp/defaults.conf"))
+ (setenv "TLP_CONFDIR" (string-append out "/etc/tlp.d"))
+ (setenv "TLP_CONFREN"
+ (string-append out "/share/tlp/rename.conf"))
+ (setenv "TLP_ELOD"
+ (string-append out "/lib/elogind/system-sleep"))
+ (setenv "TLP_SHCPL"
+ (string-append out "/share/bash-completion/completions"))
+ (setenv "TLP_MAN" (string-append out "/share/man"))
+ (setenv "TLP_META" (string-append out "/share/metainfo")))))
+ (add-before 'install 'fix-installation
+ (lambda _
+ ;; Stop the Makefile from trying to create system directories.
+ (substitute* "Makefile"
+ (("\\[ -f \\$\\(_CONFUSR\\) \\]") "#")
+ (("install -d -m 755 \\$\\(_VAR\\)") "#"))))
+ (replace 'install
+ (lambda _ (invoke "make" "install-tlp" "install-man-tlp")))
+ (add-after 'install 'wrap
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ (let* ((bin (string-append (assoc-ref outputs "out") "/bin"))
+ (bin-files (find-files bin ".*")))
+ (define (bin-directory input-name)
+ (let ((p (assoc-ref inputs input-name)))
+ (and p (string-append p "/bin"))))
+ (define (sbin-directory input-name)
+ (string-append (assoc-ref inputs input-name) "/sbin"))
+ (for-each (lambda (program)
+ (wrap-program program
+ `("PATH" ":" prefix
+ ,(append
+ (filter-map bin-directory
+ '("bash"
+ "coreutils"
+ "dbus"
+ "eudev"
+ "grep"
+ "inetutils"
+ "kmod"
+ "perl"
+ "sed"
+ "usbutils"
+ "util-linux"
+ "x86-energy-perf-policy"))
+ (filter-map sbin-directory
+ '("ethtool"
+ "hdparm"
+ "iw"
+ "pciutils"
+ "rfkill"
+ "wireless-tools"))))))
+ bin-files)))))))
+ (home-page "https://linrunner.de/en/tlp/tlp.html")
+ (synopsis "Power management tool for Linux")
+ (description "TLP is a power management tool for Linux. It comes with
+a default configuration already optimized for battery life. Nevertheless,
+TLP is customizable to fulfil system requirements. TLP settings are applied
+every time the power supply source is changed.")
+ ;; 'COPYING' is a custom version that says that one file is GPLv3+ and the
+ ;; rest is GPLv2+.
+ (license (list license:gpl2+ license:gpl3+))))
+
+(define-public tlpui
+ (package
+ (name "tlpui")
+ (version "1.5.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/d4nj1/TLPUI")
+ (commit (string-append "tlpui-" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "0ca18hazxksx516nkh28f6rd0l1039nkn7mszqfy68c461061q1h"))))
+ (build-system python-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'patch-setup.py
+ ;; Install data_files to $out/share instead of /usr/share.
+ (lambda _
+ (substitute* "setup.py"
+ (("/usr/") ""))))
+ (add-after 'unpack 'use-tlp-input
+ ;; Hard-code tlp-stat filename to avoid propagating "tlp".
+ (lambda* (#:key inputs #:allow-other-keys)
+ (let ((tlp-stat (search-input-file inputs "/bin/tlp-stat")))
+ (with-directory-excursion "tlpui"
+ (substitute* '("file.py" "settingshelper.py" "statui.py")
+ (("which\\(\"tlp-stat\"\\)")
+ (string-append "'" tlp-stat "'"))
+ (("\"tlp-stat\"")
+ (string-append "'" tlp-stat "'")))))))
+ (add-before 'check 'fix-home-directory
+ (lambda _
+ ;; Tests fail with "Permission denied:
+ ;; '/homeless-shelter'".
+ (setenv "HOME" "/tmp")))
+ ;; `sanity-check' phase errors out with the following
+ ;; messages: "Unable to init server: Could not connect:
+ ;; Connection refused" and "Error: cannot read user
+ ;; configuration from /etc/tlp.conf or /etc/default/tlp".
+ (delete 'sanity-check)
+ (replace 'check
+ (lambda _
+ (invoke "python" "-m" "discover")))
+ (add-after 'install 'wrap-gi-python
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out"))
+ (gi-typelib-path (getenv "GI_TYPELIB_PATH")))
+ (wrap-program (string-append out "/bin/tlpui")
+ `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))))))))
+ (native-inputs
+ (list `(,glib "bin") gobject-introspection python-discover))
+ (inputs
+ (list gtk+ python-pygobject tlp))
+ (home-page "https://github.com/d4nj1/TLPUI")
+ (synopsis "User interface for TLP written in Python")
+ (description
+ "The Python scripts in this project generate a GTK-UI to change
+TLP configuration files easily. It aims to protect users from setting
+bad configuration and to deliver a basic overview of all the valid
+configuration values.")
+ (license license:gpl2+)))
--
2.30.2
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 23 Mar 2022 18:50:05 +0000
Resent-Message-ID: <handler.54539.B54539.16480613874783 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 54539 <at> debbugs.gnu.org
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.16480613874783
(code B ref 54539); Wed, 23 Mar 2022 18:50:05 +0000
Received: (at 54539) by debbugs.gnu.org; 23 Mar 2022 18:49:47 +0000
Received: from localhost ([127.0.0.1]:46020 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nX63H-0001F5-9J
for submit <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:49:47 -0400
Received: from xavier.telenet-ops.be ([195.130.132.52]:45278)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nX63F-0001Ew-Qy
for 54539 <at> debbugs.gnu.org; Wed, 23 Mar 2022 14:49:46 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by xavier.telenet-ops.be with bizsmtp
id 9upk2700D4UW6Th01upkKu; Wed, 23 Mar 2022 19:49:44 +0100
Message-ID: <a85be88402b840a95e3c57705a8554eacbd5789a.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Wed, 23 Mar 2022 19:49:44 +0100
In-Reply-To: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-uwLe3eUhNIrSZV57yDYe"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1648061384; bh=7EJfH3ay8eRJx8uyUDPsOW2gzzQ9Sm8uvQlQNcqQX5s=;
h=Subject:From:To:Date:In-Reply-To:References;
b=fcx5QIziCt17g3rpZglRjhys9INzDc00lq6Z5MaQxveJSMS4RzrCRdgb2bj1mjFCE
Fs6Nt1P0GVPifFZ4zLn872xE82DZGAkOcXZO8hnfTvLVv3ElrBTwViZ+N34m7ebJnf
x0B6kkT8QGgXM8KW7rxgvQF8gHfwqa/SuCsDQ5o2pk4hZu7491qSN/Y0mS7xeUzJVY
t8FveNoujgV61qEf8viG0fPYEAJYoLVZMshE41JDftO3A4OzNqfz3u+5cLzn+yVUX4
JZXmQ78QywRpCG+nQWc9c7TvDFSe7GkjluCrokqIWMrDScFttlfAzZJ1Yaw8xfbocW
aIVv0jBqLJe9Q==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-uwLe3eUhNIrSZV57yDYe
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Maxime Devos schreef op wo 23-03-2022 om 19:46 [+0100]:
> Import cycles make some packaging things harder and prevent some
> proposed optimisations to "guix pull", let's start eliminating them.
> TBC ...
The copyright lines are based on a mix of "git blame" and "git log --
grep the-package"; I might have missed some people ...
--=-uwLe3eUhNIrSZV57yDYe
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjtryBccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7ijJAQDEhgTDbPiupDFrHNRdfwDv38Do
zUrbbQdBf9fpsPSFHwEA53+d59PRmNQAb/eddh3vdXTKp+MJ38Rbq3sOMpgbGA8=
=tc+7
-----END PGP SIGNATURE-----
--=-uwLe3eUhNIrSZV57yDYe--
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 24 Mar 2022 07:23:01 +0000
Resent-Message-ID: <handler.54539.B54539.164810654016897 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxime Devos <maximedevos@HIDDEN>, 54539 <at> debbugs.gnu.org
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.164810654016897
(code B ref 54539); Thu, 24 Mar 2022 07:23:01 +0000
Received: (at 54539) by debbugs.gnu.org; 24 Mar 2022 07:22:20 +0000
Received: from localhost ([127.0.0.1]:46690 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nXHnY-0004OT-At
for submit <at> debbugs.gnu.org; Thu, 24 Mar 2022 03:22:20 -0400
Received: from mailrelay.tugraz.at ([129.27.2.202]:13846)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1nXHnQ-0004OE-MX
for 54539 <at> debbugs.gnu.org; Thu, 24 Mar 2022 03:22:18 -0400
Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101])
by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4KPGrJ3QRkz1LXt4;
Thu, 24 Mar 2022 08:22:08 +0100 (CET)
DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4KPGrJ3QRkz1LXt4
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at;
s=mailrelay; t=1648106528;
bh=u6Huo7rr9c1V4JrVmaG5yzmUN80rh8K/BVxDksbeSy4=;
h=Subject:From:To:Date:In-Reply-To:References:From;
b=AQgfwbLct+DPaCXxLhGLZytgRLseOBNIKyLgF8a9OAu7nCOlPPbNmj1yEK5DINe2m
Po/YfmzDcuqvigtFkaRrB3kbyZfmkEBqJTXAtq/wwzORAqDsnK9/JwbrY4Y4LNNRaX
hLbsRTYdIex8drr9YsQd19LLfPYt5Dc7U8D/q1iU=
Message-ID: <5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Thu, 24 Mar 2022 08:22:09 +0100
In-Reply-To: <a85be88402b840a95e3c57705a8554eacbd5789a.camel@HIDDEN>
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
<a85be88402b840a95e3c57705a8554eacbd5789a.camel@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ
X-Spam-Scanner: SpamAssassin 3.003001
X-Spam-Score-relay: -1.9
X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hi Maxime,
Am Mittwoch, dem 23.03.2022 um 19:49 +0100 schrieb Maxime Devos:
> Maxime Devos schreef op wo 23-03-2022 om 19:46 [+0100]:
> > Import cycles make some packaging things harder and prevent some
> > proposed optimisations to "guix pull", let's start eliminating
> > them.
> > TBC ...
>
> The copyright lines are based on a mix of "git blame" and "git log --
> grep the-package"; I might have missed some people ...
I agree that breaking up cycles is a good thing, but I disagree with
some of the decisions you've made here. For instance, I oppose the use
of single-package modules, because those more often than not simply
clutter the file system.
I'm not sure if Guile's #:autoload could do anything to fix these
issues (I suppose not), but long term I think guile modules should
support a style that is basically (resolve-interface) + (module-ref) in
the manner Guix needs, but declaratively. While we do not have that in
place yet, I suggest something like the following:
(define (check-package-ref pkg)
(module-ref (resolve-interface '(gnu packages check)) pkg))
...
or
(define check-package-ref
(let ((iface (resolve-interface '(gnu packages check))))
(lambda (pkg) (resolve-interface iface pkg))))
I'm not sure if the second will have the intended effect. It appears
to me as though the key to breaking these cycles is moving them into a
context that is not evaluated on the top of the file, e.g. a thunked
field or in the case of my first suggestion a procedure.
In either case, declaring all these lazy dependencies near the module
definition would have the added benefit, that people could see them
being lazily imported and thus no longer need the #:use-modules
comment.
WDYT?
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 24 Mar 2022 15:06:02 +0000
Resent-Message-ID: <handler.54539.B54539.164813434225719 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>, 54539 <at> debbugs.gnu.org
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.164813434225719
(code B ref 54539); Thu, 24 Mar 2022 15:06:02 +0000
Received: (at 54539) by debbugs.gnu.org; 24 Mar 2022 15:05:42 +0000
Received: from localhost ([127.0.0.1]:49172 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nXP1y-0006gl-Go
for submit <at> debbugs.gnu.org; Thu, 24 Mar 2022 11:05:42 -0400
Received: from albert.telenet-ops.be ([195.130.137.90]:36738)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nXP1x-0006gd-1Y
for 54539 <at> debbugs.gnu.org; Thu, 24 Mar 2022 11:05:41 -0400
Received: from [IPv6:2a02:2c40:200:b001::1:66ec]
([IPv6:2a02:2c40:200:b001::1:66ec])
by albert.telenet-ops.be with bizsmtp
id AF5a2700548ECPd06F5gQo; Thu, 24 Mar 2022 16:05:40 +0100
Message-ID: <70b6c5f42bccf41a63acb38922e8d20d4eda3d8a.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Thu, 24 Mar 2022 16:05:33 +0100
In-Reply-To: <5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
<a85be88402b840a95e3c57705a8554eacbd5789a.camel@HIDDEN>
<5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-4JI2SAZvG1A16dMVqSEi"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1648134340; bh=tW2cV0MJWF/tPR/olyRM2TBFqBStuLcJhpUVDSVQNQE=;
h=Subject:From:To:Date:In-Reply-To:References;
b=LPrFKESnVfa+PkjgvbIXy6wfDSY98xB8Z8gumqAzNBjEav1DQuviYfSyN61xhwDOt
+kcFs+z+EM0meMfeOGFzCHwFQwB7IVczvSzXELxwYrUqh0QztjvntMiviE2a7oMFzt
XX3QRRlDFi/p4x0qrjZYW0kcqcjmZrOP/NaQ2ZL+45/fyXDE5EKKtAe4oAR8M+Vk4v
y/66Ck/Pt3Q9HjorJmecMAaSESoJpQN29Wcb/fgbhzQrkXC6MIFO2eWnF8GHhizp7o
8MCsnHyK8BVkN8m8wmraioFXTPyU3M3mc6fbSlnryhRAteuOaU6NX+VNoCTduoYvuI
xJqmO89xuso0A==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-4JI2SAZvG1A16dMVqSEi
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Liliana Marie Prikler schreef op do 24-03-2022 om 08:22 [+0100]:
> I agree that breaking up cycles is a good thing, but I disagree with
> some of the decisions you've made here.=C2=A0 For instance, I oppose the =
use
> of single-package modules, because those more often than not simply
> clutter the file system.
There are some other sound applications in (gnu packages audio)
and (gnu packages music), so maybe I can make a (gnu packages audio-
apps) module where 'audacity' and other applications like 'calf' can
reside?
For reducing the contribution of (gnu packages compression) on the
cycle issue, I've (in not yet submitted patched) separated many things
into (gnu packages compression-xyz), perhaps I can merge
(gnu packages patools) into (gnu packages compression-xyz)?
Greetings,
Maxime.
--=-4JI2SAZvG1A16dMVqSEi
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjyIvRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7rOTAP0YuDljFH70+2uWg1ghSjlV2CQa
cHtSUkp37fUrUPJ9WAD7B7OLNzXZQsprCTFB3CcxG+V/6Z92MK6HeSz75Y0yygo=
=nThe
-----END PGP SIGNATURE-----
--=-4JI2SAZvG1A16dMVqSEi--
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 24 Mar 2022 15:39:01 +0000
Resent-Message-ID: <handler.54539.B54539.164813631129001 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxime Devos <maximedevos@HIDDEN>, 54539 <at> debbugs.gnu.org
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.164813631129001
(code B ref 54539); Thu, 24 Mar 2022 15:39:01 +0000
Received: (at 54539) by debbugs.gnu.org; 24 Mar 2022 15:38:31 +0000
Received: from localhost ([127.0.0.1]:49237 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nXPXj-0007Xh-0m
for submit <at> debbugs.gnu.org; Thu, 24 Mar 2022 11:38:31 -0400
Received: from mailrelay.tugraz.at ([129.27.2.202]:44451)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1nXPXh-0007XP-51
for 54539 <at> debbugs.gnu.org; Thu, 24 Mar 2022 11:38:30 -0400
Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101])
by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4KPTrw45b2z3xQt;
Thu, 24 Mar 2022 16:38:24 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at;
s=mailrelay; t=1648136304;
bh=eXaZNY9weUZUn3S1eGFp7tzfO9D8CjR975LelwCL6uA=;
h=Subject:From:To:Date:In-Reply-To:References;
b=QfG+7l4TuB85erc/f9FBIItMBzREUB+bpRb2EmCqFhvNl5p/5ht8vrvnIbduCB7ta
2bvyvA0tRC9QZ5Nw8mcMI/Iwz9ONHZTmgko2Rvb6oavgbM/q5VMFmt15LYsxf925Jc
fdXZrXyWsW1vpH/msDzoa0+zR0JCMvu2NZLvoZzo=
Message-ID: <232472b55b6237597e2e304741fd823d205d7972.camel@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Thu, 24 Mar 2022 16:38:23 +0100
In-Reply-To: <70b6c5f42bccf41a63acb38922e8d20d4eda3d8a.camel@HIDDEN>
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
<a85be88402b840a95e3c57705a8554eacbd5789a.camel@HIDDEN>
<5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
<70b6c5f42bccf41a63acb38922e8d20d4eda3d8a.camel@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ
X-Spam-Scanner: SpamAssassin 3.003001
X-Spam-Score-relay: -1.9
X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Am Donnerstag, dem 24.03.2022 um 16:05 +0100 schrieb Maxime Devos:
> Liliana Marie Prikler schreef op do 24-03-2022 om 08:22 [+0100]:
> > I agree that breaking up cycles is a good thing, but I disagree
> > with some of the decisions you've made here. For instance, I
> > oppose the use of single-package modules, because those more often
> > than not simply clutter the file system.
>
> There are some other sound applications in (gnu packages audio)
> and (gnu packages music), so maybe I can make a (gnu packages audio-
> apps) module where 'audacity' and other applications like 'calf' can
> reside?
I'm not sure. IIUC, audio should be for audio systems, codecs, etc.
whereas music sounds like a particular niche containing music players
etc. Perhaps the cycle could more appropriately been broken by moving
stuff from music to audio? Alternatively, declaring music as lazy
import as shown in my previous mail might help making these
interdependencies both "cycle-free" and visible. (I'm pretty sure we
also have "sound" lying around somewhere to put more oil into the
fire.)
> For reducing the contribution of (gnu packages compression) on the
> cycle issue, I've (in not yet submitted patched) separated many
> things into (gnu packages compression-xyz), perhaps I can merge
> (gnu packages patools) into (gnu packages compression-xyz)?
Here too, I think a classification into compression algorithms in
compression and backup/archival tools in another file (we do have
backup IIRC) would make the most sense. Though obviously, we'd have to
do compression algorithms implemented in Rust in a special rust-
compression file to avoid circles or use the cycle killer lambda trick.
I'm not sure if "compression-xyz" would be a helpful label, and it
might just become the next root of circular dependencies if abused.
Cheers
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 24 Mar 2022 15:47:02 +0000
Resent-Message-ID: <handler.54539.B54539.164813680529812 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>, 54539 <at> debbugs.gnu.org
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.164813680529812
(code B ref 54539); Thu, 24 Mar 2022 15:47:02 +0000
Received: (at 54539) by debbugs.gnu.org; 24 Mar 2022 15:46:45 +0000
Received: from localhost ([127.0.0.1]:49245 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nXPfg-0007kl-T9
for submit <at> debbugs.gnu.org; Thu, 24 Mar 2022 11:46:45 -0400
Received: from laurent.telenet-ops.be ([195.130.137.89]:57528)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nXPff-0007kd-52
for 54539 <at> debbugs.gnu.org; Thu, 24 Mar 2022 11:46:44 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by laurent.telenet-ops.be with bizsmtp
id AFmh270064UW6Th01FmhiB; Thu, 24 Mar 2022 16:46:41 +0100
Message-ID: <6c9031840667a11465eeefed0a4f0769c3466578.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Thu, 24 Mar 2022 16:46:37 +0100
In-Reply-To: <232472b55b6237597e2e304741fd823d205d7972.camel@HIDDEN>
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
<a85be88402b840a95e3c57705a8554eacbd5789a.camel@HIDDEN>
<5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
<70b6c5f42bccf41a63acb38922e8d20d4eda3d8a.camel@HIDDEN>
<232472b55b6237597e2e304741fd823d205d7972.camel@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-0pveJBfJmIbcbreU7IaW"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1648136801; bh=5zJqhqktO/FoXyiH62rwOW15x5OAKfNjB6d5DD5zCiM=;
h=Subject:From:To:Date:In-Reply-To:References;
b=Uepa2zWz69om5Z/Q/ukHK7PmDkuyy9U5aBhWq8CXC7httNZCNUytX+lspXaR+umx3
Ap8g5Z6xoB5IH50ljX+c+5pFBIWBZQzwIOPHR6iWHj3LXLQcRN2G1YDVS5/AiNEhEf
CYiwumplZ3ofg+dXweZbdKSYP8fwbjh3TV51iQFwXISs4Ra6eEsn9dQV0fNOljiShM
E+uQ91vVisn7CJRVj/6PblsUhhQgAdv44nDKLRFSxzJ5S42/MXe1zXIcuNOnpUg94V
M9Zzufp2/d9owsj6ZPKvNSiT9PlYh/AQOwe6S0R4j0+Z7vcVmQOWLhJb4cJklismTv
scLI9bJo+k68w==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-0pveJBfJmIbcbreU7IaW
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Liliana Marie Prikler schreef op do 24-03-2022 om 16:38 [+0100]:
> > For reducing the contribution of (gnu packages compression) on the
> > cycle issue, I've (in not yet submitted patched) separated many
> > things into (gnu packages compression-xyz), perhaps I can merge
> > (gnu packages patools) into (gnu packages compression-xyz)?
> Here too, I think a classification into compression algorithms in
> compression and backup/archival tools in another file (we do have
> backup IIRC) would make the most sense.=C2=A0 Though obviously, we'd have
> to
> do compression algorithms implemented in Rust in a special rust-
> compression file to avoid circles or use the cycle killer lambda
> trick.
> I'm not sure if "compression-xyz" would be a helpful label, and it
> might just become the next root of circular dependencies if abused.
Except for zpaq, there don't appear to be any backup tools in (gnu
packages compression). There are no rust compression things in
(gnu packages compression) (yet!). But yes, there's some opportunity
for abuse here. There _are_ archival tools in (gnu packages
compression), e.g. tar and unzip. Moving them to (gnu packages
backup) wouldn't bring any benefit though, since they are used by
practically everything.
Anyway, I'll continue trying to break cycles ...
Greetings,
Maxime.
--=-0pveJBfJmIbcbreU7IaW
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjySXRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7gPKAP923TsyKaWfv4R8Yqee7GAwOvjX
V65fuS5avwZk4RnpggD+LwgqR+fpaSDA787Wzjpk5ExVbhoVHCb664ExPEjMTgE=
=1yxR
-----END PGP SIGNATURE-----
--=-0pveJBfJmIbcbreU7IaW--
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: zimoun <zimon.toutoune@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 24 Mar 2022 16:59:02 +0000
Resent-Message-ID: <handler.54539.B54539.16481411404663 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Cc: 54539 <at> debbugs.gnu.org, Maxime Devos <maximedevos@HIDDEN>
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.16481411404663
(code B ref 54539); Thu, 24 Mar 2022 16:59:02 +0000
Received: (at 54539) by debbugs.gnu.org; 24 Mar 2022 16:59:00 +0000
Received: from localhost ([127.0.0.1]:49293 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nXQnc-0001D9-IZ
for submit <at> debbugs.gnu.org; Thu, 24 Mar 2022 12:59:00 -0400
Received: from mail-io1-f49.google.com ([209.85.166.49]:35701)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <zimon.toutoune@HIDDEN>) id 1nXQna-0001Cu-N0
for 54539 <at> debbugs.gnu.org; Thu, 24 Mar 2022 12:58:59 -0400
Received: by mail-io1-f49.google.com with SMTP id p22so6099947iod.2
for <54539 <at> debbugs.gnu.org>; Thu, 24 Mar 2022 09:58:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=T3j8FkYCJNvTKFdkCkWEU8UlHXK4Az7gIfYOJGoBOjM=;
b=HX76Ad2XLN4iQyiVxjoECMLDj4N2/bGsKpl1CZtqu6IAO7BI9XgyukYyrgtkjJCzCZ
gIn0d63HqufT+g6+TBVIo8nqH3vOUVmnhwL9Z6ZM+Sa1VvbCtmYmXfU7WU/3DFkBps17
gmiXoxjIZCRF2lg0Cq1nSbFt13L5FdpAKkWN2+n0RBP22ogUhc0KW43QNJq1OtMkL9Z5
0jjRKgI509E8kkAzUDV9CQ2zIyBAGVKUNiTwX/VCBmU4fFYREk/wRFb/4oaFcCNmkZ1v
ZrbQkSNH5RLN9VUJ2kgUUbJ8Tnoi6HXfuhw8hFANCDZBKOQtPxcsT+1hrnNpeCf4USn9
hpoQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=T3j8FkYCJNvTKFdkCkWEU8UlHXK4Az7gIfYOJGoBOjM=;
b=aPUVPdi7iMOrp2CCHNBLh/Hhq8v4G6Fm2+axZDs7hbH4LfyEXdZZgb3zS0Davck89R
VvYZMkQiLMRfBdDXYoLvMelRVYgF+v41/j+R7cmSso2Hj/37fCvle02okEexUavN52DT
XnpapJAG69WdTAgnxnXUhxz9PKQlBL7lNf46gRq0lk/mf8SjR7Mj5A5CfjbaPEepBd5r
bpkX224fKK+mg1qV0wbSkLpUWPbtxSMHcBKVtTfHKLJgojm8g2k19/7C8TUeSSM/0bvv
Bvl4iGwbwdnw23Rgx7XNOwvYfBqbrTMez5ca3nrIEh+Xj4u/GsaTdsgXgqaEmNTIsl3w
KHBg==
X-Gm-Message-State: AOAM531xlmHmJlXSEu7Q3LAay6f9jCMm1k1IkH/MpBQavm4c5x1BRaIh
SE2WY0Jt1SNquqOQebE/gQsng52OfHxZiQQMuFE=
X-Google-Smtp-Source: ABdhPJywukpT8W2BiHKXFqc6522UDvsuuFlixEueJdaeAJnXrg2lJ+l6Dl+h9qQwe21vPfvgd14HUCvpa9TnLlM4ojs=
X-Received: by 2002:a5e:dc05:0:b0:645:d2cc:3e92 with SMTP id
b5-20020a5edc05000000b00645d2cc3e92mr3439166iok.72.1648141132625; Thu, 24 Mar
2022 09:58:52 -0700 (PDT)
MIME-Version: 1.0
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
<a85be88402b840a95e3c57705a8554eacbd5789a.camel@HIDDEN>
<5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
In-Reply-To: <5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
From: zimoun <zimon.toutoune@HIDDEN>
Date: Thu, 24 Mar 2022 17:58:41 +0100
Message-ID: <CAJ3okZ0q9h=GnHfJ9ucb2Je0PhYuZ4U+V-nq8i8m_yinzO_RaA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi,
On Thu, 24 Mar 2022 at 08:23, Liliana Marie Prikler
<liliana.prikler@HIDDEN> wrote:
> I agree that breaking up cycles is a good thing, but I disagree with
> some of the decisions you've made here. For instance, I oppose the use
> of single-package modules, because those more often than not simply
> clutter the file system.
Well, instead of opinions in the vacuum of matter, we need to profile
and decide on performance report. The number of files and the number
of package per file should consider the performance of:
- compilation by developer
- guix pull
- guix search (or any other)
- guix search --load-path
- etc.
> In either case, declaring all these lazy dependencies near the module
> definition would have the added benefit, that people could see them
> being lazily imported and thus no longer need the #:use-modules
> comment.
I agree that lazyness is a good thing and a good direction. However,
let be pragmatic with what we have now. :-) What are the performance
comparison between breaking many cycles as Maxime is proposing vs
using many 'module-ref' + 'resolve-interface' instead of break?
Cheers,
simon
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: Leo Famulari <leo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 24 Mar 2022 17:06:01 +0000
Resent-Message-ID: <handler.54539.B54539.16481415195459 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Cc: 54539 <at> debbugs.gnu.org, Maxime Devos <maximedevos@HIDDEN>
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.16481415195459
(code B ref 54539); Thu, 24 Mar 2022 17:06:01 +0000
Received: (at 54539) by debbugs.gnu.org; 24 Mar 2022 17:05:19 +0000
Received: from localhost ([127.0.0.1]:49318 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nXQtj-0001Py-M3
for submit <at> debbugs.gnu.org; Thu, 24 Mar 2022 13:05:19 -0400
Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:58535)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <leo@HIDDEN>) id 1nXQth-0001Pf-Fl
for 54539 <at> debbugs.gnu.org; Thu, 24 Mar 2022 13:05:17 -0400
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.west.internal (Postfix) with ESMTP id A4F653201F33;
Thu, 24 Mar 2022 13:05:10 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Thu, 24 Mar 2022 13:05:10 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
h=cc:cc:content-type:date:date:from:from:in-reply-to
:in-reply-to:message-id:mime-version:references:reply-to:sender
:subject:subject:to:to; s=mesmtp; bh=Zbh/9GtsiZ9KYK2Oo/iM+kd+Gut
2BhCsOR9BCXOGaSA=; b=b+dX+7cCszapyi54h+xAxB93inOHFc62TGK/tb2/UsR
/3dBaJTqxdJUxCBmNobDdwyzRyvIYSjs7IvaRY1Zo7UtGJy0v0i7sywIFqQ5O7HM
ygtOEXTy9RSYaT5WZk1f5ZDVfo+yqHYL3yWu9JetMh7ct9ZIZ0s600ZVbgPRyUgE
=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-type:date:date:from:from
:in-reply-to:in-reply-to:message-id:mime-version:references
:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Zbh/9GtsiZ9KYK2Oo
/iM+kd+Gut2BhCsOR9BCXOGaSA=; b=KtggglnnChkXxnPUbpImOXKWyUDt/wdXu
JUL9Eu4xfy6f2VLAqyX19/1TDiGAb6bKMoto15yZ220Slqx4wfNX88iHwcJ14KGr
tvOT1zzNAQJT+ztZ9HN607PX8RE/5fDZIgvffZl+G3YfbLirBM2MYHAljiy6yfh7
KYAGVDdyc5V76sN5XWGAyxvmkHOTULvPy/ig6OfC+qfWONu38lAAfY8gbEnHpXif
KtCPwCmnmrOAn+D4tocjELC1gyYkZbWk69FDvqI5rQi3s3tztT/fAcX54yGC2QUA
ScaJY/olmhOgZZ6uiuPOqZTFWJxnhzXDfKz8VY4kJMIQIlYm+eabw==
X-ME-Sender: <xms:xaQ8YtX1l9k_d6YKgzCzRvgR1Po8s2uXMX07Pfw8OZtLrbzVlcxH4g>
<xme:xaQ8Ytkl48rW1Njq9U3xjpEzXujeoSrxgjbs5Xc3M3Fz3R93vCIwdwk8Lma5mjx_6
sRNV1pbFsH9YG4w_w>
X-ME-Received: <xmr:xaQ8YpZrJICqG8u5aDRUYVoHfJubXHzm-URoyaa8qmcXd1fuYhP6NhgGHw6MDlYFFjldjq1XyCZS9_bnEmdmKsSk>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudegledgledvucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh
rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth
gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev
gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg
hosehfrghmuhhlrghrihdrnhgrmhgv
X-ME-Proxy: <xmx:xaQ8YgX_Vc8qCneKRtAzdkHenjurf-CvzD56E5ezr29UR4MmcaeVTA>
<xmx:xaQ8YnnXmzVkCME8fD0XUD9Qtutv__QcipH6RpBs8YdZazf2goDL0A>
<xmx:xaQ8YtcQZOn2YPkec4tPBXvU63aghUAnCoNsw-RBae9LWP1_Avrm8Q>
<xmx:xqQ8YvsFijVCGP4SCK4Jt9wUFKvCjypTYnidJLaA05odaZdRsfyiLQ>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
24 Mar 2022 13:05:09 -0400 (EDT)
Date: Thu, 24 Mar 2022 13:05:07 -0400
From: Leo Famulari <leo@HIDDEN>
Message-ID: <Yjykw0ikvRY/V9N0@HIDDEN>
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
<a85be88402b840a95e3c57705a8554eacbd5789a.camel@HIDDEN>
<5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
On Thu, Mar 24, 2022 at 08:22:09AM +0100, Liliana Marie Prikler wrote:
> I agree that breaking up cycles is a good thing, but I disagree with
> some of the decisions you've made here. For instance, I oppose the use
> of single-package modules, because those more often than not simply
> clutter the file system.
The file system can hold many files. The Guix codebase is nowhere near
the limit...
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 24 Mar 2022 18:08:02 +0000
Resent-Message-ID: <handler.54539.B54539.164814525311850 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: zimoun <zimon.toutoune@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>
Cc: 54539 <at> debbugs.gnu.org
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.164814525311850
(code B ref 54539); Thu, 24 Mar 2022 18:08:02 +0000
Received: (at 54539) by debbugs.gnu.org; 24 Mar 2022 18:07:33 +0000
Received: from localhost ([127.0.0.1]:49387 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nXRrx-000353-Lf
for submit <at> debbugs.gnu.org; Thu, 24 Mar 2022 14:07:33 -0400
Received: from xavier.telenet-ops.be ([195.130.132.52]:43310)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nXRru-00034r-O1
for 54539 <at> debbugs.gnu.org; Thu, 24 Mar 2022 14:07:31 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by xavier.telenet-ops.be with bizsmtp
id AJ7U2700A4UW6Th01J7UeU; Thu, 24 Mar 2022 19:07:28 +0100
Message-ID: <2b5a3af9bd4ea9ec79ad9f9636ed344a51ba7a81.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Thu, 24 Mar 2022 19:07:23 +0100
In-Reply-To: <CAJ3okZ0q9h=GnHfJ9ucb2Je0PhYuZ4U+V-nq8i8m_yinzO_RaA@HIDDEN>
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
<a85be88402b840a95e3c57705a8554eacbd5789a.camel@HIDDEN>
<5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
<CAJ3okZ0q9h=GnHfJ9ucb2Je0PhYuZ4U+V-nq8i8m_yinzO_RaA@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-UfpMZ+YZPj2Sfkeqv2pK"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1648145248; bh=aVLDLpEHzGvxwagIsa7qwa5ior4GlK5Qy9wfDFnyNWk=;
h=Subject:From:To:Cc:Date:In-Reply-To:References;
b=esTih5wW4nAgWDXZ30vThXeGOATdNnoylkYnYNpw1PV/2dGzyZHX8K0+6ZuXKZM5/
xT9hbEmWkTf502TIQdnCkFr/vVfHcdOcVuVyPmL1CQNSGPRdTKU2Fh8Cvfy0/jfhuy
Z6pPy3h2/tUZ6zmTNIVDL53wG1cUsoj9lCIA20A/vuT58izWkVuzzvyntcSaU71UjM
s0hWbpEBYHRGOELDXsHFyJBOvrWvDbeGf2Um6JMrN4awPqJMK/lnaL9bwclmN6MQN+
pH3F/ASNt5mm1Zs3kvQXwDlY5NVMbrrfpnEfzTHXRp8+Aq3D87Kaevw9wtidcETpoj
OFjtBIex8jSlA==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-UfpMZ+YZPj2Sfkeqv2pK
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
zimoun schreef op do 24-03-2022 om 17:58 [+0100]:
> I agree that lazyness is a good thing and a good direction.=C2=A0 However=
,
> let be pragmatic with what we have now. :-)=C2=A0 What are the performanc=
e
> comparison between breaking many cycles as Maxime is proposing vs
> using many 'module-ref' + 'resolve-interface' instead of break?
Currently this patch series does not improve anything much, according
to "guix graph --type=3Dmodule hello | wc --lines". I'm now introducing
some module-ref+resolve-interface --- it's very convenient, but I'm not
yet at a significant result.
Anyway, restructuring modules and lazy loading can be complementary,
whatever's convenient.
Greetings,
Maxime.
--=-UfpMZ+YZPj2Sfkeqv2pK
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjyzWxccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qyvAQCMzjcLrTbp33oplqHjSbGykB3r
sxV5rKxCbdc6xq1+uwEAwsxLUPd1y8I7e73212q44Ly5wfpgFMlWFf/m0L6aWAs=
=lXjQ
-----END PGP SIGNATURE-----
--=-UfpMZ+YZPj2Sfkeqv2pK--
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 24 Mar 2022 21:51:01 +0000
Resent-Message-ID: <handler.54539.B54539.16481586061690 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 54539 <at> debbugs.gnu.org
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.16481586061690
(code B ref 54539); Thu, 24 Mar 2022 21:51:01 +0000
Received: (at 54539) by debbugs.gnu.org; 24 Mar 2022 21:50:06 +0000
Received: from localhost ([127.0.0.1]:49579 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nXVLK-0000RC-61
for submit <at> debbugs.gnu.org; Thu, 24 Mar 2022 17:50:06 -0400
Received: from xavier.telenet-ops.be ([195.130.132.52]:57786)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nXVLH-0000Qm-8Z
for 54539 <at> debbugs.gnu.org; Thu, 24 Mar 2022 17:50:04 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by xavier.telenet-ops.be with bizsmtp
id AMq12700A4UW6Th01Mq1Zc; Thu, 24 Mar 2022 22:50:01 +0100
Message-ID: <8a4250c11e8bc178dc5da8fe43497af4e0ee1293.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Thu, 24 Mar 2022 22:49:56 +0100
In-Reply-To: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-Z3hGdEz8bw5Kz0SywtD9"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1648158601; bh=/VneI/DuN0Von3n7E7yq3ugfF6LOHdhhveKv682b3+0=;
h=Subject:From:To:Date:In-Reply-To:References;
b=RM4v214CA8rzDTcPNz/48mxENgRni3BYO4gcRWZpers+kZwbC0yik/DnbsHKjkW8p
9R9fey87jPcqT2IAO/go3Jot5USUd37BmtNn2vR/Wwn5MKtMw6hYENLXoQOyinJnEH
XtJbgEvQuupEbXKD+G6BOoBF5hcPIPh68NVfuqRMXVY932y30WSUQWl2KjsDkCHEmI
0TmG2GzvIfwLUO5KgzSWYLQahOMB3B8XF860ick0WWu07YWyTeam+k9FhDu0zQYzn+
/YZwDGp84TeWKJfKAIaUrFuAMaX+M/iwKtx5QYMnyEVCllaD77ETc8qVTt80NUUexn
x38E6i0FvpXBg==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-Z3hGdEz8bw5Kz0SywtD9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Maxime Devos schreef op wo 23-03-2022 om 19:46 [+0100]:
> Import cycles make some packaging things harder and prevent some
> proposed optimisations to "guix pull", let's start eliminating them.
> TBC ...
Status update: previously the output of
"guix graph -t module hello --max-depth=3D9 |wc --lines" reports ~1040
lines. With WIP patches, it now reports 280 lines. I'm gradually
increasing the max-depth and each time investigating how to leave xorg,
gtk, ... out of the output.
Greetings,
Maxime.
--=-Z3hGdEz8bw5Kz0SywtD9
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjznhBccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7kQPAPwPlqj951BHz5xnsZvVlTbZ26MV
sdLCWR/HRu0UKlQsLgD/VadoZ3QysZwliEVcibei/XhkUPaaJuLUPaQ/AK8fOAk=
=UXBT
-----END PGP SIGNATURE-----
--=-Z3hGdEz8bw5Kz0SywtD9--
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 25 Mar 2022 08:45:02 +0000
Resent-Message-ID: <handler.54539.B54539.1648197883612 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxime Devos <maximedevos@HIDDEN>, zimoun <zimon.toutoune@HIDDEN>
Cc: 54539 <at> debbugs.gnu.org
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.1648197883612
(code B ref 54539); Fri, 25 Mar 2022 08:45:02 +0000
Received: (at 54539) by debbugs.gnu.org; 25 Mar 2022 08:44:43 +0000
Received: from localhost ([127.0.0.1]:50050 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nXfYp-00009o-0g
for submit <at> debbugs.gnu.org; Fri, 25 Mar 2022 04:44:43 -0400
Received: from mailrelay.tugraz.at ([129.27.2.202]:62147)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1nXfYn-00009b-In
for 54539 <at> debbugs.gnu.org; Fri, 25 Mar 2022 04:44:42 -0400
Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101])
by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4KPwd158vSz1LZX0;
Fri, 25 Mar 2022 09:44:37 +0100 (CET)
DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4KPwd158vSz1LZX0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at;
s=mailrelay; t=1648197878;
bh=B6g6w/5HeGXZtycN7eBxknrzEGSTe6Yvsd6MfJg+9bQ=;
h=Subject:From:To:Cc:Date:In-Reply-To:References:From;
b=DCZmDE4hlH/Xb8SDHBl/KwGnTOaUgEIV+f+IoizydqoCCHZlJybnfDlX1MP/KlrVa
pV4Q1gMtRUL/gwK5U8VLK/PDoELjvkqAUYEKzvhyLLvuKzVqbcbMke0TVtW7XGMZuJ
3zmooBIj2NxOk+z/L8C5P8Yvc7azhMAvfwKKNdj0=
Message-ID: <84da9090d9dee87855ee4f5b2f5442ad919ea032.camel@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Fri, 25 Mar 2022 09:44:38 +0100
In-Reply-To: <2b5a3af9bd4ea9ec79ad9f9636ed344a51ba7a81.camel@HIDDEN>
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
<a85be88402b840a95e3c57705a8554eacbd5789a.camel@HIDDEN>
<5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
<CAJ3okZ0q9h=GnHfJ9ucb2Je0PhYuZ4U+V-nq8i8m_yinzO_RaA@HIDDEN>
<2b5a3af9bd4ea9ec79ad9f9636ed344a51ba7a81.camel@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ
X-Spam-Scanner: SpamAssassin 3.003001
X-Spam-Score-relay: -1.9
X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Am Donnerstag, dem 24.03.2022 um 19:07 +0100 schrieb Maxime Devos:
> zimoun schreef op do 24-03-2022 om 17:58 [+0100]:
> > I agree that lazyness is a good thing and a good direction.
> > However, let be pragmatic with what we have now. :-) What are the
> > performance comparison between breaking many cycles as Maxime is
> > proposing vs using many 'module-ref' + 'resolve-interface' instead
> > of break?
>
> Currently this patch series does not improve anything much, according
> to "guix graph --type=module hello | wc --lines". I'm now
> introducing some module-ref+resolve-interface --- it's very
> convenient, but I'm not yet at a significant result.
For the record, my suggestion to declare lazily loaded modules near the
top is based on the fact that Maxime's current patch set uses them to
break up cycles in a manner that also requires a comment in the define-
module clause for the sake of clarity. As a nice side effect, it makes
it so that two-liners in the inputs field become one-liners.
The question is (on a per-module basis) whether we consider this cheat
fine or whether we want to move things into different files (and
which). I so far haven't heard a good argument for the case of
audacity I raised. "It breaks cycles" is not good enough when we
consider the potential existence of other cuts (e.g. "audio-apps",
although perhaps a more specific "audio-editors" similar to how we have
"image-viewers" might make more sense), as well as the cheat of lazy
imports.
simon, you raise some important performance metrics, but there is such
a thing as optimizing for the wrong metric. There are other variables
to consider, like time to grep, "does it make sense that X belongs to Y
and Z doesn't", etc., when it comes to ease of contributing. Declaring
some modules banned for a given other module has an adverse effect
here, in my opinion, and thus I claim that we need easily accessible
ways of using those supposedly banned modules.
Btw. regarding style, I think declaring a function @PACKAGE_MODULE,
i.e. a literal '@ followed by the last symbol in the module's name,
would be the easiest, as one could read (@PACKAGE_MODULE arg) as a
shorthand for (@ (gnu packages PACKAGE_MODULE) arg). Somewhat off-
topic, what's the rationale behind not using @ syntax? Does @ have
different semantics from resolve-interface + module-ref?
Cheers
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 25 Mar 2022 08:52:02 +0000
Resent-Message-ID: <handler.54539.B54539.16481982821431 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Leo Famulari <leo@HIDDEN>
Cc: 54539 <at> debbugs.gnu.org, Maxime Devos <maximedevos@HIDDEN>
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.16481982821431
(code B ref 54539); Fri, 25 Mar 2022 08:52:02 +0000
Received: (at 54539) by debbugs.gnu.org; 25 Mar 2022 08:51:22 +0000
Received: from localhost ([127.0.0.1]:50061 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nXffG-0000N1-2e
for submit <at> debbugs.gnu.org; Fri, 25 Mar 2022 04:51:22 -0400
Received: from mailrelay.tugraz.at ([129.27.2.202]:64782)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1nXffE-0000Ms-IK
for 54539 <at> debbugs.gnu.org; Fri, 25 Mar 2022 04:51:20 -0400
Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101])
by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4KPwmj5Dbwz1LZWr;
Fri, 25 Mar 2022 09:51:17 +0100 (CET)
DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4KPwmj5Dbwz1LZWr
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at;
s=mailrelay; t=1648198277;
bh=JV5et0BiHokpK96+nuEWnDgEC4d72tJrVK5Ck4Mednc=;
h=Subject:From:To:Cc:Date:In-Reply-To:References:From;
b=Psxf6/A8h6mgXnnujFoP+u4dgv2kyw5HWLnRqX8GSIELGntx7x01vw6tkRBztp/4d
zslwfCjw4OnuSOjub/4kRiRPdfrjsymekQlleTafvxcYdFHa/LTOdo0DWGu/aCEDMH
a89cYmDFEYRKUERp7SrJN050wpf7V1Uyx/5x/JI4=
Message-ID: <b678a54be5faee9b1ff739b73bd87036077b53e8.camel@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Fri, 25 Mar 2022 09:51:16 +0100
In-Reply-To: <Yjykw0ikvRY/V9N0@HIDDEN>
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
<a85be88402b840a95e3c57705a8554eacbd5789a.camel@HIDDEN>
<5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
<Yjykw0ikvRY/V9N0@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ
X-Spam-Scanner: SpamAssassin 3.003001
X-Spam-Score-relay: -1.9
X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Am Donnerstag, dem 24.03.2022 um 13:05 -0400 schrieb Leo Famulari:
> On Thu, Mar 24, 2022 at 08:22:09AM +0100, Liliana Marie Prikler
> wrote:
> > I agree that breaking up cycles is a good thing, but I disagree
> > with some of the decisions you've made here. For instance, I
> > oppose the use of single-package modules, because those more often
> > than not simply clutter the file system.
>
> The file system can hold many files. The Guix codebase is nowhere
> near the limit...
That's not a good argument, though. Theoretically, you could have one
file per package, or even one folder per package as the Gentoo folks
do. Clearly, this is not an appeal to file system limits, but to
limitations of humans and their tools. Have you tried exploring
/gnu/store? Merely loading it takes a considerable amount of time.
Cheers
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 25 Mar 2022 10:28:01 +0000
Resent-Message-ID: <handler.54539.B54539.164820402511928 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>, 54539 <at> debbugs.gnu.org
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.164820402511928
(code B ref 54539); Fri, 25 Mar 2022 10:28:01 +0000
Received: (at 54539) by debbugs.gnu.org; 25 Mar 2022 10:27:05 +0000
Received: from localhost ([127.0.0.1]:50214 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nXh9t-00036K-D5
for submit <at> debbugs.gnu.org; Fri, 25 Mar 2022 06:27:05 -0400
Received: from andre.telenet-ops.be ([195.130.132.53]:47946)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nXh9q-00035r-CI
for 54539 <at> debbugs.gnu.org; Fri, 25 Mar 2022 06:27:03 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by andre.telenet-ops.be with bizsmtp
id AaT02700E4UW6Th01aT0dy; Fri, 25 Mar 2022 11:27:00 +0100
Message-ID: <9dc81d586944ac9cdd7505ed8e0cafdb95bceb7b.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Fri, 25 Mar 2022 11:26:54 +0100
In-Reply-To: <232472b55b6237597e2e304741fd823d205d7972.camel@HIDDEN>
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
<a85be88402b840a95e3c57705a8554eacbd5789a.camel@HIDDEN>
<5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
<70b6c5f42bccf41a63acb38922e8d20d4eda3d8a.camel@HIDDEN>
<232472b55b6237597e2e304741fd823d205d7972.camel@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-XjUD3mUeGlcPyBDpwNv+"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1648204020; bh=un+VPPAfcKzuZklFknezQ/6qcGHU9QB8ShfA6hZmnbE=;
h=Subject:From:To:Date:In-Reply-To:References;
b=RrPn4ySgcUk4REPn2KnPoxreMRG/OYbhQgCPFsflqNEozHj1WUNbLdZLgICXXNXM4
zw32ThXZrYm9ZbVyHRPDqKcY+tZfaXyef1RFHiCMoqq1r2vY9XVelXism70HHzJYqt
9AxUOV6owwNNqBzTH0UfR5I01WJ7qq4No3GDR/Nuhl2CbwxD4ZEm5WnVaroXMBRSxr
z71DlidHAJtdiBG0/EqT5ac9z6/z9W/prrI/t5/ere0L6CNA1c5uKOHPmL/d0I2xJB
2oUDK1g7RRT/SMG/oTtZxpbnCWO4eBTdNDmFurxzVmTdMB0BA5FQZr+o+2FVZRNVoU
V2/B1EzICz4Dg==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-XjUD3mUeGlcPyBDpwNv+
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Liliana Marie Prikler schreef op do 24-03-2022 om 16:38 [+0100]:
> Am Donnerstag, dem 24.03.2022 um 16:05 +0100 schrieb Maxime Devos:
> > Liliana Marie Prikler schreef op do 24-03-2022 om 08:22 [+0100]:
> > > I agree that breaking up cycles is a good thing, but I disagree
> > > with some of the decisions you've made here.=C2=A0 For instance, I
> > > oppose the use of single-package modules, because those more often
> > > than not simply clutter the file system.
> >=20
> > There are some other sound applications in (gnu packages audio)
> > and (gnu packages music), so maybe I can make a (gnu packages audio-
> > apps) module where 'audacity' and other applications like 'calf' can
> > reside?
> I'm not sure. IIUC, audio should be for audio systems, codecs, etc.
> whereas music sounds like a particular niche containing music players
> etc.
> [...]
I'm not sure where the =E2=80=98I'm not sure=E2=80=99 comes from --- audaci=
ty is not an
audio system like pulseaudio or alsa, not a codec implementation like
libvorbis, and it is a sound player (and editor), so IIUC, audacity
does not fit into (gnu packages audio).
While it can be used for modifying and playing music, it is more
general than that, hence the suggestion of (gnu packages audio-apps)
(where some other packages can be moved to as well, maybe 'gnaural'?).
Though granted, it's difficult to make a strict distinction between
audio and music.
> Perhaps the cycle could more appropriately been broken by moving
> stuff from music to audio?
(gnu packages music) is full of applications using gtk+ or gles or the
like. Moving them to (gnu packages audio) would make (gnu packages
audio) depend on (gnu packages gtk) and friends, which seems counter-
productive to me.
Greetings,
Maxime.
--=-XjUD3mUeGlcPyBDpwNv+
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYj2Y7hccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7r9TAQDm2MtmjvUEkBqTQr1kj7QWr4Kd
Vsh3X1O2j42AfQ2/hgEAqaXwv3//EubdEfSmX+BGbeuRItDtJ3h6fI46WA3fBQM=
=T7AB
-----END PGP SIGNATURE-----
--=-XjUD3mUeGlcPyBDpwNv+--
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 25 Mar 2022 11:48:02 +0000
Resent-Message-ID: <handler.54539.B54539.164820883928598 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxime Devos <maximedevos@HIDDEN>, 54539 <at> debbugs.gnu.org
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.164820883928598
(code B ref 54539); Fri, 25 Mar 2022 11:48:02 +0000
Received: (at 54539) by debbugs.gnu.org; 25 Mar 2022 11:47:19 +0000
Received: from localhost ([127.0.0.1]:50356 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nXiPX-0007RC-0y
for submit <at> debbugs.gnu.org; Fri, 25 Mar 2022 07:47:19 -0400
Received: from mailrelay.tugraz.at ([129.27.2.202]:7347)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1nXiPU-0007R2-AF
for 54539 <at> debbugs.gnu.org; Fri, 25 Mar 2022 07:47:17 -0400
Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101])
by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4KQ0gh6jh5z3wZ9;
Fri, 25 Mar 2022 12:47:12 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at;
s=mailrelay; t=1648208833;
bh=ZmYPnoeWRz1pyecG7AlCTvQXBDb0D2siEQHpdHRFBK0=;
h=Subject:From:To:Date:In-Reply-To:References;
b=YDqYzA38/SQZl37ZD8SPCHbwKA7JLAusQ3Jlh4fuZMERugc4pqjcqMentIZHYWLoy
UB78pMZ+WkduB8HIjEFJm0PuA1hF3R+Ai0IMHwuu6JERLYXL0D8pYzcw1r6Faw/Rys
x4sCfVrhbyS+s3RRDThGh2VEg77GBAGVBi4v2JH8=
Message-ID: <3e47544944b522f78002dd628a772216958e0ad9.camel@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Fri, 25 Mar 2022 12:47:12 +0100
In-Reply-To: <9dc81d586944ac9cdd7505ed8e0cafdb95bceb7b.camel@HIDDEN>
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
<a85be88402b840a95e3c57705a8554eacbd5789a.camel@HIDDEN>
<5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
<70b6c5f42bccf41a63acb38922e8d20d4eda3d8a.camel@HIDDEN>
<232472b55b6237597e2e304741fd823d205d7972.camel@HIDDEN>
<9dc81d586944ac9cdd7505ed8e0cafdb95bceb7b.camel@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ
X-Spam-Scanner: SpamAssassin 3.003001
X-Spam-Score-relay: -1.9
X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Am Freitag, dem 25.03.2022 um 11:26 +0100 schrieb Maxime Devos:
> Liliana Marie Prikler schreef op do 24-03-2022 om 16:38 [+0100]:
> > Am Donnerstag, dem 24.03.2022 um 16:05 +0100 schrieb Maxime Devos:
> >
> > > Liliana Marie Prikler schreef op do 24-03-2022 om 08:22 [+0100]:
> > > > I agree that breaking up cycles is a good thing, but I disagree
> > > > with some of the decisions you've made here. For instance, I
> > > > oppose the use of single-package modules, because those more
> > > > often than not simply clutter the file system.
> > >
> > > There are some other sound applications in (gnu packages audio)
> > > and (gnu packages music), so maybe I can make a (gnu packages
> > > audio-apps) module where 'audacity' and other applications like
> > > 'calf' can reside?
> > I'm not sure. IIUC, audio should be for audio systems, codecs,
> > etc. whereas music sounds like a particular niche containing music
> > players etc.
> > [...]
>
> I'm not sure where the ‘I'm not sure’ comes from --- audacity is not
> an audio system like pulseaudio or alsa, not a codec implementation
> like libvorbis, and it is a sound player (and editor), so IIUC,
> audacity does not fit into (gnu packages audio).
It's not particularly specific to audacity in this case, it's that I
think that "-app" does not make for a useful distinction. Consider
fluidsynth. Is it an app, a library, something else? If fluidsynth
was causing circular imports and moving it to audio-synthesizers fixed
things, that'd be fine by me. gnaural could also fit into
synthesizers. However, putting both in the same file might still be an
issue from a cycle perspective, because the latter needs gtk, whereas
the former is content with having just glib (although that one appears
benign on surface, as at the very least gtk does not audio directly).
> While it can be used for modifying and playing music, it is more
> general than that, hence the suggestion of (gnu packages audio-apps)
> (where some other packages can be moved to as well, maybe
> 'gnaural'?).
>
> Though granted, it's difficult to make a strict distinction between
> audio and music.
>
> > Perhaps the cycle could more appropriately been broken by moving
> > stuff from music to audio?
>
> (gnu packages music) is full of applications using gtk+ or gles or
> the like. Moving them to (gnu packages audio) would make (gnu
> packages audio) depend on (gnu packages gtk) and friends, which seems
> counter-productive to me.
That's the status quo (through gnaural and audacity for example). To
make a more educated guess, which cycle do we aim to address here? Is
there a meaningful cut that can be made (e.g. the offending packages
are all "audio editors", "audio synthesizers", etc.) or do we have to
separate good and bad based on their inputs?
Cheers
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 25 Mar 2022 14:14:01 +0000
Resent-Message-ID: <handler.54539.B54539.164821758612832 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>, 54539 <at> debbugs.gnu.org
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.164821758612832
(code B ref 54539); Fri, 25 Mar 2022 14:14:01 +0000
Received: (at 54539) by debbugs.gnu.org; 25 Mar 2022 14:13:06 +0000
Received: from localhost ([127.0.0.1]:52129 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nXkgb-0003Ku-T6
for submit <at> debbugs.gnu.org; Fri, 25 Mar 2022 10:13:06 -0400
Received: from michel.telenet-ops.be ([195.130.137.88]:53704)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1nXkgZ-0003Kk-1k
for 54539 <at> debbugs.gnu.org; Fri, 25 Mar 2022 10:13:04 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by michel.telenet-ops.be with bizsmtp
id AeD12700A4UW6Th06eD165; Fri, 25 Mar 2022 15:13:01 +0100
Message-ID: <ff888453c3b11f0fe77e00d0d27d9854bddd22d9.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Fri, 25 Mar 2022 15:12:56 +0100
In-Reply-To: <3e47544944b522f78002dd628a772216958e0ad9.camel@HIDDEN>
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
<a85be88402b840a95e3c57705a8554eacbd5789a.camel@HIDDEN>
<5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
<70b6c5f42bccf41a63acb38922e8d20d4eda3d8a.camel@HIDDEN>
<232472b55b6237597e2e304741fd823d205d7972.camel@HIDDEN>
<9dc81d586944ac9cdd7505ed8e0cafdb95bceb7b.camel@HIDDEN>
<3e47544944b522f78002dd628a772216958e0ad9.camel@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-FZHw3KVJAB8lcqOXyUBM"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1648217581; bh=ZI5SYmMQ1Q8h/W13lqiFdYTbHdBh6QNtRy4J7zyb31U=;
h=Subject:From:To:Date:In-Reply-To:References;
b=dGCkqAxDgQkFbYvWgoFngeXZRzzdXLTZxME5/1RY01p3KTz3Ka1JcuTi5x9IBLPm7
4lXBH5u/UnuMtHLBtKN1s5PrzCwo1ezZ1B8Wi2774xLFfjgxJnatDJzNMWLBmgdhEi
nwwL/mrIRl0OWf1DX1TNBG8dfF0cW+BgVd6I3dRC9+h/JXBc52a4/oYUQ7jTXvr8QA
iYcQbpc/0q+gGk/WcPtuv7U7+uN1QVJbecOXMtl6FYGQTmK4mUjCMNDmt+dyNpxfT3
YfyDw7C0tICt5RaPadYSFAE+tg5opQn6nDhNGok08MzwUPszjoqZ3RLQRSbFrzaL76
tnD0Z1AB9DhtQ==
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-FZHw3KVJAB8lcqOXyUBM
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Liliana Marie Prikler schreef op vr 25-03-2022 om 12:47 [+0100]:
> That's the status quo (through gnaural and audacity for example).=C2=A0 T=
o
> make a more educated guess, which cycle do we aim to address here?=C2=A0 =
Is
> there a meaningful cut that can be made (e.g. the offending packages
> are all "audio editors", "audio synthesizers", etc.) or do we have to
> separate good and bad based on their inputs?
Some cycles:
(gnu packages pulseaudio) -> (gnu packages audio) -> (gnu packages gtk)
/(gnu packages qt)-> (gnu packages pulseaudio) + the world
(gnu packages pulseaudio) -> (gnu packages audio) -> (gnu packages
webkit) -> (gnu packages gstreamer) + the world -> (gnu packages
pulseaudio) + the world
Suggested cut: audio libraries like flac, libogg, libvorbis, opus,
wildmidi, vo-aacenc, tinyalsa ... can go in (gnu packages audio), other
things go somewhere else, especially if they need expensive imports.
Greetings,
Maxime.
--=-FZHw3KVJAB8lcqOXyUBM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYj3N6BccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7v6UAQCWtpEWEGHceh+JtnqhPF3r9XwX
4BmPQoQM871NI3vBxAD/ZJ+yNKPCI+Msfj+02dH3ROcdadLZkdaZktXRml+bcgc=
=zZCv
-----END PGP SIGNATURE-----
--=-FZHw3KVJAB8lcqOXyUBM--
X-Loop: help-debbugs@HIDDEN
Subject: [bug#54539] [PATCH 0/6] Start breaking up import cycles
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 25 Mar 2022 14:28:02 +0000
Resent-Message-ID: <handler.54539.B54539.164821845822481 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 54539
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxime Devos <maximedevos@HIDDEN>, 54539 <at> debbugs.gnu.org
Received: via spool by 54539-submit <at> debbugs.gnu.org id=B54539.164821845822481
(code B ref 54539); Fri, 25 Mar 2022 14:28:02 +0000
Received: (at 54539) by debbugs.gnu.org; 25 Mar 2022 14:27:38 +0000
Received: from localhost ([127.0.0.1]:52144 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nXkug-0005qX-KT
for submit <at> debbugs.gnu.org; Fri, 25 Mar 2022 10:27:38 -0400
Received: from mailrelay.tugraz.at ([129.27.2.202]:58402)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1nXkue-0005qN-Gk
for 54539 <at> debbugs.gnu.org; Fri, 25 Mar 2022 10:27:37 -0400
Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101])
by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4KQ4DZ3Pc7z3xj7;
Fri, 25 Mar 2022 15:27:26 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at;
s=mailrelay; t=1648218446;
bh=rIX3ipMp+N4j9NQAH1695VQFRIOwBdRmIA5oGwDLIr8=;
h=Subject:From:To:Date:In-Reply-To:References;
b=BbgFqZHwtjulx4/7HclOq36TIabMFhIGFEISvOBnl2wjDdwQJLg+41avQBVx1oclV
FvIiD9q8A3s4SbEGm9/67kBv4C08vTwtLFiLSwpfZLS0E13fmVfFwKDthETLMJ4/Gq
xMlKqVaD15CdOzNO1khaJdnV3Lwmvv+QUQxzn5N8=
Message-ID: <56df912130f0b984fd7193f1255a3674a043f028.camel@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Fri, 25 Mar 2022 15:27:25 +0100
In-Reply-To: <ff888453c3b11f0fe77e00d0d27d9854bddd22d9.camel@HIDDEN>
References: <5a87d6f772ff7424cb6fccea7c45276bef7797aa.camel@HIDDEN>
<a85be88402b840a95e3c57705a8554eacbd5789a.camel@HIDDEN>
<5ab234b577c15dd50c36aaf427cce593404b52dc.camel@HIDDEN>
<70b6c5f42bccf41a63acb38922e8d20d4eda3d8a.camel@HIDDEN>
<232472b55b6237597e2e304741fd823d205d7972.camel@HIDDEN>
<9dc81d586944ac9cdd7505ed8e0cafdb95bceb7b.camel@HIDDEN>
<3e47544944b522f78002dd628a772216958e0ad9.camel@HIDDEN>
<ff888453c3b11f0fe77e00d0d27d9854bddd22d9.camel@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ
X-Spam-Scanner: SpamAssassin 3.003001
X-Spam-Score-relay: -1.9
X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Am Freitag, dem 25.03.2022 um 15:12 +0100 schrieb Maxime Devos:
> Liliana Marie Prikler schreef op vr 25-03-2022 om 12:47 [+0100]:
> > That's the status quo (through gnaural and audacity for example).
> > To make a more educated guess, which cycle do we aim to address
> > here?
> > Is there a meaningful cut that can be made (e.g. the offending
> > packages are all "audio editors", "audio synthesizers", etc.) or do
> > we have to separate good and bad based on their inputs?
>
> Some cycles:
>
> (gnu packages pulseaudio) -> (gnu packages audio) -> (gnu packages
> gtk)
> /(gnu packages qt)-> (gnu packages pulseaudio) + the world
>
> (gnu packages pulseaudio) -> (gnu packages audio) -> (gnu packages
> webkit) -> (gnu packages gstreamer) + the world -> (gnu packages
> pulseaudio) + the world
>
> Suggested cut: audio libraries like flac, libogg, libvorbis, opus,
> wildmidi, vo-aacenc, tinyalsa ... can go in (gnu packages audio),
> other things go somewhere else, especially if they need expensive
> imports.
Hmm, is it all codecs? In that case, I'd suggest making a smaller (gnu
packages audio-codecs), that can be used by (gnu packages audio-
systems) [including (tiny)alsa, pulseaudio, jack, ...] that can be used
by the rest of the world. Having that, we could move "the rest" into
audio-xyz (or let it simply remain "audio"). Would that be actionable?
(Note: There might still be debate w.r.t. the above split when
considering synthesizers, as they are technically not codecs, but we
still need to distinguish between low-level synths like fluidsynth and
wildmidi vs. full-on sound stations.)
(Note2: Of course, this assumes that neither audio-codecs nor audio-
systems will ever need to import any of the rust stuff. *sigh*)
Cheers
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.