GNU bug report logs - #54678
[PATCH] gnu: Add emacs-pyimport.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Sat, 2 Apr 2022 03:00:02 UTC

Severity: normal

Tags: patch

Done: Maxime Devos <maximedevos <at> telenet.be>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54678 in the body.
You can then email your comments to 54678 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#54678; Package guix-patches. (Sat, 02 Apr 2022 03:00:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to jgart <jgart <at> dismail.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 02 Apr 2022 03:00:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: Add emacs-pyimport.
Date: Fri,  1 Apr 2022 22:58:56 -0400
* gnu/packages/emacs-xyz.scm (emacs-pyimport): New variable.

Hi Guixers,

Here is emacs-pyimport.

Also available as a pre-release at https://whereis.みんな/

all best,

jgart
---
 gnu/packages/emacs-xyz.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bc9a9f1c28..5b17fd9b65 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -30828,6 +30828,43 @@ (define-public emacs-org-modern
 headlines, keywords, tables and source blocks.")
    (license license:gpl3+)))
 
+(define-public emacs-pyimport
+  (let ((commit "a6f63cf7ed93f0c0f7c207e6595813966f8852b9")
+        (revision "0"))
+    (package
+      (name "emacs-pyimport")
+      (version (git-version "1.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/Wilfred/pyimport")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1q5gqhvh4zq5dy8vns694warcz48j1hdnxg16sjck4gsi9xivbvs"))))
+      (build-system emacs-build-system)
+      (inputs
+        (list python-pyflakes))
+      (propagated-inputs
+        (list emacs-dash emacs-s emacs-shut-up))
+      (arguments
+        (list #:phases
+              #~(modify-phases %standard-phases
+                  (add-after 'unpack 'patch-pyflakes-executable
+                    (lambda* (#:key inputs #:allow-other-keys)
+                      (let ((python-pyflakes (assoc-ref inputs "python-pyflakes")))
+                        (make-file-writable "pyimport.el")
+                        (substitute* "pyimport.el"
+                          (("\"pyflakes")
+                           (string-append "\"" python-pyflakes "/bin/pyflakes")))))))))
+      (home-page "https://github.com/Wilfred/pyimport")
+      (synopsis "Manage Python imports from Emacs")
+      (description
+"@code{emacs-pyimport} manages python imports from Emacs via @code{python-pyflakes}.")
+      (license license:gpl3+)))) ; License is in pyimport.el
+
 (define-public emacs-osm
   (package
     (name "emacs-osm")
-- 
2.34.0





Information forwarded to guix-patches <at> gnu.org:
bug#54678; Package guix-patches. (Mon, 04 Apr 2022 18:15:01 GMT) Full text and rfc822 format available.

Message #8 received at 54678 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: jgart <jgart <at> dismail.de>, 54678 <at> debbugs.gnu.org
Subject: Re: [bug#54678] [PATCH] gnu: Add emacs-pyimport.
Date: Mon, 04 Apr 2022 20:14:50 +0200
[Message part 1 (text/plain, inline)]
jgart via Guix-patches via schreef op vr 01-04-2022 om 22:58 [-0400]:
> +                      (let ((python-pyflakes (assoc-ref inputs "python-pyflakes")))
> +                        (make-file-writable "pyimport.el")
> +                        (substitute* "pyimport.el"
> +                          (("\"pyflakes")
> +                           (string-append "\"" python-pyflakes "/bin/pyflakes")))))))))

Input labels can be avoided here:

  (substitute* ...
    ...
    (string-append ... (search-input-file inputs "bin/pyflakes")))

Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#54678; Package guix-patches. (Tue, 05 Apr 2022 20:52:01 GMT) Full text and rfc822 format available.

Message #11 received at 54678 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 54678 <at> debbugs.gnu.org
Cc: Maxime Devos <maximedevos <at> telenet.be>, jgart <jgart <at> dismail.de>
Subject: [PATCH v2] gnu: Add emacs-pyimport.
Date: Tue,  5 Apr 2022 16:48:40 -0400
* gnu/packages/emacs-xyz.scm (emacs-pyimport): New variable.

Hi Maxime,

Here's a v2 with your suggestions.

Thanks for the code review.

all best,

jgart

---
 gnu/packages/emacs-xyz.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bc9a9f1c28..dcd1f07916 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -30828,6 +30828,43 @@ (define-public emacs-org-modern
 headlines, keywords, tables and source blocks.")
    (license license:gpl3+)))
 
+(define-public emacs-pyimport
+  (let ((commit "a6f63cf7ed93f0c0f7c207e6595813966f8852b9")
+        (revision "0"))
+    (package
+      (name "emacs-pyimport")
+      (version (git-version "1.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/Wilfred/pyimport")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1q5gqhvh4zq5dy8vns694warcz48j1hdnxg16sjck4gsi9xivbvs"))))
+      (build-system emacs-build-system)
+      (inputs
+        (list python-pyflakes))
+      (propagated-inputs
+        (list emacs-dash emacs-s emacs-shut-up))
+      (arguments
+        (list #:phases
+              #~(modify-phases %standard-phases
+                  (add-after 'unpack 'patch-pyflakes-executable
+                    (lambda* (#:key inputs #:allow-other-keys)
+                      (let ((pyflakes (search-input-file inputs "/bin/pyflakes")))
+                        (make-file-writable "pyimport.el")
+                        (substitute* "pyimport.el"
+                          (("\"pyflakes")
+                           (string-append "\"" pyflakes)))))))))
+      (home-page "https://github.com/Wilfred/pyimport")
+      (synopsis "Manage Python imports from Emacs")
+      (description
+"@code{emacs-pyimport} manages python imports from Emacs via @code{python-pyflakes}.")
+      (license license:gpl3+)))) ; License is in pyimport.el
+
 (define-public emacs-osm
   (package
     (name "emacs-osm")
-- 
2.34.0





Information forwarded to guix-patches <at> gnu.org:
bug#54678; Package guix-patches. (Mon, 09 May 2022 17:50:02 GMT) Full text and rfc822 format available.

Message #14 received at 54678 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: jgart <jgart <at> dismail.de>, 54678 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Add emacs-pyimport.
Date: Mon, 09 May 2022 19:49:16 +0200
[Message part 1 (text/plain, inline)]
jgart schreef op di 05-04-2022 om 16:48 [-0400]:
> +      (license license:gpl3+)))) ; License is in pyimport.el

The license header is present, but the actual license text is missing,
and the GPL requires:

> and give all recipients a copy of this License along with the Program.

Looks like upstream forgot a file ...

Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#54678; Package guix-patches. (Tue, 07 Jun 2022 22:17:01 GMT) Full text and rfc822 format available.

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>
Cc: Maxime Devos <maximedevos <at> telenet.be>, 54678-done <at> debbugs.gnu.org,
 jgart <jgart <at> dismail.de>
Subject: Re: [bug#54678] [PATCH v2] gnu: Add emacs-pyimport.
Date: Wed, 08 Jun 2022 00:15:53 +0200
Hello,

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-pyimport): New variable.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou




Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Tue, 07 Jun 2022 22:17:02 GMT) Full text and rfc822 format available.

Notification sent to jgart <jgart <at> dismail.de>:
bug acknowledged by developer. (Tue, 07 Jun 2022 22:17:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#54678; Package guix-patches. (Wed, 08 Jun 2022 07:53:01 GMT) Full text and rfc822 format available.

Message #25 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>, jgart via Guix-patches via
 <guix-patches <at> gnu.org>
Cc: 54678-done <at> debbugs.gnu.org, jgart <jgart <at> dismail.de>
Subject: Re: [bug#54678] [PATCH v2] gnu: Add emacs-pyimport.
Date: Wed, 08 Jun 2022 09:52:01 +0200
[Message part 1 (text/plain, inline)]
reopen 54678
thanks

Nicolas Goaziou schreef op wo 08-06-2022 om 00:15 [+0200]:
> jgart via Guix-patches via <guix-patches <at> gnu.org> writes:
> 
> > * gnu/packages/emacs-xyz.scm (emacs-pyimport): New variable.
> 
> Applied. Thank you.

What about <https://issues.guix.gnu.org/54678#3>?

Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 08 Jun 2022 07:53:02 GMT) Full text and rfc822 format available.

Reply sent to Maxime Devos <maximedevos <at> telenet.be>:
You have taken responsibility. (Wed, 08 Jun 2022 07:53:02 GMT) Full text and rfc822 format available.

Notification sent to jgart <jgart <at> dismail.de>:
bug acknowledged by developer. (Wed, 08 Jun 2022 07:53:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#54678; Package guix-patches. (Fri, 10 Jun 2022 09:09:02 GMT) Full text and rfc822 format available.

Message #35 received at 54678 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 54678 <at> debbugs.gnu.org, 54678-done <at> debbugs.gnu.org, jgart <jgart <at> dismail.de>
Subject: Re: [bug#54678] [PATCH v2] gnu: Add emacs-pyimport.
Date: Fri, 10 Jun 2022 11:08:31 +0200
Hello,

Maxime Devos <maximedevos <at> telenet.be> writes:

> reopen 54678
> thanks
>
> Nicolas Goaziou schreef op wo 08-06-2022 om 00:15 [+0200]:
>> jgart via Guix-patches via <guix-patches <at> gnu.org> writes:
>> 
>> > * gnu/packages/emacs-xyz.scm (emacs-pyimport): New variable.
>> 
>> Applied. Thank you.
>
> What about <https://issues.guix.gnu.org/54678#3>?

I asked a similar question for a different package some months (years?)
ago. The decision was that we should assume good faith from the author,
even if the licensing is not perfect. In this situation, upstream intent
is clear, so there is no real issue.

Of course, it would be nice to help upstream have a correct licensing
process.

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#54678; Package guix-patches. (Fri, 10 Jun 2022 09:09:02 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#54678; Package guix-patches. (Fri, 10 Jun 2022 15:06:02 GMT) Full text and rfc822 format available.

Message #41 received at 54678 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 54678 <at> debbugs.gnu.org, 54678-done <at> debbugs.gnu.org, jgart <jgart <at> dismail.de>
Subject: Re: [bug#54678] [PATCH v2] gnu: Add emacs-pyimport.
Date: Fri, 10 Jun 2022 17:05:47 +0200
[Message part 1 (text/plain, inline)]
Nicolas Goaziou schreef op vr 10-06-2022 om 11:08 [+0200]:
> [...]
> I asked a similar question for a different package some months (years?)
> ago. The decision was that we should assume good faith from the author,
> even if the licensing is not perfect. In this situation, upstream intent
> is clear, so there is no real issue.
> 
> Of course, it would be nice to help upstream have a correct licensing
> process.
> 
> Regards,

Thanks for your answer, I'll keep it in mind.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#54678; Package guix-patches. (Fri, 10 Jun 2022 15:06:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 09 Jul 2022 11:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 263 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.