GNU bug report logs - #54766
[PATCH] 28.1.0; Native comp: Inherit working directory for sub processes (MS Windows)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54766 in the body.
You can then email your comments to 54766 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robin Putters <robin.putters <at> keronic.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] 28.1.0; Native comp: Inherit working directory for sub
 processes (MS Windows) 
Date: Thu, 7 Apr 2022 14:35:57 +0000

[Message part 1 (text/plain, inline)]

On MS Windows systems, where the Emacs executable is typically not in the PATH, creating the async sub processes for the native compiler will fail because they are started in a random working directory. The included patch will inherit the working directory from the parent emacs process by setting default-directory before creating the sub process.    

Robin Putters

[Pat2409.diff (application/octet-stream, attachment)]

Message #8 received at 54766 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robin Putters <robin.putters <at> keronic.com>
Cc: 54766 <at> debbugs.gnu.org
Subject: Re: bug#54766: [PATCH] 28.1.0;
 Native comp: Inherit working directory for sub processes (MS Windows)
Date: Thu, 07 Apr 2022 19:08:29 +0300

> From: Robin Putters <robin.putters <at> keronic.com>
> Date: Thu, 7 Apr 2022 14:35:57 +0000
> 
> On MS Windows systems, where the Emacs executable is typically not in the PATH, creating the async sub processes for the native compiler will fail because they are started in a random working directory. The included patch will inherit the working directory from the parent emacs process by setting default-directory before creating the sub process.    

Please tell more about the failure and its reasons.  The compilation
command does this:

                   (process (make-process
                             :name (concat "Compiling: " source-file)
                             :buffer (with-current-buffer
                                         (get-buffer-create
                                          comp-async-buffer-name)
                                       (setf buffer-read-only t)
			               (current-buffer))
                             :command (list
                                       (expand-file-name invocation-name
                                                         invocation-directory)
                                       "--batch" "-l" temp-file)

So the program we invoked already has its executable file name
expanded relative to invocation-directory, and we shouldn't need PATH
at all.  What am I missing?

Message #13 received at 54766 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Robin Putters <robin.putters <at> keronic.com>, 54766 <at> debbugs.gnu.org
Subject: Re: bug#54766: [PATCH] 28.1.0; Native comp: Inherit working
 directory for sub processes (MS Windows) 
Date: Sat, 23 Apr 2022 19:16:04 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> So the program we invoked already has its executable file name
> expanded relative to invocation-directory, and we shouldn't need PATH
> at all.  What am I missing?

I don't understand either -- using nativecomp Emacs without having the
Emacs executable in PATH works just fine for me.

Robin, what was the actual error messages you were seeing?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #16 received at 54766 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Robin Putters <robin.putters <at> keronic.com>, 54766 <at> debbugs.gnu.org
Subject: Re: bug#54766: [PATCH] 28.1.0; Native comp: Inherit working
 directory for sub processes (MS Windows) 
Date: Sun, 22 May 2022 13:27:22 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I don't understand either -- using nativecomp Emacs without having the
> Emacs executable in PATH works just fine for me.
>
> Robin, what was the actual error messages you were seeing?

More information was requested, but no response was given within a
month, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.