GNU bug report logs -
#54895
[PATCH 0/2] Fix failing build of cava
Previous Next
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54895 in the body.
You can then email your comments to 54895 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#54895
; Package
guix-patches
.
(Tue, 12 Apr 2022 21:51:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Tue, 12 Apr 2022 21:51:01 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
Hi Guix,
this patch series fixes the failing build¹ for cava and uses the newer
G-expressions for the arguments.
¹ https://ci.guix.gnu.org/build/620722/details
Daniel Meißner (2):
gnu: cava: Use G-expressions.
gnu: cava: Fix build failure
gnu/packages/audio.scm | 66 +++++++++++++++++++++++-------------------
1 file changed, 37 insertions(+), 29 deletions(-)
--
2.34.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#54895
; Package
guix-patches
.
(Tue, 12 Apr 2022 21:53:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 54895 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/audio.scm (cava)[arguments]: Use G-expressions.
---
gnu/packages/audio.scm | 55 +++++++++++++++++++++---------------------
1 file changed, 27 insertions(+), 28 deletions(-)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 13e0f02837..fd85b20855 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -4589,35 +4589,34 @@ (define-public cava
(base32
"1mziklmqifhnb4kg9ia2r56r8wjn6xp40bkpf484hsgqvnrccl86"))))
(build-system gnu-build-system)
- (native-inputs
- (list autoconf automake libtool))
- (inputs
- (list fftw ncurses pulseaudio))
+ (native-inputs (list autoconf automake libtool))
+ (inputs (list fftw ncurses pulseaudio))
(arguments
- `(#:configure-flags
- (list (string-append "PREFIX=" %output)
- (string-append "FONT_DIR=" %output "/share/consolefonts"))
- #:make-flags
- (let ((lib (string-append %output "/lib")))
- (list (string-append "cava_LDFLAGS = -L" lib " -Wl,-rpath " lib)))
- #:phases
- (modify-phases %standard-phases
- (replace 'bootstrap
- (lambda* (#:key outputs #:allow-other-keys)
- (setenv "HOME" (getcwd))
- (invoke "sh" "autogen.sh")))
- (add-before 'build 'make-cava-ldflags
- (lambda* (#:key outputs #:allow-other-keys)
- (mkdir-p (string-append (assoc-ref outputs "out") "/lib"))
- #t))
- (add-after 'install 'data
- (lambda* (#:key outputs #:allow-other-keys)
- (for-each (lambda (file)
- (install-file file
- (string-append (assoc-ref outputs "out")
- "/share/doc/examples")))
- (find-files "example_files"))
- #t)))))
+ (list #:configure-flags
+ #~(list (string-append "PREFIX="
+ #$output)
+ (string-append "FONT_DIR="
+ #$output "/share/consolefonts"))
+ #:make-flags
+ #~(let ((lib (string-append #$output "/lib")))
+ (list (string-append "cava_LDFLAGS = -L" lib " -Wl,-rpath " lib)))
+ #:phases
+ #~(modify-phases %standard-phases
+ (replace 'bootstrap
+ (lambda _
+ (setenv "HOME"
+ (getcwd))
+ (invoke "sh" "autogen.sh")))
+ (add-before 'build 'make-cava-ldflags
+ (lambda _
+ (mkdir-p (string-append #$output "/lib"))))
+ (add-after 'install 'data
+ (lambda _
+ (for-each (lambda (file)
+ (install-file file
+ (string-append #$output
+ "/share/doc/examples")))
+ (find-files "example_files")))))))
(home-page "https://karlstav.github.io/cava/")
(synopsis "Console audio visualizer for ALSA, MPD, and PulseAudio")
(description "C.A.V.A. is a bar audio spectrum visualizer for the terminal
--
2.34.0
Information forwarded
to
guix-patches <at> gnu.org
:
bug#54895
; Package
guix-patches
.
(Tue, 12 Apr 2022 21:53:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 54895 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/audio.scm (cava)[source]: Remove bundled iniparser.
(cava)[inputs]: Add iniparser.
---
gnu/packages/audio.scm | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index fd85b20855..9b7d723921 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -110,6 +110,7 @@ (define-module (gnu packages audio)
#:use-module (gnu packages qt)
#:use-module (gnu packages rdf)
#:use-module (gnu packages readline)
+ #:use-module (gnu packages samba)
#:use-module (gnu packages sdl)
#:use-module (gnu packages serialization)
#:use-module (gnu packages sqlite)
@@ -4587,10 +4588,18 @@ (define-public cava
(file-name (git-file-name name version))
(sha256
(base32
- "1mziklmqifhnb4kg9ia2r56r8wjn6xp40bkpf484hsgqvnrccl86"))))
+ "1mziklmqifhnb4kg9ia2r56r8wjn6xp40bkpf484hsgqvnrccl86"))
+ (modules '((guix build utils)))
+ (snippet
+ #~(begin
+ (delete-file-recursively "iniparser")
+ (substitute* "configure.ac"
+ (("AC_CONFIG_FILES\\(iniparser/Makefile\\)") ""))
+ (substitute* "Makefile.am"
+ (("SUBDIRS = iniparser") ""))))))
(build-system gnu-build-system)
(native-inputs (list autoconf automake libtool))
- (inputs (list fftw ncurses pulseaudio))
+ (inputs (list fftw ncurses pulseaudio iniparser))
(arguments
(list #:configure-flags
#~(list (string-append "PREFIX="
@@ -4599,7 +4608,7 @@ (define-public cava
#$output "/share/consolefonts"))
#:make-flags
#~(let ((lib (string-append #$output "/lib")))
- (list (string-append "cava_LDFLAGS = -L" lib " -Wl,-rpath " lib)))
+ (list (string-append "cava_LDFLAGS = -L" lib " -Wl,-rpath " lib " -lrt")))
#:phases
#~(modify-phases %standard-phases
(replace 'bootstrap
--
2.34.0
Reply sent
to
Ludovic Courtès <ludo <at> gnu.org>
:
You have taken responsibility.
(Fri, 06 May 2022 08:32:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de>
:
bug acknowledged by developer.
(Fri, 06 May 2022 08:32:01 GMT)
Full text and
rfc822 format available.
Message #16 received at 54895-done <at> debbugs.gnu.org (full text, mbox):
Hi,
Daniel Meißner <daniel.meissner-i4k <at> ruhr-uni-bochum.de> skribis:
> this patch series fixes the failing build¹ for cava and uses the newer
> G-expressions for the arguments.
>
> ¹ https://ci.guix.gnu.org/build/620722/details
>
> Daniel Meißner (2):
> gnu: cava: Use G-expressions.
> gnu: cava: Fix build failure
Applied, thanks!
Ludo’.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Fri, 03 Jun 2022 11:24:08 GMT)
Full text and
rfc822 format available.
This bug report was last modified 1 year and 319 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.