GNU bug report logs - #54933
[patch] Add Liquid War 6

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54933 in the body.
You can then email your comments to 54933 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: zamfofex <zamfofex <at> twdb.moe>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [patch] Add Liquid War 6
Date: Thu, 14 Apr 2022 07:00:29 -0300 (BRT)

[Message part 1 (text/plain, inline)]

[liquidwar6.diff (text/x-patch, attachment)]

Message #10 received at 54933-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: zamfofex <zamfofex <at> twdb.moe>
Cc: 54933-done <at> debbugs.gnu.org
Subject: Re: bug#54933: [patch] Add Liquid War 6
Date: Fri, 29 Apr 2022 23:14:22 +0200

Hi,

zamfofex <zamfofex <at> twdb.moe> skribis:

> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index de398c297f..8765f70761 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm

Applied with mostly cosmetic changes:

> +    (inputs
> +      (list guile-2.0 zlib expat sqlite ncurses readline curl doxygen python-2
> +            libxslt perl graphviz glu libcaca
> +            (sdl-union (list sdl sdl-image sdl-ttf sdl-mixer))))

I passed it through ‘guix style’ and moved ‘doxygen’ to ‘native-inputs’
as suggested by ‘guix lint’.

> +    (arguments
> +      '(#:configure-flags
> +         (list
> +           "--enable-allinone"
> +           "CFLAGS=-Wno-error"
> +           (string-append "CPPFLAGS="
> +             "-I" (search-input-directory %build-inputs "include/SDL")))))

I used a gexp and ‘this-package-input’here.

> +    (description
> +      (string-append
> +        "Liquid War 6 is a unique multiplayer wargame. Your army is a blob of "
> +        "liquid and you have to try and eat your opponents. Rules are very "
> +        "simple yet original, they have been invented by Thomas Colcombet."))

I changed that to a literal string:

  https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html

For future patches please take a look at:

  https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html

In particular, please use ‘git format-patch’ and possibly ‘git
send-email’ to send patches.  That ensures the commit log and authorship
are preserved and makes the reviewer’s life easier.  :-)

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.