GNU bug report logs - #54973
Blender has no denoiser

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54973 in the body.
You can then email your comments to 54973 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Haider Mirza <x7and7 <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: Blender has no denoiser
Date: Sat, 16 Apr 2022 14:36:06 +0100

[Message part 1 (text/plain, inline)]

Blender in Guix has no denoiser, as Blender is not compiled with 
OpenImageDenoise or so Blender tells me.
Therefore, the denoiser just renders a black image if it's 
enabled.

Can you try and add this functionality as packaging 
OpenImageDenoise has turned out to be a massive pain.

[Message part 2 (text/html, inline)]

Message #8 received at 54973 <at> debbugs.gnu.org (full text, mbox):

From: raingloom <raingloom <at> riseup.net>
To: Haider Mirza <x7and7 <at> gmail.com>
Cc: 54973 <at> debbugs.gnu.org
Subject: Re: bug#54973: Blender has no denoiser
Date: Sat, 16 Apr 2022 18:28:53 +0200

On Sat, 16 Apr 2022 14:36:06 +0100
Haider Mirza <x7and7 <at> gmail.com> wrote:

> Blender in Guix has no denoiser, as Blender is not compiled with 
> OpenImageDenoise or so Blender tells me.
> Therefore, the denoiser just renders a black image if it's 
> enabled.
> 
> Can you try and add this functionality as packaging 
> OpenImageDenoise has turned out to be a massive pain.

Can you send the WIP version of your OID package? Even if it's broken,
the person who tries to package it would benefit from seeing what
approach(es) have failed so far, so they don't repeat the same mistakes.
(That person could be me if no one gets on it. But I have uni stuff so
I'm not gonna promise anything.)

There are also other optional dependencies of Blender that would be
nice to have packages for.

Message #11 received at 54973 <at> debbugs.gnu.org (full text, mbox):

From: Haider Mirza <x7and7 <at> gmail.com>
To: 54973 <at> debbugs.gnu.org
Subject: Re:Blender has no denoiser 
Date: Sat, 16 Apr 2022 17:49:28 +0100

[Message part 1 (text/plain, inline)]

This is currently very broken but this is what I had:
It is requires a package called ISPC.

(define-module (oidn)
 #:use-module (guix packages)
 ;; #:use-module (gnu packages base)
 #:use-module (gnu packages gcc)
 #:use-module (gnu packages python)
 #:use-module (gnu packages tbb)
 #:use-module (gnu packages cmake)
 #:use-module (guix git-download)
 #:use-module (guix build-system cmake)
 #:use-module ((guix licenses) #:prefix license:))

(define-public oidn
 (package
  (name "oidn")
  (version "1.4.3")
  (source
   (origin
    (method git-fetch)
    (uri (git-reference
          (url "https://github.com/OpenImageDenoise/oidn.git")
          (commit (string-append "v" version))))
    (file-name (git-file-name name version))
    (sha256
     (base32 
     "14zga8xd7pxwhp50n36n0c8j12vdn92i90wf6nz868nlqvlpyakk"))))
  (build-system cmake-build-system)
  (inputs
   (list cmake gcc python tbb))     ; for scripts/MakeHeader.py
  (home-page "https://www.openimagedenoise.org/")
  (synopsis "A denoiser")
  (description
   "open source library of high-performance, high-quality 
   denoising filters for images rendered with ray tracing.")
  (license license:asl2.0)))

[Message part 2 (text/html, inline)]

Message #14 received at 54973 <at> debbugs.gnu.org (full text, mbox):

From: raingloom <raingloom <at> riseup.net>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: 54973 <at> debbugs.gnu.org, Haider Mirza <x7and7 <at> gmail.com>, help-guix <at> gnu.org
Subject: Re: Blender has no denoiser
Date: Sat, 16 Apr 2022 23:04:28 +0200

On Sat, 16 Apr 2022 18:30:19 +0000
Ekaitz Zarraga <ekaitz <at> elenq.tech> wrote:

> Hi,
> 
> ------- Original Message -------
> On Saturday, April 16th, 2022 at 6:29 PM, Haider Mirza
> <x7and7 <at> gmail.com> wrote:
> 
> 
> > The Guix installation of Blender has no denoiser.
> > Blender's compositor says that Blender is compiled without
> > "OpenImageDenoise"
> >
> > Last time I checked OIDN (OpenImageDenoise) is free software and
> > all it's dependancies are also.
> > I tried to packaged OIDN but it just ended up being a massive pain
> > and It's depenadancy (ispc) just refused to compile.
> > Can you suggest some sort of solution (The IRC has no answers)
> > --
> > Haider Mirza via Emacs on a GNU/Linux system  
> 
> I had a similar issue in the past with blender, it was missing a
> dependency and I had to package it myself. It is what it is.
> Sometimes you need to package this kind of software, it's full of
> compilation errors and so on. The only thing we can do is to help you
> package it. Can you share the package you developed?
> 

It was already sent in the CC'd issue. I think it's best to continue
the discussion there, instead of forking it onto two lists.

Message #17 received at 54973 <at> debbugs.gnu.org (full text, mbox):

From: Haider Mirza <x7and7 <at> gmail.com>
To: 54973 <at> debbugs.gnu.org
Subject: Re: Blender has no denoiser 
Date: Sat, 16 Apr 2022 18:17:10 +0100

[Message part 1 (text/plain, inline)]

I had tried to package ISPC but CMake doesnt seem to work with me.

(define-module (ispc)
 #:use-module (guix packages)
 #:use-module (gnu packages bison)
 #:use-module (gnu packages llvm)
 #:use-module (gnu packages python)
 #:use-module (gnu packages flex)
 #:use-module (gnu packages m4)
 #:use-module (gnu packages version-control)
 #:use-module (gnu packages cmake)
 #:use-module (guix git-download)
 #:use-module (guix build-system cmake)
 #:use-module ((guix licenses) #:prefix license:))

(define-public ispc
 (package
  (name "ispc")
  (version "1.17.0")
  (source
   (origin
    (method git-fetch)
    (uri (git-reference
          (url "https://github.com/ispc/ispc.git")
          (commit (string-append "v" version))))
    (file-name (git-file-name name version))
    (sha256
     (base32 
     "1klk1mhxjvyhzf1kqznimdb2f96czp76k8riv8yda87gfrk7cmfn"))))
  (build-system cmake-build-system)
  (inputs
   (list cmake python bison flex m4 git clang))     ; for 
   scripts/MakeHeader.py
  (home-page "https://www.openimagedenoise.org/")
  (synopsis "compiler for a variant of the C programming 
  language")
  (description
   "ispc is a compiler for a variant of the C programming 
   language, with extensions for single program, multiple data 
   programming.")
  (license license:bsd-3)))

[Message part 2 (text/html, inline)]

Message #20 received at 54973 <at> debbugs.gnu.org (full text, mbox):

From: Haider Mirza <haider <at> haider.gq>
To: 54973 <at> debbugs.gnu.org
Subject: Re: Blender has no denoiser
Date: Fri, 10 Jun 2022 20:19:45 +0100

[Message part 1 (text/plain, inline)]

I will close this Issue as it is open for pretty much no reason.
Thank you to Raingloom and anyone else who responded!

I might send a patch in the future tackling this problem.

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 54973 <at> debbugs.gnu.org (full text, mbox):

From: Haider Mirza <haider <at> haider.gq>
To: 54973 <at> debbugs.gnu.org
Subject: control message for bug #54973
Date: Fri, 10 Jun 2022 20:21:11 +0100

[Message part 1 (text/plain, inline)]

close 54973
quit

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 54973-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Haider Mirza <haider <at> haider.gq>
Cc: 54973-done <at> debbugs.gnu.org
Subject: Re: bug#54973: control message for bug #54973
Date: Sat, 11 Jun 2022 00:09:02 +0200

[Message part 1 (text/plain, inline)]

Hullo,

Haider Mirza 写道：
> close 54973
> quit

This kind of message works only if sent to the ‘control@’ address 
instead of the bug address.

The (IMO easier) way to close issues is to ‘Reply’ and simply edit 
the address to add ‘-done’ or ‘-close’ after the bug number, as 
I've done with this message.

Thanks!

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.