GNU bug report logs - #54976
29.0.50; Eshell breaks when unknown entries in eshell-modules-list

Previous Next

Package: emacs;

Reported by: Sean Whitton <spwhitton <at> spwhitton.name>

Date: Sat, 16 Apr 2022 20:51:01 UTC

Severity: normal

Found in version 29.0.50

Fixed in version 29.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 54976 in the body.
You can then email your comments to 54976 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#54976; Package emacs. (Sat, 16 Apr 2022 20:51:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Sean Whitton <spwhitton <at> spwhitton.name>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 16 Apr 2022 20:51:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Eshell breaks when unknown entries in eshell-modules-list
Date: Sat, 16 Apr 2022 13:50:39 -0700
Hello,

Suppose you put this in your init.el:

    (add-to-list 'eshell-modules-list 'eshell-elecslash)

because you want to use the new em-elecslash.el module I'm working on.

Then if you try to M-x eshell on an older version of Emacs which lacks
em-elecslash, Eshell will fail to initialise at all.

It is easy add a guard (when (locate-library ...)) or similar, but this
is not possible if you have added eshell-elecslash using the customise
interface.  In that case, by enabling the module, youq just make your
init unusable with older Emacs.

It would be better to print a warning, say, rather than error.

-- 
Sean Whitton




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#54976; Package emacs. (Sun, 19 Jun 2022 14:58:01 GMT) Full text and rfc822 format available.

Message #8 received at 54976 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: 54976 <at> debbugs.gnu.org
Subject: Re: bug#54976: 29.0.50;
 Eshell breaks when unknown entries in eshell-modules-list
Date: Sun, 19 Jun 2022 07:57:38 -0700
close 54976 29.1
thanks

Sean Whitton <spwhitton <at> spwhitton.name> writes:

> Suppose you put this in your init.el:
>
>     (add-to-list 'eshell-modules-list 'eshell-elecslash)
>
> because you want to use the new em-elecslash.el module I'm working on.
>
> Then if you try to M-x eshell on an older version of Emacs which lacks
> em-elecslash, Eshell will fail to initialise at all.
>
> It is easy add a guard (when (locate-library ...)) or similar, but this
> is not possible if you have added eshell-elecslash using the customise
> interface.  In that case, by enabling the module, youq just make your
> init unusable with older Emacs.
>
> It would be better to print a warning, say, rather than error.

I agree that it makes more sense to warn here instead of refusing to
start.  So I have now done that in Emacs 29 (commit d6b4803850).




bug marked as fixed in version 29.1, send any further explanations to 54976 <at> debbugs.gnu.org and Sean Whitton <spwhitton <at> spwhitton.name> Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Sun, 19 Jun 2022 14:58:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#54976; Package emacs. (Sun, 19 Jun 2022 22:27:02 GMT) Full text and rfc822 format available.

Message #13 received at 54976 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 54976 <at> debbugs.gnu.org
Subject: Re: bug#54976: 29.0.50; Eshell breaks when unknown entries in
 eshell-modules-list
Date: Sun, 19 Jun 2022 15:26:20 -0700
Hello,

On Sun 19 Jun 2022 at 07:57am -07, Stefan Kangas wrote:

> close 54976 29.1
> thanks
>
> Sean Whitton <spwhitton <at> spwhitton.name> writes:
>
>> Suppose you put this in your init.el:
>>
>>     (add-to-list 'eshell-modules-list 'eshell-elecslash)
>>
>> because you want to use the new em-elecslash.el module I'm working on.
>>
>> Then if you try to M-x eshell on an older version of Emacs which lacks
>> em-elecslash, Eshell will fail to initialise at all.
>>
>> It is easy add a guard (when (locate-library ...)) or similar, but this
>> is not possible if you have added eshell-elecslash using the customise
>> interface.  In that case, by enabling the module, youq just make your
>> init unusable with older Emacs.
>>
>> It would be better to print a warning, say, rather than error.
>
> I agree that it makes more sense to warn here instead of refusing to
> start.  So I have now done that in Emacs 29 (commit d6b4803850).

Many thanks for this!

-- 
Sean Whitton




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 18 Jul 2022 11:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 254 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.