GNU bug report logs - #54977
29.0.50; Customising eshell-modules-list means you won't get new default entries

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: minor; Reported by: Sean Whitton <spwhitton@HIDDEN>; Keywords: confirmed; dated Sat, 16 Apr 2022 20:56:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Added tag(s) confirmed. Request was from Stefan Kangas <stefan@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Severity set to 'minor' from 'wishlist' Request was from Stefan Kangas <stefan@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Severity set to 'wishlist' from 'normal' Request was from Stefan Kangas <stefan@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 54977 <at> debbugs.gnu.org:


Received: (at 54977) by debbugs.gnu.org; 18 Apr 2022 05:07:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 18 01:07:56 2022
Received: from localhost ([127.0.0.1]:37751 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ngJcC-0005d6-In
	for submit <at> debbugs.gnu.org; Mon, 18 Apr 2022 01:07:56 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:50193)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <spwhitton@HIDDEN>) id 1ngJcB-0005cs-26
 for 54977 <at> debbugs.gnu.org; Mon, 18 Apr 2022 01:07:55 -0400
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 0E2A75C00C2;
 Mon, 18 Apr 2022 01:07:50 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute4.internal (MEProxy); Mon, 18 Apr 2022 01:07:50 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name;
 h=cc:cc:content-type:date:date:from:from:in-reply-to
 :in-reply-to:message-id:mime-version:references:reply-to:sender
 :subject:subject:to:to; s=fm3; t=1650258470; x=1650344870; bh=7b
 YDLt8eoJDh2/GU3cjnF8fWW+Lz1V2QKyG6hmL50So=; b=AFksOoYTznbONF9JjY
 Wq4vzSov2dfSi4Z70nIgVAQ3SZtoKZ8pU92etkNXJVSiL1y/wOYVrWe41Ykj+FpO
 rAIf+YESs3hq8WqD42yL+Zj1UjHNwzvOi1DhvTMPxA0MA9YIOVpg11wOo8KF0FA2
 LOvGFkyeAT7NNWRJdG4tDY6WU4DyTEPZYz/U5HZ/d0/ddNZELg0n0syR+qYqKHk7
 73GK/q8LhG9lQXYxAlhlShYVYSK+OpX5TKfOsqiFjSMi3n5f7nOQoG9jekAZQ0LY
 XmpK1Cbnu0jB00xevQ0iHzgC/KV/uVgMzabNjS3qaIP/k74CjDkuBwT0gqx5svaZ
 lBGg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1650258470; x=
 1650344870; bh=7bYDLt8eoJDh2/GU3cjnF8fWW+Lz1V2QKyG6hmL50So=; b=u
 vh9KpsoocvgrqJeovm3kuOTwsilgwJ+U9IzZbP1QdWr0wploU8MydvAtz9fBdOX7
 KtrEQ1ZX1v8gFpr6ZbghaWlf6QBasnGpJAAiHT1OiNTHFa7jgVA0d74NgwuHKf2R
 v9Kw4NZAGeFTaTS+Ce/pQdCFFlJ45qrXp/gUizsT55ALGsoOv/vDApEsq8QBLE+S
 +cgu4xzcgg4g223CpE6zva2I1/4EF1Sw//Z8M2uG8+cfG6rbQ2VQmbBhj6q2v8Pt
 x8Akq/UOh0whBK9oKGNbsIxcu5g0CVHtQQYAIcIlNwPdodcSHTtMNZy0qmrc92ZA
 c3FzRxNSwi8WvzUGsCOKA==
X-ME-Sender: <xms:JfJcYg9VCaSx0AohPqy9e6Je-wKi_IsU2VME-0ky7Y1BsbdJOo6uBw>
 <xme:JfJcYovNLu5BWk0pLSLh-8cSix-AerFU_hbUy3LwY5waLwRCMTRZ5K_ZRurlDLsDV
 r_LBlQ6a6tKlIMbaw>
X-ME-Received: <xmr:JfJcYmC-HHROzi4xgylUAjnzc6NRiYXURFUtFwgOcafhLPTipEf5rrKepZOr3ExxWcmDuyqSWXkPBjZy8nOVm1XG8TpZSts>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrvddttddgkeeiucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufgjfhgffffkgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu
 hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne
 cuggftrfgrthhtvghrnhepleeggefgvdeijedvhfdugfegtefgkeekueeileejjeehudeg
 geefteeghfeuffeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh
 hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv
X-ME-Proxy: <xmx:JfJcYge7qkg4lWxTnZJO94rnHgkFazLXXD6SAVHBqAHFXBDVyctYEQ>
 <xmx:JfJcYlOwcQ0SfhpBk0OUra5tN3YlcBRYCIpGBUlbDpZGQyXlqPXgcQ>
 <xmx:JfJcYqlBPeUFhIGWzp6pxT1GMcmuYnvDq8N6wh-Okx_8XILzp97_TQ>
 <xmx:JvJcYnVHHx6LiQyCzcQFjo4c7aJ2uk3GzjF067PWPP7-dGbGK0uDSA>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 18 Apr 2022 01:07:49 -0400 (EDT)
Received: by athena.silentflame.com (Postfix, from userid 1000)
 id 02A681B76D4; Mon, 18 Apr 2022 05:07:49 +0000 (UTC)
From: Sean Whitton <spwhitton@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#54977: 29.0.50; Customising eshell-modules-list means you
 won't get new default entries
In-Reply-To: <83a6ckz3br.fsf@HIDDEN>
References: <87a6ckkath.fsf@HIDDEN> <83a6ckz3br.fsf@HIDDEN>
User-Agent: Emacs/29.0.50 (x86_64-pc-linux-gnu)
Date: Sun, 17 Apr 2022 22:07:48 -0700
Message-ID: <8735ibx9ln.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 54977
Cc: 54977 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello,

On Sun 17 Apr 2022 at 08:28am +03, Eli Zaretskii wrote:

>> From: Sean Whitton <spwhitton@HIDDEN>
>> Date: Sat, 16 Apr 2022 13:55:22 -0700
>>
>> Suppose that you use the customisation interface to enable the
>> eshell-rebind module, and save the result in your init.  Now upstream
>> Emacs gains a new on-by-default module, e.g. the recently added
>> em-extpipe.  While everyone who hasn't customised eshell-modules-list
>> gets the new module automatically, you'll have to customise the variable
>> again, and you can't even just tick a box to add it, as with the other
>> truly optional modules, but must manually insert it at the end of the
>> list.  This is no good.
>>
>> How about using two separate defcustoms for these two kinds of entry?
>
> One other idea is to have the default modules not mentioned
> explicitly, but instead have some kind of placeholder which stands for
> all the default modules.  Similar to some path variables that treat an
> empty or nil list member as standing for the default value.

That would be nicer than two defcustoms, I think.  Possibly it could be
an uber-module which just pulls in the defaults.

-- 
Sean Whitton




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#54977; Package emacs. Full text available.

Message received at 54977 <at> debbugs.gnu.org:


Received: (at 54977) by debbugs.gnu.org; 17 Apr 2022 05:50:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 17 01:50:18 2022
Received: from localhost ([127.0.0.1]:34890 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nfxne-00067Z-8v
	for submit <at> debbugs.gnu.org; Sun, 17 Apr 2022 01:50:18 -0400
Received: from mail-pg1-f178.google.com ([209.85.215.178]:33655)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jporterbugs@HIDDEN>) id 1nfxnc-00067K-LG
 for 54977 <at> debbugs.gnu.org; Sun, 17 Apr 2022 01:50:17 -0400
Received: by mail-pg1-f178.google.com with SMTP id k14so13555612pga.0
 for <54977 <at> debbugs.gnu.org>; Sat, 16 Apr 2022 22:50:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=subject:to:references:from:message-id:date:mime-version:in-reply-to
 :content-language:content-transfer-encoding;
 bh=tENvl69Fr9x/QdcjO8N9rXb6qm3C5QUMdDrYAxfMeUs=;
 b=H5DbU8OBRtmpwgtZqPRFxieZ/DBGGhKsIIVF+pTcbQM+ThSo5biExWHRMxBCTIR/KT
 ECEA5I/hOT4a4hckE4dds48Yu0oT9iA6gPPh3PXknyMAM8WVVuMw47IL8bdYElef+TnA
 KUSA1VOFrTqjnzC2d5cOZjxXZYXfSrbLevtvBXflcRWg/rYD55AvG3vudF2I4o8AFXxP
 QrxhOwgNF1PErEquMPIiYFvlRy0i9LHVWcrkoPDddO5uR4UBs+nVn3/YB/pb0RtNu9LF
 7pa4JQPqzVK5Ef4w/IHUFlKeAUFIlM1Sm7T19goZLgPNheRxYC2Vm1qYVfuCpQnvo+tz
 nJaQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:subject:to:references:from:message-id:date
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=tENvl69Fr9x/QdcjO8N9rXb6qm3C5QUMdDrYAxfMeUs=;
 b=AS+P8OBSMYhbjYZKe6ZHbFUdjfLHK44Z3lhqayR35Ojq96CI/yJlQQn9EJVXa57gGZ
 /eHBZVq66aNlNlc0MEnEAKNRKRveGXhQKmCmC/bHbobgHR1jmEKEo21Pi9eg0FCV1lAz
 KV8CatTPcEPfL8lBlZaRBL0gafyAKW7Sb370KexNIATyfx23HbgKw+ZFrEhThM7kXMcQ
 yeOprl1cWUjLIl9+sj48dxF5Thf97QtKped/RUkgV2T/xar0eYYVvenxdC2ocdf3ObO5
 Tz3HW0Kig8HsUuDRn75a8JEu7voHtOwd7UsVjX6fI8YT1boSysvyjxiqMNtNEhqAmnFR
 xvXA==
X-Gm-Message-State: AOAM533dxEVhnwBXrxzwzW67b09FuokAFsSc3VF1EI1HEVrVNDkf4pYD
 hyAiJAP+txrVrdLZtW3Th0LEAHf/MqU=
X-Google-Smtp-Source: ABdhPJzcMyQyHLa+TxgUGlccmorpA2fF07mY819yumw6RZfErUO/PUk2eIOhAxwVE4tVpdLrGvkOEA==
X-Received: by 2002:a05:6a00:190a:b0:4fa:e4e9:7126 with SMTP id
 y10-20020a056a00190a00b004fae4e97126mr6253640pfi.65.1650174610773; 
 Sat, 16 Apr 2022 22:50:10 -0700 (PDT)
Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com.
 [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id
 q60-20020a17090a17c200b001cd567fecaesm9022510pja.26.2022.04.16.22.50.10
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 16 Apr 2022 22:50:10 -0700 (PDT)
Subject: Re: bug#54977: 29.0.50; Customising eshell-modules-list means you
 won't get new default entries
To: Sean Whitton <spwhitton@HIDDEN>, 54977 <at> debbugs.gnu.org
References: <87a6ckkath.fsf@HIDDEN>
 <34785f50-0c61-332a-180a-4fe7038fee8b@HIDDEN>
 <87ilr8xpwp.fsf@HIDDEN>
From: Jim Porter <jporterbugs@HIDDEN>
Message-ID: <a7baaceb-a1a6-952e-8587-e0d882c44454@HIDDEN>
Date: Sat, 16 Apr 2022 22:50:10 -0700
MIME-Version: 1.0
In-Reply-To: <87ilr8xpwp.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 54977
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 4/16/2022 10:03 PM, Sean Whitton wrote:
> On Sat 16 Apr 2022 at 10:01pm -07, Jim Porter wrote:
> 
>> Maybe it would be good to provide something like that for users of the
>> Customize interface as well? Then any defcustom that takes a list
>> could either be customized to have an exact set of elements (as it is
>> today), or to have "the default, but with FOO added and BAR removed".
> 
> That might be a good enhancement, but I think the Eshell case is a bit
> simpler -- using two defcustoms mostly solves it.

True, for this case it might be simpler to use two defcustoms, 
especially if it turns out that adding the necessary bits to the 
Customize interface proves difficult. I've never looked at the Customize 
internals, so I'm not sure how hard that would be (though I'm sure it's 
considerably harder than adding a defcustom to Eshell).

Still, enhancing Customize would also (probably) solve this issue for 
`erc-modules' and `org-modules', and I'm sure lots of third-party 
packages would benefit too.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#54977; Package emacs. Full text available.

Message received at 54977 <at> debbugs.gnu.org:


Received: (at 54977) by debbugs.gnu.org; 17 Apr 2022 05:28:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 17 01:28:34 2022
Received: from localhost ([127.0.0.1]:34873 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nfxSc-0005TE-IL
	for submit <at> debbugs.gnu.org; Sun, 17 Apr 2022 01:28:34 -0400
Received: from eggs.gnu.org ([209.51.188.92]:54182)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1nfxSa-0005T0-0c
 for 54977 <at> debbugs.gnu.org; Sun, 17 Apr 2022 01:28:32 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:44596)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1nfxSU-0004IZ-2g; Sun, 17 Apr 2022 01:28:26 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=RndToq+2mbA2+ClTCTtYAuJWsOM83BPUJpy2EoQT14g=; b=NuPW7zQ+dJKz
 ux+22F905VQMf4NeIKI7p4tnifLAtwLkUG3MzLhUxD05n99cAytlhDlfFpDR2bPR71rIcevVb7ke5
 MGGlxWmEW/RDOVodgtWUV1sh5ojKv5NlPhnWVlAMqGMdLYWmrRAGMx+XLapyaJlRQhj80N02Ftc3R
 +R/jeHg/tkHaibf19HyVL8dD/404IiWnAcSKAq1sawmL/5vRUzMokXsmR5GAzrtx+5iiWngP9nZSy
 VxkUA1jxZxsSeV8kdxIv1KUE5bVfnF8A11zmaX4cVOYjnHEJOO3NnthkfL0F+gsP7NhaXIqslyMZ9
 tzHz09GF+0E83Y3MkQv9GQ==;
Received: from [87.69.77.57] (port=2113 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1nfxST-0007Jt-4M; Sun, 17 Apr 2022 01:28:25 -0400
Date: Sun, 17 Apr 2022 08:28:08 +0300
Message-Id: <83a6ckz3br.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Sean Whitton <spwhitton@HIDDEN>
In-Reply-To: <87a6ckkath.fsf@HIDDEN> (message from Sean
 Whitton on Sat, 16 Apr 2022 13:55:22 -0700)
Subject: Re: bug#54977: 29.0.50;
 Customising eshell-modules-list means you won't get new default
 entries
References: <87a6ckkath.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 54977
Cc: 54977 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Sean Whitton <spwhitton@HIDDEN>
> Date: Sat, 16 Apr 2022 13:55:22 -0700
> 
> Suppose that you use the customisation interface to enable the
> eshell-rebind module, and save the result in your init.  Now upstream
> Emacs gains a new on-by-default module, e.g. the recently added
> em-extpipe.  While everyone who hasn't customised eshell-modules-list
> gets the new module automatically, you'll have to customise the variable
> again, and you can't even just tick a box to add it, as with the other
> truly optional modules, but must manually insert it at the end of the
> list.  This is no good.
> 
> How about using two separate defcustoms for these two kinds of entry?

One other idea is to have the default modules not mentioned
explicitly, but instead have some kind of placeholder which stands for
all the default modules.  Similar to some path variables that treat an
empty or nil list member as standing for the default value.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#54977; Package emacs. Full text available.

Message received at 54977 <at> debbugs.gnu.org:


Received: (at 54977) by debbugs.gnu.org; 17 Apr 2022 05:03:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 17 01:03:26 2022
Received: from localhost ([127.0.0.1]:34847 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nfx4I-0004iB-Kc
	for submit <at> debbugs.gnu.org; Sun, 17 Apr 2022 01:03:26 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60695)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <spwhitton@HIDDEN>) id 1nfx4H-0004hz-2S
 for 54977 <at> debbugs.gnu.org; Sun, 17 Apr 2022 01:03:25 -0400
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id D96F75C00D4;
 Sun, 17 Apr 2022 01:03:19 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Sun, 17 Apr 2022 01:03:19 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name;
 h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to
 :message-id:mime-version:references:reply-to:sender:subject
 :subject:to:to; s=fm3; t=1650171799; x=1650258199; bh=YgG6gD55Dd
 zFZWUg5XZ60z19x5/KsVBj9Hor5u4sM0U=; b=TIpuhu0dIDqyjWSVqY5fakKmo8
 NQRqzat58mwSYnedB1B/qqhOcqBQauA5vlhzUUB8RBeyFLOx5Mg1mdMt4F4wbUXg
 Up1Is0nVFfLHLQC5iEDPthI0Q2ggdJJoFG069QLPAOAmuNKh47hEr8dRUIWr+vEF
 RUW1O3/aKQliHQgKglUbLneEKQmAbPj9sJo1+EItvhEc4Glf+I0xHNik1vLUEZM/
 DH9tKo2Nux8dW8F/xCY0BtAOCMlO/0eBfw9RiKJ8vr7xVCS93SD+XKw7JZFO2lPU
 VfSijciA9OiJgoVXl6dO24OZyw9tTXLq6AGA6Wjc2S05+A64LyIuVv4qvIiQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1650171799; x=
 1650258199; bh=YgG6gD55DdzFZWUg5XZ60z19x5/KsVBj9Hor5u4sM0U=; b=M
 4kJ39fF+gWiviy3TSZXT64ch7O3txhq8hNbMyWOk2xI2QBP58FX9cdRrn3wid+d+
 l9WLDSVk91D/tC/S57/xj6hG/wJkzIELV9Y5b/3MK3z9ppPgKuTRweDA5hdK4rqg
 mOepShoZS4OCj+wAdFhb7j6ocYF8neQf+AIqNJdffdacg1EUvARH+obwknMcGMbC
 y4ZY0s905IcqgqrdPFYnHuFnjN0GXsQbJ0SM54sBEYhRXhLPO4GJ44/85leJOAMj
 OL5sJ2nquofH4SEgnN4x4kuwzPsfwXU5/wbttQH3oxa7xVdGQPRd094ETGrtXI1L
 83WmbvRvGMid3Vdnf6khg==
X-ME-Sender: <xms:l59bYjNcheHszzaGluTkWuClTHDKgpBrlFl7NNPh0K1ZpBUQQUZsXw>
 <xme:l59bYt8vmFdLQQbBre98uIj2NpyqyTLVi8k2TDYbKI3w0-FISLApxiVl-QSvWyBrK
 6_-QiuQlnYm0L3gWQ>
X-ME-Received: <xmr:l59bYiQUw4GYbg-hNWJpKwRroOdhMCRwfOueRJTblYZ_ePQ29m6tjildDIyM4MyVYWVbC9lgrZIvq14UBkNf9GPuJkF_vqA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudelkedgledvucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffujghffgffkfggtgesthdttd
 dttdertdenucfhrhhomhepufgvrghnucghhhhithhtohhnuceoshhpfihhihhtthhonhes
 shhpfihhihhtthhonhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeelgeeggfdvieejvd
 fhudfggeetgfekkeeuieeljeejhedugeegfeetgefhueffkeenucevlhhushhtvghrufhi
 iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsphifhhhithhtohhnsehsphifhh
 hithhtohhnrdhnrghmvg
X-ME-Proxy: <xmx:l59bYntXO5IQIjS38Z_OyZgGrfgDmknzgJGETw-9t12aKlvxaM9U_A>
 <xmx:l59bYreFhB8f9E_OgIj5U2J9Nh6EPhLG_qwy2l6FYchYL5S0WndyHw>
 <xmx:l59bYj31KfMKJFbb5uUAGp5Owfx7yESz6fs0m_HSXmfEpdj3qklVTg>
 <xmx:l59bYrkRKVF6Ii5ooYmeFKPqcOpqDw2kGgyuT0bgBZhGn8paWVPjbQ>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 17 Apr 2022 01:03:19 -0400 (EDT)
Received: by athena.silentflame.com (Postfix, from userid 1000)
 id 715441B6ABB; Sun, 17 Apr 2022 05:03:18 +0000 (UTC)
From: Sean Whitton <spwhitton@HIDDEN>
To: Jim Porter <jporterbugs@HIDDEN>, 54977 <at> debbugs.gnu.org
Subject: Re: bug#54977: 29.0.50; Customising eshell-modules-list means you
 won't get new default entries
In-Reply-To: <34785f50-0c61-332a-180a-4fe7038fee8b@HIDDEN>
References: <87a6ckkath.fsf@HIDDEN>
 <34785f50-0c61-332a-180a-4fe7038fee8b@HIDDEN>
User-Agent: Emacs/29.0.50 (x86_64-pc-linux-gnu)
Date: Sat, 16 Apr 2022 22:03:18 -0700
Message-ID: <87ilr8xpwp.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 54977
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello,

On Sat 16 Apr 2022 at 10:01pm -07, Jim Porter wrote:

> On 4/16/2022 1:55 PM, Sean Whitton wrote:
>> Suppose that you use the customisation interface to enable the
>> eshell-rebind module, and save the result in your init.  Now upstream
>> Emacs gains a new on-by-default module, e.g. the recently added
>> em-extpipe.  While everyone who hasn't customised eshell-modules-list
>> gets the new module automatically, you'll have to customise the variable
>> again, and you can't even just tick a box to add it, as with the other
>> truly optional modules, but must manually insert it at the end of the
>> list.  This is no good.
>
> Generally I resolve this in my config by using a combination of
> `add-to-list' and `delete' to manually customize lists like this.

Right, me too.

> Maybe it would be good to provide something like that for users of the
> Customize interface as well? Then any defcustom that takes a list
> could either be customized to have an exact set of elements (as it is
> today), or to have "the default, but with FOO added and BAR removed".

That might be a good enhancement, but I think the Eshell case is a bit
simpler -- using two defcustoms mostly solves it.

-- 
Sean Whitton




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#54977; Package emacs. Full text available.

Message received at 54977 <at> debbugs.gnu.org:


Received: (at 54977) by debbugs.gnu.org; 17 Apr 2022 05:01:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 17 01:01:27 2022
Received: from localhost ([127.0.0.1]:34841 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nfx2N-0004fA-7p
	for submit <at> debbugs.gnu.org; Sun, 17 Apr 2022 01:01:27 -0400
Received: from mail-pg1-f182.google.com ([209.85.215.182]:38884)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jporterbugs@HIDDEN>) id 1nfx2L-0004ew-KJ
 for 54977 <at> debbugs.gnu.org; Sun, 17 Apr 2022 01:01:25 -0400
Received: by mail-pg1-f182.google.com with SMTP id s137so13436838pgs.5
 for <54977 <at> debbugs.gnu.org>; Sat, 16 Apr 2022 22:01:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=subject:to:references:from:message-id:date:mime-version:in-reply-to
 :content-language:content-transfer-encoding;
 bh=MHw/U32nWxEuoVrMuYApewVZjkMRW4z8XgInIhJLJ+4=;
 b=TjNI8OAaCE7OOLy+MF3r0EekD+Zyba7eco4TE273LCKQ8OIXAQF6J6nlxcLYVrrBe8
 HWxHSsTX+i3KSyEYBD+z8OsYiME1NJxzxEfpcznqaTLiT9GxIdakY2sZHtcmu1XuBzLh
 L7JUy7SdHt0sT+DBlgkbVq+KFSBhs4YoLMMqGW3yHh8SwwJWFaIa2YXDez0NU9VEgXsh
 VF+9gUC3gBbsnu1aL74VejxnXncNEh2uQsJJX+xWLSr1KIG07UD8xAgAuTlrdA0677zz
 n/wFc8a4cYEblhqF49BmeLFdZ8hV97cXqcE1+MXoLmldaMw16hCFyLZ+jDgVQe018Yei
 ddaw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:subject:to:references:from:message-id:date
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=MHw/U32nWxEuoVrMuYApewVZjkMRW4z8XgInIhJLJ+4=;
 b=TI8QaqCMRvXfchj/u1UN/+0NpkFj230aQj/fzXzT/S1O+sdnmcw1Q/cTOEWKNmMXXv
 lfQHL6pPFhlzWF9z3z+EqzXSeO5q39OPgUf8g8oFb2rEBUm/LBd7sSBUZko+nKjvsumB
 aREVoHUWA3W0HDc+qk8dDcKI8JoVryKuYIYJfru6VzypsdpVYDNhPsrSCvVTV20rsR3X
 AusDrc9ZufwCmKpRakPHYRjcSjeWHdTmss+qkrgM/lHfthssCSBIc31iW8AoqxxDJ2mk
 G7jLW/zHn7Q6RjH7ttDfJ7FE94Pb+3Jflq5IA2Xan1DacVdJkorcAXi/AJaw7yNFor8U
 px+g==
X-Gm-Message-State: AOAM532NOeOCFGjRB55W5oF1H+ColDTBi6WlDo+XCy63J8CaYJrT9QVD
 S+ttjkgfw/OxqIaAOprbbMHrLrkFnBk=
X-Google-Smtp-Source: ABdhPJx596cCOgDc2rQinj12biNMGDFvK1njnYyjrGx9MtI/jcHQAc1p330nmZuFvumsgfTqBJafww==
X-Received: by 2002:a65:460d:0:b0:39d:13e0:d571 with SMTP id
 v13-20020a65460d000000b0039d13e0d571mr5194874pgq.596.1650171679610; 
 Sat, 16 Apr 2022 22:01:19 -0700 (PDT)
Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com.
 [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id
 q203-20020a632ad4000000b003987c421eb2sm9105561pgq.34.2022.04.16.22.01.18
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sat, 16 Apr 2022 22:01:19 -0700 (PDT)
Subject: Re: bug#54977: 29.0.50; Customising eshell-modules-list means you
 won't get new default entries
To: Sean Whitton <spwhitton@HIDDEN>, 54977 <at> debbugs.gnu.org
References: <87a6ckkath.fsf@HIDDEN>
From: Jim Porter <jporterbugs@HIDDEN>
Message-ID: <34785f50-0c61-332a-180a-4fe7038fee8b@HIDDEN>
Date: Sat, 16 Apr 2022 22:01:19 -0700
MIME-Version: 1.0
In-Reply-To: <87a6ckkath.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 54977
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 4/16/2022 1:55 PM, Sean Whitton wrote:
> Suppose that you use the customisation interface to enable the
> eshell-rebind module, and save the result in your init.  Now upstream
> Emacs gains a new on-by-default module, e.g. the recently added
> em-extpipe.  While everyone who hasn't customised eshell-modules-list
> gets the new module automatically, you'll have to customise the variable
> again, and you can't even just tick a box to add it, as with the other
> truly optional modules, but must manually insert it at the end of the
> list.  This is no good.

Generally I resolve this in my config by using a combination of 
`add-to-list' and `delete' to manually customize lists like this. Maybe 
it would be good to provide something like that for users of the 
Customize interface as well? Then any defcustom that takes a list could 
either be customized to have an exact set of elements (as it is today), 
or to have "the default, but with FOO added and BAR removed".




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#54977; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 16 Apr 2022 20:55:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 16 16:55:30 2022
Received: from localhost ([127.0.0.1]:34423 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nfpS6-00079C-EM
	for submit <at> debbugs.gnu.org; Sat, 16 Apr 2022 16:55:30 -0400
Received: from lists.gnu.org ([209.51.188.17]:53476)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <spwhitton@HIDDEN>) id 1nfpS5-000794-BB
 for submit <at> debbugs.gnu.org; Sat, 16 Apr 2022 16:55:29 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:52026)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <spwhitton@HIDDEN>)
 id 1nfpS4-0006GK-Gk
 for bug-gnu-emacs@HIDDEN; Sat, 16 Apr 2022 16:55:28 -0400
Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:42771)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <spwhitton@HIDDEN>)
 id 1nfpS3-0008Km-0u
 for bug-gnu-emacs@HIDDEN; Sat, 16 Apr 2022 16:55:28 -0400
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id 8E2803202051
 for <bug-gnu-emacs@HIDDEN>; Sat, 16 Apr 2022 16:55:25 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute4.internal (MEProxy); Sat, 16 Apr 2022 16:55:25 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name;
 h=cc:content-type:date:date:from:from:in-reply-to:message-id
 :mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=
 1650142525; x=1650228925; bh=HcWvj8BSlwiJzTx1zgDkOh82iD7r+9SIH3n
 uOgDK8HA=; b=GPPJkZG9AqGA1Suy800MltVa5tGumHIok6LMZ4Ia87g/yx1Cn2y
 XMqEQxC2yji+oZoHiYfWhEJ2TV2RZazZ7Fn4TNZn4gu52c0MqOKuHkogJm+twdlS
 sllAcGB0MskFnw+Wytx8qVqJKm4OTSjeegC3IDk43HLuvTh/6ZIGLbB7gOAgdRcm
 4Pwq1Ujelc0TvPYYB5MIT+iNexpF3WhNW5C/CeEJcTLokeXzQ8oQMIGKp/2Q/5Iy
 dpL5snySY25sjWlNGh0Qo8KRrdZaVaA+yOdfaEpnrREfiJgzqWqd3CBO/r7UKdMo
 WXlXNDnRzqAkQAuyD+sBKMelOfmJqAMt6Eg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:date:from:from
 :in-reply-to:message-id:mime-version:reply-to:sender:subject
 :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; t=1650142525; x=1650228925; bh=HcWvj8BSlwiJz
 Tx1zgDkOh82iD7r+9SIH3nuOgDK8HA=; b=BOMN6Y8AaIBUFM7EryEgiz7Iohz7l
 yPY1Y5v5o+FmxuipO2HqBSC8l83McdOHi1UDKl0K3xOireHHzptsDRrc5vfptm0T
 PjdFaAUbOVTDDfvtRGfKQYV+SgVgvaENK4xyo952j31lvvk5FHwSAuxVcJcnvqHk
 E/w8f1mCFLSKq0RaHRTuabf6sxPYyGXaRjDxb4xxDZ9cT9MhCccWS1/Obh0JyRfw
 F7xwTZBQc0B7NtKhLfsNuavUsxdnyfXUdskT1m7V7AXKWJUkxt1ogpmOumLoq08t
 YaZFfNcICDP32HfCCefeu0oQnv5Gby2AUlLxQwInaB0SpD2zdrWQePc3Q==
X-ME-Sender: <xms:PC1bYqrcrzYdypMmYijnsXzUxupg5jcj6cIyGvywUCxGS4DEn_cgUg>
 <xme:PC1bYorMz2mz0D5WDHJfbyEozH7YopoP9ACojQIzmch0AL9vmB83tov0N5Wp4I1Sy
 QmouBXqqM7RuqZ6Hg>
X-ME-Received: <xmr:PC1bYvNq1vH7zZCdR3vXNNbWSM_8x86q0TpnKLJ5k_mYqeowsu32W3dM9dEs4AORSP54m3yGqS5nPO5xfuyRKlgw5yLY86-o36UGcY_eoVTDJsKxxw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeljedgudehiecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufgffffkgggtsehttddttd
 dtredtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehs
 phifhhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepkeffveegfeetvdetud
 fhtefffeefheehkeejfeehieffvdejleeltedtueeivdeinecuvehluhhsthgvrhfuihii
 vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhih
 htthhonhdrnhgrmhgv
X-ME-Proxy: <xmx:PC1bYp5HSTMdCZmNtZEZ89mstuALkeccdZBw0R5eQpr4JLzQcEvtdg>
 <xmx:PC1bYp42d_IncgYVeHjq5W2v7eSC4ymld9FW1vw3hCvOihHPz8TZ6g>
 <xmx:PC1bYpjRYjbuIIcnmInDDRSkY6BMQLP-BNbiWbQeUlQcv9Cx3JwunA>
 <xmx:PS1bYqVGiWn3FWLx-RJ9wStYcSfv6O_2v1rAUrIJtO23Dn1OLMf3CQ>
Received: by mail.messagingengine.com (Postfix) with ESMTPA for
 <bug-gnu-emacs@HIDDEN>; Sat, 16 Apr 2022 16:55:24 -0400 (EDT)
Received: by melete.silentflame.com (Postfix, from userid 1000)
 id 063657E511F; Sat, 16 Apr 2022 13:55:22 -0700 (MST)
From: Sean Whitton <spwhitton@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 29.0.50; Customising eshell-modules-list means you won't get new
 default entries
User-Agent: Emacs/29.0.50 (x86_64-pc-linux-gnu)
Date: Sat, 16 Apr 2022 13:55:22 -0700
Message-ID: <87a6ckkath.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=64.147.123.25;
 envelope-from=spwhitton@HIDDEN; helo=wout2-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.7 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.7 (--)

Hello,

eshell-modules-list has two kinds of entries: truly optional modules
that the user has chosen to enable, and modules that are enabled by
default, and that the user is likely to want to remove from the list
only in unusual circumstances.

Suppose that you use the customisation interface to enable the
eshell-rebind module, and save the result in your init.  Now upstream
Emacs gains a new on-by-default module, e.g. the recently added
em-extpipe.  While everyone who hasn't customised eshell-modules-list
gets the new module automatically, you'll have to customise the variable
again, and you can't even just tick a box to add it, as with the other
truly optional modules, but must manually insert it at the end of the
list.  This is no good.

How about using two separate defcustoms for these two kinds of entry?

-- 
Sean Whitton




Acknowledgement sent to Sean Whitton <spwhitton@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#54977; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 19 Jun 2022 19:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.