GNU bug report logs - #55118
[PATCH] gnu: Add phoronix-test-suite.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55118 in the body.
You can then email your comments to 55118 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add phoronix-test-suite.
Date: Tue, 26 Apr 2022 03:53:57 +0000

[Message part 1 (text/plain, inline)]

Hi,

I've packaged Phoronix test suite. Hopefully all inputs are wrapped.

----
Petr

[Message part 2 (text/html, inline)]

[0001-gnu-Add-phoronix-test-suite.patch (text/x-patch, attachment)]

Message #8 received at 55118 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 55118 <at> debbugs.gnu.org
Subject: Re: [bug#55118] [PATCH] gnu: Add phoronix-test-suite.
Date: Tue, 26 Apr 2022 09:09:34 +0200

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op di 26-04-2022 om 03:53 [+0000]:
> +                               (list #$(this-package-input "php")

It looks at a some files like /usr/bin/php8.  While these do not exist
on Guix System, these don't seem right on foreign distos -- shouldn't
Guix' php be used instead of the foreign distro's php?

Greeti,gs,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 55118 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 55118 <at> debbugs.gnu.org
Subject: Re: [bug#55118] [PATCH] gnu: Add phoronix-test-suite.
Date: Tue, 26 Apr 2022 09:12:42 +0200

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op di 26-04-2022 om 03:53 [+0000]:
> +                               (list #$(this-package-input "php")
> +                                     #$(this-package-input "sed")
> +                                     #$(this-package-input
> "which")))))

chmod & rm from coreutils-minimal, and 'sh' from bash-minimal are
missing.  I recommend changing 'prefix' to '=' to catch these kind of
issues.

Greetings,
Maxime

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 55118 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 55118 <at> debbugs.gnu.org
Subject: Re: [bug#55118] [PATCH] gnu: Add phoronix-test-suite.
Date: Tue, 26 Apr 2022 09:14:19 +0200

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op di 26-04-2022 om 03:53 [+0000]:
> +                       `("PATH" ":" prefix
> +                         ,(map (lambda (dir)
> +                                 (string-append dir "/bin:" dir
> +                                                "/sbin"))
> +                               (list #$(this-package-input "php")
> +                                     #$(this-package-input "sed")
> +                                     #$(this-package-input
> "which")))))

To allow for inputs with changed names and avoid input labels, maybe:

  `("PATH" ":" prefix
    ,(map (lambda (binary)
            (dirname (search-input-file (string-append "bin/" binary))))
          '("php" "sed" "which")))

?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 55118 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 55118 <at> debbugs.gnu.org
Subject: Re: [bug#55118] [PATCH] gnu: Add phoronix-test-suite.
Date: Tue, 26 Apr 2022 09:18:10 +0200

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op di 26-04-2022 om 03:53 [+0000]:
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url
> +                    
> "https://github.com/phoronix-test-suite/phoronix-test-suite")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +               
> "1q509piv5r8lkx82n9qgma19wd01f5ihy1ks1604865fwah1jg19"))))

I can't say I'm familiar with the quoting rules of shell but there seem
to be some quoees missing around $PATH in ...

  PATH="`echo $PATH | sed -e s/:[\.]:/:/g -e s/:[\.]// -e  s/[\.]://`"

`dirname $0` in 

	export PTS_DIR=$(readlink -f `dirname $0`)

(maybe also around the whole $(...)) construct.

E.g., try readlink -f `echo 0 1` -- instead of reading the file "0 1",
it reads "0" and "1".

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 55118 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 55118 <at> debbugs.gnu.org
Subject: Re: [bug#55118] [PATCH] gnu: Add phoronix-test-suite.
Date: Tue, 26 Apr 2022 09:19:49 +0200

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op di 26-04-2022 om 03:53 [+0000]:
> +    (license license:gpl3+)))

I noticed the line

-  [...] However, some tests supported by the Phoronix Test Suite are
not open-source software or require commercial software packages.

Are the non-free parts excluded in this package?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 55118 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 55118 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add phoronix-test-suite
Date: Tue, 26 Apr 2022 15:01:19 +0200

[Message part 1 (text/plain, inline)]

Hi,

For the benchmarks/tests, I'm really bad at php but it seems I've still
managed to disable most tests in the Parabola package of
phoronix-test-suite[1] and keep some non-problematic ones like the php
compilation test.

References:
------------
[1]https://git.parabola.nu/abslibre.git/tree/libre/phoronix-test-suite

Denis.

[Message part 2 (application/pgp-signature, inline)]

Message #28 received at 55118-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: phodina <phodina <at> protonmail.com>
Cc: 55118-done <at> debbugs.gnu.org
Subject: Re: bug#55118: [PATCH] gnu: Add phoronix-test-suite.
Date: Thu, 07 Jul 2022 17:46:42 -0400

Hi!

phodina <phodina <at> protonmail.com> writes:

> Hi,
>
> I've packaged Phoronix test suite. Hopefully all inputs are wrapped.

I had missed this contribution and contributed it myself in
92121b8e9db9541b0fdf0e6e0b17e28e03a01277; apologies!

Closing.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.