GNU bug report logs - #55132
[PATCH] home: shells: Migrate fish to xdg-configuration-files.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55132 in the body.
You can then email your comments to 55132 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bastien Rivière <me <at> babariviere.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] home: shells: Migrate fish to xdg-configuration-files.
Date: Tue, 26 Apr 2022 19:31:11 +0200

* gnu/home/services/shells.scm (home-fish-service-type): Use new
xdg-configuration-files-service-type service.
---
 gnu/home/services/shells.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/home/services/shells.scm b/gnu/home/services/shells.scm
index d96c951cd8..fd5a66090d 100644
--- a/gnu/home/services/shells.scm
+++ b/gnu/home/services/shells.scm
@@ -586,7 +586,7 @@ (define-configuration home-fish-configuration
    serialize-fish-abbreviations))
 
 (define (fish-files-service config)
-  `(("config/fish/config.fish"
+  `(("fish/config.fish"
      ,(mixed-text-file
        "fish-config.fish"
        #~(string-append "\
@@ -650,7 +650,7 @@ (define home-fish-service-type
   (service-type (name 'home-fish)
                 (extensions
                  (list (service-extension
-                        home-files-service-type
+                        home-xdg-configuration-files-service-type
                         fish-files-service)
                        (service-extension
                         home-profile-service-type
-- 
2.35.1

Message #10 received at 55132-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Bastien Rivière <me <at> babariviere.com>
Cc: 55132-done <at> debbugs.gnu.org
Subject: Re: bug#55132: [PATCH] home: shells: Migrate fish to
 xdg-configuration-files.
Date: Fri, 29 Apr 2022 14:48:03 +0200

Hi Bastien,

Bastien Rivière <me <at> babariviere.com> skribis:

> * gnu/home/services/shells.scm (home-fish-service-type): Use new
> xdg-configuration-files-service-type service.

Applied, thanks!

Ludo’.

Message #13 received at 55132-done <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Ludovic Courtès <ludo <at> gnu.org>, Bastien Rivière <me <at> babariviere.com>
Cc: 55132-done <at> debbugs.gnu.org
Subject: Re: bug#55132: [PATCH] home: shells: Migrate fish to
 xdg-configuration-files.
Date: Tue, 03 May 2022 13:19:02 +0300

[Message part 1 (text/plain, inline)]

On 2022-04-29 14:48, Ludovic Courtès wrote:

> Hi Bastien,
>
> Bastien Rivière <me <at> babariviere.com> skribis:
>
>> * gnu/home/services/shells.scm (home-fish-service-type): Use new
>> xdg-configuration-files-service-type service.
>
> Applied, thanks!

Seems there was an earlier patch, which slipped off:
https://issues.guix.gnu.org/52808#18

Got the report for this problem today, Bastien and Ludovic, thank you
for the fix and merge.

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.