GNU bug report logs - #55186
package-definition-location is wrong for inherited packages

Previous Next

Package: guix;

Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Date: Fri, 29 Apr 2022 15:57:01 UTC

Severity: normal

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55186 in the body.
You can then email your comments to 55186 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#55186; Package guix. (Fri, 29 Apr 2022 15:57:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Fri, 29 Apr 2022 15:57:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: bug-guix <bug-guix <at> gnu.org>
Subject: package-definition-location is wrong for inherited packages
Date: Fri, 29 Apr 2022 11:56:34 -0400
Hi Guix,

Here's another problem with source location I've discovered when
attempting to locate the source of `python2-pytest-warnings', which
reads like:

--8<---------------cut here---------------start------------->8---
(define-public python2-pytest-warnings
  (package (inherit (package-with-python2
                     (strip-python2-variant python-pytest-warnings)))
           (properties `((superseded . ,python2-pytest)))))
--8<---------------cut here---------------end--------------->8---

The define-public line is at line 2569, but:

--8<---------------cut here---------------start------------->8---
(define package (car (find-packages-by-name "python2-pytest-warnings")))
(package-definition-location package) location->source-properties)
--8<---------------cut here---------------end--------------->8---

returns 2570, the line below.

Thanks,

Maxim




Information forwarded to bug-guix <at> gnu.org:
bug#55186; Package guix. (Mon, 02 May 2022 21:05:02 GMT) Full text and rfc822 format available.

Message #8 received at 55186 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 55186 <at> debbugs.gnu.org
Subject: Re: bug#55186: package-definition-location is wrong for inherited
 packages
Date: Mon, 02 May 2022 23:04:38 +0200
Hi,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> Here's another problem with source location I've discovered when
> attempting to locate the source of `python2-pytest-warnings', which
> reads like:
>
> (define-public python2-pytest-warnings
>   (package (inherit (package-with-python2
>                      (strip-python2-variant python-pytest-warnings)))
>            (properties `((superseded . ,python2-pytest)))))

It works for me:

--8<---------------cut here---------------start------------->8---
$ guix repl
GNU Guile 3.0.8
Copyright (C) 1995-2021 Free Software Foundation, Inc.

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.

Enter `,help' for help.
scheme@(guix-user)> ,use(guix)
scheme@(guix-user)> ,use(gnu packages check)
scheme@(guix-user)> (package-definition-location python2-mock )
$1 = #<<location> file: "gnu/packages/check.scm" line: 882 column: 0>
scheme@(guix-user)> (package-definition-location python2-nose )
$2 = #<<location> file: "gnu/packages/check.scm" line: 917 column: 0>
scheme@(guix-user)> (package-definition-location python2-nose2 )
$3 = #f
scheme@(guix-user)> ,q
$ guix describe
Generation 214  May 02 2022 21:44:14    (current)
  guix 6b588da
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 6b588da368c77cde82ea2f22ca315116228777ad
--8<---------------cut here---------------end--------------->8---

Note that ‘python2-nose2’ has #f.  This is because it’s defined without
a literal (package …) form:

--8<---------------cut here---------------start------------->8---
(define-public python2-nose2
  (package-with-python2 python-nose2))
--8<---------------cut here---------------end--------------->8---

It’s OK for the initial use case of ‘package-definition-location’, which
was the ‘generic-git’ updater.

Not sure if it helps, but I hope it does anyway.  :-)

Ludo’.




Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Mon, 16 May 2022 04:57:01 GMT) Full text and rfc822 format available.

Notification sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
bug acknowledged by developer. (Mon, 16 May 2022 04:57:01 GMT) Full text and rfc822 format available.

Message #13 received at 55186-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 55186-done <at> debbugs.gnu.org
Subject: Re: bug#55186: package-definition-location is wrong for inherited
 packages
Date: Mon, 16 May 2022 00:56:19 -0400
Hi Ludovic,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>> Here's another problem with source location I've discovered when
>> attempting to locate the source of `python2-pytest-warnings', which
>> reads like:
>>
>> (define-public python2-pytest-warnings
>>   (package (inherit (package-with-python2
>>                      (strip-python2-variant python-pytest-warnings)))
>>            (properties `((superseded . ,python2-pytest)))))
>
> It works for me:

Thanks for checking, this works for me too now.  I think I was amidst
modifications to the code, that induced me in error.  I've fixed what I
think was a typo in a comment in the code that made my understanding
difficult in the early commits of https://issues.guix.gnu.org/55424.

Happily closing,

Maxim




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 13 Jun 2022 11:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 289 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.