GNU bug report logs - #55210
[PATCH 0/3] Add go-1.18.1

Previous Next

Package: guix-patches;

Reported by: Pier-Hugues Pellerin <ph <at> heykimo.com>

Date: Sun, 1 May 2022 18:57:02 UTC

Severity: normal

Tags: patch

Done: Sharlatan Hellseher <sharlatanus <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55210 in the body.
You can then email your comments to 55210 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#55210; Package guix-patches. (Sun, 01 May 2022 18:57:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Pier-Hugues Pellerin <ph <at> heykimo.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 01 May 2022 18:57:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pier-Hugues Pellerin <ph <at> heykimo.com>
To: guix-patches <at> gnu.org
Cc: Pier-Hugues Pellerin <ph <at> heykimo.com>
Subject: [PATCH 0/3] Add go-1.18.1
Date: Sun,  1 May 2022 14:55:55 -0400
Hello,

I've added a go 1.18 package, still learning the build and all the quirks. So far I've did
the following in multiple commits, I hope it's okay:

- I've created a new go-1.18 package inheriting from 1.17.

This mean that the build use the same logic as before, use go 1.4 for the build toolchain.
and fallback on previous version 1.17

- I've changed the Homepage of the Go 1.18 package.

Guix lint complained about a change in the URL, so I've updated it to https://go.dev.

- 1.17 is here to stay for some time

I've looked at the toolchain of the Go language, today the minimun version of go require to build is
1.4, but this will be updated to 1.17 for 1.19[0].

- Adding go-next to point to go 1.18.

Following a discussion on email I've added `go-next` that currently point to 1.18,
I've copied the strategy from the emacs' package that also define an emacs-next
package to allow users to try out the latest version. I am not sure this was the right way
to do it. I 

- Made go point to 1.18 as the default version


Following Ludovic advice I've made the default go point to 1.18, so we can create a testing branch and see
what is failling.

Thanks everyone

ph

[0] https://github.com/golang/go/issues/44505


Pier-Hugues Pellerin (3):
  gnu: Add go-1.18.
  gnu: Add go-next.
  gnu: go: Update to go-1.18

 gnu/packages/golang.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

-- 
2.35.1





Information forwarded to guix-patches <at> gnu.org:
bug#55210; Package guix-patches. (Sun, 01 May 2022 18:59:01 GMT) Full text and rfc822 format available.

Message #8 received at 55210 <at> debbugs.gnu.org (full text, mbox):

From: Pier-Hugues Pellerin <ph <at> heykimo.com>
To: 55210 <at> debbugs.gnu.org
Cc: Pier-Hugues Pellerin <ph <at> heykimo.com>
Subject: [PATCH 1/3] gnu: Add go-1.18.
Date: Sun,  1 May 2022 14:57:47 -0400
* gnu/packages/golang.scm (go-1.18): Update to Go 1.18.1
---
 gnu/packages/golang.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 820e6b54ab..829db82ea2 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -839,6 +839,31 @@ (define-public go-1.17
        (package-native-inputs go-1.16)))))
 
 (define-public go go-1.17)
+(define-public go-1.18
+  (package
+    (inherit go-1.17)
+    (name "go")
+    (version "1.18.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/golang/go")
+                    (commit (string-append "go" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1ywx90w1jvmp6nif00kjn4ksn09a0wvfp2kww3gxk02s1wi23zw5"))))
+    (inputs (if (not (target-arm?))
+                (alist-delete "gcc:lib"
+                              (package-inputs go-1.17))
+                (package-inputs go-1.17)))
+    (native-inputs (if (not (member (%current-system)
+                                    (package-supported-systems go-1.4)))
+                       (alist-replace "go"
+                                      (list go-1.17)
+                                      (package-native-inputs go-1.17))
+                       (package-native-inputs go-1.17)))
+    (home-page "https://go.dev")))
 
 (define-public (make-go-std go)
   "Return a package which builds the standard library for Go compiler GO."
-- 
2.35.1





Information forwarded to guix-patches <at> gnu.org:
bug#55210; Package guix-patches. (Sun, 01 May 2022 18:59:01 GMT) Full text and rfc822 format available.

Message #11 received at 55210 <at> debbugs.gnu.org (full text, mbox):

From: Pier-Hugues Pellerin <ph <at> heykimo.com>
To: 55210 <at> debbugs.gnu.org
Cc: Pier-Hugues Pellerin <ph <at> heykimo.com>
Subject: [PATCH 2/3] gnu: Add go-next.
Date: Sun,  1 May 2022 14:58:32 -0400
* gnu/packages/golang.scm (go-next): Add go-next that point to the next
version of Go, allowing to use the latest version without rebuilding everything.
---
 gnu/packages/golang.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 829db82ea2..a9091b67a0 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -865,6 +865,11 @@ (define-public go-1.18
                        (package-native-inputs go-1.17)))
     (home-page "https://go.dev")))
 
+(define-public go-next
+  (package
+    (inherit go-1.18)
+    (name "go-next")))
+
 (define-public (make-go-std go)
   "Return a package which builds the standard library for Go compiler GO."
   (package
-- 
2.35.1





Information forwarded to guix-patches <at> gnu.org:
bug#55210; Package guix-patches. (Sun, 01 May 2022 18:59:02 GMT) Full text and rfc822 format available.

Message #14 received at 55210 <at> debbugs.gnu.org (full text, mbox):

From: Pier-Hugues Pellerin <ph <at> heykimo.com>
To: 55210 <at> debbugs.gnu.org
Cc: Pier-Hugues Pellerin <ph <at> heykimo.com>
Subject: [PATCH 3/3] gnu: go: Update to go-1.18
Date: Sun,  1 May 2022 14:58:42 -0400
* gnu/packages/golang.scm go: Update to go-1.18.
---
 gnu/packages/golang.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index a9091b67a0..95ac6546e7 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -870,6 +870,8 @@ (define-public go-next
     (inherit go-1.18)
     (name "go-next")))
 
+(define-public go go-1.18)
+
 (define-public (make-go-std go)
   "Return a package which builds the standard library for Go compiler GO."
   (package
-- 
2.35.1





Reply sent to Sharlatan Hellseher <sharlatanus <at> gmail.com>:
You have taken responsibility. (Wed, 31 Jan 2024 20:55:02 GMT) Full text and rfc822 format available.

Notification sent to Pier-Hugues Pellerin <ph <at> heykimo.com>:
bug acknowledged by developer. (Wed, 31 Jan 2024 20:55:02 GMT) Full text and rfc822 format available.

Message #19 received at 55210-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 55210-done <at> debbugs.gnu.org
Subject: [PATCH 0/3] Add go-1.18.1
Date: Wed, 31 Jan 2024 20:53:43 +0000
[Message part 1 (text/plain, inline)]
Hi,

go-1.18 was added in this commit f44ba4a1ad9a1c16cb6a90faf690c6c9b0b919d6
by Hilton Chain <hako <at> ultrarare.space>.

Closing this issue as not actual.

Thanks,
Oleg
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 29 Feb 2024 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 28 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.