GNU bug report logs - #55215
[PATCH] gnu: emacs-circe: Update to 2.12.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55215 in the body.
You can then email your comments to 55215 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: emacs-circe: Update to 2.12.
Date: Mon,  2 May 2022 02:31:26 +0000

* gnu/packages/emacs-xyz.scm (emacs-circe): Update to 2.12.
---
 gnu/packages/emacs-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d0851a480e..0723639b8f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -16227,11 +16227,11 @@ (define-public emacs-auth-source-xoauth2
 (define-public emacs-circe
   ;; The latest stable release is two years old, and some important fixes have
   ;; landed since then.
-  (let ((commit "d6f1fa18646f6ed2a1c0f06a4888130bd694ff19")
-        (revision "0"))
+  (let ((commit "710f057fedae6e9b820cce9336fef24b7d057e4c")
+        (revision "1"))
     (package
       (name "emacs-circe")
-      (version (git-version "2.11" revision commit))
+      (version (git-version "2.12" revision commit))
       (source
        (origin
          (method git-fetch)
-- 
2.35.1

Message #8 received at 55215 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: jgart <jgart <at> dismail.de>
Cc: 55215 <at> debbugs.gnu.org
Subject: Re: bug#55215: [PATCH] gnu: emacs-circe: Update to 2.12.
Date: Fri, 06 May 2022 10:23:45 +0200

jgart <jgart <at> dismail.de> skribis:

> * gnu/packages/emacs-xyz.scm (emacs-circe): Update to 2.12.
> ---
>  gnu/packages/emacs-xyz.scm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index d0851a480e..0723639b8f 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -16227,11 +16227,11 @@ (define-public emacs-auth-source-xoauth2
>  (define-public emacs-circe
>    ;; The latest stable release is two years old, and some important fixes have
>    ;; landed since then.
> -  (let ((commit "d6f1fa18646f6ed2a1c0f06a4888130bd694ff19")
> -        (revision "0"))
> +  (let ((commit "710f057fedae6e9b820cce9336fef24b7d057e4c")
> +        (revision "1"))
>      (package
>        (name "emacs-circe")
> -      (version (git-version "2.11" revision commit))
> +      (version (git-version "2.12" revision commit))

Looks like you forgot to update the hash.  Could you send an updated
patch?

TIA!

Ludo’.

Message #11 received at 55215 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 55215 <at> debbugs.gnu.org
Subject: Re: bug#55215: [PATCH] gnu: emacs-circe: Update to 2.12.
Date: Fri, 6 May 2022 16:30:33 +0000

On Fri, 06 May 2022 10:23:45 +0200 Ludovic Courtès <ludo <at> gnu.org> wrote:
> jgart <jgart <at> dismail.de> skribis:
> 
> > * gnu/packages/emacs-xyz.scm (emacs-circe): Update to 2.12.
> > ---
> >  gnu/packages/emacs-xyz.scm | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> > index d0851a480e..0723639b8f 100644
> > --- a/gnu/packages/emacs-xyz.scm
> > +++ b/gnu/packages/emacs-xyz.scm
> > @@ -16227,11 +16227,11 @@ (define-public emacs-auth-source-xoauth2
> >  (define-public emacs-circe
> >    ;; The latest stable release is two years old, and some important fixes have
> >    ;; landed since then.
> > -  (let ((commit "d6f1fa18646f6ed2a1c0f06a4888130bd694ff19")
> > -        (revision "0"))
> > +  (let ((commit "710f057fedae6e9b820cce9336fef24b7d057e4c")
> > +        (revision "1"))
> >      (package
> >        (name "emacs-circe")
> > -      (version (git-version "2.11" revision commit))
> > +      (version (git-version "2.12" revision commit))
> 
> Looks like you forgot to update the hash.  Could you send an updated
> patch?

Hi Ludo,

Thanks for the review.

I've run into this issue before that no matter what I do to try to get
guix to detect the faulty hash it happily builds the package in question
successfully without failing.

For example, I tried changing the first character of the hash to 1
if 0 in order to cause it to fail but guix does not complain and builds
it nonetheless.

Is this because of some caching going on? What should I do?

all best,

jgart

Message #14 received at 55215 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: jgart <jgart <at> dismail.de>
Cc: 55215 <at> debbugs.gnu.org
Subject: Re: bug#55215: [PATCH] gnu: emacs-circe: Update to 2.12.
Date: Mon, 09 May 2022 10:29:45 +0200

Hi,

jgart <jgart <at> dismail.de> skribis:

> I've run into this issue before that no matter what I do to try to get
> guix to detect the faulty hash it happily builds the package in question
> successfully without failing.

Since ‘origin’ has a ‘file-name’ field that is a function of the version
string, Guix will try to redownload the source if you change the version
string, and at that point it should fail with a wrong hash error, as it
did for me.

Let me know if you observe something different.

HTH,
Ludo’.

Message #21 received at 55215-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: jgart <jgart <at> dismail.de>
Cc: 55215-done <at> debbugs.gnu.org
Subject: Re: bug#55215: [PATCH] gnu: emacs-circe: Update to 2.12.
Date: Thu, 07 Jul 2022 16:30:07 -0400

Hello,

jgart <jgart <at> dismail.de> writes:

> * gnu/packages/emacs-xyz.scm (emacs-circe): Update to 2.12.
> ---
>  gnu/packages/emacs-xyz.scm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index d0851a480e..0723639b8f 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -16227,11 +16227,11 @@ (define-public emacs-auth-source-xoauth2
>  (define-public emacs-circe
>    ;; The latest stable release is two years old, and some important fixes have
>    ;; landed since then.
> -  (let ((commit "d6f1fa18646f6ed2a1c0f06a4888130bd694ff19")
> -        (revision "0"))
> +  (let ((commit "710f057fedae6e9b820cce9336fef24b7d057e4c")
> +        (revision "1"))
>      (package
>        (name "emacs-circe")
> -      (version (git-version "2.11" revision commit))
> +      (version (git-version "2.12" revision commit))
>        (source
>         (origin
>           (method git-fetch)

Obsoleted by commit 96eb2337b5, which updated emacs-circe to 2.12.

Thanks,

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.