Received: (at 55231) by debbugs.gnu.org; 17 Feb 2025 05:01:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 17 00:01:32 2025
Received: from localhost ([127.0.0.1]:40970 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tjtG7-0000PR-NW
for submit <at> debbugs.gnu.org; Mon, 17 Feb 2025 00:01:32 -0500
Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:42298)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
id 1tjqqi-00045N-Kq
for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 21:27:09 -0500
Received: by mail-pl1-x632.google.com with SMTP id
d9443c01a7336-21f2339dcfdso57712645ad.1
for <55231 <at> debbugs.gnu.org>; Sun, 16 Feb 2025 18:27:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1739759222; x=1740364022; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=PiZFrnsDQpd9rk112Q2b0k882CdrX4rdONvGJWtXXzw=;
b=ClohdBmKvuxZ6KVS1TR8cetALj08mzt6mixCcPqY8U9OkJZimymZsiyrNLZVmWwfrO
m+jkOWHCR8a0nwbZ2vjFZwdd288395bzVuN5w46am9Du7uuHLEqFUg4/nl5ujsAWcJQJ
57loOVxEImO/F1Y+NxUbfXcMnaVorIkGon0YhU2/dy3yA/D2RZYHMC5bXpeBri6GY8QD
ClohyDjiSWCc04fRk0HuGkKe0msSiXIZfbwS62iOsy2NgCujAGQ77dbe/AYbmoeMBZSE
S4bY5ULgmFhT9fm/O6GTvKFpiOMouVX/JrezdRdvQLP4zcS6sNFA6lJnQx/b2zeyLnps
+n7Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1739759222; x=1740364022;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=PiZFrnsDQpd9rk112Q2b0k882CdrX4rdONvGJWtXXzw=;
b=HVL7xZvGi2IzW/Q4iTxW9jRh9nJz/DbQopzX96nyHKthHBG3qFDoG5u7sdzAlivxM1
Vasb3vMDANN0r9TdRPd1bVn7Gdi42Kkdr4/btxCi4R1+k0FZyCcJZwk2I4uxb+B0cvOS
JVMdg2bfk7ZfjHHAgLPemB7owlAWfZ5CfvrS1uuRQcKfgcE9YKNvfIIrPNVtIJHR/5RI
+CZ/5rVINbRceIPtu9MNajYrBmqpvrt9qzdDfSrH+WNn6Eixi2i/UcD1qSksHztEZqc+
TY1FwQTuQ29qXsCMvYfkx0UcjNaDDnsYjICNyD59UHu/i0qBmR2VG0XTk3MzP6tHP+le
g+Ew==
X-Gm-Message-State: AOJu0YweT87uorXjKD06LS5Xr8RT35mBC+4TgwQoif2bm0QzZU0/7cCQ
+GcxpZpKVWgYa0Ya/onLUn2BpScy9DdF96fCHDfDyUCub73xHhfn
X-Gm-Gg: ASbGnctlm8LebRbBolVhAk3nIyRPoa7he+wiMta+HrEhqOm/AUZaYKMaeiY8dEDfzas
GYiI8zKc9SZQK605F+WnLgkuk5zqJZt1dlZadqJWWd1xSWX8rM4OxtDgRLpmP2Tsvu1oFzKJbNk
6uxaVE5N0g/slBVcjiHs4hD97gP7s2wCvwk080gXLC0hpzpEZidFWoKaHJuYv6I4lvyzF26LlLw
eQ+TUSHHcItjqzkTfTd8UfOQWFd4oJtlkvJmJaGRYFLSp9zn6Org6tjrtM04X+6Xf+TB+vWfJAq
Ma4huFch2ZMA
X-Google-Smtp-Source: AGHT+IGFrz1EFtRGNVdOIh+6Avk1NYvaWI6GNEwFM1evKHTGq9gNuZcTVVc997CTJ9tHTAlhspS4Ug==
X-Received: by 2002:a17:902:e888:b0:21f:5063:d3ca with SMTP id
d9443c01a7336-220d357a606mr248382535ad.16.1739759222393;
Sun, 16 Feb 2025 18:27:02 -0800 (PST)
Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89])
by smtp.gmail.com with ESMTPSA id
d9443c01a7336-220d5364669sm61399885ad.86.2025.02.16.18.26.57
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 16 Feb 2025 18:27:01 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: bug#55231: [PATCH v1] initrd: Allow extra search paths with
=?utf-8?Q?=E2=80=98initrd-extra-module-paths=E2=80=99?=
In-Reply-To: <878qq5pz2x.fsf_-_@HIDDEN> ("Ludovic =?utf-8?Q?Court=C3=A8s?=
=?utf-8?Q?=22's?= message of "Sun, 16 Feb 2025 18:40:54 +0100")
References: <353146a4da0938e592fa4333b601abf5b98d937d.1739710358.git.maxim.cournoyer@HIDDEN>
<3a29ed41b52ef12aa92d31ff740b01777785e6c6.1739710358.git.maxim.cournoyer@HIDDEN>
<878qq5pz2x.fsf_-_@HIDDEN>
Date: Mon, 17 Feb 2025 11:26:47 +0900
Message-ID: <87eczx1f2w.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Ludo, Ludovic Courtès writes: [...]
Content analysis details: (3.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (maxim.cournoyer[at]gmail.com)
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[2607:f8b0:4864:20:0:0:0:632 listed in]
[list.dnswl.org]
X-Debbugs-Envelope-To: 55231
X-Mailman-Approved-At: Mon, 17 Feb 2025 00:01:09 -0500
Cc: Josselin Poiret <dev@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>,
Ian Eure <ian@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>,
Brian Cully <bjc@HIDDEN>, Leo Famulari <leo@HIDDEN>,
Andreas Enge <andreas@HIDDEN>, Kaelyn <kaelyn.alexi@HIDDEN>,
Felix Lechner <felix.lechner@HIDDEN>,
Mathieu Othacehe <othacehe@HIDDEN>,
John Kehayias <john.kehayias@HIDDEN>,
Christopher Baines <guix@HIDDEN>, 55231 <at> debbugs.gnu.org,
Simon Tournier <zimon.toutoune@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Ludo, Ludovic Courtès writes: [...]
Content analysis details: (2.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[2607:f8b0:4864:20:0:0:0:632 listed in]
[list.dnswl.org]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
provider (maxim.cournoyer[at]gmail.com)
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
Hi Ludo,
Ludovic Court=C3=A8s <ludo@HIDDEN> writes:
[...]
>> + (let* ((substitutable-inputs? (every substitutable-derivation?
>> + (map derivation-input-derivati=
on
>> + inputs)))
>
> This change doesn=E2=80=99t come for free. I didn=E2=80=99t follow the d=
iscussion, but
> adding overhead to such a core component to accommodate ZFS sounds
> questionable to me.
I've measured with strace -fc and time, and the difference appeared
negligible.
>> + ;; DRV2 is *not* available as a substitute, since it has drv1=
as
>> + ;; input, and the non-substitutability is viral to avoid
>> + ;; distributing non-substitutable items that could have become
>> + ;; embedded, for example in an initrd.
>
> Who would distribute it though? A build farm building a ZFS-enabled
> initrd, right? Is that a real use case? (Perhaps this has already been
> answered before; please let me know what I should look at, it=E2=80=99s a=
long
> discussion!)
It's that far fetch that substitute servers like berlin or third party
ones could want to use ZFS RAID 5/6 themselves to minimize disk usage
while having some redundancy, so yes, that's the most likely use case, I
think.
Then a downstream user of such build farm/substitute server could use
ZFS themselves and find themselves fetching ready-built initrd's binary
containing the ZFS module, which should not be happening due to the
license incompatibility between ZFS's CDDL and the Linux kernel GPL2
only.
--=20
Thanks,
Maxim
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 17 Feb 2025 05:01:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 17 00:01:18 2025
Received: from localhost ([127.0.0.1]:40960 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tjtFr-0000NP-FP
for submit <at> debbugs.gnu.org; Mon, 17 Feb 2025 00:01:18 -0500
Received: from fout-a2-smtp.messagingengine.com ([103.168.172.145]:36143)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <leo@HIDDEN>) id 1tjl6z-0005Te-0t
for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 15:19:34 -0500
Received: from phl-compute-06.internal (phl-compute-06.phl.internal
[10.202.2.46])
by mailfout.phl.internal (Postfix) with ESMTP id A437813809C9;
Sun, 16 Feb 2025 15:19:27 -0500 (EST)
Received: from phl-imap-08 ([10.202.2.84])
by phl-compute-06.internal (MEProxy); Sun, 16 Feb 2025 15:19:27 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
h=cc:cc:content-transfer-encoding:content-type:content-type
:date:date:from:from:in-reply-to:in-reply-to:message-id
:mime-version:references:reply-to:subject:subject:to:to; s=
mesmtp; t=1739737167; x=1739823567; bh=5CgfD8dfbCNqJoW5HXCvsI9WX
Eycwzz0HcDIZqfhPUo=; b=BV/yrXludE9UWcX0/vQyLquZ24imkwIQAAjP5Hhc9
xwirU8WWFBK7J0/9ErW2bt8SGfu9bHuNXafjLBDbOKqM3EMatfyYjFTPDGWugH5w
D+BgPbANWCWzRVIu7NahGtLhgz13FzRA/1pJrVYzar3Riin4OB9DUYX6k33F/IkR
QY=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1739737167; x=
1739823567; bh=5CgfD8dfbCNqJoW5HXCvsI9WXEycwzz0HcDIZqfhPUo=; b=b
+apAfa7hRDk+NCXyrPJ3A/flzcnPQ1dbu9iZdcVDyCAvVLdvwL9K9vY0pulOY2ix
M6e15dctFQBLQMppqngB6DFwA9ULTCtEkDz7p3xhIZkog+FHaqH8e0dLyjOBQTXZ
5VwnI2XTzWmsunhmgUiB3FgKVwicHy1sjAPJ1JmPXjiF694njQPefzwszJcpvfrc
xGcgwWOHEv4zJfVXlHTle0tUXcCH9ljs6n/BztqxJJmX1yAgu10Sw6qGufh0a7KM
C2iKnghtFaxuL/eoqDco4fEceVWEG54ll7jNGgSUMT3zSDu3whFbfFlMPf7UpICK
n9gmJG71YOivnLONhiF+w==
X-ME-Sender: <xms:TkiyZ_Uj0Klg41e2fYjAsMSsrvvlVFHKO8cC6Vln-H3lJ03tVxsbug>
<xme:TkiyZ3mJvzFezn4IgoFZtdBrfK5J9NXOHj1NUCn1XLYZRUCnUs6Z2hwYrXfOIXfiZ
jNojTryK3RXJshJPA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdehieegudcutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp
uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg
hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthhqredtredt
jeenucfhrhhomhepfdfnvghoucfhrghmuhhlrghrihdfuceolhgvohesfhgrmhhulhgrrh
hirdhnrghmvgeqnecuggftrfgrthhtvghrnhephffgieevvdevvdduiefhtdegjeevjefg
heettdehueelheetvddugeektedvkefhnecuffhomhgrihhnpehgnhhurdhorhhgnecuve
hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgr
mhhulhgrrhhirdhnrghmvgdpnhgspghrtghpthhtohepudehpdhmohguvgepshhmthhpoh
huthdprhgtphhtthhopehguhhigiestggsrghinhgvshdrnhgvthdprhgtphhtthhopeeh
hedvfeduseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtoheprghnughrvggrsh
esvghnghgvrdhfrhdprhgtphhtthhopehmrgigihhmrdgtohhurhhnohihvghrsehgmhgr
ihhlrdgtohhmpdhrtghpthhtohepiihimhhonhdrthhouhhtohhunhgvsehgmhgrihhlrd
gtohhmpdhrtghpthhtoheplhhuughosehgnhhurdhorhhgpdhrtghpthhtohepohhthhgr
tggvhhgvsehgnhhurdhorhhgpdhrtghpthhtohepuggvvhesjhhpohhirhgvthdrgiihii
dprhgtphhtthhopehfvghlihigrdhlvggthhhnvghrsehlvggrshgvqdhuphdrtghomh
X-ME-Proxy: <xmx:TkiyZ7aW_OSpmL_9yYryg3OAX7Xp-bmP3Uh9hDgbqMsyqDPexUeT_g>
<xmx:TkiyZ6Ubn3eDVqED7IQiNN1c2dbinF1WXuukv9ci0rAZq7YwHwNFmA>
<xmx:TkiyZ5nH9K80smOZXBZNgsbWIkW9wc5geMh9fv6_3Kt3IZGyDZW3MQ>
<xmx:TkiyZ3cOfwZpvEhD7kRgsobGtEgN9Mh7m7GTD4WB9625-gThXXJTZg>
<xmx:T0iyZ--wutMVQzI5-c3HpB1MtovboEMoNG0i0xrS3mD7WeLtXvi6r987>
Feedback-ID: i819c4023:Fastmail
Received: by mailuser.phl.internal (Postfix, from userid 501)
id 6C02618A006B; Sun, 16 Feb 2025 15:19:26 -0500 (EST)
X-Mailer: MessagingEngine.com Webmail Interface
MIME-Version: 1.0
Date: Sun, 16 Feb 2025 15:19:07 -0500
From: "Leo Famulari" <leo@HIDDEN>
To: "Morgan Arnold" <morgan.arnold@HIDDEN>,
=?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Message-Id: <fc0a8c3e-d5b8-43a2-80de-0232d0be4f1d@HIDDEN>
In-Reply-To: <Z_R-GqCPE0Fil07ukiYc7ubqjVk39lZIheRItdeE-lJyIPG7MrFM9QBKomWR5mX72vDU5tIFJCmVwhYekOMTh0DlsHVA2KggPchBO2ChZ-o=@proton.me>
References: <353146a4da0938e592fa4333b601abf5b98d937d.1739710358.git.maxim.cournoyer@HIDDEN>
<3a29ed41b52ef12aa92d31ff740b01777785e6c6.1739710358.git.maxim.cournoyer@HIDDEN>
<878qq5pz2x.fsf_-_@HIDDEN>
<Z_R-GqCPE0Fil07ukiYc7ubqjVk39lZIheRItdeE-lJyIPG7MrFM9QBKomWR5mX72vDU5tIFJCmVwhYekOMTh0DlsHVA2KggPchBO2ChZ-o=@proton.me>
Subject: =?UTF-8?Q?Re:_bug#55231:_[PATCH_v1]_initrd:_Allow_extra_search_paths_wit?=
=?UTF-8?Q?h_=E2=80=98initrd-extra-module-paths=E2=80=99?=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 2.3 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Sun, Feb 16, 2025, at 13:25, Morgan Arnold wrote: > As
you note, the only person who would distribute such a pre-compiled > initrd
would be someone who built one and shared it, say with `guix > pub [...]
Content analysis details: (2.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE:
The query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[103.168.172.145 listed in sa-accredit.habeas.com]
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/,
low trust [103.168.172.145 listed in list.dnswl.org]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[103.168.172.145 listed in bl.score.senderscore.com]
X-Debbugs-Envelope-To: 55231
X-Mailman-Approved-At: Mon, 17 Feb 2025 00:01:09 -0500
Cc: Josselin Poiret <dev@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>,
Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Ian Eure <ian@HIDDEN>,
Mathieu Othacehe <othacehe@HIDDEN>, Brian Cully <bjc@HIDDEN>,
Andreas Enge <andreas@HIDDEN>, Kaelyn <kaelyn.alexi@HIDDEN>,
Felix Lechner <felix.lechner@HIDDEN>,
John Kehayias <john.kehayias@HIDDEN>,
Christopher Baines <guix@HIDDEN>, 55231 <at> debbugs.gnu.org,
zimoun <zimon.toutoune@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Sun, Feb 16, 2025, at 13:25, Morgan Arnold wrote: > As
you note, the only person who would distribute such a pre-compiled > initrd
would be someone who built one and shared it, say with `guix > pub [...]
Content analysis details: (1.3 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE:
The query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[103.168.172.145 listed in sa-trusted.bondedsender.org]
0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[103.168.172.145 listed in bl.score.senderscore.com]
-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/,
low trust
[103.168.172.145 listed in list.dnswl.org]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
-0.0 SPF_PASS SPF: sender matches SPF record
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
On Sun, Feb 16, 2025, at 13:25, Morgan Arnold wrote:
> As you note, the only person who would distribute such a pre-compiled=20
> initrd would be someone who built one and shared it, say with `guix=20
> publish`. A lot of the discussion essentially boils down to one=20
> question: is Guix responsible only for not committing copyright=20
> violations itself, say by not distributing such a pre-compiled initrd=20
> itself, or is Guix also responsible for putting in guardrails to=20
> prevent users from accidentally committing copyright violations? If yo=
u=20
> subscribe to the former view, then the original changes proposed by=20
> Brian are entirely acceptable as is. If, instead, you subscribe to the=20
> latter view, then this change may be unacceptable, as it facilitates=20
> the accidental commission of copyright violations by users of Guix. Th=
e=20
> changes made here to derivations are an attempt to allow users to=20
> create ZFS-compatible initrds in a manner which is compatible with the=20
> latter (more conservative, in some sense) view of the responsibilities=20
> of Guix.
Thanks for your work writing this summary, Morgan.
I think the latter point of view, the "conservative" view, actually repr=
esents a somewhat radical break from how the Guix project has organized =
itself thus far. We've always focused on the GNU "freedom zero": the fre=
edom to use the software as one sees fit.
https://www.gnu.org/philosophy/free-sw.en.html#four-freedoms
If we start hard-coding restrictions on how users can use Guix and the f=
ree software it provides, we are turning our back on that value.
Second, I think the discussion here is being clouded by the fact that ZF=
S is a cause c=C3=A9l=C3=A8bre in the world of copyleft licensing.
It's the same as if someone linked OpenSSL 1.0 with a GPL program for th=
eir own use. That was a useful thing to create, but the old OpenSSL lice=
nse did not permit redistribution. Although Guix tried avoid creating th=
ese combinations in our packages, we would have never sought to prevent =
users from doing so.
To build on that scenario, I could link ZFS with Linux, build it on my o=
ffload server, and use it on the servers I control. That is, I'd be subs=
tituting it. But I would not be distributing it to a 3rd party, so the c=
opyright licenses would not apply.
Leo
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 16 Feb 2025 18:28:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 13:28:37 2025
Received: from localhost ([127.0.0.1]:37230 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tjjNd-00058n-Bh
for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 13:28:37 -0500
Received: from mail-4316.protonmail.ch ([185.70.43.16]:43263)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>)
id 1tjjKY-0004wp-Ug
for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 13:25:29 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me;
s=protonmail; t=1739730320; x=1739989520;
bh=1uYdIaxOdei/Tn6Y7mRjJXMqCqNRmX1PhbROIPxaL24=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
b=aWDcEEWwnvywYbSHiPZzuyc0N9aanaE5POO4p8gu9m/s17GtdyX8WfDPIVyUNdTtY
3lUSiYM9GGFLlm/55Y72ippok+fmNIVrO5YNGV81hdomhPgdDS1qsRTF2nA01o9s2k
2ca1H48/+2uSImMpQlZW2uNHwZiKvj7lf4SOaJUlZT+/cAMEij9/soFhseZ5QHJt4Y
X5JaOCkidYDqVonh+WDaHJ9ceUduzIdCModiMrv/eq8RAUBKt1Hkvw3r+/jjA1x4Wp
HI3SCKoEy2nKVwuCFpU1sDlo4NzP/5T6+CoxES7rdTllpPVCV2HQJEsnTZYISW5n0O
XrcehiHFzUR0Q==
Date: Sun, 16 Feb 2025 18:25:12 +0000
To: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
From: Morgan Arnold <morgan.arnold@HIDDEN>
Subject: =?utf-8?Q?Re:_bug#55231:_[PATCH_v1]_initrd:_Allow_extra_search_paths_with_=E2=80=98initrd-extra-module-paths=E2=80=99?=
Message-ID: <Z_R-GqCPE0Fil07ukiYc7ubqjVk39lZIheRItdeE-lJyIPG7MrFM9QBKomWR5mX72vDU5tIFJCmVwhYekOMTh0DlsHVA2KggPchBO2ChZ-o=@proton.me>
In-Reply-To: <878qq5pz2x.fsf_-_@HIDDEN>
References: <353146a4da0938e592fa4333b601abf5b98d937d.1739710358.git.maxim.cournoyer@HIDDEN>
<3a29ed41b52ef12aa92d31ff740b01777785e6c6.1739710358.git.maxim.cournoyer@HIDDEN>
<878qq5pz2x.fsf_-_@HIDDEN>
Feedback-ID: 45510636:user:proton
X-Pm-Message-ID: 2459107532d9eb7cc03e966cc7195417e87b8d6d
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 3.0 (+++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Ludo, I'll try to (hopefully accurately) summarise the
discussion. > Who would distribute it though? A build farm building a
ZFS-enabled
> initrd, right? Is that a real use case? (Perhaps this has already been
> answered before; please let me know what I should look [...]
Content analysis details: (3.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
3.0 MANY_TO_CC Sent to 10+ recipients
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE:
The query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[185.70.43.16 listed in sa-accredit.habeas.com]
-0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[185.70.43.16 listed in wl.mailspike.net]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [185.70.43.16 listed in list.dnswl.org]
0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[185.70.43.16 listed in bl.score.senderscore.com]
-0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
X-Debbugs-Envelope-To: 55231
X-Mailman-Approved-At: Sun, 16 Feb 2025 13:28:36 -0500
Cc: Josselin Poiret <dev@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>,
Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Ian Eure <ian@HIDDEN>,
Mathieu Othacehe <othacehe@HIDDEN>, Brian Cully <bjc@HIDDEN>,
Leo Famulari <leo@HIDDEN>, Andreas Enge <andreas@HIDDEN>,
Kaelyn <kaelyn.alexi@HIDDEN>,
Felix Lechner <felix.lechner@HIDDEN>,
John Kehayias <john.kehayias@HIDDEN>,
Christopher Baines <guix@HIDDEN>, 55231 <at> debbugs.gnu.org,
Simon Tournier <zimon.toutoune@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.0 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hi Ludo, I'll try to (hopefully accurately) summarise the
discussion. > Who would distribute it though? A build farm building a ZFS-enabled
> initrd, right? Is that a real use case? (Perhaps this has already been
> answered before; please let me know what I should look [...]
Content analysis details: (2.0 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust
[185.70.43.16 listed in list.dnswl.org]
3.0 MANY_TO_CC Sent to 10+ recipients
0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE:
The query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[185.70.43.16 listed in sa-accredit.habeas.com]
0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[185.70.43.16 listed in bl.score.senderscore.com]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)
[185.70.43.16 listed in wl.mailspike.net]
-0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
Hi Ludo,
I'll try to (hopefully accurately) summarise the discussion.
> Who would distribute it though? A build farm building a ZFS-enabled
> initrd, right? Is that a real use case? (Perhaps this has already been
> answered before; please let me know what I should look at, it=E2=80=99s a=
long
> discussion!)
As you note, the only person who would distribute such a pre-compiled initr=
d would be someone who built one and shared it, say with `guix publish`. A =
lot of the discussion essentially boils down to one question: is Guix respo=
nsible only for not committing copyright violations itself, say by not dist=
ributing such a pre-compiled initrd itself, or is Guix also responsible for=
putting in guardrails to prevent users from accidentally committing copyri=
ght violations? If you subscribe to the former view, then the original chan=
ges proposed by Brian are entirely acceptable as is. If, instead, you subsc=
ribe to the latter view, then this change may be unacceptable, as it facili=
tates the accidental commission of copyright violations by users of Guix. T=
he changes made here to derivations are an attempt to allow users to create=
ZFS-compatible initrds in a manner which is compatible with the latter (mo=
re conservative, in some sense) view of the responsibilities of Guix.
> > + (let* ((substitutable-inputs? (every substitutable-derivation?
> > + (map derivation-input-derivation
> > + inputs)))
>=20
>=20
> This change doesn=E2=80=99t come for free. I didn=E2=80=99t follow the di=
scussion, but
> adding overhead to such a core component to accommodate ZFS sounds
> questionable to me.
I agree that this is quite a lot of overhead. However, if one subscribes to=
the second view regarding the responsibilities of Guix, then some change l=
ike this seems to me to be required if we are to support Guix on ZFS at all=
. It might be possible to have the best of both worlds, by introducing a ne=
w parameter to the `derivation` function which controls whether or not `#:s=
ubstitutable? #f` has this propagating behaviour. We could then restrict th=
ese large-overhead computations over entire dependency graphs to initrds on=
ly, which I think would reduce the overhead to an acceptable level. If the =
consensus is that we ought to be preventing users from accidentally committ=
ing copyright violations, and that the level of overhead introduced by this=
change is unacceptable, then I think that the way forward is by implementi=
ng this new parameter, say `#:propagating-substitutable?` or similar.
Best,
Morgan
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 16 Feb 2025 18:17:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 13:17:30 2025 Received: from localhost ([127.0.0.1]:37162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tjjCq-0004Gb-R2 for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 13:17:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47246) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1tjide-0006kC-46 for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 12:41:06 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1tjidX-0008Pm-Id; Sun, 16 Feb 2025 12:40:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=wmi9qaSSq8clblBHTd3/h+WPdQy1H4/qNYKnjJbaODs=; b=OL2/62my0FsiKx64Gm3M 2iSohWdcr4Wu0T1ilfH2D79ryyYqRwuhpw+MAvdHvbc9AmKKqud+zTaVBHKnlv89wh6FxydlauBcb wgYr4M2tRbIaWT0Na4mgnh6hbIdmKiLT1NLnInzYEfjUGIYxD5AlWEQqK0D4Fa1oA1x0EEiYp/nG+ F9/ImNmYUjsV3G17Pbiy76H/L0rrA/gWsmdNCLYJ5BWEdzAIC8yj8fM56BbDWj621e7s1ypNjjOiX uNAgYEg0IOICYfTjDHQJV8UZuRRVOIHKK8pvBUv7pNwdiATrrehGhw3aacDfDDKKDwTULQGSjicYB KpRjWEbT5AyN2Q==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Subject: Re: bug#55231: [PATCH v1] initrd: Allow extra search paths with =?utf-8?Q?=E2=80=98initrd-extra-module-paths=E2=80=99?= In-Reply-To: <3a29ed41b52ef12aa92d31ff740b01777785e6c6.1739710358.git.maxim.cournoyer@HIDDEN> (Maxim Cournoyer's message of "Sun, 16 Feb 2025 21:52:48 +0900") References: <353146a4da0938e592fa4333b601abf5b98d937d.1739710358.git.maxim.cournoyer@HIDDEN> <3a29ed41b52ef12aa92d31ff740b01777785e6c6.1739710358.git.maxim.cournoyer@HIDDEN> Date: Sun, 16 Feb 2025 18:40:54 +0100 Message-ID: <878qq5pz2x.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 55231 X-Mailman-Approved-At: Sun, 16 Feb 2025 13:17:27 -0500 Cc: Josselin Poiret <dev@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>, Ian Eure <ian@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Brian Cully <bjc@HIDDEN>, Leo Famulari <leo@HIDDEN>, Andreas Enge <andreas@HIDDEN>, Kaelyn <kaelyn.alexi@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, John Kehayias <john.kehayias@HIDDEN>, Christopher Baines <guix@HIDDEN>, 55231 <at> debbugs.gnu.org, Simon Tournier <zimon.toutoune@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.3 (/) Hello, Maxim Cournoyer <maxim.cournoyer@HIDDEN> skribis: > From: Morgan Arnold <morgan.arnold@HIDDEN> > > This commit changes the conditions under which derivations, as > constructed by the `derivation' procedure, are made substitutable, to > prevent potential copyright violations related to the construction of > substitutable initrds including non-substitutable derivations (in > particular, ZFS). > > This change prevents such copyright violations by only marking a derivati= on as > substitutable if it is itself marked substitutable along all of its input= s. > This means that non-substitutable derivations propagate to other derivati= ons > using them as input. Hmm. > + (define (user+system-env-vars inputs) [...] > + (let* ((substitutable-inputs? (every substitutable-derivation? > + (map derivation-input-derivation > + inputs))) This change doesn=E2=80=99t come for free. I didn=E2=80=99t follow the dis= cussion, but adding overhead to such a core component to accommodate ZFS sounds questionable to me. > + ;; DRV2 is *not* available as a substitute, since it has drv1 = as > + ;; input, and the non-substitutability is viral to avoid > + ;; distributing non-substitutable items that could have become > + ;; embedded, for example in an initrd. Who would distribute it though? A build farm building a ZFS-enabled initrd, right? Is that a real use case? (Perhaps this has already been answered before; please let me know what I should look at, it=E2=80=99s a l= ong discussion!) Ludo=E2=80=99.
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 16 Feb 2025 14:33:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 09:33:30 2025 Received: from localhost ([127.0.0.1]:33032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tjfi6-0001Qq-7U for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 09:33:30 -0500 Received: from mail-10629.protonmail.ch ([79.135.106.29]:29651) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>) id 1tjfi3-0001QY-Ju for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 09:33:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1739716400; x=1739975600; bh=UtBm3pBciu3ZTVKURCR6rgm5E4TsfqFCMm9eEcEVSR0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=cPRhrvTGWqqp1gm7GnXk1P+j12pg2Aw21qLElNn3Qj5K1AZ2g5PcNxQ0rvViqLZuC 9esQ2hNCY4yTVmX62CJA8tZJxRZ5ge9XAOT/CA52ATeqsduwkBLgEJd186qWUOXePZ e7dSWxuH4jqP5SqMoPLyCAU6GPFaQ7go8KTrGeXSOLwfUTkeHm/bB0j0C8JXv1qvg/ hNwew2NifqMO9bORT2NR2HfscJMdQuFJHAKhY95o7doLNRDDm0a+BToNSjxJIqvbbk uCmD0AUbx8+7mSxmDK/VFlt5wX8eCl9C9VP5CZztz3HH9o4rco2XgnOTuzAIWjBBcv /PkQoyrZsgxXg== Date: Sun, 16 Feb 2025 14:33:14 +0000 To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> From: Morgan Arnold <morgan.arnold@HIDDEN> Subject: =?utf-8?Q?Re:_bug#55231:_[PATCH_v6]_initrd:_Allow_extra_search_paths_with_=E2=80=98initrd-extra-module-paths=E2=80=99?= Message-ID: <xuCxCqhMsfsl2QgR2gPQJ4Ou-cYLgOTv73lISH6TWDlNhQ_sXP_Wq1baCEfdomXPNtwePOflmD54JNNP7yFT5r05woVfDtVumVlT7sgZAxM=@proton.me> In-Reply-To: <87frke3v6e.fsf_-_@HIDDEN> References: <JTtAimnNMICUW-We530BE44G5KpCO2CoYASQY0J4ThyM0PF-Q0HIlIsjt4j1SdsjjPBobI-0iYoARfw5MmWiYoeC6hATg9llGDhWg6Ku4MA=@proton.me> <Z6oCQMYpj2R98syY@jurong> <VBHM6E4b-4Rwi1VeyYGs9CNojT6aQ5kKvXr8yBjlHZUpRCoJgkmWNBtW1sYZs6FZ1r5hDHuj-cB9VvWXmZ29GM0P3dwRY-VSboFzryTvPAY=@proton.me> <875xlgvd9h.fsf_-_@HIDDEN> <iOT1aqNUX2hG8nPSfPERteM0XkN1mz1C-SoW2AYX_UjEEDIOe1FnHzWXnR5QlCYdU5rMpYEjwDCrJ8QofUff5U98_ohVR3sZtEjBpCSHeXE=@proton.me> <aOt786iZX9EVyqAJO1tCSe7ev0OcCN8c5NKIsOkoGUd95ljy7L9_V3QEmXdeD7tAKq-UMGWzJnvt5az51foPXPwHYODD3RNCCeyf8VB7EVU=@proton.me> <87frke3v6e.fsf_-_@HIDDEN> Feedback-ID: 45510636:user:proton X-Pm-Message-ID: 4da506adb006ab789c8b984a7df79b81880fbb7a MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, "ludo@HIDDEN" <ludo@HIDDEN>, "john.kehayias@HIDDEN" <john.kehayias@HIDDEN>, Andreas Enge <andreas@HIDDEN>, "kaelyn.alexi@HIDDEN" <kaelyn.alexi@HIDDEN>, "guix-devel@HIDDEN" <guix-devel@HIDDEN>, "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.0 (--) Hi Maxim, Your help is much appreciated! The changes all look good, but there is one = thing which is alarming me somewhat. Perhaps I am misunderstanding how the = `substitutable-derivation?` function actually operates, but if I apply thes= e patches and then run, say: ``` (use-modules (guix) (gnu) (gnu packages bash)) (define store (open-connection)) (display (substitutable-derivation? (package-derivation store bash-minimal)= )) ``` it prints `#f`, which seems quite contrary to what I would expect. Oddly en= ough, despite this, Guix still seems to fetch a substitute for `bash-minima= l` from Cuirass. In this sense it doesn't cause a problem, but I don't unde= rstand why the above script prints `#f` despite Guix fetching a substitute. Hopefully this is just a misunderstanding on my part and the changes are ac= tually completely fine. Best, Morgan
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 16 Feb 2025 13:41:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 08:41:08 2025 Received: from localhost ([127.0.0.1]:32834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tjetP-0004D7-P3 for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 08:41:08 -0500 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]:58547) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tjetK-0004CS-GX for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 08:41:05 -0500 Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-2fc0026eb79so6582330a91.0 for <55231 <at> debbugs.gnu.org>; Sun, 16 Feb 2025 05:41:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739713256; x=1740318056; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=lZH3gQcDYJdvQ/kqwsOyLt/Igx4jeXfyXPRvfH5vLbA=; b=W4hyu803HvcyKQzwoNoVc0vuV/d1wtSsf9xMhW/77ljMsrzV50BRg4hulZnUIO+NuQ Dt40/jnUw4XxgAIpwkH7+ZwanFU6XLmDXLcV4/qTmY236HlSBl7cTgT6Rdvxh84BOEPm tx0yxxQtF4FybmvunkTX9jz0JQVFSw3ez8NMBOQFdrNXrzfnyAvErWczEWH3VW/9vp8l 2f/+AOrSH8CI3fBk05lRbG1BVQL+Tk/AaVkj3efx2hNTi8NJJV2AojPB4kI4+aSGRcsu +lUuX3XbJcccLsCJLwIlFVuTB6si7wQp65cHJi2OK5mzMzNOqLlXAcrCZ5/XknGV1P1u h+LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739713256; x=1740318056; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lZH3gQcDYJdvQ/kqwsOyLt/Igx4jeXfyXPRvfH5vLbA=; b=khaKNF6UAp7rRRxFSgohvusPJka0NjDm8z/MBDnK3bMIJ7SJAVtLzEEL9D7epWhTyE UTMnFKmzE8e8o1pMetQFDv0dOcBZuaK/2bhI2mesIm0arLFj7H2GCo3Y8VcUl2iqQvsp YjlAx1WSJyNP6VG1CaQ/gVsFIJVxwDDKp7nNOrqMxL7G5ASq6Rdqt17uK2HLoZUR8T7n CU9pxRKdVF1BVpIeJSwML6eIXUMslg6mjAGvcieHALezrAqoGMCyG5dP0CIiZR2WQKH1 M6u8Z2L9rhKPGCMMh7OyaaGZa0+wi3HOARQsCFxd3WS8O/v8UB4HogW+m9rM6WDRZ8Au xxPQ== X-Forwarded-Encrypted: i=1; AJvYcCVA/AopuIZI5kBBaw2hAyrgFOebwyE7WdFdOQ0U1QQoWqPwWSIHECSu7COQy6vx05c4YZm3Qg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwR8j+F8kbpQ0Fw0utz/FT8dQum0nVrXTO//Y9spqPGBoFM2Yol T0ZSLusLFHOQH7jmnN/krXY0EBxEa9tktGYlhSpnmvWTZycqfMoc X-Gm-Gg: ASbGncsH6r9KKbSM6b9wR7p6R3A28y8EICX7fzlbMvDqJwUqDRTbKUtnV/SZG1X7AfF YRWqYA32BtgsiJ252J3WmA+E2dBj9KzB9hy9wseVAmHBCEj1dhFkygwgAFLuvG2vRv7rqKLezY/ zzGG3SMFEikUlGl+iU5Qm8bfvGjrlhJ1KNT4Zhzh/bDzPRjcFtXsuBiYApmQm+32JRZu00uE188 EOB12q53lhyeUgPhBuFJTTIFc46DkvBg2Wlim0MPC+999dgwotJ3K4Uab8sd54674ag9fl5Utid wrVyH3ToNhgQ X-Google-Smtp-Source: AGHT+IH1bETEN5ls87r/5PSlHCS1VoXynZGEfbXGu/D4IUIknkb2O67dT7sCIPmvmdPfuDRsUpuWLA== X-Received: by 2002:a17:90b:1e0e:b0:2ee:8427:4b02 with SMTP id 98e67ed59e1d1-2fc41049fbfmr9421830a91.28.1739713256488; Sun, 16 Feb 2025 05:40:56 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fc13ad4384sm6288477a91.22.2025.02.16.05.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 05:40:55 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Maxime Devos <maximedevos@HIDDEN> Subject: Re: Understanding #:substitutable? and #55231 In-Reply-To: <6af9b9dd-313a-4eb5-92c1-2edc42bed113@HIDDEN> (Maxime Devos's message of "Sun, 9 Feb 2025 20:46:33 +0100") References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <_vvV6oht3R-W5PqRtwQhRBDb8q-O40J39F7fnTG3JLHVXOujpZdQ4s-G85O27ErbFokl95RtkiUBXlE8pLJVFsnN6-ANPTMGK4Vq0iBUP_I=@protonmail.com> <6af9b9dd-313a-4eb5-92c1-2edc42bed113@HIDDEN> Date: Sun, 16 Feb 2025 22:40:41 +0900 Message-ID: <87bjv23t46.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: GNU Guix maintainers <guix-maintainers@HIDDEN>, Ian Eure <ian@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Kaelyn <kaelyn.alexi@HIDDEN>, "Morgan Arnold via Development of GNU Guix and the GNU System distribution." <guix-devel@HIDDEN>, 55231 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Maxime, Some of your replies in this thread are overly aggressive, in clear violation of our Code of Conduct. Please refrain from singling out a group of people and assigning labels to them, or calling out someone specifically in a negative light. Since this is not the first time this has happened and has been flagged by the community, the Guix co-maintainers are putting you on a 2-week temporary ban starting now and ending on *March 2nd, 14h00 UTC*. This should give you ample time to re-read our Code of Conduct. Please refrain from all interaction with the community during this period, including sending mails to public Guix lists or the bug tracker, or on the project IRC channels. This includes responding to any messages that may (also) be addressed to you. Attempting to evade this short ban will result in a longer one. Maxim, On behalf of the Guix co-maintainers.
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 16 Feb 2025 12:56:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 07:56:32 2025 Received: from localhost ([127.0.0.1]:60874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tjeCG-0007RZ-Dg for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 07:56:32 -0500 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:50368) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tjeCE-0007RK-P2 for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 07:56:31 -0500 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-220c4159f87so45995045ad.0 for <55231 <at> debbugs.gnu.org>; Sun, 16 Feb 2025 04:56:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739710584; x=1740315384; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Z/+1mxy0Drdp0XorZYKfRFVsauYCM2O4P9cM3h2LT7A=; b=e8pd0CENDTYhZYFDiTdTls0Mif4v1haM7y7P2FvuV6i/In6hP02I4YNCczKIko6ETU JPzhqY1HFO49vMQdQtsO3CGYds+bj+hC4+DXvM0g6QYhxGDuQlpcJLKPq1Y7IfCviM6H wFldKf2UNoppP/Rdnlxpe7W6mxKP4eWNC5kGM4garwiRM/UfkQl96Taz/ABfKd21BBes Td3J5ELmbdoaJQJHhvb09Pm6pgAFnezmpfoS1p+CyASPWqpfiN5BTMSf8LbvVLNxdLZe l+f7u55nK27wX2kO+AkbHQXZk0l4paArEsuKMa1lDSAOBMq/iNUYAiFFCfY2MrADAxuY mVdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739710584; x=1740315384; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z/+1mxy0Drdp0XorZYKfRFVsauYCM2O4P9cM3h2LT7A=; b=enmpegqDKuVelE0LnnwlkYkES4FYG1iufRvpaYqF9RfO7CJuYsNYbEGSxlktlqZdW8 Dhylh059SyOIOK120IjUyPQQppfC0jZPeEi5IdUI3WM+jhIIdoDjASFj4UZsSidPWogZ i5VYK4FDeKMXBUTBkWF+lfB+7i2fjmE244GCqFIPwGC/Ti+jg3R/WxFS9131VX1RzDK5 ZDk+jQ1rU2SV9+iHC1oUnOqVrV7NeuQZpetqVhR6Jy3DOonpjSxIvmKF8maW3Nz340eG my2SsqP6JGMvEkVWiqVMM4WguYPTf5FzDrYBXvBTMhVRgBiy8kQrTjQssxYVq9NtGTHC uBGw== X-Forwarded-Encrypted: i=1; AJvYcCVrtq7XIwxcyGMZvgdMpRlLZEIptfXT0wJ1gWkDWGvfiisXKptP/jedWaeqHtMdfHvCP/hB1A==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy46veqmuitLNydirMkZpnmAgsUnxwFhS7g7CgszBkPL5DHRHho KcU+7nBLav3z6aDwKerlNUvqtvf9MPfbmby1Do5fHhPkYNt8dae/eCcRx9/u X-Gm-Gg: ASbGnct44t9pq6Z1jLtQNzcnEvgqhc7dTJbdbGii9EfhcjfjDtjnOvDIC4BHrvQBmUT xgDrJLNm51An+Sea7KJ/wGVfdenBbaSZiL2Vcr5O1oI8HrLuzvpt0vMOoZWROBTWOVXF5dUYgBt m1ifPGvJzTBPb5vgWTs6yYh3igstfQGVYlK27Dsu8nTdzu78JSJ2nyJx0wlNSqF1jroofFGhwwi D1uYQ6vSksKrND5r9kAPHHprLL237wb2ZMLiIwONeLJ/1PI3GJCxq8ST04OhyjnW7bdhnAy0u4L M/vHiUiWXnG1 X-Google-Smtp-Source: AGHT+IEbHoefbmabHrtQ9ML2ASPzVPaIpcMr2A/nCXlogT18m+dfcXwcY5xQ6sV4Gp4Yry4+EHL3vg== X-Received: by 2002:a05:6a21:999f:b0:1e8:bd15:6801 with SMTP id adf61e73a8af0-1ee8cbf9aa3mr11592654637.29.1739710583919; Sun, 16 Feb 2025 04:56:23 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-addc7e25d20sm2518363a12.30.2025.02.16.04.56.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 04:56:23 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Morgan Arnold <morgan.arnold@HIDDEN> Subject: Re: bug#55231: [PATCH v6] initrd: Allow extra search paths with =?utf-8?Q?=E2=80=98initrd-extra-module-paths=E2=80=99?= In-Reply-To: <aOt786iZX9EVyqAJO1tCSe7ev0OcCN8c5NKIsOkoGUd95ljy7L9_V3QEmXdeD7tAKq-UMGWzJnvt5az51foPXPwHYODD3RNCCeyf8VB7EVU=@proton.me> (Morgan Arnold's message of "Wed, 12 Feb 2025 19:41:22 +0000") References: <JTtAimnNMICUW-We530BE44G5KpCO2CoYASQY0J4ThyM0PF-Q0HIlIsjt4j1SdsjjPBobI-0iYoARfw5MmWiYoeC6hATg9llGDhWg6Ku4MA=@proton.me> <Z6oCQMYpj2R98syY@jurong> <VBHM6E4b-4Rwi1VeyYGs9CNojT6aQ5kKvXr8yBjlHZUpRCoJgkmWNBtW1sYZs6FZ1r5hDHuj-cB9VvWXmZ29GM0P3dwRY-VSboFzryTvPAY=@proton.me> <875xlgvd9h.fsf_-_@HIDDEN> <iOT1aqNUX2hG8nPSfPERteM0XkN1mz1C-SoW2AYX_UjEEDIOe1FnHzWXnR5QlCYdU5rMpYEjwDCrJ8QofUff5U98_ohVR3sZtEjBpCSHeXE=@proton.me> <aOt786iZX9EVyqAJO1tCSe7ev0OcCN8c5NKIsOkoGUd95ljy7L9_V3QEmXdeD7tAKq-UMGWzJnvt5az51foPXPwHYODD3RNCCeyf8VB7EVU=@proton.me> Date: Sun, 16 Feb 2025 21:56:09 +0900 Message-ID: <87frke3v6e.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, "ludo@HIDDEN" <ludo@HIDDEN>, "maximedevos@HIDDEN" <maximedevos@HIDDEN>, "john.kehayias@HIDDEN" <john.kehayias@HIDDEN>, Andreas Enge <andreas@HIDDEN>, "kaelyn.alexi@HIDDEN" <kaelyn.alexi@HIDDEN>, "guix-devel@HIDDEN" <guix-devel@HIDDEN>, "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Morgan, I needed to do some changes and adjust one test, but in v6 the derivations tests now pass, and the regular operation of Guix appears otherwise unaffected, which is good (I don't need to rebuild say, Libreoffice). Could you test? -- Thanks, Maxim
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 16 Feb 2025 12:53:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 07:53:47 2025
Received: from localhost ([127.0.0.1]:60818 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tje9b-0007Fz-93
for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 07:53:47 -0500
Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:55628)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
id 1tje9X-0007FH-Po
for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 07:53:44 -0500
Received: by mail-pl1-x634.google.com with SMTP id
d9443c01a7336-220bff984a0so61407895ad.3
for <55231 <at> debbugs.gnu.org>; Sun, 16 Feb 2025 04:53:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1739710417; x=1740315217; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=w1WyFeWIP6FgMY04mB07xpdqvsdZ3qMec56fZMylY3k=;
b=lcWNGT2yc47SpCuiORWUSHcPQQeCjpojJv8nC5gs1yaTdtrajhwNCOvVZDD5LhMuu6
+9F/OzBRHWBT5pnuljK8dhD2uhdyfQsGV33CiCYVnLOfdUWk3YF0dJ7aC0i+FqhdJzM6
85NF+5bXmds5GAzLBRLDlbryOCwbaIostMekLSM9DZidXY0K1pgmIaubyXXG4wnhOkyG
VVvCp1tSGGWSJ+Ns0BFw4DjUziC7mLSmuEujfy+ypH0ARAumDp9Uwr1AQq3N+CTtl3pP
lzPxr52eB9ZaVxT6lhBCfs/UA2jlovfnGFCvP2yMp11SAapoKgUKYNnAKjxDL8Ub7sO/
VAVA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1739710417; x=1740315217;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=w1WyFeWIP6FgMY04mB07xpdqvsdZ3qMec56fZMylY3k=;
b=YCTu1Y6QtPSkB2/JkPK1Bj5CzyaVKD+uvLKIzNbkX/XNQPPcWKsIzEq2j5C0d8FoH7
U7z/Y+wrj9Y2j8cotvJYdtaFuJ+LxZeNu/YhDVjQc8Zh4reNgfGXziXI4Cxfqoi79Ct4
M2sJ50xjnLvDqXGdVcVQm0tYY5TDSX8PBz62c7At13YBCtBuuUXltlUsC9Kq8bTNw/c+
T8YPhfdps1tfmwzmbUprMkKTClA6zWX/TCq+/uJKCcDTWAnwEDNio1xh8VBGjsT5oLn5
UzSK5OJl8XeQQbon0Nu/YcGayjzkSXqhNmE260Ym6AxrNsJ1NrHLsIm3n5QVAVz4TuY6
+UJw==
X-Gm-Message-State: AOJu0YxNiaHSh6B0J4H4FVcX48rV4E2rPsuS33wqvLlcWX4DeQC7HkKv
ro81+pDNpSAlfbQcIWahDZOGoD9/6Zv9vO2JSR/VRN1+Eiaq6xno4Z7BgJWu
X-Gm-Gg: ASbGncsXuKtTO/5O8zuGs4BtyVcJdxTuKIOzp1jEXjT0xScRro0eVYidjVB6IDv3cta
opfcB/b1eNkJmJkqqaTFOPn3bp/wNREwbN+qmeMQM4e17O/5ZnWakcj75O+mOnBOjivIsOZ8zWK
MbbiZwj97c4fSBB8w108N1K0qPziIOiVuITdlO7EPEAR21+Bhs16loMBaod4yarQrS1eiw3dC2q
TH3Mwl+svjBqmbH7SLrhxedxtXjhJiO2iOTS1rgAqW6GXn+tY6r6v0O4nV4svVTgDvLsET7Qaoz
ZuRKUhgu/28LZZ+iml/6Ucmvl6ytB6TX4g==
X-Google-Smtp-Source: AGHT+IGKPYzStDao+WtNVe3edM/CCDiWTZCHitBlwZMIjyJDUobdavi3kO/v1KyN8q4qof6QvVpTjQ==
X-Received: by 2002:a17:902:ef49:b0:21f:c67:a68a with SMTP id
d9443c01a7336-22104081daemr99817485ad.31.1739710416776;
Sun, 16 Feb 2025 04:53:36 -0800 (PST)
Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89])
by smtp.gmail.com with ESMTPSA id
d9443c01a7336-220d82e843fsm54178725ad.220.2025.02.16.04.53.35
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 16 Feb 2025 04:53:36 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: 55231 <at> debbugs.gnu.org
Subject: [PATCH v6 4/4] Propagate non-substitutability of derivations.
Date: Sun, 16 Feb 2025 21:52:48 +0900
Message-ID: <3a29ed41b52ef12aa92d31ff740b01777785e6c6.1739710358.git.maxim.cournoyer@HIDDEN>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <353146a4da0938e592fa4333b601abf5b98d937d.1739710358.git.maxim.cournoyer@HIDDEN>
References: <353146a4da0938e592fa4333b601abf5b98d937d.1739710358.git.maxim.cournoyer@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Brian Cully <bjc@HIDDEN>, Maxime Devos <maximedevos@HIDDEN>, Kaelyn <kaelyn.alexi@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ian Eure <ian@HIDDEN>, John Kehayias <john.kehayias@HIDDEN>, Leo Famulari <leo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, Andreas Enge <andreas@HIDDEN>, bjc@HIDDEN, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Christopher Baines <guix@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: Morgan Arnold <morgan.arnold@HIDDEN>,
Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
From: Morgan Arnold <morgan.arnold@HIDDEN>
This commit changes the conditions under which derivations, as
constructed by the `derivation' procedure, are made substitutable, to
prevent potential copyright violations related to the construction of
substitutable initrds including non-substitutable derivations (in
particular, ZFS).
This change prevents such copyright violations by only marking a derivation as
substitutable if it is itself marked substitutable along all of its inputs.
This means that non-substitutable derivations propagate to other derivations
using them as input.
Change-Id: I80ba4a371ee0c55a1294aff311d4e7b151055fac
Signed-off-by: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Modified-by: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
---
guix/derivations.scm | 53 +++++++++++++++++++++++--------------------
tests/derivations.scm | 16 +++++++------
2 files changed, 37 insertions(+), 32 deletions(-)
diff --git a/guix/derivations.scm b/guix/derivations.scm
index ffa69e924c..f4e7c56981 100644
--- a/guix/derivations.scm
+++ b/guix/derivations.scm
@@ -868,33 +868,36 @@ (define* (derivation store name builder args
env-vars)
#f)))))
- (define (user+system-env-vars)
+ (define (user+system-env-vars inputs)
;; Some options are passed to the build daemon via the env. vars of
;; derivations (urgh!). We hide that from our API, but here is the place
;; where we kludgify those options.
- (let ((env-vars `(,@(if local-build?
- `(("preferLocalBuild" . "1"))
- '())
- ,@(if (not substitutable?)
- `(("allowSubstitutes" . "0"))
- '())
- ,@(if allowed-references
- `(("allowedReferences"
- . ,(string-join allowed-references)))
- '())
- ,@(if disallowed-references
- `(("disallowedReferences"
- . ,(string-join disallowed-references)))
- '())
- ,@(if leaked-env-vars
- `(("impureEnvVars"
- . ,(string-join leaked-env-vars)))
- '())
- ,@(match properties
- (() '())
- (lst `(("guix properties"
- . ,(object->string properties)))))
- ,@env-vars)))
+ (let* ((substitutable-inputs? (every substitutable-derivation?
+ (map derivation-input-derivation
+ inputs)))
+ (env-vars `(,@(if local-build?
+ `(("preferLocalBuild" . "1"))
+ '())
+ ,@(if (and substitutable? substitutable-inputs?)
+ '()
+ `(("allowSubstitutes" . "0")))
+ ,@(if allowed-references
+ `(("allowedReferences"
+ . ,(string-join allowed-references)))
+ '())
+ ,@(if disallowed-references
+ `(("disallowedReferences"
+ . ,(string-join disallowed-references)))
+ '())
+ ,@(if leaked-env-vars
+ `(("impureEnvVars"
+ . ,(string-join leaked-env-vars)))
+ '())
+ ,@(match properties
+ (() '())
+ (lst `(("guix properties"
+ . ,(object->string properties)))))
+ ,@env-vars)))
(match references-graphs
(((file . path) ...)
(let ((value (map (cut string-append <> " " <>)
@@ -967,7 +970,7 @@ (define* (derivation store name builder args
(filter-map input->derivation-input inputs))
derivation-input<?))
(env-vars (sort (env-vars-with-empty-outputs
- (user+system-env-vars))
+ (user+system-env-vars inputs))
(lambda (e1 e2)
(string<? (car e1) (car e2)))))
(drv-masked (make-derivation outputs inputs sources
diff --git a/tests/derivations.scm b/tests/derivations.scm
index 72ea9aa9cc..c157128f39 100644
--- a/tests/derivations.scm
+++ b/tests/derivations.scm
@@ -1105,14 +1105,16 @@ (define %coreutils
(let-values (((build download)
(derivation-build-plan store
(list (derivation-input drv2)))))
- ;; Although DRV2 is available as a substitute, we must build its
- ;; dependency, DRV1, due to #:substitutable? #f.
- (and (match download
- (((= substitutable-path item))
- (string=? item (derivation->output-path drv2))))
+ ;; DRV2 is *not* available as a substitute, since it has drv1 as
+ ;; input, and the non-substitutability is viral to avoid
+ ;; distributing non-substitutable items that could have become
+ ;; embedded, for example in an initrd.
+ (and (null? download)
(match build
- (((= derivation-file-name build))
- (string=? build (derivation-file-name drv1))))))))))
+ (((= derivation-file-name build1)
+ (= derivation-file-name build2))
+ (string=? build1 (derivation-file-name drv1))
+ (string=? build2 (derivation-file-name drv2))))))))))
(test-assert "derivation-build-plan and substitutes, local build"
(with-store store
--
2.48.1
bjc@HIDDEN, maximedevos@HIDDEN, kaelyn.alexi@HIDDEN, ludo@HIDDEN, morgan.arnold@HIDDEN, ian@HIDDEN, john.kehayias@HIDDEN, leo@HIDDEN, felix.lechner@HIDDEN, andreas@HIDDEN, bjc@HIDDEN, maxim.cournoyer@HIDDEN, guix@HIDDEN, dev@HIDDEN, othacehe@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 16 Feb 2025 12:53:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 07:53:43 2025
Received: from localhost ([127.0.0.1]:60815 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tje9W-0007Fh-QW
for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 07:53:43 -0500
Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:48502)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
id 1tje9S-0007F6-SS
for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 07:53:39 -0500
Received: by mail-pl1-x62f.google.com with SMTP id
d9443c01a7336-220c8cf98bbso71265065ad.1
for <55231 <at> debbugs.gnu.org>; Sun, 16 Feb 2025 04:53:38 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1739710412; x=1740315212; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=EbAN8FGWF+f5d2LmSP+kV7+TqTUBNPQJI3m3X4lf/Bo=;
b=lvlwCrktFqijLszgdYhP3E5ybXVqvJ1PCu11JrTtmISYF/LVKtJ/QHy2XnugTpNvqo
1uEQFW2xhPhMUvBqiAGWCEmh34cNlfnTEiQCPsNtHE0z0BK4le3pvoPnvh/pAlww8YZq
FsdGo1bRQJgBWexeFOXd6CKdldWU/OdkYaWQLteuxb10FLFyQfja7bfES1n9eEbI9XSK
1UnRT8CvkiN6b96/xoNIdB/RKdg9cIv6oEvUJEzHh8QsixfKTys8ZPLX1LYGKNlnWKkz
QaQ5FVRSxSDNjQo6weW07xsRi67/sPnqv+dIvb3iVURIA8uBVjffxu/wqwd3oaoUrikL
hCkw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1739710412; x=1740315212;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=EbAN8FGWF+f5d2LmSP+kV7+TqTUBNPQJI3m3X4lf/Bo=;
b=Tt/yD2A/Qb9vnrx+V9zsbNJyBA3+j20KW4eGfl+YvfUPeY5n008H101zpp1jq9eYWS
AfnaZb+1pXH0ey5cwEX6X7S5MoUjk4g+eul4thNzPFf4Tg/Tc7xCCqI+zbDY3PL/JjzR
uf+YUrGHyOFIfYNb4dKuXGk91MfbSEfFjY0I3yReJ0yB3eJQWl7MR5la7SwLJkTggmfA
Olxe2QP/BfW91fRzIB2Ki6whV2zJD3sLzoxZH/NLuMtbCPRGAMdJkDbGxmTO7NLjJXaY
xcO76TQQiSnEtm1BVhD9vGxTCOGyVpH7nM32j+89HvgVkIsd6I9nfhYpNcTmbEVvYdtR
4+6w==
X-Gm-Message-State: AOJu0YxJeZa095kHfUhCepj5koqHnp3GLfPCXvOrnxUuQV8ljGVi9twV
PXVP2cDC2uRG+TjhM535tmUQiww6XyeDFyPz7SjQnIhU03YYgGK0k8zrlx4A
X-Gm-Gg: ASbGncvUSWFROXEq6y/5G2ElSUxt43KtLnZozkOTElRqS4sZ1RiDIV5/L+Ro4Vo3FWI
iaNN1r6r+l/GMEIuzRClBxqTt2u/kqg5zlapGE7sv8YRK27AP+z2fF0hBWQQ+CIK4yldV/9RUrf
58fOn9le2MDUnL476qkU+g4GL6YbZeetWpYUYePx9VuTzZvM4bsIWh5d12Jrd6GwWdXlCf0eUqx
rOW+/tPtQwURgZFHP2xyZCdvOHFY2ZvXYlkPA8ssICaVgjQPTPTqkNI/X3qS9KscCwXzWWtXEf1
Wfd40nXv/OlH6d2WXMndxgkBb9r7N6u73g==
X-Google-Smtp-Source: AGHT+IE/nO49ewr+eR9gMaxjUpx0fBcKnKtRWcvz66cewO77khz8O7SvV60fVVS37Gfj1L+GFBeWHw==
X-Received: by 2002:a17:902:dac5:b0:21f:507b:9ada with SMTP id
d9443c01a7336-2210405cc66mr96845985ad.31.1739710412268;
Sun, 16 Feb 2025 04:53:32 -0800 (PST)
Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89])
by smtp.gmail.com with ESMTPSA id
d9443c01a7336-220d82e843fsm54178725ad.220.2025.02.16.04.53.30
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 16 Feb 2025 04:53:31 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: 55231 <at> debbugs.gnu.org
Subject: [PATCH v6 3/4] tests: Remove extraneous 'with-store' in derivations
test.
Date: Sun, 16 Feb 2025 21:52:47 +0900
Message-ID: <1c9a81869981a3281b6a3ef68bda73b336be2e5c.1739710358.git.maxim.cournoyer@HIDDEN>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <353146a4da0938e592fa4333b601abf5b98d937d.1739710358.git.maxim.cournoyer@HIDDEN>
References: <353146a4da0938e592fa4333b601abf5b98d937d.1739710358.git.maxim.cournoyer@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Brian Cully <bjc@HIDDEN>, Maxime Devos <maximedevos@HIDDEN>, Kaelyn <kaelyn.alexi@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ian Eure <ian@HIDDEN>, John Kehayias <john.kehayias@HIDDEN>, Leo Famulari <leo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, Andreas Enge <andreas@HIDDEN>, bjc@HIDDEN, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
* tests/derivations.scm ("derivation fails but keep going"): Remove extraneous
'with-store'.
Change-Id: If30c2d457504b8524cd167f1a145fbbea61b513c
---
tests/derivations.scm | 45 +++++++++++++++++++++----------------------
1 file changed, 22 insertions(+), 23 deletions(-)
diff --git a/tests/derivations.scm b/tests/derivations.scm
index efcd21f324..72ea9aa9cc 100644
--- a/tests/derivations.scm
+++ b/tests/derivations.scm
@@ -150,29 +150,28 @@ (define* (directory-contents dir #:optional (slurp get-bytevector-all))
(test-assert "derivation fails but keep going"
;; In keep-going mode, 'build-derivations' should fail because of D1, but it
;; must return only after D2 has succeeded.
- (with-store store
- (let* ((d1 (derivation %store "fails"
- %bash `("-c" "false")
- #:sources (list %bash)))
- (d2 (build-expression->derivation %store "sleep-then-succeed"
- `(begin
- ,(random-text)
- ;; XXX: Hopefully that's long
- ;; enough that D1 has already
- ;; failed.
- (sleep 2)
- (mkdir %output)))))
- (set-build-options %store
- #:use-substitutes? #f
- #:keep-going? #t)
- (guard (c ((store-protocol-error? c)
- (and (= 100 (store-protocol-error-status c))
- (string-contains (store-protocol-error-message c)
- (derivation-file-name d1))
- (not (valid-path? %store (derivation->output-path d1)))
- (valid-path? %store (derivation->output-path d2)))))
- (build-derivations %store (list d1 d2))
- #f))))
+ (let* ((d1 (derivation %store "fails"
+ %bash `("-c" "false")
+ #:sources (list %bash)))
+ (d2 (build-expression->derivation %store "sleep-then-succeed"
+ `(begin
+ ,(random-text)
+ ;; XXX: Hopefully that's long
+ ;; enough that D1 has already
+ ;; failed.
+ (sleep 2)
+ (mkdir %output)))))
+ (set-build-options %store
+ #:use-substitutes? #f
+ #:keep-going? #t)
+ (guard (c ((store-protocol-error? c)
+ (and (= 100 (store-protocol-error-status c))
+ (string-contains (store-protocol-error-message c)
+ (derivation-file-name d1))
+ (not (valid-path? %store (derivation->output-path d1)))
+ (valid-path? %store (derivation->output-path d2)))))
+ (build-derivations %store (list d1 d2))
+ #f)))
(test-assert "identical files are deduplicated"
;; Note: DATA must be longer than %DEDUPLICATION-MINIMUM-SIZE.
--
2.48.1
bjc@HIDDEN, maximedevos@HIDDEN, kaelyn.alexi@HIDDEN, ludo@HIDDEN, morgan.arnold@HIDDEN, ian@HIDDEN, john.kehayias@HIDDEN, leo@HIDDEN, felix.lechner@HIDDEN, andreas@HIDDEN, bjc@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 16 Feb 2025 12:53:38 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 07:53:38 2025
Received: from localhost ([127.0.0.1]:60812 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tje9S-0007FI-9m
for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 07:53:38 -0500
Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:58391)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
id 1tje9P-0007Ex-Rg
for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 07:53:36 -0500
Received: by mail-pl1-x632.google.com with SMTP id
d9443c01a7336-220c8eb195aso72865235ad.0
for <55231 <at> debbugs.gnu.org>; Sun, 16 Feb 2025 04:53:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1739710408; x=1740315208; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=vCWWkNucH/lViQB+qrOb6fJTg0rUx0PTq+0DfEz3jR8=;
b=MpV2blfDPdbGY4dWfHYSP+fo79cs7M/1SSuHTMhcricKBgYrKewEUR34b5F9t240aW
d0sCfLvpJE8gyrzJYujWf30UT+WGiODFjQmGNXn7KDxEXu6asG3BJ1s38mmljW6e6o+P
CfkojzFqy4UnKgvolpDhBD4tTpDZTLTP98D8PsvFjoUAbjtYnn7ZnARyAmbcqNwHU/bU
skKm3nY6/s7WyAOzcuGDavFSqNfcEieSzoyRip6nO6qkERvLcIQxaw+FTveNjUBQOW1Q
RbXLG5uLL+X4hJKaOu/pQFjQmr7gSIFJCG/VHx7Y6NKkmo6mPNF2ndfijJXsYoPbZVAN
lvNQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1739710408; x=1740315208;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=vCWWkNucH/lViQB+qrOb6fJTg0rUx0PTq+0DfEz3jR8=;
b=szJjanDNOTTtOFPlap984PHMIYxLbmKnCmeSMfGTm0DWB3mEwf22ORNrxEqYvDww4s
rD1ZvpoSDCvTG75Ia/jPfWcwPyYxCk4WqsnMMuTLV2u6LkBHVE21mnqZ4siCux0GbpLt
wLQvIfMIwvhlmp9NeebhWrSOKon1ZFAOiyy/rl/1KHYVn0cgecfFYN7I7vr07vEMCqN9
k5wiAqYEjgJGRO9aWOh5luegFw3Q2y3WheyVP3YdVlV0z6yGpCo9ac0gQjIiWNpC/Aut
GHIKOJeCEVPyAXGDl5YMN9C9IpBdC7q1nhI9wvnDX/4BeWIDADFIX4YQc9DxUxC5BPmy
1RlA==
X-Gm-Message-State: AOJu0Yw7CoCheZ29xQK+lJgm5jqgPS9lGy+hmNN4rRIYmvBqTkQlsJRW
afO1/vPZrh8bSo2UbQsKA8DwzvXBmcR173m/R0jRkdfcsuJd0xjveqPKEq1v
X-Gm-Gg: ASbGnct/uuC9v6M20Mjsdo2ArIkJFQW2B5LJdCBAOBdRYUZUzbaP5pCPj332GvleiTr
QdS0wBxbRleF677H527aEr4hr4DAXidF1TbTKCAE9F3Ys/QVUms4u7vrWjGOzXLJq2nVA2FuUdV
NLaJJc0tApb4P7JvGl0JJQzcInOqpXd7heeX2FSZd9ZQGZchNoAwcnEtK4xpcQ/+4YjpBLJomI6
XpLeb3EsadQWyBn1quGpzWN5II0rdmV1Xi0UgEGGdr9VjzaTr2sK0DvhXk00Ncwy+CD+q3FV6nV
QbFcUEUD3aZnerNIvnJTru6EcxCIKqNclw==
X-Google-Smtp-Source: AGHT+IHDmnuSKOSchS/PBRIezkLv1QGBmlU9+4uX50grfU4f5tUblbKJVEtw1JAPa4FuqEZLMe6O8w==
X-Received: by 2002:a17:903:1d1:b0:220:d272:534d with SMTP id
d9443c01a7336-2210405c6b6mr114538045ad.22.1739710408364;
Sun, 16 Feb 2025 04:53:28 -0800 (PST)
Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89])
by smtp.gmail.com with ESMTPSA id
d9443c01a7336-220d82e843fsm54178725ad.220.2025.02.16.04.53.26
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 16 Feb 2025 04:53:27 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: 55231 <at> debbugs.gnu.org
Subject: [PATCH v6 2/4] derivations: Fix indentation.
Date: Sun, 16 Feb 2025 21:52:46 +0900
Message-ID: <a9d8d189296eb348403c52f6e3d42b7383008317.1739710358.git.maxim.cournoyer@HIDDEN>
X-Mailer: git-send-email 2.48.1
In-Reply-To: <353146a4da0938e592fa4333b601abf5b98d937d.1739710358.git.maxim.cournoyer@HIDDEN>
References: <353146a4da0938e592fa4333b601abf5b98d937d.1739710358.git.maxim.cournoyer@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Brian Cully <bjc@HIDDEN>, Maxime Devos <maximedevos@HIDDEN>, Kaelyn <kaelyn.alexi@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ian Eure <ian@HIDDEN>, John Kehayias <john.kehayias@HIDDEN>, Leo Famulari <leo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, Andreas Enge <andreas@HIDDEN>, bjc@HIDDEN, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Christopher Baines <guix@HIDDEN>, Josselin Poiret <dev@HIDDEN>, Mathieu Othacehe <othacehe@HIDDEN>, Simon Tournier <zimon.toutoune@HIDDEN>, Tobias Geerinckx-Rice <me@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
* guix/derivations.scm (derivation): Fix indentation.
Change-Id: I2407b59788ce335c21c181d9f9e3f26a359e9bf5
---
guix/derivations.scm | 46 ++++++++++++++++++++++----------------------
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/guix/derivations.scm b/guix/derivations.scm
index bef98cd26a..ffa69e924c 100644
--- a/guix/derivations.scm
+++ b/guix/derivations.scm
@@ -841,30 +841,30 @@ (define* (derivation store name builder args
;; corresponding environment variable.
(match drv
(($ <derivation> outputs inputs sources
- system builder args env-vars)
+ system builder args env-vars)
(let* ((drv-hash (derivation-hash drv))
(outputs (map (match-lambda
- ((output-name . ($ <derivation-output>
- _ algo hash rec?))
- (let ((path
- (if hash
- (fixed-output-path name hash
- #:hash-algo algo
- #:output output-name
- #:recursive? rec?)
- (output-path output-name
- drv-hash name))))
- (cons output-name
- (make-derivation-output path algo
- hash rec?)))))
+ ((output-name . ($ <derivation-output>
+ _ algo hash rec?))
+ (let ((path
+ (if hash
+ (fixed-output-path name hash
+ #:hash-algo algo
+ #:output output-name
+ #:recursive? rec?)
+ (output-path output-name
+ drv-hash name))))
+ (cons output-name
+ (make-derivation-output path algo
+ hash rec?)))))
outputs)))
(make-derivation outputs inputs sources system builder args
(map (match-lambda
- ((name . value)
- (cons name
- (or (and=> (assoc-ref outputs name)
- derivation-output-path)
- value))))
+ ((name . value)
+ (cons name
+ (or (and=> (assoc-ref outputs name)
+ derivation-output-path)
+ value))))
env-vars)
#f)))))
@@ -910,10 +910,10 @@ (define* (derivation store name builder args
;; Return a variant of ENV-VARS where each OUTPUTS is associated with an
;; empty string, even outputs that do not appear in ENV-VARS.
(let ((e (map (match-lambda
- ((name . val)
- (if (member name outputs)
- (cons name "")
- (cons name val))))
+ ((name . val)
+ (if (member name outputs)
+ (cons name "")
+ (cons name val))))
env-vars)))
(fold (lambda (output-name env-vars)
(if (assoc output-name env-vars)
--
2.48.1
bjc@HIDDEN, maximedevos@HIDDEN, kaelyn.alexi@HIDDEN, ludo@HIDDEN, morgan.arnold@HIDDEN, ian@HIDDEN, john.kehayias@HIDDEN, leo@HIDDEN, felix.lechner@HIDDEN, andreas@HIDDEN, bjc@HIDDEN, maxim.cournoyer@HIDDEN, guix@HIDDEN, dev@HIDDEN, othacehe@HIDDEN, zimon.toutoune@HIDDEN, me@HIDDEN, guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 16 Feb 2025 12:53:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 07:53:31 2025
Received: from localhost ([127.0.0.1]:60809 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tje9K-0007Ew-8Q
for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 07:53:31 -0500
Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:45290)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
id 1tje9H-0007Ef-77
for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 07:53:28 -0500
Received: by mail-pl1-x62c.google.com with SMTP id
d9443c01a7336-220c8f38febso62896715ad.2
for <55231 <at> debbugs.gnu.org>; Sun, 16 Feb 2025 04:53:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1739710400; x=1740315200; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=1b2TvlH3aV6RiWMqtxeCmEVqSQGptSXQ0zJcXNbguhk=;
b=LQXTGNhD0uvpfWUpS+DwIUCJkfK4hvU9uNstSFZ0dL6Z/nMX8oSMsc+PYPhUqAyEHn
F5ldHUxRk2Ael395zYSnmLyBn9Jpw+jpFEuROPKKWCFLuQUxZgXHFt/oaJ8+06chx35G
XT4evyLeLgVw1Noc7mzkmWrKCP5Fyhk9avbAqzVI4biNnHmzFUfAsz952caPfmpTs1pb
wPlVK63xsRd05LHs5BmZpAE/l7UIzoSa+3hJTaC1z6dsPOwBgL+Xi52f1KZQm9s6wDB/
1Jvz2gni2MU56YE1I10Gn/EtFjLZiXgWNYXHBxSvuktiqoSu5EBDEng9QaB5GX0QA3OD
Bx6Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1739710400; x=1740315200;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=1b2TvlH3aV6RiWMqtxeCmEVqSQGptSXQ0zJcXNbguhk=;
b=gy5Sb5MRqXwPJ7axiAbZ/6yEWLLQRoemVmNTidp1In6zZUtUwSgZiN9tH0FILN+d97
ntkB0WLSYvF7qrUVaeBPFX0kAHYv8NLNabGjTZSJwUOM0qj6R/Brk/zdExoyk0Khk/vl
DhTq/sQ1sb7W8W7Kh2E/OgEcEToRwCKu12HqKMVDUARzofyqMA97xoe+dUSxhJfoyXbV
lOvlu/3q9cSUHVqeOXl2n0RO0oTsVYKYJ969CZNTHzOSV35T+tTAiZxwDjdk9ngkE10F
RuAsme8JdgnZftxZFFzxenepKJoNTxYVPNutHN3LD8O6Lg/fN8Z812FsY4+53x1nqbKZ
qTqA==
X-Gm-Message-State: AOJu0YwPyBrX/+Dm64SrEsvrY4AeZ/1A0qG6EQJuZ6HNG8mMlbHV9sHX
O5Ng2WdUl5PI0LrAXBiV1XjpEou3LUjhBRnFCm8bxqZ81IpLME05bOYf2XfZ
X-Gm-Gg: ASbGncvfRDAVnGggBKO68KLJ7G0kd7nYUXYR5bUOECfWcL8v07OCyboQaVzTl5BRVkL
gIBoVdS31KiVOBGngQKiBh2wt6lN7FZAK7cDJrS/2sRZ+vUomNybEymHyFKZ/41LEH/lZoIXxtz
Ucn7QJNaya4eZfsLNy+G0kfprAqjJtHSVriDXV/zBe4Cq5sQ8jtCfvSDlJwhPqoENR2k1KNuNhe
WHkqoM2mYn8OpavyKBvxoCOMk8ru/Pzx3I73hYhX2nmLK2jNrkpX2A1VsFtS2kiC/d/KiRLhnNp
rmUhGHKtXdi8c0OGEpqktoG4IveMuTth8Q==
X-Google-Smtp-Source: AGHT+IF1SloX9dEDXmpSpO5VCqY7PSskI264M6BhO3HElWERAZRKBh02f4MF2U9xOdTABH6O4WUNWw==
X-Received: by 2002:a17:902:fc8f:b0:220:f7bb:842 with SMTP id
d9443c01a7336-221040b1922mr90465345ad.42.1739710399699;
Sun, 16 Feb 2025 04:53:19 -0800 (PST)
Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89])
by smtp.gmail.com with ESMTPSA id
d9443c01a7336-220d82e843fsm54178725ad.220.2025.02.16.04.53.17
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 16 Feb 2025 04:53:19 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: 55231 <at> debbugs.gnu.org
Subject: [PATCH v6 1/4] Allow copying of out-of-tree modules to the Linux
initrd.
Date: Sun, 16 Feb 2025 21:52:45 +0900
Message-ID: <353146a4da0938e592fa4333b601abf5b98d937d.1739710358.git.maxim.cournoyer@HIDDEN>
X-Mailer: git-send-email 2.48.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
X-Debbugs-Cc: Brian Cully <bjc@HIDDEN>, Maxime Devos <maximedevos@HIDDEN>, Kaelyn <kaelyn.alexi@HIDDEN>, Ludovic Courtès <ludo@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ian Eure <ian@HIDDEN>, John Kehayias <john.kehayias@HIDDEN>, Leo Famulari <leo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, Andreas Enge <andreas@HIDDEN>, bjc@HIDDEN, Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Wilko Meyer <w@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Brian Cully <bjc@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
From: Brian Cully <bjc@HIDDEN>
With this patch, modules for ‘initrd-modules’ will not only be searched for in
the in-tree Linux modules, but also any additional modules specified in
‘kernel-loadable-modules’.
* gnu/build/linux-modules.scm (find-module-file): Change DIRECTORY argument to
DIRECTORIES. Now takes a list of directories to search, rather than a single
one.
* gnu/system/linux-initrd.scm (flat-linux-module-directory): change LINUX
argument to PACKAGES. Now contains a list of file-like objects to search for
modules.
(raw-initrd): Add LINUX-EXTRA-MODULE-DIRECTORIES keyword argument. Pass it
to (flat-linux-module-directory) along with the selected LINUX package.
(base-initrd): Add LINUX-EXTRA-MODULE-DIRECTORIES keyword argument. Pass it
to (raw-initrd).
* gnu/system.scm (operating-system-initrd-file): Pass in operating system
definition's kernel-loadable-modules into (make-initrd) as
LINUX-EXTRA-MODULE-DIRECTORIES.
* doc/guix.texi (Initial RAM Disk): Document how out-of-tree modules can be
used.
Change-Id: Ic39f2abcfabc3ec34a71acce840038396bf9c82e
Signed-off-by: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Modified-by: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
---
doc/guix.texi | 15 ++++++++++++
gnu/build/linux-modules.scm | 22 +++++++++++------
gnu/system.scm | 2 ++
gnu/system/linux-initrd.scm | 49 +++++++++++++++++++++++--------------
4 files changed, 62 insertions(+), 26 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 01e3a4edf0..a4c3743e50 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -43413,6 +43413,21 @@ Initial RAM Disk
(initrd-modules (cons "megaraid_sas" %base-initrd-modules)))
@end lisp
+If a module listed in @code{initrd-modules} is not included in the
+Linux-libre kernel, then its location must be provided via the
+@code{kernel-loadable-modules} list.
+
+As an example, if you need the driver for a Realtek RTL8821CE wireless
+network adapter for mounting the root file system over NFS, your
+configuration might include the following:
+
+@lisp
+(operating-system
+ ;; @dots{}
+ (initrd-modules (cons "8821ce" %base-initrd-modules))
+ (kernel-loadable-modules (list (list rtl8821ce-linux-module "module"))))
+@end lisp
+
@defvar %base-initrd-modules
This is the list of kernel modules included in the initrd by default.
@end defvar
diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scm
index 32baf6c525..24bbe087f5 100644
--- a/gnu/build/linux-modules.scm
+++ b/gnu/build/linux-modules.scm
@@ -246,8 +246,8 @@ (define (file-name->module-name file)
'.ko[.gz|.xz|.zst]' and normalizing it."
(normalize-module-name (strip-extension (basename file))))
-(define (find-module-file directory module)
- "Lookup module NAME under DIRECTORY, and return its absolute file name.
+(define (find-module-file directories module)
+ "Lookup module NAME under DIRECTORIES, and return its absolute file name.
NAME can be a file name with or without '.ko', or it can be a module name.
Raise an error if it could not be found.
@@ -255,6 +255,9 @@ (define (find-module-file directory module)
module names usually (always?) use underscores as the inter-word separator,
whereas file names often, but not always, use hyphens. Examples:
\"usb-storage.ko\", \"serpent_generic.ko\"."
+ (define directories (if (pair? directories)
+ directories
+ (list directories))) ;for backward compatibility
(define names
;; List of possible file names. XXX: It would of course be cleaner to
;; have a database that maps module names to file names and vice versa,
@@ -268,16 +271,19 @@ (define (find-module-file directory module)
(else chr)))
module))))
- (match (find-files directory
- (lambda (file stat)
- (member (strip-extension
- (basename file)) names)))
+ (match (append-map (lambda (directory)
+ (find-files directory
+ (lambda (file _)
+ (member (strip-extension
+ (basename file))
+ names))))
+ directories)
((file)
file)
(()
- (error "kernel module not found" module directory))
+ (error "kernel module not found" module directories))
((_ ...)
- (error "several modules by that name" module directory))))
+ (error "several modules by that name" module directories))))
(define* (recursive-module-dependencies files
#:key (lookup-module dot-ko))
diff --git a/gnu/system.scm b/gnu/system.scm
index 8df871f255..1921b60c25 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -1373,6 +1373,8 @@ (define (operating-system-initrd-file os)
#:linux (operating-system-kernel os)
#:linux-modules
(operating-system-initrd-modules os)
+ #:linux-extra-module-directories
+ (operating-system-kernel-loadable-modules os)
#:mapped-devices mapped-devices
#:keyboard-layout (operating-system-keyboard-layout os)))
diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm
index dc08edc791..a8df9056ec 100644
--- a/gnu/system/linux-initrd.scm
+++ b/gnu/system/linux-initrd.scm
@@ -120,13 +120,19 @@ (define* (expression->initrd exp
`(#:references-graphs (("closure" ,init))))
"/initrd.cpio.gz"))
-(define (flat-linux-module-directory linux modules)
+(define (flat-linux-module-directory packages modules)
"Return a flat directory containing the Linux kernel modules listed in
-MODULES and taken from LINUX."
+MODULES and taken from PACKAGES."
(define imported-modules
(source-module-closure '((gnu build linux-modules)
(guix build utils))))
+ (define package-inputs
+ (map (match-lambda
+ ((p o) (gexp-input p o))
+ (p (gexp-input p "out")))
+ packages))
+
(define build-exp
(with-imported-modules imported-modules
(with-extensions (list guile-zlib guile-zstd)
@@ -138,8 +144,9 @@ (define (flat-linux-module-directory linux modules)
(srfi srfi-26)
(ice-9 match))
- (define module-dir
- (string-append #$linux "/lib/modules"))
+ (define module-dirs
+ (map (cut string-append <> "/lib/modules")
+ '#$package-inputs))
(define builtin-modules
(match (find-files module-dir (lambda (file stat)
@@ -157,7 +164,7 @@ (define (flat-linux-module-directory linux modules)
(lset-difference string=? '#$modules builtin-modules))
(define modules
- (let* ((lookup (cut find-module-file module-dir <>))
+ (let* ((lookup (cut find-module-file module-dirs <>))
(modules (map lookup modules-to-lookup)))
(append modules
(recursive-module-dependencies
@@ -192,6 +199,7 @@ (define* (raw-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-directories '())
(pre-mount #t)
(mapped-devices '())
(keyboard-layout #f)
@@ -199,15 +207,16 @@ (define* (raw-initrd file-systems
qemu-networking?
volatile-root?
(on-error 'debug))
- "Return as a file-like object a raw initrd, with kernel
-modules taken from LINUX. FILE-SYSTEMS is a list of file-systems to be
-mounted by the initrd, possibly in addition to the root file system specified
-on the kernel command line via 'root'. LINUX-MODULES is a list of kernel
-modules to be loaded at boot time. MAPPED-DEVICES is a list of device
-mappings to realize before FILE-SYSTEMS are mounted. PRE-MOUNT is a
-G-expression to evaluate before realizing MAPPED-DEVICES.
-HELPER-PACKAGES is a list of packages to be copied in the initrd. It may include
-e2fsck/static or other packages needed by the initrd to check root partition.
+ "Return as a file-like object a raw initrd, with kernel modules taken from
+LINUX. FILE-SYSTEMS is a list of file-systems to be mounted by the initrd,
+possibly in addition to the root file system specified on the kernel command
+line via 'root'. LINUX-MODULES is a list of kernel modules to be loaded at
+boot time. LINUX-EXTRA-MODULE-DIRECTORIES is a list of file-like objects which
+will be searched for modules in addition to the linux kernel. MAPPED-DEVICES
+is a list of device mappings to realize before FILE-SYSTEMS are mounted.
+HELPER-PACKAGES is a list of packages to be copied in the initrd. It may
+include e2fsck/static or other packages needed by the initrd to check root
+partition.
When true, KEYBOARD-LAYOUT is a <keyboard-layout> record denoting the desired
console keyboard layout. This is done before MAPPED-DEVICES are set up and
@@ -243,7 +252,8 @@ (define* (raw-initrd file-systems
#~())))
(define kodir
- (flat-linux-module-directory linux linux-modules))
+ (flat-linux-module-directory (cons linux linux-extra-module-directories)
+ linux-modules))
(expression->initrd
(with-imported-modules (source-module-closure
@@ -390,6 +400,7 @@ (define* (base-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-directories '())
(mapped-devices '())
(keyboard-layout #f)
qemu-networking?
@@ -410,9 +421,10 @@ (define* (base-initrd file-systems
QEMU-NETWORKING? and VOLATILE-ROOT? behaves as in raw-initrd.
The initrd is automatically populated with all the kernel modules necessary
-for FILE-SYSTEMS and for the given options. Additional kernel
-modules can be listed in LINUX-MODULES. They will be added to the initrd, and
-loaded at boot time in the order in which they appear."
+for FILE-SYSTEMS and for the given options. Additional kernel modules can be
+listed in LINUX-MODULES. Additional directories for modules can be listed in
+LINUX-EXTRA-MODULE-DIRECTORIES. They will be added to the initrd, and loaded
+at boot time in the order in which they appear."
(define linux-modules*
;; Modules added to the initrd and loaded from the initrd.
`(,@linux-modules
@@ -432,6 +444,7 @@ (define* (base-initrd file-systems
(raw-initrd file-systems
#:linux linux
#:linux-modules linux-modules*
+ #:linux-extra-module-directories linux-extra-module-directories
#:mapped-devices mapped-devices
#:helper-packages helper-packages
#:keyboard-layout keyboard-layout
base-commit: af643735a546d9d3538113ebab4b5892f34c131a
--
2.48.1
bjc@HIDDEN, maximedevos@HIDDEN, kaelyn.alexi@HIDDEN, ludo@HIDDEN, morgan.arnold@HIDDEN, ian@HIDDEN, john.kehayias@HIDDEN, leo@HIDDEN, felix.lechner@HIDDEN, andreas@HIDDEN, bjc@HIDDEN, maxim.cournoyer@HIDDEN, w@HIDDEN, guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 16 Feb 2025 11:29:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 06:29:51 2025
Received: from localhost ([127.0.0.1]:60650 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tjcqM-0000O7-Ty
for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 06:29:51 -0500
Received: from mail-10629.protonmail.ch ([79.135.106.29]:49009)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>)
id 1tjcqJ-0000Nr-Ki
for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 06:29:48 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me;
s=protonmail; t=1739705380; x=1739964580;
bh=9iCX6LLuWhip89We3ANnCNsAyno5FmPYCPTlMRnhXmk=;
h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:
Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector:
List-Unsubscribe:List-Unsubscribe-Post;
b=Z1Wf8A8ZfdLJsp2wvPr4nOrpoXZ71ZgA3MgaGTMrlrcjtcL3awx4K1ex6W0T1q/Ga
eTD4RO1iACSTEVph1k5JBXKVOShAiGY0Jm06+B23BX80kQGrmQYGt5NhiMHEUi9myo
F9ufIne57LfUwCz9jCf57fIsiBPm7Pk/jgiYl2XhZUha4SBtLOEAQf+qj/9v1sK3gg
r69QgcqkdpcHTJ0fMYzrBBEdzvJxePSIm17JKeUjG0g4jbpdwQ61RhRMoUCdgrnQGw
p+O/gRITV0Cgd0E8cNO+hOBukot/ChA3j7v6vfKMDL9X06yVi7X1mDDEj3dkpVz0WQ
9y7cUIPfGqogQ==
Date: Sun, 16 Feb 2025 11:29:34 +0000
To: 55231 <at> debbugs.gnu.org
From: Morgan Arnold <morgan.arnold@HIDDEN>
Subject: [PATCH] Prevent possible copyright violations caused by initrd
changes.
Message-ID: <04422036fe701cdb2a249819cdfb79284539026f.1739705251.git.morgan.arnold@HIDDEN>
Feedback-ID: 45510636:user:proton
X-Pm-Message-ID: 3a4779d00eef39831cd1c6cabd0299723ea3e25f
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: Morgan Arnold <morgan.arnold@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
This commit changes the conditions under which derivations, as constructed =
by the `derivation` function, are made substitutable, to prevent potential =
copyright violations related to the construction of substitutable initrds i=
ncluding non-substitutable derivations (in particular, ZFS).
This change prevents such copyright violations by only marking a derivation=
as substitutable if it is marked substitutable and all of its inputs are m=
arked as substitutable. This means that non-substitutable derivations have =
a "poisoning" effect, preventing derivations which take them as input from =
being substitutable.
Change-Id: I80ba4a371ee0c55a1294aff311d4e7b151055fac
---
guix/derivations.scm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/guix/derivations.scm b/guix/derivations.scm
index bef98cd..64b51d8 100644
--- a/guix/derivations.scm
+++ b/guix/derivations.scm
@@ -868,6 +868,10 @@ (define* (derivation store name builder args
env-vars)
#f)))))
=20
+ (define inputs-substitutable? (every substitutable-derivation?
+ (map derivation-input-derivation
+ (filter derivation-input? inpu=
ts))))
+
(define (user+system-env-vars)
;; Some options are passed to the build daemon via the env. vars of
;; derivations (urgh!). We hide that from our API, but here is the pl=
ace
@@ -875,7 +879,7 @@ (define* (derivation store name builder args
(let ((env-vars `(,@(if local-build?
`(("preferLocalBuild" . "1"))
'())
- ,@(if (not substitutable?)
+ ,@(if (not (and substitutable? inputs-substitutable?=
))
`(("allowSubstitutes" . "0"))
'())
,@(if allowed-references
base-commit: b30669e15d2e8c3d1b74b32f77e2095682aab4ca
prerequisite-patch-id: 45b81fb0e4b05258028b424c6faa9ce11db81572
prerequisite-patch-id: 73d157f088f6ec9e9feece25a7ba6a0c890d6343
--=20
2.47.1
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 16 Feb 2025 11:24:57 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 06:24:57 2025 Received: from localhost ([127.0.0.1]:60641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tjcld-0000AQ-Er for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 06:24:57 -0500 Received: from mail-40134.protonmail.ch ([185.70.40.134]:64297) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>) id 1tjcla-0000AC-2q for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 06:24:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1739705087; x=1739964287; bh=1nWOjS/YjAVtAj/b2isGPuAZecL1L91fx03KkoNtVQI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=jgMfJrhFaD28+JGVe9G+Nd2Zqd/zRxD7wb6FdjRoeb/wYgud6TU+kEh9XFCYl5fZm B0gFzpe9swa3pc/2egnIPdmA9fPhoXQ+B84vpAtvoaUH90CvVRvHgxsScXmCF6Q225 J/OQDmBkdDO0gjzKnbd4BzW082qcncUKNFbtvjpqFHJejdJ+fU5wUJg2UDRLMd1XvK 4An/CSLKt6Iq8wLsjbFXOuDHaj5fXdztxAd1D+eItEqMKM5ll+5DC4CZwz7FCuMVyT lyzPMZCFH06HquVV3/jXpLp0d7RQRdhjXIvigXh5dKny6dkCScz2bIVCZOzr4kzY1q FXfXBeSD5KMTA== Date: Sun, 16 Feb 2025 11:24:43 +0000 To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> From: Morgan Arnold <morgan.arnold@HIDDEN> Subject: =?utf-8?Q?Re:_bug#55231:_[PATCH_v1]_initrd:_Allow_extra_search_paths_with_=E2=80=98initrd-extra-module-paths=E2=80=99?= Message-ID: <gUOjJoEMLHJSnQB8Fyy9i8r5aelAgRG4A5nomTvt0VKRk__JJfcFKkdNUWvlYiq71dtFmtqi3qTmKWJbs6QmYSTvZ2dyLj4hv0qwv4H7Edo=@proton.me> In-Reply-To: <87msem45um.fsf_-_@HIDDEN> References: <JTtAimnNMICUW-We530BE44G5KpCO2CoYASQY0J4ThyM0PF-Q0HIlIsjt4j1SdsjjPBobI-0iYoARfw5MmWiYoeC6hATg9llGDhWg6Ku4MA=@proton.me> <Z6oCQMYpj2R98syY@jurong> <VBHM6E4b-4Rwi1VeyYGs9CNojT6aQ5kKvXr8yBjlHZUpRCoJgkmWNBtW1sYZs6FZ1r5hDHuj-cB9VvWXmZ29GM0P3dwRY-VSboFzryTvPAY=@proton.me> <875xlgvd9h.fsf_-_@HIDDEN> <iOT1aqNUX2hG8nPSfPERteM0XkN1mz1C-SoW2AYX_UjEEDIOe1FnHzWXnR5QlCYdU5rMpYEjwDCrJ8QofUff5U98_ohVR3sZtEjBpCSHeXE=@proton.me> <aOt786iZX9EVyqAJO1tCSe7ev0OcCN8c5NKIsOkoGUd95ljy7L9_V3QEmXdeD7tAKq-UMGWzJnvt5az51foPXPwHYODD3RNCCeyf8VB7EVU=@proton.me> <87msem45um.fsf_-_@HIDDEN> Feedback-ID: 45510636:user:proton X-Pm-Message-ID: c2c43fc4b0b9bc272447b5dc6e4d12ed748cdb32 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, "ludo@HIDDEN" <ludo@HIDDEN>, "maximedevos@HIDDEN" <maximedevos@HIDDEN>, "john.kehayias@HIDDEN" <john.kehayias@HIDDEN>, Andreas Enge <andreas@HIDDEN>, "kaelyn.alexi@HIDDEN" <kaelyn.alexi@HIDDEN>, "guix-devel@HIDDEN" <guix-devel@HIDDEN>, "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Maxim, I found the cause of these failed tests, although unfortunately it doesn't = seem to resolve the problem with implicit inputs from `gnu-build-system` be= ing non-substitutable. The failing tests pass a `derivation` as input to th= e derivations that they construct, rather than a `derivation-input`. My add= ed code then fails upon attempting to apply `derivation-input-derivation` t= o something which is not `derivation-input?`. I think that this might argua= bly be a flaw in the tests, but it can be resolved by simply checking that = an input is `derivation-input?` before attempting to apply `derivation-inpu= t-derivation`. I'll send over the patch in a moment. Best, Morgan
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 16 Feb 2025 09:19:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 04:19:38 2025 Received: from localhost ([127.0.0.1]:60140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tjaoM-0002js-2O for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 04:19:38 -0500 Received: from mail-4322.protonmail.ch ([185.70.43.22]:60781) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>) id 1tjaoH-0002ja-Gx for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 04:19:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1739697567; x=1739956767; bh=BFSBZHnSSieyjsDZZ4JyqBNIsecSY0+nb3j3rDYxGVY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=BWT6EXiJjDjBGWhxc8Hr7USqnK0y0ogWMSFmknLddnExq7NiP8uqiEPwyFPuPGDRv U17cP9bIzkeli8uPBu8wHvcX+lf6CGaJSJYXEGwxrxD2vVd8fJ7S6mt0HdY/oNJom8 bR+rvqCYVnrNdw3z/gFApd0nlI+Lw+5GEtZ3c+6VNypOAWg3O9PxYegWuJ0cMrETIq 4NCBEQYY7iXzZthAt5O0VuatVavhFU6o4HQJplENLUkpxAHu/g8GerIDSlPx0yV4em MHrVF4XfACMuJo1RBpyzr0J2COIqY4ZHs/7CgQOdrw/LqFJYOTCQ9YhcstgfwJj6qG DLkPiwox8R58Q== Date: Sun, 16 Feb 2025 09:19:24 +0000 To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> From: Morgan Arnold <morgan.arnold@HIDDEN> Subject: =?utf-8?Q?Re:_bug#55231:_[PATCH_v1]_initrd:_Allow_extra_search_paths_with_=E2=80=98initrd-extra-module-paths=E2=80=99?= Message-ID: <3o4_UDsLg_niP9tmlxooqmgL06jnuZUG-5XC0cVNmBFFSGzknqo57tPuquPbDyXojL1N8sBpu3fKFqDs5G703jNggTKMdPqWR3XH53wov4w=@proton.me> In-Reply-To: <87msem45um.fsf_-_@HIDDEN> References: <JTtAimnNMICUW-We530BE44G5KpCO2CoYASQY0J4ThyM0PF-Q0HIlIsjt4j1SdsjjPBobI-0iYoARfw5MmWiYoeC6hATg9llGDhWg6Ku4MA=@proton.me> <Z6oCQMYpj2R98syY@jurong> <VBHM6E4b-4Rwi1VeyYGs9CNojT6aQ5kKvXr8yBjlHZUpRCoJgkmWNBtW1sYZs6FZ1r5hDHuj-cB9VvWXmZ29GM0P3dwRY-VSboFzryTvPAY=@proton.me> <875xlgvd9h.fsf_-_@HIDDEN> <iOT1aqNUX2hG8nPSfPERteM0XkN1mz1C-SoW2AYX_UjEEDIOe1FnHzWXnR5QlCYdU5rMpYEjwDCrJ8QofUff5U98_ohVR3sZtEjBpCSHeXE=@proton.me> <aOt786iZX9EVyqAJO1tCSe7ev0OcCN8c5NKIsOkoGUd95ljy7L9_V3QEmXdeD7tAKq-UMGWzJnvt5az51foPXPwHYODD3RNCCeyf8VB7EVU=@proton.me> <87msem45um.fsf_-_@HIDDEN> Feedback-ID: 45510636:user:proton X-Pm-Message-ID: c89f2c3a485c91e83b640af4aa5f17eae7a10c08 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, "ludo@HIDDEN" <ludo@HIDDEN>, "maximedevos@HIDDEN" <maximedevos@HIDDEN>, "john.kehayias@HIDDEN" <john.kehayias@HIDDEN>, Andreas Enge <andreas@HIDDEN>, "kaelyn.alexi@HIDDEN" <kaelyn.alexi@HIDDEN>, "guix-devel@HIDDEN" <guix-devel@HIDDEN>, "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Maxim, > That's probably the GCC implicitly added by gnu-build-system, which is > listed in the %final-inputs variable. I did figure out that this was the GCC implicitly added by `gnu-build-syste= m`, although unfortunately examining this more carefully didn't help me a w= hole lot with understanding why it seemed to be non-substitutable.=20 > I'm not sure what's wrong, but I think we could start by investigating > why this changes causes 29 new failures when running: I accidentally added an extra closing parenthesis to the changed line in `d= erivation`, but didn't bother submitting an updated patch set because even = with that typo fixed, the change still didn't seem to work. You may have no= ticed and fixed this yourself. I had trouble running the test suite while w= orking on the changes, as I was away from home and my laptop seemed to be s= omewhat underpowered for the purpose. I'm back at home with access to my PC= now, so I'll try to have a look at why the tests are failing. Best, Morgan
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 16 Feb 2025 09:06:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 04:06:04 2025 Received: from localhost ([127.0.0.1]:60074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tjabE-0002Aa-5p for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 04:06:04 -0500 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:44309) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tjabB-00029f-Ex for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 04:06:02 -0500 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-220d39a5627so49719245ad.1 for <55231 <at> debbugs.gnu.org>; Sun, 16 Feb 2025 01:06:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739696754; x=1740301554; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jZnUj+OMg4rijVxHEByT++xkPTAK2F3N34YZTGM5rsc=; b=e9EpWXUxgU6ANhKRaPskl67h+P8ONQ4FJNODPFiu0CAZO+YaQMwWuk9tOCGW74a55h H75bO8B8honnkoeNv1I47N8MOi4FKeGog6O8d7eWROZ2vCVmqFCjVoeCNJNvL6TvYocb eNELATD9znYQofBzbIIcKJNIo0d6iqGfcLWJ7bENkmqPbJQcMUcoDEIyVXP7sAmrW8ae qTgUolroIM0z2sDwap8q5TNQLXhszgOUyo47gOGObErcznMzULImOf49eSaxwN5hCyvl Hhr/IvWpR0KoVwYgZCBSfdWFT6J23a67Z/By8HCD43KER3RCkVIsGkVFGN5r/pkzX4qX 3Y0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739696754; x=1740301554; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jZnUj+OMg4rijVxHEByT++xkPTAK2F3N34YZTGM5rsc=; b=oF1coDlyI0PBTLaYkZ3aCnXj8yNDjnp0ham+1cDV0CAl+vIYsScU/mm/yESLkosLtf h0Sp7g2jgHas/gz6z2nq3VNDotY9rYZgp29pKNIxiQQLjOwmJCsRhB+i4OdcIafR3uds nmS3pK8ZGp4XOBO96dhhx0qdxKZ6HT8R/VYyNypFEfmU6Phlqpi5Ud4LmrnAaSd+EDbc 6Agu3KpLMIaAuzwlvKDQehAFoPLdyKcBAgQtY7JfVUoCEiBoeaXoxsEdLuYsPR/DPu/z 12YRghgNpDM+tpGKnaweoyKTs/sEzEgoXKyHagtChuL/jJuZpmi52GlhcpsREA/hhtTT LJhQ== X-Forwarded-Encrypted: i=1; AJvYcCXVu38WstCCbmqgRGkelbwaZiW/obKJzI83sEyGCsriBkYJmM21vKspVy8hMnnmOQj7eE8gAQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwQdAyWNQbu7l4KJkAKCFluwUgUi3VDnqRzu370zmAFC3db1PKS PCjvXAxzR2CtgoTE65tzW6KxsMwQFaznDjeS6/k7XEbUdsRQkBwEhjdhcuMF X-Gm-Gg: ASbGncuduxoKU4ZgNHiYwVwFzIjrhemkkzV/Khf2uezwjkrZcGdGuweisOXpqwlB9yX OHqodtioLDsirmO+yj3M2EfATVgQKn0N4DitZMIxFkNclfJpJU6e4UJtebrcIEfBJr+9ags9PC8 r9xmFHHg8Uud20qHQa2r78sSUNXc+7MBKwPB84GampWwOK1Dk/BO1BTgxHF++uVC/MFdtKBbxu4 XH5l3tkPJzWj+8J0GjhUdMnJZeECp4emmaIKBeH5PM/SMEEB7qgHFFBIpk/+lSdqN4kNhvku//U dNYTNlWz0SFt X-Google-Smtp-Source: AGHT+IHCPFVq3k+IYWyo7/2npl6guYXTbb3Xsq6wtgbkCLo4leYufi1sK0hCRz6F621amxBdeTCz7Q== X-Received: by 2002:a05:6a20:3d83:b0:1e0:f495:1bd9 with SMTP id adf61e73a8af0-1ee8cb0e932mr11838284637.8.1739696753840; Sun, 16 Feb 2025 01:05:53 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-732425463ebsm6189442b3a.19.2025.02.16.01.05.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Feb 2025 01:05:52 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Morgan Arnold <morgan.arnold@HIDDEN> Subject: Re: bug#55231: [PATCH v1] initrd: Allow extra search paths with =?utf-8?Q?=E2=80=98initrd-extra-module-paths=E2=80=99?= In-Reply-To: <aOt786iZX9EVyqAJO1tCSe7ev0OcCN8c5NKIsOkoGUd95ljy7L9_V3QEmXdeD7tAKq-UMGWzJnvt5az51foPXPwHYODD3RNCCeyf8VB7EVU=@proton.me> (Morgan Arnold's message of "Wed, 12 Feb 2025 19:41:22 +0000") References: <JTtAimnNMICUW-We530BE44G5KpCO2CoYASQY0J4ThyM0PF-Q0HIlIsjt4j1SdsjjPBobI-0iYoARfw5MmWiYoeC6hATg9llGDhWg6Ku4MA=@proton.me> <Z6oCQMYpj2R98syY@jurong> <VBHM6E4b-4Rwi1VeyYGs9CNojT6aQ5kKvXr8yBjlHZUpRCoJgkmWNBtW1sYZs6FZ1r5hDHuj-cB9VvWXmZ29GM0P3dwRY-VSboFzryTvPAY=@proton.me> <875xlgvd9h.fsf_-_@HIDDEN> <iOT1aqNUX2hG8nPSfPERteM0XkN1mz1C-SoW2AYX_UjEEDIOe1FnHzWXnR5QlCYdU5rMpYEjwDCrJ8QofUff5U98_ohVR3sZtEjBpCSHeXE=@proton.me> <aOt786iZX9EVyqAJO1tCSe7ev0OcCN8c5NKIsOkoGUd95ljy7L9_V3QEmXdeD7tAKq-UMGWzJnvt5az51foPXPwHYODD3RNCCeyf8VB7EVU=@proton.me> Date: Sun, 16 Feb 2025 18:05:37 +0900 Message-ID: <87msem45um.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, "ludo@HIDDEN" <ludo@HIDDEN>, "maximedevos@HIDDEN" <maximedevos@HIDDEN>, "john.kehayias@HIDDEN" <john.kehayias@HIDDEN>, Andreas Enge <andreas@HIDDEN>, "kaelyn.alexi@HIDDEN" <kaelyn.alexi@HIDDEN>, "guix-devel@HIDDEN" <guix-devel@HIDDEN>, "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Morgan, Morgan Arnold <morgan.arnold@HIDDEN> writes: > Hi all, > >> I'm not sure if what I'm proposing would actually work. > > How prophetic. > > I did some more testing with the proposed change to `derivation`, and > it seems to be causing a weird issue. I didn't think that propagating > non-substitutability would be much of a problem, since there are very > few non-substitutable packages, but I was surprised to find that this > change makes almost all packages non-substitutable! I did some > REPL-ing to find the culprit, and it when I traced it back, I found > that all of my non-substitutable derivations appeared to be so because > their dependency graph included a derivation called `#<derivation > /gnu/store/qbrwrmdgnfx3p9gl499f5pyhv0fcnw0a-gcc-11.4.0.drv =3D> > /gnu/store/d69awcc5wahh71amx0dmgaimsdvvp2bg-gcc-11.4.0-lib > 7fc7c9bb99b0>`. That's probably the GCC implicitly added by gnu-build-system, which is listed in the %final-inputs variable. > Unfortunately, I cannot for the life of me figure out what this > derivation is, or why it isn't substitutable (all of its inputs are > substitutable, and I can't find any relevant package explicitly marked > as non-substitutable). I wonder if maybe it has something to do with > the `gnu-build-system`? It appears to be an input of `bash-minimal`, > which is what leads me to that suspicion. If I could figure out what > this derivation is and why it's non-substitutable, I think that the > change that the proposed change to `derivation` would work (and, in > some sense, implement what ought intuitively to be the default > behaviour, as Brian noted). I'm not sure what's wrong, but I think we could start by investigating why this changes causes 29 new failures when running: --8<---------------cut here---------------start------------->8--- export SCM_LOG_DRIVER_FLAGS=3D"--brief=3Dno --errors-only=3Dyes" VERBOSE=3D1 make check TESTS=3Dtests/derivations.scm $ make check TESTS=3Dtests/derivations.scm=20 make check-recursive make[1]=C2=A0: on entre dans le r=C3=A9pertoire =C2=AB=C2=A0/home/maxim/src= /guix-spare=C2=A0=C2=BB Making check in po/guix make[2]=C2=A0: on entre dans le r=C3=A9pertoire =C2=AB=C2=A0/home/maxim/src= /guix-spare/po/guix=C2=A0=C2=BB make[2]: Rien =C3=A0 faire pour =C2=AB=C2=A0check=C2=A0=C2=BB. make[2]=C2=A0: on quitte le r=C3=A9pertoire =C2=AB=C2=A0/home/maxim/src/gui= x-spare/po/guix=C2=A0=C2=BB Making check in po/packages make[2]=C2=A0: on entre dans le r=C3=A9pertoire =C2=AB=C2=A0/home/maxim/src= /guix-spare/po/packages=C2=A0=C2=BB make[2]: Rien =C3=A0 faire pour =C2=AB=C2=A0check=C2=A0=C2=BB. make[2]=C2=A0: on quitte le r=C3=A9pertoire =C2=AB=C2=A0/home/maxim/src/gui= x-spare/po/packages=C2=A0=C2=BB make[2]=C2=A0: on entre dans le r=C3=A9pertoire =C2=AB=C2=A0/home/maxim/src= /guix-spare=C2=A0=C2=BB Compiling Scheme modules... Compiling Scheme modules... Compiling Scheme modules... Compiling Scheme modules... Compiling Scheme modules... Compiling Scheme modules... Compiling Scheme modules... Compiling Scheme modules... make check-TESTS check-local make[3]=C2=A0: on entre dans le r=C3=A9pertoire =C2=AB=C2=A0/home/maxim/src= /guix-spare=C2=A0=C2=BB make[4]=C2=A0: on entre dans le r=C3=A9pertoire =C2=AB=C2=A0/home/maxim/src= /guix-spare=C2=A0=C2=BB PASS: tests/derivations.scm - parse & export=20 PASS: tests/derivations.scm - add-to-store, flat=20 PASS: tests/derivations.scm - add-to-store, recursive=20 PASS: tests/derivations.scm - derivation with no inputs=20 PASS: tests/derivations.scm - build derivation with 1 source=20 FAIL: tests/derivations.scm - derivation fails but keep going=20 PASS: tests/derivations.scm - identical files are deduplicated=20 PASS: tests/derivations.scm - built-in-builders=20 PASS: tests/derivations.scm - unknown built-in builder=20 PASS: tests/derivations.scm - 'download' built-in builder=20 PASS: tests/derivations.scm - 'download' built-in builder, invalid hash=20 PASS: tests/derivations.scm - 'download' built-in builder, not found=20 PASS: tests/derivations.scm - 'download' built-in builder, not fixed-output= =20 PASS: tests/derivations.scm - 'download' built-in builder, no fixed-output = hash=20 PASS: tests/derivations.scm - 'download' built-in builder, check mode=20 PASS: tests/derivations.scm - 'git-download' built-in builder=20 PASS: tests/derivations.scm - 'git-download' built-in builder, invalid hash= =20 PASS: tests/derivations.scm - 'git-download' built-in builder, invalid comm= it=20 PASS: tests/derivations.scm - 'git-download' built-in builder, not found=20 PASS: tests/derivations.scm - derivation-name=20 PASS: tests/derivations.scm - derivation-output-names=20 PASS: tests/derivations.scm - offloadable-derivation?=20 PASS: tests/derivations.scm - substitutable-derivation?=20 PASS: tests/derivations.scm - fixed-output-derivation?=20 PASS: tests/derivations.scm - fixed-output-derivation?, no hash=20 PASS: tests/derivations.scm - fixed-output derivation=20 PASS: tests/derivations.scm - fixed-output derivation: output paths are equ= al=20 PASS: tests/derivations.scm - fixed-output derivation, recursive=20 PASS: tests/derivations.scm - fixed-output derivation, invalid hash size=20 PASS: tests/derivations.scm - derivation with a fixed-output input=20 PASS: tests/derivations.scm - derivation with duplicate fixed-output inputs= =20 PASS: tests/derivations.scm - derivation with equivalent fixed-output input= s=20 PASS: tests/derivations.scm - multiple-output derivation=20 PASS: tests/derivations.scm - multiple-output derivation, non-alphabetic or= der=20 PASS: tests/derivations.scm - read-derivation vs. derivation=20 PASS: tests/derivations.scm - read-derivation with hash =3D #f=20 PASS: tests/derivations.scm - multiple-output derivation, derivation-path->= output-path=20 PASS: tests/derivations.scm - user of multiple-output derivation=20 PASS: tests/derivations.scm - derivation with #:references-graphs=20 PASS: tests/derivations.scm - derivation #:allowed-references, ok=20 PASS: tests/derivations.scm - derivation #:allowed-references, not allowed= =20 PASS: tests/derivations.scm - derivation #:allowed-references, self allowed= =20 PASS: tests/derivations.scm - derivation #:allowed-references, self not all= owed=20 PASS: tests/derivations.scm - derivation #:disallowed-references, ok=20 PASS: tests/derivations.scm - derivation #:disallowed-references, not ok=20 PASS: tests/derivations.scm - derivation #:leaked-env-vars=20 PASS: tests/derivations.scm - build derivation with coreutils=20 PASS: tests/derivations.scm - build-expression->derivation and invalid modu= le name=20 FAIL: tests/derivations.scm - build-expression->derivation and builder enco= ding=20 FAIL: tests/derivations.scm - build-expression->derivation and derivation-p= rerequisites=20 FAIL: tests/derivations.scm - derivation-prerequisites and valid-derivation= -input?=20 FAIL: tests/derivations.scm - build-expression->derivation without inputs=20 FAIL: tests/derivations.scm - build-expression->derivation and max-silent-t= ime=20 FAIL: tests/derivations.scm - build-expression->derivation and timeout=20 FAIL: tests/derivations.scm - build-derivations with specific output=20 FAIL: tests/derivations.scm - build-expression->derivation and derivation-b= uild-plan=20 FAIL: tests/derivations.scm - derivation-build-plan when outputs already pr= esent=20 FAIL: tests/derivations.scm - derivation-build-plan and substitutes=20 FAIL: tests/derivations.scm - derivation-build-plan and substitutes, non-su= bstitutable build=20 FAIL: tests/derivations.scm - derivation-build-plan and substitutes, non-su= bstitutable dep=20 FAIL: tests/derivations.scm - derivation-build-plan and substitutes, local = build=20 FAIL: tests/derivations.scm - derivation-build-plan in 'check' mode=20 FAIL: tests/derivations.scm - derivation-build-plan, topological ordering=20 FAIL: tests/derivations.scm - derivation-input-fold=20 FAIL: tests/derivations.scm - substitution-oracle and #:substitute? #f=20 FAIL: tests/derivations.scm - build-expression->derivation with expression = returning #f=20 FAIL: tests/derivations.scm - build-expression->derivation with two outputs= =20 FAIL: tests/derivations.scm - build-expression->derivation with one input=20 FAIL: tests/derivations.scm - build-expression->derivation with modules=20 FAIL: tests/derivations.scm - build-expression->derivation: same fixed-outp= ut path=20 FAIL: tests/derivations.scm - build-expression->derivation with a fixed-out= put input=20 FAIL: tests/derivations.scm - build-expression->derivation produces recursi= ve fixed-output=20 FAIL: tests/derivations.scm - build-expression->derivation uses recursive f= ixed-output=20 FAIL: tests/derivations.scm - build-expression->derivation with #:reference= s-graphs=20 FAIL: tests/derivations.scm - derivation-properties=20 FAIL: tests/derivations.scm - map-derivation=20 PASS: tests/derivations.scm - map-derivation, sources =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D GNU Guix 1.3.0.77462-364394: ./test-suite.log =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D # TOTAL: 77 # PASS: 48 # SKIP: 0 # XFAIL: 0 # FAIL: 29 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 --8<---------------cut here---------------end--------------->8--- =20=20 --=20 Thanks, Maxim
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 16 Feb 2025 07:32:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 02:32:17 2025
Received: from localhost ([127.0.0.1]:59837 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tjZ8S-0008No-KI
for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 02:32:17 -0500
Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]:46416)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
id 1tjZ8P-0008NS-To
for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 02:32:14 -0500
Received: by mail-pj1-x1036.google.com with SMTP id
98e67ed59e1d1-2fc32756139so2559636a91.1
for <55231 <at> debbugs.gnu.org>; Sat, 15 Feb 2025 23:32:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1739691127; x=1740295927; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=rkS0DYcvYQt4iWHH4LlarbjzYcPn70wJJoQj7F1cdzI=;
b=fBU5CfpKu7hZQgi0OYGcizCkKxlCih8m+W5u8K5/4uShNNHLp/aixm7rRojDQ7iOM+
0/Mqc879Y48MNVbYAKfq5zXaWYZhfdyQsM4vmojfu907D8KcIWsUV0UFmLGDIdysBkV6
6n3RP1gnIachn6FDNXo0X7spwe2ppRDmVyk1HR6KapedeAh/UgOEAK0CVuvRdaBjK2o/
8H0lIL1dkVxooSJYnVmr6Itib3BHiSelW6DOaHVB7itcmGYQEECe4Ata8H0Qz9bsgoWs
Gl01mIjdOy7olAtqKlZ3DRva+x9fzmkaG5d7IDNDLDsPipvqJfIpkd6leX/Fi786ljpK
6Hew==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1739691127; x=1740295927;
h=content-transfer-encoding:mime-version:user-agent:message-id:date
:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from
:to:cc:subject:date:message-id:reply-to;
bh=rkS0DYcvYQt4iWHH4LlarbjzYcPn70wJJoQj7F1cdzI=;
b=sz4kXRmKHbXRpMCrLDGVin5WqgPepJZWG9s8J+Q5EY8TwRVY4nOtQUqAcWgXIByhhk
EIBilB9bJfA2pI4EqCQ0D04Ih9rkRCSss5uxcGETid6JGHgwwU3k/X0KV4qocIifN1Us
JdSga9vjwhkWwNgyWn6pAalYTA4jhReRMWgxq745+xxr65aiRH7cElwrW05WMDZx3dtC
yHo5VAo1gDdIdTPjzLpaEGBQ1VQYZXXDs40t2154RR9tTLWy7qiM0VHPGBzJJdJMv3l5
qoYoFoJ4uBjWmJUriW2SV30ISZJU1Xwo5orq685eIx4OkLhrY3FWWx9nK+6OMsCeql5O
CpCw==
X-Gm-Message-State: AOJu0YxtIA4MkL2tzargMdqA7BuSM0Bm05KIZap1sIRxcIkbNPC47PHd
OFLsGpopWy08zbIXK9aaLjRwct6FAqu/PHdIqPaZLlBewoe5gZKp
X-Gm-Gg: ASbGncvJ2Gq+ucYGhaSW5VgKVs2c5AIVd+ZkraO1ldKxvrtoUnv9e8syQgU58LYT9qk
EPa+v9XzzP3ol20H1T2NzLMgX4D/8Qwmz4mzmtJ8nvAPmitqSW6lzUnXze79tuGGJTQETd5S8qi
nI6nHHlzYlKxQ1zWYY9cZF3qt3Ae9R35eR3z1ZtUCdhro00kLy9r6gwL/clTfHcUR1pxJIMzZ/E
lUwY7jKyeg+VRdE2X7tguu034+vv9+ArT6xChEdTkalMVffAKjBNmWVc0TFO//g/vW+56rxbnbu
EK1MpDze6XHh
X-Google-Smtp-Source: AGHT+IFDTijfC/CDXtnp/SufFNqa9BHakS85MHHrUPURvCOXsOGlQxmcY7JqLMgmcWrtZRJ6FUTyUA==
X-Received: by 2002:a05:6a00:198c:b0:730:8386:6070 with SMTP id
d2e1a72fcca58-73261445ce1mr9681061b3a.0.1739691127568;
Sat, 15 Feb 2025 23:32:07 -0800 (PST)
Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-7324257fdd6sm5934510b3a.76.2025.02.15.23.32.04
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 15 Feb 2025 23:32:07 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Morgan Arnold <morgan.arnold@HIDDEN>
Subject: Re: bug#55231: [PATCH v1] initrd: Allow extra search paths with
=?utf-8?Q?=E2=80=98initrd-extra-module-paths=E2=80=99?=
In-Reply-To: <15e253236ef3ffae9adf9139c274eeb8cfdf9e8e.1739285590.git.morgan.arnold@HIDDEN>
(Morgan Arnold's message of "Tue, 11 Feb 2025 14:56:07 +0000")
References: <87wnf3pv87.fsf@HIDDEN>
<15e253236ef3ffae9adf9139c274eeb8cfdf9e8e.1739285590.git.morgan.arnold@HIDDEN>
Date: Sun, 16 Feb 2025 16:31:53 +0900
Message-ID: <87r03y4a6u.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: Ian Eure <ian@HIDDEN>, Brian Cully <bjc@HIDDEN>,
Maxime Devos <maximedevos@HIDDEN>, Leo Famulari <leo@HIDDEN>,
Kaelyn <kaelyn.alexi@HIDDEN>, 55231 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi Morgan, Brian and all,
Morgan Arnold <morgan.arnold@HIDDEN> writes:
> From: Brian Cully <bjc@HIDDEN>
>
> With this patch, modules for =E2=80=98initrd-modules=E2=80=99 will not on=
ly be searched for in
> the in-tree Linux modules, but also any additional modules specified in
> =E2=80=98kernel-loadable-modules=E2=80=99.
>
> * gnu/build/linux-modules.scm (find-module-file): change DIRECTORY argume=
nt to
> DIRECTORIES. Now takes a list of directories to search, rather than a sin=
gle
> one.
> * gnu/system/linux-initrd.scm (flat-linux-module-directory): change LINUX
> argument to PACKAGES. Now contains a list of file-likes to search for mod=
ules.
> (raw-initrd): Add LINUX-EXTRA-MODULE-DIRECTORIES keyword argument. Pass it
> to (flat-linux-module-directory) along with the selected LINUX package.
> (base-initrd): Add LINUX-EXTRA-MODULE-DIRECTORIES keyword argument. Pass =
it
> to (raw-initrd).
> * gnu/system.scm (operating-system-initrd-file): pass in operating system
> definition's kernel-loadable-modules into (make-initrd) as
> LINUX-EXTRA-MODULE-DIRECTORIES.
This change looks reasonable to me, *if* we can make the possible
copyright violation fix that Morgan is working on work correctly. I've
applied it locally and made the following small changes, also
normalizing the commit message a bit and squashing the documentation
change along the actual change commit:
--8<---------------cut here---------------start------------->8---
modified doc/guix.texi
@@ -43414,11 +43414,11 @@ Initial RAM Disk
@end lisp
=20
If a module listed in @code{initrd-modules} is not included in the
-Linux-libre kernel, then the location to it must be added to the
+Linux-libre kernel, then its location must be provided via the
@code{kernel-loadable-modules} list.
=20
-For example, if you need the driver for a Realtek RTL8821CE wireless
-network adapter for mounting the root filesystem over NFS, your
+As an example, if you need the driver for a Realtek RTL8821CE wireless
+network adapter for mounting the root file system over NFS, your
configuration might include the following:
=20
@lisp
modified gnu/build/linux-modules.scm
@@ -255,6 +255,9 @@ (define (find-module-file directories module)
module names usually (always?) use underscores as the inter-word separator,
whereas file names often, but not always, use hyphens. Examples:
\"usb-storage.ko\", \"serpent_generic.ko\"."
+ (define directories (if pair? directories
+ directories
+ (list directories))) ;for backward compatibility
(define names
;; List of possible file names. XXX: It would of course be cleaner to
;; have a database that maps module names to file names and vice versa,
@@ -270,7 +273,7 @@ (define (find-module-file directories module)
=20
(match (append-map (lambda (directory)
(find-files directory
- (lambda (file _stat)
+ (lambda (file _)
(member (strip-extension
(basename file))
names))))
modified gnu/system/linux-initrd.scm
@@ -128,10 +128,9 @@ (define (flat-linux-module-directory packages modules)
(guix build utils))))
=20
(define package-inputs
- (map (lambda (p)
- (match p
- ((p o) (gexp-input p o))
- (p (gexp-input p "out"))))
+ (map (match-lambda
+ ((p o) (gexp-input p o))
+ (p (gexp-input p "out")))
packages))
=20
(define build-exp
--8<---------------cut here---------------end--------------->8---
I'll now take a look at the initrd substitutability issue/potential fix
from Morgan.
--=20
Thanks,
Maxim
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at submit) by debbugs.gnu.org; 16 Feb 2025 07:10:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 02:10:12 2025 Received: from localhost ([127.0.0.1]:59740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tjYn5-0004E4-LB for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 02:10:12 -0500 Received: from lists.gnu.org ([2001:470:142::17]:48660) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tjYmm-00047N-Qg for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 02:09:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tjYmb-00006H-K0; Sun, 16 Feb 2025 02:09:41 -0500 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tjYmZ-0008C8-L5; Sun, 16 Feb 2025 02:09:41 -0500 Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-2fc3027c7aeso3518549a91.0; Sat, 15 Feb 2025 23:09:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739689777; x=1740294577; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Eu7hmceJJu/qeaY8VhhlQSnd6hHhuUEqJS3c8tul8xk=; b=QWiYxx2lRJiXzKCLxpG5+u7nC5/+GQ7psxOpiRd0NUSJCT/nsZU3TF+YzTxCuz5li/ nBH68D7qoKIjC5U2Gon09FmZ7Sc9xfxrDdRZ4lOdoZ8Pi8ghNcPGS2dK6mTuyb41p6zK 56Na6XrHn5VujF4+nB9UdgNJydMe7eHF4rC849CDcYznuAUeHf5UNO4m06Po37/f5vDK 9Yax4Vbo5J2WQA3pIpR3IyCxD4gmBynOuGAv5plnZrXJnG0+MMTa8eKEuorpSxA9WgSg 1nNfYi1aaQv3zyPx11RYp9MYvA8ThAZmnlLG8Vmhc8lbmAhmjtFf0CijZiKRj6ppx9Te WLaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739689777; x=1740294577; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Eu7hmceJJu/qeaY8VhhlQSnd6hHhuUEqJS3c8tul8xk=; b=jK0eYQrG6rtWH+7tclW+Wk5Tc2VfIryrJUWZIU66WmV2g3Z669OQ9aTSYBFngTaWqG XLZy5tZXK+lFYfqNVMPAYydxgCRZt+r+kw4tGEBMZhaWV34efgqmjlRPV8qMOzNm4MVG 85YHtoMQAx9eqUKhB7L0ug3WFrwSStRwcKYnAVy37iXVoXEf8Urg89ow9+eQlEMpciWw 4uMkUZ2jfQdShFHBIM5si5L+O0jOOfwmjxtOeZdQBPSy44xxTUj4xfIwPj+AaolSWNlb rsYbTg3a9k/mzfJOV7igQ/qqvSi9Ii9eERRZrbEcuXy3z4xeuNWrdiYKjXUIHq6CXSGG ECuA== X-Forwarded-Encrypted: i=1; AJvYcCU5mohDUv+DQQ+FgSF+DgN5zW6wi+9IDwUR+lVFXkXbe8UCFtnxMT2zDrPDfU+hVBi7lnTs1o57ocelf+Xu@HIDDEN, AJvYcCVA1G8RNEynn2UOA69TbeZxp7VaFESmKUm2tsxbDtPCBbba3Xlkj0Lgs8v7HdrxC6/lAICZ9RBhakxp@HIDDEN, AJvYcCVV3/fmrPG95NSpArfap9sQWUOBPSRaVG3YtxvECNFa/7cWhMlkCeQoJkTj9WYuWgGxiYs38w==@gnu.org X-Gm-Message-State: AOJu0YzOUg8NqC7KG6QZKQaMZN7tVQr2DN42claQcn6AE9NToL/7w33G apMYME6JbZQsTQVZnV80mmFyrlPtvDXH6ViC4ltzxtv5ZKBUwC3N X-Gm-Gg: ASbGncv4rwuBf7KyKHS1jRpFPCjBZIbDsalKcc7LL/ar4HTzspLiDEbW6GQ7QigLDpE qMprBhmqgfnEkXNPRCwfu4LTEZO83nxX0dAoVyfV2soiPO6fmnQhA1UN5SWLCy8wlhhqBOARBvl gwH3r++NH8nEqleUC72DLiRtco6eLtGjhun9nipzV93sThHAI5XuldNvGbxCGFRl3XVo8u6t+sv fnLa2eh6RLSl1vu7ZrUYIaVhAzJep1QY6Y8fKTbzMDOEIlTZWjtXxW6idagJLExCVr/BqFUY0rd phobAWfSkY5I X-Google-Smtp-Source: AGHT+IGFkwZUl38OqjzkUldR/gOe0bX85ISp0Bra4RszridgOlYvwRCgBTqI1oMEhQ+yekMj2rQOvw== X-Received: by 2002:a05:6a00:1391:b0:72d:9cbc:730d with SMTP id d2e1a72fcca58-732617c4b97mr8418472b3a.11.1739689777113; Sat, 15 Feb 2025 23:09:37 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7325fec3dd9sm2752415b3a.86.2025.02.15.23.09.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Feb 2025 23:09:36 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Leo Famulari <leo@HIDDEN> Subject: Re: [bug#55231] Understanding #:substitutable? and #55231 In-Reply-To: <Z6-IzkI8GPcXiVsb@HIDDEN> (Leo Famulari's message of "Fri, 14 Feb 2025 13:17:50 -0500") References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> <Z6leT5MPfBTb3Ffq@HIDDEN> <87bjva5sq8.fsf@HIDDEN> <Z65bYzVd7HwZBbNm@HIDDEN> <EeoPDHUUv2IQ_8_zXkbijLh9tHBiY0T_hIpjE-RaP3cZavCzvpiv_YCgNXneMdHqkW_ZPtrReuO-_BkepeoRmMMcDFNGOMOi3qiPSeEJAxY=@proton.me> <Z6-IzkI8GPcXiVsb@HIDDEN> Date: Sun, 16 Feb 2025 16:09:23 +0900 Message-ID: <87v7ta4b8c.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=maxim.cournoyer@HIDDEN; helo=mail-pj1-x1029.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Ian Eure <ian@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, guix-devel@HIDDEN, 55231 <at> debbugs.gnu.org, Maxime Devos via Guix-patches via <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) Hi, Leo Famulari <leo@HIDDEN> writes: > On Fri, Feb 14, 2025 at 04:10:22PM +0000, Morgan Arnold wrote: >> Maxime's concern seems to me to be more about the fact that this >> change facilitates (and arguably encourages) the accidental commission >> of copyright violations. This issue is not necessarily specific to >> Linux+ZFS, but is the primary example being discussed because >> facilitating Linux+ZFS systems would be a major application of this >> patch. > > Thanks Morgan. I agree that if we are not understanding Maxime's point, > I hope we will be corrected. > > If Maxime's concern is that Guix should not make it too easy for users > to distribute software for which they do not have the license, I hear > that concern, but I argue that we shouldn't go very far with it. Of > course, Guix itself should not do that kind of thing, but we shouldn't > go out of our way to prevent users from doing so. > > Sure, let's not make a special variable "Linux with ZFS" that a user > only needs to tweak a single line in order to build and distribute. > > But we shouldn't prevent users from adding kernel modules to their > initrd, because that is explicitly not a problem from a licensing > standpoint. And if users choose to redistribute the compiled result, > that is their mistake / decision, not ours. > > Again, I don't see what is special with this combination, compared to > things like the incompatibility of the OpenSSL and GPL licenses. OpenSSL > could not be distributed linked with GPL code for many years of Guix, > and we didn't combine the licenses ourselves. But it was trivial for > users to do it, even on the command line by using package > transformations. That was okay, and I think this is a similar situation > that is also okay. > > To all, remember, my earlier message clarified the distinction between > combination and distribution. I hope further discussion will keep that > distinction in mind, if it is correct. Of course copyright is only > concerned with "copying" and distribution. If I've followed correctly, I think Maxime's last reservation to this change was that currently, even if the ZFS module is marked as non-substitutable, after it gets embedded in a binary initrd via this proposed change, it could become available as a binary substitute that lacks any of the 'non-substitutable' metadata, as (I assume) the initrd keeps no reference to the non-substitutable modules and Guix currently has no other means to know. Maxime's suggestion was to turn every initrd derivation into non-substitutable, which would work around that, but it'd means that everyone would also be building their initrd locally from source, which doesn't sound too great as it makes the current experience worst to satisfy a niche requirement (using out-of-tree kernel modules with incompatible licenses). Perhaps there could be some special case code that could be inserted at the right place to do the right thing; it'd need to be investigated. -- Thanks, Maxim
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 16 Feb 2025 07:09:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 16 02:09:47 2025 Received: from localhost ([127.0.0.1]:59733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tjYmh-00047Z-2T for submit <at> debbugs.gnu.org; Sun, 16 Feb 2025 02:09:47 -0500 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:49188) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1tjYme-00047I-BB for 55231 <at> debbugs.gnu.org; Sun, 16 Feb 2025 02:09:45 -0500 Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-2fbfa8c73a6so6373846a91.2 for <55231 <at> debbugs.gnu.org>; Sat, 15 Feb 2025 23:09:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739689777; x=1740294577; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Eu7hmceJJu/qeaY8VhhlQSnd6hHhuUEqJS3c8tul8xk=; b=nesDh7SIbi+0wMq9/0lFIJsiYPOw5a7Jis2mY4LdT9hS1U18P+2QQMzT67+PJxsW+Z QzL6+Bn4CRKSYv+XRLtEd1KJfo7CowY+KYH5/fC/099TpD6TRUSXjPlMBgT867b2d7Ca xMyBn/XL96tC2F9tdFkkIsH+ILwHSg7Lcd/cIWV0woiWa1XsyhHkIAd5e0wIGcSCIVC0 DAa3jkxi0skuOBsMJprELYZj3pa9o31sMSQqdSaMkWNB4gwBsIO1Zl6y1kRqT5XWXIrv N9BaPRLJ4ztUEmtM7sabSkuPc1vHfmnay5D6KhnvqbJEdmeNaz0v+7vpQZEEedQw+79L lMhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739689777; x=1740294577; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Eu7hmceJJu/qeaY8VhhlQSnd6hHhuUEqJS3c8tul8xk=; b=FwQlu3PEf90ig+FP+HFAOPnKJvykts3AVZOvpXivsENk1gVZXFVFARyYaN7zcsWGeD Gq/SyuF4VRCtKDrNM1y27brF2tR8RgK17KsJOcmmp3v23DLIAgBEjo2QNFtObj0eFRaa ntHG6BLSk0RcFjPMatNoLSJq8G3d3gtScKKNoDk1um3zDTqsyjFO7uV/Is6atwyKs7kk Hgut9XFe+3uTecAKzdiN/tNgIJX6IPDOGRmxR43rRAHtv6U/BfNbtbh9YOGQueimKFY/ itAiDBlrsaB/XPLkgQnsx7URPvz0aLYVNFSVSXRWXEWNYhGyC5d0Yn3l/edYkanqIfhm s9DQ== X-Forwarded-Encrypted: i=1; AJvYcCWjpsIzXDdUOyyBb9icFjbSfj0qANUWIVbV0s8wHxdR2tAN0ZjQCg9Ik8p9a96ZA/yhfsqH0Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyfjpVAWlhwhazLcxe5MG9LqMKXlu6IZwEfpPNptvvNvrtSHuBS /SyTuKskmEwPNQ32OM9LrvJC57ODj2X24oSFGPSp9TtKUdoH3RsJcS6JqlRL X-Gm-Gg: ASbGncvFYJe3zVwoDGW0/8MTynL4xO7b0C6j7Q1KCe0nLQH5S6sJ7r4DCCzsufppoMp En+4vle35u4CZQj1TGooSeKy4Xrbtq76mkFf/Pz1viBvmOoNmZxhU84G69tXbyHgzlGt/WjKTPj h3K26e2v3uvzsPCVbdSJLj6UomEwbo851slv25kg3gFvqV/aHXMAg6e+IaHlclItXyOJ0UvIfa/ AA1AXl6TQBGGQinsxsL8LmvOn+dx52zSWsaIjSiV9e9w1qJ01WWKfExUr6i9VH3UbTZgmNcXtaY TTsAY9XN1I+R X-Google-Smtp-Source: AGHT+IGFkwZUl38OqjzkUldR/gOe0bX85ISp0Bra4RszridgOlYvwRCgBTqI1oMEhQ+yekMj2rQOvw== X-Received: by 2002:a05:6a00:1391:b0:72d:9cbc:730d with SMTP id d2e1a72fcca58-732617c4b97mr8418472b3a.11.1739689777113; Sat, 15 Feb 2025 23:09:37 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7325fec3dd9sm2752415b3a.86.2025.02.15.23.09.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Feb 2025 23:09:36 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Leo Famulari <leo@HIDDEN> Subject: Re: [bug#55231] Understanding #:substitutable? and #55231 In-Reply-To: <Z6-IzkI8GPcXiVsb@HIDDEN> (Leo Famulari's message of "Fri, 14 Feb 2025 13:17:50 -0500") References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> <Z6leT5MPfBTb3Ffq@HIDDEN> <87bjva5sq8.fsf@HIDDEN> <Z65bYzVd7HwZBbNm@HIDDEN> <EeoPDHUUv2IQ_8_zXkbijLh9tHBiY0T_hIpjE-RaP3cZavCzvpiv_YCgNXneMdHqkW_ZPtrReuO-_BkepeoRmMMcDFNGOMOi3qiPSeEJAxY=@proton.me> <Z6-IzkI8GPcXiVsb@HIDDEN> Date: Sun, 16 Feb 2025 16:09:23 +0900 Message-ID: <87v7ta4b8c.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, guix-devel@HIDDEN, 55231 <at> debbugs.gnu.org, Maxime Devos via Guix-patches via <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi, Leo Famulari <leo@HIDDEN> writes: > On Fri, Feb 14, 2025 at 04:10:22PM +0000, Morgan Arnold wrote: >> Maxime's concern seems to me to be more about the fact that this >> change facilitates (and arguably encourages) the accidental commission >> of copyright violations. This issue is not necessarily specific to >> Linux+ZFS, but is the primary example being discussed because >> facilitating Linux+ZFS systems would be a major application of this >> patch. > > Thanks Morgan. I agree that if we are not understanding Maxime's point, > I hope we will be corrected. > > If Maxime's concern is that Guix should not make it too easy for users > to distribute software for which they do not have the license, I hear > that concern, but I argue that we shouldn't go very far with it. Of > course, Guix itself should not do that kind of thing, but we shouldn't > go out of our way to prevent users from doing so. > > Sure, let's not make a special variable "Linux with ZFS" that a user > only needs to tweak a single line in order to build and distribute. > > But we shouldn't prevent users from adding kernel modules to their > initrd, because that is explicitly not a problem from a licensing > standpoint. And if users choose to redistribute the compiled result, > that is their mistake / decision, not ours. > > Again, I don't see what is special with this combination, compared to > things like the incompatibility of the OpenSSL and GPL licenses. OpenSSL > could not be distributed linked with GPL code for many years of Guix, > and we didn't combine the licenses ourselves. But it was trivial for > users to do it, even on the command line by using package > transformations. That was okay, and I think this is a similar situation > that is also okay. > > To all, remember, my earlier message clarified the distinction between > combination and distribution. I hope further discussion will keep that > distinction in mind, if it is correct. Of course copyright is only > concerned with "copying" and distribution. If I've followed correctly, I think Maxime's last reservation to this change was that currently, even if the ZFS module is marked as non-substitutable, after it gets embedded in a binary initrd via this proposed change, it could become available as a binary substitute that lacks any of the 'non-substitutable' metadata, as (I assume) the initrd keeps no reference to the non-substitutable modules and Guix currently has no other means to know. Maxime's suggestion was to turn every initrd derivation into non-substitutable, which would work around that, but it'd means that everyone would also be building their initrd locally from source, which doesn't sound too great as it makes the current experience worst to satisfy a niche requirement (using out-of-tree kernel modules with incompatible licenses). Perhaps there could be some special case code that could be inserted at the right place to do the right thing; it'd need to be investigated. -- Thanks, Maxim
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at submit) by debbugs.gnu.org; 14 Feb 2025 18:55:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 14 13:55:03 2025 Received: from localhost ([127.0.0.1]:51821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tj0q6-00026o-F1 for submit <at> debbugs.gnu.org; Fri, 14 Feb 2025 13:55:03 -0500 Received: from lists.gnu.org ([2001:470:142::17]:57076) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>) id 1tj0pv-00025f-CT for submit <at> debbugs.gnu.org; Fri, 14 Feb 2025 13:54:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <morgan.arnold@HIDDEN>) id 1tj0po-0006NU-Ki; Fri, 14 Feb 2025 13:54:44 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <morgan.arnold@HIDDEN>) id 1tj0pl-0006NC-N4; Fri, 14 Feb 2025 13:54:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1739559278; x=1739818478; bh=nAqKePZjfgkIy3PY/9DCnLX5zgOHw0wgXXeb8xtSdiU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=HT2aCmRfIE+4pAfM9TgqJeloceWO8HMXAKA1AsICYobElBgcc3ARs5DSxTfut4X7I 1BqgDTv+KW5Q4/XLA1v66CIUdKbP5TXjp6Gi7LiLEGxURRWdv/37bFwkWwkSTHCLmi 0+C9Nz7pFh+FnhVszdW0yXgOuPi7p+EjGXBovuomJlMFi66flGwHOMsyfUDz0yyZ3F IyTPznW7Jzc0VI80W65qrM67maiuoQKVjsRlVAJFQyDen8FZQkgBm8vPTiUr2+4LNN PHvgWgwp/gaFoy0E5BAafAEopCb59u4xmaeOf63SPNz48vmQlDXKq+/tY2r7Go472Y MfQRwbvkFJhkg== Date: Fri, 14 Feb 2025 18:54:33 +0000 To: Leo Famulari <leo@HIDDEN> From: Morgan Arnold <morgan.arnold@HIDDEN> Subject: Re: [bug#55231] Understanding #:substitutable? and #55231 Message-ID: <kd65wIxbPtafUl8CYTzMz4JgKIOBh3MKKYbfXW01DFkv1_84iwpu7fE1lIusqmK9_AZgCl7nJUx-j7rbo0jVJyEItfOPcn2cx_rMQ_kugVU=@proton.me> In-Reply-To: <Z6-IzkI8GPcXiVsb@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> <Z6leT5MPfBTb3Ffq@HIDDEN> <87bjva5sq8.fsf@HIDDEN> <Z65bYzVd7HwZBbNm@HIDDEN> <EeoPDHUUv2IQ_8_zXkbijLh9tHBiY0T_hIpjE-RaP3cZavCzvpiv_YCgNXneMdHqkW_ZPtrReuO-_BkepeoRmMMcDFNGOMOi3qiPSeEJAxY=@proton.me> <Z6-IzkI8GPcXiVsb@HIDDEN> Feedback-ID: 45510636:user:proton X-Pm-Message-ID: ecfef11805a0ce8b2f1eb7da3e8d1a42e1a71271 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.16; envelope-from=morgan.arnold@HIDDEN; helo=mail-4316.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Ian Eure <ian@HIDDEN>, =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, guix-devel@HIDDEN, 55231 <at> debbugs.gnu.org, Maxime Devos via Guix-patches via <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) Hi Leo, > If Maxime's concern is that Guix should not make it too easy for users > to distribute software for which they do not have the license, I hear > that concern, but I argue that we shouldn't go very far with it. Of > course, Guix itself should not do that kind of thing, but we shouldn't > go out of our way to prevent users from doing so. I am inclined to agree with this point of view, but it is my understanding = that Maxime does not, and it seems like (at a minimum) rather bad form to m= erge this patch over entirely reasonable objections, even if we happen to d= isagree with the reasoning behind those objections. This, of course, being = subject to the assumption that I am interpreting Maxime's objections correc= tly. My hope in making `#:substitutable? #f` propagate to dependents was to= resolve this issue by simply implementing user protection from any acciden= tal copyright-violating distribution. This seems to me like the most feasib= le path to assembling a patch set which would satisfy the expressed concern= s, and so the most feasible path to the merging of this patch set. I would be very open to finding another way to address these concerns, but = `#:substitutable? #f` propagation was the only solution which presented its= elf to me. There may be a simpler way to deal specifically with the case of= initrds, since those are what are being changed here, but the only scheme = which I was able to devise for implementation required working at the level= of derivations (essentially, because one has to be able to access the inpu= ts of the initrd as derivations to be able to speak of their substitutabili= ty, since substitutability is a property of derivations). Best, Morgan
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 14 Feb 2025 18:54:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 14 13:54:47 2025 Received: from localhost ([127.0.0.1]:51815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tj0pr-00025q-17 for submit <at> debbugs.gnu.org; Fri, 14 Feb 2025 13:54:47 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:64283) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>) id 1tj0po-00025V-Ke for 55231 <at> debbugs.gnu.org; Fri, 14 Feb 2025 13:54:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1739559278; x=1739818478; bh=nAqKePZjfgkIy3PY/9DCnLX5zgOHw0wgXXeb8xtSdiU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=HT2aCmRfIE+4pAfM9TgqJeloceWO8HMXAKA1AsICYobElBgcc3ARs5DSxTfut4X7I 1BqgDTv+KW5Q4/XLA1v66CIUdKbP5TXjp6Gi7LiLEGxURRWdv/37bFwkWwkSTHCLmi 0+C9Nz7pFh+FnhVszdW0yXgOuPi7p+EjGXBovuomJlMFi66flGwHOMsyfUDz0yyZ3F IyTPznW7Jzc0VI80W65qrM67maiuoQKVjsRlVAJFQyDen8FZQkgBm8vPTiUr2+4LNN PHvgWgwp/gaFoy0E5BAafAEopCb59u4xmaeOf63SPNz48vmQlDXKq+/tY2r7Go472Y MfQRwbvkFJhkg== Date: Fri, 14 Feb 2025 18:54:33 +0000 To: Leo Famulari <leo@HIDDEN> From: Morgan Arnold <morgan.arnold@HIDDEN> Subject: Re: [bug#55231] Understanding #:substitutable? and #55231 Message-ID: <kd65wIxbPtafUl8CYTzMz4JgKIOBh3MKKYbfXW01DFkv1_84iwpu7fE1lIusqmK9_AZgCl7nJUx-j7rbo0jVJyEItfOPcn2cx_rMQ_kugVU=@proton.me> In-Reply-To: <Z6-IzkI8GPcXiVsb@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> <Z6leT5MPfBTb3Ffq@HIDDEN> <87bjva5sq8.fsf@HIDDEN> <Z65bYzVd7HwZBbNm@HIDDEN> <EeoPDHUUv2IQ_8_zXkbijLh9tHBiY0T_hIpjE-RaP3cZavCzvpiv_YCgNXneMdHqkW_ZPtrReuO-_BkepeoRmMMcDFNGOMOi3qiPSeEJAxY=@proton.me> <Z6-IzkI8GPcXiVsb@HIDDEN> Feedback-ID: 45510636:user:proton X-Pm-Message-ID: ecfef11805a0ce8b2f1eb7da3e8d1a42e1a71271 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, guix-devel@HIDDEN, 55231 <at> debbugs.gnu.org, Maxime Devos via Guix-patches via <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Leo, > If Maxime's concern is that Guix should not make it too easy for users > to distribute software for which they do not have the license, I hear > that concern, but I argue that we shouldn't go very far with it. Of > course, Guix itself should not do that kind of thing, but we shouldn't > go out of our way to prevent users from doing so. I am inclined to agree with this point of view, but it is my understanding = that Maxime does not, and it seems like (at a minimum) rather bad form to m= erge this patch over entirely reasonable objections, even if we happen to d= isagree with the reasoning behind those objections. This, of course, being = subject to the assumption that I am interpreting Maxime's objections correc= tly. My hope in making `#:substitutable? #f` propagate to dependents was to= resolve this issue by simply implementing user protection from any acciden= tal copyright-violating distribution. This seems to me like the most feasib= le path to assembling a patch set which would satisfy the expressed concern= s, and so the most feasible path to the merging of this patch set. I would be very open to finding another way to address these concerns, but = `#:substitutable? #f` propagation was the only solution which presented its= elf to me. There may be a simpler way to deal specifically with the case of= initrds, since those are what are being changed here, but the only scheme = which I was able to devise for implementation required working at the level= of derivations (essentially, because one has to be able to access the inpu= ts of the initrd as derivations to be able to speak of their substitutabili= ty, since substitutability is a property of derivations). Best, Morgan
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 14 Feb 2025 18:18:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 14 13:18:04 2025 Received: from localhost ([127.0.0.1]:51674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tj0GK-0000GY-63 for submit <at> debbugs.gnu.org; Fri, 14 Feb 2025 13:18:04 -0500 Received: from fout-b6-smtp.messagingengine.com ([202.12.124.149]:41469) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <leo@HIDDEN>) id 1tj0GF-0000Fs-53 for 55231 <at> debbugs.gnu.org; Fri, 14 Feb 2025 13:18:01 -0500 Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfout.stl.internal (Postfix) with ESMTP id EA1D711400B5; Fri, 14 Feb 2025 13:17:52 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Fri, 14 Feb 2025 13:17:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mesmtp; t=1739557072; x= 1739643472; bh=JRhhks3h6+yis9eKpD6fVh07iYuPgTE47GgVXTZcXZs=; b=M QScNYJ186imP7D0FoJdP3f8OegHrOGi5i9HuXfl3jKDLM6deH9tvwtYGJ2cjEagy 8oYmQVfKHWixejEV4LFsDtfqBnYGzfn9TiOVNIlfq9sWqTbAJz/dpARvNUGrfYOz 9y1micuXffj8TH5L9sL5Z+RlwXxtkXgpyuyizxcshM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1739557072; x=1739643472; bh=JRhhks3h6+yis9eKpD6fVh07iYuPgTE47Gg VXTZcXZs=; b=qC4O1/56ZkQzAtqPCPiO72mhz1Vnx8xW/+5YtQCx9vNSdZzopln bPv28Z8ZcINC5+ZLoU5avvwLmSxNPzhDh1X22bTjp+pTduQUnpIN6ymkM5lvOHac 55BOpe1ewKsyE0MYHfjA4o8r/BzetgAGL11NHB42eUQfCC+mCRT2lyKfgr/71s+Y igFifJNAMg2Q7uL1sq+sqY1HRa1Ygg7hV5ZRZE+V37X33Ea0simvmZzjcMYK0HEu tol+L4VUh6GGp7IV/pV4adluTwbFhiK1t4Bk1L2GZUYgkmWv/jWUDo4tWFWNm1qN K1TvH45aZfttk4WO3Yh4xKOdjTjo1QMWDDg== X-ME-Sender: <xms:0IivZ0fJeDFTtp4ARO3vMKXOvQVQX4uJ0uf-ywWRydNcMXPL9vxd-Q> <xme:0IivZ2OZrfzb0tkG0qabv1On3HHNYPC_Jwx1uXCo5DXG8TxtrGJh5bk2ZhZcqxu3V kGv6QiXCcMvUpix7w> X-ME-Received: <xmr:0IivZ1iZXcb-4NX0H5sJWUmQ_y9eHEE-J27_IR1vRd-SV9wYnqCPiT5m5ahWgmAx59tBzkxkDvugv_TtUT16mLFh> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdehtdefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddv necuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnh grmhgvqeenucggtffrrghtthgvrhhnpeeiteduheefkeeufeelgeduhfejgfelheefleeu hfeffffgueduleehvdejleeiteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgvpdhnsggprhgtphht thhopeejpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehmohhrghgrnhdrrghrnh holhgusehprhhothhonhdrmhgvpdhrtghpthhtohepfhgvlhhigidrlhgvtghhnhgvrhes lhgvrghsvgdquhhprdgtohhmpdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnh hurdhorhhgpdhrtghpthhtohepihgrnhesrhgvthhrohhsphgvtgdrthhvpdhrtghpthht ohepghhuihigqdguvghvvghlsehgnhhurdhorhhgpdhrtghpthhtoheplhhuughosehgnh hurdhorhhgpdhrtghpthhtohepheehvdefudesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: <xmx:0IivZ5_Gon_syKSUX6ORkaJFI5mNAb0krRFD73kCASfZUgAqQuysHA> <xmx:0IivZwswmc-DREpG6KsMcqOsQ10gXjgkSeeY5reWr4K8nhYrbNaRdw> <xmx:0IivZwHzbVpJkfwiZXpe1KCVTTbsKo_0cEB9J2hXXc1PJA2xN0oWuA> <xmx:0IivZ_PurJ6Uv9OW96OtfMoRcc77KXKoG3FCWDMssj2mM8-g7N8E_A> <xmx:0IivZ19CjBZDZ1yBUVHqjs6ERRKcQ6AlNy8CiTimk6fs2TFrHG4M2GLN> Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 14 Feb 2025 13:17:52 -0500 (EST) Date: Fri, 14 Feb 2025 13:17:50 -0500 From: Leo Famulari <leo@HIDDEN> To: Morgan Arnold <morgan.arnold@HIDDEN> Subject: Re: [bug#55231] Understanding #:substitutable? and #55231 Message-ID: <Z6-IzkI8GPcXiVsb@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> <Z6leT5MPfBTb3Ffq@HIDDEN> <87bjva5sq8.fsf@HIDDEN> <Z65bYzVd7HwZBbNm@HIDDEN> <EeoPDHUUv2IQ_8_zXkbijLh9tHBiY0T_hIpjE-RaP3cZavCzvpiv_YCgNXneMdHqkW_ZPtrReuO-_BkepeoRmMMcDFNGOMOi3qiPSeEJAxY=@proton.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <EeoPDHUUv2IQ_8_zXkbijLh9tHBiY0T_hIpjE-RaP3cZavCzvpiv_YCgNXneMdHqkW_ZPtrReuO-_BkepeoRmMMcDFNGOMOi3qiPSeEJAxY=@proton.me> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, guix-devel@HIDDEN, 55231 <at> debbugs.gnu.org, Maxime Devos via Guix-patches via <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On Fri, Feb 14, 2025 at 04:10:22PM +0000, Morgan Arnold wrote: > Maxime's concern seems to me to be more about the fact that this > change facilitates (and arguably encourages) the accidental commission > of copyright violations. This issue is not necessarily specific to > Linux+ZFS, but is the primary example being discussed because > facilitating Linux+ZFS systems would be a major application of this > patch. Thanks Morgan. I agree that if we are not understanding Maxime's point, I hope we will be corrected. If Maxime's concern is that Guix should not make it too easy for users to distribute software for which they do not have the license, I hear that concern, but I argue that we shouldn't go very far with it. Of course, Guix itself should not do that kind of thing, but we shouldn't go out of our way to prevent users from doing so. Sure, let's not make a special variable "Linux with ZFS" that a user only needs to tweak a single line in order to build and distribute. But we shouldn't prevent users from adding kernel modules to their initrd, because that is explicitly not a problem from a licensing standpoint. And if users choose to redistribute the compiled result, that is their mistake / decision, not ours. Again, I don't see what is special with this combination, compared to things like the incompatibility of the OpenSSL and GPL licenses. OpenSSL could not be distributed linked with GPL code for many years of Guix, and we didn't combine the licenses ourselves. But it was trivial for users to do it, even on the command line by using package transformations. That was okay, and I think this is a similar situation that is also okay. To all, remember, my earlier message clarified the distinction between combination and distribution. I hope further discussion will keep that distinction in mind, if it is correct. Of course copyright is only concerned with "copying" and distribution.
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at submit) by debbugs.gnu.org; 14 Feb 2025 18:18:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 14 13:18:23 2025 Received: from localhost ([127.0.0.1]:51678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tj0Gc-0000HF-U2 for submit <at> debbugs.gnu.org; Fri, 14 Feb 2025 13:18:23 -0500 Received: from lists.gnu.org ([2001:470:142::17]:42456) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <leo@HIDDEN>) id 1tj0GW-0000Gs-N2 for submit <at> debbugs.gnu.org; Fri, 14 Feb 2025 13:18:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1tj0GH-0001MY-4V; Fri, 14 Feb 2025 13:18:02 -0500 Received: from fout-b6-smtp.messagingengine.com ([202.12.124.149]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1tj0GD-0001OC-HA; Fri, 14 Feb 2025 13:17:59 -0500 Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfout.stl.internal (Postfix) with ESMTP id EA1D711400B5; Fri, 14 Feb 2025 13:17:52 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Fri, 14 Feb 2025 13:17:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mesmtp; t=1739557072; x= 1739643472; bh=JRhhks3h6+yis9eKpD6fVh07iYuPgTE47GgVXTZcXZs=; b=M QScNYJ186imP7D0FoJdP3f8OegHrOGi5i9HuXfl3jKDLM6deH9tvwtYGJ2cjEagy 8oYmQVfKHWixejEV4LFsDtfqBnYGzfn9TiOVNIlfq9sWqTbAJz/dpARvNUGrfYOz 9y1micuXffj8TH5L9sL5Z+RlwXxtkXgpyuyizxcshM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1739557072; x=1739643472; bh=JRhhks3h6+yis9eKpD6fVh07iYuPgTE47Gg VXTZcXZs=; b=qC4O1/56ZkQzAtqPCPiO72mhz1Vnx8xW/+5YtQCx9vNSdZzopln bPv28Z8ZcINC5+ZLoU5avvwLmSxNPzhDh1X22bTjp+pTduQUnpIN6ymkM5lvOHac 55BOpe1ewKsyE0MYHfjA4o8r/BzetgAGL11NHB42eUQfCC+mCRT2lyKfgr/71s+Y igFifJNAMg2Q7uL1sq+sqY1HRa1Ygg7hV5ZRZE+V37X33Ea0simvmZzjcMYK0HEu tol+L4VUh6GGp7IV/pV4adluTwbFhiK1t4Bk1L2GZUYgkmWv/jWUDo4tWFWNm1qN K1TvH45aZfttk4WO3Yh4xKOdjTjo1QMWDDg== X-ME-Sender: <xms:0IivZ0fJeDFTtp4ARO3vMKXOvQVQX4uJ0uf-ywWRydNcMXPL9vxd-Q> <xme:0IivZ2OZrfzb0tkG0qabv1On3HHNYPC_Jwx1uXCo5DXG8TxtrGJh5bk2ZhZcqxu3V kGv6QiXCcMvUpix7w> X-ME-Received: <xmr:0IivZ1iZXcb-4NX0H5sJWUmQ_y9eHEE-J27_IR1vRd-SV9wYnqCPiT5m5ahWgmAx59tBzkxkDvugv_TtUT16mLFh> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdehtdefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddv necuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnh grmhgvqeenucggtffrrghtthgvrhhnpeeiteduheefkeeufeelgeduhfejgfelheefleeu hfeffffgueduleehvdejleeiteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgvpdhnsggprhgtphht thhopeejpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehmohhrghgrnhdrrghrnh holhgusehprhhothhonhdrmhgvpdhrtghpthhtohepfhgvlhhigidrlhgvtghhnhgvrhes lhgvrghsvgdquhhprdgtohhmpdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnh hurdhorhhgpdhrtghpthhtohepihgrnhesrhgvthhrohhsphgvtgdrthhvpdhrtghpthht ohepghhuihigqdguvghvvghlsehgnhhurdhorhhgpdhrtghpthhtoheplhhuughosehgnh hurdhorhhgpdhrtghpthhtohepheehvdefudesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: <xmx:0IivZ5_Gon_syKSUX6ORkaJFI5mNAb0krRFD73kCASfZUgAqQuysHA> <xmx:0IivZwswmc-DREpG6KsMcqOsQ10gXjgkSeeY5reWr4K8nhYrbNaRdw> <xmx:0IivZwHzbVpJkfwiZXpe1KCVTTbsKo_0cEB9J2hXXc1PJA2xN0oWuA> <xmx:0IivZ_PurJ6Uv9OW96OtfMoRcc77KXKoG3FCWDMssj2mM8-g7N8E_A> <xmx:0IivZ19CjBZDZ1yBUVHqjs6ERRKcQ6AlNy8CiTimk6fs2TFrHG4M2GLN> Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 14 Feb 2025 13:17:52 -0500 (EST) Date: Fri, 14 Feb 2025 13:17:50 -0500 From: Leo Famulari <leo@HIDDEN> To: Morgan Arnold <morgan.arnold@HIDDEN> Subject: Re: [bug#55231] Understanding #:substitutable? and #55231 Message-ID: <Z6-IzkI8GPcXiVsb@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> <Z6leT5MPfBTb3Ffq@HIDDEN> <87bjva5sq8.fsf@HIDDEN> <Z65bYzVd7HwZBbNm@HIDDEN> <EeoPDHUUv2IQ_8_zXkbijLh9tHBiY0T_hIpjE-RaP3cZavCzvpiv_YCgNXneMdHqkW_ZPtrReuO-_BkepeoRmMMcDFNGOMOi3qiPSeEJAxY=@proton.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <EeoPDHUUv2IQ_8_zXkbijLh9tHBiY0T_hIpjE-RaP3cZavCzvpiv_YCgNXneMdHqkW_ZPtrReuO-_BkepeoRmMMcDFNGOMOi3qiPSeEJAxY=@proton.me> Received-SPF: pass client-ip=202.12.124.149; envelope-from=leo@HIDDEN; helo=fout-b6-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Ian Eure <ian@HIDDEN>, Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, guix-devel@HIDDEN, 55231 <at> debbugs.gnu.org, Maxime Devos via Guix-patches via <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) On Fri, Feb 14, 2025 at 04:10:22PM +0000, Morgan Arnold wrote: > Maxime's concern seems to me to be more about the fact that this > change facilitates (and arguably encourages) the accidental commission > of copyright violations. This issue is not necessarily specific to > Linux+ZFS, but is the primary example being discussed because > facilitating Linux+ZFS systems would be a major application of this > patch. Thanks Morgan. I agree that if we are not understanding Maxime's point, I hope we will be corrected. If Maxime's concern is that Guix should not make it too easy for users to distribute software for which they do not have the license, I hear that concern, but I argue that we shouldn't go very far with it. Of course, Guix itself should not do that kind of thing, but we shouldn't go out of our way to prevent users from doing so. Sure, let's not make a special variable "Linux with ZFS" that a user only needs to tweak a single line in order to build and distribute. But we shouldn't prevent users from adding kernel modules to their initrd, because that is explicitly not a problem from a licensing standpoint. And if users choose to redistribute the compiled result, that is their mistake / decision, not ours. Again, I don't see what is special with this combination, compared to things like the incompatibility of the OpenSSL and GPL licenses. OpenSSL could not be distributed linked with GPL code for many years of Guix, and we didn't combine the licenses ourselves. But it was trivial for users to do it, even on the command line by using package transformations. That was okay, and I think this is a similar situation that is also okay. To all, remember, my earlier message clarified the distinction between combination and distribution. I hope further discussion will keep that distinction in mind, if it is correct. Of course copyright is only concerned with "copying" and distribution.
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 14 Feb 2025 16:10:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 14 11:10:37 2025 Received: from localhost ([127.0.0.1]:51344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tiyGz-0007yk-47 for submit <at> debbugs.gnu.org; Fri, 14 Feb 2025 11:10:37 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:61177) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>) id 1tiyGv-0007yT-SJ for 55231 <at> debbugs.gnu.org; Fri, 14 Feb 2025 11:10:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1739549427; x=1739808627; bh=58aT/RAZ1R8b/nTYNBro96g8UVI7WhqYr446WAMqYs8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=SdfLP9O9Y0puWbOFdRMfCDI2R4TNJQMUpQilLj+u6AfHasEbU/eOKAAi07G1Bwsh8 fDMwcCVvl0TcrCaWVdDek/LN3nHfYdzMjLLet2a0RmV5YsRmWgc5bMXl/Is+r0wK0Z JtoLNwD8LxZJQwTzm7gxuFysJpcHRq67370LICfQSd4MRvWeh6eIJn/zCRusnFCupR ZT77gNzrkvjWP7aFHZDSW88BjgQfja5x+/Y2cBPLj4cN2dem6xcPIsf/d7Vh/QMinh EKA+hikyGOxo0sKQXiFiFJEfJ5kwUhot+uzJAjr55V6Jnv18jJGJ9r7Op2AEVL3br4 p9x2ET/fQguqA== Date: Fri, 14 Feb 2025 16:10:22 +0000 To: Leo Famulari <leo@HIDDEN> From: Morgan Arnold <morgan.arnold@HIDDEN> Subject: Re: [bug#55231] Understanding #:substitutable? and #55231 Message-ID: <EeoPDHUUv2IQ_8_zXkbijLh9tHBiY0T_hIpjE-RaP3cZavCzvpiv_YCgNXneMdHqkW_ZPtrReuO-_BkepeoRmMMcDFNGOMOi3qiPSeEJAxY=@proton.me> In-Reply-To: <Z65bYzVd7HwZBbNm@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> <Z6leT5MPfBTb3Ffq@HIDDEN> <87bjva5sq8.fsf@HIDDEN> <Z65bYzVd7HwZBbNm@HIDDEN> Feedback-ID: 45510636:user:proton X-Pm-Message-ID: a4633f7fa2bce69772824d5599440c12e24a8c6c MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, guix-devel@HIDDEN, 55231 <at> debbugs.gnu.org, Maxime Devos via Guix-patches via <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Leo, Thanks for your interest! > If it is the case, then I don't think that Guix needs to do anything > about this except prevent our CI infrastructure from building the ZFS > module. We wouldn't need to hardcode any restrictions into the Guix > codebase. We have created these kinds of CI restrictions in the past. I think that Maxime has argued against the idea that this is a sufficient g= uardrail. To (hopefully accurately) summarize Maxime's position, the issue = is not simply preventing Guix's CI infrastructure from serving the combined= work, but that this change would make it easier for users of Guix to accid= entally serve the combined work by use of `guix publish`. Maxime's position= is, to the best of my understanding, that this change should not be introd= uced to Guix, as it makes it easier for an end user to accidentally commit = a copyright violation. If I have misrepresented Maxime's position here, I w= ould welcome a correction. I personally believe that the odds of a user accidentally committing a copy= right violation due to this change are sufficiently low that it would be ac= ceptable to merge the patch as-is, but reasonable minds can and of course d= o differ on this point. My attempts to make `#:substitutable? #f` "poisonin= g" are an attempt to fix this, but I have found that my lack of experience = has made it difficult for me to figure out how to test that this change is = behaving appropriately. It currently seems that more packages than I expect= ed are "poisoned" for reasons that I do not really understand. Any help wit= h understanding this would be hugely appreciated. > Already it's possible to create combinations of programs with > incompatible free software licenses, as a user. Is this particular > combination (ZFS and Linux) special in some way? As discussed (in particular by Ian), it is already very possible to commit = copyright violations with Guix. Maxime's concern seems to me to be more abo= ut the fact that this change facilitates (and arguably encourages) the acci= dental commission of copyright violations. This issue is not necessarily sp= ecific to Linux+ZFS, but is the primary example being discussed because fac= ilitating Linux+ZFS systems would be a major application of this patch. Best, Morgan P.S. In my proposed patch to `derivation`, I accidentally fat-fingered an e= xtra closing parenthesis at the end of the changed line. I haven't bothered= to submit a v6 of the patch set which fixes this, since I'm not sure if th= e corrected version of the patch even works as intended (or, if it is worki= ng as intended, why so many more packages than expected seem to be poisoned= ).
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at submit) by debbugs.gnu.org; 14 Feb 2025 16:10:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Feb 14 11:10:54 2025 Received: from localhost ([127.0.0.1]:51348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tiyHF-0007zL-SU for submit <at> debbugs.gnu.org; Fri, 14 Feb 2025 11:10:54 -0500 Received: from lists.gnu.org ([2001:470:142::17]:52902) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>) id 1tiyHB-0007yz-1u for submit <at> debbugs.gnu.org; Fri, 14 Feb 2025 11:10:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <morgan.arnold@HIDDEN>) id 1tiyH4-00014b-7W; Fri, 14 Feb 2025 11:10:42 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <morgan.arnold@HIDDEN>) id 1tiyH1-0007oG-4m; Fri, 14 Feb 2025 11:10:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1739549427; x=1739808627; bh=58aT/RAZ1R8b/nTYNBro96g8UVI7WhqYr446WAMqYs8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=SdfLP9O9Y0puWbOFdRMfCDI2R4TNJQMUpQilLj+u6AfHasEbU/eOKAAi07G1Bwsh8 fDMwcCVvl0TcrCaWVdDek/LN3nHfYdzMjLLet2a0RmV5YsRmWgc5bMXl/Is+r0wK0Z JtoLNwD8LxZJQwTzm7gxuFysJpcHRq67370LICfQSd4MRvWeh6eIJn/zCRusnFCupR ZT77gNzrkvjWP7aFHZDSW88BjgQfja5x+/Y2cBPLj4cN2dem6xcPIsf/d7Vh/QMinh EKA+hikyGOxo0sKQXiFiFJEfJ5kwUhot+uzJAjr55V6Jnv18jJGJ9r7Op2AEVL3br4 p9x2ET/fQguqA== Date: Fri, 14 Feb 2025 16:10:22 +0000 To: Leo Famulari <leo@HIDDEN> From: Morgan Arnold <morgan.arnold@HIDDEN> Subject: Re: [bug#55231] Understanding #:substitutable? and #55231 Message-ID: <EeoPDHUUv2IQ_8_zXkbijLh9tHBiY0T_hIpjE-RaP3cZavCzvpiv_YCgNXneMdHqkW_ZPtrReuO-_BkepeoRmMMcDFNGOMOi3qiPSeEJAxY=@proton.me> In-Reply-To: <Z65bYzVd7HwZBbNm@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> <Z6leT5MPfBTb3Ffq@HIDDEN> <87bjva5sq8.fsf@HIDDEN> <Z65bYzVd7HwZBbNm@HIDDEN> Feedback-ID: 45510636:user:proton X-Pm-Message-ID: a4633f7fa2bce69772824d5599440c12e24a8c6c MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.16; envelope-from=morgan.arnold@HIDDEN; helo=mail-4316.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Ian Eure <ian@HIDDEN>, =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>, Felix Lechner <felix.lechner@HIDDEN>, guix-devel@HIDDEN, 55231 <at> debbugs.gnu.org, Maxime Devos via Guix-patches via <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) Hi Leo, Thanks for your interest! > If it is the case, then I don't think that Guix needs to do anything > about this except prevent our CI infrastructure from building the ZFS > module. We wouldn't need to hardcode any restrictions into the Guix > codebase. We have created these kinds of CI restrictions in the past. I think that Maxime has argued against the idea that this is a sufficient g= uardrail. To (hopefully accurately) summarize Maxime's position, the issue = is not simply preventing Guix's CI infrastructure from serving the combined= work, but that this change would make it easier for users of Guix to accid= entally serve the combined work by use of `guix publish`. Maxime's position= is, to the best of my understanding, that this change should not be introd= uced to Guix, as it makes it easier for an end user to accidentally commit = a copyright violation. If I have misrepresented Maxime's position here, I w= ould welcome a correction. I personally believe that the odds of a user accidentally committing a copy= right violation due to this change are sufficiently low that it would be ac= ceptable to merge the patch as-is, but reasonable minds can and of course d= o differ on this point. My attempts to make `#:substitutable? #f` "poisonin= g" are an attempt to fix this, but I have found that my lack of experience = has made it difficult for me to figure out how to test that this change is = behaving appropriately. It currently seems that more packages than I expect= ed are "poisoned" for reasons that I do not really understand. Any help wit= h understanding this would be hugely appreciated. > Already it's possible to create combinations of programs with > incompatible free software licenses, as a user. Is this particular > combination (ZFS and Linux) special in some way? As discussed (in particular by Ian), it is already very possible to commit = copyright violations with Guix. Maxime's concern seems to me to be more abo= ut the fact that this change facilitates (and arguably encourages) the acci= dental commission of copyright violations. This issue is not necessarily sp= ecific to Linux+ZFS, but is the primary example being discussed because fac= ilitating Linux+ZFS systems would be a major application of this patch. Best, Morgan P.S. In my proposed patch to `derivation`, I accidentally fat-fingered an e= xtra closing parenthesis at the end of the changed line. I haven't bothered= to submit a v6 of the patch set which fixes this, since I'm not sure if th= e corrected version of the patch even works as intended (or, if it is worki= ng as intended, why so many more packages than expected seem to be poisoned= ).
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at submit) by debbugs.gnu.org; 13 Feb 2025 20:52:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 13 15:52:18 2025 Received: from localhost ([127.0.0.1]:45788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tigC2-0001HE-EO for submit <at> debbugs.gnu.org; Thu, 13 Feb 2025 15:52:18 -0500 Received: from lists.gnu.org ([2001:470:142::17]:49076) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <leo@HIDDEN>) id 1tigBz-0001Gt-Vw for submit <at> debbugs.gnu.org; Thu, 13 Feb 2025 15:52:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1tigBg-0000dX-Np; Thu, 13 Feb 2025 15:51:57 -0500 Received: from fout-b1-smtp.messagingengine.com ([202.12.124.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1tigBe-0000g2-1d; Thu, 13 Feb 2025 15:51:55 -0500 Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfout.stl.internal (Postfix) with ESMTP id 1321211400AF; Thu, 13 Feb 2025 15:51:50 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Thu, 13 Feb 2025 15:51:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mesmtp; t=1739479909; x= 1739566309; bh=hYiMZmam8ukhLOiHvpjmMOxxy+FsbVTTzgp6Ytjy+Rw=; b=j OvhoKO7P5khxYZhrFBCpsI6RQPx0xvmuzgUHD+doPjOf61zDn8mqoIpic1VT7KuS hT9g8Z8H10riBeCCzwBT2KmQ8O38pX2+HqBDgbQUSClFuMx+rQBTHkgQW+9sKiws DcVzXquUOhMm8pjuMWFUgoEId7ow5c+7eglQj5LTpU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1739479909; x=1739566309; bh=hYiMZmam8ukhLOiHvpjmMOxxy+FsbVTTzgp 6Ytjy+Rw=; b=z4qXozkPE7RL8saXUN+dF2xJIEhh8a6bv2rq3/VpPp7G88T++Vu 2X1siB4lOI6Js/J9rqsPXB3yLZK6+T8vYr7NUuzp9KHnuTSJCJVNnkcNrRPHQBDA yO7IxUd8TvIGTt3vKT9jr9VUzPXH7sgkHe8mJv/Lvk2VGStwKSRGwbg57y1YzvuE pR4mYOAlQEvJ4LjZ7DCI3lGXvmTNmHxzmN9u9IHc/Gw2efBQzJS34wGgf02EkQwd CwZOKpwEkYzkbHxDpIF8xX0gue6fhYDrFEe0HevSDf97Y16jc/I9+3q5uLxtDDHe 0K9A5Ab/36lM/V0N1Ce5mbPksxsgyw1gxdg== X-ME-Sender: <xms:ZVuuZyezlIg6iWPljiFA_09_XKkIW1cWEC5MIUe-zy5diBv4fwMzFQ> <xme:ZVuuZ8NtLwLpp-pYdU54J48gvNHdymMYyNgRzEz2v7a8663LCmCQx67Uemh6jesUv OBdQlclHtk6YWXmqg> X-ME-Received: <xmr:ZVuuZzhG88syisL1NlsnOaRTlkzOLlSgdUBIlupNeM7L4KOMJKa5BfRl8Uchz3enOqAKn9M_aSrNb-LqndEpn91i> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdegjeejkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddv necuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnh grmhgvqeenucggtffrrghtthgvrhhnpeeiteduheefkeeufeelgeduhfejgfelheefleeu hfeffffgueduleehvdejleeiteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgvpdhnsggprhgtphht thhopeejpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehfvghlihigrdhlvggthh hnvghrsehlvggrshgvqdhuphdrtghomhdprhgtphhtthhopehguhhigidqphgrthgthhgv shesghhnuhdrohhrghdprhgtphhtthhopehirghnsehrvghtrhhoshhpvggtrdhtvhdprh gtphhtthhopehguhhigidquggvvhgvlhesghhnuhdrohhrghdprhgtphhtthhopehmohhr ghgrnhdrrghrnhholhgusehprhhothhonhdrmhgvpdhrtghpthhtoheplhhuughosehgnh hurdhorhhgpdhrtghpthhtohepheehvdefudesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: <xmx:ZVuuZ_-hLvgN2Z6rYWkkkEAljftRYfH_CmyWp2XMPrUwbRND21EA8g> <xmx:ZVuuZ-vXvUZLvB0RkRvBnRBArBbuD8rOwN2jlgmlqkGUhrh7vuQfhQ> <xmx:ZVuuZ2GtXAbeSVBIS1ECFdMdyhH4zJtvkudFx-pjQI0HpKWl8d2DEA> <xmx:ZVuuZ9OJRF-V6S2Cwd6Sro9d6QHRXlkNetddyQvS-qJn_F_q16Fm8Q> <xmx:ZVuuZ7_uq7sJ3_4BZcdaloT7ni0_HsxvHRJ3S7WTKkntYu1KeWjPvO6y> Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Feb 2025 15:51:49 -0500 (EST) Date: Thu, 13 Feb 2025 15:51:47 -0500 From: Leo Famulari <leo@HIDDEN> To: Felix Lechner <felix.lechner@HIDDEN> Subject: Re: [bug#55231] Understanding #:substitutable? and #55231 Message-ID: <Z65bYzVd7HwZBbNm@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> <Z6leT5MPfBTb3Ffq@HIDDEN> <87bjva5sq8.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bjva5sq8.fsf@HIDDEN> Received-SPF: pass client-ip=202.12.124.144; envelope-from=leo@HIDDEN; helo=fout-b1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Ian Eure <ian@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@HIDDEN>, guix-devel@HIDDEN, 55231 <at> debbugs.gnu.org, Maxime Devos via Guix-patches via <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) On Sun, Feb 09, 2025 at 08:27:59PM -0800, Felix Lechner wrote: > On Sun, Feb 09 2025, Leo Famulari wrote: > > The violation of the licenses would only arise when distributing the > > combined work to a 3rd party? > > That's also my understanding. Cloud images would be a problem, but Guix > makes those unnecessary! If it is the case, then I don't think that Guix needs to do anything about this except prevent our CI infrastructure from building the ZFS module. We wouldn't need to hardcode any restrictions into the Guix codebase. We have created these kinds of CI restrictions in the past. Already it's possible to create combinations of programs with incompatible free software licenses, as a user. Is this particular combination (ZFS and Linux) special in some way?
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 13 Feb 2025 20:51:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Feb 13 15:51:58 2025 Received: from localhost ([127.0.0.1]:45783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tigBi-0001Fw-0Z for submit <at> debbugs.gnu.org; Thu, 13 Feb 2025 15:51:58 -0500 Received: from fout-b1-smtp.messagingengine.com ([202.12.124.144]:60553) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <leo@HIDDEN>) id 1tigBf-0001Fj-Nz for 55231 <at> debbugs.gnu.org; Thu, 13 Feb 2025 15:51:56 -0500 Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfout.stl.internal (Postfix) with ESMTP id 1321211400AF; Thu, 13 Feb 2025 15:51:50 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Thu, 13 Feb 2025 15:51:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mesmtp; t=1739479909; x= 1739566309; bh=hYiMZmam8ukhLOiHvpjmMOxxy+FsbVTTzgp6Ytjy+Rw=; b=j OvhoKO7P5khxYZhrFBCpsI6RQPx0xvmuzgUHD+doPjOf61zDn8mqoIpic1VT7KuS hT9g8Z8H10riBeCCzwBT2KmQ8O38pX2+HqBDgbQUSClFuMx+rQBTHkgQW+9sKiws DcVzXquUOhMm8pjuMWFUgoEId7ow5c+7eglQj5LTpU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1739479909; x=1739566309; bh=hYiMZmam8ukhLOiHvpjmMOxxy+FsbVTTzgp 6Ytjy+Rw=; b=z4qXozkPE7RL8saXUN+dF2xJIEhh8a6bv2rq3/VpPp7G88T++Vu 2X1siB4lOI6Js/J9rqsPXB3yLZK6+T8vYr7NUuzp9KHnuTSJCJVNnkcNrRPHQBDA yO7IxUd8TvIGTt3vKT9jr9VUzPXH7sgkHe8mJv/Lvk2VGStwKSRGwbg57y1YzvuE pR4mYOAlQEvJ4LjZ7DCI3lGXvmTNmHxzmN9u9IHc/Gw2efBQzJS34wGgf02EkQwd CwZOKpwEkYzkbHxDpIF8xX0gue6fhYDrFEe0HevSDf97Y16jc/I9+3q5uLxtDDHe 0K9A5Ab/36lM/V0N1Ce5mbPksxsgyw1gxdg== X-ME-Sender: <xms:ZVuuZyezlIg6iWPljiFA_09_XKkIW1cWEC5MIUe-zy5diBv4fwMzFQ> <xme:ZVuuZ8NtLwLpp-pYdU54J48gvNHdymMYyNgRzEz2v7a8663LCmCQx67Uemh6jesUv OBdQlclHtk6YWXmqg> X-ME-Received: <xmr:ZVuuZzhG88syisL1NlsnOaRTlkzOLlSgdUBIlupNeM7L4KOMJKa5BfRl8Uchz3enOqAKn9M_aSrNb-LqndEpn91i> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdegjeejkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddv necuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnh grmhgvqeenucggtffrrghtthgvrhhnpeeiteduheefkeeufeelgeduhfejgfelheefleeu hfeffffgueduleehvdejleeiteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgvpdhnsggprhgtphht thhopeejpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehfvghlihigrdhlvggthh hnvghrsehlvggrshgvqdhuphdrtghomhdprhgtphhtthhopehguhhigidqphgrthgthhgv shesghhnuhdrohhrghdprhgtphhtthhopehirghnsehrvghtrhhoshhpvggtrdhtvhdprh gtphhtthhopehguhhigidquggvvhgvlhesghhnuhdrohhrghdprhgtphhtthhopehmohhr ghgrnhdrrghrnhholhgusehprhhothhonhdrmhgvpdhrtghpthhtoheplhhuughosehgnh hurdhorhhgpdhrtghpthhtohepheehvdefudesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: <xmx:ZVuuZ_-hLvgN2Z6rYWkkkEAljftRYfH_CmyWp2XMPrUwbRND21EA8g> <xmx:ZVuuZ-vXvUZLvB0RkRvBnRBArBbuD8rOwN2jlgmlqkGUhrh7vuQfhQ> <xmx:ZVuuZ2GtXAbeSVBIS1ECFdMdyhH4zJtvkudFx-pjQI0HpKWl8d2DEA> <xmx:ZVuuZ9OJRF-V6S2Cwd6Sro9d6QHRXlkNetddyQvS-qJn_F_q16Fm8Q> <xmx:ZVuuZ7_uq7sJ3_4BZcdaloT7ni0_HsxvHRJ3S7WTKkntYu1KeWjPvO6y> Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Feb 2025 15:51:49 -0500 (EST) Date: Thu, 13 Feb 2025 15:51:47 -0500 From: Leo Famulari <leo@HIDDEN> To: Felix Lechner <felix.lechner@HIDDEN> Subject: Re: [bug#55231] Understanding #:substitutable? and #55231 Message-ID: <Z65bYzVd7HwZBbNm@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> <Z6leT5MPfBTb3Ffq@HIDDEN> <87bjva5sq8.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bjva5sq8.fsf@HIDDEN> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@HIDDEN>, guix-devel@HIDDEN, 55231 <at> debbugs.gnu.org, Maxime Devos via Guix-patches via <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On Sun, Feb 09, 2025 at 08:27:59PM -0800, Felix Lechner wrote: > On Sun, Feb 09 2025, Leo Famulari wrote: > > The violation of the licenses would only arise when distributing the > > combined work to a 3rd party? > > That's also my understanding. Cloud images would be a problem, but Guix > makes those unnecessary! If it is the case, then I don't think that Guix needs to do anything about this except prevent our CI infrastructure from building the ZFS module. We wouldn't need to hardcode any restrictions into the Guix codebase. We have created these kinds of CI restrictions in the past. Already it's possible to create combinations of programs with incompatible free software licenses, as a user. Is this particular combination (ZFS and Linux) special in some way?
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 12 Feb 2025 19:41:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 12 14:41:39 2025 Received: from localhost ([127.0.0.1]:38371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tiIc7-0004Sr-Dl for submit <at> debbugs.gnu.org; Wed, 12 Feb 2025 14:41:39 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:19287) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>) id 1tiIc4-0004SW-In for 55231 <at> debbugs.gnu.org; Wed, 12 Feb 2025 14:41:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1739389289; x=1739648489; bh=fOOo+4OQ4EFiaxCzoCjrTg6RfD2PiqvBIIei/MyrQ+o=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=ZzFAhszIs8OHW4xxsORO4XMPqHxkrb7f9GQ+2EM3LxYGbADR3XoNwaNSGj9Ezg4sM SKeKNjCbeBYXNRT3YQYcvGVN6w20bFdjxKn2Z6ePw7mP7SLtlC5+wd4xHlsRPCDib+ DFOMDddPvYv83h5RYI1tE39Q+Mi/fqzOPy+ceI4Raz1YzYG3RcUAvisVgd6VbtnOlp S35uIEtIcAULsInZObxkeg2oyj3qJrfA9yUP64AoNKQ6eevvwYovx3juTBDnkhnJBB rZfQvs4Jdq/x1FDFzzrct6/iFTO3NpmjdTEgT39ZxSArq62WXv7ZEH7GY+TtXvCNwu 0+AYMP6hVQyug== Date: Wed, 12 Feb 2025 19:41:22 +0000 To: Morgan Arnold <morgan.arnold@HIDDEN> From: Morgan Arnold <morgan.arnold@HIDDEN> Subject: =?utf-8?Q?Re:_bug#55231:_[PATCH_v1]_initrd:_Allow_extra_search_paths_with_=E2=80=98initrd-extra-module-paths=E2=80=99?= Message-ID: <aOt786iZX9EVyqAJO1tCSe7ev0OcCN8c5NKIsOkoGUd95ljy7L9_V3QEmXdeD7tAKq-UMGWzJnvt5az51foPXPwHYODD3RNCCeyf8VB7EVU=@proton.me> In-Reply-To: <iOT1aqNUX2hG8nPSfPERteM0XkN1mz1C-SoW2AYX_UjEEDIOe1FnHzWXnR5QlCYdU5rMpYEjwDCrJ8QofUff5U98_ohVR3sZtEjBpCSHeXE=@proton.me> References: <JTtAimnNMICUW-We530BE44G5KpCO2CoYASQY0J4ThyM0PF-Q0HIlIsjt4j1SdsjjPBobI-0iYoARfw5MmWiYoeC6hATg9llGDhWg6Ku4MA=@proton.me> <Z6oCQMYpj2R98syY@jurong> <VBHM6E4b-4Rwi1VeyYGs9CNojT6aQ5kKvXr8yBjlHZUpRCoJgkmWNBtW1sYZs6FZ1r5hDHuj-cB9VvWXmZ29GM0P3dwRY-VSboFzryTvPAY=@proton.me> <875xlgvd9h.fsf_-_@HIDDEN> <iOT1aqNUX2hG8nPSfPERteM0XkN1mz1C-SoW2AYX_UjEEDIOe1FnHzWXnR5QlCYdU5rMpYEjwDCrJ8QofUff5U98_ohVR3sZtEjBpCSHeXE=@proton.me> Feedback-ID: 45510636:user:proton X-Pm-Message-ID: 3b0d75c6a1da7358fd4f2837855e64a52bea2b38 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: Maxim Cournoyer <maxim.cournoyer@HIDDEN>, Ian Eure <ian@HIDDEN>, "ludo@HIDDEN" <ludo@HIDDEN>, "maximedevos@HIDDEN" <maximedevos@HIDDEN>, "guix-devel@HIDDEN" <guix-devel@HIDDEN>, Andreas Enge <andreas@HIDDEN>, "kaelyn.alexi@HIDDEN" <kaelyn.alexi@HIDDEN>, "john.kehayias@HIDDEN" <john.kehayias@HIDDEN>, "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi all, > I'm not sure if what I'm proposing would actually work. How prophetic. I did some more testing with the proposed change to `derivation`, and it se= ems to be causing a weird issue. I didn't think that propagating non-substi= tutability would be much of a problem, since there are very few non-substit= utable packages, but I was surprised to find that this change makes almost = all packages non-substitutable! I did some REPL-ing to find the culprit, an= d it when I traced it back, I found that all of my non-substitutable deriva= tions appeared to be so because their dependency graph included a derivatio= n called `#<derivation /gnu/store/qbrwrmdgnfx3p9gl499f5pyhv0fcnw0a-gcc-11.4= .0.drv =3D> /gnu/store/d69awcc5wahh71amx0dmgaimsdvvp2bg-gcc-11.4.0-lib 7fc7= c9bb99b0>`. Unfortunately, I cannot for the life of me figure out what this derivation = is, or why it isn't substitutable (all of its inputs are substitutable, and= I can't find any relevant package explicitly marked as non-substitutable).= I wonder if maybe it has something to do with the `gnu-build-system`? It a= ppears to be an input of `bash-minimal`, which is what leads me to that sus= picion. If I could figure out what this derivation is and why it's non-subs= titutable, I think that the change that the proposed change to `derivation`= would work (and, in some sense, implement what ought intuitively to be the= default behaviour, as Brian noted). Any and all relevant thoughts would be much appreciated. Best, Morgan
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 11 Feb 2025 14:59:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 09:59:40 2025 Received: from localhost ([127.0.0.1]:57989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thrjg-0004wg-2J for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 09:59:40 -0500 Received: from mail-40133.protonmail.ch ([185.70.40.133]:42241) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>) id 1thrjc-0004wO-UY for 55231 <at> debbugs.gnu.org; Tue, 11 Feb 2025 09:59:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=lnlrj7zpbnf4xfzjfkniq4v77e.protonmail; t=1739285970; x=1739545170; bh=m9qQvTkMuzk84mT7TH/Dr0+XBeMYLvK9OosE1V1B2ck=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=mex27pNZdS34JkqYnouGHI3UfTe4YkOk3wvj329dJeLi9S8XfUrC3ywbOMysmdfvN IKcYj/c9jiO6qa704x06O/cSfimtd0oGQEjuyH4kYrOZzTiLV8pkwz9vi7v9Z5PtUC 64Jmlf2gAeXN13Z8DdeXQhDEBPfBMApRjPP0GJxdMyxew+y0HAClEn1hVaw5VVC9V9 4H+UD4QXx/tSzaRQk1wUluUc/klJGkcgUPy7k4lzD3SfV+e4QrCytT4agql6p8XWdr I5BYzUmR6U7DpyGtUi2R8SaGoNB/dWgqBkdQ4BfTAXGoZCFMbTHpr9MdrWhTkgd5Nw 7r3bj80y4iuzQ== Date: Tue, 11 Feb 2025 14:59:26 +0000 To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> From: Morgan Arnold <morgan.arnold@HIDDEN> Subject: =?utf-8?Q?Re:_bug#55231:_[PATCH_v1]_initrd:_Allow_extra_search_paths_with_=E2=80=98initrd-extra-module-paths=E2=80=99?= Message-ID: <iOT1aqNUX2hG8nPSfPERteM0XkN1mz1C-SoW2AYX_UjEEDIOe1FnHzWXnR5QlCYdU5rMpYEjwDCrJ8QofUff5U98_ohVR3sZtEjBpCSHeXE=@proton.me> In-Reply-To: <875xlgvd9h.fsf_-_@HIDDEN> References: <JTtAimnNMICUW-We530BE44G5KpCO2CoYASQY0J4ThyM0PF-Q0HIlIsjt4j1SdsjjPBobI-0iYoARfw5MmWiYoeC6hATg9llGDhWg6Ku4MA=@proton.me> <Z6oCQMYpj2R98syY@jurong> <VBHM6E4b-4Rwi1VeyYGs9CNojT6aQ5kKvXr8yBjlHZUpRCoJgkmWNBtW1sYZs6FZ1r5hDHuj-cB9VvWXmZ29GM0P3dwRY-VSboFzryTvPAY=@proton.me> <875xlgvd9h.fsf_-_@HIDDEN> Feedback-ID: 45510636:user:proton X-Pm-Message-ID: 65188f9af099536da6f76da890b2c72d2048d450 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, "ludo@HIDDEN" <ludo@HIDDEN>, "maximedevos@HIDDEN" <maximedevos@HIDDEN>, "guix-devel@HIDDEN" <guix-devel@HIDDEN>, Andreas Enge <andreas@HIDDEN>, "kaelyn.alexi@HIDDEN" <kaelyn.alexi@HIDDEN>, "john.kehayias@HIDDEN" <john.kehayias@HIDDEN>, "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Maxim, Thanks for the input. I think that I communicated the idea that I'm proposi= ng poorly, although I'm not sure if what I'm proposing would actually work.= I sent a new version of the patchset with the change that I'm proposing im= plemented, which should hopefully clarify what I mean. Of course, it's very= possible that what I'm suggesting here is unacceptable for some reason tha= t I haven't noticed. Let me know if this doesn't adequately clarify things! Best, Morgan On Tuesday, February 11th, 2025 at 14:09, Maxim Cournoyer <maxim.cournoyer@= gmail.com> wrote: >=20 >=20 > Hi, >=20 > Morgan Arnold morgan.arnold@HIDDEN writes: >=20 > > Hi Andreas, > >=20 > > Thanks for the clarification. If this is the case, and texlive is > > unlikely to be used as a native input, it seems reasonable to me that > > setting `allowSubstitutes =3D 0` if `(not (and substitutable? (every su= bstitutable-derivation? inputs)))` would entirely eliminate the > > possibility of ZFS-based copyviols, as any derivation depending on it > > could not be substituted, and so neither Guix nor anyone using Guix > > could commit a copyviol. A user who wishes to use ZFS will then > > download the source code, compile the kernel module, and include it in > > their initrd, and this initrd will not accidentally be distributed. To > > the best of my non-lawyer understanding, this would not constitute any > > kind of copyviol. >=20 >=20 > I'm not sure exactly where in the daemon code this would be implemented? > Would you have a pseudo-code draft of where it'd be done? Few of us are > knowledgeable about the daemon code base. >=20 > > This seems to me to implement a maximally conservative (in terms of > > avoiding possible copyviols) approach to incorporating ZFS into > > Guix. If this makes sense, I would be happy to include that change to > > `derivation` in this patch set. >=20 >=20 > The idea is logical to me, but the implementation, if it touches how a > derivation is computed/changes its result, IIUC, would invalidate all > past derivations ever computed by Nix/Guix, which would be highly > undesirable/disruptive. >=20 > -- > Thanks, > Maxim
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 11 Feb 2025 14:57:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 09:57:04 2025
Received: from localhost ([127.0.0.1]:57975 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1thrh9-0004tA-SW
for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 09:57:04 -0500
Received: from mail-40134.protonmail.ch ([185.70.40.134]:12963)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>)
id 1thrh5-0004sL-UZ
for 55231 <at> debbugs.gnu.org; Tue, 11 Feb 2025 09:57:00 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me;
s=h4hlmtzubvcl3mfwa4tcicao5e.protonmail; t=1739285813; x=1739545013;
bh=wOB4xPWP7UhWkEcTp3UfAuy2ACEP93Y+vKhvQ5Es1LU=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
b=jGr8P1hm/xbVzQw4HQaaOO4irgGXj9LxfkRTcICrcmphWlW9mwtFFYBoAtWUdqDRd
/CbMGVbHqmtFV7VRk1VwTqEfVzvw6aPz64FN1XnFYSgXOcHs2BvbPxfgG5OCXqn9v/
Ltfut87b8rZpdnlwVm10reg/3XnO0qnoa8S51++k6g0CYe/Ftk8TS+j9oFO84SDt7D
a8XHbmDtxDJqcYYoxLpkcv4zEmGY0GlDWGe2Fc7YkH2Lr/uBgu5NaK/VyETAzYTod+
uur+++e7EzOgmyBF0D+GbGpzfVKuuP+ebnAgUjj5QTv23OG97Q8n8XlPcBD6x8RciE
Raie6S0mJJuEg==
Date: Tue, 11 Feb 2025 14:56:50 +0000
To: 55231 <at> debbugs.gnu.org
From: Morgan Arnold <morgan.arnold@HIDDEN>
Subject: [PATCH v5 3/3] Prevent possible copyright violations caused by initrd
changes.
Message-ID: <7658251299b5b223bb35ab6e23aa74c8e15c5a08.1739285590.git.morgan.arnold@HIDDEN>
In-Reply-To: <15e253236ef3ffae9adf9139c274eeb8cfdf9e8e.1739285590.git.morgan.arnold@HIDDEN>
References: <15e253236ef3ffae9adf9139c274eeb8cfdf9e8e.1739285590.git.morgan.arnold@HIDDEN>
Feedback-ID: 45510636:user:proton
X-Pm-Message-ID: 21e79b7fedd74b3cf78ffc6d6cff9e04525c627d
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: Morgan Arnold <morgan.arnold@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
This commit changes the conditions under which derivations, as constructed =
by the `derivation` function, are made substitutable, to prevent potential =
copyright violations related to the construction of substitutable initrds i=
ncluding non-substitutable derivations (in particular, ZFS).
This change prevents such copyright violations by only marking a derivation=
as substitutable if it is marked substitutable and all of its inputs are m=
arked as substitutable. This means that non-substitutable derivations have =
a "poisoning" effect, preventing derivations which take them as input from =
being substitutable.
Change-Id: I80ba4a371ee0c55a1294aff311d4e7b151055fac
---
guix/derivations.scm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/guix/derivations.scm b/guix/derivations.scm
index bef98cd26a..789e235eb8 100644
--- a/guix/derivations.scm
+++ b/guix/derivations.scm
@@ -868,6 +868,9 @@ (define* (derivation store name builder args
env-vars)
#f)))))
=20
+ (define inputs-substitutable? (every substitutable-derivation?
+ (map derivation-input-derivation in=
puts)))
+
(define (user+system-env-vars)
;; Some options are passed to the build daemon via the env. vars of
;; derivations (urgh!). We hide that from our API, but here is the pl=
ace
@@ -875,7 +878,7 @@ (define* (derivation store name builder args
(let ((env-vars `(,@(if local-build?
`(("preferLocalBuild" . "1"))
'())
- ,@(if (not substitutable?)
+ ,@(if (not (and substitutable? inputs-substitutable?=
)))
`(("allowSubstitutes" . "0"))
'())
,@(if allowed-references
--=20
2.47.1
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 11 Feb 2025 14:57:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 09:57:02 2025
Received: from localhost ([127.0.0.1]:57972 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1thrh6-0004sY-LR
for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 09:57:02 -0500
Received: from mail-4322.protonmail.ch ([185.70.43.22]:16513)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>)
id 1thrh3-0004sI-8T
for 55231 <at> debbugs.gnu.org; Tue, 11 Feb 2025 09:56:58 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me;
s=protonmail; t=1739285810; x=1739545010;
bh=hH7JD+Lak3rlR+ED7DzAteQSn19TVoCZW3AEyoCtjNA=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
b=NzCKKhCsn2ZaJr8wx4hMF34URsy+CseoFJK1LspSgM7eJIxag19j6gdu12zvLHM0p
2/CaYuEhS8cO5Nx9KJNqaMWhqB1rBCRU8lrLUw80iqAsv72E9ic+Ays7QMIs2V0hoT
x4A/C8CaaXA1NZZ8UlHLxlJXgr3J8rMLv8YDkdm+t8jByi+ui32MQA2tgu4CUm/RZG
Owr6Becp61WinF9iSzpoF9fcr2v7kmTufMf+GngSNXKsOMAmN+pbqTRppA153ZwMZN
mqTeSZaGcOCUDpkhN9dFfQvRnWWZ/TTF/798yyNdIBPImnWjIuACZGgY77M1e9tkbE
5B4O0mxVEUjMw==
Date: Tue, 11 Feb 2025 14:56:30 +0000
To: 55231 <at> debbugs.gnu.org
From: Morgan Arnold <morgan.arnold@HIDDEN>
Subject: =?utf-8?Q?[PATCH_v5_2/3]_doc:_=E2=80=98initrd-modules=E2=80=99_will_search_=E2=80=98kernel-loadable-modules=E2=80=99.?=
Message-ID: <c4f63708fd32996cc76a3ec5eec6ad72e6438642.1739285590.git.morgan.arnold@HIDDEN>
In-Reply-To: <15e253236ef3ffae9adf9139c274eeb8cfdf9e8e.1739285590.git.morgan.arnold@HIDDEN>
References: <15e253236ef3ffae9adf9139c274eeb8cfdf9e8e.1739285590.git.morgan.arnold@HIDDEN>
Feedback-ID: 45510636:user:proton
X-Pm-Message-ID: 94dd00c7f8f0a9fb1e4e1e89af1a5ae58926c5c7
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: Brian Cully <bjc@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
From: Brian Cully <bjc@HIDDEN>
---
doc/guix.texi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/doc/guix.texi b/doc/guix.texi
index bb5f29277f..2ca8bbda51 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -43252,6 +43252,21 @@ Initial RAM Disk
(initrd-modules (cons "megaraid_sas" %base-initrd-modules)))
@end lisp
=20
+If a module listed in @code{initrd-modules} is not included in the
+Linux-libre kernel, then the location to it must be added to the
+@code{kernel-loadable-modules} list.
+
+For example, if you need the driver for a Realtek RTL8821CE wireless
+network adapter for mounting the root filesystem over NFS, your
+configuration might include the following:
+
+@lisp
+(operating-system
+ ;; @dots{}
+ (initrd-modules (cons "8821ce" %base-initrd-modules))
+ (kernel-loadable-modules (list (list rtl8821ce-linux-module "module"))))
+@end lisp
+
@defvar %base-initrd-modules
This is the list of kernel modules included in the initrd by default.
@end defvar
--=20
2.47.1
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 11 Feb 2025 14:56:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 09:56:26 2025
Received: from localhost ([127.0.0.1]:57509 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1thrgY-0004kV-2t
for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 09:56:26 -0500
Received: from mail-40133.protonmail.ch ([185.70.40.133]:35909)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>)
id 1thrgT-0004cx-S8
for 55231 <at> debbugs.gnu.org; Tue, 11 Feb 2025 09:56:23 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me;
s=protonmail; t=1739285773; x=1739544973;
bh=X1H7ZRdf1749Bg+aquscNKYP85xe/HPB/X76dHLQph8=;
h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:
Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector:
List-Unsubscribe:List-Unsubscribe-Post;
b=SjpitOwdkADTNHlSEyNG+AcZwLC0HgXjH+E/0+AdupuwpqToMQK0ZYutYUmyChDju
JiKRmY5X9perLNWihHPWUazEOl1WkFH7LC27Jtre+uuNczGeYXUu+zNPwe4dHRqcD6
Qy8EfkK1BiVynGExN3gTGTXgqL7gkF5mCII2s1zQe8W+TV+fAg/xlAoJ0VkyQF0Pot
+OstewyRa5q5ZVdnGYmHtk2OF6Dd/wowTVLkMnTzClIowaudq4tcSe9Ui6KIAgjYQ0
m7H1vsvjNioIgAPgegDM7/7EHZ1ekTkU9OZ/OoNZiw1+1/Ld7nSCN07FdGAggBQ14h
I3uUcHsHLeK9g==
Date: Tue, 11 Feb 2025 14:56:07 +0000
To: 55231 <at> debbugs.gnu.org
From: Morgan Arnold <morgan.arnold@HIDDEN>
Subject: [PATCH v5 1/3] Allows copying of out-of-tree modules to the Linux
initrd.
Message-ID: <15e253236ef3ffae9adf9139c274eeb8cfdf9e8e.1739285590.git.morgan.arnold@HIDDEN>
Feedback-ID: 45510636:user:proton
X-Pm-Message-ID: f42dc2d3f480c89b0a7bfcd00b5c76d8de5a9186
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: Brian Cully <bjc@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
From: Brian Cully <bjc@HIDDEN>
With this patch, modules for =E2=80=98initrd-modules=E2=80=99 will not only=
be searched for in
the in-tree Linux modules, but also any additional modules specified in
=E2=80=98kernel-loadable-modules=E2=80=99.
* gnu/build/linux-modules.scm (find-module-file): change DIRECTORY argument=
to
DIRECTORIES. Now takes a list of directories to search, rather than a singl=
e
one.
* gnu/system/linux-initrd.scm (flat-linux-module-directory): change LINUX
argument to PACKAGES. Now contains a list of file-likes to search for modul=
es.
(raw-initrd): Add LINUX-EXTRA-MODULE-DIRECTORIES keyword argument. Pass it
to (flat-linux-module-directory) along with the selected LINUX package.
(base-initrd): Add LINUX-EXTRA-MODULE-DIRECTORIES keyword argument. Pass it
to (raw-initrd).
* gnu/system.scm (operating-system-initrd-file): pass in operating system
definition's kernel-loadable-modules into (make-initrd) as
LINUX-EXTRA-MODULE-DIRECTORIES.
---
gnu/build/linux-modules.scm | 19 ++++++++------
gnu/system.scm | 2 ++
gnu/system/linux-initrd.scm | 50 ++++++++++++++++++++++++-------------
3 files changed, 45 insertions(+), 26 deletions(-)
diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scm
index 32baf6c525..b47bce9ab2 100644
--- a/gnu/build/linux-modules.scm
+++ b/gnu/build/linux-modules.scm
@@ -246,8 +246,8 @@ (define (file-name->module-name file)
'.ko[.gz|.xz|.zst]' and normalizing it."
(normalize-module-name (strip-extension (basename file))))
=20
-(define (find-module-file directory module)
- "Lookup module NAME under DIRECTORY, and return its absolute file name.
+(define (find-module-file directories module)
+ "Lookup module NAME under DIRECTORIES, and return its absolute file name=
.
NAME can be a file name with or without '.ko', or it can be a module name.
Raise an error if it could not be found.
=20
@@ -268,16 +268,19 @@ (define (find-module-file directory module)
(else chr)))
module))))
=20
- (match (find-files directory
- (lambda (file stat)
- (member (strip-extension
- (basename file)) names)))
+ (match (append-map (lambda (directory)
+ (find-files directory
+ (lambda (file _stat)
+ (member (strip-extension
+ (basename file))
+ names))))
+ directories)
((file)
file)
(()
- (error "kernel module not found" module directory))
+ (error "kernel module not found" module directories))
((_ ...)
- (error "several modules by that name" module directory))))
+ (error "several modules by that name" module directories))))
=20
(define* (recursive-module-dependencies files
#:key (lookup-module dot-ko))
diff --git a/gnu/system.scm b/gnu/system.scm
index 8df871f255..1921b60c25 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -1373,6 +1373,8 @@ (define (operating-system-initrd-file os)
#:linux (operating-system-kernel os)
#:linux-modules
(operating-system-initrd-modules os)
+ #:linux-extra-module-directories
+ (operating-system-kernel-loadable-modules os)
#:mapped-devices mapped-devices
#:keyboard-layout (operating-system-keyboard-layout os)))
=20
diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm
index dc08edc791..dab40dfe22 100644
--- a/gnu/system/linux-initrd.scm
+++ b/gnu/system/linux-initrd.scm
@@ -120,13 +120,20 @@ (define* (expression->initrd exp
`(#:references-graphs (("closure" ,init))))
"/initrd.cpio.gz"))
=20
-(define (flat-linux-module-directory linux modules)
+(define (flat-linux-module-directory packages modules)
"Return a flat directory containing the Linux kernel modules listed in
-MODULES and taken from LINUX."
+MODULES and taken from PACKAGES."
(define imported-modules
(source-module-closure '((gnu build linux-modules)
(guix build utils))))
=20
+ (define package-inputs
+ (map (lambda (p)
+ (match p
+ ((p o) (gexp-input p o))
+ (p (gexp-input p "out"))))
+ packages))
+
(define build-exp
(with-imported-modules imported-modules
(with-extensions (list guile-zlib guile-zstd)
@@ -138,8 +145,9 @@ (define (flat-linux-module-directory linux modules)
(srfi srfi-26)
(ice-9 match))
=20
- (define module-dir
- (string-append #$linux "/lib/modules"))
+ (define module-dirs
+ (map (cut string-append <> "/lib/modules")
+ '#$package-inputs))
=20
(define builtin-modules
(match (find-files module-dir (lambda (file stat)
@@ -157,7 +165,7 @@ (define (flat-linux-module-directory linux modules)
(lset-difference string=3D? '#$modules builtin-modules))
=20
(define modules
- (let* ((lookup (cut find-module-file module-dir <>))
+ (let* ((lookup (cut find-module-file module-dirs <>))
(modules (map lookup modules-to-lookup)))
(append modules
(recursive-module-dependencies
@@ -192,6 +200,7 @@ (define* (raw-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-directories '())
(pre-mount #t)
(mapped-devices '())
(keyboard-layout #f)
@@ -199,15 +208,16 @@ (define* (raw-initrd file-systems
qemu-networking?
volatile-root?
(on-error 'debug))
- "Return as a file-like object a raw initrd, with kernel
-modules taken from LINUX. FILE-SYSTEMS is a list of file-systems to be
-mounted by the initrd, possibly in addition to the root file system specif=
ied
-on the kernel command line via 'root'. LINUX-MODULES is a list of kernel
-modules to be loaded at boot time. MAPPED-DEVICES is a list of device
-mappings to realize before FILE-SYSTEMS are mounted. PRE-MOUNT is a
-G-expression to evaluate before realizing MAPPED-DEVICES.
-HELPER-PACKAGES is a list of packages to be copied in the initrd. It may i=
nclude
-e2fsck/static or other packages needed by the initrd to check root partiti=
on.
+ "Return as a file-like object a raw initrd, with kernel modules taken fr=
om
+LINUX. FILE-SYSTEMS is a list of file-systems to be mounted by the initrd=
,
+possibly in addition to the root file system specified on the kernel comma=
nd
+line via 'root'. LINUX-MODULES is a list of kernel modules to be loaded a=
t
+boot time. LINUX-EXTRA-MODULE-DIRECTORIES is a list of file-like objects w=
hich
+will be searched for modules in addition to the linux kernel. MAPPED-DEVIC=
ES
+is a list of device mappings to realize before FILE-SYSTEMS are mounted.
+HELPER-PACKAGES is a list of packages to be copied in the initrd. It may
+include e2fsck/static or other packages needed by the initrd to check root
+partition.
=20
When true, KEYBOARD-LAYOUT is a <keyboard-layout> record denoting the desi=
red
console keyboard layout. This is done before MAPPED-DEVICES are set up an=
d
@@ -243,7 +253,8 @@ (define* (raw-initrd file-systems
#~())))
=20
(define kodir
- (flat-linux-module-directory linux linux-modules))
+ (flat-linux-module-directory (cons linux linux-extra-module-directorie=
s)
+ linux-modules))
=20
(expression->initrd
(with-imported-modules (source-module-closure
@@ -390,6 +401,7 @@ (define* (base-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-directories '())
(mapped-devices '())
(keyboard-layout #f)
qemu-networking?
@@ -410,9 +422,10 @@ (define* (base-initrd file-systems
QEMU-NETWORKING? and VOLATILE-ROOT? behaves as in raw-initrd.
=20
The initrd is automatically populated with all the kernel modules necessar=
y
-for FILE-SYSTEMS and for the given options. Additional kernel
-modules can be listed in LINUX-MODULES. They will be added to the initrd,=
and
-loaded at boot time in the order in which they appear."
+for FILE-SYSTEMS and for the given options. Additional kernel modules can=
be
+listed in LINUX-MODULES. Additional directories for modules can be listed=
in
+LINUX-EXTRA-MODULE-DIRECTORIES. They will be added to the initrd, and loa=
ded
+at boot time in the order in which they appear."
(define linux-modules*
;; Modules added to the initrd and loaded from the initrd.
`(,@linux-modules
@@ -432,6 +445,7 @@ (define* (base-initrd file-systems
(raw-initrd file-systems
#:linux linux
#:linux-modules linux-modules*
+ #:linux-extra-module-directories linux-extra-module-director=
ies
#:mapped-devices mapped-devices
#:helper-packages helper-packages
#:keyboard-layout keyboard-layout
base-commit: a8f223f91cf1170c85c0133e12856476e40a8288
--=20
2.47.1
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 11 Feb 2025 13:10:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Feb 11 08:10:12 2025 Received: from localhost ([127.0.0.1]:54981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thq1j-00019s-TK for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 08:10:12 -0500 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]:49324) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1thq1g-000147-Iu for 55231 <at> debbugs.gnu.org; Tue, 11 Feb 2025 08:10:09 -0500 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-21f7f1e1194so66835835ad.2 for <55231 <at> debbugs.gnu.org>; Tue, 11 Feb 2025 05:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739279401; x=1739884201; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=HM1xyOMJI0jCv+gUHbQDayshfaCRxAMFp5hnzl81T7Q=; b=HI4bGpw8qiRWVCpBUeyd7lLVNgOQlvAZLfzQeDj2RxQIGfL7pUQthwG+tvwotr3mzm Hz169A1QAg0sppgsi0KMpBkajAx4g2/PEWMdP/OuR5Y9EIStkBpLfHEJHNLGzxM2ovc/ WEeuP1ESdlBii6kqpWLrq5aweak8Pn3oG0Cpts0vim6Ne9eLEOD+kKobot7W++a4HMPh Sblc8MHeVKq5AIt8Tc7xsiZyHiM/jGxWGz1oQyKimv45eRMn2jDLpe/eXyy97vljKqzA G8FnGd1TTx5Y56m0wNT370EAgBBinD5RAltikebqsO8pAlM5gpMAnoerbnrl1jQNlwMK 6ecw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739279401; x=1739884201; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HM1xyOMJI0jCv+gUHbQDayshfaCRxAMFp5hnzl81T7Q=; b=j8G7tdAHeDzW7+yIvj8AB+CdWPLxuzH3Uoo19rL4PF+r56nZi/SrTxhpszrPbvJWBX zx1DlXxgZN7FbxqE3yZ++y60Uf8Qt9Z7qvLHqjwO2fPiTN7e06R0XgOdMeSzLRBUiSw0 4QfcJ+uFPKzxNFpzHgEmSiMOmJqM+9F/K8U/zKbXs0csEfBywWlggrdFHgDOB4VT1ScQ /HgYXylwjB4GbYPGtQTXtmN4ZZckde3sGdcF04HVBQ/vUXmp9D00I5nNEYTLLye0rklt lvA70nqeRMhdd1lyxVtZPdFEez5iPHsX/VYfkP0drPtytaJjJNRXBJJedrEXGeu4xEqi J2/Q== X-Forwarded-Encrypted: i=1; AJvYcCV8+NPSJL5/iKKaTEvH6PdUOVbqRDMbLzOpQX0C5DXKEawx3AAQ8uQZ9S6aQYrJ/j+rySaQeg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyRNyPzjX+VZKMlyJ32HmLMqE9fU6SNV33vVzHvufYt1C7qZc7D t4Gehv9mCUJwM8cbYp3JNoFV5XsXMHO9A+Hqga2VRZwAr9k77Lur2H34Iw== X-Gm-Gg: ASbGncv2puhyAJHzqqcmwXZjGpoDlDLyc+1Mbq1IhTYA0tkaM6cpsLxnacjfzD2mCEv tfedSju3wK5HRyMvUQKwyO5D/dGqNBhVhvarNXwUhXsdnSgtNohHVqbL4PNGfqn3WivuM0TkaF8 8TsyaPyVeoM3b9u9jhh46DG61GJgPAzcpx0DG4BzA5ThyD16eOSkYh3RV6NAAsgaLJOIpwyO+UA 7isvVIY6ZxLhZeJ81U78Sc/XEXAOB6mHKCVfuno8cfGLfckmyn90why6R6/S6XX2sHy6lcnE1kw C93qurdpg911 X-Google-Smtp-Source: AGHT+IH4087QU4ec1ZmQtgVNibMoSeC57IUw/NYFY/jec6DhKxEJiIeKu7nm+zXF3/o5x1G3HXDT6w== X-Received: by 2002:a05:6a21:3389:b0:1db:ff76:99d7 with SMTP id adf61e73a8af0-1ee03c00260mr30814242637.35.1739279401228; Tue, 11 Feb 2025 05:10:01 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ad51aecd55esm9366890a12.29.2025.02.11.05.09.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 05:10:00 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Morgan Arnold <morgan.arnold@HIDDEN> Subject: Re: bug#55231: [PATCH v1] initrd: Allow extra search paths with =?utf-8?Q?=E2=80=98initrd-extra-module-paths=E2=80=99?= In-Reply-To: <VBHM6E4b-4Rwi1VeyYGs9CNojT6aQ5kKvXr8yBjlHZUpRCoJgkmWNBtW1sYZs6FZ1r5hDHuj-cB9VvWXmZ29GM0P3dwRY-VSboFzryTvPAY=@proton.me> (Morgan Arnold's message of "Mon, 10 Feb 2025 15:53:54 +0000") References: <JTtAimnNMICUW-We530BE44G5KpCO2CoYASQY0J4ThyM0PF-Q0HIlIsjt4j1SdsjjPBobI-0iYoARfw5MmWiYoeC6hATg9llGDhWg6Ku4MA=@proton.me> <Z6oCQMYpj2R98syY@jurong> <VBHM6E4b-4Rwi1VeyYGs9CNojT6aQ5kKvXr8yBjlHZUpRCoJgkmWNBtW1sYZs6FZ1r5hDHuj-cB9VvWXmZ29GM0P3dwRY-VSboFzryTvPAY=@proton.me> Date: Tue, 11 Feb 2025 22:09:46 +0900 Message-ID: <875xlgvd9h.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, "ludo@HIDDEN" <ludo@HIDDEN>, "maximedevos@HIDDEN" <maximedevos@HIDDEN>, "guix-devel@HIDDEN" <guix-devel@HIDDEN>, Andreas Enge <andreas@HIDDEN>, "kaelyn.alexi@HIDDEN" <kaelyn.alexi@HIDDEN>, "john.kehayias@HIDDEN" <john.kehayias@HIDDEN>, "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi, Morgan Arnold <morgan.arnold@HIDDEN> writes: > Hi Andreas, > > Thanks for the clarification. If this is the case, and texlive is > unlikely to be used as a native input, it seems reasonable to me that > setting `allowSubstitutes = 0` if `(not (and substitutable? (every > substitutable-derivation? inputs)))` would entirely eliminate the > possibility of ZFS-based copyviols, as any derivation depending on it > could not be substituted, and so neither Guix nor anyone using Guix > could commit a copyviol. A user who wishes to use ZFS will then > download the source code, compile the kernel module, and include it in > their initrd, and this initrd will not accidentally be distributed. To > the best of my non-lawyer understanding, this would not constitute any > kind of copyviol. I'm not sure exactly where in the daemon code this would be implemented? Would you have a pseudo-code draft of where it'd be done? Few of us are knowledgeable about the daemon code base. > This seems to me to implement a maximally conservative (in terms of > avoiding possible copyviols) approach to incorporating ZFS into > Guix. If this makes sense, I would be happy to include that change to > `derivation` in this patch set. The idea is logical to me, but the implementation, if it touches how a derivation is computed/changes its result, IIUC, would invalidate all past derivations ever computed by Nix/Guix, which would be highly undesirable/disruptive. -- Thanks, Maxim
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 10 Feb 2025 15:54:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 10 10:54:13 2025 Received: from localhost ([127.0.0.1]:52069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thW6v-0007QJ-21 for submit <at> debbugs.gnu.org; Mon, 10 Feb 2025 10:54:13 -0500 Received: from mail-4322.protonmail.ch ([185.70.43.22]:52891) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>) id 1thW6p-0007Pz-Nl for 55231 <at> debbugs.gnu.org; Mon, 10 Feb 2025 10:54:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1739202841; x=1739462041; bh=PWMO4P1aOpAZ+CezbruzXf00KAx1fsrjHNZJOWK6jAE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=XNnV0l98T5BPRjs+KebWKZMEQOl1mU6dxol2kd70KVjUBtdFjH5sT6we48wg5vKlS ivyknv5rN8XLfGyWxmd6ZLpFRdfLyuGhA0Lh1cFFyPNQ0B1qTA5ndEMdYPj0uThNZW CJ55ohz1AmFrqL/ReGijcF/uSdDDymw4g9QRenvagZCrPuG6B9aVJbkdwJ9NhuhAqF z6wFQgIUptbDLJt8DeR9o7Sk5AWstYtVp323Xw9KXKaEFm6L5SacNX0sz+nXUh5CaA XnMoSo/lHPj3qGlhGmGdXQdYwsLn/4qilgQ75Y0fanROmDIhUwOQKq5vSXvXKqak7N z+GlxAS/KNmHA== Date: Mon, 10 Feb 2025 15:53:54 +0000 To: Andreas Enge <andreas@HIDDEN> From: Morgan Arnold <morgan.arnold@HIDDEN> Subject: Re: Understanding #:substitutable? and #55231 Message-ID: <VBHM6E4b-4Rwi1VeyYGs9CNojT6aQ5kKvXr8yBjlHZUpRCoJgkmWNBtW1sYZs6FZ1r5hDHuj-cB9VvWXmZ29GM0P3dwRY-VSboFzryTvPAY=@proton.me> In-Reply-To: <Z6oCQMYpj2R98syY@jurong> References: <JTtAimnNMICUW-We530BE44G5KpCO2CoYASQY0J4ThyM0PF-Q0HIlIsjt4j1SdsjjPBobI-0iYoARfw5MmWiYoeC6hATg9llGDhWg6Ku4MA=@proton.me> <Z6oCQMYpj2R98syY@jurong> Feedback-ID: 45510636:user:proton X-Pm-Message-ID: a1944dbcce8d1897e0879986a4302e2c0771e1d4 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, "ludo@HIDDEN" <ludo@HIDDEN>, "maximedevos@HIDDEN" <maximedevos@HIDDEN>, "john.kehayias@HIDDEN" <john.kehayias@HIDDEN>, "kaelyn.alexi@HIDDEN" <kaelyn.alexi@HIDDEN>, "guix-devel@HIDDEN" <guix-devel@HIDDEN>, "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Andreas, Thanks for the clarification. If this is the case, and texlive is unlikely = to be used as a native input, it seems reasonable to me that setting `allow= Substitutes =3D 0` if `(not (and substitutable? (every substitutable-deriva= tion? inputs)))` would entirely eliminate the possibility of ZFS-based copy= viols, as any derivation depending on it could not be substituted, and so n= either Guix nor anyone using Guix could commit a copyviol. A user who wishe= s to use ZFS will then download the source code, compile the kernel module,= and include it in their initrd, and this initrd will not accidentally be d= istributed. To the best of my non-lawyer understanding, this would not cons= titute any kind of copyviol. This seems to me to implement a maximally conservative (in terms of avoidin= g possible copyviols) approach to incorporating ZFS into Guix. If this make= s sense, I would be happy to include that change to `derivation` in this pa= tch set. Best, Morgan On Monday, February 10th, 2025 at 14:42, Andreas Enge <andreas@HIDDEN> wro= te: >=20 >=20 > Hello, >=20 > Am Sun, Feb 09, 2025 at 10:42:26PM +0000 schrieb Morgan Arnold via Develo= pment of GNU Guix and the GNU System distribution.: >=20 > > It might be more correct to allow derivations built with non-substituta= ble native inputs to be substitutable nonetheless. The alternative seems li= ke it could cause issues, in particular with the non-substitutable texlive = package being used as a native input to build documentation. >=20 >=20 > just to clarify, texlive (or more precisely, texlivetexmf) is marked as > non substitutable not because it would not be allowed, but because it is > huge and essentially just an unpacked big tarball. So people had better > build the package by themselves. >=20 > And it should not be used as a (native-)input to other packages: We have > the much smaller modular texlive packages for this, which make it > possible to depend precisely on what is needed to build the > documentation. >=20 > Andreas
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 10 Feb 2025 15:45:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 10 10:45:21 2025 Received: from localhost ([127.0.0.1]:52029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thVyK-00073m-Qq for submit <at> debbugs.gnu.org; Mon, 10 Feb 2025 10:45:21 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]:46844) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1thVyI-00073a-QV for 55231 <at> debbugs.gnu.org; Mon, 10 Feb 2025 10:45:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=dyQU1evl2XAd7HS DoM4lFNgsr3kpXXHnPO+Fv/X8ghw=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=ZGhph7wkluoQLgERxrAabgFbX1HB5CcZXvuqq4Ld zB6wAncc3oAVNlEmvr1nR+CZ6uUmidmb+N5twN/oCCieHjO+AR172+VfPdj69LX8OO89K0 NxWun5T8ABWfUdVJFWoBte2S42O2PhFtJHIfxKaXMkrYTWhLRMVbIUfP5Hmx4= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 8c98470f (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Mon, 10 Feb 2025 15:45:13 +0000 (UTC) From: Felix Lechner <felix.lechner@HIDDEN> To: Maxime Devos <maximedevos@HIDDEN> Subject: Re: Understanding #:substitutable? and #55231 In-Reply-To: <b7e8b482-4e8d-43ff-a0b6-e7ea62cab0ef@HIDDEN> (Maxime Devos's message of "Sun, 9 Feb 2025 22:49:37 +0100") References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <_vvV6oht3R-W5PqRtwQhRBDb8q-O40J39F7fnTG3JLHVXOujpZdQ4s-G85O27ErbFokl95RtkiUBXlE8pLJVFsnN6-ANPTMGK4Vq0iBUP_I=@protonmail.com> <6af9b9dd-313a-4eb5-92c1-2edc42bed113@HIDDEN> <871pw6x4u2.fsf@HIDDEN> <b7e8b482-4e8d-43ff-a0b6-e7ea62cab0ef@HIDDEN> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Mon, 10 Feb 2025 07:45:13 -0800 Message-ID: <875xlh6bxy.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, "Morgan Arnold via Development of GNU Guix and the GNU System distribution." <guix-devel@HIDDEN>, Kaelyn <kaelyn.alexi@HIDDEN>, John Kehayias <john.kehayias@HIDDEN>, 55231 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Maxime, On Sun, Feb 09 2025, Maxime Devos wrote: > It _is_ on track. I replied to someone making a negative remark about > my behaviour, and defended myself. > If defending oneself is a form of 'off track', then 'off track' is a > good thing to do. > Sometimes, being dismissive, is a perfectly reasonable response. As > long as it's for the right reasons, well-founded, and with evidence. > > Also, the 'dismissiveness to [others with different viewpoint]' is the > other way around (see: previous points). > This is, again, a mischaracterisation > It's not a great place. Every so often I have to defend myself against > false insinuations and sometimes people conveniently ignore previously > mentioned issues. > I wasn't doing any derailing. > Like, if you a going to criticize someone's defense, at least bother > to look up their evidence ... > If the act of defending oneself against an accusation is, > intrinsically, a form of derailing, then derailing sometimes is a good > thing. > > Having to ever so often defend myself, is one of the reasons I avoid > Guix nowadays. This kind of thing happens on technical lists from time to time. It's not good to use perseverance, which is great when solving bugs, to address social issues. Goodwill (or silence) are better for those. Sometimes we just have to laugh at ourselves---and at all the compulsive behavior that makes us human. Be friends, everyone! Peace, Felix P.S. Your last message was in HTML format, so it was hard for me to sort out who replied to whom (and the quotes above may be misattributed).
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 10 Feb 2025 15:13:10 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 10 10:13:09 2025 Received: from localhost ([127.0.0.1]:51924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thVTB-0005Ju-HC for submit <at> debbugs.gnu.org; Mon, 10 Feb 2025 10:13:09 -0500 Received: from coleridge.kublai.com ([2602:f977:800:0:e276:63ff:fe62:3637]:52923 helo=mail.spork.org) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <bjc@HIDDEN>) id 1thVT7-0005Ji-Tq for 55231 <at> debbugs.gnu.org; Mon, 10 Feb 2025 10:13:06 -0500 Received: from lapras (ool-43531f23.dyn.optonline.net [67.83.31.35]) by mail.spork.org (Postfix) with ESMTPSA id 3EE5991FD; Mon, 10 Feb 2025 10:13:04 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1739200384; bh=JDwr74EclmFt0gYIpZLg45hKZ2NFoJu85cnSwsJ89ko=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=kVhXZtNka2TsOrL10+89B3v+PBN+qJV2Z3ZYqrU2GMlq7/4HEW8YiutEqOBZWG9oP w1+qeXLfYpYgfn+cSzMEPjXX3tSrcAFfNEZJx3prUoVzfRuxTNjiuSEhjaH8J4jc4H HyB7J0LC9tRdYnBOe+q4hTr6VmwbCFwuVuQYoONU= From: bjc@HIDDEN To: Maxime Devos <maximedevos@HIDDEN> Subject: Re: Understanding #:substitutable? and #55231 In-Reply-To: <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> (Maxime Devos's message of "Sun, 9 Feb 2025 22:13:51 +0100") References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> Date: Mon, 10 Feb 2025 10:13:03 -0500 Message-ID: <87jz9xde9s.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: "Morgan Arnold via Development of GNU Guix and the GNU System distribution." <guix-devel@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ludovic =?utf-8?Q?Cou?= =?utf-8?Q?rt=C3=A8s?= <ludo@HIDDEN>, 55231 <at> debbugs.gnu.org, Ian Eure <ian@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Maxime Devos <maximedevos@HIDDEN> writes: > The incoherency is the problem. If you want ZFS, and your belief ok > ZFS being legally OK is based on P being true, then it follows you > have > > =C2=A0(a) ensure that P is true/rectify !P situations, > =C2=A0(b) or give up on ZFS > =C2=A0(c) (third alternative) or find another justification and ensure its > preconditions are met. > > Yet, as a group, people that want ZFS in Guix have added ZFS without > (a) and (c). Please refrain from calling me incoherent. This patch was specifically designed to work within the bounds of Guix' restrictions, and has been pointed out, has general use, not just for ZFS even if that was my initial motivation. It was designed to be of general use, which also would allow me my own particular uses. I did not understand your objections over the substitutable flag at the time, and I still don't completely. That's not incoherency, that's because a) this is inherently complicated, and b) =E2=80=98#:substitutable?= =E2=80=99 has arguably broken default behavior and no way to currently fix it. I'm staying out of this otherwise. This patch has been a particular sore point for me and was a major reason I stepped back from Guix. I'm glad others are finding it useful, and I wish them well in getting it integrated, but I don't have it in me anymore to deal with the patch process in this project. -bjc
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 10 Feb 2025 13:42:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 10 08:42:40 2025 Received: from localhost ([127.0.0.1]:49617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thU3c-0000NN-Dq for submit <at> debbugs.gnu.org; Mon, 10 Feb 2025 08:42:40 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:55176) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <andreas@HIDDEN>) id 1thU3W-0000N2-R5 for 55231 <at> debbugs.gnu.org; Mon, 10 Feb 2025 08:42:38 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id E43F9415; Mon, 10 Feb 2025 14:42:28 +0100 (CET) Authentication-Results: hera.aquilenet.fr; none X-Virus-Scanned: Debian amavis at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavis, port 10024) with ESMTP id HANYwifTGNtB; Mon, 10 Feb 2025 14:42:28 +0100 (CET) Received: from jurong (195-36-198-235.abo.bbox.fr [195.36.198.235]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 51D091A5; Mon, 10 Feb 2025 14:42:26 +0100 (CET) Date: Mon, 10 Feb 2025 14:42:24 +0100 From: Andreas Enge <andreas@HIDDEN> To: Morgan Arnold <morgan.arnold@HIDDEN> Subject: Re: Understanding #:substitutable? and #55231 Message-ID: <Z6oCQMYpj2R98syY@jurong> References: <JTtAimnNMICUW-We530BE44G5KpCO2CoYASQY0J4ThyM0PF-Q0HIlIsjt4j1SdsjjPBobI-0iYoARfw5MmWiYoeC6hATg9llGDhWg6Ku4MA=@proton.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <JTtAimnNMICUW-We530BE44G5KpCO2CoYASQY0J4ThyM0PF-Q0HIlIsjt4j1SdsjjPBobI-0iYoARfw5MmWiYoeC6hATg9llGDhWg6Ku4MA=@proton.me> X-Rspamd-Server: hera X-Rspamd-Queue-Id: E43F9415 X-Spamd-Result: default: False [-9.60 / 15.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM(-3.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_SEVEN(0.00)[8]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; SUBJECT_HAS_QUESTION(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[protonmail.com]; TO_DN_SOME(0.00)[]; FREEMAIL_CC(0.00)[gnu.org, telenet.be, protonmail.com, retrospec.tv, debbugs.gnu.org] X-Spamd-Bar: --------- X-Rspamd-Action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, "ludo@HIDDEN" <ludo@HIDDEN>, "maximedevos@HIDDEN" <maximedevos@HIDDEN>, "john.kehayias@HIDDEN" <john.kehayias@HIDDEN>, "kaelyn.alexi@HIDDEN" <kaelyn.alexi@HIDDEN>, "guix-devel@HIDDEN" <guix-devel@HIDDEN>, "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hello, Am Sun, Feb 09, 2025 at 10:42:26PM +0000 schrieb Morgan Arnold via Development of GNU Guix and the GNU System distribution.: > It might be more correct to allow derivations built with non-substitutable native inputs to be substitutable nonetheless. The alternative seems like it could cause issues, in particular with the non-substitutable texlive package being used as a native input to build documentation. just to clarify, texlive (or more precisely, texlivetexmf) is marked as non substitutable not because it would not be allowed, but because it is huge and essentially just an unpacked big tarball. So people had better build the package by themselves. And it should not be used as a (native-)input to other packages: We have the much smaller modular texlive packages for this, which make it possible to depend precisely on what is needed to build the documentation. Andreas
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 10 Feb 2025 10:52:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Feb 10 05:52:13 2025 Received: from localhost ([127.0.0.1]:48493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thROf-0005md-Kp for submit <at> debbugs.gnu.org; Mon, 10 Feb 2025 05:52:13 -0500 Received: from baptiste.telenet-ops.be ([2a02:1800:120:4::f00:13]:41612) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maximedevos@HIDDEN>) id 1thROc-0005mL-U7 for 55231 <at> debbugs.gnu.org; Mon, 10 Feb 2025 05:52:11 -0500 Received: from [IPV6:2a02:1811:8c0e:ef00:d058:b1ee:d400:979b] ([IPv6:2a02:1811:8c0e:ef00:d058:b1ee:d400:979b]) by baptiste.telenet-ops.be with cmsmtp id Bms32E0061ADjLZ01ms31c; Mon, 10 Feb 2025 11:52:04 +0100 Message-ID: <8f429bdd-eab1-45e6-98ca-21235e13ef2f@HIDDEN> Date: Mon, 10 Feb 2025 11:52:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Understanding #:substitutable? and #55231 To: Morgan Arnold <morgan.arnold@HIDDEN>, "guix-devel@HIDDEN" <guix-devel@HIDDEN> References: <JTtAimnNMICUW-We530BE44G5KpCO2CoYASQY0J4ThyM0PF-Q0HIlIsjt4j1SdsjjPBobI-0iYoARfw5MmWiYoeC6hATg9llGDhWg6Ku4MA=@proton.me> Content-Language: en-US From: Maxime Devos <maximedevos@HIDDEN> In-Reply-To: <JTtAimnNMICUW-We530BE44G5KpCO2CoYASQY0J4ThyM0PF-Q0HIlIsjt4j1SdsjjPBobI-0iYoARfw5MmWiYoeC6hATg9llGDhWg6Ku4MA=@proton.me> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r25; t=1739184725; bh=d1bUuZWsTRptuoIb8ygoVHBVFWqG++7cJ7woM78vuvg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding:From; b=lfD2EIghQ4sep0Vw0SoqILBaQW+jllsvBuQ5/Zq8XdSrb/DvvUtSE9URGSO9IuzTq Bq9hIgIu1mcV0y3yVACpe0o2CJJDkrqkKcoU5V47crLgC47MpD5k2iydPSRX3vVGmv Cpkfyee3BYfPwy9+NnB5cvXZHB1w3+4Mb9Bybvb7WkrU2owMok07/gS1cC+xxdPZPi 182e9MnGarwpAawxg2zRoJtQJSCiFaC4fy37qi+xpFHkc6xDMy/ahVKDeYlx0xNbl2 oMuTBqHLjyYC3icoCXJ1Pj5Yqy6tDg4zGuLyRS/XqMMsrSqAwW456/ZbWeBex6eoKs 70dGxAQFPQe6Q== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55231 Cc: "john.kehayias@HIDDEN" <john.kehayias@HIDDEN>, "ludo@HIDDEN" <ludo@HIDDEN>, "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org>, "kaelyn.alexi@HIDDEN" <kaelyn.alexi@HIDDEN>, Ian Eure <ian@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 9/02/2025 23:42, Morgan Arnold wrote: > Hi all, > > As a bit of an aside, I'm wondering if it wouldn't be possible to eliminate the possibility of even potential copyviols by a change to the `derivation` function? It currently sets environment variable for the builder daemon by setting `allowSubstitutes = 0` if `(not substitutable?)`. If non-substitutability were propagated by doing something like instead setting `allowSubstitutes = 0` if `(not substitutable?)` or if `(not (every substitutable-derivation? inputs))`, wouldn't this suffice to ensure that an initrd which contains non-substitutable inputs is properly marked non-substitutable? [...] This has effectively already been answered. Best regards, Maxime Devos
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 10 Feb 2025 04:28:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 23:28:07 2025 Received: from localhost ([127.0.0.1]:47437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thLOw-0006tD-Pk for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 23:28:06 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]:48760) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1thLOt-0006sy-NB for 55231 <at> debbugs.gnu.org; Sun, 09 Feb 2025 23:28:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=SfnKcCVqYen07wU qiZ/F0t3ArXDHHagdL51T1DccG/0=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=rcra9zY2o2yhncDjj/4VDS9jiLBUZakxHlZh4eor CYsilo/RXbedIb/lP9fO/uzWmId5lFTDUh7I+vvqrTCzqZ8AbU0wJfiYZD+YVtVKvOsjWD G08aokeK10RlNF1NSQblCkz/c1qtJScktOvPWFlLfI9/NOV1eekZDGDXWHuBI= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id c7936edf (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Mon, 10 Feb 2025 04:28:00 +0000 (UTC) From: Felix Lechner <felix.lechner@HIDDEN> To: Leo Famulari <leo@HIDDEN> Subject: Re: [bug#55231] Understanding #:substitutable? and #55231 In-Reply-To: <Z6leT5MPfBTb3Ffq@HIDDEN> (Leo Famulari's message of "Sun, 9 Feb 2025 21:02:55 -0500") References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> <Z6leT5MPfBTb3Ffq@HIDDEN> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Sun, 09 Feb 2025 20:27:59 -0800 Message-ID: <87bjva5sq8.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, "Morgan Arnold via Development of GNU Guix and the GNU System distribution." <guix-devel@HIDDEN>, 55231 <at> debbugs.gnu.org, Maxime Devos via Guix-patches via <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Leo, On Sun, Feb 09 2025, Leo Famulari wrote: > The violation of the licenses would only arise when distributing the > combined work to a 3rd party? That's also my understanding. Cloud images would be a problem, but Guix makes those unnecessary! Please do not rely on this message. I have no legal training. Kind regards Felix
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at submit) by debbugs.gnu.org; 10 Feb 2025 04:28:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 23:28:24 2025 Received: from localhost ([127.0.0.1]:47440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thLPE-0006ti-3w for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 23:28:24 -0500 Received: from lists.gnu.org ([2001:470:142::17]:60414) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <felix.lechner@HIDDEN>) id 1thLPB-0006tT-Gv for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 23:28:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <felix.lechner@HIDDEN>) id 1thLP4-0006Va-9c; Sun, 09 Feb 2025 23:28:14 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from <felix.lechner@HIDDEN>) id 1thLOx-0005rT-0q; Sun, 09 Feb 2025 23:28:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=SfnKcCVqYen07wU qiZ/F0t3ArXDHHagdL51T1DccG/0=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=rcra9zY2o2yhncDjj/4VDS9jiLBUZakxHlZh4eor CYsilo/RXbedIb/lP9fO/uzWmId5lFTDUh7I+vvqrTCzqZ8AbU0wJfiYZD+YVtVKvOsjWD G08aokeK10RlNF1NSQblCkz/c1qtJScktOvPWFlLfI9/NOV1eekZDGDXWHuBI= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id c7936edf (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Mon, 10 Feb 2025 04:28:00 +0000 (UTC) From: Felix Lechner <felix.lechner@HIDDEN> To: Leo Famulari <leo@HIDDEN> Subject: Re: [bug#55231] Understanding #:substitutable? and #55231 In-Reply-To: <Z6leT5MPfBTb3Ffq@HIDDEN> (Leo Famulari's message of "Sun, 9 Feb 2025 21:02:55 -0500") References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> <Z6leT5MPfBTb3Ffq@HIDDEN> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Sun, 09 Feb 2025 20:27:59 -0800 Message-ID: <87bjva5sq8.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=208.82.101.137; envelope-from=felix.lechner@HIDDEN; helo=sail-ipv4.us-core.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Ian Eure <ian@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, "Morgan Arnold via Development of GNU Guix and the GNU System distribution." <guix-devel@HIDDEN>, 55231 <at> debbugs.gnu.org, Maxime Devos via Guix-patches via <guix-patches@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) Hi Leo, On Sun, Feb 09 2025, Leo Famulari wrote: > The violation of the licenses would only arise when distributing the > combined work to a 3rd party? That's also my understanding. Cloud images would be a problem, but Guix makes those unnecessary! Please do not rely on this message. I have no legal training. Kind regards Felix
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 10 Feb 2025 02:03:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 21:03:07 2025 Received: from localhost ([127.0.0.1]:47194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thJ8c-0008LH-SY for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 21:03:07 -0500 Received: from fout-b8-smtp.messagingengine.com ([202.12.124.151]:53243) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <leo@HIDDEN>) id 1thJ8Z-0008KS-OJ for 55231 <at> debbugs.gnu.org; Sun, 09 Feb 2025 21:03:05 -0500 Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.stl.internal (Postfix) with ESMTP id C675E1140146; Sun, 9 Feb 2025 21:02:57 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Sun, 09 Feb 2025 21:02:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mesmtp; t=1739152977; x= 1739239377; bh=ieIEBIeiWE/7q9xElNugDLOrH88adLxHpA7m2/98g50=; b=w pC/9ThhnwVH2VyHVw6vjOYpWe7D0pJeyT9gkouocGcRN+f5O4Y+6mamojNOCs+L2 M7ROqzkH4ZgSS6wtwSiSgxh5IsboU7m/60gKg1vY8xjUZD5dLFogGH4j8hegDNk1 J3cLWOFe+LZnucUvaKuDIbUBcIKROAZlkBfMGXxE0Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1739152977; x=1739239377; bh=ieIEBIeiWE/7q9xElNugDLOrH88adLxHpA7 m2/98g50=; b=PsbEt34FUTDl6D1VSa4Hf1DJsYnXE9NU9dlnOgbVHxCl4NeFlRw nPRXw3aIKqwWztkohchSRdaNVG8gV96DmsnlIrnOt4cGDA8TTgXecKswComdbIVo ck63Du3ijNMso0DpKkmEXBJM4gVgvUUZnCk/Uigv7rVuLFikBCojWKgeM7sj+YXJ VmKB4W0oZOsefBoInyxCBnaIF0Trh8jf0IBjz10QCzni35POj9u9EykNJenggxhz WWkkDBMknzV3sg5Gg2Xl2Jdi+jfTD5Co5BkO97LLvMyX5guRUzN8Ydj9P0rq38tN +DdxT2kR7MQMkP+9ewdI5Du8B7N3ElFDrYw== X-ME-Sender: <xms:UV6pZ5RC41AIUm7mGxDyzb4RuQmbZ3UmlbgXc4LxipN-n9J1pTXfbg> <xme:UV6pZyxt-p5hGqQ7Q5zuz64nPDEjxaF9XJeqzbz2BTMmIQ-Ns_nZprSg3Q-bW-GAR 9acKr_RG1xrPXrbyw> X-ME-Received: <xmr:UV6pZ-1bpnIYh-Nf2KdM0OnvKn9oW65uWNCRrxIGh_w4ks6OkO0wyUnBsOFnXKxNfplqxAexkWnmPqHOrBt25CgR> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdefieejlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddv necuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnh grmhgvqeenucggtffrrghtthgvrhhnpeefuddvfeffvdfftedufeeiheethfejgeevteet udekvdekudegvedtudetueffheenucffohhmrghinhepghhnuhdrohhrghdpohhpvghnsh houhhrtggvrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvgdpnhgspghrtghpthhtohepie dpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepghhuihigqdhprghttghhvghssehg nhhurdhorhhgpdhrtghpthhtohepihgrnhesrhgvthhrohhsphgvtgdrthhvpdhrtghpth htohepghhuihigqdguvghvvghlsehgnhhurdhorhhgpdhrtghpthhtohepmhhorhhgrghn rdgrrhhnohhlugesphhrohhtohhnrdhmvgdprhgtphhtthhopehluhguohesghhnuhdroh hrghdprhgtphhtthhopeehhedvfeduseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: <xmx:UV6pZxB-y9B-FKs85yQx7vmXYH6ps_XhwswqbyrGMTpLs3xgMiaTVQ> <xmx:UV6pZyjR6gx_e3IpHFiZ4jTPbk2hWkiw0x3_sKDzlIZ1O4cb-JW4Qg> <xmx:UV6pZ1qaq3mE-wndcpDEPY13t1dN1cZE-68y2BUYQMmbcikXa0KmGA> <xmx:UV6pZ9glU8Rl29rCLZW8hDFZ7eWXoyWQW3mML9C0BKJG9sjwwWpIzg> <xmx:UV6pZ9V0tqY37mvgMLRJ24WUss8tZRWfAdM8bXl7mq3wP7khvu4sMjLK> Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 9 Feb 2025 21:02:56 -0500 (EST) Date: Sun, 9 Feb 2025 21:02:55 -0500 From: Leo Famulari <leo@HIDDEN> To: Maxime Devos via Guix-patches via <guix-patches@HIDDEN> Subject: Re: [bug#55231] Understanding #:substitutable? and #55231 Message-ID: <Z6leT5MPfBTb3Ffq@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55231 Cc: "Morgan Arnold via Development of GNU Guix and the GNU System distribution." <guix-devel@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@HIDDEN>, 55231 <at> debbugs.gnu.org, Ian Eure <ian@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On Sun, Feb 09, 2025 at 10:13:51PM +0100, Maxime Devos via Guix-patches via wrote: > And while documenting "The default configuration of adding X (ZFS) to your Y > (operating-system kernel-modules) might be illegal, so also modify the > initrd to mark it as non-substitutable" is worth _something_, it's much > better to just automatically mark the initrd as non-substitutable, as this > is an easy pitfall and entirely automatable. I want to try to clarify my understanding of something. My impression is that the problem would be distribution of the combination of Linux and ZFS, as the GPL and CDDL both limit distribution, not use: For the GPL2: "Activities other than copying, distribution and modification are not covered by this License; they are outside its scope." https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html And the CDDL 1.0: "3.1. Availability of Source Code. Any Covered Software that You distribute or otherwise make available in Executable form must also be made available in Source Code form and that Source Code form must be distributed only under the terms of this License." https://opensource.org/license/CDDL-1.0 So, It would never be "illegal" to add ZFS to my operating-system kernel-modules, right? The violation of the licenses would only arise when distributing the combined work to a 3rd party? My apologies if this has already been discussed, but it stuck out to me.
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at submit) by debbugs.gnu.org; 10 Feb 2025 02:03:16 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 21:03:16 2025 Received: from localhost ([127.0.0.1]:47198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thJ8m-0008Li-9l for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 21:03:16 -0500 Received: from lists.gnu.org ([2001:470:142::17]:46782) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <leo@HIDDEN>) id 1thJ8j-0008LP-FF for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 21:03:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1thJ8b-0003jJ-Cp; Sun, 09 Feb 2025 21:03:06 -0500 Received: from fout-b8-smtp.messagingengine.com ([202.12.124.151]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1thJ8Y-0001ex-In; Sun, 09 Feb 2025 21:03:04 -0500 Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.stl.internal (Postfix) with ESMTP id C675E1140146; Sun, 9 Feb 2025 21:02:57 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Sun, 09 Feb 2025 21:02:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=mesmtp; t=1739152977; x= 1739239377; bh=ieIEBIeiWE/7q9xElNugDLOrH88adLxHpA7m2/98g50=; b=w pC/9ThhnwVH2VyHVw6vjOYpWe7D0pJeyT9gkouocGcRN+f5O4Y+6mamojNOCs+L2 M7ROqzkH4ZgSS6wtwSiSgxh5IsboU7m/60gKg1vY8xjUZD5dLFogGH4j8hegDNk1 J3cLWOFe+LZnucUvaKuDIbUBcIKROAZlkBfMGXxE0Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1739152977; x=1739239377; bh=ieIEBIeiWE/7q9xElNugDLOrH88adLxHpA7 m2/98g50=; b=PsbEt34FUTDl6D1VSa4Hf1DJsYnXE9NU9dlnOgbVHxCl4NeFlRw nPRXw3aIKqwWztkohchSRdaNVG8gV96DmsnlIrnOt4cGDA8TTgXecKswComdbIVo ck63Du3ijNMso0DpKkmEXBJM4gVgvUUZnCk/Uigv7rVuLFikBCojWKgeM7sj+YXJ VmKB4W0oZOsefBoInyxCBnaIF0Trh8jf0IBjz10QCzni35POj9u9EykNJenggxhz WWkkDBMknzV3sg5Gg2Xl2Jdi+jfTD5Co5BkO97LLvMyX5guRUzN8Ydj9P0rq38tN +DdxT2kR7MQMkP+9ewdI5Du8B7N3ElFDrYw== X-ME-Sender: <xms:UV6pZ5RC41AIUm7mGxDyzb4RuQmbZ3UmlbgXc4LxipN-n9J1pTXfbg> <xme:UV6pZyxt-p5hGqQ7Q5zuz64nPDEjxaF9XJeqzbz2BTMmIQ-Ns_nZprSg3Q-bW-GAR 9acKr_RG1xrPXrbyw> X-ME-Received: <xmr:UV6pZ-1bpnIYh-Nf2KdM0OnvKn9oW65uWNCRrxIGh_w4ks6OkO0wyUnBsOFnXKxNfplqxAexkWnmPqHOrBt25CgR> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdefieejlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddv necuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnh grmhgvqeenucggtffrrghtthgvrhhnpeefuddvfeffvdfftedufeeiheethfejgeevteet udekvdekudegvedtudetueffheenucffohhmrghinhepghhnuhdrohhrghdpohhpvghnsh houhhrtggvrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvgdpnhgspghrtghpthhtohepie dpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepghhuihigqdhprghttghhvghssehg nhhurdhorhhgpdhrtghpthhtohepihgrnhesrhgvthhrohhsphgvtgdrthhvpdhrtghpth htohepghhuihigqdguvghvvghlsehgnhhurdhorhhgpdhrtghpthhtohepmhhorhhgrghn rdgrrhhnohhlugesphhrohhtohhnrdhmvgdprhgtphhtthhopehluhguohesghhnuhdroh hrghdprhgtphhtthhopeehhedvfeduseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: <xmx:UV6pZxB-y9B-FKs85yQx7vmXYH6ps_XhwswqbyrGMTpLs3xgMiaTVQ> <xmx:UV6pZyjR6gx_e3IpHFiZ4jTPbk2hWkiw0x3_sKDzlIZ1O4cb-JW4Qg> <xmx:UV6pZ1qaq3mE-wndcpDEPY13t1dN1cZE-68y2BUYQMmbcikXa0KmGA> <xmx:UV6pZ9glU8Rl29rCLZW8hDFZ7eWXoyWQW3mML9C0BKJG9sjwwWpIzg> <xmx:UV6pZ9V0tqY37mvgMLRJ24WUss8tZRWfAdM8bXl7mq3wP7khvu4sMjLK> Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 9 Feb 2025 21:02:56 -0500 (EST) Date: Sun, 9 Feb 2025 21:02:55 -0500 From: Leo Famulari <leo@HIDDEN> To: Maxime Devos via Guix-patches via <guix-patches@HIDDEN> Subject: Re: [bug#55231] Understanding #:substitutable? and #55231 Message-ID: <Z6leT5MPfBTb3Ffq@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> Received-SPF: pass client-ip=202.12.124.151; envelope-from=leo@HIDDEN; helo=fout-b8-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: "Morgan Arnold via Development of GNU Guix and the GNU System distribution." <guix-devel@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@HIDDEN>, 55231 <at> debbugs.gnu.org, Ian Eure <ian@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.1 (/) On Sun, Feb 09, 2025 at 10:13:51PM +0100, Maxime Devos via Guix-patches via wrote: > And while documenting "The default configuration of adding X (ZFS) to your Y > (operating-system kernel-modules) might be illegal, so also modify the > initrd to mark it as non-substitutable" is worth _something_, it's much > better to just automatically mark the initrd as non-substitutable, as this > is an easy pitfall and entirely automatable. I want to try to clarify my understanding of something. My impression is that the problem would be distribution of the combination of Linux and ZFS, as the GPL and CDDL both limit distribution, not use: For the GPL2: "Activities other than copying, distribution and modification are not covered by this License; they are outside its scope." https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html And the CDDL 1.0: "3.1. Availability of Source Code. Any Covered Software that You distribute or otherwise make available in Executable form must also be made available in Source Code form and that Source Code form must be distributed only under the terms of this License." https://opensource.org/license/CDDL-1.0 So, It would never be "illegal" to add ZFS to my operating-system kernel-modules, right? The violation of the licenses would only arise when distributing the combined work to a 3rd party? My apologies if this has already been discussed, but it stuck out to me.
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 9 Feb 2025 22:42:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 17:42:43 2025 Received: from localhost ([127.0.0.1]:46799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thG0h-0004IG-G2 for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 17:42:43 -0500 Received: from mail-10629.protonmail.ch ([79.135.106.29]:44351) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>) id 1thG0e-0004Hz-Rs for 55231 <at> debbugs.gnu.org; Sun, 09 Feb 2025 17:42:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1739140954; x=1739400154; bh=URYGTwdPeMeoW4AmD11qIcyeM7tsA00NSAu35xVb+00=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector: List-Unsubscribe:List-Unsubscribe-Post; b=mjw5oUWobyYQKFbUOhj/P8jpDbKGABngX5iRojzR0jgxk0bMjNwXW4lmHwMQDhttT NO9iDhof3k3d8cEZzxGoevUAklMFONeMUV63bQ7LMoNRP5m2hCy0hLqIQk2uCflVBN 4ggjSX9bM+KFY8aI1Ap7Z95qXMR1S8OKWn3QlD3CDsL42v/Tze04KExAeM3sAHqgN/ Y8mlEXNHav+ZCMVET9aY/KhYRNQXo3PjEuMVL7YG6As4VYoOfqSVf7kBv5DBtU+OiP E4lYGS67I2GqyvEKK+EP2SfKoY9EUFyb+44MeM3xtmAQKSgjLsQvOC5iz0Yk3MpxCp HIZZ0075E9pFA== Date: Sun, 09 Feb 2025 22:42:26 +0000 To: "guix-devel@HIDDEN" <guix-devel@HIDDEN> From: Morgan Arnold <morgan.arnold@HIDDEN> Subject: Re: Understanding #:substitutable? and #55231 Message-ID: <JTtAimnNMICUW-We530BE44G5KpCO2CoYASQY0J4ThyM0PF-Q0HIlIsjt4j1SdsjjPBobI-0iYoARfw5MmWiYoeC6hATg9llGDhWg6Ku4MA=@proton.me> Feedback-ID: 45510636:user:proton X-Pm-Message-ID: 2cf49a0255e23365d6f99de207ff111b4562ca9f MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, "ludo@HIDDEN" <ludo@HIDDEN>, "maximedevos@HIDDEN" <maximedevos@HIDDEN>, "kaelyn.alexi@HIDDEN" <kaelyn.alexi@HIDDEN>, "john.kehayias@HIDDEN" <john.kehayias@HIDDEN>, "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.0 (--) Hi all, As a bit of an aside, I'm wondering if it wouldn't be possible to eliminate= the possibility of even potential copyviols by a change to the `derivation= ` function? It currently sets environment variable for the builder daemon b= y setting `allowSubstitutes =3D 0` if `(not substitutable?)`. If non-substi= tutability were propagated by doing something like instead setting `allowSu= bstitutes =3D 0` if `(not substitutable?)` or if `(not (every substitutable= -derivation? inputs))`, wouldn't this suffice to ensure that an initrd whic= h contains non-substitutable inputs is properly marked non-substitutable? It might be more correct to allow derivations built with non-substitutable = native inputs to be substitutable nonetheless. The alternative seems like i= t could cause issues, in particular with the non-substitutable texlive pack= age being used as a native input to build documentation. Best, Morgan
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 9 Feb 2025 21:49:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 16:49:48 2025
Received: from localhost ([127.0.0.1]:46723 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1thFBU-0001nZ-4Q
for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 16:49:48 -0500
Received: from andre.telenet-ops.be ([2a02:1800:120:4::f00:15]:38398)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <maximedevos@HIDDEN>)
id 1thFBR-0001nI-9r
for 55231 <at> debbugs.gnu.org; Sun, 09 Feb 2025 16:49:46 -0500
Received: from [IPV6:2a02:1811:8c0e:ef00:d058:b1ee:d400:979b]
([IPv6:2a02:1811:8c0e:ef00:d058:b1ee:d400:979b])
by andre.telenet-ops.be with cmsmtp
id BZpe2E0031ADjLZ01ZpekK; Sun, 09 Feb 2025 22:49:39 +0100
Content-Type: multipart/alternative;
boundary="------------WXJZBW9MekD9PwbGaOza9geZ"
Message-ID: <b7e8b482-4e8d-43ff-a0b6-e7ea62cab0ef@HIDDEN>
Date: Sun, 9 Feb 2025 22:49:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Understanding #:substitutable? and #55231
To: John Kehayias <john.kehayias@HIDDEN>
References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me>
<87a5awylhy.fsf@HIDDEN>
<58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN>
<_vvV6oht3R-W5PqRtwQhRBDb8q-O40J39F7fnTG3JLHVXOujpZdQ4s-G85O27ErbFokl95RtkiUBXlE8pLJVFsnN6-ANPTMGK4Vq0iBUP_I=@protonmail.com>
<6af9b9dd-313a-4eb5-92c1-2edc42bed113@HIDDEN>
<871pw6x4u2.fsf@HIDDEN>
Content-Language: en-US
From: Maxime Devos <maximedevos@HIDDEN>
In-Reply-To: <871pw6x4u2.fsf@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r25;
t=1739137779; bh=D9EpVTu4qxHc6t2csJ+ICj0L5/FVULVcwHTxdHNbLqY=;
h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:Cc:
References:From:In-Reply-To:From;
b=hewamzAdSN9XacquyT6cmeXpypvQaXSrR27hGv6bQuZCDEDaByd4m7P6KsU3vjepM
LjrNF94EC30jHHTo/8SPXgAigaE/yXDSmZWCD+qqsLqAxomVzXiWYJ/THHrIWtsifp
d/7K80UjlTLtb5yb7TgH231CB+yXdUW0H4FEq6pJ3Gdj3x7Cx2tLPXlIi3V4fU02Nm
XXn/LCNxvqienPlux7bqLkcPm54GlTk3ZKx/WXJqYo+v6MuJPsiH6dougIi+BeiF3d
IyeIVOybW30w80g7FgAWflW6o/23tSpG3Np+SOAVGscKmUsl8WKniBsMwjVrSdJwkV
E6amWaI1HlYfg==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 55231
Cc: Ian Eure <ian@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>,
=?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>,
Kaelyn <kaelyn.alexi@HIDDEN>,
"Morgan Arnold via Development of GNU Guix and the GNU System distribution."
<guix-devel@HIDDEN>, 55231 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
This is a multi-part message in MIME format.
--------------WXJZBW9MekD9PwbGaOza9geZ
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
On 9/02/2025 21:04, John Kehayias wrote:
> Hi Maxime and everyone,
>
> (As a I hope neutral bystander that knows nothing about nor has any
> particular opinions about the ZFS topic but felt it necessary for
> general "good Guix community" to chime in.)
>
> I understand tone and all of that is difficult in these communications,
> and we all have differing language familiarity/interpretations. And we
> can all have strong opinions. I give everyone the benefit of the doubt
> here, but I do want to (very politely I hope) course correct for this to
> stay a good environment for all to discuss.
>
> On Sun, Feb 09, 2025 at 08:46 PM, Maxime Devos wrote:
>
> [snip]
>
>> * their slander(*) (see: Mason Loring Bliss) (also, to a much lesser
>> extent, right now you - I don't think this quoting out
>> context+misinterpretation _technically_ counts as slander, but it's
>> something bad nonetheless)
> This is not productive to say the least. Let's please all refrain from
> such escalation. Certainly point out when you disagree or ask for
> evidence in discussions, but this is taking us off track.
It _is_ on track. I replied to someone making a negative remark about my
behaviour, and defended myself.
If defending oneself is a form of 'off track', then 'off track' is a
good thing to do.
>> * their rudeness (see: raid5atemyhomework) (also Mason Loring Bliss,
>> since slander is rude)
>> * their hypocrisy as a group (see: they claim it can be fine because
>> of non-binary distribution, but they never change Guix to _make_ the ZFS
>> stuff non-binary)
>> * repeating _old_ information as an argument/counter-argument, even
>> though it has already been made and replied to, without providing more
>> explanation or another interpretation (see: Mason Loring Bliss. Maybe
>> others, but in particular I recall Mason Loring Bliss doing this).
>>
>> (*) In ordinary sense, without distinguishing between exact forms of
>> defamation, and not evaluating whether illegal or legal.
> Also, please be mindful that these are different people in the current
> thread. Many of the people from the older ZFS threads don't seem to be
> active on Guix, at least publicly. In any event, please be aware this is
> a wide group on guix-devel with many opinions. Let's keep from
> generalizations as much as possible.
Please be aware that I mentioned in the parentheses who.
Do note, that I didn't mention other people from the ZFS discussion.
>> Sometimes, being dismissive, is a perfectly reasonable response. As long
>> as it's for the right reasons, well-founded, and with evidence.
>>
>> Also, the 'dismissiveness to [others with different viewpoint]' is the
>> other way around (see: previous points).
>>
> If one feels that they are saying the same things and it is not going
> anywhere new, I would encourage them to simply let the discussion
> continue without them for others that may be finding this useful and
> productive towards a path forward. Previous objections have been noted
> and are available in this thread and previous issue discussions.
This is, again, a mischaracterisation. Just, like, look at the ZFS
discussion, and in particular my response to Mason Loring Bliss' slander.
And there, I did let the discussion continue, and we did talk about new
things (except Mason Loring Bliss, who suddenly jumped in with slander,
and as basis mentioned old arguments ... in the form of a link, that has
been discussed already, without further interpretation). It's not an
exact fit, but if there's anything you need to give this advice to, it's
them, not me.
> I hope guix-devel will continue to be a great place to discuss all
> things Guix, whether in strong agreement, disagreement, or anywhere in
> between. Tough discussions are welcome, but please keep this from
> derailing further.
It's not a great place. Every so often I have to defend myself against
false insinuations and sometimes people conveniently ignore previously
mentioned issues.
I wasn't doing any derailing. It was:
* (for old stuff) Mason Loring Bliss (and sort-of raid5atemyhomework,
but derailing isn't quite the right word there since they started with
the metaphorical rails) (maybe others, but those I recall in particular)
* (recently) you and Morgan Arnold with false insinuations
Like, if you a going to criticize someone's defense, at least bother to
look up their evidence ... (the posts by Mason Loring Bliss and
raid5atemyhomework are easy to find and speak for theirselves).
If the act of defending oneself against an accusation is, intrinsically,
a form of derailing, then derailing sometimes is a good thing.
Having to ever so often defend myself, is one of the reasons I avoid
Guix nowadays.
With all due respect,
Maxime Devos
--------------WXJZBW9MekD9PwbGaOza9geZ
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 9/02/2025 21:04, John Kehayias
wrote:<br>
</div>
<blockquote type="cite" cite="mid:871pw6x4u2.fsf@HIDDEN">
<pre wrap="" class="moz-quote-pre">Hi Maxime and everyone,
(As a I hope neutral bystander that knows nothing about nor has any
particular opinions about the ZFS topic but felt it necessary for
general "good Guix community" to chime in.)
I understand tone and all of that is difficult in these communications,
and we all have differing language familiarity/interpretations. And we
can all have strong opinions. I give everyone the benefit of the doubt
here, but I do want to (very politely I hope) course correct for this to
stay a good environment for all to discuss.
On Sun, Feb 09, 2025 at 08:46 PM, Maxime Devos wrote:
[snip]
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre"> * their slander(*) (see: Mason Loring Bliss) (also, to a much lesser
extent, right now you - I don't think this quoting out
context+misinterpretation _technically_ counts as slander, but it's
something bad nonetheless)
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
This is not productive to say the least. Let's please all refrain from
such escalation. Certainly point out when you disagree or ask for
evidence in discussions, but this is taking us off track.</pre>
</blockquote>
<p>It _is_ on track. I replied to someone making a negative remark
about my behaviour, and defended myself.<span
style="white-space: pre-wrap">
</span></p>
<p><span style="white-space: pre-wrap">If defending oneself is a form of 'off track', then 'off track' is a good thing to do.
</span></p>
<blockquote type="cite" cite="mid:871pw6x4u2.fsf@HIDDEN">
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre"> * their rudeness (see: raid5atemyhomework) (also Mason Loring Bliss,
since slander is rude)
* their hypocrisy as a group (see: they claim it can be fine because
of non-binary distribution, but they never change Guix to _make_ the ZFS
stuff non-binary)
* repeating _old_ information as an argument/counter-argument, even
though it has already been made and replied to, without providing more
explanation or another interpretation (see: Mason Loring Bliss. Maybe
others, but in particular I recall Mason Loring Bliss doing this).
(*) In ordinary sense, without distinguishing between exact forms of
defamation, and not evaluating whether illegal or legal.
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
Also, please be mindful that these are different people in the current
thread. Many of the people from the older ZFS threads don't seem to be
active on Guix, at least publicly. In any event, please be aware this is
a wide group on guix-devel with many opinions. Let's keep from
generalizations as much as possible.</pre>
</blockquote>
<p>Please be aware that I mentioned in the parentheses who.</p>
<p>Do note, that I didn't mention other people from the ZFS
discussion.<span style="white-space: pre-wrap">
</span></p>
<blockquote type="cite" cite="mid:871pw6x4u2.fsf@HIDDEN">
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">Sometimes, being dismissive, is a perfectly reasonable response. As long
as it's for the right reasons, well-founded, and with evidence.
Also, the 'dismissiveness to [others with different viewpoint]' is the
other way around (see: previous points).
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
If one feels that they are saying the same things and it is not going
anywhere new, I would encourage them to simply let the discussion
continue without them for others that may be finding this useful and
productive towards a path forward. Previous objections have been noted
and are available in this thread and previous issue discussions.</pre>
</blockquote>
<p><span style="white-space: pre-wrap">This is, again, a mischaracterisation. Just, like, look at the ZFS discussion, and in particular my response to Mason Loring Bliss' slander.</span></p>
<p><span style="white-space: pre-wrap">And there, I did let the discussion continue, and we did talk about new things (except Mason Loring Bliss, who suddenly jumped in with slander, and as basis mentioned old arguments ... in the form of a link, that has been discussed already, without further interpretation). It's not an exact fit, but if there's anything you need to give this advice to, it's them, not me.</span></p>
<p><span style="white-space: pre-wrap">
</span></p>
<blockquote type="cite" cite="mid:871pw6x4u2.fsf@HIDDEN">
<pre wrap="" class="moz-quote-pre">I hope guix-devel will continue to be a great place to discuss all
things Guix, whether in strong agreement, disagreement, or anywhere in
between. Tough discussions are welcome, but please keep this from
derailing further.</pre>
</blockquote>
<p>It's not a great place. Every so often I have to defend myself
against false insinuations and sometimes people conveniently
ignore previously mentioned issues.<br>
</p>
<p>I wasn't doing any derailing. It was:</p>
<p>* (for old stuff) Mason Loring Bliss (and sort-of
raid5atemyhomework, but derailing isn't quite the right word there
since they started with the metaphorical rails) (maybe others, but
those I recall in particular)<br>
* (recently) you and Morgan Arnold with false insinuations</p>
<p>Like, if you a going to criticize someone's defense, at least
bother to look up their evidence ... (the posts by Mason Loring
Bliss and raid5atemyhomework are easy to find and speak for
theirselves).<br>
</p>
<p>If the act of defending oneself against an accusation is,
intrinsically, a form of derailing, then derailing sometimes is a
good thing.<span style="white-space: pre-wrap">
</span></p>
<p><span style="white-space: pre-wrap">Having to ever so often defend myself, is one of the reasons I avoid Guix nowadays.
</span></p>
With all due respect,<br>
Maxime Devos<br>
</body>
</html>
--------------WXJZBW9MekD9PwbGaOza9geZ--
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 9 Feb 2025 21:14:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 16:14:02 2025 Received: from localhost ([127.0.0.1]:46667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thEcr-00007a-BH for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 16:14:02 -0500 Received: from baptiste.telenet-ops.be ([2a02:1800:120:4::f00:13]:38834) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maximedevos@HIDDEN>) id 1thEco-00007K-PK for 55231 <at> debbugs.gnu.org; Sun, 09 Feb 2025 16:13:59 -0500 Received: from [IPV6:2a02:1811:8c0e:ef00:d058:b1ee:d400:979b] ([IPv6:2a02:1811:8c0e:ef00:d058:b1ee:d400:979b]) by baptiste.telenet-ops.be with cmsmtp id BZDr2E00P1ADjLZ01ZDr3v; Sun, 09 Feb 2025 22:13:52 +0100 Message-ID: <50767bf1-572c-4d62-8839-eb085a105783@HIDDEN> Date: Sun, 9 Feb 2025 22:13:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Understanding #:substitutable? and #55231 To: Ian Eure <ian@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> Content-Language: en-US From: Maxime Devos <maximedevos@HIDDEN> In-Reply-To: <87wmdyx63a.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r25; t=1739135632; bh=jSML76fVJ/WAFL9lKteIHaTBCItHLlTVliSbeNaEJRY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding:From; b=YIG3ASRdaeOsXEnGibFcWxv0ogwBNqgaH5fyunk58eFiFruDEan7Q5jbvn7Ur9Y3W oilcOzUvpjGdhme+SfZFJZcwRLdrffU/Rd9VU+jqjyKdfSyK/Q9B02kU2y2/26JQ6Y DrY91qnJr3Kkub4fnMtUO0mNDRHzrbixerweGj24rHXGtAQPStGkfUGdnhR43y1/IS b1o6Po3T9IKn7evj2mBudwU7mu5EOiWrEwIVJmNcwQzVny14pJQiUJ6Zxq3DIs7pA9 gTq0p2kYqkX6NSVJY5+jE5R627Ooqa+tztKk3ercdX8PoqJKUQZ29/rHRMUD3ismo9 Dhxu95LLhd80A== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55231 Cc: "Morgan Arnold via Development of GNU Guix and the GNU System distribution." <guix-devel@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, =?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>, 55231 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 9/02/2025 20:37, Ian Eure wrote: > Hi Maxime, > > Maxime Devos <maximedevos@HIDDEN> writes: > >> On 9/02/2025 2:06, Ian Eure wrote: >> >>> Hi Morgan, >>> >>> Morgan Arnold via "Development of GNU Guix and the GNU System >>> distribution." <guix-devel@HIDDEN> writes: >>> >>>> Hello, >>>> >>>> If the issue is simply that the patch has not been rebased against a >>>> new enough version of Guix to be merged, I am happy to do that >>>> rebasing. Additionally, please correct me if I have made any incorrect >>>> assertions above. >> >> No. See the stuff about #:substitutable?. The reason I didn't answer >> back then, is that I don't want to keep being a broken record. > > Could you help me understand the case where this becomes a problem? > Is it: > > - If you have one machine with an operating-system which includes a > non-#:substitutable? out-of-tree kernel module in its initrd, and > - A second machine with an identical initrd configuration, and > - The first machine is configured to serve substitutes, and > - The second machine uses the first as a substitute server > > Then the non-#:substitutable? module would be distributed, violating > its license? Yes (assuming typical ZFS+GPL compatibility argument) (and assuming the two machines are by different people - if it's by the same person, I imagine it may simplify the legalities). Well, it wouldn't be distributed as the module itself, as it's embedded in the initrd. But the initrd is substitutable, so the initrd is distributed. > I’d also find it helpful to understand the line for specific acts and > entities in play, on a matrix of: allowing violations, encouraging > violations, or committing violations; and by individual Guix users, or > by the Guix project itself. For example, I think the Guix project > encouraging or committing a violation is unacceptable. > > I think this would help a great deal to make the bounds of the problem > clear, which is needed to solve them. I'd say: Allowing violations by the Guix project: pretty much never. (Like, _maybe_ in some cases it can be determined it's a dead law not worth following in jurisdiction X at time [T,T+?), but then this needs to be repeated for all the jurisdictions, and may need to be reevaluated often, now consider that most of us probably aren't lawyers, let alone in a sufficient number of jurisdictions, and that there may be disagreements, and that evaluating the situation takes time+effort ... Doesn't seem worthwhile.) Encouraging violations: never. (Encouraging law breaking seems illegal.) Allowing violations - depends, we're not going to install spyware and constantly monitor them or something, so they probably could do things out-of-sight. But "hint hint, don't add activate X (whose purpose is to make Y), or the illegal substance Y will result" (**) doesn't seem like something to have in Guix. And while documenting "The default configuration of adding X (ZFS) to your Y (operating-system kernel-modules) might be illegal, so also modify the initrd to mark it as non-substitutable" is worth _something_, it's much better to just automatically mark the initrd as non-substitutable, as this is an easy pitfall and entirely automatable. (**): this is reference to prohibition era in US What I think Guix should (try to) ensure to be the case, is: If users tag their custom stuff (including from channels) that shouldn't be distributed with #:substitutable? #false, and they intentionally change things to violate the law, then users can legally run their substitute servers without worrying about the particulars of their configuration, and without having to look closely at the manual (you _should_ read the manual, but you might not known in advance which parts you should have read, and might easily miss something). If Guix knows that some of this isn't automated in some known situations, then in those known situations it should produce some kind of error message, such that they know they need to resolve the situation in some matter. >> If 'make-linux-libre' in the presence of ZFS leads to #:subsitutable? >> problems, that doesn't mean it's fine to ignore the law for #52231. It >> means you need to: > > Could you please help me understand how `make-linux-libre' is in > scope? I don’t believe any in-tree kernel modules have the > problematic license terms, so I think the issue is purely out-of-tree > stuff, whether that’s ZFS, nVidia drivers, "endpoint protection" > security systems, etc. Perhaps you meant `make-initrd'? I meant 'make-linux-libre'. This is a comment about <https://lists.gnu.org/archive/html/guix-devel/2025-02/msg00061.html>: > If the concern is rather that this change makes it easier for someone to > accidentally redistribute a compiled ZFS kernel module and commit a > copyviol, I > struggle to see how this concern is particular enough to #55231 to be > a reason > not to merge it. It seems to me, at least in principle, that it would > be just > as simple to commit a copyviol by using, say, the `make-linux-libre` > function > (which does not appear to set `#:substitutable? #f` on the resulting > derivation, unsurprisingly) to build a kernel with the ZFS kernel > module built > in, and then redistributing that. It seems like the only way to > completely > remove this possibility would be to make `#:substitutable?` > "poisoning", so to > speak, in the sense that any derivation taking non-substitutable > derivations as > inputs would be marked non-substitutable itself. This seems to entirely > eliminate the possibility of substituting something which is > non-substitutable, > but I have no idea if this is practical or even desirable. > Going the the above, it might be possible to add nominally out-of-tree modules to be compiled from within the tree. Do note that this is an 'if X then Y' construction, I did not claim that 'X' is the case. I do not know whether make-linux-libre supports such a thing. >> More specifically, ZFS proponents (at least as a group, and when >> limited to those visible in Guix) tend to be rather incoherent in >> their positions, in the sense that simultaneously do: >> >> (snip) > > I appreciate your perspective, however, I’m more interested in > understanding the problems so they can be solved. Any help in that > area would be greatly appreciated. The incoherency is the problem. If you want ZFS, and your belief ok ZFS being legally OK is based on P being true, then it follows you have (a) ensure that P is true/rectify !P situations, (b) or give up on ZFS (c) (third alternative) or find another justification and ensure its preconditions are met. Yet, as a group, people that want ZFS in Guix have added ZFS without (a) and (c). >>> It does seem that #55231 ended up in a place where there was >>> concensus that it was acceptable, but didn’t get merged for some >>> reason or other. I definitely could be wrong, but I suspect the >>> issue is that when non-#:substitutable? packages are used in places >>> other than package inputs, the downstream derivations don’t carry >>> that information. I believe when used as a package input, >>> non-#:substitutable? packages do, in fact, poison all downstream >>> derivations. Happy to be corrected if I’m wrong here. >> >> Not quite - to my understanding, the downstream derivations _also_ >> don't carry that information when it's in package inputs (at least, >> last time I checked there didn't seem to be any mechanism to set >> #:substitutable? to #false when any of the inputs are unsubstitutable >> (whether non-bag(?) derivation inputs, implicit inputs, native-inputs, >> ...)). > > Ah, hmm. So these kind of violations are implictly prevented by Guix > not shipping things in combinations which would violate the license > terms? ... no? Guix _does_ ship things in bad combinations(*) (Linux-with-ZFS initrd, by users running a substitute server, in the case that this combination is in their configuration somewhere), without marking that initrd combination as nonsubstitutable (IIRC). (*) actually, I don't recall whether the Linux is part of the initrd, but there also are other similar situations, e.g. system images. Same problem. >>> I think it’s reasonable to merge this after it’s rebased on current >>> master, and would be willing to do that unless Maxime or Ludo’ raise >>> an objection. >> >> First you say you suspect the issue is that #:substitutable?-related >> behaviour isn't right yet, and immediately in the next paragraph you >> say it's reasonable to merge it. Given that the patches haven't been >> adjusted to solve this, this is rather incongruent. > > While I agree that the fundamental #:substitutable? mechanism of Guix > could use improvement, I don’t believe these patches need to wait for > that work, becasue: > > - This is a generic mechanism useful for any out-of-tree module > regardless of license[1]. And one of these out-of-tree modules is ZFS, where it is not useful as-is because of the license. In fact, ZFS support is the purpose of #55231. (Evidence: (1) the example in the manual, (2) Kaeylen mentioning plans for using this for ZFS) > - They won’t cause the Guix project to commit a license violation. > - They don’t encourage individuals to commit license violations. It does encourage them ... see, all the previously mentioned stuff about substitute servers. > - While they could /allow/ individuals to commit violations, many > things in Guix already do, because it’s infeasible to forbid. It's not, and has never been, a matter of forbidding of allowing users to do something. It's a matter of not leading to user (whether project or individual user) to _accidentally_ perform a violations. And it's entirely feasible to prevent this: see, the stuff about #:substitutable? changes. > To the last point: > > - Right now, Guix allows a user to make a system image containing > compiled ZFS modules and distribute it. s/allows an user to/lets an user accidentally/ This is a problem. This should be resolved this by (a) removing ZFS or (b) modifying the image producer to mark it as non-substitutable. (unlikely option (c): ZFS people adjust license). If people won't do (b) yet, it follows that (a) needs to be done for now. > - Guix ships DVD rippers and programs which can copy files, which a > user can commit copyright violations with. > - Guix ships numerous programs for file sharing, whose /primary/ > purpose is committing copyright violations. The nicotine+ package > is one example[1]. This argument, essentially, is 'X already does the bad thing Y(nicotine+). So, it's fine to do Z (improper ZFS support) as well.'. This really doesn't follow. Like, if I were to burn down a house (illegal), that doesn't make it legal to steal a chair from the house. Also, nowhere did I claim that #55231 purpose is committing copyright violations. > I am struggling to square objections to a patch whose intent and > primary use would be within the bounds of non-binary-redistribution > licenses, but which might enable an individual to (most likely > inadvertently) commit a license violation with the significantly > riskier things which are already permitted. If I’m misunderstanding > the situation here, I’d appreciate further insight. > > Some examples of other modules that could be used with this facility are: > > lttng, a GPL’d out-of-tree kernel tracing system > ddcci, a GPL’d out-of-tree module for controlling monitor settings > OpenRazer, a GPL’d out-of-tree module to suppot Razer HID hardware > > I’m certain there are other cases where it’d be useful. ZFS _is_ the primary use, see previous remarks. Even if it weren't the primary use, it's still a main use, and will likely be advertised as such (if not in Guix proper manual, then likely in outside guides). Even it it weren't, ZFS is nevertheless a Linux kernel module in Guix, and #55231 deals with kernel modules in Guix, so #55231 needs to deal with ZFS. Just because X has good uses Y1 ... Yn (lttng, etc.), doesn't mean it's fine to neglect the currently bad use Y0 (current implementation of #55231 + ZFS support). Best regards, Maxime Devos
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 9 Feb 2025 20:04:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 15:04:41 2025 Received: from localhost ([127.0.0.1]:46485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thDXl-0005Kk-DA for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 15:04:41 -0500 Received: from mail-40131.protonmail.ch ([185.70.40.131]:19113) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <john.kehayias@HIDDEN>) id 1thDXj-0005KS-5L for 55231 <at> debbugs.gnu.org; Sun, 09 Feb 2025 15:04:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1739131472; x=1739390672; bh=ymm9ts37wwUiinlw5qjmxKDe0bBEGcvRpVqEMJpdzLY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=WYmlyto0WCmnGnjAHd2Gh+dv+wSVCJKBZIMjnchzqH1/9H7q0c/S22SxbIlGpIOrA t2fX38LdtE6NClrNmW3usSXXhN/LGRamYWWCLKaPbomGPp9tK+9EnQBAUVjfTlSXUx pl0kxwhrdAvB/s3L2hmRMPWpKwOj8x7MaK7y8jlL/b3zkX5K4MCakK20C+lA8PDZt0 wwyrdgwCkDGpoYg5SnagGB7eRJLbBQhz/yZFpgCQmPs5lVRhLkpQ+d0N+JulU2Od9J 2FPBCYp48gyaRfkPSpwk4sqAXbilexXiHZfK1FjxLRyiDDvgm6f8WdiDkAScAWlxrf 4VHcY8rbppFEQ== Date: Sun, 09 Feb 2025 20:04:27 +0000 To: Maxime Devos <maximedevos@HIDDEN> From: John Kehayias <john.kehayias@HIDDEN> Subject: Re: Understanding #:substitutable? and #55231 Message-ID: <871pw6x4u2.fsf@HIDDEN> In-Reply-To: <6af9b9dd-313a-4eb5-92c1-2edc42bed113@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <_vvV6oht3R-W5PqRtwQhRBDb8q-O40J39F7fnTG3JLHVXOujpZdQ4s-G85O27ErbFokl95RtkiUBXlE8pLJVFsnN6-ANPTMGK4Vq0iBUP_I=@protonmail.com> <6af9b9dd-313a-4eb5-92c1-2edc42bed113@HIDDEN> Feedback-ID: 7805494:user:proton X-Pm-Message-ID: bf89d14f4995361583fe04e52024c0a0eb655a3c MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: Ian Eure <ian@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>, Kaelyn <kaelyn.alexi@HIDDEN>, "Morgan Arnold via Development of GNU Guix and the GNU System distribution." <guix-devel@HIDDEN>, 55231 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Maxime and everyone, (As a I hope neutral bystander that knows nothing about nor has any particular opinions about the ZFS topic but felt it necessary for general "good Guix community" to chime in.) I understand tone and all of that is difficult in these communications, and we all have differing language familiarity/interpretations. And we can all have strong opinions. I give everyone the benefit of the doubt here, but I do want to (very politely I hope) course correct for this to stay a good environment for all to discuss. On Sun, Feb 09, 2025 at 08:46 PM, Maxime Devos wrote: [snip] > =C2=A0* their slander(*) (see: Mason Loring Bliss) (also, to a much less= er > extent, right now you - I don't think this quoting out > context+misinterpretation _technically_ counts as slander, but it's > something bad nonetheless) This is not productive to say the least. Let's please all refrain from such escalation. Certainly point out when you disagree or ask for evidence in discussions, but this is taking us off track. > =C2=A0* their rudeness (see: raid5atemyhomework) (also Mason Loring Blis= s, > since slander is rude) > =C2=A0* their hypocrisy as a group (see: they claim it can be fine becau= se > of non-binary distribution, but they never change Guix to _make_ the ZFS > stuff non-binary) > =C2=A0* repeating _old_ information as an argument/counter-argument, eve= n > though it has already been made and replied to, without providing more > explanation or another interpretation (see: Mason Loring Bliss. Maybe > others, but in particular I recall Mason Loring Bliss doing this). > > (*) In ordinary sense, without distinguishing between exact forms of > defamation, and not evaluating whether illegal or legal. Also, please be mindful that these are different people in the current thread. Many of the people from the older ZFS threads don't seem to be active on Guix, at least publicly. In any event, please be aware this is a wide group on guix-devel with many opinions. Let's keep from generalizations as much as possible. > > Sometimes, being dismissive, is a perfectly reasonable response. As long > as it's for the right reasons, well-founded, and with evidence. > > Also, the 'dismissiveness to [others with different viewpoint]' is the > other way around (see: previous points). > If one feels that they are saying the same things and it is not going anywhere new, I would encourage them to simply let the discussion continue without them for others that may be finding this useful and productive towards a path forward. Previous objections have been noted and are available in this thread and previous issue discussions. I hope guix-devel will continue to be a great place to discuss all things Guix, whether in strong agreement, disagreement, or anywhere in between. Tough discussions are welcome, but please keep this from derailing further. Thanks, John
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 9 Feb 2025 20:03:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 15:03:54 2025 Received: from localhost ([127.0.0.1]:46478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thDWz-0005Iz-DB for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 15:03:54 -0500 Received: from mail-10628.protonmail.ch ([79.135.106.28]:31965) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>) id 1thDWv-0005Ii-Am for 55231 <at> debbugs.gnu.org; Sun, 09 Feb 2025 15:03:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=kl4b4ulfxnaj5oc473irr2q5ce.protonmail; t=1739131422; x=1739390622; bh=hGS8lJlT0vYYf4xoy1lRairyCX0dPOp7220ENS96BNI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=dwo8nv33Jqa7h2fzGp1Y5J74djy7pgsxCi/k8tXL3HrMB5ibzpViY+rDdW/3Rv7V5 4YdX2xx8SFUmeJdiG9Su7V6TqbV7Yna52u4wlJEcXLjKyA8EtXWD+iHuSQw6a3q12K Cmu2lCh3jIvBvcxYtsEas/DPQD/rFI73Q5XQcwvh4Ql2sJadeSZoIZ/GUAzIW8PqXh fXkPYtliw0jRpc3ORS/mcZOQ6DeSCcck87jmiCIY+3a9KbIktf0KJinbGw2LiYEcb7 yTS+yrwt3TKFsrnY2/n/PIYKkDhJjwxJkLab/j7+G1d+5Ca+Nl+zL2j42IyKTrKreq qw+cWnipFWZJw== Date: Sun, 09 Feb 2025 20:03:37 +0000 To: Ian Eure <ian@HIDDEN> From: Morgan Arnold <morgan.arnold@HIDDEN> Subject: Re: Understanding #:substitutable? and #55231 Message-ID: <vJ6xu7iGiFRs_Y9H8WamQ688G7KMgD1-ryOdpgMhsii3XCjtVBCmZhYepoCwYL7aMsKZeJX9J3bCLT7KEgpN9u5qX6yOEQZH6SDZuk6SOqo=@proton.me> In-Reply-To: <87wmdyx63a.fsf@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <87wmdyx63a.fsf@HIDDEN> Feedback-ID: 45510636:user:proton X-Pm-Message-ID: 8413b5c432b02c946e25c50e19548a421377c559 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: "guix-devel@HIDDEN" <guix-devel@HIDDEN>, "kaelyn.alexi@HIDDEN" <kaelyn.alexi@HIDDEN>, "ludo@HIDDEN" <ludo@HIDDEN>, "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org>, "maximedevos@HIDDEN" <maximedevos@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi all, > > If 'make-linux-libre' in the presence of ZFS leads to > > #:subsitutable? > > problems, that doesn't mean it's fine to ignore the law for > > #52231. It > > means you need to: > > > Could you please help me understand how `make-linux-libre' is in scope? I= don=E2=80=99t believe any in-tree kernel modules have the problematic lice= nse terms, so I think the issue is purely out-of-tree stuff, whether that= =E2=80=99s ZFS, nVidia drivers, "endpoint protection" security systems, etc= . Perhaps you meant` make-initrd'? I haven't had time to read all of this and go through the legal considerati= ons that Kaelyn linked (thanks!), but just wanted to clarify that I was the= one who brought up `make-linux-libre`, probably erroneously. I think that = I misunderstood `make-linux-libre` as being capable of including out-of-tre= e kernel modules in the kernel, so I proposed that it was subject to the sa= me licensing concerns. This, however, seems to have been a misunderstanding= of `make-linux-libre` on my part. Anyway, Maxime reasonably points out tha= t this is effectively irrelevant to whether or not the changes proposed her= e ought to be included in Guix. > I=E2=80=99d also find it helpful to understand the line for specific acts > and entities in play, on a matrix of: allowing violations, > encouraging violations, or committing violations; and by > individual Guix users, or by the Guix project itself. For > example, I think the Guix project encouraging or committing a > violation is unacceptable. I agree that it would be helpful to clarify the matrix mentioned here, and = that Guix encouraging or committing a violation is unacceptable. I further = agree that Guix allowing violations is inevitable, and I fail to see how th= e proposed changes either encourage a violation (modulo the changes made to= the documentation) or commit a violation. I am very much not a lawyer, so = I may be missing the violation entirely, and am trying to get up to speed o= n some of the legal concerns. Best, Morgan On Sunday, February 9th, 2025 at 20:37, Ian Eure <ian@HIDDEN> wrote: >=20 >=20 > Hi Maxime, >=20 > Maxime Devos maximedevos@HIDDEN writes: >=20 > > On 9/02/2025 2:06, Ian Eure wrote: > >=20 > > > Hi Morgan, > > >=20 > > > Morgan Arnold via "Development of GNU Guix and the GNU System > > > distribution." guix-devel@HIDDEN writes: > > >=20 > > > > Hello, > > > >=20 > > > > If the issue is simply that the patch has not been rebased > > > > against a > > > > new enough version of Guix to be merged, I am happy to do that > > > > rebasing. Additionally, please correct me if I have made any > > > > incorrect > > > > assertions above. > >=20 > > No. See the stuff about #:substitutable?. The reason I didn't > > answer > > back then, is that I don't want to keep being a broken record. >=20 >=20 > Could you help me understand the case where this becomes a > problem? Is it: >=20 > - If you have one machine with an operating-system which includes > a non-#:substitutable? out-of-tree kernel module in its initrd, > and > - A second machine with an identical initrd configuration, and > - The first machine is configured to serve substitutes, and > - The second machine uses the first as a substitute server >=20 > Then the non-#:substitutable? module would be distributed, > violating its license? >=20 > I=E2=80=99d also find it helpful to understand the line for specific acts > and entities in play, on a matrix of: allowing violations, > encouraging violations, or committing violations; and by > individual Guix users, or by the Guix project itself. For > example, I think the Guix project encouraging or committing a > violation is unacceptable. >=20 > I think this would help a great deal to make the bounds of the > problem clear, which is needed to solve them. >=20 > > If 'make-linux-libre' in the presence of ZFS leads to > > #:subsitutable? > > problems, that doesn't mean it's fine to ignore the law for > > #52231. It > > means you need to: >=20 >=20 > Could you please help me understand how `make-linux-libre' is in scope? I= don=E2=80=99t believe any in-tree kernel modules have the problematic lice= nse terms, so I think the issue is purely out-of-tree stuff, whether that= =E2=80=99s ZFS, nVidia drivers, "endpoint protection" security systems, etc= . Perhaps you meant` make-initrd'? >=20 > > More specifically, ZFS proponents (at least as a group, and when > > limited to those visible in Guix) tend to be rather incoherent > > in > > their positions, in the sense that simultaneously do: > >=20 > > (snip) >=20 >=20 > I appreciate your perspective, however, I=E2=80=99m more interested in > understanding the problems so they can be solved. Any help in > that area would be greatly appreciated. >=20 > > > It does seem that #55231 ended up in a place where there was > > > concensus that it was acceptable, but didn=E2=80=99t get merged for > > > some > > > reason or other. I definitely could be wrong, but I suspect > > > the > > > issue is that when non-#:substitutable? packages are used in > > > places > > > other than package inputs, the downstream derivations don=E2=80=99t > > > carry > > > that information. I believe when used as a package input, > > > non-#:substitutable? packages do, in fact, poison all > > > downstream > > > derivations. Happy to be corrected if I=E2=80=99m wrong here. > >=20 > > Not quite - to my understanding, the downstream derivations > > also > > don't carry that information when it's in package inputs (at > > least, > > last time I checked there didn't seem to be any mechanism to set > > #:substitutable? to #false when any of the inputs are > > unsubstitutable > > (whether non-bag(?) derivation inputs, implicit inputs, > > native-inputs, > > ...)). >=20 >=20 > Ah, hmm. So these kind of violations are implictly prevented by > Guix not shipping things in combinations which would violate the > license terms? >=20 > > For packages, in typical situations the #:substitutable? #false > > of any > > 'native-inputs' of a package shouldn't impact the > > substitutability of > > the package. For 'inputs', it rather depends > > (e.g. static/dynamic, the > > particulars of the license, is it because of license reasons or > > something else). Since it somewhat depends on the situation, if > > you > > implement a thing like this, I would recommend making it a > > default > > for #:substitutable?(*), that can be overridden by some method. >=20 >=20 > That=E2=80=99s a good suggestion, thank you. >=20 > > > I think it=E2=80=99s reasonable to merge this after it=E2=80=99s reba= sed on > > > current > > > master, and would be willing to do that unless Maxime or Ludo= =E2=80=99 > > > raise > > > an objection. > >=20 > > First you say you suspect the issue is that > > #:substitutable?-related > > behaviour isn't right yet, and immediately in the next paragraph > > you > > say it's reasonable to merge it. Given that the patches haven't > > been > > adjusted to solve this, this is rather incongruent. >=20 >=20 > While I agree that the fundamental #:substitutable? mechanism of > Guix could use improvement, I don=E2=80=99t believe these patches need to > wait for that work, becasue: >=20 > - This is a generic mechanism useful for any out-of-tree module > regardless of license[1]. > - They won=E2=80=99t cause the Guix project to commit a license violation= . > - They don=E2=80=99t encourage individuals to commit license violations. > - While they could /allow/ individuals to commit violations, many > things in Guix already do, because it=E2=80=99s infeasible to forbid. >=20 > To the last point: >=20 > - Right now, Guix allows a user to make a system image containing > compiled ZFS modules and distribute it. > - Guix ships DVD rippers and programs which can copy files, which > a user can commit copyright violations with. > - Guix ships numerous programs for file sharing, whose /primary/ > purpose is committing copyright violations. The nicotine+ > package is one example[1]. >=20 > I am struggling to square objections to a patch whose intent and > primary use would be within the bounds of > non-binary-redistribution licenses, but which might enable an > individual to (most likely inadvertently) commit a license > violation with the significantly riskier things which are already > permitted. If I=E2=80=99m misunderstanding the situation here, I=E2=80= =99d > appreciate further insight. >=20 > Some examples of other modules that could be used with this > facility are: >=20 > lttng, a GPL=E2=80=99d out-of-tree kernel tracing system > ddcci, a GPL=E2=80=99d out-of-tree module for controlling monitor setting= s > OpenRazer, a GPL=E2=80=99d out-of-tree module to suppot Razer HID hardwar= e >=20 > I=E2=80=99m certain there are other cases where it=E2=80=99d be useful. >=20 > > I already raised the objection several times in the past > > (including > > before #55231), and none of the patch revisions attempted to > > deal > > with the objection. Issues don't simply magically resolve > > themselves. I believe you can infer whether I would object to > > the > > current state of #55231 or not. >=20 >=20 > I haven=E2=80=99t been involved in this stuff in the past and don= =E2=80=99t use > ZFS on Guix[2]. The issue I read, which this patch is for, it > appeared that your last objection was that the documentation gave > ZFS as an example, which is the Guix project obliquely encouraging > users to commit inadvertent violations. This problem was > addressed, therefore I believed your objections were resolved. I > apologize for midunderstanding the situation. >=20 > Thanks, >=20 > -- Ian >=20 > [1]: I distinguish between things with both legitimate and > illegitimate purposes (such as BitTorrent clients), and those > whose main purpose is clearly copyright violation. > [2]: I do use ZFS on Debian, where this issue is moot.
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 9 Feb 2025 19:46:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 14:46:43 2025 Received: from localhost ([127.0.0.1]:46418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thDGN-0004Vt-FU for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 14:46:43 -0500 Received: from xavier.telenet-ops.be ([2a02:1800:120:4::f00:14]:40384) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maximedevos@HIDDEN>) id 1thDGK-0004Vc-SJ for 55231 <at> debbugs.gnu.org; Sun, 09 Feb 2025 14:46:41 -0500 Received: from [IPV6:2a02:1811:8c0e:ef00:d058:b1ee:d400:979b] ([IPv6:2a02:1811:8c0e:ef00:d058:b1ee:d400:979b]) by xavier.telenet-ops.be with cmsmtp id BXmZ2E00A1ADjLZ01XmZiK; Sun, 09 Feb 2025 20:46:34 +0100 Message-ID: <6af9b9dd-313a-4eb5-92c1-2edc42bed113@HIDDEN> Date: Sun, 9 Feb 2025 20:46:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Understanding #:substitutable? and #55231 To: Kaelyn <kaelyn.alexi@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> <_vvV6oht3R-W5PqRtwQhRBDb8q-O40J39F7fnTG3JLHVXOujpZdQ4s-G85O27ErbFokl95RtkiUBXlE8pLJVFsnN6-ANPTMGK4Vq0iBUP_I=@protonmail.com> Content-Language: en-US From: Maxime Devos <maximedevos@HIDDEN> In-Reply-To: <_vvV6oht3R-W5PqRtwQhRBDb8q-O40J39F7fnTG3JLHVXOujpZdQ4s-G85O27ErbFokl95RtkiUBXlE8pLJVFsnN6-ANPTMGK4Vq0iBUP_I=@protonmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r25; t=1739130394; bh=yEjt+0wGcIYgVx+z6pirn72mKSLksYHjryNv5bkV0b4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding:From; b=TLIoQcwHCU+PZ/MVVN1LNEwrFpEV6XIGBj2fdAcqUTWj8VQE6VnMfGBMm8IXqeDNm ciBpqF4qOiULx8ViMbsSyGXJ52DVGhHMojnD53KriO9tse0lBH17Wlwi53In2K5/5n F5ZjkxoHonV1f552svpj3SKQ8QsvjxxSpdZCrbsaisPkAuww8RjiscCRJ/MkonB4q8 VCAvA6dC+tllPMjo242c+az88P/waRvcY5ep05nglMZKOF+bN5QVFCdkycavHwJd23 NN5YW3fvNx9hmlGxO75Udyv6ghbqNLzWa6DcJwc1qZfFrxemRoh7tWhfbptTHtqQEl a2VlgMwPyc6eg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55231 Cc: "Morgan Arnold via Development of GNU Guix and the GNU System distribution." <guix-devel@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, =?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>, 55231 <at> debbugs.gnu.org, Ian Eure <ian@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > [ZFS (il)legality links] This isn't the place for that. If you believe there are some new and correct arguments for/against compatibility, that's something for a separate thread. Some of these are old news. >> And pointing this out to them doesn't seem to ever work. >> >> It has been some time ago, but I probably suspected it wouldn't work in >> this case either. > Not to be offensive, but I find these statements to be very dismissive of those who disagree with you about ZFS distribution as well as both their reasoning for their position and their openness to differing viewpoints or new information. This is a mischaracterisation - both of what I said in the mail you are responding to, and the reality of what happened in the ZFS discussions. It is indeed dismissive, but the dismissiveness is not 'because I disagree with them', it's because of: * their slander(*) (see: Mason Loring Bliss) (also, to a much lesser extent, right now you - I don't think this quoting out context+misinterpretation _technically_ counts as slander, but it's something bad nonetheless) * their rudeness (see: raid5atemyhomework) (also Mason Loring Bliss, since slander is rude) * their hypocrisy as a group (see: they claim it can be fine because of non-binary distribution, but they never change Guix to _make_ the ZFS stuff non-binary) * repeating _old_ information as an argument/counter-argument, even though it has already been made and replied to, without providing more explanation or another interpretation (see: Mason Loring Bliss. Maybe others, but in particular I recall Mason Loring Bliss doing this). (*) In ordinary sense, without distinguishing between exact forms of defamation, and not evaluating whether illegal or legal. Sometimes, being dismissive, is a perfectly reasonable response. As long as it's for the right reasons, well-founded, and with evidence. Also, the 'dismissiveness to [others with different viewpoint]' is the other way around (see: previous points). Regards, Maxime Devos
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 9 Feb 2025 19:37:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 14:37:24 2025 Received: from localhost ([127.0.0.1]:46376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thD7L-0003yZ-T2 for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 14:37:24 -0500 Received: from fhigh-b5-smtp.messagingengine.com ([202.12.124.156]:54029) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <ian@HIDDEN>) id 1thD7J-0003yI-BI for 55231 <at> debbugs.gnu.org; Sun, 09 Feb 2025 14:37:22 -0500 Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfhigh.stl.internal (Postfix) with ESMTP id D0F5E25401AB; Sun, 9 Feb 2025 14:37:15 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-08.internal (MEProxy); Sun, 09 Feb 2025 14:37:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1739129835; x=1739216235; bh=3aKZ3b2jqh1Kl/tujzyGbOvfSOlW0fw5KI7FaO7JccI=; b= RcxOWD+Um5H1a+C8R6AC1pEJNC2Vpqcg4SvZKBipQSFmFakASOIUDsUtuYmdaQF/ eW956BHUfej6YtUwLmuE9vSTvj1bxj4tK2ErMMB/sH38Ttar+8DVinrhzfh1vP6q DNkPV6KsRAHazSiGQSVL11LeeHgyFGS44qkn7hLBy1ApeUHwNMQc4ulbKPkPs5k6 Zx5e0ZDQ6WLfTPOyfD1O0IaDFZM6anQiIZJbwZFJNb/XZzMJ3nyldNGL13n6k8Rk 2ZwGv1iYLsXiuVcHtmLRcNHWWfDc1t4R/6ZeNkpp6Pxf4aT3I39b+exZafOM4lUu xjpls/XnFIJh0RQEiwzaIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1739129835; x= 1739216235; bh=3aKZ3b2jqh1Kl/tujzyGbOvfSOlW0fw5KI7FaO7JccI=; b=R ns/x7lEa1vgnECMVaggSPqVvhz7bd4+m+pWmuVm8L9igCn/s387ylNClK/gWPHQf G17FkxUEYiW98Jm/yitYrf1xAy8MvYuIY4ukfRT8R5feE9uKkk8r0J1KostTTHjb 7L1b7YNyiU4ZjkowLy/Cs6OXlVR+EowIa38zVd+vEvsvj174/93kE+PQKw4qzv78 Rk19xQyUtc176T+CQon7wILcZ2aEA5cpfxcRf8bp8eOQu1MHGUnOSb6a89imGTRG TTXCP64Gu+IIlpwseXF/qG8cVsk+x5Hr+9xsMOboiEpooonMvqq23stAL526drGb 74GVUaoNYqjLM6i8opX0g== X-ME-Sender: <xms:6gOpZ15MNTLOe-YLnPXdmjbqjZ8KLoU_hS5mMnCVr095jILWz6hRdw> <xme:6gOpZy4U7HXD9kXbYL0coMDLro0GN6aiswxrBGGtKIB5fQfsrNGZJs3-lrKZ-em9V UVekpgHEjtfMrKs1w> X-ME-Received: <xmr:6gOpZ8dDbsX-wTVXwdIK5grmD27TXwQeAu6N226WDGSNgU80IVTJOcM6F0MdD1wezB2EQsMxiw6jjrnNHZrQvp3aLUVcCAFVdqnG-4RWSA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdefiedtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttder jeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqe enucggtffrrghtthgvrhhnpeevueelueegudejueekhffhhfelgfejheefffehgfffleek veekuedtgeekleegffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvhdpnhgspghrtghpthhtohephedp mhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheplhhuughosehgnhhurdhorhhgpdhrtg hpthhtohepheehvdefudesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehm ohhrghgrnhdrrghrnhholhgusehprhhothhonhdrmhgvpdhrtghpthhtohepghhuihigqd guvghvvghlsehgnhhurdhorhhgpdhrtghpthhtohepmhgrgihimhgvuggvvhhoshesthgv lhgvnhgvthdrsggv X-ME-Proxy: <xmx:6gOpZ-IRL3P4NyRoFKalnlnmVNJmjBCinINLZxiCo0UsMcTbYdoX3Q> <xmx:6gOpZ5Jttwk2zMKCYRNiBDMzE8JoCaunKLnNxLtbv30aSqCFkau_fg> <xmx:6gOpZ3xvCQ8_PXelxCYwZfuCKW1XMtLkimLUSQckTBb79YVSUiC3WQ> <xmx:6gOpZ1JxG6KoT2RiX0JalQ6KfcgqgUnih1W5FzKVI1CN0pvG8Uc09g> <xmx:6wOpZ3h9kZ38S2Af_wm0gLmrK-UOxD1PVHwtBfXpiuTP1uywQdRy2fJB> Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 9 Feb 2025 14:37:14 -0500 (EST) From: Ian Eure <ian@HIDDEN> To: Maxime Devos <maximedevos@HIDDEN> Subject: Re: Understanding #:substitutable? and #55231 In-Reply-To: <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> (Maxime Devos's message of "Sun, 9 Feb 2025 18:11:33 +0100") References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> User-Agent: mu4e 1.12.8; emacs 29.4 Date: Sun, 09 Feb 2025 11:37:13 -0800 Message-ID: <87wmdyx63a.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55231 Cc: "Morgan Arnold via Development of GNU Guix and the GNU System distribution." <guix-devel@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, Ludovic =?utf-8?Q?Cou?= =?utf-8?Q?rt=C3=A8s?= <ludo@HIDDEN>, 55231 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Hi Maxime, Maxime Devos <maximedevos@HIDDEN> writes: > On 9/02/2025 2:06, Ian Eure wrote: > >> Hi Morgan, >> >> Morgan Arnold via "Development of GNU Guix and the GNU System >> distribution." <guix-devel@HIDDEN> writes: >> >>> Hello, >>> >>> If the issue is simply that the patch has not been rebased=20 >>> against a >>> new enough version of Guix to be merged, I am happy to do that >>> rebasing. Additionally, please correct me if I have made any=20 >>> incorrect >>> assertions above. > > No. See the stuff about #:substitutable?. The reason I didn't=20 > answer > back then, is that I don't want to keep being a broken record. Could you help me understand the case where this becomes a=20 problem? Is it: - If you have one machine with an operating-system which includes=20 a non-#:substitutable? out-of-tree kernel module in its initrd,=20 and - A second machine with an identical initrd configuration, and - The first machine is configured to serve substitutes, and - The second machine uses the first as a substitute server Then the non-#:substitutable? module would be distributed,=20 violating its license? I=E2=80=99d also find it helpful to understand the line for specific acts=20 and entities in play, on a matrix of: allowing violations,=20 encouraging violations, or committing violations; and by=20 individual Guix users, or by the Guix project itself. For=20 example, I think the Guix project encouraging or committing a=20 violation is unacceptable. I think this would help a great deal to make the bounds of the=20 problem clear, which is needed to solve them. > If 'make-linux-libre' in the presence of ZFS leads to=20 > #:subsitutable? > problems, that doesn't mean it's fine to ignore the law for=20 > #52231. It > means you need to: Could you please help me understand how `make-linux-libre' is in=20 scope? I don=E2=80=99t believe any in-tree kernel modules have the=20 problematic license terms, so I think the issue is purely=20 out-of-tree stuff, whether that=E2=80=99s ZFS, nVidia drivers, "endpoint=20 protection" security systems, etc. Perhaps you meant=20 `make-initrd'? > More specifically, ZFS proponents (at least as a group, and when > limited to those visible in Guix) tend to be rather incoherent=20 > in > their positions, in the sense that simultaneously do: > > =C2=A0(snip) I appreciate your perspective, however, I=E2=80=99m more interested in=20 understanding the problems so they can be solved. Any help in=20 that area would be greatly appreciated. >> It does seem that #55231 ended up in a place where there was >> concensus that it was acceptable, but didn=E2=80=99t get merged for=20 >> some >> reason or other.=C2=A0 I definitely could be wrong, but I suspect=20 >> the >> issue is that when non-#:substitutable? packages are used in=20 >> places >> other than package inputs, the downstream derivations don=E2=80=99t=20 >> carry >> that information.=C2=A0 I believe when used as a package input, >> non-#:substitutable? packages do, in fact, poison all=20 >> downstream >> derivations.=C2=A0 Happy to be corrected if I=E2=80=99m wrong here. > > Not quite - to my understanding, the downstream derivations=20 > _also_ > don't carry that information when it's in package inputs (at=20 > least, > last time I checked there didn't seem to be any mechanism to set > #:substitutable? to #false when any of the inputs are=20 > unsubstitutable > (whether non-bag(?) derivation inputs, implicit inputs,=20 > native-inputs, > ...)). Ah, hmm. So these kind of violations are implictly prevented by=20 Guix not shipping things in combinations which would violate the=20 license terms? > For packages, in typical situations the #:substitutable? #false=20 > of any > 'native-inputs' of a package shouldn't impact the=20 > substitutability of > the package. For 'inputs', it rather depends=20 > (e.g. static/dynamic, the > particulars of the license, is it because of license reasons or > something else). Since it somewhat depends on the situation, if=20 > you > implement a thing like this, I would recommend making it a=20 > _default_ > for #:substitutable?(*), that can be overridden by some method. That=E2=80=99s a good suggestion, thank you. >> I think it=E2=80=99s reasonable to merge this after it=E2=80=99s rebased= on=20 >> current >> master, and would be willing to do that unless Maxime or Ludo=E2=80=99=20 >> raise >> an objection. > > First you say you suspect the issue is that=20 > #:substitutable?-related > behaviour isn't right yet, and immediately in the next paragraph=20 > you > say it's reasonable to merge it. Given that the patches haven't=20 > been > adjusted to solve this, this is rather incongruent. While I agree that the fundamental #:substitutable? mechanism of=20 Guix could use improvement, I don=E2=80=99t believe these patches need to=20 wait for that work, becasue: - This is a generic mechanism useful for any out-of-tree module=20 regardless of license[1]. - They won=E2=80=99t cause the Guix project to commit a license violation. - They don=E2=80=99t encourage individuals to commit license violations. - While they could /allow/ individuals to commit violations, many=20 things in Guix already do, because it=E2=80=99s infeasible to forbid. To the last point: - Right now, Guix allows a user to make a system image containing=20 compiled ZFS modules and distribute it. - Guix ships DVD rippers and programs which can copy files, which=20 a user can commit copyright violations with. - Guix ships numerous programs for file sharing, whose /primary/=20 purpose is committing copyright violations. The nicotine+=20 package is one example[1]. I am struggling to square objections to a patch whose intent and=20 primary use would be within the bounds of=20 non-binary-redistribution licenses, but which might enable an=20 individual to (most likely inadvertently) commit a license=20 violation with the significantly riskier things which are already=20 permitted. If I=E2=80=99m misunderstanding the situation here, I=E2=80=99d= =20 appreciate further insight. Some examples of other modules that could be used with this=20 facility are: lttng, a GPL=E2=80=99d out-of-tree kernel tracing system ddcci, a GPL=E2=80=99d out-of-tree module for controlling monitor settings OpenRazer, a GPL=E2=80=99d out-of-tree module to suppot Razer HID hardware I=E2=80=99m certain there are other cases where it=E2=80=99d be useful. > I already raised the objection several times in the past=20 > (including > _before_ #55231), and none of the patch revisions attempted to=20 > deal > with the objection.=C2=A0 Issues don't simply magically resolve > themselves. I believe you can infer whether I would object to=20 > the > current state of #55231 or not. > I haven=E2=80=99t been involved in this stuff in the past and don=E2=80=99t= use=20 ZFS on Guix[2]. The issue I read, which this patch is for, it=20 appeared that your last objection was that the documentation gave=20 ZFS as an example, which is the Guix project obliquely encouraging=20 users to commit inadvertent violations. This problem was=20 addressed, therefore I believed your objections were resolved. I=20 apologize for midunderstanding the situation. Thanks, -- Ian [1]: I distinguish between things with both legitimate and=20 illegitimate purposes (such as BitTorrent clients), and those=20 whose main purpose is clearly copyright violation. [2]: I do use ZFS on Debian, where this issue is moot.
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 9 Feb 2025 18:50:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 13:50:45 2025 Received: from localhost ([127.0.0.1]:46279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thCOC-0001jt-Ka for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 13:50:45 -0500 Received: from mail-4322.protonmail.ch ([185.70.43.22]:29619) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <kaelyn.alexi@HIDDEN>) id 1thCO9-0001jP-Qy for 55231 <at> debbugs.gnu.org; Sun, 09 Feb 2025 13:50:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1739127034; x=1739386234; bh=362HUtJTILAQ713TPhzfO2TAj3PnxoGQVUZ1r2WoL+c=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=KbupgbU2Q0rfd7Kh8GgCzrNXcbLNOpSAhxcx/+ZcGRUY877kM8i8cul5vymgWamGW Bl+RaKbG/nJsOQ8uLUP8zXjY6Bs0VK2oUA/eR0QlDgJIfkCKrc0xxMkIFXARJqkf2j eTBs8sEykcHlrJVi3yh6dOATqgu3XfxkdmjBXYTe01dQU4hm96bRkomn9Yx2awPUjK IYNoMTyfopzpjepCxrDI+iO/hh50egwnJXewiyxUYpdu4LzLfGcKC5nlyr7QdTE/OC 7kpH2JlLZZZRMwT7WyK7HprIHAYuDRveBUQWieqEn1CKqMYxVANa+gTZJ71RE7296f K9z8hg1XNwP7w== Date: Sun, 09 Feb 2025 18:50:30 +0000 To: Maxime Devos <maximedevos@HIDDEN> From: Kaelyn <kaelyn.alexi@HIDDEN> Subject: Re: Understanding #:substitutable? and #55231 Message-ID: <_vvV6oht3R-W5PqRtwQhRBDb8q-O40J39F7fnTG3JLHVXOujpZdQ4s-G85O27ErbFokl95RtkiUBXlE8pLJVFsnN6-ANPTMGK4Vq0iBUP_I=@protonmail.com> In-Reply-To: <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> Feedback-ID: 34709329:user:proton X-Pm-Message-ID: f42d856284ab94ef9b6a43f56543d77b21523e6b MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: "Morgan Arnold via Development of GNU Guix and the GNU System distribution." <guix-devel@HIDDEN>, Morgan Arnold <morgan.arnold@HIDDEN>, =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>, 55231 <at> debbugs.gnu.org, Ian Eure <ian@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi, On Sunday, February 9th, 2025 at 9:11 AM, Maxime Devos <maximedevos@telenet= .be> wrote: >=20 >=20 > On 9/02/2025 2:06, Ian Eure wrote: >=20 > > Hi Morgan, > >=20 > > Morgan Arnold via "Development of GNU Guix and the GNU System > > distribution." guix-devel@HIDDEN writes: > >=20 > > > Hello, > > >=20 > > > If the issue is simply that the patch has not been rebased against a > > > new enough version of Guix to be merged, I am happy to do that > > > rebasing. Additionally, please correct me if I have made any incorrec= t > > > assertions above. >=20 >=20 > No. See the stuff about #:substitutable?. The reason I didn't answer > back then, is that I don't want to keep being a broken record. >=20 > If 'make-linux-libre' in the presence of ZFS leads to #:subsitutable? > problems, that doesn't mean it's fine to ignore the law for #52231. It > means you need to: >=20 > (a) remove ZFS > (b) or adjust 'make-linux-libre' (whether code or documentation, > preferably code) to do the #:substitutable? thing >=20 > More generally, legality > convenience (except in case of revolution, >=20 > but that's not applicable to Guix, and it seems inadvisable to talk > about such matters in the open). > More specifically, ZFS proponents (at least as a group, and when limited > to those visible in Guix) tend to be rather incoherent in their > positions, in the sense that simultaneously do: >=20 > (1) consider GPL and ZFS license to be compatible, > (2) with caveat about "no binary distributions" (legal restriction) > (3) want to get ZFS in a distribution > (4) their method to get ZFS in the distribution doesn't address point (2) > (5) and they refuse to fix the legal issue (4) when pointed out to > them, with as reason: > (5a) previous versions of Guix already violate restriction (2) > (5b) it's technically slightly inconvenient >=20 > Like, (5a) just makes things worse (as now would be knowingly in > violation of the law, and the duration of the violation increases) and > (5b) is utterly irrelevant to the law - Guix is subject to the law, not > the other way around. While I do not wish to chime in on either side at this time as I am most de= finitely not a lawyer, I want to share a few references and the result of a= bit of recent research. As far as I can tell (as a layman), the legality o= f distributing a binary ZFS module is currently a matter of differing opini= ons, and a bit of searching has not revealed case precedent for deciding th= e matter. The closest to that which I found was a lawsuit against VMware in= Germany over vmklinux within vSpere, which was dismissed on procedural gro= unds and for which VMware voluntarily announced the removal of vmklinux (ht= tps://sfconservancy.org/news/2019/apr/02/vmware-no-appeal/). Regarding distributing ZFS, Ubuntu and their legal team concluded about 9 y= ears ago that they can distribute ZFS kernel modules and still comply with = both licenses. I also did not find mention of Ubuntu reversing their decisi= on, or of legal issues around ZFS that have arisen for them in that time pe= riod. Again, I want to emphasize that IANAL and that there is not a clear d= ecision on the legality of such distribution. Here are a few useful links I found, both for and against ZFS binary distri= bution: * https://blog.dustinkirkland.com/2016/02/zfs-licensing-and-linux.html * https://blog.hansenpartnership.com/are-gplv2-and-cddl-incompatible/ * https://sfconservancy.org/blog/2016/feb/25/zfs-and-linux/ * https://softwarefreedom.org/resources/2016/linux-kernel-cddl.html > And pointing this out to them doesn't seem to ever work. >=20 > It has been some time ago, but I probably suspected it wouldn't work in > this case either. Not to be offensive, but I find these statements to be very dismissive of t= hose who disagree with you about ZFS distribution as well as both their rea= soning for their position and their openness to differing viewpoints or new= information. As an aside, I can and do accept that the Guix maintainers hold the view th= at distributing binary ZFS modules is a license violation, and that they ha= ve rejected the patches in issue #55231 on the basis it could inadvertently= allow for official substitutes to be made available containing a binary zf= s.ko or spl.ko. I have worked around the absence in a satisfactory way for = my needs by overriding much of the initrd generation within my local channe= l to effectively integrate #55231 there. However, responses like the one ab= ove (as well as some of the general sentiments raised in this email thread)= have largely discouraged me from contributing to Guix aside from the occas= ional package bump or bug fix. Basically, I no longer have any opinion on t= he fate of the patches in #55231 or on how Guix wishes to deal with ZFS (an= d despite no discouraging responses on the issue, there's a good chance I w= on't find the motivation again to follow up on the single reply to https://= issues.guix.gnu.org/71482, given the community attitudes I've observed rega= rding matters touching on ZFS). Regards, Kaelyn > > It does seem that #55231 ended up in a place where there was concensus > > that it was acceptable, but didn=E2=80=99t get merged for some reason o= r > > other. I definitely could be wrong, but I suspect the issue is that > > when non-#:substitutable? packages are used in places other than > > package inputs, the downstream derivations don=E2=80=99t carry that > > information. I believe when used as a package input, > > non-#:substitutable? packages do, in fact, poison all downstream > > derivations. Happy to be corrected if I=E2=80=99m wrong here. >=20 >=20 > Not quite - to my understanding, the downstream derivations also don't > carry that information when it's in package inputs (at least, last time > I checked there didn't seem to be any mechanism to set #:substitutable? > to #false when any of the inputs are unsubstitutable (whether non-bag(?) > derivation inputs, implicit inputs, native-inputs, ...)). >=20 > For packages, in typical situations the #:substitutable? #false of any > 'native-inputs' of a package shouldn't impact the substitutability of > the package. For 'inputs', it rather depends (e.g. static/dynamic, the > particulars of the license, is it because of license reasons or > something else). Since it somewhat depends on the situation, if you > implement a thing like this, I would recommend making it a default for > #:substitutable?(*), that can be overridden by some method. >=20 > > I think it=E2=80=99s reasonable to merge this after it=E2=80=99s rebase= d on current > > master, and would be willing to do that unless Maxime or Ludo=E2=80= =99 raise > > an objection. >=20 >=20 > First you say you suspect the issue is that #:substitutable?-related > behaviour isn't right yet, and immediately in the next paragraph you say > it's reasonable to merge it. Given that the patches haven't been > adjusted to solve this, this is rather incongruent. >=20 > I already raised the objection several times in the past (including > before #55231), and none of the patch revisions attempted to deal with > the objection. Issues don't simply magically resolve themselves. I > believe you can infer whether I would object to the current state of > #55231 or not. >=20 > Regards, > Maxime Devos
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 9 Feb 2025 17:11:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Feb 09 12:11:45 2025 Received: from localhost ([127.0.0.1]:46071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1thAqO-0005OH-SF for submit <at> debbugs.gnu.org; Sun, 09 Feb 2025 12:11:45 -0500 Received: from baptiste.telenet-ops.be ([2a02:1800:120:4::f00:13]:48904) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <maximedevos@HIDDEN>) id 1thAqM-0005O0-4q for 55231 <at> debbugs.gnu.org; Sun, 09 Feb 2025 12:11:43 -0500 Received: from [IPV6:2a02:1811:8c0e:ef00:d058:b1ee:d400:979b] ([IPv6:2a02:1811:8c0e:ef00:d058:b1ee:d400:979b]) by baptiste.telenet-ops.be with cmsmtp id BVBZ2E00L1ADjLZ01VBZYN; Sun, 09 Feb 2025 18:11:34 +0100 Message-ID: <58533ecf-607f-4a41-a94f-c232a26c46f5@HIDDEN> Date: Sun, 9 Feb 2025 18:11:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Understanding #:substitutable? and #55231 To: Ian Eure <ian@HIDDEN>, "Morgan Arnold via Development of GNU Guix and the GNU System distribution." <guix-devel@HIDDEN> References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> <87a5awylhy.fsf@HIDDEN> Content-Language: en-US From: Maxime Devos <maximedevos@HIDDEN> In-Reply-To: <87a5awylhy.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r25; t=1739121094; bh=W3N5AUAs/v3NAqxglMpYXiZ4ipADtAkbbqaOtwJCByM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding:From; b=X/sScGtRJY+LeVXu2Ueu9faRXtz7xq6Ms1ow7+G60FNsZhfWjiX9go219jTVOu5JK psGIkvJckNS9423TLld+q4Da8vLD7GqIYhrqsaGN/Knk6EFOTnAV94vAWkhR09m+zJ JHr/WANyP7GzhKiAlgSufKAxe4UfNT12biffcOtpkluXV9bskrOuY86gdfKML4xXwJ kuJBJpVFq4K4TtuL7cWHJibvpa0IW8jXoIuwnKN2ODkeQcFcHUOXooA8XOMetuTBGK vpNBSDE2NbI9MGZ0VBDuFb/77NIUuERi+f62SboH6L2ICyi3OTy34DYOjDVge2ngLw c2K+JWS5BNZng== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55231 Cc: Morgan Arnold <morgan.arnold@HIDDEN>, =?UTF-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>, 55231 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 9/02/2025 2:06, Ian Eure wrote: > Hi Morgan, > > Morgan Arnold via "Development of GNU Guix and the GNU System > distribution." <guix-devel@HIDDEN> writes: > >> Hello, >> >> If the issue is simply that the patch has not been rebased against a >> new enough version of Guix to be merged, I am happy to do that >> rebasing. Additionally, please correct me if I have made any incorrect >> assertions above. No. See the stuff about #:substitutable?. The reason I didn't answer back then, is that I don't want to keep being a broken record. If 'make-linux-libre' in the presence of ZFS leads to #:subsitutable? problems, that doesn't mean it's fine to ignore the law for #52231. It means you need to: (a) remove ZFS (b) or adjust 'make-linux-libre' (whether code or documentation, preferably code) to do the #:substitutable? thing More generally, legality > convenience (except in case of revolution, but that's not applicable to Guix, and it seems inadvisable to talk about such matters in the open). More specifically, ZFS proponents (at least as a group, and when limited to those visible in Guix) tend to be rather incoherent in their positions, in the sense that simultaneously do: (1) consider GPL and ZFS license to be compatible, (2) with caveat about "no binary distributions" (legal restriction) (3) want to get ZFS in a distribution (4) their method to get ZFS in the distribution doesn't address point (2) (5) and they refuse to fix the legal issue (4) when pointed out to them, with as reason: (5a) previous versions of Guix already violate restriction (2) (5b) it's technically slightly inconvenient Like, (5a) just makes things _worse_ (as now would be _knowingly_ in violation of the law, and the duration of the violation increases) and (5b) is utterly irrelevant to the law - Guix is subject to the law, not the other way around. And pointing this out to them doesn't seem to ever work. It has been some time ago, but I probably suspected it wouldn't work in this case either. > It does seem that #55231 ended up in a place where there was concensus > that it was acceptable, but didn’t get merged for some reason or > other. I definitely could be wrong, but I suspect the issue is that > when non-#:substitutable? packages are used in places other than > package inputs, the downstream derivations don’t carry that > information. I believe when used as a package input, > non-#:substitutable? packages do, in fact, poison all downstream > derivations. Happy to be corrected if I’m wrong here. Not quite - to my understanding, the downstream derivations _also_ don't carry that information when it's in package inputs (at least, last time I checked there didn't seem to be any mechanism to set #:substitutable? to #false when any of the inputs are unsubstitutable (whether non-bag(?) derivation inputs, implicit inputs, native-inputs, ...)). For packages, in typical situations the #:substitutable? #false of any 'native-inputs' of a package shouldn't impact the substitutability of the package. For 'inputs', it rather depends (e.g. static/dynamic, the particulars of the license, is it because of license reasons or something else). Since it somewhat depends on the situation, if you implement a thing like this, I would recommend making it a _default_ for #:substitutable?(*), that can be overridden by some method. > I think it’s reasonable to merge this after it’s rebased on current > master, and would be willing to do that unless Maxime or Ludo’ raise > an objection. First you say you suspect the issue is that #:substitutable?-related behaviour isn't right yet, and immediately in the next paragraph you say it's reasonable to merge it. Given that the patches haven't been adjusted to solve this, this is rather incongruent. I already raised the objection several times in the past (including _before_ #55231), and none of the patch revisions attempted to deal with the objection. Issues don't simply magically resolve themselves. I believe you can infer whether I would object to the current state of #55231 or not. Regards, Maxime Devos
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 9 Feb 2025 01:07:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Feb 08 20:07:02 2025 Received: from localhost ([127.0.0.1]:42228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tgvmo-00082R-B4 for submit <at> debbugs.gnu.org; Sat, 08 Feb 2025 20:07:02 -0500 Received: from fout-a6-smtp.messagingengine.com ([103.168.172.149]:41185) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <ian@HIDDEN>) id 1tgvmj-00081m-AP for 55231 <at> debbugs.gnu.org; Sat, 08 Feb 2025 20:06:59 -0500 Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfout.phl.internal (Postfix) with ESMTP id A0C001380906; Sat, 8 Feb 2025 20:06:51 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Sat, 08 Feb 2025 20:06:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1739063211; x=1739149611; bh=Oy2bvep7wX0wnj8IiZeBBsiSXFx1qxHvEZqTlmRC41w=; b= s16xHexSmkSz0pt5p01q/wFrtfrodHssFhqZcj21AhuZfxTc9hDqGN63Kiq/r23g B/NWgkW7ZLWZQ344oAqWM7ZuhwmT456t+gaQ6l7Z+s7E9/BTB7xuMBPeBL7HRS/d 2HsmJCrK6djNWZ+ndXMTsUKsTlKQce85kZYe7pukhmBKsWdmoCaAyye1sAY+mpVe RErKSHCUDDLf9zKXgVvX34pOaBJybb5gRA67+7pm2y/HwaJdJxmXvfz6CrOlhKmf 3XlbohT1W1trbiuDzJaQDLJpXQZLKKW2/lqR0kN43iuVo26+Sbu77yx/pTlREjx5 q+SEjeltZmm2WSHBUmwd3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1739063211; x= 1739149611; bh=Oy2bvep7wX0wnj8IiZeBBsiSXFx1qxHvEZqTlmRC41w=; b=T 4ooWb4hpFp46qFFaezVjCSgnfj+JDEnv2vkeLufh7QQnBzvFQSZwYUlQsIaTTeiG 9lgGE6BWdoFxdmazPyVH/vezDLuXsGDDyowmSAQhPHjWn7FBlXeegmrgu1EjKylm IsRZzBv7E16xXvNNaa5fryVgE9HojSkBQ/9XBzaSMkDy6TvBvgMJVs7KVk7IIMaW P4wuDd/ZZmmhNucoCcwulbYrheLLNcWvEiPpyEf5eK51Vfue8ob7cG80TkxCJRM2 V4rrj0bR+gWUOlxuA9nGZLDKdNXteexoBytrrgSQIZJ29s1SSAox4IRwzvKc17PU RRIcGZbdp81Q/nNdloxeA== X-ME-Sender: <xms:qv-nZ-V0IXDi0NrV0PwB1rwtIIPvrFo3xg3RjliPAGAf5FktazFvbw> <xme:qv-nZ6mfVm4OduqKbEuiqW3LWI-VDuQRwx2ScyvhftjXA_HTV9nJWJtNMPLDJ2jLq 9ZYkkRqfqIv8mGBfg> X-ME-Received: <xmr:qv-nZyYpgIPleoZWDjbz8ES0apAMn-zOoCIGPxql3XMUhzQcO-pCNQgJmWBQ0yy0usm4aUcXYHkluDDjQDz8XIqhhpeq1E4v8qOuaNlQ3A> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeffeejhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtgfesthhqredttder jeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdrthhvqe enucggtffrrghtthgvrhhnpeevueelueegudejueekhffhhfelgfejheefffehgfffleek veekuedtgeekleegffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvhdpnhgspghrtghpthhtohephedp mhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepmhgrgihimhgvuggvvhhoshesthgvlh gvnhgvthdrsggvpdhrtghpthhtoheplhhuughosehgnhhurdhorhhgpdhrtghpthhtohep heehvdefudesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehmohhrghgrnh drrghrnhholhgusehprhhothhonhdrmhgvpdhrtghpthhtohepghhuihigqdguvghvvghl sehgnhhurdhorhhg X-ME-Proxy: <xmx:q_-nZ1UVdUqIZcAmPBRwq8O1xTUjCjnChN-SO_e97_Vw3ifqF4vR_w> <xmx:q_-nZ4k3pIGzxMID-eFEskQpZF4d7foWRqr_N14hK-iajY3uE8_qGw> <xmx:q_-nZ6dXAz5v38_V_ckwTyhe6vFf8dzgeh7xvwmGqgNO_VeLH0aLaw> <xmx:q_-nZ6HtvXojhfe-IvnzT5mT_mUGt5CNEEOe53nWQiG3vl2w31F46Q> <xmx:q_-nZ3uW7Z1WWC-KD9ZFMhN05KziaXM1kECLrBgitFCKp0iZIINaDhW6> Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 8 Feb 2025 20:06:50 -0500 (EST) From: Ian Eure <ian@HIDDEN> To: Morgan Arnold via "Development of GNU Guix and the GNU System distribution." <guix-devel@HIDDEN> Subject: Re: Understanding #:substitutable? and #55231 In-Reply-To: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> (Morgan Arnold via's message of "Wed, 05 Feb 2025 16:02:38 +0000") References: <7YDq_dqJ3hhPBhpMt1fFRO-B21hxMgwryTwdGidAIndSZAmPkLkLdWmam-lwkl7_Esxv8nlOtoLHh82Hh-ZGnEMnjBkGIFBBbJakx-fqiUs=@proton.me> User-Agent: mu4e 1.12.8; emacs 29.4 Date: Sat, 08 Feb 2025 17:06:49 -0800 Message-ID: <87a5awylhy.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 55231 Cc: Morgan Arnold <morgan.arnold@HIDDEN>, Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>, 55231 <at> debbugs.gnu.org, Maxime Devos <maximedevos@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Hi Morgan, Morgan Arnold via "Development of GNU Guix and the GNU System=20 distribution." <guix-devel@HIDDEN> writes: > Hello, > > If the issue is simply that the patch has not been rebased=20 > against a > new enough version of Guix to be merged, I am happy to do that > rebasing. Additionally, please correct me if I have made any=20 > incorrect > assertions above. > It does seem that #55231 ended up in a place where there was=20 concensus that it was acceptable, but didn=E2=80=99t get merged for some=20 reason or other. I definitely could be wrong, but I suspect the=20 issue is that when non-#:substitutable? packages are used in=20 places other than package inputs, the downstream derivations don=E2=80=99t= =20 carry that information. I believe when used as a package input,=20 non-#:substitutable? packages do, in fact, poison all downstream=20 derivations. Happy to be corrected if I=E2=80=99m wrong here. I think it=E2=80=99s reasonable to merge this after it=E2=80=99s rebased on= =20 current master, and would be willing to do that unless Maxime or=20 Ludo=E2=80=99 raise an objection. However, you resent a v1 patch to a bug where four versions has=20 already been sent. If you=E2=80=99d be willing to resend as v5 (with `git= =20 format-patch -v5 -2'), I can get it pushed. Thanks, -- Ian
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 6 Feb 2025 04:36:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 23:36:43 2025 Received: from localhost ([127.0.0.1]:53694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tftd5-00064D-83 for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 23:36:43 -0500 Received: from mail-40133.protonmail.ch ([185.70.40.133]:15365) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>) id 1tfnci-0004Hb-Bw for 55231 <at> debbugs.gnu.org; Wed, 05 Feb 2025 17:11:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1738793509; x=1739052709; bh=5EaYRrNE1z3DXFB2M/ITLTVizLZW3CymTEHOQEOLQ5k=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector: List-Unsubscribe:List-Unsubscribe-Post; b=GPMrld8MRv+KBgHT9qrCohUXNQ4/Jr8y1Uz3Cxk0SUwRvRlvHGNXoxzRhqqq6HbLZ KTbWN/CqNW5SgyA2FkES7qhKmk8q+7bWcGiGiz/AqkFLVkI7+atEmNu+QLVXfGmBlx Y6D2jIY1xRtLPTSLyY+5ul2TDZlZrDmqNe3+aB9M5cBIvonedF978iIuELCnE6Z6dD er/CISqXSi0jy3yVW/sTGy7cyDVeuxbfgpw1xr7iJhln3i6Kv6Fm/kyzSK4S32EyPo rXdgpP5Cvkaph5b1R1Uq0kGlBwRmNBKrlylH7GYWpXtclus6wQGedKkBAALQHygIdz B/DK/fsDWZChA== Date: Wed, 05 Feb 2025 22:11:46 +0000 To: "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> From: Morgan Arnold <morgan.arnold@HIDDEN> Subject: =?utf-8?Q?[PATCH_v1]_initrd:_Allow_extra_search_paths_with_=E2=80=98initrd-extra-module-paths=E2=80=99?= Message-ID: <6Uxo8QbXiUMWqlYZwxpdOYroHPEageNgoo-EJQSgpT4CvfjIq_k-noKrQDBM39x_FqCs9KVh1oZcjR1ns3sfP9TDJe_Y-mkMiZ3NixHyFp8=@proton.me> Feedback-ID: 45510636:user:proton X-Pm-Message-ID: 7effa4126c45c65fc1cf117f7c6270526b7070a4 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 X-Mailman-Approved-At: Wed, 05 Feb 2025 23:36:36 -0500 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) I've made a (hopefully acceptable) attempt to rebase the patches on the new= est master of the Guix repo. If there's anything preventing these patches f= rom being merged, please let me know. Best, Morgan
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 6 Feb 2025 04:36:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 23:36:43 2025
Received: from localhost ([127.0.0.1]:53692 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tftd4-000645-Lh
for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 23:36:43 -0500
Received: from mail-40134.protonmail.ch ([185.70.40.134]:26275)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>)
id 1tfnW9-0003vj-DC
for 55231 <at> debbugs.gnu.org; Wed, 05 Feb 2025 17:05:10 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me;
s=pj7athgoqbgqfgcicpl5udjcly.protonmail; t=1738793102; x=1739052302;
bh=3XV8qODv28OwrscffCvUjTztc605e5acrs1bplnwSYM=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
b=QW8kD3Ca8xn4RY/Id4Ec0HoBfyYlF2lKeiemuIoBQbpNCJS7+z5rhGPGnr4clyY3C
VNcVncyPMls4zCgulh6a4a2AHHBp0wPdBkcBkmYq86Xpaxx0nn59PVGVfy7V9MKUa1
F8+354vtRPXtdIxkEg5DE7zFKVrWkKgjaJ9SayShKIeqW0oVgB5+gw4WKJP0o3qFXw
+p5iTWHYOmIHjn4bYH9eX0urN+RB/N3fxtT4pSs4xBd5ch/M6/88C/phnbtEQvjWfO
Ft98xzgVcULUJOkT3HDG+SZ19l0nl0bCjNYqLcIDlAYoij0wOdC8aD7YGWJt75F+aU
r+YaCE1XT9Csg==
Date: Wed, 05 Feb 2025 22:04:58 +0000
To: 55231 <at> debbugs.gnu.org
From: Morgan Arnold <morgan.arnold@HIDDEN>
Subject: =?utf-8?Q?[PATCH_2/2]_doc:_=E2=80=98initrd-modules=E2=80=99_will_search_=E2=80=98kernel-loadable-modules=E2=80=99.?=
Message-ID: <20250205220421.23774-2-morgan.arnold@HIDDEN>
In-Reply-To: <20250205220421.23774-1-morgan.arnold@HIDDEN>
References: <20250205220421.23774-1-morgan.arnold@HIDDEN>
Feedback-ID: 45510636:user:proton
X-Pm-Message-ID: f53493df4f8e6e485ee7dd2c778ce19861a9fc85
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 55231
X-Mailman-Approved-At: Wed, 05 Feb 2025 23:36:35 -0500
Cc: Brian Cully <bjc@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
From: Brian Cully <bjc@HIDDEN>
---
doc/guix.texi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/doc/guix.texi b/doc/guix.texi
index bb5f29277f..2ca8bbda51 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -43252,6 +43252,21 @@ file system, you would write:
(initrd-modules (cons "megaraid_sas" %base-initrd-modules)))
@end lisp
=20
+If a module listed in @code{initrd-modules} is not included in the
+Linux-libre kernel, then the location to it must be added to the
+@code{kernel-loadable-modules} list.
+
+For example, if you need the driver for a Realtek RTL8821CE wireless
+network adapter for mounting the root filesystem over NFS, your
+configuration might include the following:
+
+@lisp
+(operating-system
+ ;; @dots{}
+ (initrd-modules (cons "8821ce" %base-initrd-modules))
+ (kernel-loadable-modules (list (list rtl8821ce-linux-module "module"))))
+@end lisp
+
@defvar %base-initrd-modules
This is the list of kernel modules included in the initrd by default.
@end defvar
--=20
2.47.1
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 6 Feb 2025 04:36:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Feb 05 23:36:42 2025
Received: from localhost ([127.0.0.1]:53690 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tftd3-00063x-FV
for submit <at> debbugs.gnu.org; Wed, 05 Feb 2025 23:36:42 -0500
Received: from mail-4316.protonmail.ch ([185.70.43.16]:27497)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <morgan.arnold@HIDDEN>)
id 1tfnVx-0003uf-T8
for 55231 <at> debbugs.gnu.org; Wed, 05 Feb 2025 17:05:00 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me;
s=protonmail; t=1738793090; x=1739052290;
bh=T5+n7cCFVwVs2kinEpH80E3D/sf0YyEOojW1Ok+bS8o=;
h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:
Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector:
List-Unsubscribe:List-Unsubscribe-Post;
b=XzV6nHbTLghPx/mfxy7VLv9ZJR7xl2P5lYuO2hhUaSO/xwpyxBFKoNmXk4dsPnnQq
RVXI+84LQGyMl4kaK0f6WiYJZPH9op0PaBfchgYD8SeQLMQJq/2pnvT7Nbrew7cifH
9nlhqwoTbjkCsda+q9Hdb9yegdhnGXT9eVml1Jh7du7UKvyvtoPiBTIGS/ZrFPnBF/
Wzg5HMhvbk+Gvd4qeqMeBqX9Ql6ma8W1da9ZN5YJ39Pq0ZnX38rTFLyF3Ec3grXEQ4
uks2I92iLKX8SX94+r6c9dNFb1QXw6fDadj6w4KrXnS9r0pzSIUTXmPomL7T2FAzOm
GQfceIMjkNBjg==
Date: Wed, 05 Feb 2025 22:04:45 +0000
To: 55231 <at> debbugs.gnu.org
From: Morgan Arnold <morgan.arnold@HIDDEN>
Subject: [PATCH 1/2] Allows copying of out-of-tree modules to the Linux initrd.
Message-ID: <20250205220421.23774-1-morgan.arnold@HIDDEN>
Feedback-ID: 45510636:user:proton
X-Pm-Message-ID: 594d41db1254c6ce5393ad04113f7677276d3321
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 55231
X-Mailman-Approved-At: Wed, 05 Feb 2025 23:36:35 -0500
Cc: Brian Cully <bjc@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
From: Brian Cully <bjc@HIDDEN>
With this patch, modules for =E2=80=98initrd-modules=E2=80=99 will not only=
be searched for in
the in-tree Linux modules, but also any additional modules specified in
=E2=80=98kernel-loadable-modules=E2=80=99.
* gnu/build/linux-modules.scm (find-module-file): change DIRECTORY argument=
to
DIRECTORIES. Now takes a list of directories to search, rather than a singl=
e
one.
* gnu/system/linux-initrd.scm (flat-linux-module-directory): change LINUX
argument to PACKAGES. Now contains a list of file-likes to search for modul=
es.
(raw-initrd): Add LINUX-EXTRA-MODULE-DIRECTORIES keyword argument. Pass it
to (flat-linux-module-directory) along with the selected LINUX package.
(base-initrd): Add LINUX-EXTRA-MODULE-DIRECTORIES keyword argument. Pass it
to (raw-initrd).
* gnu/system.scm (operating-system-initrd-file): pass in operating system
definition's kernel-loadable-modules into (make-initrd) as
LINUX-EXTRA-MODULE-DIRECTORIES.
---
gnu/build/linux-modules.scm | 19 ++++++++------
gnu/system.scm | 2 ++
gnu/system/linux-initrd.scm | 50 ++++++++++++++++++++++++-------------
3 files changed, 45 insertions(+), 26 deletions(-)
diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scm
index 32baf6c525..b47bce9ab2 100644
--- a/gnu/build/linux-modules.scm
+++ b/gnu/build/linux-modules.scm
@@ -246,8 +246,8 @@ (define (file-name->module-name file)
'.ko[.gz|.xz|.zst]' and normalizing it."
(normalize-module-name (strip-extension (basename file))))
=20
-(define (find-module-file directory module)
- "Lookup module NAME under DIRECTORY, and return its absolute file name.
+(define (find-module-file directories module)
+ "Lookup module NAME under DIRECTORIES, and return its absolute file name=
.
NAME can be a file name with or without '.ko', or it can be a module name.
Raise an error if it could not be found.
=20
@@ -268,16 +268,19 @@ (define names
(else chr)))
module))))
=20
- (match (find-files directory
- (lambda (file stat)
- (member (strip-extension
- (basename file)) names)))
+ (match (append-map (lambda (directory)
+ (find-files directory
+ (lambda (file _stat)
+ (member (strip-extension
+ (basename file))
+ names))))
+ directories)
((file)
file)
(()
- (error "kernel module not found" module directory))
+ (error "kernel module not found" module directories))
((_ ...)
- (error "several modules by that name" module directory))))
+ (error "several modules by that name" module directories))))
=20
(define* (recursive-module-dependencies files
#:key (lookup-module dot-ko))
diff --git a/gnu/system.scm b/gnu/system.scm
index 8df871f255..1921b60c25 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -1373,6 +1373,8 @@ (define make-initrd
#:linux (operating-system-kernel os)
#:linux-modules
(operating-system-initrd-modules os)
+ #:linux-extra-module-directories
+ (operating-system-kernel-loadable-modules os)
#:mapped-devices mapped-devices
#:keyboard-layout (operating-system-keyboard-layout os)))
=20
diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm
index dc08edc791..dab40dfe22 100644
--- a/gnu/system/linux-initrd.scm
+++ b/gnu/system/linux-initrd.scm
@@ -120,13 +120,20 @@ (define builder
`(#:references-graphs (("closure" ,init))))
"/initrd.cpio.gz"))
=20
-(define (flat-linux-module-directory linux modules)
+(define (flat-linux-module-directory packages modules)
"Return a flat directory containing the Linux kernel modules listed in
-MODULES and taken from LINUX."
+MODULES and taken from PACKAGES."
(define imported-modules
(source-module-closure '((gnu build linux-modules)
(guix build utils))))
=20
+ (define package-inputs
+ (map (lambda (p)
+ (match p
+ ((p o) (gexp-input p o))
+ (p (gexp-input p "out"))))
+ packages))
+
(define build-exp
(with-imported-modules imported-modules
(with-extensions (list guile-zlib guile-zstd)
@@ -138,8 +145,9 @@ (define build-exp
(srfi srfi-26)
(ice-9 match))
=20
- (define module-dir
- (string-append #$linux "/lib/modules"))
+ (define module-dirs
+ (map (cut string-append <> "/lib/modules")
+ '#$package-inputs))
=20
(define builtin-modules
(match (find-files module-dir (lambda (file stat)
@@ -157,7 +165,7 @@ (define modules-to-lookup
(lset-difference string=3D? '#$modules builtin-modules))
=20
(define modules
- (let* ((lookup (cut find-module-file module-dir <>))
+ (let* ((lookup (cut find-module-file module-dirs <>))
(modules (map lookup modules-to-lookup)))
(append modules
(recursive-module-dependencies
@@ -192,6 +200,7 @@ (define* (raw-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-directories '())
(pre-mount #t)
(mapped-devices '())
(keyboard-layout #f)
@@ -199,15 +208,16 @@ (define* (raw-initrd file-systems
qemu-networking?
volatile-root?
(on-error 'debug))
- "Return as a file-like object a raw initrd, with kernel
-modules taken from LINUX. FILE-SYSTEMS is a list of file-systems to be
-mounted by the initrd, possibly in addition to the root file system specif=
ied
-on the kernel command line via 'root'. LINUX-MODULES is a list of kernel
-modules to be loaded at boot time. MAPPED-DEVICES is a list of device
-mappings to realize before FILE-SYSTEMS are mounted. PRE-MOUNT is a
-G-expression to evaluate before realizing MAPPED-DEVICES.
-HELPER-PACKAGES is a list of packages to be copied in the initrd. It may i=
nclude
-e2fsck/static or other packages needed by the initrd to check root partiti=
on.
+ "Return as a file-like object a raw initrd, with kernel modules taken fr=
om
+LINUX. FILE-SYSTEMS is a list of file-systems to be mounted by the initrd=
,
+possibly in addition to the root file system specified on the kernel comma=
nd
+line via 'root'. LINUX-MODULES is a list of kernel modules to be loaded a=
t
+boot time. LINUX-EXTRA-MODULE-DIRECTORIES is a list of file-like objects w=
hich
+will be searched for modules in addition to the linux kernel. MAPPED-DEVIC=
ES
+is a list of device mappings to realize before FILE-SYSTEMS are mounted.
+HELPER-PACKAGES is a list of packages to be copied in the initrd. It may
+include e2fsck/static or other packages needed by the initrd to check root
+partition.
=20
When true, KEYBOARD-LAYOUT is a <keyboard-layout> record denoting the desi=
red
console keyboard layout. This is done before MAPPED-DEVICES are set up an=
d
@@ -243,7 +253,8 @@ (define file-system-scan-commands
#~())))
=20
(define kodir
- (flat-linux-module-directory linux linux-modules))
+ (flat-linux-module-directory (cons linux linux-extra-module-directorie=
s)
+ linux-modules))
=20
(expression->initrd
(with-imported-modules (source-module-closure
@@ -390,6 +401,7 @@ (define* (base-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-directories '())
(mapped-devices '())
(keyboard-layout #f)
qemu-networking?
@@ -410,9 +422,10 @@ (define* (base-initrd file-systems
QEMU-NETWORKING? and VOLATILE-ROOT? behaves as in raw-initrd.
=20
The initrd is automatically populated with all the kernel modules necessar=
y
-for FILE-SYSTEMS and for the given options. Additional kernel
-modules can be listed in LINUX-MODULES. They will be added to the initrd,=
and
-loaded at boot time in the order in which they appear."
+for FILE-SYSTEMS and for the given options. Additional kernel modules can=
be
+listed in LINUX-MODULES. Additional directories for modules can be listed=
in
+LINUX-EXTRA-MODULE-DIRECTORIES. They will be added to the initrd, and loa=
ded
+at boot time in the order in which they appear."
(define linux-modules*
;; Modules added to the initrd and loaded from the initrd.
`(,@linux-modules
@@ -432,6 +445,7 @@ (define helper-packages
(raw-initrd file-systems
#:linux linux
#:linux-modules linux-modules*
+ #:linux-extra-module-directories linux-extra-module-director=
ies
#:mapped-devices mapped-devices
#:helper-packages helper-packages
#:keyboard-layout keyboard-layout
--=20
2.47.1
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 26 May 2024 19:02:18 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 26 15:02:18 2024 Received: from localhost ([127.0.0.1]:42588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sBJ8M-0006Bl-DY for submit <at> debbugs.gnu.org; Sun, 26 May 2024 15:02:18 -0400 Received: from mail-4322.protonmail.ch ([185.70.43.22]:30379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <kaelyn.alexi@HIDDEN>) id 1sBJ8I-0006BN-Tx for 55231 <at> debbugs.gnu.org; Sun, 26 May 2024 15:02:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1716750120; x=1717009320; bh=sCHOjISGidDRr8OuLoudIJde2wI/IEecgs37zve2a3c=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=BaVZjMX8on7HaXgzxnr6sJoGX2brQecbp1qCfcFB43e1RynbeF1MmIYSRg3OAXsEe sqhJJ5UdrJ1NoyB0Fcy4PPt1lu7CSEGiZsT8m14H1SNBmR2RFgz+BRNltgLGXOau1u bfDLA51oxp19xFxqWI31WA9XgnJp5kiY1VhdoJGez3bkfXoUFNOn22FWNhHo6EFedD QZBep/lbRjMDSPsneXdO/a95+5Tnc9/YfCMCTIa9A5MtLHNZHjYnbdDOrSpzPtZTRq a97IYiBrHpJqbzx9Sz0y0bhR2MoerheiK6261ucYriJFTqexOCzNFfjoPTZ323UI9r TVXDXWptuTjkg== Date: Sun, 26 May 2024 19:01:56 +0000 To: "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> From: Kaelyn <kaelyn.alexi@HIDDEN> Subject: =?utf-8?Q?Re:_[bug#55231][PATCH_v1]_initrd:_Allow_extra_search_paths_with_=E2=80=98initrd-extra-module-paths=E2=80=99?= Message-ID: <1tDxflmRvH9dG_XKzC_f96MeCAhzXoO3N5eKXVzaG01-pUYy2LKGjpKh6AgtQgMEQgggJKgJ_pZylYEQWZxbYFQ0kiCh4VAU4BxGOeXr4Zk=@protonmail.com> Feedback-ID: 34709329:user:proton X-Pm-Message-ID: 723d3f989635ba77dd905f5890727851dcf3a650 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 55231 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi, I just want to say that the latest v4 of the patches look good to me, and h= as removed the example with the questionable licensing situation. I have al= so been using this patch quite successfully, in a slightly modified version= (mostly module name changes) imported into a local channel, for almost 2 y= ears now. Also, if needed, I would be happy to rebase the patches against the current= master. Cheers, Kaelyn
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 24 Jun 2022 13:28:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 24 09:28:47 2022
Received: from localhost ([127.0.0.1]:41428 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1o4jMd-0005SN-HG
for submit <at> debbugs.gnu.org; Fri, 24 Jun 2022 09:28:47 -0400
Received: from coleridge.kublai.com ([166.84.7.167]:52568 helo=mail.spork.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjc@HIDDEN>) id 1o4jMT-0005Ru-QZ
for 55231 <at> debbugs.gnu.org; Fri, 24 Jun 2022 09:28:42 -0400
Received: from psyduck.jhoto.kublai.com (ool-18b8e9e7.dyn.optonline.net
[24.184.233.231])
by mail.spork.org (Postfix) with ESMTPSA id 96EDB3E11;
Fri, 24 Jun 2022 09:28:37 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim;
t=1656077317; bh=bOBi/e8drletEjC3kmo7KDSQNKfcz5WkXNnad3E8Glo=;
h=From:To:Cc:Subject:Date:In-Reply-To:References;
b=a8PIyleX1B7snw+rMOsCr0kVWzp5F5YuE8edpr5WF9Wb3mBmGW8shT1kW/TSuhGmL
sMk76pjPMMwJuSuTIvKeXIuzlsZgQnsuhQIHLxQAhb6WLlVJxlpbQF8CSfTOA83RJq
1TziiQUuLwZE+YGi7niFxTC6xMAoHRKQlW50NCL0=
From: Brian Cully <bjc@HIDDEN>
To: 55231 <at> debbugs.gnu.org
Subject: [PATCH v4 2/2] =?UTF-8?q?doc:=20=E2=80=98initrd-modules=E2=80=99?=
=?UTF-8?q?=20will=20search=20=E2=80=98kernel-loadable-modules=E2=80=99.?=
Date: Fri, 24 Jun 2022 09:28:26 -0400
Message-Id: <decfa9ca4ff55b14673e7b1013ceac4cb3bf9371.1656077306.git.bjc@HIDDEN>
X-Mailer: git-send-email 2.36.1
In-Reply-To: <10a6842d1a6bde797d82d6b8107660bedce8b956.1656077306.git.bjc@HIDDEN>
References: <10a6842d1a6bde797d82d6b8107660bedce8b956.1656077306.git.bjc@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: Brian Cully <bjc@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
---
doc/guix.texi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/doc/guix.texi b/doc/guix.texi
index eda0956260..7c4682a76d 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -36461,6 +36461,21 @@ Initial RAM Disk
(initrd-modules (cons "megaraid_sas" %base-initrd-modules)))
@end lisp
+If a module listed in @code{initrd-modules} is not included in the
+Linux-libre kernel, then the location to it must be added to the
+@code{kernel-loadable-modules} list.
+
+For example, if you need the driver for a Realtek RTL8821CE wireless
+network adapter for mounting the root filesystem over NFS, your
+configuration might include the following:
+
+@lisp
+(operating-system
+ ;; @dots{}
+ (initrd-modules (cons "8821ce" %base-initrd-modules))
+ (kernel-loadable-modules (list (list rtl8821ce-linux-module "module"))))
+@end lisp
+
@defvr {Scheme Variable} %base-initrd-modules
This is the list of kernel modules included in the initrd by default.
@end defvr
--
2.36.1
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 24 Jun 2022 13:28:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 24 09:28:43 2022
Received: from localhost ([127.0.0.1]:41426 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1o4jMY-0005S9-VU
for submit <at> debbugs.gnu.org; Fri, 24 Jun 2022 09:28:43 -0400
Received: from coleridge.kublai.com ([166.84.7.167]:52185 helo=mail.spork.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjc@HIDDEN>) id 1o4jMT-0005Rt-PR
for 55231 <at> debbugs.gnu.org; Fri, 24 Jun 2022 09:28:41 -0400
Received: from psyduck.jhoto.kublai.com (ool-18b8e9e7.dyn.optonline.net
[24.184.233.231])
by mail.spork.org (Postfix) with ESMTPSA id 6C6023E10;
Fri, 24 Jun 2022 09:28:34 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim;
t=1656077317; bh=3ymhSD1c1tgxvfw5SNMjaMK8QYFGxB1yrY7XpGgiaHs=;
h=From:To:Cc:Subject:Date;
b=XolVBZib3Ntq5eeO0x8PDjIX0EtC0Cg4/qqEeoj8nxcWL7VY2gNXpliRrog0Ix4er
o8mdeQXsqgv6/efnkXSZ/Tu84Cbs3K/+MhHnXbjBodrk3PCaJaUfWIzjBS3XjR/EXC
NDnQSSEfl8ckdyjczU9+pOTF8lYUNoJbn3QkqqI0=
From: Brian Cully <bjc@HIDDEN>
To: 55231 <at> debbugs.gnu.org
Subject: [PATCH v4 1/2] Allows copying of out-of-tree modules to the Linux
initrd.
Date: Fri, 24 Jun 2022 09:28:25 -0400
Message-Id: <10a6842d1a6bde797d82d6b8107660bedce8b956.1656077306.git.bjc@HIDDEN>
X-Mailer: git-send-email 2.36.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: Brian Cully <bjc@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
With this patch, modules for ‘initrd-modules’ will not only be searched for in
the in-tree Linux modules, but also any additional modules specified in
‘kernel-loadable-modules’.
* gnu/build/linux-modules.scm (find-module-file): change DIRECTORY argument to
DIRECTORIES. Now takes a list of directories to search, rather than a single
one.
* gnu/system/linux-initrd.scm (flat-linux-module-directory): change LINUX
argument to PACKAGES. Now contains a list of file-likes to search for modules.
(raw-initrd): Add LINUX-EXTRA-MODULE-DIRECTORIES keyword argument. Pass it
to (flat-linux-module-directory) along with the selected LINUX package.
(base-initrd): Add LINUX-EXTRA-MODULE-DIRECTORIES keyword argument. Pass it
to (raw-initrd).
* gnu/system.scm (operating-system-initrd-file): pass in operating system
definition's kernel-loadable-modules into (make-initrd) as
LINUX-EXTRA-MODULE-DIRECTORIES.
---
gnu/build/linux-modules.scm | 19 ++++++++------
gnu/system.scm | 2 ++
gnu/system/linux-initrd.scm | 49 ++++++++++++++++++++++++-------------
3 files changed, 45 insertions(+), 25 deletions(-)
diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scm
index 053720574b..97b7e429ea 100644
--- a/gnu/build/linux-modules.scm
+++ b/gnu/build/linux-modules.scm
@@ -225,8 +225,8 @@ (define (file-name->module-name file)
'.ko[.gz|.xz]' and normalizing it."
(normalize-module-name (strip-extension (basename file))))
-(define (find-module-file directory module)
- "Lookup module NAME under DIRECTORY, and return its absolute file name.
+(define (find-module-file directories module)
+ "Lookup module NAME under DIRECTORIES, and return its absolute file name.
NAME can be a file name with or without '.ko', or it can be a module name.
Raise an error if it could not be found.
@@ -247,16 +247,19 @@ (define (find-module-file directory module)
(else chr)))
module))))
- (match (find-files directory
- (lambda (file stat)
- (member (strip-extension
- (basename file)) names)))
+ (match (append-map (lambda (directory)
+ (find-files directory
+ (lambda (file _stat)
+ (member (strip-extension
+ (basename file))
+ names))))
+ directories)
((file)
file)
(()
- (error "kernel module not found" module directory))
+ (error "kernel module not found" module directories))
((_ ...)
- (error "several modules by that name" module directory))))
+ (error "several modules by that name" module directories))))
(define* (recursive-module-dependencies files
#:key (lookup-module dot-ko))
diff --git a/gnu/system.scm b/gnu/system.scm
index ba1b7b5152..2439560671 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -1313,6 +1313,8 @@ (define (operating-system-initrd-file os)
#:linux (operating-system-kernel os)
#:linux-modules
(operating-system-initrd-modules os)
+ #:linux-extra-module-directories
+ (operating-system-kernel-loadable-modules os)
#:mapped-devices mapped-devices
#:keyboard-layout (operating-system-keyboard-layout os)))
diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm
index 4c4c78e444..f6e8f75efa 100644
--- a/gnu/system/linux-initrd.scm
+++ b/gnu/system/linux-initrd.scm
@@ -119,13 +119,20 @@ (define* (expression->initrd exp
`(#:references-graphs (("closure" ,init))))
"/initrd.cpio.gz"))
-(define (flat-linux-module-directory linux modules)
+(define (flat-linux-module-directory packages modules)
"Return a flat directory containing the Linux kernel modules listed in
-MODULES and taken from LINUX."
+MODULES and taken from PACKAGES."
(define imported-modules
(source-module-closure '((gnu build linux-modules)
(guix build utils))))
+ (define package-inputs
+ (map (lambda (p)
+ (match p
+ ((p o) (gexp-input p o))
+ (p (gexp-input p "out"))))
+ packages))
+
(define build-exp
(with-imported-modules imported-modules
(with-extensions (list guile-zlib)
@@ -135,11 +142,12 @@ (define (flat-linux-module-directory linux modules)
(srfi srfi-1)
(srfi srfi-26))
- (define module-dir
- (string-append #$linux "/lib/modules"))
+ (define module-dirs
+ (map (cut string-append <> "/lib/modules")
+ '#$package-inputs))
(define modules
- (let* ((lookup (cut find-module-file module-dir <>))
+ (let* ((lookup (cut find-module-file module-dirs <>))
(modules (map lookup '#$modules)))
(append modules
(recursive-module-dependencies
@@ -172,20 +180,23 @@ (define* (raw-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-directories '())
(mapped-devices '())
(keyboard-layout #f)
(helper-packages '())
qemu-networking?
volatile-root?
(on-error 'debug))
- "Return as a file-like object a raw initrd, with kernel
-modules taken from LINUX. FILE-SYSTEMS is a list of file-systems to be
-mounted by the initrd, possibly in addition to the root file system specified
-on the kernel command line via 'root'. LINUX-MODULES is a list of kernel
-modules to be loaded at boot time. MAPPED-DEVICES is a list of device
-mappings to realize before FILE-SYSTEMS are mounted.
-HELPER-PACKAGES is a list of packages to be copied in the initrd. It may include
-e2fsck/static or other packages needed by the initrd to check root partition.
+ "Return as a file-like object a raw initrd, with kernel modules taken from
+LINUX. FILE-SYSTEMS is a list of file-systems to be mounted by the initrd,
+possibly in addition to the root file system specified on the kernel command
+line via 'root'. LINUX-MODULES is a list of kernel modules to be loaded at
+boot time. LINUX-EXTRA-MODULE-DIRECTORIES is a list of file-like objects which
+will be searched for modules in addition to the linux kernel. MAPPED-DEVICES
+is a list of device mappings to realize before FILE-SYSTEMS are mounted.
+HELPER-PACKAGES is a list of packages to be copied in the initrd. It may
+include e2fsck/static or other packages needed by the initrd to check root
+partition.
When true, KEYBOARD-LAYOUT is a <keyboard-layout> record denoting the desired
console keyboard layout. This is done before MAPPED-DEVICES are set up and
@@ -221,7 +232,8 @@ (define* (raw-initrd file-systems
#~())))
(define kodir
- (flat-linux-module-directory linux linux-modules))
+ (flat-linux-module-directory (cons linux linux-extra-module-directories)
+ linux-modules))
(expression->initrd
(with-imported-modules (source-module-closure
@@ -366,6 +378,7 @@ (define* (base-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-directories '())
(mapped-devices '())
(keyboard-layout #f)
qemu-networking?
@@ -386,9 +399,10 @@ (define* (base-initrd file-systems
QEMU-NETWORKING? and VOLATILE-ROOT? behaves as in raw-initrd.
The initrd is automatically populated with all the kernel modules necessary
-for FILE-SYSTEMS and for the given options. Additional kernel
-modules can be listed in LINUX-MODULES. They will be added to the initrd, and
-loaded at boot time in the order in which they appear."
+for FILE-SYSTEMS and for the given options. Additional kernel modules can be
+listed in LINUX-MODULES. Additional directories for modules can be listed in
+LINUX-EXTRA-MODULE-DIRECTORIES. They will be added to the initrd, and loaded
+at boot time in the order in which they appear."
(define linux-modules*
;; Modules added to the initrd and loaded from the initrd.
`(,@linux-modules
@@ -408,6 +422,7 @@ (define* (base-initrd file-systems
(raw-initrd file-systems
#:linux linux
#:linux-modules linux-modules*
+ #:linux-extra-module-directories linux-extra-module-directories
#:mapped-devices mapped-devices
#:helper-packages helper-packages
#:keyboard-layout keyboard-layout
--
2.36.1
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 21 Jun 2022 12:34:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 21 08:34:35 2022
Received: from localhost ([127.0.0.1]:59373 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1o3d5X-0005h4-D9
for submit <at> debbugs.gnu.org; Tue, 21 Jun 2022 08:34:35 -0400
Received: from mail-4325.protonmail.ch ([185.70.43.25]:58017)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <kaelyn.alexi@HIDDEN>) id 1o3d5V-0005go-Bi
for 55231 <at> debbugs.gnu.org; Tue, 21 Jun 2022 08:34:34 -0400
Date: Tue, 21 Jun 2022 12:34:19 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
s=protonmail3; t=1655814866; x=1656074066;
bh=RcCjdQpzNims8V/52k3pCzRbefUV5GFZ8NW3cZDtH9M=;
h=Date:To:From:Reply-To:Subject:Message-ID:Feedback-ID:From:To:Cc:
Date:Subject:Reply-To:Feedback-ID:Message-ID;
b=NOmTzVtFsQxh9s0XDg2SVPM24AlDkkiNcgPn1NuBpMUYb5kRwoUDTvGKFcbHrpozb
d+nEcVfY0/YXeUWk2mL9XmUxniG8z9bEWhr12kuJX6N3+zTDRsUpAq9upkvR2qAqGh
OHH48ByC7Kyox2YeT2lAVd9ew74iUIzLqSd2PHZ7bCYdElfTuKt9+4tCW+8EwCHo02
TzNdxkVi+c65ourXaalJjIr6adM5UZXd9+gyYY6ZmYrQXyj9uXRSqF9UmFYntuNNAG
hjdhXv8+l8iEoLSzU1zYuU7uFjAZFhdoU85IxjLgEpGh4aFxWesZBaR+Pjk9dXZHtQ
Uch7Y5oEoKFXg==
To: "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org>
From: Kaelyn <kaelyn.alexi@HIDDEN>
Subject: =?utf-8?Q?Re:_[bug#55231][PATCH_v1]_initrd:_Allow_extra_search_paths_with_=E2=80=98initrd-extra-module-paths=E2=80=99?=
Message-ID: <62rRCnWUAiOvJIODcOCnx0Vw7EUYR3YHxLrkEfMBUHjURBOWn_JfZf76LODMt2W8syVn0hnIaeU4ysQ-kfi5-4X3wyM7oGTnOO4t2JPwRzY=@protonmail.com>
Feedback-ID: 34709329:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 55231
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: Kaelyn <kaelyn.alexi@HIDDEN>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi again,
Regarding the documentation example, one (contrived) alternative is:
"""
For example, if you need the driver for a Realtek RTL8821CE wireless networ=
k adapter for mounting the root filesystem over NFS, your configuration mig=
ht include the following:
@lisp
(operating-system
;; @dots{}
(initrd-modules (cons "8821ce" %base-initrd-modules))
(kernel-loadable-modules (list (list rtl8821ce-linux-module "module"))))
@end lisp
"""
While I don't have the hardware, I did verify the kernel module name by bui=
lding the rtl8821ce-linux-module package.
Cheers,
Kaelyn
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 19 Jun 2022 12:06:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 19 08:06:02 2022 Received: from localhost ([127.0.0.1]:50761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1o2tgo-0005WG-AH for submit <at> debbugs.gnu.org; Sun, 19 Jun 2022 08:06:02 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:51562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maximedevos@HIDDEN>) id 1o2tgm-0005Vz-Db for 55231 <at> debbugs.gnu.org; Sun, 19 Jun 2022 08:06:01 -0400 Received: from [172.20.10.9] ([188.189.158.25]) by laurent.telenet-ops.be with bizsmtp id l05y270020Z9yEL0105y8g; Sun, 19 Jun 2022 14:05:59 +0200 Message-ID: <23328359aaef00b461b27e46b5e716655a8ff015.camel@HIDDEN> Subject: Re: [bug#55231] [PATCH v3 2/2] doc: =?UTF-8?Q?=E2=80=98initrd-modules=E2=80=99?= will search =?UTF-8?Q?=E2=80=98kernel-loadable-modules=E2=80=99=2E?= From: Maxime Devos <maximedevos@HIDDEN> To: Brian Cully <bjc@HIDDEN> Date: Sun, 19 Jun 2022 14:05:50 +0200 In-Reply-To: <878rpt5zmq.fsf@HIDDEN> References: <10a6842d1a6bde797d82d6b8107660bedce8b956.1655579477.git.bjc@HIDDEN> <65cf1060a7ce60b1b91a25f809af6264abdcfa59.1655579477.git.bjc@HIDDEN> <d9e2175bb610845bc2ab662eaff69d439e03f1a1.camel@HIDDEN> <87czf566hu.fsf@HIDDEN> <45da2e782470b7bc69fd3014a8c9ced154a58e49.camel@HIDDEN> <878rpt5zmq.fsf@HIDDEN> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-yJcvYuLTN0IDVCQjZK6E" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1655640359; bh=DSXcKN5qbZWeRnlRw5Zx6iigLa3vzAV62lC5U0XUUsY=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=mSVGzfC3GdPvni9KGSfnI+K3tLrGdxU6nvXMkgPDeaUgokW41RSjfJkYZgIDLD04J IQGIAbs6tzCiWIPmNWaAAFh/dPSrbEptK1C9A8ENIKYPKQMZYa/hDs7xtjAKMrRsuJ JE0LippUtCznlFN6pTvOXNWGwdIcuMxhuoDc3f5FX5QpVnlGc+86EqD9CH9/Sip2A6 rKFDJ4vyXt96ej3m9SdHj2TuOyL1JKVbgW3jEyFxtDGSwKl4DAvdHIgXzkoFr6Fp/N uvwtdVcgBfAHRlGJOaIROy8+4sW2UL48VMpHmx/I8V0MabA4vCO8EUxr1Vtn7c3Ctz IZiezPxlJakeg== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: 55231 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-yJcvYuLTN0IDVCQjZK6E Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Brian Cully schreef op za 18-06-2022 om 19:11 [-0400]: > So, simply using ZFS in =E2=80=98kernel-loadable-modules=E2=80=99 would b= e enough=20 > to trigger this misbehavior? That sounds like a pretty serious=20 > issue. Would it be possible to have the substitute servers filter=20 > on the #:substitutable flag? That's exactly what the #:substitutable flag is for (IIUC)! However, the problem is that currently, that flag isn't set for derivations that make a copy of the ZFS module. As I wrote previously: > > and IIUC, the code inside expression->initrd copies the kernel > > module into the new store item, > This is getting out of scope, though. I don't really want this=20 > patch to go in without /some/ documentation regarding how modules=20 > get looked up, so if anyone has an alternate module and use-case,=20 > I'll just swap it in for the ZFS one. I don't have any. Greetings, Maxime. --=-yJcvYuLTN0IDVCQjZK6E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYq8RHhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7ryiAQCxJDyPWK8uOhO8EAe6QkxQ4VVJ 5x6qwjNw/pYnZctswQD/TqLj9GzZ0VfrT1S4sot56loPrdZ0aBiehxkpKBhOBw8= =a5R3 -----END PGP SIGNATURE----- --=-yJcvYuLTN0IDVCQjZK6E--
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 18 Jun 2022 23:19:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 18 19:19:01 2022 Received: from localhost ([127.0.0.1]:50350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1o2hiX-0006wm-O6 for submit <at> debbugs.gnu.org; Sat, 18 Jun 2022 19:19:01 -0400 Received: from coleridge.kublai.com ([166.84.7.167]:63516 helo=mail.spork.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <bjc@HIDDEN>) id 1o2hiT-0006wO-2Z for 55231 <at> debbugs.gnu.org; Sat, 18 Jun 2022 19:19:00 -0400 Received: from ditto (ool-18b8e9e7.dyn.optonline.net [24.184.233.231]) by mail.spork.org (Postfix) with ESMTPSA id C22503437; Sat, 18 Jun 2022 19:18:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1655594336; bh=m1vdiC0HdRqzm16r6l/HoXWLR+aDmE2gFGzZ+465G1U=; h=References:From:To:Cc:Subject:Date:In-reply-to; b=bHreHiC8jmczuLLG8F/5ePuYh3MYz+12+PQfc1hO6Oxc0eWl4FRHbnf2Mz1mlw1P8 RFk/SNfTRkXPDyUa8ffV7Scw7pvMxB4snyv/Fm2hW4szjJaHPhTj7R+Q+vHPAQDiJK wMkr3JgBFVaU/su/jyjOHWYUj7RBJxod+PBR5UM4= References: <10a6842d1a6bde797d82d6b8107660bedce8b956.1655579477.git.bjc@HIDDEN> <65cf1060a7ce60b1b91a25f809af6264abdcfa59.1655579477.git.bjc@HIDDEN> <d9e2175bb610845bc2ab662eaff69d439e03f1a1.camel@HIDDEN> <87czf566hu.fsf@HIDDEN> <45da2e782470b7bc69fd3014a8c9ced154a58e49.camel@HIDDEN> User-agent: mu4e 1.6.11; emacs 28.1 From: Brian Cully <bjc@HIDDEN> To: Maxime Devos <maximedevos@HIDDEN> Subject: Re: [bug#55231] [PATCH v3 2/2] doc: =?utf-8?Q?=E2=80=98initrd-mod?= =?utf-8?Q?ules=E2=80=99?= will search =?utf-8?Q?=E2=80=98kernel-loadable-modules=E2=80=99=2E?= Date: Sat, 18 Jun 2022 19:11:28 -0400 In-reply-to: <45da2e782470b7bc69fd3014a8c9ced154a58e49.camel@HIDDEN> Message-ID: <878rpt5zmq.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: 55231 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Maxime Devos <maximedevos@HIDDEN> writes: > Because #:substitutable? isn't set appropriately in dependents, > substitute servers exist,=C2=A0ZFS can be used on substitute servers=20 > and > someone using the substitute server might have a sufficiently=20 > similar > system configuration to do substitution of a store item=20 > containing a > copy of the ZFS binary. So, simply using ZFS in =E2=80=98kernel-loadable-modules=E2=80=99 would be = enough=20 to trigger this misbehavior? That sounds like a pretty serious=20 issue. Would it be possible to have the substitute servers filter=20 on the #:substitutable flag? This is getting out of scope, though. I don't really want this=20 patch to go in without /some/ documentation regarding how modules=20 get looked up, so if anyone has an alternate module and use-case,=20 I'll just swap it in for the ZFS one. -bjc
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 18 Jun 2022 22:35:29 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 18 18:35:29 2022 Received: from localhost ([127.0.0.1]:50335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1o2h2P-0005uO-Jn for submit <at> debbugs.gnu.org; Sat, 18 Jun 2022 18:35:29 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:50802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maximedevos@HIDDEN>) id 1o2h2M-0005uC-Nj for 55231 <at> debbugs.gnu.org; Sat, 18 Jun 2022 18:35:28 -0400 Received: from [172.20.10.9] ([188.188.170.162]) by andre.telenet-ops.be with bizsmtp id kmbP2700b3Waito01mbQtC; Sun, 19 Jun 2022 00:35:25 +0200 Message-ID: <45da2e782470b7bc69fd3014a8c9ced154a58e49.camel@HIDDEN> Subject: Re: [bug#55231] [PATCH v3 2/2] doc: =?UTF-8?Q?=E2=80=98initrd-modules=E2=80=99?= will search =?UTF-8?Q?=E2=80=98kernel-loadable-modules=E2=80=99=2E?= From: Maxime Devos <maximedevos@HIDDEN> To: Brian Cully <bjc@HIDDEN> Date: Sun, 19 Jun 2022 00:34:45 +0200 In-Reply-To: <87czf566hu.fsf@HIDDEN> References: <10a6842d1a6bde797d82d6b8107660bedce8b956.1655579477.git.bjc@HIDDEN> <65cf1060a7ce60b1b91a25f809af6264abdcfa59.1655579477.git.bjc@HIDDEN> <d9e2175bb610845bc2ab662eaff69d439e03f1a1.camel@HIDDEN> <87czf566hu.fsf@HIDDEN> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-613Xt+bKSKaDnRq4HQyE" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1655591725; bh=g9XHJgoIBmuCo5DSp2k7QV0JCUjgIlATtnclPGbfowQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=jaQZmhZeaGNYGnZ4wHis9w40kMA/j15Z6lxNO3vhyJHQHVZ50Dg86L2m/41ulJ/5L shaLy9D93DeKuvVG5AsWXYQ/y4YcFLUQu8zG9ktoy+di8IGug3iokkmU8kwjMIhEl8 Z4oghgFv1vyB7gtH2ZtmbFPmeLCxoz2NMRZMMytFKMKVrCMm7slYKEuu44GlkkHpbW aWnWbupww+asqttdAsDHHXWqzZn1kpqD90cYhKYdD+Ta9BIlyp+yUsOMtlQjr4FhkL Rl5UPDWqSCBi1oO6wHGBcKffYBAB7VBa3W6CnYs7D/e78OVzSXyBAMkiIDI8ArEWhS PCvXVRvkbdjrw== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: 55231 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-613Xt+bKSKaDnRq4HQyE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Brian Cully schreef op za 18-06-2022 om 16:43 [-0400]: > That said, I'm not sure how this would cause the module to be=20 > distributed as a binary. [...] Because #:substitutable? isn't set appropriately in dependents, substitute servers exist,=C2=A0ZFS can be used on substitute servers and someone using the substitute server might have a sufficiently similar system configuration to do substitution of a store item containing a copy of the ZFS binary. Greetings, Maxime. --=-613Xt+bKSKaDnRq4HQyE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYq5TBRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hp7AQCihs5fFUXl54bTaZgaSYFETXaw UNZbSrcVKTEp4xPvpAD/T1Xx/Un/AzQKpEh3zZvofBsPncHBsb9ASaA6PfhkNAw= =POZ3 -----END PGP SIGNATURE----- --=-613Xt+bKSKaDnRq4HQyE--
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 18 Jun 2022 20:50:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 18 16:50:46 2022 Received: from localhost ([127.0.0.1]:50258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1o2fP4-0003PR-Eh for submit <at> debbugs.gnu.org; Sat, 18 Jun 2022 16:50:46 -0400 Received: from coleridge.kublai.com ([166.84.7.167]:51070 helo=mail.spork.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <bjc@HIDDEN>) id 1o2fOz-0003PH-Nk for 55231 <at> debbugs.gnu.org; Sat, 18 Jun 2022 16:50:45 -0400 Received: from ditto (ool-18b8e9e7.dyn.optonline.net [24.184.233.231]) by mail.spork.org (Postfix) with ESMTPSA id 62D813333; Sat, 18 Jun 2022 16:50:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1655585441; bh=QNFsAh5QHIeCLkfGNwF9sFpnzlK/S7ojeFOxSDValR8=; h=References:From:To:Cc:Subject:Date:In-reply-to; b=tExRmNp+bxHCnXbzK++2rnIYg9+nczqmS4s7OoA3AEn83GFwDIcqWHiqFObFujoCx Xn4Yb22yK3ns/511Nl9BEspwtLCkcNbzmf2tszBV1/RwOvqwXICbgU7fMpfmrWmAq8 Ggb8jBEOZRBcy7jxs+/NK6S+xbsYva8wQlREidaM= References: <10a6842d1a6bde797d82d6b8107660bedce8b956.1655579477.git.bjc@HIDDEN> <65cf1060a7ce60b1b91a25f809af6264abdcfa59.1655579477.git.bjc@HIDDEN> <d9e2175bb610845bc2ab662eaff69d439e03f1a1.camel@HIDDEN> User-agent: mu4e 1.6.11; emacs 28.1 From: Brian Cully <bjc@HIDDEN> To: Maxime Devos <maximedevos@HIDDEN> Subject: Re: [bug#55231] [PATCH v3 2/2] doc: =?utf-8?Q?=E2=80=98initrd-mod?= =?utf-8?Q?ules=E2=80=99?= will search =?utf-8?Q?=E2=80=98kernel-loadable-modules=E2=80=99=2E?= Date: Sat, 18 Jun 2022 16:43:33 -0400 In-reply-to: <d9e2175bb610845bc2ab662eaff69d439e03f1a1.camel@HIDDEN> Message-ID: <87czf566hu.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: 55231 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) > and because the defense for not considering the ZFS license to=20 > be a > problem consists of the ZFS module not being distributed in=20 > binary > form, whereas this suggestion would in some situations cause it=20 > to be > distributed in binary form. If you have another example, I'll put it in instead. I used this=20 one, because I know this one works, and that's all. That said, I'm not sure how this would cause the module to be=20 distributed as a binary. In order for it to be added to the=20 initrd, it will still need to built using the DKMS mechanism, and=20 thus compiled on (or at least for) the target Guix installation. If the complaint is that one could generate a USB stick, or some=20 such, with ZFS in the initrd, then yes, that's possible. But=20 that's also possible by using the existing=20 =E2=80=98kernel-loadable-modules=E2=80=99 mechanism to generate an image wi= th=20 =E2=80=98guix system image=E2=80=99 and distributing that. I don't think it= 's our=20 job to try and prevent such things, since, even if desirable, it's=20 not really feasible. If the complaint is merely that it's in the documentation, then=20 ok, I'll change it to whatever module you want. -bjc
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 18 Jun 2022 20:35:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 18 16:35:01 2022
Received: from localhost ([127.0.0.1]:50242 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1o2f9p-00030u-Ik
for submit <at> debbugs.gnu.org; Sat, 18 Jun 2022 16:35:01 -0400
Received: from baptiste.telenet-ops.be ([195.130.132.51]:39246)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1o2f9n-00030e-SN
for 55231 <at> debbugs.gnu.org; Sat, 18 Jun 2022 16:35:00 -0400
Received: from [172.20.10.9] ([188.188.170.162])
by baptiste.telenet-ops.be with bizsmtp
id kkax270033Waito01kaxHo; Sat, 18 Jun 2022 22:34:58 +0200
Message-ID: <d9e2175bb610845bc2ab662eaff69d439e03f1a1.camel@HIDDEN>
Subject: Re: [bug#55231] [PATCH v3 2/2] doc:
=?UTF-8?Q?=E2=80=98initrd-modules=E2=80=99?= will search
=?UTF-8?Q?=E2=80=98kernel-loadable-modules=E2=80=99=2E?=
From: Maxime Devos <maximedevos@HIDDEN>
To: Brian Cully <bjc@HIDDEN>, 55231 <at> debbugs.gnu.org
Date: Sat, 18 Jun 2022 22:34:53 +0200
In-Reply-To: <65cf1060a7ce60b1b91a25f809af6264abdcfa59.1655579477.git.bjc@HIDDEN>
References: <10a6842d1a6bde797d82d6b8107660bedce8b956.1655579477.git.bjc@HIDDEN>
<65cf1060a7ce60b1b91a25f809af6264abdcfa59.1655579477.git.bjc@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-uycy88wZ6DjEhcOLR/tY"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1655584498; bh=OBa65uVvyM4XmpomOsIhPqd+3DKGGtqLcbfTdJ/d2b4=;
h=Subject:From:To:Date:In-Reply-To:References;
b=lH8Li3Hwfcy1t52mVuQ9JrvV08dayt3mdAlR4Kc7GdCvBG54+zEN08I2pwHUhAiFj
6SCV4HfCsSxXPeU5DJlXWCSQfrTzWxUVLp4VjQSCoCS0RnP4EeynQDKYzPPAqdVcT0
PCjPoFsFde9se9DtbTa27wYBNKeGyxadNBGihC8YDMc2qPRA3jBu/qLWt9edU/2SOh
DrCvFlGZpXA/Srm5wNG2TU+z8AYKH3jjGyDvg1H8jbmvRJT/RJxvfopAhaL/YMfAiN
5a2zptAjKhYQOO9RBDV3+mwY0sNn2OxG2zqKkNpIlMAX+mMc0h2KUkjq73b/fTns24
kA81Smx+Z6FIQ==
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 55231
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-uycy88wZ6DjEhcOLR/tY
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Brian Cully via Guix-patches via schreef op za 18-06-2022 om 15:11 [-
0400]:
> +If a module listed in @code{initrd-modules} is not included in the
> +Linux-libre kernel, then the location to it must be added to the
> +@code{kernel-loadable-modules} list.=C2=A0 For example, if your root fil=
e
> +system exists on a ZFS pool, then your configuration might look like the
> +following:
> +
> +@lisp
> +(operating-system
> +=C2=A0 ;; @dots{}
> +=C2=A0 (initrd-modules (cons "zfs" %base-initrd-modules))
> +=C2=A0 (kernel-loadable-modules (list (list zfs "module"))))
> +@end lisp
As written previously, this is not a good example, because:
> As-is, I don't think this is a good example, because
> 'expression->initrd' does not set #:substitutable? #false,
> the 'zfs' package has the comment (*)
>=20
> `(;; The ZFS kernel module should not be downloaded since the
> license
> ;; terms don't allow for distributing it, only building it
> locally.
> #:substitutable? #f [...])
>=20
> and IIUC, the code inside expression->initrd copies the kernel module
> into the new store item, so it looks like this accidentally suggest
> people to commit copyvios, and copyvios are currently against the
> law.
and because the defense for not considering the ZFS license to be a
problem consists of the ZFS module not being distributed in binary
form, whereas this suggestion would in some situations cause it to be
distributed in binary form.
Greetings,
Maxime.
--=-uycy88wZ6DjEhcOLR/tY
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYq427RccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7vuRAP93e+IazsNTgVuVDhMRelp9dHd9
9osZoFuZBA8dInijdAEAscxvbiaqTecbAuzG+bVfZ7Vf5XaiqqzlGlCl7lHS7wM=
=gS+J
-----END PGP SIGNATURE-----
--=-uycy88wZ6DjEhcOLR/tY--
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 18 Jun 2022 19:13:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 18 15:13:22 2022
Received: from localhost ([127.0.0.1]:50038 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1o2dso-0000q9-91
for submit <at> debbugs.gnu.org; Sat, 18 Jun 2022 15:13:22 -0400
Received: from coleridge.kublai.com ([166.84.7.167]:61435 helo=mail.spork.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjc@HIDDEN>) id 1o2dsl-0000pu-Lr
for 55231 <at> debbugs.gnu.org; Sat, 18 Jun 2022 15:13:19 -0400
Received: from psyduck.jhoto.kublai.com (ool-18b8e9e7.dyn.optonline.net
[24.184.233.231])
by mail.spork.org (Postfix) with ESMTPSA id 7FE673262;
Sat, 18 Jun 2022 15:13:19 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim;
t=1655579599; bh=8Hj0+6AubqJc/k/UlmV9m/THDcoZ/oLyzmsaF1PAe8U=;
h=From:To:Cc:Subject:Date:In-Reply-To:References;
b=Jfye6PufZCK0phSgQjFpzTxoLjyNRtUtKRUwDj4Pklac924Pe6g0f4gjrbgGe+0gT
v4oUt9rZMGj/WelXc8hXsOjaOGcQmSxOqu5nIhWbdwIoE66ia9DjZUHELivdIZWWmy
viJbOjcysqODBBaM2g/YJ9lrepkKltfylPS4L96A=
From: Brian Cully <bjc@HIDDEN>
To: 55231 <at> debbugs.gnu.org
Subject: [PATCH v3 2/2] =?UTF-8?q?doc:=20=E2=80=98initrd-modules=E2=80=99?=
=?UTF-8?q?=20will=20search=20=E2=80=98kernel-loadable-modules=E2=80=99.?=
Date: Sat, 18 Jun 2022 15:11:18 -0400
Message-Id: <65cf1060a7ce60b1b91a25f809af6264abdcfa59.1655579477.git.bjc@HIDDEN>
X-Mailer: git-send-email 2.36.1
In-Reply-To: <10a6842d1a6bde797d82d6b8107660bedce8b956.1655579477.git.bjc@HIDDEN>
References: <10a6842d1a6bde797d82d6b8107660bedce8b956.1655579477.git.bjc@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: Brian Cully <bjc@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
---
doc/guix.texi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/doc/guix.texi b/doc/guix.texi
index eda0956260..d97909695f 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -36461,6 +36461,19 @@ Initial RAM Disk
(initrd-modules (cons "megaraid_sas" %base-initrd-modules)))
@end lisp
+If a module listed in @code{initrd-modules} is not included in the
+Linux-libre kernel, then the location to it must be added to the
+@code{kernel-loadable-modules} list. For example, if your root file
+system exists on a ZFS pool, then your configuration might look like the
+following:
+
+@lisp
+(operating-system
+ ;; @dots{}
+ (initrd-modules (cons "zfs" %base-initrd-modules))
+ (kernel-loadable-modules (list (list zfs "module"))))
+@end lisp
+
@defvr {Scheme Variable} %base-initrd-modules
This is the list of kernel modules included in the initrd by default.
@end defvr
--
2.36.1
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 18 Jun 2022 19:13:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 18 15:13:20 2022
Received: from localhost ([127.0.0.1]:50035 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1o2dsl-0000pt-JC
for submit <at> debbugs.gnu.org; Sat, 18 Jun 2022 15:13:20 -0400
Received: from coleridge.kublai.com ([166.84.7.167]:64925 helo=mail.spork.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjc@HIDDEN>) id 1o2dsf-0000pi-Ou
for 55231 <at> debbugs.gnu.org; Sat, 18 Jun 2022 15:13:17 -0400
Received: from psyduck.jhoto.kublai.com (ool-18b8e9e7.dyn.optonline.net
[24.184.233.231])
by mail.spork.org (Postfix) with ESMTPSA id 1926633AE;
Sat, 18 Jun 2022 15:13:10 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim;
t=1655579593; bh=F1VZwcsd7B/Nola2WyyesUnE8/NzZ9xsRP626NcddsA=;
h=From:To:Cc:Subject:Date;
b=mB+v1oDq34ayn7lI1Rqw92Qx+qX98Ajm+R46/xUFDKAHtLZoEfi5KEzfo0Byh43JR
sLQWjd+x51zBpjbcFthXl9d8Adpn4KveDeZrHznptMywXkgLczu1mUaY7LyKtMbVYm
Qpdj7TF4qyuX6YGqe/AVGHJ6rZIiuBpu4dYOxGJY=
From: Brian Cully <bjc@HIDDEN>
To: 55231 <at> debbugs.gnu.org
Subject: [PATCH v3 1/2] Allows copying of out-of-tree modules to the Linux
initrd.
Date: Sat, 18 Jun 2022 15:11:17 -0400
Message-Id: <10a6842d1a6bde797d82d6b8107660bedce8b956.1655579477.git.bjc@HIDDEN>
X-Mailer: git-send-email 2.36.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: Brian Cully <bjc@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
With this patch, modules for ‘initrd-modules’ will not only be searched for in
the in-tree Linux modules, but also any additional modules specified in
‘kernel-loadable-modules’.
* gnu/build/linux-modules.scm (find-module-file): change DIRECTORY argument to
DIRECTORIES. Now takes a list of directories to search, rather than a single
one.
* gnu/system/linux-initrd.scm (flat-linux-module-directory): change LINUX
argument to PACKAGES. Now contains a list of file-likes to search for modules.
(raw-initrd): Add LINUX-EXTRA-MODULE-DIRECTORIES keyword argument. Pass it
to (flat-linux-module-directory) along with the selected LINUX package.
(base-initrd): Add LINUX-EXTRA-MODULE-DIRECTORIES keyword argument. Pass it
to (raw-initrd).
* gnu/system.scm (operating-system-initrd-file): pass in operating system
definition's kernel-loadable-modules into (make-initrd) as
LINUX-EXTRA-MODULE-DIRECTORIES.
---
This version removes the redundant (package+out->input) procedure, and
renames ‘linux-extra-module-paths’ to ‘linux-extra-module-directories’.
gnu/build/linux-modules.scm | 19 ++++++++------
gnu/system.scm | 2 ++
gnu/system/linux-initrd.scm | 49 ++++++++++++++++++++++++-------------
3 files changed, 45 insertions(+), 25 deletions(-)
diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scm
index 053720574b..97b7e429ea 100644
--- a/gnu/build/linux-modules.scm
+++ b/gnu/build/linux-modules.scm
@@ -225,8 +225,8 @@ (define (file-name->module-name file)
'.ko[.gz|.xz]' and normalizing it."
(normalize-module-name (strip-extension (basename file))))
-(define (find-module-file directory module)
- "Lookup module NAME under DIRECTORY, and return its absolute file name.
+(define (find-module-file directories module)
+ "Lookup module NAME under DIRECTORIES, and return its absolute file name.
NAME can be a file name with or without '.ko', or it can be a module name.
Raise an error if it could not be found.
@@ -247,16 +247,19 @@ (define (find-module-file directory module)
(else chr)))
module))))
- (match (find-files directory
- (lambda (file stat)
- (member (strip-extension
- (basename file)) names)))
+ (match (append-map (lambda (directory)
+ (find-files directory
+ (lambda (file _stat)
+ (member (strip-extension
+ (basename file))
+ names))))
+ directories)
((file)
file)
(()
- (error "kernel module not found" module directory))
+ (error "kernel module not found" module directories))
((_ ...)
- (error "several modules by that name" module directory))))
+ (error "several modules by that name" module directories))))
(define* (recursive-module-dependencies files
#:key (lookup-module dot-ko))
diff --git a/gnu/system.scm b/gnu/system.scm
index ba1b7b5152..2439560671 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -1313,6 +1313,8 @@ (define (operating-system-initrd-file os)
#:linux (operating-system-kernel os)
#:linux-modules
(operating-system-initrd-modules os)
+ #:linux-extra-module-directories
+ (operating-system-kernel-loadable-modules os)
#:mapped-devices mapped-devices
#:keyboard-layout (operating-system-keyboard-layout os)))
diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm
index 4c4c78e444..f6e8f75efa 100644
--- a/gnu/system/linux-initrd.scm
+++ b/gnu/system/linux-initrd.scm
@@ -119,13 +119,20 @@ (define* (expression->initrd exp
`(#:references-graphs (("closure" ,init))))
"/initrd.cpio.gz"))
-(define (flat-linux-module-directory linux modules)
+(define (flat-linux-module-directory packages modules)
"Return a flat directory containing the Linux kernel modules listed in
-MODULES and taken from LINUX."
+MODULES and taken from PACKAGES."
(define imported-modules
(source-module-closure '((gnu build linux-modules)
(guix build utils))))
+ (define package-inputs
+ (map (lambda (p)
+ (match p
+ ((p o) (gexp-input p o))
+ (p (gexp-input p "out"))))
+ packages))
+
(define build-exp
(with-imported-modules imported-modules
(with-extensions (list guile-zlib)
@@ -135,11 +142,12 @@ (define (flat-linux-module-directory linux modules)
(srfi srfi-1)
(srfi srfi-26))
- (define module-dir
- (string-append #$linux "/lib/modules"))
+ (define module-dirs
+ (map (cut string-append <> "/lib/modules")
+ '#$package-inputs))
(define modules
- (let* ((lookup (cut find-module-file module-dir <>))
+ (let* ((lookup (cut find-module-file module-dirs <>))
(modules (map lookup '#$modules)))
(append modules
(recursive-module-dependencies
@@ -172,20 +180,23 @@ (define* (raw-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-directories '())
(mapped-devices '())
(keyboard-layout #f)
(helper-packages '())
qemu-networking?
volatile-root?
(on-error 'debug))
- "Return as a file-like object a raw initrd, with kernel
-modules taken from LINUX. FILE-SYSTEMS is a list of file-systems to be
-mounted by the initrd, possibly in addition to the root file system specified
-on the kernel command line via 'root'. LINUX-MODULES is a list of kernel
-modules to be loaded at boot time. MAPPED-DEVICES is a list of device
-mappings to realize before FILE-SYSTEMS are mounted.
-HELPER-PACKAGES is a list of packages to be copied in the initrd. It may include
-e2fsck/static or other packages needed by the initrd to check root partition.
+ "Return as a file-like object a raw initrd, with kernel modules taken from
+LINUX. FILE-SYSTEMS is a list of file-systems to be mounted by the initrd,
+possibly in addition to the root file system specified on the kernel command
+line via 'root'. LINUX-MODULES is a list of kernel modules to be loaded at
+boot time. LINUX-EXTRA-MODULE-DIRECTORIES is a list of file-like objects which
+will be searched for modules in addition to the linux kernel. MAPPED-DEVICES
+is a list of device mappings to realize before FILE-SYSTEMS are mounted.
+HELPER-PACKAGES is a list of packages to be copied in the initrd. It may
+include e2fsck/static or other packages needed by the initrd to check root
+partition.
When true, KEYBOARD-LAYOUT is a <keyboard-layout> record denoting the desired
console keyboard layout. This is done before MAPPED-DEVICES are set up and
@@ -221,7 +232,8 @@ (define* (raw-initrd file-systems
#~())))
(define kodir
- (flat-linux-module-directory linux linux-modules))
+ (flat-linux-module-directory (cons linux linux-extra-module-directories)
+ linux-modules))
(expression->initrd
(with-imported-modules (source-module-closure
@@ -366,6 +378,7 @@ (define* (base-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-directories '())
(mapped-devices '())
(keyboard-layout #f)
qemu-networking?
@@ -386,9 +399,10 @@ (define* (base-initrd file-systems
QEMU-NETWORKING? and VOLATILE-ROOT? behaves as in raw-initrd.
The initrd is automatically populated with all the kernel modules necessary
-for FILE-SYSTEMS and for the given options. Additional kernel
-modules can be listed in LINUX-MODULES. They will be added to the initrd, and
-loaded at boot time in the order in which they appear."
+for FILE-SYSTEMS and for the given options. Additional kernel modules can be
+listed in LINUX-MODULES. Additional directories for modules can be listed in
+LINUX-EXTRA-MODULE-DIRECTORIES. They will be added to the initrd, and loaded
+at boot time in the order in which they appear."
(define linux-modules*
;; Modules added to the initrd and loaded from the initrd.
`(,@linux-modules
@@ -408,6 +422,7 @@ (define* (base-initrd file-systems
(raw-initrd file-systems
#:linux linux
#:linux-modules linux-modules*
+ #:linux-extra-module-directories linux-extra-module-directories
#:mapped-devices mapped-devices
#:helper-packages helper-packages
#:keyboard-layout keyboard-layout
--
2.36.1
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 17 Jun 2022 20:35:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 17 16:35:01 2022 Received: from localhost ([127.0.0.1]:47054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1o2IgH-0000IU-G4 for submit <at> debbugs.gnu.org; Fri, 17 Jun 2022 16:35:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1o2IgF-0000IF-DB for 55231 <at> debbugs.gnu.org; Fri, 17 Jun 2022 16:35:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44356) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1o2Ig9-0002K2-TY; Fri, 17 Jun 2022 16:34:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=NJz4haW/cg2WS6PGmNGmiyZmt3u+4ucvnFUqTqPj5y8=; b=VNtUGY0WoT8ELPaoDi8G OlaGJDIGcPcf6aADcg52uYmeyR5iK7W5Vz/O2sjlm6CaiduPu/+ZUgxJ9ywyIWXdPsHvtCRvVHfT8 spEDW7Uai6OmpAv+/D9JNBMsTkxconDnig39MbqONfdSwPdcSDysHLetZ8YNZhJIuZ3lCeGEd3rxV dbm+IQH00j1tSxQ8mN2aDpNIeqkW2z2RmU7+yzaYUczolaprk+B2/exBhpPkEA3Svo/a33rjvn2VD wzK2g+dx9brsZW0+7f7Nd4lJxTzbTkOGSLLVfTLL/IiWiotLAAVLAkH4SDPzTwyD2g6IMm7Qx3Zg/ aUV3yIFXqR/yzA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:60076 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1o2Ig9-0006Iv-GB; Fri, 17 Jun 2022 16:34:53 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Brian Cully <bjc@HIDDEN> Subject: Re: bug#55231: [PATCH v1] initrd: Allow extra search paths with =?utf-8?Q?=E2=80=98initrd-extra-module-paths=E2=80=99?= References: <87wnf3pv87.fsf@HIDDEN> <88d91cf303fd82c3667149ee8a647527f44bf571.1655430718.git.bjc@HIDDEN> Date: Fri, 17 Jun 2022 22:34:51 +0200 In-Reply-To: <88d91cf303fd82c3667149ee8a647527f44bf571.1655430718.git.bjc@HIDDEN> (Brian Cully's message of "Thu, 16 Jun 2022 21:51:59 -0400") Message-ID: <878rpvdo5w.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55231 Cc: 55231 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi Brian, Brian Cully <bjc@HIDDEN> skribis: > With this patch, modules for =E2=80=98initrd-modules=E2=80=99 will not on= ly be searched for in > the in-tree Linux modules, but also any additional modules specified in > =E2=80=98kernel-loadable-modules=E2=80=99. > > * gnu/build/linux-modules.scm (find-module-file): change DIRECTORY argume= nt to > DIRECTORIES. Now takes a list of directories to search, rather than a sin= gle > one. > * gnu/system/linux-initrd.scm (flat-linux-module-directory): change LINUX > argument to PACKAGES. Now contains a list of file-likes to search for mod= ules. > (raw-initrd): Add LINUX-EXTRA-MODULE-PATHS keyword argument. Pass it > to (flat-linux-extra-module-paths) along with the selected LINUX package. > (base-initrd): Add LINUX-EXTRA-MODULE-PATHS keyword argument. Pass it > to (raw-initrd). > * gnu/system.scm (operating-system-initrd-file): pass in operating system > definition's kernel-loadable-modules into (make-initrd) as > LINUX-EXTRA-MODULE-PATHS. > --- > > I've removed the new operating-system slot in preference to re-using > kernel-loadable-modules, as discussed. > > I did leave the old argument names for the lower level routines in place, > as I feel that they more accurately represent how the data are being > used. > > I've also pulled out the documentation. Once this patch set is beaten > into acceptability, the documentation can be adjusted if that's deemed > necessary. Alright! It looks great to me. I have two cosmetic comments: > + (define (package+out->input package out) > + (gexp-input package out)) I think you can remove this definition and use =E2=80=98gexp-input=E2=80=99= directly. > @@ -172,20 +183,23 @@ (define* (raw-initrd file-systems > #:key > (linux linux-libre) > (linux-modules '()) > + (linux-extra-module-paths '()) Nitpick: I=E2=80=99d call it #:linux-extra-module-path (singular, as in =E2= =80=9Csearch path=E2=80=9D) or simply #:linux-extra-module-directories. If you could introduce a couple of lines in doc/guix.texi to explain where modules are searched for, that=E2=80=99d be perfect. Thanks for taking the time to prepare this revision! Ludo=E2=80=99.
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 17 Jun 2022 01:54:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 16 21:54:32 2022
Received: from localhost ([127.0.0.1]:43413 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1o21Bv-00056x-MQ
for submit <at> debbugs.gnu.org; Thu, 16 Jun 2022 21:54:32 -0400
Received: from coleridge.kublai.com ([166.84.7.167]:61636 helo=mail.spork.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjc@HIDDEN>) id 1o21Bt-00056o-E6
for 55231 <at> debbugs.gnu.org; Thu, 16 Jun 2022 21:54:30 -0400
Received: from psyduck.jhoto.kublai.com (ool-18b8e9e7.dyn.optonline.net
[24.184.233.231])
by mail.spork.org (Postfix) with ESMTPSA id D30182ED5;
Thu, 16 Jun 2022 21:54:28 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim;
t=1655430868; bh=bAGDRFoQXaijSpIrQ2E9pmzYBZAM01wSer3hcq0o/dU=;
h=From:To:Cc:Subject:Date;
b=oP8YnXBFILby+6wwOxtQhnW3mc5I/ERWxkt430P10UoHLzJhrTe2iE7gGD7/0CI8J
nzDLCfF9p4wjZaq/pl/6gZDLXy9WeRlU1mNAnEO0gloHLkkWzYQi9w22Omon6jDAJ3
rRIUovAqV73x1fKmtKd9VtS91AXDIfxHI8wOOaFA=
From: Brian Cully <bjc@HIDDEN>
To: 55231 <at> debbugs.gnu.org
Subject: [PATCH v2 1/2] Allows copying of out-of-tree modules to the Linux
initrd.
Date: Thu, 16 Jun 2022 21:51:59 -0400
Message-Id: <88d91cf303fd82c3667149ee8a647527f44bf571.1655430718.git.bjc@HIDDEN>
X-Mailer: git-send-email 2.36.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: Brian Cully <bjc@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
With this patch, modules for ‘initrd-modules’ will not only be searched for in
the in-tree Linux modules, but also any additional modules specified in
‘kernel-loadable-modules’.
* gnu/build/linux-modules.scm (find-module-file): change DIRECTORY argument to
DIRECTORIES. Now takes a list of directories to search, rather than a single
one.
* gnu/system/linux-initrd.scm (flat-linux-module-directory): change LINUX
argument to PACKAGES. Now contains a list of file-likes to search for modules.
(raw-initrd): Add LINUX-EXTRA-MODULE-PATHS keyword argument. Pass it
to (flat-linux-extra-module-paths) along with the selected LINUX package.
(base-initrd): Add LINUX-EXTRA-MODULE-PATHS keyword argument. Pass it
to (raw-initrd).
* gnu/system.scm (operating-system-initrd-file): pass in operating system
definition's kernel-loadable-modules into (make-initrd) as
LINUX-EXTRA-MODULE-PATHS.
---
I've removed the new operating-system slot in preference to re-using
kernel-loadable-modules, as discussed.
I did leave the old argument names for the lower level routines in place,
as I feel that they more accurately represent how the data are being
used.
I've also pulled out the documentation. Once this patch set is beaten
into acceptability, the documentation can be adjusted if that's deemed
necessary.
gnu/build/linux-modules.scm | 19 ++++++++------
gnu/system.scm | 2 ++
gnu/system/linux-initrd.scm | 52 +++++++++++++++++++++++++------------
3 files changed, 48 insertions(+), 25 deletions(-)
diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scm
index 053720574b..97b7e429ea 100644
--- a/gnu/build/linux-modules.scm
+++ b/gnu/build/linux-modules.scm
@@ -225,8 +225,8 @@ (define (file-name->module-name file)
'.ko[.gz|.xz]' and normalizing it."
(normalize-module-name (strip-extension (basename file))))
-(define (find-module-file directory module)
- "Lookup module NAME under DIRECTORY, and return its absolute file name.
+(define (find-module-file directories module)
+ "Lookup module NAME under DIRECTORIES, and return its absolute file name.
NAME can be a file name with or without '.ko', or it can be a module name.
Raise an error if it could not be found.
@@ -247,16 +247,19 @@ (define (find-module-file directory module)
(else chr)))
module))))
- (match (find-files directory
- (lambda (file stat)
- (member (strip-extension
- (basename file)) names)))
+ (match (append-map (lambda (directory)
+ (find-files directory
+ (lambda (file _stat)
+ (member (strip-extension
+ (basename file))
+ names))))
+ directories)
((file)
file)
(()
- (error "kernel module not found" module directory))
+ (error "kernel module not found" module directories))
((_ ...)
- (error "several modules by that name" module directory))))
+ (error "several modules by that name" module directories))))
(define* (recursive-module-dependencies files
#:key (lookup-module dot-ko))
diff --git a/gnu/system.scm b/gnu/system.scm
index ba1b7b5152..6f52377c8d 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -1313,6 +1313,8 @@ (define (operating-system-initrd-file os)
#:linux (operating-system-kernel os)
#:linux-modules
(operating-system-initrd-modules os)
+ #:linux-extra-module-paths
+ (operating-system-kernel-loadable-modules os)
#:mapped-devices mapped-devices
#:keyboard-layout (operating-system-keyboard-layout os)))
diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm
index 4c4c78e444..50a182d7d5 100644
--- a/gnu/system/linux-initrd.scm
+++ b/gnu/system/linux-initrd.scm
@@ -119,13 +119,23 @@ (define* (expression->initrd exp
`(#:references-graphs (("closure" ,init))))
"/initrd.cpio.gz"))
-(define (flat-linux-module-directory linux modules)
+(define (flat-linux-module-directory packages modules)
"Return a flat directory containing the Linux kernel modules listed in
-MODULES and taken from LINUX."
+MODULES and taken from PACKAGES."
(define imported-modules
(source-module-closure '((gnu build linux-modules)
(guix build utils))))
+ (define (package+out->input package out)
+ (gexp-input package out))
+
+ (define package-inputs
+ (map (lambda (p)
+ (match p
+ ((p o) (package+out->input p o))
+ (p (package+out->input p "out"))))
+ packages))
+
(define build-exp
(with-imported-modules imported-modules
(with-extensions (list guile-zlib)
@@ -135,11 +145,12 @@ (define (flat-linux-module-directory linux modules)
(srfi srfi-1)
(srfi srfi-26))
- (define module-dir
- (string-append #$linux "/lib/modules"))
+ (define module-dirs
+ (map (cut string-append <> "/lib/modules")
+ '#$package-inputs))
(define modules
- (let* ((lookup (cut find-module-file module-dir <>))
+ (let* ((lookup (cut find-module-file module-dirs <>))
(modules (map lookup '#$modules)))
(append modules
(recursive-module-dependencies
@@ -172,20 +183,23 @@ (define* (raw-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-paths '())
(mapped-devices '())
(keyboard-layout #f)
(helper-packages '())
qemu-networking?
volatile-root?
(on-error 'debug))
- "Return as a file-like object a raw initrd, with kernel
-modules taken from LINUX. FILE-SYSTEMS is a list of file-systems to be
-mounted by the initrd, possibly in addition to the root file system specified
-on the kernel command line via 'root'. LINUX-MODULES is a list of kernel
-modules to be loaded at boot time. MAPPED-DEVICES is a list of device
-mappings to realize before FILE-SYSTEMS are mounted.
-HELPER-PACKAGES is a list of packages to be copied in the initrd. It may include
-e2fsck/static or other packages needed by the initrd to check root partition.
+ "Return as a file-like object a raw initrd, with kernel modules taken from
+LINUX. FILE-SYSTEMS is a list of file-systems to be mounted by the initrd,
+possibly in addition to the root file system specified on the kernel command
+line via 'root'. LINUX-MODULES is a list of kernel modules to be loaded at
+boot time. LINUX-EXTRA-MODULE-PATHS is a list of file-like objects which will
+be searched for modules in addition to the linux kernel. MAPPED-DEVICES is a
+list of device mappings to realize before FILE-SYSTEMS are mounted.
+HELPER-PACKAGES is a list of packages to be copied in the initrd. It may
+include e2fsck/static or other packages needed by the initrd to check root
+partition.
When true, KEYBOARD-LAYOUT is a <keyboard-layout> record denoting the desired
console keyboard layout. This is done before MAPPED-DEVICES are set up and
@@ -221,7 +235,8 @@ (define* (raw-initrd file-systems
#~())))
(define kodir
- (flat-linux-module-directory linux linux-modules))
+ (flat-linux-module-directory (cons linux linux-extra-module-paths)
+ linux-modules))
(expression->initrd
(with-imported-modules (source-module-closure
@@ -366,6 +381,7 @@ (define* (base-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-paths '())
(mapped-devices '())
(keyboard-layout #f)
qemu-networking?
@@ -386,9 +402,10 @@ (define* (base-initrd file-systems
QEMU-NETWORKING? and VOLATILE-ROOT? behaves as in raw-initrd.
The initrd is automatically populated with all the kernel modules necessary
-for FILE-SYSTEMS and for the given options. Additional kernel
-modules can be listed in LINUX-MODULES. They will be added to the initrd, and
-loaded at boot time in the order in which they appear."
+for FILE-SYSTEMS and for the given options. Additional kernel modules can be
+listed in LINUX-MODULES. Additional search paths for modules can be listed in
+LINUX-EXTRA-MODULE-PATHS. They will be added to the initrd, and loaded at
+boot time in the order in which they appear."
(define linux-modules*
;; Modules added to the initrd and loaded from the initrd.
`(,@linux-modules
@@ -408,6 +425,7 @@ (define* (base-initrd file-systems
(raw-initrd file-systems
#:linux linux
#:linux-modules linux-modules*
+ #:linux-extra-module-paths linux-extra-module-paths
#:mapped-devices mapped-devices
#:helper-packages helper-packages
#:keyboard-layout keyboard-layout
--
2.36.1
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 3 Jun 2022 07:27:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 03 03:27:39 2022 Received: from localhost ([127.0.0.1]:55156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nx1ic-0006Cd-OJ for submit <at> debbugs.gnu.org; Fri, 03 Jun 2022 03:27:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1nx1iY-0006CO-Fh for 55231 <at> debbugs.gnu.org; Fri, 03 Jun 2022 03:27:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49002) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1nx1iS-0002uN-62; Fri, 03 Jun 2022 03:27:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=5GVo50Y8XZz3ZFdJF0muJvvyOJ+9nPClm1VG8Dn+77k=; b=pxjStEcGZSAbdQgJT8ut F/JNonKiQrencOseKfOJioWkaj5rK5zgaWJJLFs62GqxnWJLgSFFk9YjofaePOdc3Nz4VdRik15sB yGo2ZTQ55+cQwnxBE/4uHyQKfGa5vv1FQhzaHPGrAF+Ho+q6ObxRgbCGOPXhVdS6FbH9Uvyx5VSQc WgS9PbDkGOr3+h5ZjHbAfeFgFP39KxPwKqWrMAo7adENULVTJeP1nCByxlJecrG5CVc70qkG5efQH jHqAjte1XgLfMoj8fB/gA7tV3v2wZLx99+c6Jlb6xQlARA+2Dd3igMgNsWMRhBLz62gjNe5lJvF4+ 6mCrsQ35fhj8BA==; Received: from [193.50.110.183] (port=50992 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1nx1iH-0006vL-VI; Fri, 03 Jun 2022 03:27:23 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Brian Cully <bjc@HIDDEN> Subject: Re: bug#55231: [PATCH v1] initrd: Allow extra search paths with =?utf-8?Q?=E2=80=98initrd-extra-module-paths=E2=80=99?= References: <87wnf3pv87.fsf@HIDDEN> <2053c4ab42dfe2719cfc377934ac2fb9bcb500a9.1653160364.git.bjc@HIDDEN> <87ilpkwf8x.fsf_-_@HIDDEN> <87a6aug4p2.fsf@HIDDEN> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 15 Prairial an 230 de la =?utf-8?Q?R=C3=A9v?= =?utf-8?Q?olution=2C?= jour de la Caille X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 03 Jun 2022 09:27:14 +0200 In-Reply-To: <87a6aug4p2.fsf@HIDDEN> (Brian Cully's message of "Thu, 02 Jun 2022 16:40:36 -0400") Message-ID: <87fskmky0d.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 55231 Cc: 55231 <at> debbugs.gnu.org, Brian Cully <bjc@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Hi, Brian Cully <bjc@HIDDEN> skribis: > Ludovic Court=C3=A8s <ludo@HIDDEN> writes: > >> I wonder if we could reuse the =E2=80=98kernel-loadable-modules=E2=80=99= field for >> this >> purpose instead of introducing a new field. We=E2=80=99d need to pass i= t to >> the >> initrd procedures and have them search in there in addition to the >> kernel package, pretty much like this patch already does actually. > > This sounds like it could be made to work as you suggest. My feeling > is that the two contexts are slightly different, though, as the Linux > modules are a superset of the initrd modules, Right. Here, we want the initrd machinery to search for modules in any place where they can be found, which is either =E2=80=98kernel=E2=80=99 or =E2=80=98kernel-loadable-modules=E2=80=99. One could define =E2=80=98initrd-extra-module-paths=E2=80=99 to be differen= t from =E2=80=98kernel-loadable-modules=E2=80=99, for example if you can be sure t= he module will be loaded from the initrd and not after, but in general both are likely to have the same value, no? >> Nitpick: the GNU convention is to use =E2=80=9Cpath=E2=80=9D to denote = =E2=80=9Csearch >> paths=E2=80=9D, >> and other =E2=80=9Cfile=E2=80=9D, =E2=80=9Cfile name=E2=80=9D, or simila= r. In this case, that=E2=80=99d be >> =E2=80=9Ckernel module=E2=80=9D or =E2=80=9CLinux module=E2=80=9D. > > I struggled with this a fair amount, actually. What these file-likes > actually represent is an element of a search path, even if they come > in the odd form of a file-like object, which is why I used > =E2=80=98path=E2=80=99. =E2=80=98file=E2=80=99 seems wrong, as it implies= (to me) that it=E2=80=99s the > =E2=80=98initrd-extra-module-files=E2=80=99 option itself that would incl= ude the > module, rather than the =E2=80=98initrd-modules=E2=80=99 option. Hmm right, you have a point! :-) > When I get some time (hopefully soon!) I=E2=80=99ll try to thread > =E2=80=98kernel-loadable-modules=E2=80=99 through instead and see how far= I can get > with that approach. Do you think the documentation for it will need to > be updated to specify that it=E2=80=99s also used as a search path for in= itrd > building? Or maybe the better option is to update the documentation > for =E2=80=98initrd-modules=E2=80=99 to say that it uses =E2=80=98kernel-= loadable-modules=E2=80=99 as > input? I think you should update the documentation in the commit that changes things, so that the patch is self-contained. It may be enough to state in the documentation of the =E2=80=98initrd-modul= es=E2=80=99 field that its value is a list of module names that are searched for in =E2=80=98kernel=E2=80=99 and =E2=80=98kernel-loadable-modules=E2=80=99. WDYT? Thanks, Ludo=E2=80=99.
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 2 Jun 2022 21:24:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 02 17:24:13 2022 Received: from localhost ([127.0.0.1]:54716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nwsIf-0005yU-Jf for submit <at> debbugs.gnu.org; Thu, 02 Jun 2022 17:24:13 -0400 Received: from mail-4319.protonmail.ch ([185.70.43.19]:21105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <kaelyn.alexi@HIDDEN>) id 1nwsIc-0005yD-Qs for 55231 <at> debbugs.gnu.org; Thu, 02 Jun 2022 17:24:13 -0400 Date: Thu, 02 Jun 2022 21:23:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1654205044; x=1654464244; bh=g3CE23lz0ZLNTm1gf8g8ldokSQK9Vy/Gt6dvJVn/zmI=; h=Date:To:From:Reply-To:Subject:Message-ID:Feedback-ID:From:To:Cc: Date:Subject:Reply-To:Feedback-ID:Message-ID; b=FJhof82YeBm6bICyY4q+SafPHRnAgy+8Z7CBSU4GAuI82EfEGAbZMYdYRXZrRIJfp AalKGSFQ7lRrujTQwazanEAluZ9951nWs+V8QtqYO9KV1G2LFWiYFvsHt/GGEtsLz4 vfFp3EMgOSOgy500UbHkpgO2P5NbjyUceT2EyBuAnuiR5FnZnbDp8oHiDcuZBwdQ8A E13U1ZIWIZb0pdC4DtYF+7teF9TFXkllQN9+4ZDB4YN+1nsgB3hXedMy69WTAIOW/k BA66YL1iNGjE323x2qYYxKsI7dy+wkB5BuNe9gFIBurtxOi3RnJ9vo+dw2tgipPcTW 0DwWLF+WeyEaQ== To: "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> From: Kaelyn <kaelyn.alexi@HIDDEN> Subject: =?utf-8?Q?[PATCH_v1]_initrd:_Allow_extra_search_paths_with_=E2=80=98initrd-extra-module-paths=E2=80=99?= Message-ID: <jMhPvkR0keO7tVdAcEW2mIuI_3iopqkDVl73kagJHUdr7sa5CdxbqMwQ2j2CqDQymRUDaSXCPO_8CIv0qSDhOyD37Nc5rsnRyrNUBrVgQM4=@protonmail.com> Feedback-ID: 34709329:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55231 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Kaelyn <kaelyn.alexi@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi, My $0.02 on 'initrd-extra-module-paths' vs 'kernel-loadable-modules': if th= e initrd code is smart enough to not include the entire packages and only i= ncludes the requested modules from the packages (which I think is already t= rue based on behavior observed some time ago), then not having to duplicate= the list would be preferable. I found this issue in the tracker after being surprised that the initrd bui= lder ignored 'kernel-loadable-modules' with 'initrd-modules' only working f= or modules that are included in the primary linux kernel package. That surp= rise over the incompatibility between 'initrd-modules' and 'kernel-loadable= -modules' is also why I've been relatively vocal about the patch. ;) Cheers, Kaelyn
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 2 Jun 2022 21:01:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jun 02 17:01:48 2022 Received: from localhost ([127.0.0.1]:54694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nwrwx-0005O1-OA for submit <at> debbugs.gnu.org; Thu, 02 Jun 2022 17:01:47 -0400 Received: from coleridge.kublai.com ([166.84.7.167]:53889 helo=mail.spork.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <bjc@HIDDEN>) id 1nwrww-0005Nt-6F for 55231 <at> debbugs.gnu.org; Thu, 02 Jun 2022 17:01:46 -0400 Received: from ditto (ool-18b8e9e7.dyn.optonline.net [24.184.233.231]) by mail.spork.org (Postfix) with ESMTPSA id B6F9F8A3D; Thu, 2 Jun 2022 17:01:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1654203705; bh=G8bKO2ASmDtPbUgOW5zLtjWZqrpAcqYfsJe89vmDIKw=; h=References:From:To:Cc:Subject:Date:In-reply-to; b=E0/mJKF6Omgj5wsi7IpIU9g9bsnmprvxOpFVQebbVN0j6WYfQgkcsP3jJN+NJYWWn Jz1ocImneBgb5jqDf6Aqh4PV6YWHSpJhtCFYl4o795DwOg+DUOqlLhZ/8YiDMWzF8u uSLHjTtkahE6H0Eq23fmK9mlMZe6VXrcTAlcPWB0= References: <87wnf3pv87.fsf@HIDDEN> <2053c4ab42dfe2719cfc377934ac2fb9bcb500a9.1653160364.git.bjc@HIDDEN> <87ilpkwf8x.fsf_-_@HIDDEN> User-agent: mu4e 1.6.10; emacs 28.1 From: Brian Cully <bjc@HIDDEN> To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN> Subject: Re: bug#55231: [PATCH v1] initrd: Allow extra search paths with =?utf-8?Q?=E2=80=98initrd-extra-module-paths=E2=80=99?= Date: Thu, 02 Jun 2022 16:40:36 -0400 In-reply-to: <87ilpkwf8x.fsf_-_@HIDDEN> Message-ID: <87a6aug4p2.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55231 Cc: 55231 <at> debbugs.gnu.org, Brian Cully <bjc@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s <ludo@HIDDEN> writes: > I wonder if we could reuse the =E2=80=98kernel-loadable-modules=E2=80=99 = field=20 > for this > purpose instead of introducing a new field. We=E2=80=99d need to pass=20 > it to the > initrd procedures and have them search in there in addition to=20 > the > kernel package, pretty much like this patch already does=20 > actually. This sounds like it could be made to work as you suggest. My=20 feeling is that the two contexts are slightly different, though,=20 as the Linux modules are a superset of the initrd modules, so I=E2=80=99d=20 prefer not to mix them as it might be confusing to people who are=20 used to other Linux distros where the initrd modules are called=20 out separately. I admit I=E2=80=99m probably being silly here, and don=E2= =80=99t=20 have any serious objection in principle. > Nitpick: the GNU convention is to use =E2=80=9Cpath=E2=80=9D to denote = =E2=80=9Csearch=20 > paths=E2=80=9D, > and other =E2=80=9Cfile=E2=80=9D, =E2=80=9Cfile name=E2=80=9D, or similar= . In this case, that=E2=80=99d=20 > be > =E2=80=9Ckernel module=E2=80=9D or =E2=80=9CLinux module=E2=80=9D. I struggled with this a fair amount, actually. What these=20 file-likes actually represent is an element of a search path, even=20 if they come in the odd form of a file-like object, which is why I=20 used =E2=80=98path=E2=80=99. =E2=80=98file=E2=80=99 seems wrong, as it impl= ies (to me) that it=E2=80=99s=20 the =E2=80=98initrd-extra-module-files=E2=80=99 option itself that would in= clude=20 the module, rather than the =E2=80=98initrd-modules=E2=80=99 option. Of course, all this goes away if we just reuse=20 =E2=80=98kernel-loadable-modules=E2=80=99 as an additional input, rather th= an=20 adding another option, so that=E2=80=99s a distinct mark in favor of doing= =20 that. When I get some time (hopefully soon!) I=E2=80=99ll try to thread=20 =E2=80=98kernel-loadable-modules=E2=80=99 through instead and see how far I= can=20 get with that approach. Do you think the documentation for it will=20 need to be updated to specify that it=E2=80=99s also used as a search path= =20 for initrd building? Or maybe the better option is to update the=20 documentation for =E2=80=98initrd-modules=E2=80=99 to say that it uses=20 =E2=80=98kernel-loadable-modules=E2=80=99 as input? -bjc
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 1 Jun 2022 15:55:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 01 11:55:05 2022
Received: from localhost ([127.0.0.1]:51684 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nwQgb-00043U-4U
for submit <at> debbugs.gnu.org; Wed, 01 Jun 2022 11:55:05 -0400
Received: from eggs.gnu.org ([209.51.188.92]:57780)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ludo@HIDDEN>) id 1nwQgZ-00042s-B2
for 55231 <at> debbugs.gnu.org; Wed, 01 Jun 2022 11:55:03 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:37564)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
id 1nwQgS-0001Sn-IP; Wed, 01 Jun 2022 11:54:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To:
From; bh=4FgHx67M7wzGDu2tGyxd76n6DPVnCywDO6cw7VtaKwc=; b=qCy0LOoq+kOwoyNjjE+b
Frfvzgl9Pch3nR1sScXcRQaBGNTe34ciTLHidCYq2RCJb4L4KZl23JuUchdB+HOEvpdYLic3qIhdX
pD3rW67NRm79xfxZp7bNzKknLmor8mq9xzNcC1LYy6qF5fTbTb7BGqSVIJpRg//jlW9H/qEkAic3f
0dk8grnQbeN8ofHfP9nJqCeAJzugniC4MT5VIzOxhyoVK/eb+gC+QRGNeI5sPvanVl4QJ4dmtzf/W
cQ4CVOXCmPE2YI/nIakyzGsofMSDTza0q1vnwY8AKAP51iw4O628Be8CW4/jWnie8rIupNnUV500a
Akr6qLHqQd9Pyg==;
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=53194 helo=ribbon)
by fencepost.gnu.org with esmtpsa
(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
(envelope-from <ludo@HIDDEN>)
id 1nwQgS-0007fD-3i; Wed, 01 Jun 2022 11:54:56 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Brian Cully <bjc@HIDDEN>
Subject: Re: bug#55231: [PATCH v1] initrd: Allow extra search paths with
=?utf-8?Q?=E2=80=98initrd-extra-module-paths=E2=80=99?=
References: <87wnf3pv87.fsf@HIDDEN>
<2053c4ab42dfe2719cfc377934ac2fb9bcb500a9.1653160364.git.bjc@HIDDEN>
Date: Wed, 01 Jun 2022 17:54:54 +0200
In-Reply-To: <2053c4ab42dfe2719cfc377934ac2fb9bcb500a9.1653160364.git.bjc@HIDDEN>
(Brian Cully's message of "Sat, 21 May 2022 15:12:45 -0400")
Message-ID: <87ilpkwf8x.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 55231
Cc: 55231 <at> debbugs.gnu.org, Brian Cully <bjc@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hello Brian,
Brian Cully <bjc@HIDDEN> skribis:
> From: Brian Cully <bjc@HIDDEN>
>
> This patch allows copying of out-of-tree kernel modules to the Linux
> initrd.
>
> For out-of-tree modules to found, an extra slot has been added to
> =E2=80=98operating-system=E2=80=99: =E2=80=98initrd-extra-module-paths=E2=
=80=99, which contains a list
> containing items of either FILE-LIKE or (FILE-LIKE OUTPUT) which will be
> searched for modules in addition to the standard Linux module path. The
> required modules can then be added to =E2=80=98initrd-modules=E2=80=99 as=
normal and all paths
> will be searched for it, including for any modules depended on.
>
> * doc: Update documentation for =E2=80=98initrd-extra-module-paths=E2=80=
=99.
> * gnu/build/linux-modules.scm (find-module-file): change DIRECTORY argume=
nt to
> DIRECTORIES. Now takes a list of directories to search, rather than a sin=
gle
> one.
> * gnu/system.scm <operating-system>: Add INITRD-EXTRA-MODULE-PATHS
> field and accessor. Takes a list of file-like objects.
> * gnu/system/linux-initrd.scm (flat-linux-module-directory): change LINUX
> argument to PACKAGES. Now contains a list of file-likes to search for mod=
ules.
> (raw-initrd): Add LINUX-EXTRA-MODULE-PATHS keyword argument. Pass it
> to (flat-linux-extra-module-paths) along with the selected LINUX package.
> (base-initrd): Add LINUX-EXTRA-MODULE-PATHS keyword argument. Pass it
> to (raw-initrd).
Nice, it looks like a welcome addition.
> +If a module listed in @code{initrd-modules} is not included in the
> +Linux-libre kernel, then the location to it must be added to the
> +@code{initrd-extra-module-paths} list. For example, if your root file
> +system exists on a ZFS pool, then your configuration might look like the
> +following:
> +
> +@lisp
> +(operating-system
> + ;; @dots{}
> + (initrd-modules (cons "zfs" %base-initrd-modules))
> + (initrd-extra-module-paths (list (list zfs "module"))))
> +@end lisp
I wonder if we could reuse the =E2=80=98kernel-loadable-modules=E2=80=99 fi=
eld for this
purpose instead of introducing a new field. We=E2=80=99d need to pass it t=
o the
initrd procedures and have them search in there in addition to the
kernel package, pretty much like this patch already does actually.
WDYT?
Nitpick: the GNU convention is to use =E2=80=9Cpath=E2=80=9D to denote =E2=
=80=9Csearch paths=E2=80=9D,
and other =E2=80=9Cfile=E2=80=9D, =E2=80=9Cfile name=E2=80=9D, or similar. =
In this case, that=E2=80=99d be
=E2=80=9Ckernel module=E2=80=9D or =E2=80=9CLinux module=E2=80=9D.
Thank you!
Ludo=E2=80=99.
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 30 May 2022 20:14:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 30 16:14:39 2022 Received: from localhost ([127.0.0.1]:46124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nvlmh-0002ZB-HY for submit <at> debbugs.gnu.org; Mon, 30 May 2022 16:14:39 -0400 Received: from mail-40141.protonmail.ch ([185.70.40.141]:45113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <kaelyn.alexi@HIDDEN>) id 1nvlmf-0002Yr-Tn for 55231 <at> debbugs.gnu.org; Mon, 30 May 2022 16:14:38 -0400 Date: Mon, 30 May 2022 20:14:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1653941671; x=1654200871; bh=aHw3z51Hdr5WGrcZvkbvt6obAreacnR1kTHFADH/zxU=; h=Date:To:From:Reply-To:Subject:Message-ID:Feedback-ID:From:To:Cc: Date:Subject:Reply-To:Feedback-ID:Message-ID; b=F/2YaxipkyVXrALuLwSZi/x0lLeSXt/QhB7ZnIhW7HV/67l0ppnQyobEBVlll/ZJW X6W8p1gRWfUsDDCysYBy8YIEfw7UGVDp/rPrEeyh/jePaN07gv+SwlJCMqsevNhdsz bAFmBexxv5yGQPVHtalv0g3Z/rQjdm9i9NklplwrSxBEPb1BH1m0CemJ7LLMT9ANZZ 0JZx9g6zlZyJ28tc1fOWGZ7HIaCyulrwHvcOZrojomhSGgz9rm+jukts7VHS15JmMG AhciaBnMPljUHD3LZEBnVZ3/tzJ8VNLD2U+a03op/Q19uJXzXWXyzvtZw0Y29UTWE1 RfXNSbvaq4j3g== To: "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> From: Kaelyn <kaelyn.alexi@HIDDEN> Subject: =?utf-8?Q?[PATCH_v1]_initrd:_Allow_extra_search_paths_with_=E2=80=98initrd-extra-module-paths=E2=80=99?= Message-ID: <5RCll7W7NfLNRPRFsqgPxB3zS1_6W-9QJbOmXc5RW3E8oZ4Pm_JTzO0SZXsMkZtC811Rw5G0ISt75vP_YKll5MGU7_Krm3Y6IWoXYL9xR3A=@protonmail.com> Feedback-ID: 34709329:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55231 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Kaelyn <kaelyn.alexi@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) As the earlier patch discussion seemed to have focused on ZFS licensing iss= ues that are largely orothogonal to the functionality being added, I'd like= to again voice my support for the proposed patch. While ZFS is indeed a ba= d example due to open questions about module licensing and redistribution, = it isn't the only out-of-tree module currently packaged in Guix which could= be used with the extra initrd support (not counting future packages or ext= ernal channels). Within the guix repo, the packages using the `linux-module= -build-system` aside from zfs are: - acpi-call-linux-module - bbswitch-module - ddcci-driver-linux - rtl8812au-aircrack-ng-linux-module - rtl8821ce-linux-module - ttyebus-linux-module - v4l2loopback-linux-module - vhba-module - wiregard-linux-compat Of those nine, at least four look to be for specific hardware, and I can co= me up with theoretical use cases for why someone might want those or wirega= rd-linux-compat (though the cases are definitely contrived straw-men that m= ay or may not be implementable in practice or actually useful in an initrd = context, such as network booting with an older kernel and the root filesyst= em can only be accessed over a wireguard connection). Cheers, Kaelyn
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 21 May 2022 19:13:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat May 21 15:13:17 2022
Received: from localhost ([127.0.0.1]:42976 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nsUXM-0002k8-DT
for submit <at> debbugs.gnu.org; Sat, 21 May 2022 15:13:17 -0400
Received: from coleridge.kublai.com ([166.84.7.167]:57942 helo=mail.spork.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjc@HIDDEN>) id 1nsUXK-0002k0-7W
for 55231 <at> debbugs.gnu.org; Sat, 21 May 2022 15:13:15 -0400
Received: from guix.jhoto.kublai.com (unknown
[IPv6:2001:470:1f07:1b9:c714:ed8b:7cf4:a700])
by mail.spork.org (Postfix) with ESMTPSA id 0CBD470CA;
Sat, 21 May 2022 15:13:14 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim;
t=1653160394; bh=lye+eu/C0xitMixOX5/Vcr/gOROF3AtimFdB3XpxwBQ=;
h=From:To:Cc:Subject:Date;
b=EQaIDMHaHNHCBgRat23MBgGBIUWTE3pOmwJOaaGN34YKQSUaIPVao54MejZrw9M2h
+AwtIcKg2zg6Ka4PwXcMR0ZHrhlG3VzIGPMknElfI4CXq6anA8uqvQsnR73PIhSJGS
y22pe8MOaSjEvywbBmnMva96qVnwAJLD+uKA7etM=
From: Brian Cully <bjc@HIDDEN>
To: 55231 <at> debbugs.gnu.org
Subject: [PATCH v2] =?UTF-8?q?initrd:=20Allow=20extra=20search=20paths=20w?=
=?UTF-8?q?ith=20=E2=80=98initrd-extra-module-paths=E2=80=99?=
Date: Sat, 21 May 2022 15:12:45 -0400
Message-Id: <2053c4ab42dfe2719cfc377934ac2fb9bcb500a9.1653160364.git.bjc@HIDDEN>
X-Mailer: git-send-email 2.36.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: Brian Cully <bjc@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
From: Brian Cully <bjc@HIDDEN>
This patch allows copying of out-of-tree kernel modules to the Linux
initrd.
For out-of-tree modules to found, an extra slot has been added to
‘operating-system’: ‘initrd-extra-module-paths’, which contains a list
containing items of either FILE-LIKE or (FILE-LIKE OUTPUT) which will be
searched for modules in addition to the standard Linux module path. The
required modules can then be added to ‘initrd-modules’ as normal and all paths
will be searched for it, including for any modules depended on.
* doc: Update documentation for ‘initrd-extra-module-paths’.
* gnu/build/linux-modules.scm (find-module-file): change DIRECTORY argument to
DIRECTORIES. Now takes a list of directories to search, rather than a single
one.
* gnu/system.scm <operating-system>: Add INITRD-EXTRA-MODULE-PATHS
field and accessor. Takes a list of file-like objects.
* gnu/system/linux-initrd.scm (flat-linux-module-directory): change LINUX
argument to PACKAGES. Now contains a list of file-likes to search for modules.
(raw-initrd): Add LINUX-EXTRA-MODULE-PATHS keyword argument. Pass it
to (flat-linux-extra-module-paths) along with the selected LINUX package.
(base-initrd): Add LINUX-EXTRA-MODULE-PATHS keyword argument. Pass it
to (raw-initrd).
---
This version includes both the previous patch and the documentation.
doc/guix.texi | 42 ++++++++++++++++++++++++------
gnu/build/linux-modules.scm | 19 ++++++++------
gnu/system.scm | 5 ++++
gnu/system/linux-initrd.scm | 52 +++++++++++++++++++++++++------------
4 files changed, 85 insertions(+), 33 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index faa35060ef..9fd45ea209 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -15490,6 +15490,16 @@ operating-system Reference
The list of Linux kernel modules that need to be available in the
initial RAM disk. @xref{Initial RAM Disk}.
+@item @code{initrd-extra-module-paths} (default: @code{'()})
+@cindex initrd
+@cindex initial RAM disk
+A list of paths outside of the Linux kernel tree to search for Linux
+kernel modules.
+
+The items in this may be either file-like objects (usually packages), or
+a list where the first element is a package and the second is an
+output--e.g. @code{(list (list zfs "module"))}.
+
@item @code{initrd} (default: @code{base-initrd})
A procedure that returns an initial RAM disk for the Linux
kernel. This field is provided to support low-level customization and
@@ -35816,6 +35826,19 @@ Initial RAM Disk
(initrd-modules (cons "megaraid_sas" %base-initrd-modules)))
@end lisp
+If a module listed in @code{initrd-modules} is not included in the
+Linux-libre kernel, then the location to it must be added to the
+@code{initrd-extra-module-paths} list. For example, if your root file
+system exists on a ZFS pool, then your configuration might look like the
+following:
+
+@lisp
+(operating-system
+ ;; @dots{}
+ (initrd-modules (cons "zfs" %base-initrd-modules))
+ (initrd-extra-module-paths (list (list zfs "module"))))
+@end lisp
+
@defvr {Scheme Variable} %base-initrd-modules
This is the list of kernel modules included in the initrd by default.
@end defvr
@@ -35929,13 +35952,15 @@ Initial RAM Disk
@cindex initrd
@cindex initial RAM disk
@deffn {Scheme Procedure} raw-initrd @var{file-systems} @
- [#:linux-modules '()] [#:mapped-devices '()] @
- [#:keyboard-layout #f] @
+ [#:linux-modules '()] [#:linux-extra-module-paths '()] @
+ [#:mapped-devices '()] [#:keyboard-layout #f] @
[#:helper-packages '()] [#:qemu-networking? #f] [#:volatile-root? #f]
Return a derivation that builds a raw initrd. @var{file-systems} is
a list of file systems to be mounted by the initrd, possibly in addition to
the root file system specified on the kernel command line via @option{root}.
@var{linux-modules} is a list of kernel modules to be loaded at boot time.
+@var{linux-extra-module-paths} is a list of file-like objects to be searched
+for kernel modules.
@var{mapped-devices} is a list of device mappings to realize before
@var{file-systems} are mounted (@pxref{Mapped Devices}).
@var{helper-packages} is a list of packages to be copied in the initrd.
@@ -35960,12 +35985,13 @@ Initial RAM Disk
@deffn {Scheme Procedure} base-initrd @var{file-systems} @
[#:mapped-devices '()] [#:keyboard-layout #f] @
[#:qemu-networking? #f] [#:volatile-root? #f] @
- [#:linux-modules '()]
-Return as a file-like object a generic initrd, with kernel
-modules taken from @var{linux}. @var{file-systems} is a list of file-systems to be
-mounted by the initrd, possibly in addition to the root file system specified
-on the kernel command line via @option{root}. @var{mapped-devices} is a list of device
-mappings to realize before @var{file-systems} are mounted.
+ [#:linux-modules '()] [#:linux-extra-module-paths '()]
+Return as a file-like object a generic initrd, with kernel modules taken
+from @var{linux} and @var{linux-extra-module-paths}. @var{file-systems}
+is a list of file-systems to be mounted by the initrd, possibly in
+addition to the root file system specified on the kernel command line
+via @option{root}. @var{mapped-devices} is a list of device mappings to
+realize before @var{file-systems} are mounted.
When true, @var{keyboard-layout} is a @code{<keyboard-layout>} record denoting
the desired console keyboard layout. This is done before @var{mapped-devices}
diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scm
index 053720574b..97b7e429ea 100644
--- a/gnu/build/linux-modules.scm
+++ b/gnu/build/linux-modules.scm
@@ -225,8 +225,8 @@ (define (file-name->module-name file)
'.ko[.gz|.xz]' and normalizing it."
(normalize-module-name (strip-extension (basename file))))
-(define (find-module-file directory module)
- "Lookup module NAME under DIRECTORY, and return its absolute file name.
+(define (find-module-file directories module)
+ "Lookup module NAME under DIRECTORIES, and return its absolute file name.
NAME can be a file name with or without '.ko', or it can be a module name.
Raise an error if it could not be found.
@@ -247,16 +247,19 @@ (define (find-module-file directory module)
(else chr)))
module))))
- (match (find-files directory
- (lambda (file stat)
- (member (strip-extension
- (basename file)) names)))
+ (match (append-map (lambda (directory)
+ (find-files directory
+ (lambda (file _stat)
+ (member (strip-extension
+ (basename file))
+ names))))
+ directories)
((file)
file)
(()
- (error "kernel module not found" module directory))
+ (error "kernel module not found" module directories))
((_ ...)
- (error "several modules by that name" module directory))))
+ (error "several modules by that name" module directories))))
(define* (recursive-module-dependencies files
#:key (lookup-module dot-ko))
diff --git a/gnu/system.scm b/gnu/system.scm
index ba3a1865d7..6c712e5cea 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -107,6 +107,7 @@ (define-module (gnu system)
operating-system-label
operating-system-default-label
operating-system-initrd-modules
+ operating-system-initrd-extra-module-paths
operating-system-initrd
operating-system-users
operating-system-groups
@@ -236,6 +237,8 @@ (define-record-type* <operating-system> operating-system
(initrd-modules operating-system-initrd-modules ; list of strings
(thunked) ; it's system-dependent
(default %base-initrd-modules))
+ (initrd-extra-module-paths operating-system-initrd-extra-module-paths ; list of file-likes
+ (default '()))
(firmware operating-system-firmware ; list of packages
(default %base-firmware))
@@ -1312,6 +1315,8 @@ (define (operating-system-initrd-file os)
#:linux (operating-system-kernel os)
#:linux-modules
(operating-system-initrd-modules os)
+ #:linux-extra-module-paths
+ (operating-system-initrd-extra-module-paths os)
#:mapped-devices mapped-devices
#:keyboard-layout (operating-system-keyboard-layout os)))
diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm
index 4c4c78e444..50a182d7d5 100644
--- a/gnu/system/linux-initrd.scm
+++ b/gnu/system/linux-initrd.scm
@@ -119,13 +119,23 @@ (define* (expression->initrd exp
`(#:references-graphs (("closure" ,init))))
"/initrd.cpio.gz"))
-(define (flat-linux-module-directory linux modules)
+(define (flat-linux-module-directory packages modules)
"Return a flat directory containing the Linux kernel modules listed in
-MODULES and taken from LINUX."
+MODULES and taken from PACKAGES."
(define imported-modules
(source-module-closure '((gnu build linux-modules)
(guix build utils))))
+ (define (package+out->input package out)
+ (gexp-input package out))
+
+ (define package-inputs
+ (map (lambda (p)
+ (match p
+ ((p o) (package+out->input p o))
+ (p (package+out->input p "out"))))
+ packages))
+
(define build-exp
(with-imported-modules imported-modules
(with-extensions (list guile-zlib)
@@ -135,11 +145,12 @@ (define (flat-linux-module-directory linux modules)
(srfi srfi-1)
(srfi srfi-26))
- (define module-dir
- (string-append #$linux "/lib/modules"))
+ (define module-dirs
+ (map (cut string-append <> "/lib/modules")
+ '#$package-inputs))
(define modules
- (let* ((lookup (cut find-module-file module-dir <>))
+ (let* ((lookup (cut find-module-file module-dirs <>))
(modules (map lookup '#$modules)))
(append modules
(recursive-module-dependencies
@@ -172,20 +183,23 @@ (define* (raw-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-paths '())
(mapped-devices '())
(keyboard-layout #f)
(helper-packages '())
qemu-networking?
volatile-root?
(on-error 'debug))
- "Return as a file-like object a raw initrd, with kernel
-modules taken from LINUX. FILE-SYSTEMS is a list of file-systems to be
-mounted by the initrd, possibly in addition to the root file system specified
-on the kernel command line via 'root'. LINUX-MODULES is a list of kernel
-modules to be loaded at boot time. MAPPED-DEVICES is a list of device
-mappings to realize before FILE-SYSTEMS are mounted.
-HELPER-PACKAGES is a list of packages to be copied in the initrd. It may include
-e2fsck/static or other packages needed by the initrd to check root partition.
+ "Return as a file-like object a raw initrd, with kernel modules taken from
+LINUX. FILE-SYSTEMS is a list of file-systems to be mounted by the initrd,
+possibly in addition to the root file system specified on the kernel command
+line via 'root'. LINUX-MODULES is a list of kernel modules to be loaded at
+boot time. LINUX-EXTRA-MODULE-PATHS is a list of file-like objects which will
+be searched for modules in addition to the linux kernel. MAPPED-DEVICES is a
+list of device mappings to realize before FILE-SYSTEMS are mounted.
+HELPER-PACKAGES is a list of packages to be copied in the initrd. It may
+include e2fsck/static or other packages needed by the initrd to check root
+partition.
When true, KEYBOARD-LAYOUT is a <keyboard-layout> record denoting the desired
console keyboard layout. This is done before MAPPED-DEVICES are set up and
@@ -221,7 +235,8 @@ (define* (raw-initrd file-systems
#~())))
(define kodir
- (flat-linux-module-directory linux linux-modules))
+ (flat-linux-module-directory (cons linux linux-extra-module-paths)
+ linux-modules))
(expression->initrd
(with-imported-modules (source-module-closure
@@ -366,6 +381,7 @@ (define* (base-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-paths '())
(mapped-devices '())
(keyboard-layout #f)
qemu-networking?
@@ -386,9 +402,10 @@ (define* (base-initrd file-systems
QEMU-NETWORKING? and VOLATILE-ROOT? behaves as in raw-initrd.
The initrd is automatically populated with all the kernel modules necessary
-for FILE-SYSTEMS and for the given options. Additional kernel
-modules can be listed in LINUX-MODULES. They will be added to the initrd, and
-loaded at boot time in the order in which they appear."
+for FILE-SYSTEMS and for the given options. Additional kernel modules can be
+listed in LINUX-MODULES. Additional search paths for modules can be listed in
+LINUX-EXTRA-MODULE-PATHS. They will be added to the initrd, and loaded at
+boot time in the order in which they appear."
(define linux-modules*
;; Modules added to the initrd and loaded from the initrd.
`(,@linux-modules
@@ -408,6 +425,7 @@ (define* (base-initrd file-systems
(raw-initrd file-systems
#:linux linux
#:linux-modules linux-modules*
+ #:linux-extra-module-paths linux-extra-module-paths
#:mapped-devices mapped-devices
#:helper-packages helper-packages
#:keyboard-layout keyboard-layout
--
2.36.1
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 13 May 2022 20:25:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 13 16:25:47 2022
Received: from localhost ([127.0.0.1]:45127 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1npbr9-0002Op-2w
for submit <at> debbugs.gnu.org; Fri, 13 May 2022 16:25:47 -0400
Received: from andre.telenet-ops.be ([195.130.132.53]:39038)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maximedevos@HIDDEN>) id 1npbr6-0002Oe-OV
for 55231 <at> debbugs.gnu.org; Fri, 13 May 2022 16:25:45 -0400
Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be
([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a])
by andre.telenet-ops.be with bizsmtp
id WLRi2700H4UW6Th01LRiFD; Fri, 13 May 2022 22:25:43 +0200
Message-ID: <f31190b82fc43348535ee873bcc29a9ff501a6f7.camel@HIDDEN>
Subject: Re: [PATCH v1] initrd: Allow extra search paths with
=?UTF-8?Q?=E2=80=98initrd-extra-module-paths=E2=80=99?=
From: Maxime Devos <maximedevos@HIDDEN>
To: 55231 <at> debbugs.gnu.org
Date: Fri, 13 May 2022 22:25:38 +0200
Content-Type: multipart/signed; micalg="pgp-sha512";
protocol="application/pgp-signature"; boundary="=-GE9Q+CrVfXqiuTqWmUXp"
User-Agent: Evolution 3.38.3-1
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
t=1652473543; bh=hsBHtNehVIG+3lJ5bPGWfrmjAPN+XZaxpGoU3jwebG0=;
h=Subject:From:To:Date;
b=j7pUgPEWWCmJ53yNdsnLLB6KQVS7Dj7lScGON0ayiLmC1hYu7pqdphO4ttK1n1ODa
s2QRk2+55xN533vnPe5Ct8YA+o9kB5b3AjhdDOPRJ7CYCuMTf6XudUywsl2hIlS4q7
Ffgia5bvR0U1sMdiKqX+7ILtCg515ea14xm3Q9FZLeHPjNuMilNao2m85zgDpBvB2C
GBiAP+WBXb2uCCGBdU2OdQ1htVqS6e0hPZM/aIRksBIalN3koalsN3YQiwXVKmj16N
mFXaz1N1/NOp+PDKVvA+A84+ywUXT/vH2etZ/FicMrcx63cZGE59wlFnb5kwYUdBgi
Zk96ONbIttYEA==
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 55231
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-GE9Q+CrVfXqiuTqWmUXp
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
(for whatever reason, looks like this didn't end up in my inbox)
> +@item @code{initrd-extra-module-paths} (default: @code{'()})
> [...]
> The items in this may be either file-like objects (usually=20
> packages), or
> +a list where the first element is a package and the second is an
> +output--e.g. @code{(list (list zfs "module"))}.
As-is, I don't think this is a good example, because
'expression->initrd' does not set #:substitutable? #false,
the 'zfs' package has the comment (*)
`(;; The ZFS kernel module should not be downloaded since the
license
;; terms don't allow for distributing it, only building it
locally.
#:substitutable? #f [...])
and IIUC, the code inside expression->initrd copies the kernel module
into
the new store item, so it looks like this accidentally suggest people
to
commit copyvios, and copyvios are currently against the law.
Greetings,
Maxime.
(*) Though I don't understand that comment: Guix is a distribution, so
by definition
it's distributing zfs -- unless it's only talking about the binaries
and not the
source code ...
--=-GE9Q+CrVfXqiuTqWmUXp
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYn6+whccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7tLWAP43VVfdGmeFc9n0cZfORPFbnUiG
b2Lnn8OyvxuhJtatbQEAlkKAnfaCenTjzuTbHXXUmzswBC/4ZzWpl4AtlxOWSQ8=
=lAgN
-----END PGP SIGNATURE-----
--=-GE9Q+CrVfXqiuTqWmUXp--
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 13 May 2022 19:46:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 13 15:46:20 2022 Received: from localhost ([127.0.0.1]:45080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1npbEy-0007PC-6L for submit <at> debbugs.gnu.org; Fri, 13 May 2022 15:46:20 -0400 Received: from mail-40138.protonmail.ch ([185.70.40.138]:13975) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <kaelyn.alexi@HIDDEN>) id 1npbEw-0007Oy-2H for 55231 <at> debbugs.gnu.org; Fri, 13 May 2022 15:46:18 -0400 Date: Fri, 13 May 2022 19:46:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail2; t=1652471170; x=1652730370; bh=8jQUkjaGsOdNjWHjXT41h4SNsXREShc41EWYMNFdmwk=; h=Date:To:From:Reply-To:Subject:Message-ID:Feedback-ID:From:To:Cc: Date:Subject:Reply-To:Feedback-ID:Message-ID; b=gDAlUBEqqAS8lwHmrVqdIJgbFt+aZBvyEcAZShoEP5ODhZB41RFoj4gcEwLKe5Eei TWUybaRMNMJxdxCcN+CM9M170cx3B1rzHUw/K/dGeJNdFue9J3IoLiVAWrKEO9RCmW MzgEpL3Puhp7H9dHJ2VNmCO3EHYIrhwYqLxKe2+Ocjd8IJpMO9mvcTjRf3W3LzKmii lbr7ISfMFLmWKPmJlpRBCtoPbncnClKA5yVIOV2Eqzn1gE6tSijSx5ZlS/NNO8MwKW 6gOuSi9NfAA+asSQdwGYy6RxSoyjzFzMeDSr/Co7PS7K6HqqETpt6VLd/jNRBOG3RW m1WXJWKwCJUJA== To: "55231 <at> debbugs.gnu.org" <55231 <at> debbugs.gnu.org> From: Kaelyn <kaelyn.alexi@HIDDEN> Subject: =?utf-8?Q?[PATCH_v1]_initrd:_Allow_extra_search_paths_with_=E2=80=98initrd-extra-module-paths=E2=80=99?= Message-ID: <j3O4Vb5dVlLA_P-LaSEH-2wB7aPJM3Zlupj1seuNjR34OijQwAiM9ZECRx309TmNwIejOzHv_W5lkUkeQC8MqGTbK3kqjcZa3fCx440oWcw=@protonmail.com> Feedback-ID: 34709329:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55231 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Reply-To: Kaelyn <kaelyn.alexi@HIDDEN> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) I've read through the original patch and the doc patch, and based on my own= tinkering with guix initrd generation, the patches look good to me. I'm al= so happy to see the functionality being added, and already have plans for u= sing it with zfs (to further the goal of an encrypted multi-disk zfs root). Cheers, Kaelyn
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at 55231) by debbugs.gnu.org; 2 May 2022 22:55:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 02 18:55:20 2022
Received: from localhost ([127.0.0.1]:38263 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nlewq-0002ZI-0d
for submit <at> debbugs.gnu.org; Mon, 02 May 2022 18:55:20 -0400
Received: from coleridge.kublai.com ([166.84.7.167]:57300 helo=mail.spork.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjc@HIDDEN>) id 1nlewo-0002ZA-5i
for 55231 <at> debbugs.gnu.org; Mon, 02 May 2022 18:55:18 -0400
Received: from ditto (unknown [IPv6:2001:470:1f07:1b9:8650:a942:ec5e:856b])
by mail.spork.org (Postfix) with ESMTPSA id BCCE755FF;
Mon, 2 May 2022 18:55:07 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim;
t=1651532117; bh=NO9Rci0bsXvPsmtn24mKPzumpNi0MfZAYg/H9ioZ7hQ=;
h=References:From:To:Cc:Subject:Date:In-reply-to;
b=MlfUQYH7c3Of4W9f651wQaFR3xpo2bmYvqYpkXcevQcv7BM3/cmTHklp7VZBUWgJo
7bt/L/9iMuiMn/tN4Jkn2BUvNYArIvagqjYOp9p2TDPbDe4Edd0iBZoQPxYgV08+OB
NkwZOMRWImo0FwDStO0RXqvqhQgGuN2YpY4zhpxg=
References: <87wnf3pv87.fsf@HIDDEN>
<c87a1c647289c0f0fb60773e2fd50916861b4d8b.camel@HIDDEN>
User-agent: mu4e 1.6.10; emacs 28.1
From: Brian Cully <bjc@HIDDEN>
To: Maxime Devos <maximedevos@HIDDEN>
Subject: Re: [bug#55231] [PATCH v1] initrd: Allow extra search paths with
=?utf-8?Q?=E2=80=98initrd-extra-module-paths=E2=80=99?=
Date: Mon, 02 May 2022 18:53:31 -0400
In-reply-to: <c87a1c647289c0f0fb60773e2fd50916861b4d8b.camel@HIDDEN>
Message-ID: <87sfprpmt3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 55231
Cc: 55231 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Maxime Devos <maximedevos@HIDDEN> writes:
> This needs some information in the manual -- when does the field=20
> need
> to be set? For what kernel modules? Is this required by=20
> v4l2loopback-
> linux-module and librem-ec-acpi-linux-module? Things like that.
> As-is, this functionality is hard to discover.
I knew I missed something. How=E2=80=99s this look?
---
doc/guix.texi | 42 ++++++++++++++++++++++++++++++++++--------
1 file changed, 34 insertions(+), 8 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 5399584cb0..1ee2c1b4a3 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -15173,6 +15173,16 @@ Window System.
The list of Linux kernel modules that need to be available in the
initial RAM disk. @xref{Initial RAM Disk}.
=20
+@item @code{initrd-extra-module-paths} (default: @code{'()})
+@cindex initrd
+@cindex initial RAM disk
+A list of paths outside of the Linux kernel tree to search for=20
Linux
+kernel modules.
+
+The items in this may be either file-like objects (usually=20
packages), or
+a list where the first element is a package and the second is an
+output--e.g. @code{(list (list zfs "module"))}.
+
@item @code{initrd} (default: @code{base-initrd})
A procedure that returns an initial RAM disk for the Linux
kernel. This field is provided to support low-level=20
customization and
@@ -35516,6 +35526,19 @@ file system, you would write:
(initrd-modules (cons "megaraid_sas" %base-initrd-modules)))
@end lisp
=20
+If a module listed in @code{initrd-modules} is not included in=20
the
+Linux-libre kernel, then the location to it must be added to the
+@code{initrd-extra-module-paths} list. For example, if your root=20
file
+system exists on a ZFS pool, then your configuration might look=20
like the
+following:
+
+@lisp
+(operating-system
+ ;; @dots{}
+ (initrd-modules (cons "zfs" %base-initrd-modules))
+ (initrd-extra-module-paths (list (list zfs "module"))))
+@end lisp
+
@defvr {Scheme Variable} %base-initrd-modules
This is the list of kernel modules included in the initrd by=20
default.
@end defvr
@@ -35629,13 +35652,15 @@ here is how to use it and customize it=20
further.
@cindex initrd
@cindex initial RAM disk
@deffn {Scheme Procedure} raw-initrd @var{file-systems} @
- [#:linux-modules '()] [#:mapped-devices '()] @
- [#:keyboard-layout #f] @
+ [#:linux-modules '()] [#:linux-extra-module-paths '()] @
+ [#:mapped-devices '()] [#:keyboard-layout #f] @
[#:helper-packages '()] [#:qemu-networking? #f]=20
[#:volatile-root? #f]
Return a derivation that builds a raw initrd. @var{file-systems}=20
is
a list of file systems to be mounted by the initrd, possibly in=20
addition to
the root file system specified on the kernel command line via=20
@option{root}.
@var{linux-modules} is a list of kernel modules to be loaded at=20
boot time.
+@var{linux-extra-module-paths} is a list of file-like objects to=20
be searched
+for kernel modules.
@var{mapped-devices} is a list of device mappings to realize=20
before
@var{file-systems} are mounted (@pxref{Mapped Devices}).
@var{helper-packages} is a list of packages to be copied in the=20
initrd.
@@ -35660,12 +35685,13 @@ to it are lost.
@deffn {Scheme Procedure} base-initrd @var{file-systems} @
[#:mapped-devices '()] [#:keyboard-layout #f] @
[#:qemu-networking? #f] [#:volatile-root? #f] @
- [#:linux-modules '()]
-Return as a file-like object a generic initrd, with kernel
-modules taken from @var{linux}. @var{file-systems} is a list of=20
file-systems to be
-mounted by the initrd, possibly in addition to the root file=20
system specified
-on the kernel command line via @option{root}.=20
@var{mapped-devices} is a list of device
-mappings to realize before @var{file-systems} are mounted.
+ [#:linux-modules '()] [#:linux-extra-module-paths '()]
+Return as a file-like object a generic initrd, with kernel=20
modules taken
+from @var{linux} and @var{linux-extra-module-paths}.=20
@var{file-systems}
+is a list of file-systems to be mounted by the initrd, possibly=20
in
+addition to the root file system specified on the kernel command=20
line
+via @option{root}. @var{mapped-devices} is a list of device=20
mappings to
+realize before @var{file-systems} are mounted.
=20
When true, @var{keyboard-layout} is a @code{<keyboard-layout>}=20
record denoting
the desired console keyboard layout. This is done before=20
@var{mapped-devices}
--=20
2.35.1
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.Received: (at 55231) by debbugs.gnu.org; 2 May 2022 22:03:57 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 02 18:03:57 2022 Received: from localhost ([127.0.0.1]:38240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1nle97-0001L5-Jq for submit <at> debbugs.gnu.org; Mon, 02 May 2022 18:03:57 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:50054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maximedevos@HIDDEN>) id 1nle95-0001Kv-5C for 55231 <at> debbugs.gnu.org; Mon, 02 May 2022 18:03:56 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id Ry3t270024UW6Th01y3tna; Tue, 03 May 2022 00:03:53 +0200 Message-ID: <c87a1c647289c0f0fb60773e2fd50916861b4d8b.camel@HIDDEN> Subject: Re: [bug#55231] [PATCH v1] initrd: Allow extra search paths with =?UTF-8?Q?=E2=80=98initrd-extra-module-paths=E2=80=99?= From: Maxime Devos <maximedevos@HIDDEN> To: Brian Cully <bjc@HIDDEN>, 55231 <at> debbugs.gnu.org Date: Tue, 03 May 2022 00:03:42 +0200 In-Reply-To: <87wnf3pv87.fsf@HIDDEN> References: <87wnf3pv87.fsf@HIDDEN> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-5cTRqjaDdOITOGA8BtZm" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1651529033; bh=XZzrAxdED9UE0kZqDG7/zrZguBSgAhh08TfHgfjeJ18=; h=Subject:From:To:Date:In-Reply-To:References; b=a1IMb0s5GIMCk2aJpsuGVMzA0jzezfT3Wd8wTZLFLrtz6h5kdGSb0EYqZoEGCfcxx 54YSgQrBwLjX8CbOq7J4zSOgRbevxyDbbKSy+rC45UCNJsQytrp/F9L2bKue7Yetef sBioKm3tFmgcm4gThpP/paG9owZOkSFKgVMKknKv0rS0B8NZ5gJLV861aPtM3s1Rzd yZtSDh8L0n7OQSvBHEKpIffORqakDBO+l/jzy3L1nIMcufTkuGccEf39i5QudrmZe8 5NGOAqsm3mbAT1RUjDV3MKu9N2dW/F6AMoJZUIo9k5QK3Bd9yVGq9k5/6ilws2z/YX Lg611BNeUBfYg== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 55231 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-5cTRqjaDdOITOGA8BtZm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Brian Cully via Guix-patches via schreef op ma 02-05-2022 om 15:11 [- 0400]: > This patch allows copying of out-of-tree kernel modules to the Linux > initrd. This needs some information in the manual -- when does the field need to be set? For what kernel modules? Is this required by v4l2loopback- linux-module and librem-ec-acpi-linux-module? Things like that. As-is, this functionality is hard to discover. Greetings, Maxime. --=-5cTRqjaDdOITOGA8BtZm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnBVPhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hICAP9CDCAYffBUwkoR9lfzmRg/llBf MbwZUM4GSZzfcnSn5QEAyofUp0BgfQaywlQmN6VYwaebfeGIVq7RjHqV4Dn2EAk= =fPl7 -----END PGP SIGNATURE----- --=-5cTRqjaDdOITOGA8BtZm--
guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 2 May 2022 19:54:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 02 15:54:11 2022
Received: from localhost ([127.0.0.1]:38041 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1nlc7W-0007Eo-QW
for submit <at> debbugs.gnu.org; Mon, 02 May 2022 15:54:11 -0400
Received: from lists.gnu.org ([209.51.188.17]:53716)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <bjc@HIDDEN>) id 1nlc7V-0007EY-Hr
for submit <at> debbugs.gnu.org; Mon, 02 May 2022 15:54:10 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:51000)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <bjc@HIDDEN>) id 1nlc7V-0003im-7Q
for guix-patches@HIDDEN; Mon, 02 May 2022 15:54:09 -0400
Received: from coleridge.kublai.com ([166.84.7.167]:53283 helo=mail.spork.org)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <bjc@HIDDEN>) id 1nlc7T-0004gU-3g
for guix-patches@HIDDEN; Mon, 02 May 2022 15:54:08 -0400
Received: from ditto (unknown [IPv6:2001:470:1f07:1b9:8650:a942:ec5e:856b])
by mail.spork.org (Postfix) with ESMTPSA id AAD7D5717
for <guix-patches@HIDDEN>; Mon, 2 May 2022 15:53:15 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim;
t=1651521195; bh=u+B+QyVD+9RTOMbyzoXzK6TU4GFt79n3l1oU6PKQJI4=;
h=From:To:Subject:Date;
b=iAiqhE7p1+86cqE/QfFtAmUv/a0C43yTldM18CZz6yFy6+QnFTKlhlySCpUdMcPh3
AqKxzxQWZnl/b02PFZY7Q39Hg6tVgzgFJjXf1RXB9QOOqAEa/UtK+LYmJloxdK/OGY
xr64CNKYwjX22yoXj6ArB5EaJJJvnRHc3gb96uWo=
User-agent: mu4e 1.6.10; emacs 28.1
From: Brian Cully <bjc@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH v1] =?UTF-8?q?initrd:=20Allow=20extra=20search=20paths=20w?=
=?UTF-8?q?ith=20=E2=80=98initrd-extra-module-paths=E2=80=99?=
Date: Mon, 2 May 2022 15:11:30 -0400
Message-ID: <87wnf3pv87.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=166.84.7.167; envelope-from=bjc@HIDDEN;
helo=mail.spork.org
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
This patch allows copying of out-of-tree kernel modules to the Linux
initrd.
For out-of-tree modules to found, an extra slot has been added to
=E2=80=98operating-system=E2=80=99: =E2=80=98initrd-extra-module-paths=E2=
=80=99, which contains a list
containing items of either FILE-LIKE or (FILE-LIKE OUTPUT) which will be
searched for modules in addition to the standard Linux module path. The
required modules can then be added to =E2=80=98initrd-modules=E2=80=99 as n=
ormal and all paths
will be searched for it, including for any modules depended on.
* gnu/build/linux-modules.scm (find-module-file): change DIRECTORY argument=
to
DIRECTORIES. Now takes a list of directories to search, rather than a single
one.
* gnu/system.scm <operating-system>: Add INITRD-EXTRA-MODULE-PATHS
field and accessor. Takes a list of file-like objects.
* gnu/system/linux-initrd.scm (flat-linux-module-directory): change LINUX
argument to PACKAGES. Now contains a list of file-likes to search for modul=
es.
(raw-initrd): Add LINUX-EXTRA-MODULE-PATHS keyword argument. Pass it
to (flat-linux-extra-module-paths) along with the selected LINUX package.
(base-initrd): Add LINUX-EXTRA-MODULE-PATHS keyword argument. Pass it
to (raw-initrd).
---
gnu/build/linux-modules.scm | 19 ++++++++------
gnu/system.scm | 5 ++++
gnu/system/linux-initrd.scm | 52 +++++++++++++++++++++++++------------
3 files changed, 51 insertions(+), 25 deletions(-)
diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scm
index 053720574b..97b7e429ea 100644
--- a/gnu/build/linux-modules.scm
+++ b/gnu/build/linux-modules.scm
@@ -225,8 +225,8 @@ (define (file-name->module-name file)
'.ko[.gz|.xz]' and normalizing it."
(normalize-module-name (strip-extension (basename file))))
=20
-(define (find-module-file directory module)
- "Lookup module NAME under DIRECTORY, and return its absolute file name.
+(define (find-module-file directories module)
+ "Lookup module NAME under DIRECTORIES, and return its absolute file name.
NAME can be a file name with or without '.ko', or it can be a module name.
Raise an error if it could not be found.
=20
@@ -247,16 +247,19 @@ (define names
(else chr)))
module))))
=20
- (match (find-files directory
- (lambda (file stat)
- (member (strip-extension
- (basename file)) names)))
+ (match (append-map (lambda (directory)
+ (find-files directory
+ (lambda (file _stat)
+ (member (strip-extension
+ (basename file))
+ names))))
+ directories)
((file)
file)
(()
- (error "kernel module not found" module directory))
+ (error "kernel module not found" module directories))
((_ ...)
- (error "several modules by that name" module directory))))
+ (error "several modules by that name" module directories))))
=20
(define* (recursive-module-dependencies files
#:key (lookup-module dot-ko))
diff --git a/gnu/system.scm b/gnu/system.scm
index c3810cbeeb..15ac30c933 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -103,6 +103,7 @@ (define-module (gnu system)
operating-system-label
operating-system-default-label
operating-system-initrd-modules
+ operating-system-initrd-extra-module-paths
operating-system-initrd
operating-system-users
operating-system-groups
@@ -232,6 +233,8 @@ (define-record-type* <operating-system> operating-system
(initrd-modules operating-system-initrd-modules ; list of strings
(thunked) ; it's system-dependent
(default %base-initrd-modules))
+ (initrd-extra-module-paths operating-system-initrd-extra-module-paths ; =
list of file-likes
+ (default '()))
=20
(firmware operating-system-firmware ; list of packages
(default %base-firmware))
@@ -1307,6 +1310,8 @@ (define make-initrd
#:linux (operating-system-kernel os)
#:linux-modules
(operating-system-initrd-modules os)
+ #:linux-extra-module-paths
+ (operating-system-initrd-extra-module-paths os)
#:mapped-devices mapped-devices
#:keyboard-layout (operating-system-keyboard-layout os)))
=20
diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm
index 4c4c78e444..50a182d7d5 100644
--- a/gnu/system/linux-initrd.scm
+++ b/gnu/system/linux-initrd.scm
@@ -119,13 +119,23 @@ (define builder
`(#:references-graphs (("closure" ,init))))
"/initrd.cpio.gz"))
=20
-(define (flat-linux-module-directory linux modules)
+(define (flat-linux-module-directory packages modules)
"Return a flat directory containing the Linux kernel modules listed in
-MODULES and taken from LINUX."
+MODULES and taken from PACKAGES."
(define imported-modules
(source-module-closure '((gnu build linux-modules)
(guix build utils))))
=20
+ (define (package+out->input package out)
+ (gexp-input package out))
+
+ (define package-inputs
+ (map (lambda (p)
+ (match p
+ ((p o) (package+out->input p o))
+ (p (package+out->input p "out"))))
+ packages))
+
(define build-exp
(with-imported-modules imported-modules
(with-extensions (list guile-zlib)
@@ -135,11 +145,12 @@ (define build-exp
(srfi srfi-1)
(srfi srfi-26))
=20
- (define module-dir
- (string-append #$linux "/lib/modules"))
+ (define module-dirs
+ (map (cut string-append <> "/lib/modules")
+ '#$package-inputs))
=20
(define modules
- (let* ((lookup (cut find-module-file module-dir <>))
+ (let* ((lookup (cut find-module-file module-dirs <>))
(modules (map lookup '#$modules)))
(append modules
(recursive-module-dependencies
@@ -172,20 +183,23 @@ (define* (raw-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-paths '())
(mapped-devices '())
(keyboard-layout #f)
(helper-packages '())
qemu-networking?
volatile-root?
(on-error 'debug))
- "Return as a file-like object a raw initrd, with kernel
-modules taken from LINUX. FILE-SYSTEMS is a list of file-systems to be
-mounted by the initrd, possibly in addition to the root file system specif=
ied
-on the kernel command line via 'root'. LINUX-MODULES is a list of kernel
-modules to be loaded at boot time. MAPPED-DEVICES is a list of device
-mappings to realize before FILE-SYSTEMS are mounted.
-HELPER-PACKAGES is a list of packages to be copied in the initrd. It may i=
nclude
-e2fsck/static or other packages needed by the initrd to check root partiti=
on.
+ "Return as a file-like object a raw initrd, with kernel modules taken fr=
om
+LINUX. FILE-SYSTEMS is a list of file-systems to be mounted by the initrd,
+possibly in addition to the root file system specified on the kernel comma=
nd
+line via 'root'. LINUX-MODULES is a list of kernel modules to be loaded at
+boot time. LINUX-EXTRA-MODULE-PATHS is a list of file-like objects which w=
ill
+be searched for modules in addition to the linux kernel. MAPPED-DEVICES is=
a
+list of device mappings to realize before FILE-SYSTEMS are mounted.
+HELPER-PACKAGES is a list of packages to be copied in the initrd. It may
+include e2fsck/static or other packages needed by the initrd to check root
+partition.
=20
When true, KEYBOARD-LAYOUT is a <keyboard-layout> record denoting the desi=
red
console keyboard layout. This is done before MAPPED-DEVICES are set up and
@@ -221,7 +235,8 @@ (define file-system-scan-commands
#~())))
=20
(define kodir
- (flat-linux-module-directory linux linux-modules))
+ (flat-linux-module-directory (cons linux linux-extra-module-paths)
+ linux-modules))
=20
(expression->initrd
(with-imported-modules (source-module-closure
@@ -366,6 +381,7 @@ (define* (base-initrd file-systems
#:key
(linux linux-libre)
(linux-modules '())
+ (linux-extra-module-paths '())
(mapped-devices '())
(keyboard-layout #f)
qemu-networking?
@@ -386,9 +402,10 @@ (define* (base-initrd file-systems
QEMU-NETWORKING? and VOLATILE-ROOT? behaves as in raw-initrd.
=20
The initrd is automatically populated with all the kernel modules necessary
-for FILE-SYSTEMS and for the given options. Additional kernel
-modules can be listed in LINUX-MODULES. They will be added to the initrd,=
and
-loaded at boot time in the order in which they appear."
+for FILE-SYSTEMS and for the given options. Additional kernel modules can=
be
+listed in LINUX-MODULES. Additional search paths for modules can be liste=
d in
+LINUX-EXTRA-MODULE-PATHS. They will be added to the initrd, and loaded at
+boot time in the order in which they appear."
(define linux-modules*
;; Modules added to the initrd and loaded from the initrd.
`(,@linux-modules
@@ -408,6 +425,7 @@ (define helper-packages
(raw-initrd file-systems
#:linux linux
#:linux-modules linux-modules*
+ #:linux-extra-module-paths linux-extra-module-paths
#:mapped-devices mapped-devices
#:helper-packages helper-packages
#:keyboard-layout keyboard-layout
base-commit: 0a64b629ae8512790d532158a72a4a25698e8157
prerequisite-patch-id: 213ce2b9743f11d45836fe0794f117f3bb84063d
--=20
2.35.1
Brian Cully <bjc@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#55231; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.