GNU logs - #55270, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#55270: unpack phase randomly changes the cwd
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Thu, 05 May 2022 11:17:01 +0000
Resent-Message-ID: <handler.55270.B.165174940923388 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 55270 <at> debbugs.gnu.org
Reply-To: Attila Lendvai <attila@HIDDEN>
Date: Thu, 05 May 2022 11:16:29 +0000
From: Attila Lendvai <attila@HIDDEN>
Message-ID: <IN6Ty5_9Tk68JceEubR3zTKjm8XTJOPv4-llOHUM18euCVLhGnRAeB_ncVn3AC2PbfDu_63Zq0YXlxXYHX8186pUHrciuQdCJCfH8TS69k4=@lendvai.name>
Feedback-ID: 28384833:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=185.70.43.17; envelope-from=attila@HIDDEN;
 helo=mail-4317.proton.ch
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

at the end of the unpack phase, the working directory is changed to a rando=
m directory.

https://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/gnu-build-system=
.scm#n178

this is fine *when* the archive contains a single dir... but this DWIM'ness=
 has just burned 15 mintues of my life, and i recommend removing it.

if it is to stay, then at least it should be patched that it only happens w=
hen the dir after extraction only contains a single subdir, and no files ot=
herwise.

--
=E2=80=A2 attila lendvai
=E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39
--
=E2=80=9CWhen men hire themselves out to shoot other men to order, asking n=
othing about the justice of their cause, I don=E2=80=99t care if they are s=
hot themselves.=E2=80=9D
=09=E2=80=94 Herbert Spencer (1820=E2=80=931903), during Britain's second A=
fghan war

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Attila Lendvai <attila@HIDDEN>
Subject: bug#55270: Acknowledgement (unpack phase randomly changes the cwd)
Message-ID: <handler.55270.B.165174940923388.ack <at> debbugs.gnu.org>
References: <IN6Ty5_9Tk68JceEubR3zTKjm8XTJOPv4-llOHUM18euCVLhGnRAeB_ncVn3AC2PbfDu_63Zq0YXlxXYHX8186pUHrciuQdCJCfH8TS69k4=@lendvai.name>
X-Gnu-PR-Message: ack 55270
X-Gnu-PR-Package: guix
Reply-To: 55270 <at> debbugs.gnu.org
Date: Thu, 05 May 2022 11:17:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 55270 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
55270: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55270
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#55270: unpack phase randomly changes the cwd
Resent-From: Maxime Devos <maximedevos@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Thu, 05 May 2022 12:19:01 +0000
Resent-Message-ID: <handler.55270.B55270.165175311124875 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Attila Lendvai <attila@HIDDEN>, 55270 <at> debbugs.gnu.org
Message-ID: <378a823f4ae3a60c2d3ad419b22958524c933b19.camel@HIDDEN>
From: Maxime Devos <maximedevos@HIDDEN>
Date: Thu, 05 May 2022 14:18:21 +0200
In-Reply-To: <IN6Ty5_9Tk68JceEubR3zTKjm8XTJOPv4-llOHUM18euCVLhGnRAeB_ncVn3AC2PbfDu_63Zq0YXlxXYHX8186pUHrciuQdCJCfH8TS69k4=@lendvai.name>
References: <IN6Ty5_9Tk68JceEubR3zTKjm8XTJOPv4-llOHUM18euCVLhGnRAeB_ncVn3AC2PbfDu_63Zq0YXlxXYHX8186pUHrciuQdCJCfH8TS69k4=@lendvai.name>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-8nR/8CzggRC0XvhF0o4q"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>


--=-8nR/8CzggRC0XvhF0o4q
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Attila Lendvai schreef op do 05-05-2022 om 11:16 [+0000]:
> at the end of the unpack phase, the working directory is changed to a ran=
dom directory.
>=20
> https://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/gnu-build-syst=
em.scm#n178

It takes the first result 'scandir' -- i.e., the 'smallest' file name
according to string-locale<?, so technically it's not random (so no
reproducibility problems)

>=20
> this is fine *when* the archive contains a single dir... but this DWIM'ne=
ss has just burned 15 mintues of my life, and i recommend removing it.
>=20
> if it is to stay, then at least it should be patched that it only happens=
 when the dir after extraction only contains a single subdir, and no files =
otherwise.

Except maybe when using 'out-of-source?', I think it has to stay in
some form -- somehow, we will have to run build scripts, "make", maybe
do some 'substitute*', and having to type the version number and
directory name inside build phases seems a bit error-prone (what if the
source is changed fom tarball or 'zip' to a vcs checkout?).

I agree with only chdiring if there's only one subdir (and no other
files) though -- =E2=80=98just the first=E2=80=99 is a bit arbitrary.

Greetings,
Maxime.

--=-8nR/8CzggRC0XvhF0o4q
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYnPAjRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hcPAQCFW/Nxza6Q/6DPskwK3/dzFebz
aUV1g5TI31LsC29bPwD/SVm+R3wlX4KhqNDtMtfQ3vKEDM/rLKd+8HkMLCSshgc=
=ci5l
-----END PGP SIGNATURE-----

--=-8nR/8CzggRC0XvhF0o4q--

Message sent to bug-guix@HIDDEN:

Subject: bug#55270: unpack phase randomly changes the cwd
Resent-From: Attila Lendvai <attila@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Thu, 05 May 2022 13:16:02 +0000
Resent-Message-ID: <handler.55270.B55270.165175654726747 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Maxime Devos <maximedevos@HIDDEN>
Cc: 55270 <at> debbugs.gnu.org
Reply-To: Attila Lendvai <attila@HIDDEN>
Date: Thu, 05 May 2022 13:15:28 +0000
From: Attila Lendvai <attila@HIDDEN>
Message-ID: <Bp8HCSiQBKqwlPg7xZPY-2mqTh7jppBKwk0rBCg5cJ2N7MHGm2ci-jsXnKjRqDRc7N2oXR5xJ_eeekBJfUZQew45gnA1WeGFTMwMEcGZ0_I=@lendvai.name>
In-Reply-To: <378a823f4ae3a60c2d3ad419b22958524c933b19.camel@HIDDEN>
References: <IN6Ty5_9Tk68JceEubR3zTKjm8XTJOPv4-llOHUM18euCVLhGnRAeB_ncVn3AC2PbfDu_63Zq0YXlxXYHX8186pUHrciuQdCJCfH8TS69k4=@lendvai.name>
 <378a823f4ae3a60c2d3ad419b22958524c933b19.camel@HIDDEN>
Feedback-ID: 28384833:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> It takes the first result 'scandir' -- i.e., the 'smallest' file name
> according to string-locale<?, so technically it's not random (so no
> reproducibility problems)


fair enough. what i meant to communicate is that it's arbitrary, not random=
.

another potential issue:

if the root of the archive contains a file called 'environment-variables', =
then this way it would overwrite the one generated by Guix. this may not ne=
cessarily be an issue, though, if that file is never used after the unpack =
phase.

maybe the cleanest would be to:

1) mkdir a directory ('extracted/'?) and chdir into it prior to
   unpacking, and

2) only do the DWIM chdir if the toplevel of the archive was a single
   dir.

but i lack the necessary perspective to see all the implications.

--
=E2=80=A2 attila lendvai
=E2=80=A2 PGP: 963F 5D5F 45C7 DFCD 0A39
--
=E2=80=9CThere is always a philosophy for lack of courage.=E2=80=9D
=09=E2=80=94 Albert Camus (1913=E2=80=931960)

Last modified: Thu, 5 May 2022 13:30:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.