GNU bug report logs - #55275
29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't force usage of the cache

Previous Next

Package: emacs;

Reported by: Eric Abrahamsen <eric <at> ericabrahamsen.net>

Date: Thu, 5 May 2022 15:29:01 UTC

Severity: normal

Found in version 29.0.50

Done: Eric Abrahamsen <eric <at> ericabrahamsen.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55275 in the body.
You can then email your comments to 55275 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#55275; Package emacs. (Thu, 05 May 2022 15:29:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Eric Abrahamsen <eric <at> ericabrahamsen.net>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 05 May 2022 15:29:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't force usage of
 the cache
Date: Thu, 05 May 2022 08:28:39 -0700
In ./lisp/gnus/nnvirtual.el, the `nnvirtual-retrieve-headers' deffoo
let-binds `gnus-use-cache' to t when it uses `gnus-retrieve-headers' on
its various constituent groups. For users not using the cache, this
will result in an error.

I can put an additional check in gnus-cache.el when we call
`gnus-cache-retrieve-headers', but it would be nice to know why this
necessary in the first place. The code comment on
`nnvirtual-retrieve-headers' says:

;; FIX FIX FIX we want to check the cache!
;; This is probably evil if people have set
;; gnus-use-cache to nil themselves, but I
;; have no way of finding the true value of it.

All the above is true, except I don't understand why we want to check
the cache. This code is ancient and I'm only medium-hopeful Lars
remembers the reasoning here, but on the face of it I don't know why we
need to force a check of the cache. It seems like we could simply remove
that, and the cache will still be checked iff the user has set
`gnus-use-cache' to t.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#55275; Package emacs. (Fri, 06 May 2022 12:19:02 GMT) Full text and rfc822 format available.

Message #8 received at 55275 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 55275 <at> debbugs.gnu.org
Subject: Re: bug#55275: 29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't
 force usage of the cache
Date: Fri, 06 May 2022 14:17:46 +0200
Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> All the above is true, except I don't understand why we want to check
> the cache. This code is ancient and I'm only medium-hopeful Lars
> remembers the reasoning here, but on the face of it I don't know why we
> need to force a check of the cache. It seems like we could simply remove
> that, and the cache will still be checked iff the user has set
> `gnus-use-cache' to t.

I have no recollection of that code.  :-/

But, yes, I think removing that binding would be the right thing to do.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Reply sent to Eric Abrahamsen <eric <at> ericabrahamsen.net>:
You have taken responsibility. (Fri, 06 May 2022 17:19:02 GMT) Full text and rfc822 format available.

Notification sent to Eric Abrahamsen <eric <at> ericabrahamsen.net>:
bug acknowledged by developer. (Fri, 06 May 2022 17:19:02 GMT) Full text and rfc822 format available.

Message #13 received at 55275-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 55275-done <at> debbugs.gnu.org
Subject: Re: bug#55275: 29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't
 force usage of the cache
Date: Fri, 06 May 2022 10:17:54 -0700
On 05/06/22 14:17 PM, Lars Ingebrigtsen wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> All the above is true, except I don't understand why we want to check
>> the cache. This code is ancient and I'm only medium-hopeful Lars
>> remembers the reasoning here, but on the face of it I don't know why we
>> need to force a check of the cache. It seems like we could simply remove
>> that, and the cache will still be checked iff the user has set
>> `gnus-use-cache' to t.
>
> I have no recollection of that code.  :-/

It was a while ago :)

> But, yes, I think removing that binding would be the right thing to do.

Done.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 04 Jun 2022 11:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 299 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.