GNU bug report logs - #55310
27.2; vc-revert: unhelpful error message when modified buffers exist

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: "Alfred M. Szmidt" <ams@HIDDEN>; Keywords: moreinfo; dated Sun, 8 May 2022 07:42:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 55310 <at> debbugs.gnu.org:


Received: (at 55310) by debbugs.gnu.org; 9 May 2022 09:38:36 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 09 05:38:36 2022
Received: from localhost ([127.0.0.1]:56117 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nnzqe-0002jV-Im
	for submit <at> debbugs.gnu.org; Mon, 09 May 2022 05:38:36 -0400
Received: from quimby.gnus.org ([95.216.78.240]:39842)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1nnzqc-0002jH-MB
 for 55310 <at> debbugs.gnu.org; Mon, 09 May 2022 05:38:35 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
 References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=z+AblMsPep8f1IgVAqrtkVeKoX1mlzCh+zCiruhq92o=; b=CBQy40VXifa8afaJtPBOhClGQ3
 xoWsmB9ojuRnX2KEFeAIeuKDw2iQchn3HeDC/Ai77KIqzdILr9ydePh27FTcmBSR1DEjzjciIB04d
 Tr/JfwbfuqKDKrgkskDOq3n6X6a0jTEbds/r5/H4HunIAaduuZ7BZxt4vdPzRnVPC3sY=;
Received: from [84.212.220.105] (helo=xo)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1nnzqU-00044d-Jj; Mon, 09 May 2022 11:38:28 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: "Alfred M. Szmidt" <ams@HIDDEN>
Subject: Re: bug#55310: 27.2; vc-revert: unhelpful error message when
 modified buffers exist
References: <E1nnbY0-0002ze-78@HIDDEN> <87y1zcjljm.fsf@HIDDEN>
 <E1nnhoI-0007PC-RC@HIDDEN>
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj
 SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEX9/f0hDA67wq9T
 qNr2723e3diWXk27olJdTkhSp7b///+JyUX3AAAAAWJLR0QKaND0VgAAAAd0SU1FB+YFCQkjMC6A
 7ocAAAGVSURBVDjLtdG/T4NAFAfwy5Grrmdsy4inJR2bEBO7GYLWkTQe0c0QSxlNh9qx0BRulsX7
 b70fTXtAm+jgGxj48H3v3gHAoS4sz/NAoIoa70FvD0sBiO6RaVgmCZujIwkBaQ2QmhHKVqvABGiC
 ORx2JXQuFdy3Ei8SnoKH1owjoE8V9QQ8Br4JtgQ616uboBak722wT4AeTssW6D12YJ6q8yuobd6F
 nneXMblIEJrQF4kMZ7jfAFAg8ooF2I1Was4BIocs4imcExK7cX6GRfUUDNcJWxPIooLlcY4k9NVx
 h9uU5QQWLkvLPEcMY7tU4G6ZTrC02OYI6k4CosQlcURcogpNRWJS3xwl8pHZYg9KqbFHlHyIJTFm
 2JZfHMD9jAlZiU4423DOzcQMDDN5XLypxgagQYjKKw21hKpzBRWvmgDle3vMq3ED0Le4w4o34DkI
 fNG94k2QV8F1/St83fhkQK+92ybsLtwanQA4+ksCib9kOcBCoeOEFISIEt8PEllvwApbicmC6kQD
 Jhrqw8Ul6lYzgEY/cgiymJjq9IAAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDUtMDlUMDk6MzU6
 NDgrMDA6MDCOxssmAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA1LTA5VDA5OjM1OjQ4KzAwOjAw
 /5tzmgAAAABJRU5ErkJggg==
X-Now-Playing: Blaine L. Reininger's _Broken Fingers_: "Broken Fingers"
Date: Mon, 09 May 2022 11:38:26 +0200
In-Reply-To: <E1nnhoI-0007PC-RC@HIDDEN> (Alfred M. Szmidt's message
 of "Sun, 08 May 2022 10:22:58 -0400")
Message-ID: <87ilqfcagd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: "Alfred M. Szmidt" <ams@HIDDEN> writes: > I don't think we
 want to have an interface that offers to kill buffers > in a loop -- it sounds
 like something that's really error-prone, which > is why that code is the
 way it is, I think. (To make [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 55310
Cc: 55310 <at> debbugs.gnu.org, Dmitry Gutov <dgutov@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

"Alfred M. Szmidt" <ams@HIDDEN> writes:

>    I don't think we want to have an interface that offers to kill buffers
>    in a loop -- it sounds like something that's really error-prone, which
>    is why that code is the way it is, I think.  (To make the user make the
>    decision themselves explicitly.)
>
> We already support such mechanism I think in several other places,
> like ibuffer, etc.   

Sure, but that's a mode to list and act on buffers -- having vc-revert
kill buffers (even after querying the user) would be surprising.

> My main problem is really that it is impossible to know _which_
> buffers are modified, if you have several hundred open in several
> different projects -- in addition to the fact that the error message
> is just wrong ("all buffers" -- it is just some buffers, that are
> marked).

Yes, it would be nice if it actually said which buffers it's talking
about.

> Idea (ideas are cheap): maybe if one could add some sort of
> high-light, or something in vc-dired that shows that this or that file
> has a open buffer that is unmodified, and then the error could be the
> same but just saying that one should check the highlighted buffers.

I think that's a good idea -- perhaps Dmitry has some comments; added to
the CCs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#55310; Package emacs. Full text available.

Message received at 55310 <at> debbugs.gnu.org:


Received: (at 55310) by debbugs.gnu.org; 8 May 2022 14:23:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 08 10:23:06 2022
Received: from localhost ([127.0.0.1]:54990 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nnhoQ-0005ql-84
	for submit <at> debbugs.gnu.org; Sun, 08 May 2022 10:23:06 -0400
Received: from eggs.gnu.org ([209.51.188.92]:46718)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ams@HIDDEN>) id 1nnhoO-0005q5-DE
 for 55310 <at> debbugs.gnu.org; Sun, 08 May 2022 10:23:04 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:57066)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ams@HIDDEN>)
 id 1nnhoJ-0002lX-0u; Sun, 08 May 2022 10:22:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=Date:References:Subject:In-Reply-To:To:From:
 mime-version; bh=0aMcdm+GqDT5pARd8qXn08XYthH6KwPKXJS+mPNLt7c=; b=Te6DgRdBayg4
 lq/66rjOzvqiZPKuyQd4MsW1XzRqmUVxOnrlj4ZzN4nzSVn9jVsENTd7XnQivc0oxqJTuJnqbQIwZ
 qp3p94DN6nybSYbiUwBW84CjxsisQYC/0PBeIRGr9zD/MI7y8V3B6YUrrY/PsDzyEsY3shKBoFF1V
 YTn8EbQgOoLO1HW32OSJGw6B2MdyjPSacJT1KqB8lFAX3bqqnDeZZAF8AXw0mF2qTqiXmPJAVfytE
 XpuNRPIrtZFLiQ+LdFPj4qUB3eJw/41flKRpKXoruAVd2lEpzhI1Z1KLECUPIm8mCb4qV4M+W0Z8+
 Ak40eDXWfgWDjHJDcLfosQ==;
Received: from ams by fencepost.gnu.org with local (Exim 4.90_1)
 (envelope-from <ams@HIDDEN>)
 id 1nnhoI-0007PC-RC; Sun, 08 May 2022 10:22:58 -0400
From: "Alfred M. Szmidt" <ams@HIDDEN>
To: Lars Ingebrigtsen <larsi@HIDDEN>
In-Reply-To: <87y1zcjljm.fsf@HIDDEN> (message from Lars Ingebrigtsen on Sun, 
 08 May 2022 13:44:45 +0200)
Subject: Re: bug#55310: 27.2; vc-revert: unhelpful error message when
 modified buffers exist
References: <E1nnbY0-0002ze-78@HIDDEN> <87y1zcjljm.fsf@HIDDEN>
Message-Id: <E1nnhoI-0007PC-RC@HIDDEN>
Date: Sun, 08 May 2022 10:22:58 -0400
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 55310
Cc: 55310 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


   "Alfred M. Szmidt" <ams@HIDDEN> writes:

   > When doing vc-revert in a vc-dir buffer, and when one has a bunch of
   > open files, one somtimes gets the unhelpful message:
   >
   >   vc-revert: Please kill or save all modified buffers before reverting
   >
   > Nicer would be prompting the user to kill/save those buffers, or list them.

   I don't think we want to have an interface that offers to kill buffers
   in a loop -- it sounds like something that's really error-prone, which
   is why that code is the way it is, I think.  (To make the user make the
   decision themselves explicitly.)

We already support such mechanism I think in several other places,
like ibuffer, etc.   


My main problem is really that it is impossible to know _which_
buffers are modified, if you have several hundred open in several
different projects -- in addition to the fact that the error message
is just wrong ("all buffers" -- it is just some buffers, that are
marked).

Idea (ideas are cheap): maybe if one could add some sort of
high-light, or something in vc-dired that shows that this or that file
has a open buffer that is unmodified, and then the error could be the
same but just saying that one should check the highlighted buffers.


   So I think leaving it the way it is is the best option here, since this
   command is one of the most potentially destructive ones we have in
   Emacs.  Anybody have an opinion here?

The destructiveness of vc-revert also depends on the version control
system, fossil provides a undo mechanism.  But doing delete on files
in dired is far worse ...  :-)




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#55310; Package emacs. Full text available.
Added tag(s) moreinfo. Request was from Lars Ingebrigtsen <larsi@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 55310 <at> debbugs.gnu.org:


Received: (at 55310) by debbugs.gnu.org; 8 May 2022 11:44:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 08 07:44:58 2022
Received: from localhost ([127.0.0.1]:53494 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nnfLN-0004u2-Q6
	for submit <at> debbugs.gnu.org; Sun, 08 May 2022 07:44:58 -0400
Received: from quimby.gnus.org ([95.216.78.240]:57926)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <larsi@HIDDEN>) id 1nnfLM-0004tn-7t
 for 55310 <at> debbugs.gnu.org; Sun, 08 May 2022 07:44:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
 s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
 References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
 Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
 Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
 List-Subscribe:List-Post:List-Owner:List-Archive;
 bh=R3ayTrpiILGA5Cl7aRrWAxE/eJcfHU1PSTb5aS7LqU0=; b=ZTxgBCn7cz3lsWtGcKpfFQ7G2i
 t8Fq4Eyq9mEzWPp4VAiGtvfhD96JpOZtXEg1lfiLUVqZOmxLYE0lITzG6Om90nj5HLynVNZx3i4Xv
 LaGH0t5r82CRh8Llj+2g1UBZEOJoE+WEa8w0eVHeGkA7EEqlbWMTEXcRYWP5zPcfGFhI=;
Received: from [84.212.220.105] (helo=xo)
 by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.92) (envelope-from <larsi@HIDDEN>)
 id 1nnfLD-0007tK-3l; Sun, 08 May 2022 13:44:49 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: "Alfred M. Szmidt" <ams@HIDDEN>
Subject: Re: bug#55310: 27.2; vc-revert: unhelpful error message when
 modified buffers exist
References: <E1nnbY0-0002ze-78@HIDDEN>
X-Now-Playing: Nina Simone's _The Montreux Years (1)_: "Don't Smoke in Bed
 (Live At Casino Montreux, 13th July 1990)"
Date: Sun, 08 May 2022 13:44:45 +0200
In-Reply-To: <E1nnbY0-0002ze-78@HIDDEN> (Alfred M. Szmidt's message
 of "Sun, 08 May 2022 03:41:44 -0400")
Message-ID: <87y1zcjljm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 @@CONTACT_ADDRESS@@ for details.
 Content preview: "Alfred M. Szmidt" <ams@HIDDEN> writes: > When doing
 vc-revert
 in a vc-dir buffer, and when one has a bunch of > open files, one somtimes
 gets the unhelpful message: > > vc-revert: Please kill or save all modified
 buffers before reverting > [...] 
 Content analysis details:   (-2.9 points, 5.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
 [score: 0.0000]
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 55310
Cc: 55310 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

"Alfred M. Szmidt" <ams@HIDDEN> writes:

> When doing vc-revert in a vc-dir buffer, and when one has a bunch of
> open files, one somtimes gets the unhelpful message:
>
>   vc-revert: Please kill or save all modified buffers before reverting
>
> Nicer would be prompting the user to kill/save those buffers, or list them.

I don't think we want to have an interface that offers to kill buffers
in a loop -- it sounds like something that's really error-prone, which
is why that code is the way it is, I think.  (To make the user make the
decision themselves explicitly.)

We could do this, of course:

diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
index 3508f684c4..cb5e42db4c 100644
--- a/lisp/vc/vc.el
+++ b/lisp/vc/vc.el
@@ -2780,6 +2780,10 @@ vc-revert
     ;; show the changes and ask for confirmation to discard them.
     (when (or (not files) (memq (buffer-file-name) files))
       (vc-buffer-sync nil))
+    ;; Offer to save all the buffers we're reverting.
+    (save-some-buffers
+     nil (lambda ()
+           (member (buffer-file-name) files)))
     (dolist (file files)
       (let ((buf (get-file-buffer file)))
 	(when (and buf (buffer-modified-p buf))


But if the user answers "no", then it'll just signal an error anyway, so
that's just confusing.

So I think leaving it the way it is is the best option here, since this
command is one of the most potentially destructive ones we have in
Emacs.  Anybody have an opinion here?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#55310; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 8 May 2022 07:41:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 08 03:41:48 2022
Received: from localhost ([127.0.0.1]:53369 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nnbY3-000548-Tb
	for submit <at> debbugs.gnu.org; Sun, 08 May 2022 03:41:48 -0400
Received: from lists.gnu.org ([209.51.188.17]:46688)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ams@HIDDEN>) id 1nnbY2-000541-LK
 for submit <at> debbugs.gnu.org; Sun, 08 May 2022 03:41:47 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:59796)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ams@HIDDEN>) id 1nnbY2-00066n-EY
 for bug-gnu-emacs@HIDDEN; Sun, 08 May 2022 03:41:46 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:51316)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ams@HIDDEN>) id 1nnbY1-0001iE-9Z
 for bug-gnu-emacs@HIDDEN; Sun, 08 May 2022 03:41:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=Date:Subject:To:From:mime-version:in-reply-to:
 references; bh=+XdC70lxHP2SJeTmdOQorJ8SYDUrynsq1Yru9s9G0CM=; b=Bge/TKOrviptFT
 +62zDF06jrAgl8xM4D9qFV2vUGNpVFN09Un0VaRptELu5B/3G7/mmYE+dZ3D5VWoqtcFEQjr/hUl7
 PurrOWM+VDE+ndzdzpkCVZL86Nm1OgmpbKWyoYbg9JKWxhg3ZGQN8PEGJIFwFGR+3VKsLQzTSNEEq
 LsJ8lUylcaoe6NakaDy5tOXx8LJ7sGPV7PnpoxNS5p3ogCk4HQy6awx/lMNomhZcQuHioonoLDWii
 P8PxtZva5AiFsRG2DvzBxRDYTDMTrIHSs/JSp3vhEUsX+wECSehzt8wvOR1wQaXMgwY4RAXFHnRdX
 s2B0r0tTjzGVGy2UkcLQ==;
Received: from ams by fencepost.gnu.org with local (Exim 4.90_1)
 (envelope-from <ams@HIDDEN>) id 1nnbY0-0002ze-78
 for bug-gnu-emacs@HIDDEN; Sun, 08 May 2022 03:41:44 -0400
From: "Alfred M. Szmidt" <ams@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 27.2; vc-revert: unhelpful error message when modified buffers exist
Message-Id: <E1nnbY0-0002ze-78@HIDDEN>
Date: Sun, 08 May 2022 03:41:44 -0400
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


When doing vc-revert in a vc-dir buffer, and when one has a bunch of
open files, one somtimes gets the unhelpful message:

  vc-revert: Please kill or save all modified buffers before reverting

Nicer would be prompting the user to kill/save those buffers, or list them.


In GNU Emacs 27.2 (build 1, x86_64-unknown-openbsd, GTK+ Version 3.24.33)
 of 2022-04-09 built on amd64.ports.openbsd.org
System Description: OpenBSD nitrogenium.mendeleev 7.1 GENERIC.MP#465 amd64

Recent messages:
  INFO     Scraping files for loaddefs.el...done
Loading /home/ams/loaddefs.el (source)...done
Loading /home/ams/quicklisp/slime-helper.el (source)...done
Loading /home/ams/quicklisp/clhs-use-local.el (source)...done
Loading /home/ams/private/emacs-nitrogenium.mendeleev...done
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --build=amd64-unknown-openbsd --without-sound
 --with-x-toolkit=gtk3 --prefix=/usr/local --sysconfdir=/etc
 --mandir=/usr/local/man --infodir=/usr/local/info
 --localstatedir=/var --disable-silent-rules --disable-gtk-doc
 'CFLAGS=-O2 -pipe -g' CPPFLAGS=-I/usr/local/include
 'LDFLAGS=-L/usr/local/lib -g''

Configured features:
XPM JPEG TIFF GIF PNG RSVG DBUS GSETTINGS GLIB NOTIFY KQUEUE GNUTLS
LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS
GTK3 X11 XDBE XIM MODULES THREADS JSON PDUMPER LCMS2 GMP

Important settings:
  locale-coding-system: nil

Major mode: Fundamental

Minor modes in effect:
  global-company-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  transient-mark-mode: t

Load-path shadows:
~/loaddefs hides /usr/local/share/emacs/27.2/lisp/loaddefs

Features:
(shadow mailalias emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml mml-sec epa epg epg-config gnus-util rmail
rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader term/screen
term/xterm xterm rcirc time-date mail-queue sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils slime-asdf grep
slime-quicklisp slime-fancy slime-indentation slime-cl-indent
cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu
slime-references slime-compiler-notes-tree slime-scratch
slime-presentations advice bridge slime-macrostep macrostep
slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace
slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc
slime-repl elp slime-parse slime derived cl-extra help-mode gud
apropos compile arc-mode archive-mode noutline outline easy-mmode pp
comint ansi-color hyperspec thingatpt slime-autoloads company-oddmuse
company-keywords company-etags etags fileloop generator xref project
ring company-gtags company-dabbrev-code company-dabbrev company-files
company-capf company-cmake company-xcode company-clang
company-semantic company-eclim company-template company-bbdb company
edmacro kmacro pcase cal-menu calendar cal-loaddefs autoload
radix-tree lisp-mnt finder-inf disp-table package easymenu browse-url
url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese
eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic
indian cyrillic chinese composite charscript charprop case-table
epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind kqueue lcms2
dynamic-setting system-font-setting font-render-setting move-toolbar
gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 190926 10037)
 (symbols 48 15424 2)
 (strings 32 47013 758)
 (string-bytes 1 1409610)
 (vectors 16 17009)
 (vector-slots 8 200499 8642)
 (floats 8 62 187)
 (intervals 56 260 129)
 (buffers 1000 12))




Acknowledgement sent to "Alfred M. Szmidt" <ams@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#55310; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 9 May 2022 09:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.