GNU bug report logs - #55326
libgit2 1.3.0 includes a time-dependent test

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55326 in the body.
You can then email your comments to 55326 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: bug-guix <at> gnu.org
Subject: libgit2 1.3.0 includes a time-dependent test
Date: Sun, 08 May 2022 23:06:24 +0200

libgit2 1.3.0 (and 1.4.3, it seems) includes a time-dependent test:
‘refs::revparse::date’, in ‘tests/refs/revparse.c’, assumes
“HEAD@{10 years ago}” doesn't match anything in the sample repositories,
which is no longer true:

--8<---------------cut here---------------start------------->8---
$ date
Sun May  8 11:04:31 PM CEST 2022
$ ./libgit2_clar -v -Q -srefs::revparse::date
Loaded 404 suites: 
Started (test status codes: OK='.' FAILURE='F' SKIPPED='S')

refs::revparseF

  1) Failure:
refs::revparse::date [/tmp/guix-build-libgit2-1.3.0.drv-0/source/tests/refs/revparse.c:31]
  Function call succeeded: error
  no error, expected non-zero return

$ /gnu/store/wy3ww7znqhlg84vg6cmw1m12z1drxwh1-libfaketime-0.9.9/bin/faketime 2021-12-12 ./libgit2_clar -v -Q -srefs::revparse::date
Loaded 404 suites: 
Started (test status codes: OK='.' FAILURE='F' SKIPPED='S')

refs::revparse.

--8<---------------cut here---------------end--------------->8---

Thus, as of 6b588da368c77cde82ea2f22ca315116228777ad, libgit2 now fails
to build; a few months ago, it would build fine.

Ludo’.

Message #12 received at 55326-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: 55326-done <at> debbugs.gnu.org
Subject: Re: bug#55326: libgit2 1.3.0 includes a time-dependent test
Date: Mon, 09 May 2022 00:11:20 +0200

Ludovic Courtès <ludo <at> gnu.org> skribis:

> libgit2 1.3.0 (and 1.4.3, it seems) includes a time-dependent test:
> ‘refs::revparse::date’, in ‘tests/refs/revparse.c’, assumes
> “HEAD@{10 years ago}” doesn't match anything in the sample repositories,
> which is no longer true:

Fixed:

  e48b5484afde93294c4ed7215e88ed450842b2e5 (master)
  f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging)

Ludo’.

Message #15 received at 55326-done <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>, 
 55326-done <at> debbugs.gnu.org
Subject: Re: bug#55326: libgit2 1.3.0 includes a time-dependent test
Date: Mon, 09 May 2022 09:25:59 +0200

[Message part 1 (text/plain, inline)]

Ludovic Courtès schreef op ma 09-05-2022 om 00:11 [+0200]:
> Fixed:
> 
>   e48b5484afde93294c4ed7215e88ed450842b2e5 (master)
>   f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging)

It's still time-dependent though:

> +                  (substitute* "tests/refs/revparse.c"
> +                    (("10 years ago")
> +                     "100 years ago"))))))

wouldn't it now fail after ~100 or ~1000 years?
Though maybe by that time, we have complete time namespaces ...

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #18 received at 55326-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 55326-done <at> debbugs.gnu.org
Subject: Re: bug#55326: libgit2 1.3.0 includes a time-dependent test
Date: Mon, 09 May 2022 10:49:18 +0200

Maxime Devos <maximedevos <at> telenet.be> skribis:

> Ludovic Courtès schreef op ma 09-05-2022 om 00:11 [+0200]:
>> Fixed:
>> 
>>   e48b5484afde93294c4ed7215e88ed450842b2e5 (master)
>>   f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging)
>
> It's still time-dependent though:
>
>> +                  (substitute* "tests/refs/revparse.c"
>> +                    (("10 years ago")
>> +                     "100 years ago"))))))
>
> wouldn't it now fail after ~100 or ~1000 years?
> Though maybe by that time, we have complete time namespaces ...

Right, and remaining computers will have RISC-VII 100 MHz CPUs anyway.

Ludo’.

Message #21 received at 55326-done <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 55326-done <at> debbugs.gnu.org
Subject: Re: bug#55326: libgit2 1.3.0 includes a time-dependent test
Date: Mon, 09 May 2022 12:10:02 +0200

[Message part 1 (text/plain, inline)]

Ludovic Courtès schreef op ma 09-05-2022 om 10:49 [+0200]:
> Right, and remaining computers will have RISC-VII 100 MHz CPUs anyway.

I assume you meant 100GHz here instead?  Or very fast software that
doesn't need fast CPUs ...

[signature.asc (application/pgp-signature, inline)]

Message #24 received at 55326-done <at> debbugs.gnu.org (full text, mbox):

From: Carl Dong <contact <at> carldong.me>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 55326-done <at> debbugs.gnu.org
Subject: Re: bug#55326: libgit2 1.3.0 includes a time-dependent test
Date: Mon, 9 May 2022 15:33:14 -0400

[Message part 1 (text/plain, inline)]

I opened a pull request upstream that just removes the specific test for “HEAD@{10 years ago}". Since that functionality is well-covered by subsequent tests.

See here for the PR: https://github.com/libgit2/libgit2/pull/6299 <https://github.com/libgit2/libgit2/pull/6299>

> Though maybe by that time, we have complete time namespaces …
One would hope!

Cheers,
Carl Dong

> On May 9, 2022, at 3:25 AM, Maxime Devos <maximedevos <at> telenet.be> wrote:
> 
> Ludovic Courtès schreef op ma 09-05-2022 om 00:11 [+0200]:
>> Fixed:
>> 
>>   e48b5484afde93294c4ed7215e88ed450842b2e5 (master)
>>   f5fe0082abe4547f3fb9f29d8351473cfb3a387b (staging)
> 
> It's still time-dependent though:
> 
>> +                  (substitute* "tests/refs/revparse.c"
>> +                    (("10 years ago")
>> +                     "100 years ago"))))))
> 
> wouldn't it now fail after ~100 or ~1000 years?
> Though maybe by that time, we have complete time namespaces ...
> 
> Greetings,
> Maxime.

[Message part 2 (text/html, inline)]

[signature.asc (application/pgp-signature, attachment)]

Message #27 received at 55326-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Carl Dong <contact <at> carldong.me>
Cc: Maxime Devos <maximedevos <at> telenet.be>, 55326-done <at> debbugs.gnu.org
Subject: Re: bug#55326: libgit2 1.3.0 includes a time-dependent test
Date: Tue, 10 May 2022 17:48:52 +0200

Heya,

Carl Dong <contact <at> carldong.me> skribis:

> I opened a pull request upstream that just removes the specific test for “HEAD@{10 years ago}". Since that functionality is well-covered by subsequent tests.
>
> See here for the PR: https://github.com/libgit2/libgit2/pull/6299 <https://github.com/libgit2/libgit2/pull/6299>

Well done, thanks!

Ludo’.

Message #30 received at 55326-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 55326-done <at> debbugs.gnu.org
Subject: Re: bug#55326: libgit2 1.3.0 includes a time-dependent test
Date: Tue, 10 May 2022 17:50:45 +0200

Maxime Devos <maximedevos <at> telenet.be> skribis:

> Ludovic Courtès schreef op ma 09-05-2022 om 10:49 [+0200]:
>> Right, and remaining computers will have RISC-VII 100 MHz CPUs anyway.
>
> I assume you meant 100GHz here instead?  Or very fast software that
> doesn't need fast CPUs ...

I did mean MHz but I don’t want to spoil more hopeful visions.  :-)

Ludo’.

Message #33 received at 55326 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>, 55326 <at> debbugs.gnu.org
Subject: Re: bug#55326: libgit2 1.3.0 includes a time-dependent test
Date: Fri, 03 Jun 2022 19:58:14 +0200

[Message part 1 (text/plain, inline)]

I noticed that the latest core-updates evaluations fail because of the
test failure in libgit2 <at> 1.3.0:

https://ci.guix.gnu.org/jobset/core-updates

so I recommend merging 'master' into 'core-updates'.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #36 received at 55326 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 55326 <at> debbugs.gnu.org
Subject: Re: bug#55326: libgit2 1.3.0 includes a time-dependent test
Date: Wed, 08 Jun 2022 18:16:14 +0200

Maxime Devos <maximedevos <at> telenet.be> skribis:

> I noticed that the latest core-updates evaluations fail because of the
> test failure in libgit2 <at> 1.3.0:
>
> https://ci.guix.gnu.org/jobset/core-updates
>
> so I recommend merging 'master' into 'core-updates'.

Done in 8c3e9da13a3c92a7db308db8c0d81cb474ad7799 (and I hope I didn’t
mess up while resolving conflicts!)

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.