GNU bug report logs - #55348
[PATCH] gnu: Add embedded-controller-hx20.

Previous Next

To reply to this bug, email your comments to 55348 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add embedded-controller-hx20.
Date: Tue, 10 May 2022 10:28:37 +0000

[Message part 1 (text/plain, inline)]

Hi,

here's a patch that brings firmware for the Embedded Controller on Framework laptops.

I wanted to put this package into gnu/packages/firmware.scm but due to arm-none-eabi toolchain and the usage of embedded.scm module the build generates only errors due to inclusion. Therefore I temporarily placed the package to gnu/packages/embedded.scm.

I'm unfortunately not an owner of Framework laptop so I can't test the built firmware. I also don't want to ask people to reflash the EC as incorrectly built binary can result in a bricked computer.

Therefore I'd like to open the discussion what should be the steps to include EC [1][2] in general into Guix so that more parts of the firmware will be open source where possible.

[1] https://chromium.googlesource.com/chromiumos/platform/ec/https://github.com/system76/ec[2] https://github.com/system76/ec
----
Petr

[Message part 2 (text/html, inline)]

[0001-gnu-Add-embedded-controller-hx20.patch (text/x-patch, attachment)]

Message #8 received at 55348 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 55348 <at> debbugs.gnu.org
Subject: Re: [bug#55348] [PATCH] gnu: Add embedded-controller-hx20.
Date: Tue, 10 May 2022 14:52:41 +0200

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op di 10-05-2022 om 10:28 [+0000]:
> +	   #:make-flags '("BOARD=hx20" "CROSS_COMPILE=arm-none-eabi-
> ")
> +	   #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (delete 'install))))
> +    (native-inputs (list arm-none-eabi-toolchain-7-2018-q2-update

Maybe we can use Guix cross-compilation mechanism here:

(arguments
  (list #:target "arm-none-eabi"
        #:cross-implicit-inputs? #false ; custom gcc required because
        [...]))
(native-inputs (list ...)

Also, why are 'libftdi, inetutils, ...' in inputs?  Do they end up in
the firmware somehow?  Or does embedded-controller-hx20 not only
contain firmware but also some kind of binaries to control the firmware
or such?  If the latter, I don't think #:target can be used here.

Gree

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 55348 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 55348 <at> debbugs.gnu.org
Subject: Re: [bug#55348] [PATCH] gnu: Add embedded-controller-hx20.
Date: Tue, 10 May 2022 14:54:38 +0200

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op di 10-05-2022 om 10:28 [+0000]:
> Modifying the EC code
> +can cause your system to not power on or boot or cause damage to the
> mainboard,

Maybe a qualifier ‘Modifying the EC code incorrectly’?  Also maybe the
loss of warranty mentioned in the README?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 55348 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: phodina <phodina <at> protonmail.com>
Cc: 55348 <at> debbugs.gnu.org
Subject: Re: bug#55348: [PATCH] gnu: Add embedded-controller-hx20.
Date: Fri, 17 Jun 2022 22:38:16 +0200

Hi phodina,

phodina <phodina <at> protonmail.com> skribis:

> From eb4dcfad9ad9126941acc0ba9522bbaa9d856fdf Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina <at> protonmail.com>
> Date: Fri, 28 Jan 2022 19:29:56 +0100
> Subject: [PATCH] gnu: Add embedded-controller-hx20.
>
> * gnu/packages/embedded.scm (embedded-controller-hx20): New variable.

Did you have a chance to look into addressing Maxime’s comments?

  https://issues.guix.gnu.org/55348

TIA,
Ludo’.

Message #17 received at 55348 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: ludo <at> gnu.org
Cc: 55348 <at> debbugs.gnu.org
Subject: Re: bug#55348: [PATCH] gnu: Add embedded-controller-hx20.
Date: Sat, 18 Jun 2022 04:49:01 +0000

[Message part 1 (text/plain, inline)]

Hi Ludo’,

> Did you have a chance to look into addressing Maxime’s comments?
> https://issues.guix.gnu.org/55348

not yet, but I plan to do so next week.

----
Petr

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.