GNU bug report logs - #55357
29.0.50; [PATCH] Fix browse-url-emacs on file:// urls

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55357 in the body.
You can then email your comments to 55357 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Bug Report Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.50; [PATCH] Fix browse-url-emacs on file:// urls
Date: Wed, 11 May 2022 00:05:50 -0700

[Message part 1 (text/plain, inline)]

If you call browse-url-emacs with a file:// url, Emacs does not open the correct file:

(browse-url-emacs "file://~/a/b") opens /a/b
(browse-url-emacs "file://a/b") opens /b

Basically unless the path is an absolute path, the first level is chopped because url parses it as host and throws it away. This patch concats the host back. If the path is absolute, host is empty string so it’s ok.

Yuan

[file-url.patch (application/octet-stream, attachment)]

Message #8 received at 55357 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 55357 <at> debbugs.gnu.org
Subject: Re: bug#55357: 29.0.50; [PATCH] Fix browse-url-emacs on file:// urls
Date: Wed, 11 May 2022 09:53:59 +0200

On Mai 11 2022, Yuan Fu wrote:

> (browse-url-emacs "file://~/a/b") opens /a/b
> (browse-url-emacs "file://a/b") opens /b

That is correct.  The component after file:// is always the host part.
See RFC8089 for the full specification.

> Basically unless the path is an absolute path, the first level is chopped because url parses it as host and throws it away. This patch concats the host back. If the path is absolute, host is empty string so it’s ok.

The host part can be non-empty, too.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Message #11 received at 55357 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 55357 <at> debbugs.gnu.org
Subject: Re: bug#55357: 29.0.50; [PATCH] Fix browse-url-emacs on file:// urls
Date: Wed, 11 May 2022 14:37:17 +0300

> Resent-From: Yuan Fu <casouri <at> gmail.com>
> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
> Resent-CC: bug-gnu-emacs <at> gnu.org
> Resent-Sender: help-debbugs <at> gnu.org
> From: Yuan Fu <casouri <at> gmail.com>
> Date: Wed, 11 May 2022 00:05:50 -0700
> 
> 
> [1:text/plain Hide]
> 
> 
> If you call browse-url-emacs with a file:// url, Emacs does not open the correct file:
> 
> (browse-url-emacs "file://~/a/b") opens /a/b
> (browse-url-emacs "file://a/b") opens /b
> 
> Basically unless the path is an absolute path, the first level is chopped because url parses it as host and throws it away. This patch concats the host back. If the path is absolute, host is empty string so it’s ok.

I think your URLs lack one or two more slashes.  See

  https://en.wikipedia.org/wiki/File_URI_scheme#How_many_slashes?

Message #16 received at 55357 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55357 <at> debbugs.gnu.org
Subject: Re: bug#55357: 29.0.50; [PATCH] Fix browse-url-emacs on file:// urls
Date: Wed, 11 May 2022 11:35:32 -0700

> On May 11, 2022, at 4:37 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> Resent-From: Yuan Fu <casouri <at> gmail.com>
>> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
>> Resent-CC: bug-gnu-emacs <at> gnu.org
>> Resent-Sender: help-debbugs <at> gnu.org
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Wed, 11 May 2022 00:05:50 -0700
>> 
>> 
>> [1:text/plain Hide]
>> 
>> 
>> If you call browse-url-emacs with a file:// url, Emacs does not open the correct file:
>> 
>> (browse-url-emacs "file://~/a/b") opens /a/b
>> (browse-url-emacs "file://a/b") opens /b
>> 
>> Basically unless the path is an absolute path, the first level is chopped because url parses it as host and throws it away. This patch concats the host back. If the path is absolute, host is empty string so it’s ok.
> 
> I think your URLs lack one or two more slashes. See
> 
> https://en.wikipedia.org/wiki/File_URI_scheme#How_many_slashes?

Ah! My bad. Closing.

Yuan

Message #21 received at 55357-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: 55357-done <at> debbugs.gnu.org
Subject: Re: bug#55357: 29.0.50; [PATCH] Fix browse-url-emacs on file:// urls
Date: Wed, 11 May 2022 11:35:58 -0700

> On May 11, 2022, at 11:35 AM, Yuan Fu <casouri <at> gmail.com> wrote:
> 
> 
> 
>> On May 11, 2022, at 4:37 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> 
>>> Resent-From: Yuan Fu <casouri <at> gmail.com>
>>> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
>>> Resent-CC: bug-gnu-emacs <at> gnu.org
>>> Resent-Sender: help-debbugs <at> gnu.org
>>> From: Yuan Fu <casouri <at> gmail.com>
>>> Date: Wed, 11 May 2022 00:05:50 -0700
>>> 
>>> 
>>> [1:text/plain Hide]
>>> 
>>> 
>>> If you call browse-url-emacs with a file:// url, Emacs does not open the correct file:
>>> 
>>> (browse-url-emacs "file://~/a/b") opens /a/b
>>> (browse-url-emacs "file://a/b") opens /b
>>> 
>>> Basically unless the path is an absolute path, the first level is chopped because url parses it as host and throws it away. This patch concats the host back. If the path is absolute, host is empty string so it’s ok.
>> 
>> I think your URLs lack one or two more slashes. See
>> 
>> https://en.wikipedia.org/wiki/File_URI_scheme#How_many_slashes?
> 
> Ah! My bad. Closing.
> 
> Yuan
> 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.