GNU bug report logs - #55381
[PATCH 05/14] gnu: Add r-unglue.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55381 in the body.
You can then email your comments to 55381 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: kyle <kyle <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Kyle Andrews <kyle <at> posteo.net>
Subject: [PATCH 05/14] gnu: Add r-unglue.
Date: Thu, 12 May 2022 02:10:25 +0000

From: Kyle Andrews <kyle <at> posteo.net>

---
 gnu/packages/cran.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 213f810d04..516c335822 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -33338,6 +33338,26 @@ (define-public r-unpivotr
 with one other by their proximity in given directions.  Functions for data
 frames and HTML tables are provided.")
    (license license:expat)))
+
+(define-public r-unglue
+  (package
+   (name "r-unglue")
+   (version "0.1.0")
+   (source
+    (origin
+     (method url-fetch)
+     (uri (cran-uri "unglue" version))
+     (sha256
+      (base32 "0w8ld4xllx0lj1jz8i2sj92f8136hlwri1d8ldpg1ymxj7aw93vg"))))
+   (properties `((upstream-name . "unglue")))
+   (build-system r-build-system)
+   (home-page "https://cran.r-project.org/package=unglue")
+   (synopsis "Extract Matched Substrings Using a Pattern")
+   (description
+    "Use syntax inspired by the package 'glue' to extract matched substrings in a
+more intuitive and compact way than by using standard regular expressions.")
+   (license license:gpl3)))
+
 (define r-gpg
   (package
    (name "r-gpg")
-- 
2.36.0

Message #8 received at 55381 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: kyle <kyle <at> posteo.net>, 55381 <at> debbugs.gnu.org
Subject: Re: [bug#55381] [PATCH 05/14] gnu: Add r-unglue.
Date: Sat, 14 May 2022 18:18:09 +0000

[Message part 1 (text/plain, inline)]

kyle schreef op do 12-05-2022 om 02:10 [+0000]:
> Use syntax inspired by the package 'glue'

Shouldn't this be 'r-glue'?  Guix doesn't have a package named 'glue'.
Also, writing a description (+- = some factual statements) in the
imperative mood ... is technically possible, but I wouldn't recommend
it.  Referring to another package for more information on what 'rust-
unglue' is about is technically possible, but a bit cumbersome for the
reader I think.  Maybe you can re-use parts of the description of
'r-glue'.

>  to extract matched substrings in a
> +more intuitive and compact way than by using standard regular expressions.

This is a bit markety language.

More generally, upstream descriptions often aren't great and require
some tweaking, expanding (and sometimes abbreviation, though not in
this particular case).  The manual has some general guidelines in
(guix)Synopses and Descriptions.

FWIW, I consider 'emacs', 'hello' and 'sed' to have good descriptions,
though the emacs description goes a bit markety with ‘highly
customizable ... extensive documention on everything’ and such ...
though in the case of Emacs those claims appear to be actually true so
maybe it's a good description after all.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 55381 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Andrews <kyle <at> posteo.net>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 55381 <at> debbugs.gnu.org
Subject: Re: [bug#55381] [PATCH 05/14] gnu: Add r-unglue.
Date: Sun, 15 May 2022 16:38:44 +0000

[Message part 1 (text/plain, inline)]

Hi Maxime,

Maxime Devos <maximedevos <at> telenet.be> writes:

> [[PGP Signed Part:Undecided]]
> kyle schreef op do 12-05-2022 om 02:10 [+0000]:
>> Use syntax inspired by the package 'glue'
>
> Shouldn't this be 'r-glue'?  Guix doesn't have a package named 'glue'.
> Also, writing a description (+- = some factual statements) in the
> imperative mood ... is technically possible, but I wouldn't recommend
> it.  Referring to another package for more information on what 'rust-
> unglue' is about is technically possible, but a bit cumbersome for the
> reader I think.  Maybe you can re-use parts of the description of
> 'r-glue'.
>

This (and r-glue too) is an R package designed to be installed and used
from within R. I noticed that the Pandas python package, for example,
doesn't refer to itself as python-pandas in its Guix documentation.
There are numerous other instances in Guix where such library software
for high-level languages refer to themselves and other related packages
as within their own ecosystems instead of the Guix ecosystem. However,
in this particular case I included in parenthesis "(provided by r-glue
in Guix)".

>>  to extract matched substrings in a
>> +more intuitive and compact way than by using standard regular expressions.
>
> This is a bit markety language.
>
> More generally, upstream descriptions often aren't great and require
> some tweaking, expanding (and sometimes abbreviation, though not in
> this particular case).  The manual has some general guidelines in
> (guix)Synopses and Descriptions.

Thanks, I had a look.

> FWIW, I consider 'emacs', 'hello' and 'sed' to have good descriptions,
> though the emacs description goes a bit markety with ‘highly
> customizable ... extensive documention on everything’ and such ...
> though in the case of Emacs those claims appear to be actually true so
> maybe it's a good description after all.
>

I made a few small tweaks which I feel significantly reduces the
"marketing" aspect. See the included patch.

[0001-gnu-Add-r-unglue.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Cheers,
Kyle

Message #16 received at 55381-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 55381-done <at> debbugs.gnu.org
Subject: [PATCH 05/14] gnu: Add r-unglue.
Date: Thu, 29 Dec 2022 20:56:54 +0100

Applied, thank you!

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.