GNU bug report logs - #55423
[PATCH]: gnu: Add mogan.

Previous Next

Package: guix-patches;

Reported by: Zhu Zihao <all_but_last <at> 163.com>

Date: Sun, 15 May 2022 03:23:02 UTC

Severity: normal

Tags: patch

Done: Zhu Zihao <all_but_last <at> 163.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55423 in the body.
You can then email your comments to 55423 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#55423; Package guix-patches. (Sun, 15 May 2022 03:23:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Zhu Zihao <all_but_last <at> 163.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 15 May 2022 03:23:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: guix-patches <at> gnu.org
Subject: [PATCH]: gnu: Add mogan.
Date: Sun, 15 May 2022 11:21:38 +0800
[Message part 1 (text/plain, inline)]

[signature.asc (application/pgp-signature, inline)]
[0001-gnu-texmacs-Use-G-expression.patch (text/x-patch, inline)]
From ea1a707936936d428efcb6aee84afa4475f695a5 Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Sat, 14 May 2022 22:16:38 +0800
Subject: [PATCH 1/2] gnu: texmacs: Use G-expression.

* gnu/packages/text-editors.scm (texmacs): Use G-expressions.
---
 gnu/packages/text-editors.scm | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 7cbad042c9..d4459f5579 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -876,19 +876,19 @@ (define-public texmacs
            qtsvg
            sqlite))
     (arguments
-     `(#:tests? #f                      ; no check target
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'fix-icon-directory
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let ((out (assoc-ref outputs "out")))
-               (substitute* "packages/linux/icons.sh"
-                 (("/usr/share")
-                  (string-append out "/share"))))))
-         (add-before 'configure 'gzip-flags
-           (lambda _
-             (substitute* "Makefile.in"
-               (("^GZIP = gzip -f") "GZIP = gzip -f -n")))))))
+     (list
+      #:tests? #f                       ; no check target
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'fix-icon-directory
+            (lambda _
+              (substitute* "packages/linux/icons.sh"
+                (("/usr/share")
+                 (string-append #$output "/share")))))
+          (add-before 'configure 'gzip-flags
+            (lambda _
+              (substitute* "Makefile.in"
+                (("^GZIP = gzip -f") "GZIP = gzip -f -n")))))))
     (synopsis "Editing platform with special features for scientists")
     (description
      "GNU TeXmacs is a text editing platform which is specialized for
-- 
2.36.0

[0002-gnu-Add-mogan.patch (text/x-patch, inline)]
From 888d590bc6d27fe43456ee636265915e46a81a3b Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Sat, 14 May 2022 22:19:06 +0800
Subject: [PATCH 2/2] gnu: Add mogan.

* gnu/packages/text-editors.scm (mogan): New variable.
---
 gnu/packages/text-editors.scm | 36 +++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index d4459f5579..7759bfde41 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -55,6 +55,7 @@ (define-module (gnu packages text-editors)
   #:use-module (gnu packages code)
   #:use-module (gnu packages cpp)
   #:use-module (gnu packages crates-io)
+  #:use-module (gnu packages curl)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages freedesktop)
@@ -899,6 +900,41 @@ (define-public texmacs
     (license license:gpl3+)
     (home-page "https://www.texmacs.org/tmweb/home/welcome.en.html")))
 
+(define-public mogan
+  (package
+    (inherit texmacs)
+    (name "mogan")
+    (version "1.0.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://gitee.com/XmacsLabs/mogan")
+             (commit (string-append "v" version))))
+       (sha256
+        (base32 "0flk12yic6jc996jqsmmd0wp40js04rdpvcdjkri0hbqrcvyni8v"))))
+    (inputs
+     (modify-inputs (package-inputs texmacs)
+       ;; Replaced by S7 scheme
+       (delete "guile")
+       (prepend curl)))
+    (arguments
+     (substitute-keyword-arguments (package-arguments texmacs)
+       ((#:phases orig)
+        #~(modify-phases #$orig
+            (replace 'gzip-flags
+              (lambda _
+                (substitute* "misc/CMakeLists.txt"
+                  (("COMMAND gzip" all)
+                   (string-append all " -n")))))))))
+    (synopsis "Structural editor delivered by Xmacs Labs")
+    (description
+     "Mogan is a fork of GNU TeXmacs created by Xmacs Labs. Its goal is
+to customize GNU TeXmacs for everyone to enjoy it fluently and develop new
+feature for everyone to learn and create science and technology.")
+    (license license:gpl3+)
+    (home-page "https://gitee.com/XmacsLabs/mogan")))
+
 (define-public scintilla
   (package
     (name "scintilla")
-- 
2.36.0

[Message part 5 (text/plain, inline)]
-- 
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao

Information forwarded to guix-patches <at> gnu.org:
bug#55423; Package guix-patches. (Sun, 15 May 2022 11:58:01 GMT) Full text and rfc822 format available.

Message #8 received at 55423 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Zhu Zihao <all_but_last <at> 163.com>, 55423 <at> debbugs.gnu.org
Subject: Re: [bug#55423] [PATCH]: gnu: Add mogan.
Date: Sun, 15 May 2022 13:57:29 +0200
[Message part 1 (text/plain, inline)]
Zhu Zihao schreef op zo 15-05-2022 om 11:21 [+0800]:
> +    (home-page "https://gitee.com/XmacsLabs/mogan")))

Appears to be a mirror for <https://github.com/XmacsLabs/mogan>.

Also, what kind of fork is this?  Is the idea to (eventually) merge the
fixes and features into upstream, or are they going separate ways, or
...?  Basically, why package the fork (which comes with some technical
and social cost) instead of working with upstream?

Not saying it's forbidden to package forks, but rather for me the
default option is to only package upstream.

> + Its goal is to customize GNU TeXmacs for everyone to enjoy it
> + fluently and develop new feature for everyone to learn and create
> + science and technology.

This description sort-of suggests TeXmacs doesn't want everyone to
enjoy it and such, which I don't think is good for relations with
upstream.  Maybe like ‘(guix)Synopsis and Descriptions’ suggests, write
about some use cases and features (that were added by the fork)?

Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#55423; Package guix-patches. (Sun, 15 May 2022 12:00:03 GMT) Full text and rfc822 format available.

Message #11 received at 55423 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Zhu Zihao <all_but_last <at> 163.com>, 55423 <at> debbugs.gnu.org
Subject: Re: [bug#55423] [PATCH]: gnu: Add mogan.
Date: Sun, 15 May 2022 13:58:57 +0200
[Message part 1 (text/plain, inline)]
Zhu Zihao schreef op zo 15-05-2022 om 11:21 [+0800]:
> +            (replace 'gzip-flags
> +              (lambda _
> +                (substitute* "misc/CMakeLists.txt"
> +                  (("COMMAND gzip" all)
> +                   (string-append all " -n")))))))))

-n = for no time stamp and reproducibility?  I recommend sending this
change to upstream (if accepted by them), such that every distribution
benefits.

Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#55423; Package guix-patches. (Sun, 15 May 2022 12:00:03 GMT) Full text and rfc822 format available.

Message #14 received at 55423 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Zhu Zihao <all_but_last <at> 163.com>, 55423 <at> debbugs.gnu.org
Subject: Re: [bug#55423] [PATCH]: gnu: Add mogan.
Date: Sun, 15 May 2022 13:59:57 +0200
[Message part 1 (text/plain, inline)]
Zhu Zihao schreef op zo 15-05-2022 om 11:21 [+0800]:
> +    (inputs
> +     (modify-inputs (package-inputs texmacs)
> +       ;; Replaced by S7 scheme
> +       (delete "guile")
> +       (prepend curl)))

S7 scheme appears to be missing in the inputs, is it bundled?

Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#55423; Package guix-patches. (Sun, 15 May 2022 12:02:01 GMT) Full text and rfc822 format available.

Message #17 received at 55423 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Zhu Zihao <all_but_last <at> 163.com>, 55423 <at> debbugs.gnu.org
Subject: Re: [bug#55423] [PATCH]: gnu: Add mogan.
Date: Sun, 15 May 2022 14:01:39 +0200
[Message part 1 (text/plain, inline)]
Zhu Zihao schreef op zo 15-05-2022 om 11:21 [+0800]:
> +    (inputs
> +     (modify-inputs (package-inputs texmacs)
> +       ;; Replaced by S7 scheme
> +       (delete "guile")
> +       (prepend curl)))

S7 is bundled in
<https://github.com/XmacsLabs/mogan/tree/main/src/Scheme/S7>.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#55423; Package guix-patches. (Sun, 15 May 2022 14:07:01 GMT) Full text and rfc822 format available.

Message #20 received at 55423 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 55423 <at> debbugs.gnu.org
Subject: Re: [bug#55423] [PATCH]: gnu: Add mogan.
Date: Sun, 15 May 2022 21:56:31 +0800
[Message part 1 (text/plain, inline)]
Maxime Devos <maximedevos <at> telenet.be> writes:

> [[PGP Signed Part:Undecided]]
> Zhu Zihao schreef op zo 15-05-2022 om 11:21 [+0800]:
>> +    (home-page "https://gitee.com/XmacsLabs/mogan")))
>
> Appears to be a mirror for <https://github.com/XmacsLabs/mogan>.

These two repositories are equal with each others. There's no "main"
repository and "mirror" repository difference. 

> Also, what kind of fork is this?  Is the idea to (eventually) merge the
> fixes and features into upstream, or are they going separate ways, or
> ...?  Basically, why package the fork (which comes with some technical
> and social cost) instead of working with upstream?
>
> Not saying it's forbidden to package forks, but rather for me the
> default option is to only package upstream.

This fork is created by Darcy Shen(sadhen), the maintainer of GNU
TeXmacs. IIUC, Shen feels GNU TeXmacs is more scientist oriented, so he
want Mogan to be programmer oriented[*]. For details, we'd better to ask
Shen directly.

I guess Shen is unhappy with the slow development progress of texmacs,
he created a fork to add the features he wanted to add to texmacs.

[*]: https://zhuanlan.zhihu.com/p/447372210 (Simplified Chinese)
>
>> + Its goal is to customize GNU TeXmacs for everyone to enjoy it
>> + fluently and develop new feature for everyone to learn and create
>> + science and technology.
>
> This description sort-of suggests TeXmacs doesn't want everyone to
> enjoy it and such, which I don't think is good for relations with
> upstream.  Maybe like ‘(guix)Synopsis and Descriptions’ suggests, write
> about some use cases and features (that were added by the fork)?

OK, I'll change it to more netural words.
>
> Greetings,
> Maxime.
>
> [[End of PGP Signed Part]]


-- 
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#55423; Package guix-patches. (Sun, 15 May 2022 14:09:02 GMT) Full text and rfc822 format available.

Message #23 received at 55423 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 55423 <at> debbugs.gnu.org
Subject: Re: [bug#55423] [PATCH]: gnu: Add mogan.
Date: Sun, 15 May 2022 22:05:54 +0800
[Message part 1 (text/plain, inline)]
Maxime Devos <maximedevos <at> telenet.be> writes:

> [[PGP Signed Part:Undecided]]
> Zhu Zihao schreef op zo 15-05-2022 om 11:21 [+0800]:
>> +            (replace 'gzip-flags
>> +              (lambda _
>> +                (substitute* "misc/CMakeLists.txt"
>> +                  (("COMMAND gzip" all)
>> +                   (string-append all " -n")))))))))
>
> -n = for no time stamp and reproducibility?  I recommend sending this
> change to upstream (if accepted by them), such that every distribution
> benefits.

I'll suggest a patch to upstream. But I think we don't need these phase
at all. There's reset-gzip-timestamps in gnu-build-system and the
timestamp of all gzip files will be cleared in the build process.

> S7 scheme appears to be missing in the inputs, is it bundled?

Yes, it's bundled. But I don't have a plan to unbundle it. It's small
and we'll have more work to do if we try to unbundle. 

-- 
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#55423; Package guix-patches. (Sun, 15 May 2022 14:17:02 GMT) Full text and rfc822 format available.

Message #26 received at 55423 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: sadhen <at> zoho.com
Cc: 55423 <at> debbugs.gnu.org
Subject: What's the motivation of creating Mogan. (was Re: [bug#55423]
 [PATCH]: gnu: Add mogan.)
Date: Sun, 15 May 2022 22:12:27 +0800
[Message part 1 (text/plain, inline)]
Hello, Darcy Shen!

We're planning to package mogan editor for Guix. Thanks for your work on
Mogan and GNU TeXmacs!

Please allow me to ask a question here: What's your motivation of
forking GNU TeXmacs to create Mogan?

So Guix developers don't know the difference between GNU TeXmacs and
Mogan and many articles about Mogan were written in Chinese. So we need
your help. Thank you very much.
-- 
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#55423; Package guix-patches. (Sun, 15 May 2022 14:25:02 GMT) Full text and rfc822 format available.

Message #29 received at 55423 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Zhu Zihao <all_but_last <at> 163.com>
Cc: 55423 <at> debbugs.gnu.org
Subject: Re: [bug#55423] [PATCH]: gnu: Add mogan.
Date: Sun, 15 May 2022 16:24:27 +0200
[Message part 1 (text/plain, inline)]
Zhu Zihao schreef op zo 15-05-2022 om 22:05 [+0800]:
> Yes, it's bundled. But I don't have a plan to unbundle it. It's small
> and we'll have more work to do if we try to unbundle. 

From (guix)Synopses and Descriptions:

  8. Make sure the package does not use bundled copies of software
     already available as separate packages.

     Sometimes, packages include copies of the source code of their
     dependencies as a convenience for users.  However, as a
     distribution, we want to make sure that such packages end up using
     the copy we already have in the distribution, if there is one.
     This improves resource usage (the dependency is built and stored
     only once), and allows the distribution to make transverse changes
     such as applying security updates for a given software package in
     a single place and have them affect the whole system—something
     that bundled copies prevent.

I don't think resource usage is a problem here, but the security
updates and transverse changes bits seem relevant here to me
(also: bug fixes, less redundancy when checking source code for malware
or bugs, replacing the s7 used by applications by a custom one to test
out new features or performance or such, ...)

It's a bit of an investment now that gives some flexibility for the
future and avoids some potential problems (e.g. malware bit and
security updates bit).

Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#55423; Package guix-patches. (Mon, 16 May 2022 15:28:02 GMT) Full text and rfc822 format available.

Message #32 received at 55423 <at> debbugs.gnu.org (full text, mbox):

From: Darcy Shen <sadhen <at> zoho.com>
To: "Zhu Zihao" <all_but_last <at> 163.com>, "55423" <55423 <at> debbugs.gnu.org>
Subject: Re: What's the motivation of creating Mogan. (was Re: [bug#55423]
 [PATCH]: gnu: Add mogan.)
Date: Mon, 16 May 2022 18:39:22 +0800
[Message part 1 (text/plain, inline)]
Because GNU TeXmacs is still using GNU Guile 1.8.x and Qt 4.x.



As one of the developers, I want to use S7 Scheme and Qt 5.x. That's the reason why I fork GNU TeXmacs.







---- On Sun, 15 May 2022 22:12:27 +0800 Zhu Zihao <all_but_last <at> 163.com> wrote ----



Hello, Darcy Shen! 
 
We're planning to package mogan editor for Guix. Thanks for your work on 
Mogan and GNU TeXmacs! 
 
Please allow me to ask a question here: What's your motivation of 
forking GNU TeXmacs to create Mogan? 
 
So Guix developers don't know the difference between GNU TeXmacs and 
Mogan and many articles about Mogan were written in Chinese. So we need 
your help. Thank you very much. 
-- 
Retrieve my PGP public key: 
 
 gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F 
 
Zihao
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#55423; Package guix-patches. (Mon, 05 Sep 2022 11:43:01 GMT) Full text and rfc822 format available.

Message #35 received at 55423 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 55423 <at> debbugs.gnu.org
Subject: Re: [bug#55423] [PATCH]: gnu: Add mogan.
Date: Mon, 05 Sep 2022 19:41:52 +0800
[Message part 1 (text/plain, inline)]
Long time no see.

I updated Mogan to 1.1.0 and switch the source to github.

[signature.asc (application/pgp-signature, inline)]
[0001-gnu-texmacs-Use-G-expression.patch (text/x-patch, inline)]
From f754c24c0945dd2fc17881f37598262b612eee67 Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Sat, 14 May 2022 22:16:38 +0800
Subject: [PATCH 1/2] gnu: texmacs: Use G-expression.

* gnu/packages/text-editors.scm (texmacs): Use G-expressions.
---
 gnu/packages/text-editors.scm | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 0c30a705b9..8a52e0ef41 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -872,19 +872,19 @@ (define-public texmacs
            qtsvg-5
            sqlite))
     (arguments
-     `(#:tests? #f                      ; no check target
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'fix-icon-directory
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let ((out (assoc-ref outputs "out")))
-               (substitute* "packages/linux/icons.sh"
-                 (("/usr/share")
-                  (string-append out "/share"))))))
-         (add-before 'configure 'gzip-flags
-           (lambda _
-             (substitute* "Makefile.in"
-               (("^GZIP = gzip -f") "GZIP = gzip -f -n")))))))
+     (list
+      #:tests? #f                       ; no check target
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'fix-icon-directory
+            (lambda _
+              (substitute* "packages/linux/icons.sh"
+                (("/usr/share")
+                 (string-append #$output "/share")))))
+          (add-before 'configure 'gzip-flags
+            (lambda _
+              (substitute* "Makefile.in"
+                (("^GZIP = gzip -f") "GZIP = gzip -f -n")))))))
     (synopsis "Editing platform with special features for scientists")
     (description
      "GNU TeXmacs is a text editing platform which is specialized for
-- 
2.37.2

[0002-gnu-Add-mogan.patch (text/x-patch, inline)]
From bf3c22e5f835725fd700176f0d1b1ec0ac28fe51 Mon Sep 17 00:00:00 2001
From: Zhu Zihao <all_but_last <at> 163.com>
Date: Sat, 14 May 2022 22:19:06 +0800
Subject: [PATCH 2/2] gnu: Add mogan.

* gnu/packages/text-editors.scm (mogan): New variable.
---
 gnu/packages/text-editors.scm | 37 +++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 8a52e0ef41..24600b4148 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -56,6 +56,7 @@ (define-module (gnu packages text-editors)
   #:use-module (gnu packages code)
   #:use-module (gnu packages cpp)
   #:use-module (gnu packages crates-io)
+  #:use-module (gnu packages curl)
   #:use-module (gnu packages datastructures)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages fontutils)
@@ -895,6 +896,42 @@ (define-public texmacs
     (license license:gpl3+)
     (home-page "https://www.texmacs.org/tmweb/home/welcome.en.html")))
 
+(define-public mogan
+  (package
+    (inherit texmacs)
+    (name "mogan")
+    (version "1.1.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/XmacsLabs/mogan")
+             (commit (string-append "v" version))))
+       (sha256
+        (base32 "0l7irs5w6f1dmzxz2p4c4vxc2w999yxy1qvhbcv5yh3kfbyzrf7z"))))
+    (inputs
+     (modify-inputs (package-inputs texmacs)
+       ;; Replaced by S7 scheme
+       ;; TODO: Maybe unbundle S7
+       (delete "guile")
+       (prepend curl)))
+    (arguments
+     (substitute-keyword-arguments (package-arguments texmacs)
+       ((#:phases orig)
+        #~(modify-phases #$orig
+            (replace 'gzip-flags
+              (lambda _
+                (substitute* "misc/CMakeLists.txt"
+                  (("COMMAND gzip" all)
+                   (string-append all " -n")))))))))
+    (synopsis "Structural editor delivered by Xmacs Labs")
+    (description
+     "Mogan is a fork of GNU TeXmacs created by Xmacs Labs. Its goal is
+make everyone to enjoy it fluently and develop new feature for everyone to learn
+and create science and technology.")
+    (license license:gpl3+)
+    (home-page "https://gitee.com/XmacsLabs/mogan")))
+
 (define-public scintilla
   (package
     (name "scintilla")
-- 
2.37.2

[Message part 5 (text/plain, inline)]
-- 
Retrieve my PGP public key:

  gpg --recv-keys 481F5EEEBA425ADC13247C76A6E672D981B8E744

Zihao

Information forwarded to guix-patches <at> gnu.org:
bug#55423; Package guix-patches. (Thu, 22 Sep 2022 05:42:01 GMT) Full text and rfc822 format available.

Message #38 received at 55423 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 55423 <at> debbugs.gnu.org
Subject: Re: [bug#55423] [PATCH]: gnu: Add mogan.
Date: Thu, 22 Sep 2022 13:40:43 +0800
[Message part 1 (text/plain, inline)]
ping.

Zhu Zihao <all_but_last <at> 163.com> writes:

> [[PGP Signed Part:Undecided]]
>
> Long time no see.
>
> I updated Mogan to 1.1.0 and switch the source to github.
>
> [[End of PGP Signed Part]]
> From f754c24c0945dd2fc17881f37598262b612eee67 Mon Sep 17 00:00:00 2001
> From: Zhu Zihao <all_but_last <at> 163.com>
> Date: Sat, 14 May 2022 22:16:38 +0800
> Subject: [PATCH 1/2] gnu: texmacs: Use G-expression.
>
> * gnu/packages/text-editors.scm (texmacs): Use G-expressions.
> ---
>  gnu/packages/text-editors.scm | 26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
> index 0c30a705b9..8a52e0ef41 100644
> --- a/gnu/packages/text-editors.scm
> +++ b/gnu/packages/text-editors.scm
> @@ -872,19 +872,19 @@ (define-public texmacs
>             qtsvg-5
>             sqlite))
>      (arguments
> -     `(#:tests? #f                      ; no check target
> -       #:phases
> -       (modify-phases %standard-phases
> -         (add-after 'unpack 'fix-icon-directory
> -           (lambda* (#:key outputs #:allow-other-keys)
> -             (let ((out (assoc-ref outputs "out")))
> -               (substitute* "packages/linux/icons.sh"
> -                 (("/usr/share")
> -                  (string-append out "/share"))))))
> -         (add-before 'configure 'gzip-flags
> -           (lambda _
> -             (substitute* "Makefile.in"
> -               (("^GZIP = gzip -f") "GZIP = gzip -f -n")))))))
> +     (list
> +      #:tests? #f                       ; no check target
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'fix-icon-directory
> +            (lambda _
> +              (substitute* "packages/linux/icons.sh"
> +                (("/usr/share")
> +                 (string-append #$output "/share")))))
> +          (add-before 'configure 'gzip-flags
> +            (lambda _
> +              (substitute* "Makefile.in"
> +                (("^GZIP = gzip -f") "GZIP = gzip -f -n")))))))
>      (synopsis "Editing platform with special features for scientists")
>      (description
>       "GNU TeXmacs is a text editing platform which is specialized for
> -- 
> 2.37.2
>
> From bf3c22e5f835725fd700176f0d1b1ec0ac28fe51 Mon Sep 17 00:00:00 2001
> From: Zhu Zihao <all_but_last <at> 163.com>
> Date: Sat, 14 May 2022 22:19:06 +0800
> Subject: [PATCH 2/2] gnu: Add mogan.
>
> * gnu/packages/text-editors.scm (mogan): New variable.
> ---
>  gnu/packages/text-editors.scm | 37 +++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>
> diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
> index 8a52e0ef41..24600b4148 100644
> --- a/gnu/packages/text-editors.scm
> +++ b/gnu/packages/text-editors.scm
> @@ -56,6 +56,7 @@ (define-module (gnu packages text-editors)
>    #:use-module (gnu packages code)
>    #:use-module (gnu packages cpp)
>    #:use-module (gnu packages crates-io)
> +  #:use-module (gnu packages curl)
>    #:use-module (gnu packages datastructures)
>    #:use-module (gnu packages documentation)
>    #:use-module (gnu packages fontutils)
> @@ -895,6 +896,42 @@ (define-public texmacs
>      (license license:gpl3+)
>      (home-page "https://www.texmacs.org/tmweb/home/welcome.en.html")))
>  
> +(define-public mogan
> +  (package
> +    (inherit texmacs)
> +    (name "mogan")
> +    (version "1.1.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/XmacsLabs/mogan")
> +             (commit (string-append "v" version))))
> +       (sha256
> +        (base32 "0l7irs5w6f1dmzxz2p4c4vxc2w999yxy1qvhbcv5yh3kfbyzrf7z"))))
> +    (inputs
> +     (modify-inputs (package-inputs texmacs)
> +       ;; Replaced by S7 scheme
> +       ;; TODO: Maybe unbundle S7
> +       (delete "guile")
> +       (prepend curl)))
> +    (arguments
> +     (substitute-keyword-arguments (package-arguments texmacs)
> +       ((#:phases orig)
> +        #~(modify-phases #$orig
> +            (replace 'gzip-flags
> +              (lambda _
> +                (substitute* "misc/CMakeLists.txt"
> +                  (("COMMAND gzip" all)
> +                   (string-append all " -n")))))))))
> +    (synopsis "Structural editor delivered by Xmacs Labs")
> +    (description
> +     "Mogan is a fork of GNU TeXmacs created by Xmacs Labs. Its goal is
> +make everyone to enjoy it fluently and develop new feature for everyone to learn
> +and create science and technology.")
> +    (license license:gpl3+)
> +    (home-page "https://gitee.com/XmacsLabs/mogan")))
> +
>  (define-public scintilla
>    (package
>      (name "scintilla")
> -- 
> 2.37.2


-- 
Retrieve my PGP public key:

  gpg --recv-keys B3EBC086AB0EBC0F45E0B4D433DB374BCEE4D9DC

Zihao
[signature.asc (application/pgp-signature, inline)]

Reply sent to Zhu Zihao <all_but_last <at> 163.com>:
You have taken responsibility. (Mon, 07 Nov 2022 11:09:02 GMT) Full text and rfc822 format available.

Notification sent to Zhu Zihao <all_but_last <at> 163.com>:
bug acknowledged by developer. (Mon, 07 Nov 2022 11:09:02 GMT) Full text and rfc822 format available.

Message #43 received at 55423-done <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: 55423-done <at> debbugs.gnu.org
Subject: Re: [bug#55423] [PATCH]: gnu: Add mogan.
Date: Mon, 07 Nov 2022 19:06:19 +0800
[Message part 1 (text/plain, inline)]
Closed due to 59102.
-- 
Retrieve my PGP public key:

  gpg --recv-keys B3EBC086AB0EBC0F45E0B4D433DB374BCEE4D9DC

Zihao
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 05 Dec 2022 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 114 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.