GNU bug report logs - #55427
emacs-libgit tests are broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55427 in the body.
You can then email your comments to 55427 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: emacs-libgit tests are broken
Date: Sun, 15 May 2022 13:19:01 +0200

With the update to Emacs 28, emacs-libgit (a requirement for emacs-
magit) fails to build with the following test error:

Test project /tmp/guix-build-emacs-libgit-20200515-1.0ef8b13.drv-
0/build
      Start  1: libegit2_annotated-commit
 1/29 Test  #1: libegit2_annotated-commit ........   Passed    0.38 sec
      Start  2: libegit2_blame
 2/29 Test  #2: libegit2_blame ...................   Passed    0.39 sec
      Start  3: libegit2_blob
 3/29 Test  #3: libegit2_blob ....................***Failed    0.43 sec
Running 4 tests (2022-05-15 07:25:56+0000, selector ‘t’)
Test blob-binary backtrace:
  signal(wrong-type-argument (utf-8-string-p "\177ELF\2\1\1\0\0\0\0\0\
  apply(signal (wrong-type-argument (utf-8-string-p "\177ELF\2\1\1\0\0
  (setq value-42 (apply fn-40 args-41))
  (unwind-protect (setq value-42 (apply fn-40 args-41)) (setq form-des
  (if (unwind-protect (setq value-42 (apply fn-40 args-41)) (setq form
  (let (form-description-44) (if (unwind-protect (setq value-42 (apply
  (let ((value-42 'ert-form-evaluation-aborted-43)) (let (form-descrip
  (let* ((fn-40 #'string=) (args-41 (condition-case err (let ((signal-
  (let* ((repo (libgit-repository-open path)) (blob (libgit-revparse-s
  (let ((default-directory path)) (init) (commit-change "filename" str
  (progn (make-directory path 'parents) (let ((default-directory path)
  (unwind-protect (progn (make-directory path 'parents) (let ((default
  (let ((path "/tmp/guix-build-emacs-libgit-20200515-1.0ef8b13.dr...")
  (let* ((str (unibyte-string 127 69 76 70 2 1 1 0 0 0 0 0 0 0 0 0 3 0
  (let ((lexical-binding nil)) (let* ((str (unibyte-string 127 69 76 7
  (lambda nil (let ((lexical-binding nil)) (let* ((str (unibyte-string
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name blob-binary :documentation nil :body 
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test 
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-L" "/tmp/guix-build-emacs-libgit-20200515-1.0ef8b1
  command-line()
  normal-top-level()
Test blob-binary condition:
    (wrong-type-argument utf-8-string-p
"\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\260\7\0\0\0\0\0\0@\0\0\
0\0\0\0\0\270\33\0\0\0\0\0\0\0\0\0\0@\08\0\11\0@\0\35\0\34\0\6\0\0\0\5\
0\0\0@\0\0\0\0\0\0\0")
   FAILED  1/4  blob-binary (0.041795 sec)
   passed  2/4  blob-create-fromdisk (0.023014 sec)
   passed  3/4  blob-create-fromstring (0.022546 sec)
   passed  4/4  blob-text (0.044085 sec)

Ran 4 tests, 3 results as expected, 1 unexpected (2022-05-15
07:25:56+0000, 0.301178 sec)

1 unexpected results:
   FAILED  blob-binary
[...]

I have no idea what causes it or where utf-8-string-p even comes from,
but the implementation of string= appears to have changed.  When
running the build locally another test also appears flaky due to weird
time stamp conversions.

Cheers

Message #10 received at 55427 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: 55427 <at> debbugs.gnu.org
Subject: Re: emacs-libgit tests are broken
Date: Mon, 16 May 2022 18:01:11 +0800

[Message part 1 (text/plain, inline)]

Issue submitted to upstream with my guess and explanation.

https://github.com/magit/libegit2/issues/121

This issue is not trivial and there's no way to workaround it IMO. 
-- 
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 55427 <at> debbugs.gnu.org (full text, mbox):

From: Taiju HIGASHI <higashi <at> taiju.info>
To: 55427 <at> debbugs.gnu.org
Subject: Re: emacs-libgit tests are broken
Date: Mon, 16 May 2022 19:28:03 +0900

Hi,

I was also watching for this issue.
It seems that the libegit2 repository has just reported this issue.

https://github.com/magit/libegit2/issues/121

- taiju

Message #16 received at 55427 <at> debbugs.gnu.org (full text, mbox):

From: Taiju HIGASHI <higashi <at> taiju.info>
To: 55427 <at> debbugs.gnu.org
Subject: Re: emacs-libgit tests are broken
Date: Mon, 16 May 2022 19:40:58 +0900

Sorry, the timing of my post was wrong.

To Zihao:
Thanks for reporting the issue.

Message #27 received at 55427 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: 55427 <at> debbugs.gnu.org
Subject: Re: emacs-libgit tests are broken
Date: Tue, 17 May 2022 23:14:06 +0800

[Message part 1 (text/plain, inline)]

Due to the inactive status of upstream. I'm planning to remove the
emacs-libgit input of emacs-magit.

magit will still work with the git executable if there's no
emacs-libgit.

Any thoughts?


Zhu Zihao <all_but_last <at> 163.com> writes:

> [[PGP Signed Part:Undecided]]
> Issue submitted to upstream with my guess and explanation.
>
> https://github.com/magit/libegit2/issues/121
>
> This issue is not trivial and there's no way to workaround it IMO. 


-- 
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao

[signature.asc (application/pgp-signature, inline)]

Message #30 received at 55427 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: Zhu Zihao <all_but_last <at> 163.com>
Cc: 55427 <at> debbugs.gnu.org
Subject: Re: bug#55427: emacs-libgit tests are broken
Date: Tue, 17 May 2022 19:10:07 -0400

Zhu Zihao writes:

> Due to the inactive status of upstream. I'm planning to remove the
> emacs-libgit input of emacs-magit.
>
> magit will still work with the git executable if there's no
> emacs-libgit.
>
> Any thoughts?

Good idea.  There's no real downside to disabling libgit2 support
because magit-libgit.el does very little at this point.

Message #33 received at 55427 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: Zhu Zihao <all_but_last <at> 163.com>, 55427 <at> debbugs.gnu.org
Subject: Re: emacs-libgit tests are broken
Date: Wed, 18 May 2022 08:14:36 +0200

Am Dienstag, dem 17.05.2022 um 23:14 +0800 schrieb Zhu Zihao:
> Due to the inactive status of upstream. I'm planning to remove the
> emacs-libgit input of emacs-magit.
I don't think we need measures quite as drastic as this.  A hotfix for
emacs-libgit was pushed to master, which causes builds to succeed again
(see e.g. [1]).  Since we're talking about free software here, it would
be more constructive to work on a proper patch – if upstream won't take
it, one can always fork it.

> magit will still work with the git executable if there's no
> emacs-libgit.
> 
> Any thoughts?
I don't see any benefits in this approach, do you?

[1] http://ci.guix.gnu.org/build/859957/details

Message #36 received at 55427 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Zhu Zihao <all_but_last <at> 163.com>, 55427 <at> debbugs.gnu.org
Subject: Re: bug#55427: emacs-libgit tests are broken
Date: Wed, 18 May 2022 12:02:50 +0200

[Message part 1 (text/plain, inline)]

Zhu Zihao schreef op di 17-05-2022 om 23:14 [+0800]:
> magit will still work with the git executable if there's no
> emacs-libgit.
> 
> Any thoughts?

Due to issues with TRAMP, magit currently cannot always find the git
executable, while AFAICT there are no problems with emacs-libgit.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #39 received at 55427 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 55427 <at> debbugs.gnu.org
Subject: Re: bug#55427: emacs-libgit tests are broken
Date: Wed, 18 May 2022 21:13:47 +0800

[Message part 1 (text/plain, inline)]

magit doesn't use libgit for remote directory.

Maybe there're other reasons that make your magit work on remote file :P. 

https://github.com/magit/magit/blob/master/lisp/magit-git.el#L93

Maxime Devos <maximedevos <at> telenet.be> writes:

> [[PGP Signed Part:Undecided]]
> Zhu Zihao schreef op di 17-05-2022 om 23:14 [+0800]:
>> magit will still work with the git executable if there's no
>> emacs-libgit.
>> 
>> Any thoughts?
>
> Due to issues with TRAMP, magit currently cannot always find the git
> executable, while AFAICT there are no problems with emacs-libgit.
>
> Greetings,
> Maxime.
>
> [[End of PGP Signed Part]]


-- 
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao

[signature.asc (application/pgp-signature, inline)]

Message #42 received at 55427 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Zhu Zihao <all_but_last <at> 163.com>
Cc: 55427 <at> debbugs.gnu.org
Subject: Re: bug#55427: emacs-libgit tests are broken
Date: Wed, 18 May 2022 15:24:35 +0200

[Message part 1 (text/plain, inline)]

Zhu Zihao schreef op wo 18-05-2022 om 21:13 [+0800]:
> magit doesn't use libgit for remote directory.
>
> Maybe there're other reasons that make your magit work on remote file
> :P. 
> 
> https://github.com/magit/magit/blob/master/lisp/magit-git.el#L93

My concern is about not breaking the local use case.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #45 received at 55427 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Cc: 55427 <at> debbugs.gnu.org
Subject: Re: emacs-libgit tests are broken
Date: Wed, 18 May 2022 21:17:42 +0800

[Message part 1 (text/plain, inline)]

Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at> writes:

>> magit will still work with the git executable if there's no
>> emacs-libgit.
>> 
>> Any thoughts?
> I don't see any benefits in this approach, do you?
>
> [1] http://ci.guix.gnu.org/build/859957/details

I don't see any benefits on libgit implementation.
The only method supported by libgit backend is `magit-bare-repo-p`[1],
magit use git executable to do 99.9% works.

The libgit backend should be a separated package. There's
https://github.com/magit/magit/blob/master/lisp/magit-libgit-pkg.el for
it. Its quaility is poor because it's currently in POC status and the
development status has been put on hold indefinitely.[2]

[1] https://github.com/magit/magit/blob/master/lisp/magit-libgit.el#L79

[2] https://github.com/magit/magit/issues/2959#issuecomment-1112185169
-- 
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao

[signature.asc (application/pgp-signature, inline)]

Message #48 received at 55427 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Zhu Zihao <all_but_last <at> 163.com>
Cc: 55427 <at> debbugs.gnu.org
Subject: Re: bug#55427: emacs-libgit tests are broken
Date: Wed, 18 May 2022 15:30:24 +0200

[Message part 1 (text/plain, inline)]

Maxime Devos schreef op wo 18-05-2022 om 15:24 [+0200]:
> Zhu Zihao schreef op wo 18-05-2022 om 21:13 [+0800]:
> > magit doesn't use libgit for remote directory.
> > 
> > Maybe there're other reasons that make your magit work on remote
> file
> > :P. 
> > 
> > https://github.com/magit/magit/blob/master/lisp/magit-git.el#L93
> 
> My concern is about not breaking the local use case.

Maybe this can be fixed by patching "magit-git-executable" in Guix
with an absolute path -- that procedure is only used on the local host,
so that shouldn't cause any problems with TRAMP.  Will send a mail to
30434.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #51 received at 55427 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 55427 <at> debbugs.gnu.org
Subject: Re: bug#55427: emacs-libgit tests are broken
Date: Wed, 18 May 2022 23:34:56 +0800

[Message part 1 (text/plain, inline)]

Maxime Devos <maximedevos <at> telenet.be> writes:

>> My concern is about not breaking the local use case.

As I said here: https://issues.guix.gnu.org/55427#15

Magit use git executable for 99.9% work. Guix user should install git
(or we patch the git absolute path for it) for almost all functionality.

libgit doesn't save you from missing git executable. 

-- 
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao

[signature.asc (application/pgp-signature, inline)]

Message #54 received at 55427 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 55427 <at> debbugs.gnu.org, Zhu Zihao <all_but_last <at> 163.com>
Subject: Re: bug#55427: emacs-libgit tests are broken
Date: Wed, 18 May 2022 18:44:50 -0400

Maxime Devos writes:

> Maybe this can be fixed by patching "magit-git-executable" in Guix
> with an absolute path -- that procedure is only used on the local host,
> so that shouldn't cause any problems with TRAMP.  Will send a mail to
> 30434.

Right, using an absolute path for magit-git-executable is _now_ fine.
Magit started using separate executables for the local and remote
operations in 1423c54d (magit-remote-git-executable: New option,
2021-07-20), part of the 3.2.0 release.  bug#30434 was active back in
2018.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.