GNU bug report logs - #55438
[PATCH] doc: Use the shell dollar substitution.

Previous Next

Package: guix-patches;

Reported by: zimoun <zimon.toutoune <at> gmail.com>

Date: Sun, 15 May 2022 22:32:02 UTC

Severity: normal

Tags: patch

Done: Julien Lepiller <julien <at> lepiller.eu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55438 in the body.
You can then email your comments to 55438 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#55438; Package guix-patches. (Sun, 15 May 2022 22:32:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to zimoun <zimon.toutoune <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 15 May 2022 22:32:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: zimoun <zimon.toutoune <at> gmail.com>
Subject: [PATCH] doc: Use the shell dollar substitution.
Date: Mon, 16 May 2022 00:31:24 +0200
Follow up of beaf701d65e9f94d0539e705d6f58a65313c5655.

* doc/guix.texi: Replace the shell backquote deprecated substitution by the
dollar one.
---
 doc/guix.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index e1fb50a634..c162d3a79d 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -3451,7 +3451,7 @@ The typical use case is to define these environment variables in the
 shell:
 
 @example
-$ eval `guix package --search-paths`
+$ eval $(guix package --search-paths)
 @end example
 
 @var{kind} may be one of @code{exact}, @code{prefix}, or @code{suffix},

base-commit: ebb43029506d994bee0c2b890881fd61a0b0c202
-- 
2.35.1





Information forwarded to guix-patches <at> gnu.org:
bug#55438; Package guix-patches. (Wed, 18 May 2022 04:42:02 GMT) Full text and rfc822 format available.

Message #8 received at 55438 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 55438 <at> debbugs.gnu.org
Subject: Re: bug#55438: [PATCH] doc: Use the shell dollar substitution.
Date: Wed, 18 May 2022 00:41:03 -0400
Hi Simon!

zimoun <zimon.toutoune <at> gmail.com> writes:

> Follow up of beaf701d65e9f94d0539e705d6f58a65313c5655.
>
> * doc/guix.texi: Replace the shell backquote deprecated substitution by the
> dollar one.

I'm nitpicking, but per "info bash", I'd reword the commit summary as
"Use new-style command substitution".  And "Replace the shell old-style
command substitution with the new-style one."

With this, I'd be happy to push :-)

Thanks!

Maxim




Reply sent to Julien Lepiller <julien <at> lepiller.eu>:
You have taken responsibility. (Sun, 05 Jun 2022 11:41:02 GMT) Full text and rfc822 format available.

Notification sent to zimoun <zimon.toutoune <at> gmail.com>:
bug acknowledged by developer. (Sun, 05 Jun 2022 11:41:02 GMT) Full text and rfc822 format available.

Message #13 received at 55438-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 55438-done <at> debbugs.gnu.org, zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: [bug#55438] [PATCH] doc: Use the shell dollar substitution.
Date: Sun, 5 Jun 2022 13:40:11 +0200
Le Wed, 18 May 2022 00:41:03 -0400,
Maxim Cournoyer <maxim.cournoyer <at> gmail.com> a écrit :

> Hi Simon!
> 
> zimoun <zimon.toutoune <at> gmail.com> writes:
> 
> > Follow up of beaf701d65e9f94d0539e705d6f58a65313c5655.
> >
> > * doc/guix.texi: Replace the shell backquote deprecated
> > substitution by the dollar one.  
> 
> I'm nitpicking, but per "info bash", I'd reword the commit summary as
> "Use new-style command substitution".  And "Replace the shell
> old-style command substitution with the new-style one."
> 
> With this, I'd be happy to push :-)
> 
> Thanks!
> 
> Maxim
> 
> 
> 

I talked with Simon who agreed with the change, so pushed to master as
e584e58e925ca9423b46f636f08ad87c8d12a229, thanks!




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 04 Jul 2022 11:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 297 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.