GNU bug report logs - #55443
emacs-28.1: tramp sudo broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55443 in the body.
You can then email your comments to 55443 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Remco van 't Veer <remco <at> remworks.net>
To: bug-guix <bug-guix <at> gnu.org>
Subject: emacs-28.1: tramp sudo broken
Date: Mon, 16 May 2022 08:27:53 +0200

After upgrading from emacs-27.2 to emacs-28.1 on a Guix system, opening
files/directories via sudo using tramp no longer works.

Here's what's in the *Messages* buffer:

> Tramp: Opening connection nil for root <at> remq240 using sudo...done
> File error: Couldn't find a proper `ls' command [6 times]
> tramp-error: Couldn't find a proper `ls' command

I am at:

> Generation 48	May 15 2022 16:38:54	(current)
>   guix 9860c90
>     repository URL: https://git.savannah.gnu.org/git/guix.git
>     branch: master
>     commit: 9860c90e8e5362e0e843efbd45f4563b9746a196

Logging out after upgrade does not help.

Kind regards,
Remco

Message #8 received at 55443 <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: Remco van 't Veer <remco <at> remworks.net>, 55443 <at> debbugs.gnu.org
Subject: Re: bug#55443: emacs-28.1: tramp sudo broken
Date: Thu, 19 May 2022 15:57:46 +0200

Hello,

Remco van 't Veer <remco <at> remworks.net> writes:

> After upgrading from emacs-27.2 to emacs-28.1 on a Guix system, opening
> files/directories via sudo using tramp no longer works.
>
> Here's what's in the *Messages* buffer:
>
>> Tramp: Opening connection nil for root <at> remq240 using sudo...done
>> File error: Couldn't find a proper `ls' command [6 times]
>> tramp-error: Couldn't find a proper `ls' command

What I personally use is described at [1], and fixed this issue I had
when I switched to emacs-next.

[1] https://yhetil.org/guix/87czjsmif0.fsf <at> jpoiret.xyz/
-- 
Josselin Poiret

Message #11 received at 55443 <at> debbugs.gnu.org (full text, mbox):

From: benoit <at> benoitj.ca
To: 55443 <at> debbugs.gnu.org
Subject: emacs-28.1: tramp sudo broken
Date: Thu, 19 May 2022 08:46:30 -0400

Hi,

had similar issue using tramp without sudo targetting a guix host.

I could fix the issue by adding /bin/ls as a special file to my services 
with something like:

  (extra-special-file "/bin/ls" (file-append coreutils "/bin/ls"))

Benoit

Message #14 received at 55443 <at> debbugs.gnu.org (full text, mbox):

From: Remco van 't Veer <remco <at> remworks.net>
To: Josselin Poiret <dev <at> jpoiret.xyz>
Cc: 55443 <at> debbugs.gnu.org
Subject: Re: bug#55443: emacs-28.1: tramp sudo broken
Date: Thu, 19 May 2022 16:55:34 +0200

2022/05/19 15:57, Josselin Poiret:

> What I personally use is described at [1], and fixed this issue I had
> when I switched to emacs-next.
>
> [1] https://yhetil.org/guix/87czjsmif0.fsf <at> jpoiret.xyz/

Thanks!  Your workaround works.  Here's my slightly tweaked version
(inspired by the post by Max Brieiev):

  (connection-local-set-profile-variables
    'guix-system
    '((tramp-remote-path . (tramp-own-remote-path))))

  (connection-local-set-profiles
    `(:application tramp :protocol "sudo" :machine ,(system-name))
    'guix-system))

I do agree with Maxime Devos in the same thread, ideally tramp sudo
should just work on guix.

Message #17 received at 55443 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: "55443 <at> debbugs.gnu.org" <55443 <at> debbugs.gnu.org>
Subject: [PATCH] gnu: emacs: Fix source snippet.
Date: Wed, 22 Jun 2022 01:53:55 +0000

[Message part 1 (text/plain, inline)]

Hello,

I believe this bug is due to a change in emacs to where the tramp-default-remote-path was moved from tramp-sh.el to tramp.el: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=695f6792f1524a446d276bf5c5e53bbb4c200909

Due to this the source snippet in emacs that adds guix paths did not work, as you should see by examining the variable: C-h v tramp-remote-path

I've tested this patch builds, sets tramp-remote-path, and alleviates the sudo problem I also experienced (for local tramp). Please test if this fixes it for you. And maybe someone can relay this to the guix-devel thread mentioned in case there is more to be done as per the discussion there.

Thanks,
John

[0001-gnu-emacs-Fix-source-snippet.patch (text/x-patch, attachment)]

Message #20 received at 55443 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: "55443 <at> debbugs.gnu.org" <55443 <at> debbugs.gnu.org>
Cc: "dev <at> jpoiret.xyz" <dev <at> jpoiret.xyz>,
 "benoit <at> benoitj.ca" <benoit <at> benoitj.ca>
Subject: Re: [PATCH] gnu: emacs: Fix source snippet.
Date: Wed, 22 Jun 2022 14:41:28 +0000

[Message part 1 (text/plain, inline)]

I forgot to CC other users on the bug, so I'm sending the message again. Apologies if you got this twice.


------- Original Message -------
On Tuesday, June 21st, 2022 at 9:53 PM, John Kehayias <john.kehayias <at> protonmail.com> wrote:


> Hello,
>
> I believe this bug is due to a change in emacs to where the tramp-default-remote-path was moved from tramp-sh.el to tramp.el: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=695f6792f1524a446d276bf5c5e53bbb4c200909
>
> Due to this the source snippet in emacs that adds guix paths did not work, as you should see by examining the variable: C-h v tramp-remote-path
>
> I've tested this patch builds, sets tramp-remote-path, and alleviates the sudo problem I also experienced (for local tramp). Please test if this fixes it for you. And maybe someone can relay this to the guix-devel thread mentioned in case there is more to be done as per the discussion there.
>
> Thanks,
> John

[0001-gnu-emacs-Fix-source-snippet.patch (text/x-patch, attachment)]

Message #25 received at 55443-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: John Kehayias <john.kehayias <at> protonmail.com>, 55443-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: emacs: Fix source snippet.
Date: Wed, 22 Jun 2022 21:47:32 +0200

Am Mittwoch, dem 22.06.2022 um 01:53 +0000 schrieb John Kehayias:
> I've tested this patch builds, sets tramp-remote-path, and alleviates
> the sudo problem I also experienced (for local tramp). 
I saw, I reworded slightly, I pushed.

> Maybe someone can relay this to the guix-devel thread mentioned in
> case there is more to be done as per the discussion there.
I don't think a discussion that is several months old has weight in
deciding what to do with relatively newer bugs.  In any case, I think
our tramp fixes should at some point also end up in the actual tramp
package, not just emacs itself :)

That being said, thanks for the fix and have a nice evening

Message #28 received at 55443 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: "55443 <at> debbugs.gnu.org" <55443 <at> debbugs.gnu.org>
Subject: Re: [PATCH] gnu: emacs: Fix source snippet.
Date: Wed, 22 Jun 2022 20:06:50 +0000

Hello!

------- Original Message -------
On Wednesday, June 22nd, 2022 at 3:47 PM, Liliana Marie Prikler wrote:

> I saw, I reworded slightly, I pushed.
>

Thanks!

> > Maybe someone can relay this to the guix-devel thread mentioned in
> > case there is more to be done as per the discussion there.
>
> I don't think a discussion that is several months old has weight in
> deciding what to do with relatively newer bugs. In any case, I think
> our tramp fixes should at some point also end up in the actual tramp
> package, not just emacs itself :)
>

I didn't follow the discussion thread but thought it might be the same (or in addition to) this bug. In any event, sure let's leave that to the actual bug tracking.

And yes, we should see about getting this in emacs proper, they should have GNU's own Guix taken care of as well :)

> That being said, thanks for the fix and have a nice evening

Thanks for the quick review and push, have a great day too!

Message #31 received at 55443 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: "55443 <at> debbugs.gnu.org" <55443 <at> debbugs.gnu.org>
Subject: Re: [PATCH] gnu: emacs: Fix source snippet.
Date: Thu, 23 Jun 2022 07:26:55 +0200

Am Mittwoch, dem 22.06.2022 um 20:06 +0000 schrieb John Kehayias:
> [...]
> On Wednesday, June 22nd, 2022 at 3:47 PM, Liliana Marie Prikler
> wrote:
> > [O]ur tramp fixes should at some point also end up in the actual
> > tramp package, not just emacs itself :)
> [...]
> And yes, we should see about getting this in emacs proper, they
> should have GNU's own Guix taken care of as well :)
Actually, the point was to also have them in our emacs-tramp package,
which (like emacs-org) doesn't always receive the fixups that land in
the emacs package.  Lots of work duplicated since Emacs vendors those.

Cheers

Message #34 received at 55443 <at> debbugs.gnu.org (full text, mbox):

From: Remco van 't Veer <remco <at> remworks.net>
To: 55443 <at> debbugs.gnu.org
Cc: John Kehayias <john.kehayias <at> protonmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: bug#55443: closed (Re: [PATCH] gnu: emacs: Fix source snippet.)
Date: Sat, 25 Jun 2022 16:57:35 +0200

Works for me, thank you!

Cheers,
Remco

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.