GNU bug report logs - #55455
[macOS] Fix build when using brew's libgccjit

Previous Next

Package: emacs;

Reported by: John Buckley <nhoj.buckley <at> gmail.com>

Date: Mon, 16 May 2022 15:24:02 UTC

Severity: normal

Tags: fixed

Fixed in version 29.1

Done: Robert Pluim <rpluim <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55455 in the body.
You can then email your comments to 55455 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#55455; Package emacs. (Mon, 16 May 2022 15:24:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to John Buckley <nhoj.buckley <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 16 May 2022 15:24:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Buckley <nhoj.buckley <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [macOS] Fix build when using brew's libgccjit
Date: Mon, 16 May 2022 12:38:14 +0100
[Message part 1 (text/plain, inline)]
libgccjit installed via Homebrew now uses the correct .dylib dynamic library
extension on macOS. This causes configure to fail because it is still
using the .so extension.

The attached patch fixes the libgccjit library extension in configure.ac

In GNU Emacs 28.1.50 (build 2, x86_64-apple-darwin21.4.0, NS appkit-2113.40
Version 12.3.1 (Build 21E258))
 of 2022-04-25 built on iMac-Pro.local
Repository revision: 7c1fc2348918a1ad8c61c7519a51042d48d7aa8d
Repository branch: emacs-28
Windowing system distributor 'Apple', version 10.3.2113
System Description:  macOS 12.3.1

Configured using:
 'configure --with-native-compilation'

Configured features:
ACL GMP GNUTLS JSON LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER
THREADS TOOLKIT_SCROLL_BARS ZLIB

Important settings:
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8-unix
[Message part 2 (text/html, inline)]
[configure.ac.patch (application/octet-stream, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#55455; Package emacs. (Mon, 16 May 2022 16:08:01 GMT) Full text and rfc822 format available.

Message #8 received at 55455 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: John Buckley <nhoj.buckley <at> gmail.com>
Cc: 55455 <at> debbugs.gnu.org
Subject: Re: bug#55455: [macOS] Fix build when using brew's libgccjit
Date: Mon, 16 May 2022 18:07:04 +0200
merge 55173 55455
tags 55455 fixed
close 55455 29.1
quit

>>>>> On Mon, 16 May 2022 12:38:14 +0100, John Buckley <nhoj.buckley <at> gmail.com> said:

    John> libgccjit installed via Homebrew now uses the correct .dylib dynamic library
    John> extension on macOS. This causes configure to fail because it is still
    John> using the .so extension.

    John> The attached patch fixes the libgccjit library extension in configure.ac

This was fixed on master in a more backwards compatible way already
for bug#55173 by commit faa29fa2c9

Closing.

Robert
-- 
Closing.




Added tag(s) fixed. Request was from Robert Pluim <rpluim <at> gmail.com> to control <at> debbugs.gnu.org. (Mon, 16 May 2022 16:08:01 GMT) Full text and rfc822 format available.

bug marked as fixed in version 29.1, send any further explanations to 55455 <at> debbugs.gnu.org and John Buckley <nhoj.buckley <at> gmail.com> Request was from Robert Pluim <rpluim <at> gmail.com> to control <at> debbugs.gnu.org. (Mon, 16 May 2022 16:08:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#55455; Package emacs. (Mon, 16 May 2022 16:12:02 GMT) Full text and rfc822 format available.

Message #15 received at 55455 <at> debbugs.gnu.org (full text, mbox):

From: John Buckley <nhoj.buckley <at> gmail.com>
To: 55455 <at> debbugs.gnu.org
Subject: Re: [macOS] Fix build when using brew's libgccjit
Date: Mon, 16 May 2022 17:11:31 +0100
[Message part 1 (text/plain, inline)]
A little more info:

- This patch will not currently work on ARM64 because brew's libgccjit is
using a fork for ARM. The .so -> .dylib fix for macOS has not been
incorporated into the fork yet.
- I forgot to add the [PATCH] prefix to this issue. Apologies.

For more context please see:
https://github.com/Homebrew/homebrew-core/issues/101673
[Message part 2 (text/html, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#55455; Package emacs. (Mon, 16 May 2022 16:22:02 GMT) Full text and rfc822 format available.

Message #18 received at 55455 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Martín <mardani29 <at> yahoo.es>
To: John Buckley <nhoj.buckley <at> gmail.com>
Cc: 55455 <at> debbugs.gnu.org
Subject: Re: bug#55455: [macOS] Fix build when using brew's libgccjit
Date: Mon, 16 May 2022 18:21:15 +0200
John Buckley <nhoj.buckley <at> gmail.com> writes:

> libgccjit installed via Homebrew now uses the correct .dylib dynamic library
> extension on macOS. This causes configure to fail because it is still
> using the .so extension.
>
> The attached patch fixes the libgccjit library extension in
> configure.ac

I think this is a duplicate of bug#55173, which should be fixed already.
Could you try to build Emacs with native compilation from the master
branch?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#55455; Package emacs. (Mon, 16 May 2022 16:24:01 GMT) Full text and rfc822 format available.

Message #21 received at 55455 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: John Buckley <nhoj.buckley <at> gmail.com>
Cc: 55455 <at> debbugs.gnu.org
Subject: Re: bug#55455: [macOS] Fix build when using brew's libgccjit
Date: Mon, 16 May 2022 19:22:53 +0300
> From: John Buckley <nhoj.buckley <at> gmail.com>
> Date: Mon, 16 May 2022 12:38:14 +0100
> 
> libgccjit installed via Homebrew now uses the correct .dylib dynamic library
> extension on macOS.

By "now" do you mean in some recent enough version?  That is, older
versions will still use the .so extension?

> This causes configure to fail because it is still
> using the .so extension.
> 
> The attached patch fixes the libgccjit library extension in configure.ac

Shouldn't we try both extensions?

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#55455; Package emacs. (Mon, 16 May 2022 19:02:02 GMT) Full text and rfc822 format available.

Message #24 received at 55455 <at> debbugs.gnu.org (full text, mbox):

From: John Buckley <nhoj.buckley <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 55455 <at> debbugs.gnu.org
Subject: Re: bug#55455: [macOS] Fix build when using brew's libgccjit
Date: Mon, 16 May 2022 20:00:58 +0100
[Message part 1 (text/plain, inline)]
> Daniel Martin <mardani29 <at> yahoo.es>

> I think this is a duplicate of bug#55173, which should be fixed already.
> Could you try to build Emacs with native compilation from the
master branch?

Yes it is as confirmed by Robert.
All is ok now on `master`. I've been on emacs-28 for a while now, probably
time to move to master.

> Eli Zaretskii <eliz <at> gnu.org>

> By "now" do you mean in some recent enough version?  That is, older
> versions will still use the .so extension?

Older versions of gcc used the wrong dynamic library extension for
libgccjit on macOS. Brew on X86_64 uses the latest version. However, brew on
ARM64 is still using the .so version because it depends on an older fork of
gcc. So both need to be supported.

> Shouldn't we try both extensions?

The fix in master does this correctly.

Thanks for the comments - all resolved now.

On Mon, 16 May 2022 at 17:23, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: John Buckley <nhoj.buckley <at> gmail.com>
> > Date: Mon, 16 May 2022 12:38:14 +0100
> >
> > libgccjit installed via Homebrew now uses the correct .dylib dynamic
> library
> > extension on macOS.
>
> By "now" do you mean in some recent enough version?  That is, older
> versions will still use the .so extension?
>
> > This causes configure to fail because it is still
> > using the .so extension.
> >
> > The attached patch fixes the libgccjit library extension in configure.ac
>
> Shouldn't we try both extensions?
>
> Thanks.
>
[Message part 2 (text/html, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 14 Jun 2022 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 288 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.