GNU bug report logs - #55460
[PATCH] gnu: emacs-doom-themes: Include extension files.

Previous Next

Package: guix-patches;

Reported by: Dominic Martinez <dom <at> dominicm.dev>

Date: Mon, 16 May 2022 18:32:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55460 in the body.
You can then email your comments to 55460 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#55460; Package guix-patches. (Mon, 16 May 2022 18:32:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Dominic Martinez <dom <at> dominicm.dev>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 16 May 2022 18:32:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dominic Martinez <dom <at> dominicm.dev>
To: guix-patches <at> gnu.org
Cc: Dominic Martinez <dom <at> dominicm.dev>
Subject: [PATCH] gnu: emacs-doom-themes: Include extension files.
Date: Mon, 16 May 2022 14:30:45 -0400
Newer versions of `emacs-doom-themes' separated extension support into a
separate directory, so this change includes those files.
---
 gnu/packages/emacs-xyz.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8d66278b8f..fa3af93b61 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27554,7 +27554,9 @@ (define-public emacs-doom-themes
                ;; EMACSLOADPATH.
                (for-each (lambda (f)
                            (rename-file f (basename f)))
-                         (find-files "./themes" ".*\\.el$"))
+                         (append
+                          (find-files "./themes" ".*\\.el$")
+                          (find-files "./extensions" ".*\\.el$")))
                #t)))))
       (synopsis "Wide collection of color themes for Emacs")
       (description "Emacs-doom-themes contains numerous popular color themes for
-- 
2.36.0





Information forwarded to guix-patches <at> gnu.org:
bug#55460; Package guix-patches. (Mon, 16 May 2022 18:51:02 GMT) Full text and rfc822 format available.

Message #8 received at 55460 <at> debbugs.gnu.org (full text, mbox):

From: Dominic Martinez <dom <at> dominicm.dev>
To: 55460 <at> debbugs.gnu.org
Cc: Dominic Martinez <dom <at> dominicm.dev>
Subject: [PATCH v2] gnu: emacs-doom-themes: Include extension files.
Date: Mon, 16 May 2022 14:50:06 -0400
Newer versions of `emacs-doom-themes' separated extension support into a
separate directory, so this change includes those files.
---
Sorry, small amendment to the previous patch as I forgot to include my copyright.

 gnu/packages/emacs-xyz.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8d66278b8f..5e1f1f6c27 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -109,6 +109,7 @@
 ;;; Copyright © 2022 Brandon Lucas <br <at> ndon.dk>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan <at> gmail.com>
 ;;; Copyright © 2022 jgart <jgart <at> dismail.de>
+;;; Copyright © 2022 Dominic Martinez <dom <at> dominicm.dev>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -27554,7 +27555,9 @@ (define-public emacs-doom-themes
                ;; EMACSLOADPATH.
                (for-each (lambda (f)
                            (rename-file f (basename f)))
-                         (find-files "./themes" ".*\\.el$"))
+                         (append
+                          (find-files "./themes" ".*\\.el$")
+                          (find-files "./extensions" ".*\\.el$")))
                #t)))))
       (synopsis "Wide collection of color themes for Emacs")
       (description "Emacs-doom-themes contains numerous popular color themes for
-- 
2.36.0





Information forwarded to guix-patches <at> gnu.org:
bug#55460; Package guix-patches. (Wed, 18 May 2022 16:10:01 GMT) Full text and rfc822 format available.

Message #11 received at 55460 <at> debbugs.gnu.org (full text, mbox):

From: Dominic Martinez <dom <at> dominicm.dev>
To: 55460 <at> debbugs.gnu.org
Cc: Dominic Martinez <dom <at> dominicm.dev>
Subject: Re: [PATCH v2] gnu: emacs-doom-themes: Include extension files.
Date: Wed, 18 May 2022 12:07:14 -0400
[Message part 1 (text/plain, inline)]
Bumping this patch as #55452 broke extension support.

[signature.asc (application/pgp-signature, inline)]

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Wed, 01 Jun 2022 20:48:02 GMT) Full text and rfc822 format available.

Notification sent to Dominic Martinez <dom <at> dominicm.dev>:
bug acknowledged by developer. (Wed, 01 Jun 2022 20:48:02 GMT) Full text and rfc822 format available.

Message #16 received at 55460-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Dominic Martinez <dom <at> dominicm.dev>
Cc: 55460-done <at> debbugs.gnu.org
Subject: Re: bug#55460: [PATCH] gnu: emacs-doom-themes: Include extension
 files.
Date: Wed, 01 Jun 2022 22:47:14 +0200
Hi,

Dominic Martinez <dom <at> dominicm.dev> skribis:

> Newer versions of `emacs-doom-themes' separated extension support into a
> separate directory, so this change includes those files.
> ---
> Sorry, small amendment to the previous patch as I forgot to include my copyright.
>
>  gnu/packages/emacs-xyz.scm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Applied, thanks, and sorry for the delay.

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 30 Jun 2022 11:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 299 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.