GNU bug report logs - #55463
[PATCH] Fix font options compilation with gsettings disabled

Previous Next

Package: emacs;

Reported by: Pieter van Prooijen <pieter.van.prooijen <at> teloden.nl>

Date: Mon, 16 May 2022 20:23:02 UTC

Severity: normal

Tags: patch

Done: Po Lu <luangruo <at> yahoo.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55463 in the body.
You can then email your comments to 55463 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#55463; Package emacs. (Mon, 16 May 2022 20:23:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Pieter van Prooijen <pieter.van.prooijen <at> teloden.nl>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 16 May 2022 20:23:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pieter van Prooijen <pieter.van.prooijen <at> teloden.nl>
To: bug-gnu-emacs <at> gnu.org
Cc: wilde <at> sha-bang.de
Subject: [PATCH] Fix font options compilation with gsettings disabled
Date: Mon, 16 May 2022 22:22:23 +0200

[Message part 1 (text/plain, inline)]
Hello All,

This is a small patch to make the recent gsettings font rendering
changes compile when pgtk is configured but gsettings is not.

Kind Regards,

Pieter van Prooijen




[0001-Fix-font-options-compilation-with-gsettings-disabled.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#55463; Package emacs. (Tue, 17 May 2022 01:06:01 GMT) Full text and rfc822 format available.

Message #8 received at 55463 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Pieter van Prooijen <pieter.van.prooijen <at> teloden.nl>
Cc: wilde <at> sha-bang.de, 55463 <at> debbugs.gnu.org
Subject: Re: bug#55463: [PATCH] Fix font options compilation with gsettings
 disabled
Date: Tue, 17 May 2022 09:05:10 +0800

Pieter van Prooijen <pieter.van.prooijen <at> teloden.nl> writes:

> Hello All,
>
> This is a small patch to make the recent gsettings font rendering
> changes compile when pgtk is configured but gsettings is not.

Thanks.

> -/* Return the cairo font options, updated from the gsettings font
> -   config entries.  The caller should call cairo_font_options_destroy
> -   on the result.  */
> +/* Return the cairo font options, optionally updated from the gsettings
> +   font config entries.  The caller should call
> +   cairo_font_options_destroy on the result.  */

I think this change is extraneous.  That comment doesn't have to be so
detailed, since building Emacs without GSettings support is a rather
oddball configuration, and it obviously cannot be used without support
being built-in.

Otherwise, LGTM.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#55463; Package emacs. (Tue, 17 May 2022 08:30:02 GMT) Full text and rfc822 format available.

Message #11 received at 55463 <at> debbugs.gnu.org (full text, mbox):

From: Pieter van Prooijen <pieter.van.prooijen <at> teloden.nl>
To: Po Lu <luangruo <at> yahoo.com>
Cc: wilde <at> sha-bang.de, 55463 <at> debbugs.gnu.org
Subject: Re: bug#55463: [PATCH] Fix font options compilation with gsettings
 disabled
Date: Tue, 17 May 2022 10:28:55 +0200

[Message part 1 (text/plain, inline)]
Hi, 

I've reverted the change in the comment, here's the patch without that
change.

Kind Regards,

Pieter

On Tue, 2022-05-17 at 09:05 +0800, Po Lu wrote:
> Pieter van Prooijen <pieter.van.prooijen <at> teloden.nl> writes:
> 
> > Hello All,
> > 
> > This is a small patch to make the recent gsettings font rendering
> > changes compile when pgtk is configured but gsettings is not.
> 
> Thanks.
> 
> > -/* Return the cairo font options, updated from the gsettings font
> > -   config entries.  The caller should call
> > cairo_font_options_destroy
> > -   on the result.  */
> > +/* Return the cairo font options, optionally updated from the
> > gsettings
> > +   font config entries.  The caller should call
> > +   cairo_font_options_destroy on the result.  */
> 
> I think this change is extraneous.  That comment doesn't have to be
> so
> detailed, since building Emacs without GSettings support is a rather
> oddball configuration, and it obviously cannot be used without
> support
> being built-in.
> 
> Otherwise, LGTM.


[0001-Fix-font-options-compilation-with-gsettings-disabled.patch (text/x-patch, attachment)]
Reply sent to Po Lu <luangruo <at> yahoo.com>:
You have taken responsibility. (Tue, 17 May 2022 10:17:02 GMT) Full text and rfc822 format available.
Notification sent to Pieter van Prooijen <pieter.van.prooijen <at> teloden.nl>:
bug acknowledged by developer. (Tue, 17 May 2022 10:17:02 GMT) Full text and rfc822 format available.

Message #16 received at 55463-done <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Pieter van Prooijen <pieter.van.prooijen <at> teloden.nl>
Cc: wilde <at> sha-bang.de, 55463-done <at> debbugs.gnu.org
Subject: Re: bug#55463: [PATCH] Fix font options compilation with gsettings
 disabled
Date: Tue, 17 May 2022 18:15:43 +0800

Pieter van Prooijen <pieter.van.prooijen <at> teloden.nl> writes:

> Hi, 
>
> I've reverted the change in the comment, here's the patch without that
> change.

Now installed, so I'm closing this bug.  Thanks.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 14 Jun 2022 11:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 317 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.