GNU bug report logs - #55468
[PATCH 2/2] gnu: emacs-explain-pause-mode: Fix failing tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55468 in the body.
You can then email your comments to 55468 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: luishgh <luishenriquegh2701 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: luishgh <51053603+luishgh <at> users.noreply.github.com>
Subject: [PATCH 2/2] gnu: emacs-explain-pause-mode: Fix failing tests.
Date: Mon, 16 May 2022 20:45:53 -0300

From: luishgh <51053603+luishgh <at> users.noreply.github.com>

* gnu/packages/emacs-xyz.scm (emacs-explain-pause-mode): Fix failing tests.
---
 gnu/packages/emacs-xyz.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 590330ac4f..8fc1d38193 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -4709,7 +4709,7 @@ (define-public emacs-explain-pause-mode
         (revision "0"))
     (package
       (name "emacs-explain-pause-mode")
-      (version (git-version "0.1" revision commit))
+      (version (git-version "0.2" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -4724,6 +4724,13 @@ (define-public emacs-explain-pause-mode
        (list emacs-buttercup))
       (arguments
        '(#:tests? #t
+         #:phases
+         (modify-phases %standard-phases
+           ;; This causes the byte-compilation before unit-tests to fail
+           (add-after 'unpack 'remove-error-on-warn
+             (lambda _
+               (substitute* "Makefile"
+                 (("--eval '\\(setq byte-compile-error-on-warn t\\)'") "")))))
          ;; Don't run case-tests as they will fail to create sockets because
          ;; the path is too long
          #:test-command '("make" "byte-compile" "unit-tests")
-- 
2.36.0

Message #8 received at 55468 <at> debbugs.gnu.org (full text, mbox):

From: Luis Henrique Gomes Higino <luishenriquegh2701 <at> gmail.com>
To: 55467 <at> debbugs.gnu.org
Cc: 55468 <at> debbugs.gnu.org
Subject: Apologies
Date: Mon, 16 May 2022 20:50:43 -0300

Hi guix,

sent the patches as separate issues :/. The right one is 
https://issues.guix.gnu.org/55466. Sorry for the inconvenience.

Regards,
-- 
Luis H. Higino

Message #13 received at 55468-close <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: luishgh <luishenriquegh2701 <at> gmail.com>
Cc: luishgh <51053603+luishgh <at> users.noreply.github.com>,
 55468-close <at> debbugs.gnu.org
Subject: Re: [bug#55468] [PATCH 2/2] gnu: emacs-explain-pause-mode: Fix
 failing tests.
Date: Tue, 17 May 2022 09:19:50 +0200

luishgh <luishenriquegh2701 <at> gmail.com> writes:

> From: luishgh <51053603+luishgh <at> users.noreply.github.com>
>
> * gnu/packages/emacs-xyz.scm (emacs-explain-pause-mode): Fix failing
> tests.

Closing, as a duplicate of bug#55466.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.