GNU bug report logs -
#55485
[PATCH] gnu: wla-dx: Update to 10.1.
Previous Next
Reported by: Felix Gruber <felgru <at> posteo.net>
Date: Tue, 17 May 2022 17:26:02 UTC
Severity: normal
Tags: patch
Done: Ludovic Courtès <ludo <at> gnu.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55485 in the body.
You can then email your comments to 55485 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#55485
; Package
guix-patches
.
(Tue, 17 May 2022 17:26:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Felix Gruber <felgru <at> posteo.net>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Tue, 17 May 2022 17:26:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/assembly.scm (wla-dx): Update to 10.1.
[native-inputs]: Use new style.
---
gnu/packages/assembly.scm | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/assembly.scm b/gnu/packages/assembly.scm
index b2830716e1..534cffd7df 100644
--- a/gnu/packages/assembly.scm
+++ b/gnu/packages/assembly.scm
@@ -342,7 +342,7 @@ package for the Game Boy and Game Boy Color. It consists of:
(define-public wla-dx
(package
(name "wla-dx")
- (version "9.12")
+ (version "10.1")
(source (origin
(method git-fetch)
(uri (git-reference
@@ -351,10 +351,9 @@ package for the Game Boy and Game Boy Color. It consists of:
(file-name (git-file-name name version))
(sha256
(base32
- "1wlbqv2rgk9q6m9an1mi0i29250zl8lw7zipki2bbi9mczpyczli"))))
+ "1nh2k2xn5fj389gq68f3fxgrxakgn8c6dw2ffqay86s3706hac9w"))))
(build-system cmake-build-system)
- (native-inputs
- `(("sphinx" ,python-sphinx))) ; to generate man pages
+ (native-inputs (list python-sphinx)) ; to generate man pages
(arguments
`(#:tests? #f)) ; no tests
(home-page "https://github.com/vhelin/wla-dx")
--
2.30.2
Information forwarded
to
guix-patches <at> gnu.org
:
bug#55485
; Package
guix-patches
.
(Tue, 17 May 2022 18:03:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 55485 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Felix Gruber schreef op di 17-05-2022 om 17:24 [+0000]:
> `(#:tests? #f)) ; no tests
10.1 appears to have lots of tests in
<https://github.com/vhelin/wla-dx/tree/v10.1/tests>.
It looks like you can run them with run_tests.sh:
https://github.com/vhelin/wla-dx/blob/master/run_tests.sh
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#55485
; Package
guix-patches
.
(Wed, 18 May 2022 17:29:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 55485 <at> debbugs.gnu.org (full text, mbox):
Hi Maxime,
On 5/17/22 20:02, Maxime Devos wrote:
> Felix Gruber schreef op di 17-05-2022 om 17:24 [+0000]:
>> `(#:tests? #f)) ; no tests
>
> 10.1 appears to have lots of tests in
> <https://github.com/vhelin/wla-dx/tree/v10.1/tests>.
>
> It looks like you can run them with run_tests.sh:
>
> https://github.com/vhelin/wla-dx/blob/master/run_tests.sh
Thanks for the hint. I'll send a new patch that uses this run_tests.sh
script in its 'check phase.
Kind regards,
Felix
Information forwarded
to
guix-patches <at> gnu.org
:
bug#55485
; Package
guix-patches
.
(Wed, 18 May 2022 17:32:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 55485 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/assembly.scm (wla-dx): Update to 10.1.
[native-inputs]: Use new style.
[arguments]: Add custom 'check phase to run run_tests.sh.
---
gnu/packages/assembly.scm | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/gnu/packages/assembly.scm b/gnu/packages/assembly.scm
index b2830716e1..ca50b00a06 100644
--- a/gnu/packages/assembly.scm
+++ b/gnu/packages/assembly.scm
@@ -11,6 +11,7 @@
;;; Copyright © 2020 B. Wilson <elaexuotee <at> wilsonb.com>
;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
;;; Copyright © 2021 Guillaume Le Vaillant <glv <at> posteo.net>
+;;; Copyright © 2022 Felix Gruber <felgru <at> posteo.net>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -342,7 +343,7 @@ package for the Game Boy and Game Boy Color. It consists of:
(define-public wla-dx
(package
(name "wla-dx")
- (version "9.12")
+ (version "10.1")
(source (origin
(method git-fetch)
(uri (git-reference
@@ -351,12 +352,20 @@ package for the Game Boy and Game Boy Color. It consists of:
(file-name (git-file-name name version))
(sha256
(base32
- "1wlbqv2rgk9q6m9an1mi0i29250zl8lw7zipki2bbi9mczpyczli"))))
+ "1nh2k2xn5fj389gq68f3fxgrxakgn8c6dw2ffqay86s3706hac9w"))))
(build-system cmake-build-system)
- (native-inputs
- `(("sphinx" ,python-sphinx))) ; to generate man pages
+ (native-inputs (list python-sphinx)) ; to generate man pages
(arguments
- `(#:tests? #f)) ; no tests
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-before 'check 'copy-tests-to-build-directory
+ (lambda _
+ (copy-recursively "../source/tests" "tests")))
+ (replace 'check
+ (lambda* (#:key tests? #:allow-other-keys)
+ (let ((sh (which "sh")))
+ (when tests?
+ (invoke sh "../source/run_tests.sh"))))))))
(home-page "https://github.com/vhelin/wla-dx")
(synopsis "Assemblers for various processors")
(description "WLA DX is a set of tools to assemble assembly files to
--
2.30.2
Reply sent
to
Ludovic Courtès <ludo <at> gnu.org>
:
You have taken responsibility.
(Sun, 29 May 2022 21:36:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
Felix Gruber <felgru <at> posteo.net>
:
bug acknowledged by developer.
(Sun, 29 May 2022 21:36:01 GMT)
Full text and
rfc822 format available.
Message #19 received at 55485-done <at> debbugs.gnu.org (full text, mbox):
Hi,
Felix Gruber <felgru <at> posteo.net> skribis:
> * gnu/packages/assembly.scm (wla-dx): Update to 10.1.
> [native-inputs]: Use new style.
> [arguments]: Add custom 'check phase to run run_tests.sh.
Applied, thank you & thanks Maxime!
Ludo’.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Mon, 27 Jun 2022 11:24:11 GMT)
Full text and
rfc822 format available.
This bug report was last modified 1 year and 274 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.