GNU bug report logs - #55494
[PATCH] daemon: runChild() is forbidden to talk during environment set up

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55494 in the body.
You can then email your comments to 55494 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: yarl-baudig <at> mailoo.org
To: guix-patches <at> gnu.org
Subject: [PATCH] daemon: runChild() is forbidden to talk during
 environment  set up
Date: Tue, 17 May 2022 23:08:54 +0200 (CEST)

DerivationGoal::startBuilder() is waiting for an empty line as a check that
the environment set up is fine.

Fixes <https://issues.guix.gnu.org/55324>
---
 nix/libstore/build.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc
index f6431bb726..9305208009 100644
--- a/nix/libstore/build.cc
+++ b/nix/libstore/build.cc
@@ -2057,7 +2057,6 @@ void DerivationGoal::runChild()
                 Path source = i->second;
                 Path target = chrootRootDir + i->first;
                 if (source == "/proc") continue; // backwards compatibility
-                debug(format("bind mounting `%1%' to `%2%'") % source % target);
                 if (stat(source.c_str(), &st) == -1)
                     throw SysError(format("getting attributes of path `%1%'") % source);
                 if (S_ISDIR(st.st_mode))
-- 
2.36.0

Message #10 received at 55494-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: yarl-baudig <at> mailoo.org
Cc: 55324-done <at> debbugs.gnu.org, 55494-done <at> debbugs.gnu.org
Subject: Re: bug#55494: [PATCH] daemon: runChild() is forbidden to talk
 during environment  set up
Date: Thu, 19 May 2022 16:48:09 +0200

Hi,

yarl-baudig <at> mailoo.org skribis:

> DerivationGoal::startBuilder() is waiting for an empty line as a check that
> the environment set up is fine.
>
> Fixes <https://issues.guix.gnu.org/55324>

Oh, good catch!

I tweaked the commit log and applied it.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.