GNU bug report logs - #55531
[PATCH] gnu: dumb: Fix build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55531 in the body.
You can then email your comments to 55531 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Foo Chuan Wei <chuanwei.foo <at> hotmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: dumb: Fix build.
Date: Fri, 20 May 2022 03:55:11 +0000

* gnu/packages/music.scm (dumb, dumb-allegro4): Fix failing build of "dumb"
  caused by missing allegro-4 dependency.
---
This patch fixes the failing build of the "dumb" package by removing the
need to have allegro-4. I am not sure why Guix needs both "dumb" and
"dumb-allegro4". By default, dumb requires allegro-4.


 gnu/packages/music.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 210af3b166..bb456abdb1 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -705,7 +705,8 @@ background while you work.")
     (arguments
      '(#:tests? #f ; no check target
        #:configure-flags
-       (list "-DBUILD_SHARED_LIBS=ON"
+       (list "-DBUILD_ALLEGRO4=OFF"
+             "-DBUILD_SHARED_LIBS=ON"
              "-DBUILD_EXAMPLES=OFF")))
     (home-page "https://github.com/kode54/dumb")
     (synopsis "Module audio renderer library")
@@ -729,7 +730,7 @@ settings (aliasing, linear interpolation and cubic interpolation).")
     (arguments
      (substitute-keyword-arguments (package-arguments dumb)
        ((#:configure-flags flags)
-        `(cons "-DBUILD_ALLEGRO4=ON" ,flags))))
+        `(cons "-DBUILD_ALLEGRO4=ON" ,(delete "-DBUILD_ALLEGRO4=OFF" flags)))))
     (inputs
      (list allegro-4))))
 

base-commit: cf17cbbc1b16dd15c8ec2e637d240de7ae5c3a44
-- 
2.25.1

Message #10 received at 55531-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: 55531-done <at> debbugs.gnu.org
Subject: Re: bug#55531: [PATCH] gnu: dumb: Fix build.
Date: Tue, 24 May 2022 16:54:12 +0200

Hi,

Foo Chuan Wei <chuanwei.foo <at> hotmail.com> skribis:

> * gnu/packages/music.scm (dumb, dumb-allegro4): Fix failing build of "dumb"
>   caused by missing allegro-4 dependency.

Applied, thanks!

Ludo’.

PS: Your MUA wrongfully sets “Mail-Followup-To: guix-patches <at> gnu.org”.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.