GNU bug report logs - #55573
29.0.50; python.el font-locks invalid class/function names

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55573 in the body.
You can then email your comments to 55573 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: kobarity <kobarity <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; python.el font-locks invalid class/function names
Date: Sun, 22 May 2022 22:20:42 +0900

[Message part 1 (text/plain, inline)]

When the following Python file is loaded using emacs -Q and M-x
find-file, "1func" is font-locked as a function name although it is not
a valid function name.

#+begin_src python
def 1func():
    pass
#+end_src

Attached is my proposal to fix this issue.

In GNU Emacs 29.0.50 (build 4, x86_64-pc-linux-gnu)
 of 2022-05-21 built on ubuntu
Repository revision: 208102fa470e3417320062cdb48a9967d80bf092
Repository branch: master
System Description: Ubuntu 22.04 LTS

Configured using:
 'configure --without-x --with-gnutls=ifavailable'

Configured features:
ACL LIBXML2 MODULES NOTIFY INOTIFY PDUMPER SECCOMP SOUND SQLITE3 THREADS
XIM ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Python

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media rmc puny
dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg
rfc6068 epg-config gnus-util text-property-search time-date mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
wombat-theme manoj-dark-theme dichromacy-theme cus-theme cus-edit pp
cus-start cus-load wid-edit python json map comint regexp-opt ring
cl-loaddefs cl-lib ansi-color seq term/screen term/xterm xterm gv subr-x
byte-opt bytecomp byte-compile cconv iso-transl tooltip eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select mouse
jit-lock font-lock syntax font-core term/tty-colors frame minibuffer
nadvice simple cl-generic cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
faces cus-face macroexp files window text-properties overlay sha1 md5
base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads inotify multi-tty
make-network-process emacs)

Memory information:
((conses 16 84231 7303)
 (symbols 48 8723 1)
 (strings 32 23861 1652)
 (string-bytes 1 712652)
 (vectors 16 12013)
 (vector-slots 8 139506 3457)
 (floats 8 51 673)
 (intervals 56 316 4)
 (buffers 992 13))

[fix-python-font-lock-keywords-level-1.patch (application/octet-stream, attachment)]

Message #8 received at 55573 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: kobarity <kobarity <at> gmail.com>
Cc: 55573 <at> debbugs.gnu.org
Subject: Re: bug#55573: 29.0.50; python.el font-locks invalid class/function
 names
Date: Sun, 22 May 2022 18:53:46 +0200

kobarity <kobarity <at> gmail.com> writes:

> When the following Python file is loaded using emacs -Q and M-x
> find-file, "1func" is font-locked as a function name although it is not
> a valid function name.
>
> #+begin_src python
> def 1func():
>     pass
> #+end_src
>
> Attached is my proposal to fix this issue.

Thanks; pushed to Emacs 29.

For future patches, including ChangeLog style commit messages would be
appreciated.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.