GNU bug report logs - #55574
28.1; desktop-kill not included in kill-emacs-hook anymore

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55574 in the body.
You can then email your comments to 55574 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: tanzer <at> gg32.com
To: bug-gnu-emacs <at> gnu.org
Subject: 28.1; desktop-kill not included in kill-emacs-hook anymore
Date: Sun, 22 May 2022 13:23:03 -0000

Before Emacs 28, `desktop-kill` was included in `kill-emacs-hook` if
`desktop-save-mode` was enabled.

In Emacs 28, `desktop-kill` is included in `kill-emacs-query-functions`
instead. Therefore the desktop is not saved and the desktop lock not
removed when `kill-emacs` is used to exit Emacs.

Unfortunately, the new behavior is not documented in the NEWS file.

The behavior can be reproduced by evaluating the following elisp
snippet in an Emacs 28.1 instance started with `emacs -Q`:

  (desktop-save-mode 1)
  (message "kill-emacs-hook: %s" kill-emacs-hook)

In Emacs 28.1, it will display:

  "kill-emacs-hook: nil"

In Emacs 27.2, it will display:

  "kill-emacs-hook: (desktop-kill)"

Please revoke the change or document it properly.



In GNU Emacs 28.1 (build 1, aarch64-apple-darwin21.1.0, NS appkit-2113.00 Version 12.0.1 (Build 21A559))
of 2022-04-04 built on armbob.lan
Windowing system distributor 'Apple', version 10.3.2113
System Description:  macOS 12.4

Configured using:
'configure --with-ns '--enable-locallisppath=/Library/Application
Support/Emacs/${version}/site-lisp:/Library/Application
Support/Emacs/site-lisp' --with-modules'

Configured features:
ACL GMP GNUTLS JSON LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER THREADS
TOOLKIT_SCROLL_BARS ZLIB

Important settings:
  value of $EMACSLOADPATH: /Users/tanzer/.emacs.lib::/Applications/Emacs.app/Contents/Resources/site-lisp:
  value of $LC_CTYPE: UTF-8
  value of $LC_MESSAGES: en_US.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  desktop-save-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
/Users/tanzer/.emacs.lib/custom hides /Applications/Emacs-28.1.app/Contents/Resources/lisp/custom

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils desktop
frameset cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads kqueue
cocoa ns multi-tty make-network-process emacs)

Memory information:
((conses 16 52547 9320)
(symbols 48 6728 1)
(strings 32 18877 2482)
(string-bytes 1 635721)
(vectors 16 14225)
(vector-slots 8 194877 11238)
(floats 8 22 51)
(intervals 56 203 0)
(buffers 992 10))

--
Christian Tanzer

Message #8 received at 55574 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: tanzer <at> gg32.com
Cc: 55574 <at> debbugs.gnu.org
Subject: Re: bug#55574: 28.1; desktop-kill not included in kill-emacs-hook
 anymore
Date: Sun, 22 May 2022 18:51:38 +0200

tanzer <at> gg32.com writes:

> Before Emacs 28, `desktop-kill` was included in `kill-emacs-hook` if
> `desktop-save-mode` was enabled.

This is a duplicate of bug#55574, so I'm merging the two.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 55574 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: tanzer <at> gg32.com
Cc: 55574 <at> debbugs.gnu.org
Subject: Re: bug#55574: 28.1; desktop-kill not included in kill-emacs-hook
 anymore
Date: Sun, 22 May 2022 18:56:48 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> This is a duplicate of bug#55574, so I'm merging the two.

Sorry; I meant bug#55560.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #18 received at 55574 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Christian Tanzer <tanzer <at> gg32.com>
Cc: 55574 <at> debbugs.gnu.org
Subject: Re: bug#55574: 28.1; desktop-kill not included in kill-emacs-hook
 anymore
Date: Sun, 22 May 2022 21:20:22 +0200

(Re-sending with the debbugs address in the CCs so that it lands in the
bug tracker.)

Christian Tanzer <tanzer <at> gg32.com> writes:

> On 22.05.2022, at 19:12, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:
>> 
>> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>> 
>>> This is a duplicate of bug#55574, so I'm merging the two.
>> 
>> Sorry; I meant bug#55560.
>
> Sorry for the noise. I stumbled over this a few weeks ago and only
> looked into it today, unfortunately without checking for an existing
> report again.
>
> I still think that this needs documenting though because it breaks
> stuff that has worked since forever.
>
> My function calling kill-emacs hasn’t changed since 1993; until today
> that is. I’m pretty sure that back then it wasn’t frowned upon to use
> kill-emacs in elisp code.

Message #23 received at 55574-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: tanzer <at> gg32.com
Cc: 55574-done <at> debbugs.gnu.org
Subject: Re: bug#55574: 28.1;
 desktop-kill not included in kill-emacs-hook anymore
Date: Mon, 23 May 2022 15:00:30 +0300

> Date: Sun, 22 May 2022 13:23:03 -0000
> From: tanzer <at> gg32.com
> 
> 
> Before Emacs 28, `desktop-kill` was included in `kill-emacs-hook` if
> `desktop-save-mode` was enabled.
> 
> In Emacs 28, `desktop-kill` is included in `kill-emacs-query-functions`
> instead. Therefore the desktop is not saved and the desktop lock not
> removed when `kill-emacs` is used to exit Emacs.
> 
> Unfortunately, the new behavior is not documented in the NEWS file.

I've now documented this in NEWS, and I'm therefore closing the bug.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.