GNU bug report logs - #55588
pgtk: child-frame-border-width cannot be set to nil

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55588 in the body.
You can then email your comments to 55588 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Florian Rommel <mail <at> florommel.de>
To: bug-gnu-emacs <at> gnu.org
Subject: pgtk: child-frame-border-width cannot be set to nil
Date: Mon, 23 May 2022 00:03:23 +0200

[Message part 1 (text/plain, inline)]

In pgtk, child-frame-border-width is set to 0 by default, and it cannot
be set to nil.
According to the manual it should be possible for child-frame-border-
width to be nil. In such cases, the value of internal-border-width is
used as the border width (see 30.4.3.4 "Layout Parameters"; and
function FRAME_INTERNAL_BORDER_WIDTH in frame.h).

The problem causes missing child-frame borders for code that depends on
this behavior (e.g., lsp-doc-ui in the lsp-ui package), and it will
cause errors for code that tries to set child-frame-border-width to
nil.

The attached patch fixes this. It essentially replicates the respective
behavior of xfns.c.

[0001-pgtk-Allow-child-frame-border-width-to-be-nil.patch (text/x-patch, attachment)]

Message #8 received at 55588 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Florian Rommel <mail <at> florommel.de>
Cc: 55588 <at> debbugs.gnu.org
Subject: Re: bug#55588: pgtk: child-frame-border-width cannot be set to nil
Date: Mon, 23 May 2022 12:18:39 +0800

Florian Rommel <mail <at> florommel.de> writes:

> In pgtk, child-frame-border-width is set to 0 by default, and it cannot
> be set to nil.
> According to the manual it should be possible for child-frame-border-
> width to be nil. In such cases, the value of internal-border-width is
> used as the border width (see 30.4.3.4 "Layout Parameters"; and
> function FRAME_INTERNAL_BORDER_WIDTH in frame.h).
>
> The problem causes missing child-frame borders for code that depends on
> this behavior (e.g., lsp-doc-ui in the lsp-ui package), and it will
> cause errors for code that tries to set child-frame-border-width to
> nil.
>
> The attached patch fixes this. It essentially replicates the respective
> behavior of xfns.c.

I remember there was a reason internal (and child frame) borders don't
work quite right in child frames on PGTK.  That might've been fixed in
December, but I cannot remember.

Please let me look into this first.

Message #11 received at 55588 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Florian Rommel <mail <at> florommel.de>
Cc: 55588 <at> debbugs.gnu.org
Subject: Re: bug#55588: pgtk: child-frame-border-width cannot be set to nil
Date: Mon, 23 May 2022 13:31:44 +0800

Po Lu <luangruo <at> yahoo.com> writes:

> I remember there was a reason internal (and child frame) borders don't
> work quite right in child frames on PGTK.  That might've been fixed in
> December, but I cannot remember.

It was fixed in December.  I installed a similar change along with some
other fixes to child frames on PGTK, please test.

Message #16 received at 55588 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Florian Rommel <mail <at> florommel.de>
Cc: 55588 <at> debbugs.gnu.org
Subject: Re: bug#55588: pgtk: child-frame-border-width cannot be set to nil
Date: Mon, 23 May 2022 20:15:53 +0800

Florian Rommel <mail <at> florommel.de> writes:

> On Mon, 2022-05-23 at 13:31 +0800, Po Lu wrote:
>> It was fixed in December.  I installed a similar change along with
>> some
>> other fixes to child frames on PGTK, please test.
>
> Thanks! Almost works.
> I believe that the default value of child-frame-border-width should be
> nil (that's the case for xfns and others), with this everything works
> as expected for me.

Should be fixed now as well, thanks.

Message #19 received at 55588 <at> debbugs.gnu.org (full text, mbox):

From: Florian Rommel <mail <at> florommel.de>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 55588 <at> debbugs.gnu.org
Subject: Re: bug#55588: pgtk: child-frame-border-width cannot be set to nil
Date: Mon, 23 May 2022 11:38:41 +0200

[Message part 1 (text/plain, inline)]

On Mon, 2022-05-23 at 13:31 +0800, Po Lu wrote:
> It was fixed in December.  I installed a similar change along with
> some
> other fixes to child frames on PGTK, please test.

Thanks! Almost works.
I believe that the default value of child-frame-border-width should be
nil (that's the case for xfns and others), with this everything works
as expected for me.

[0001-pgtk-Set-child-frame-border-width-to-nil.patch (text/x-patch, attachment)]

Message #22 received at 55588 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: Florian Rommel <mail <at> florommel.de>, 55588 <at> debbugs.gnu.org
Subject: Re: bug#55588: pgtk: child-frame-border-width cannot be set to nil
Date: Tue, 21 Jun 2022 13:45:37 +0200

Po Lu <luangruo <at> yahoo.com> writes:

>> Thanks! Almost works.
>> I believe that the default value of child-frame-border-width should be
>> nil (that's the case for xfns and others), with this everything works
>> as expected for me.
>
> Should be fixed now as well, thanks.

This was a month ago, so I assume Po's fix worked, and I'm therefore
closing this bug report.  If this is still an issue, please respond to
the debbugs address and we'll reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.