GNU bug report logs - #55617
[PATCH 0/2] gnu: rsync: Update to 3.2.4.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55617 in the body.
You can then email your comments to 55617 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] gnu: rsync: Update to 3.2.4.
Date: Tue, 24 May 2022 15:52:46 -0400

[Message part 1 (text/plain, inline)]

$ ./pre-inst-env guix refresh -l rsync
Building the following 39 packages would ensure 124 dependent packages
are rebuilt ...

This patchset also fixes the casync build.

The only dependency failing to build is ocaml-craml, for which the
only release was in 2018 and has had no commits since other than the
addition of a deprecation notice with a given alternative of mdx,
which is available in guix as ocaml-mdx. No other packages depend on
ocaml-craml. Should this package be removed?

Greg

[0002-gnu-casync-Update-to-99559cd1.patch (text/x-patch, attachment)]

[0001-gnu-rsync-Update-to-3.2.4.patch (text/x-patch, attachment)]

Message #8 received at 55617 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Greg Hogan <code <at> greghogan.com>, 55617 <at> debbugs.gnu.org
Subject: Re: [bug#55617] [PATCH 0/2] gnu: rsync: Update to 3.2.4.
Date: Wed, 25 May 2022 16:42:01 +0200

[Message part 1 (text/plain, inline)]

Greg Hogan schreef op di 24-05-2022 om 15:52 [-0400]:
> +         (modify-phases %standard-phases
> +           (add-before 'configure 'patch-build-flags
> +             ;; Fix for change to warnings in GCC 10+ causing
> +             ;; "error: argument 1 null where non-null expected [-
> Werror=nonnull]"
> +             (lambda _
> +               (substitute* "meson.build" (("-Werror=format=2")
> "")))))))

This warning can easily indicate a real bug, has it been reported
upstream?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 55617 <at> debbugs.gnu.org (full text, mbox):

From: Greg Hogan <code <at> greghogan.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 55617 <at> debbugs.gnu.org
Subject: Re: [bug#55617] [PATCH 0/2] gnu: rsync: Update to 3.2.4.
Date: Wed, 25 May 2022 14:30:46 -0400

[Message part 1 (text/plain, inline)]

On Wed, May 25, 2022 at 10:42 AM Maxime Devos <maximedevos <at> telenet.be> wrote:
>
> Greg Hogan schreef op di 24-05-2022 om 15:52 [-0400]:
> > +         (modify-phases %standard-phases
> > +           (add-before 'configure 'patch-build-flags
> > +             ;; Fix for change to warnings in GCC 10+ causing
> > +             ;; "error: argument 1 null where non-null expected [-
> > Werror=nonnull]"
> > +             (lambda _
> > +               (substitute* "meson.build" (("-Werror=format=2")
> > "")))))))
>
> This warning can easily indicate a real bug, has it been reported
> upstream?

It was reported upstream in 2017 but after the latest release. I have
removed that substitute from the attached, updated patchset since I
had overlooked that this change is not needed when building against
the latest commit.

> Greetings,
> Maxime.

[0001-gnu-rsync-Update-to-3.2.4.patch (text/x-patch, attachment)]

[0002-gnu-casync-Update-to-99559cd1.patch (text/x-patch, attachment)]

Message #14 received at 55617 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Greg Hogan <code <at> greghogan.com>
Cc: 55617 <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#55617: [PATCH 0/2] gnu: rsync: Update to 3.2.4.
Date: Mon, 30 May 2022 16:15:03 +0200

Hi,

Greg Hogan <code <at> greghogan.com> skribis:

> From ecaee327cfb0edcb663bb00d32a04a0da2d78ceb Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code <at> greghogan.com>
> Date: Tue, 3 May 2022 17:55:02 +0000
> Subject: [PATCH 1/2] gnu: rsync: Update to 3.2.4.
>
> * gnu/packages/rsync.scm (rsync): Update to 3.2.4.

[...]

> From 208b49b03614d6412447e01b06ca8026de6dd668 Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code <at> greghogan.com>
> Date: Tue, 3 May 2022 17:54:16 +0000
> Subject: [PATCH 2/2] gnu: casync: Update to 99559cd1.
>
> * gnu/packages/sync.scm (casync): Update to 99559cd1.
> [source]: Remove patch.
> [arguments]: Fix installation.
> [native-inputs]: Add python.
> [inputs]: Add eudev.
> * gnu/packages/patches/casync-renameat2-declaration.patch: Delete file.
> * gnu/local.mk: Remove it.

Applied, thanks!

Ludo’.

Message #19 received at 55617-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Greg Hogan <code <at> greghogan.com>
Cc: Maxime Devos <maximedevos <at> telenet.be>, 55617-done <at> debbugs.gnu.org
Subject: Re: bug#55617: [PATCH 0/2] gnu: rsync: Update to 3.2.4.
Date: Mon, 30 May 2022 16:15:30 +0200

Hi,

Greg Hogan <code <at> greghogan.com> skribis:

> From ecaee327cfb0edcb663bb00d32a04a0da2d78ceb Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code <at> greghogan.com>
> Date: Tue, 3 May 2022 17:55:02 +0000
> Subject: [PATCH 1/2] gnu: rsync: Update to 3.2.4.
>
> * gnu/packages/rsync.scm (rsync): Update to 3.2.4.

[...]

> From 208b49b03614d6412447e01b06ca8026de6dd668 Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code <at> greghogan.com>
> Date: Tue, 3 May 2022 17:54:16 +0000
> Subject: [PATCH 2/2] gnu: casync: Update to 99559cd1.
>
> * gnu/packages/sync.scm (casync): Update to 99559cd1.
> [source]: Remove patch.
> [arguments]: Fix installation.
> [native-inputs]: Add python.
> [inputs]: Add eudev.
> * gnu/packages/patches/casync-renameat2-declaration.patch: Delete file.
> * gnu/local.mk: Remove it.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.