GNU bug report logs - #55637
Add west requirements.txt dependencies

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55637 in the body.
You can then email your comments to 55637 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Peter Polidoro <peter <at> polidoro.io>
To: guix-patches <at> gnu.org
Subject: Add west requirements.txt dependencies
Date: Wed, 25 May 2022 12:43:42 -0400

Message #8 received at 55637 <at> debbugs.gnu.org (full text, mbox):

From: peter <at> polidoro.io
To: 55637 <at> debbugs.gnu.org
Cc: Peter Polidoro <peter <at> polidoro.io>
Subject: [PATCH] gnu: Add python-canopen.
Date: Wed, 25 May 2022 13:11:22 -0400

From: Peter Polidoro <peter <at> polidoro.io>

* gnu/packages/python-xyz.scm (python-canopen): New variable.
---
 gnu/packages/python-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 6ca759e2e2..35a2009f69 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -31743,3 +31743,24 @@ (define-public python-preshed
      "Simple but high performance Cython hash table mapping pre-randomized keys
 to void* values.")
     (license license:expat)))
+
+(define-public python-canopen
+  (package
+    (name "python-canopen")
+    (version "2.0.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "canopen" version))
+       (sha256
+        (base32 "1nb543wb37kj95v6bhh272lm5gkpi41q3pnsl1fxlyizm2gamj5w"))))
+    (build-system python-build-system)
+    (native-inputs (list python-packaging))
+    (propagated-inputs (list python-can))
+    (home-page "")
+    (synopsis "CANopen stack implementation")
+    (description "A Python implementation of the CANopen standard. The aim of
+the project is to support the most common parts of the CiA 301 standard in a
+simple Pythonic interface. It is mainly targeted for testing and automation
+tasks rather than a standard compliant master implementation.")
+    (license license:expat)))
-- 
2.36.0

Message #11 received at 55637 <at> debbugs.gnu.org (full text, mbox):

From: peter <at> polidoro.io
To: 55637 <at> debbugs.gnu.org
Cc: Peter Polidoro <peter <at> polidoro.io>
Subject: [PATCH] gnu: Add python-progress.
Date: Wed, 25 May 2022 13:33:16 -0400

From: Peter Polidoro <peter <at> polidoro.io>

* gnu/packages/python-xyz.scm (python-progress): New variable.
---
 gnu/packages/python-xyz.scm | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 35a2009f69..a9fbfcc2f4 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -31764,3 +31764,19 @@ (define-public python-canopen
 simple Pythonic interface. It is mainly targeted for testing and automation
 tasks rather than a standard compliant master implementation.")
     (license license:expat)))
+
+(define-public python-progress
+  (package
+    (name "python-progress")
+    (version "1.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "progress" version))
+       (sha256
+        (base32 "1k9lpb7lqr6mywpnqcz71y6qny54xlgprdp327za2gy0nnc6xj69"))))
+    (build-system python-build-system)
+    (home-page "http://github.com/verigak/progress/")
+    (synopsis "Progress reporting bars for Python")
+    (description "Progress reporting bars for Python")
+    (license license:isc)))
-- 
2.36.0

Message #14 received at 55637 <at> debbugs.gnu.org (full text, mbox):

From: peter <at> polidoro.io
To: 55637 <at> debbugs.gnu.org
Cc: Peter Polidoro <peter <at> polidoro.io>
Subject: [PATCH] gnu: Add python-pylink-square.
Date: Thu, 26 May 2022 14:55:42 -0400

From: Peter Polidoro <peter <at> polidoro.io>

* gnu/packages/embedded.scm (python-pylink-square): New variable.
---
 gnu/packages/embedded.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm
index 010f5b84d2..75675c2698 100644
--- a/gnu/packages/embedded.scm
+++ b/gnu/packages/embedded.scm
@@ -1699,3 +1699,34 @@ (define-public mbed-tools
 connected by USB, checkout Mbed projects and perform builds amongst other
 operations.")
     (license license:asl2.0)))
+
+(define-public python-pylink-square
+  (package
+    (name "python-pylink-square")
+    (version "0.12.0")
+    (source
+     ;; The tests suite appears to be incomplete in the PyPI archive.
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "http://www.github.com/Square/pylink")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0w0pi91gvaw9k2r267kpc1ryd74v19iq5ysn4j7pf4g2069gbgxf"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases (modify-phases %standard-phases
+                  (add-after 'unpack 'patch-setup
+                    (lambda _
+                      (substitute* "setup.py"
+                        (("mock == 2.0.0") "mock")))))))
+    (native-inputs (list python-mock))
+    (propagated-inputs (list python-future
+                             python-psutil
+                             python-six
+                             libjaylink))
+    (home-page "http://www.github.com/Square/pylink")
+    (synopsis "Python interface for SEGGER J-Link.")
+    (description "Python interface for SEGGER J-Link.")
+    (license license:asl2.0)))
-- 
2.36.0

Message #17 received at 55637 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: peter <at> polidoro.io
Cc: 55637 <at> debbugs.gnu.org
Subject: Re: [bug#55637] [PATCH] gnu: Add python-canopen.
Date: Fri, 27 May 2022 10:22:08 +0100

[Message part 1 (text/plain, inline)]

peter <at> polidoro.io writes:

> From: Peter Polidoro <peter <at> polidoro.io>
>
> * gnu/packages/python-xyz.scm (python-canopen): New variable.
> ---
>  gnu/packages/python-xyz.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 6ca759e2e2..35a2009f69 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -31743,3 +31743,24 @@ (define-public python-preshed
>       "Simple but high performance Cython hash table mapping pre-randomized keys
>  to void* values.")
>      (license license:expat)))
> +
> +(define-public python-canopen
> +  (package
> +    (name "python-canopen")
> +    (version "2.0.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "canopen" version))
> +       (sha256
> +        (base32 "1nb543wb37kj95v6bhh272lm5gkpi41q3pnsl1fxlyizm2gamj5w"))))
> +    (build-system python-build-system)
> +    (native-inputs (list python-packaging))
> +    (propagated-inputs (list python-can))
> +    (home-page "")
> +    (synopsis "CANopen stack implementation")
> +    (description "A Python implementation of the CANopen standard. The aim of
> +the project is to support the most common parts of the CiA 301 standard in a
> +simple Pythonic interface. It is mainly targeted for testing and automation
> +tasks rather than a standard compliant master implementation.")
> +    (license license:expat)))

The linter picks up a couple of issues:

gnu/packages/python-xyz.scm:31761:17: python-canopen <at> 2.0.0: sentences in description should be followed by two spaces; possible infractions at 47, 162
gnu/packages/python-xyz.scm:31759:15: python-canopen <at> 2.0.0: invalid home page URL: ""

Plus, I'd avoid adding packages to the end of modules. If everyone does
this, it means lots of git conflicts. Instead, try and slot the new
package definition in somewhere close to related packages, or
alphabetically, or randomly even if neither of those approaches apply.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 55637 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: peter <at> polidoro.io
Cc: 55637 <at> debbugs.gnu.org
Subject: Re: [bug#55637] [PATCH] gnu: Add python-progress.
Date: Fri, 27 May 2022 10:24:54 +0100

[Message part 1 (text/plain, inline)]

peter <at> polidoro.io writes:

> From: Peter Polidoro <peter <at> polidoro.io>
>
> * gnu/packages/python-xyz.scm (python-progress): New variable.
> ---
>  gnu/packages/python-xyz.scm | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 35a2009f69..a9fbfcc2f4 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -31764,3 +31764,19 @@ (define-public python-canopen
>  simple Pythonic interface. It is mainly targeted for testing and automation
>  tasks rather than a standard compliant master implementation.")
>      (license license:expat)))
> +
> +(define-public python-progress
> +  (package
> +    (name "python-progress")
> +    (version "1.6")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "progress" version))
> +       (sha256
> +        (base32 "1k9lpb7lqr6mywpnqcz71y6qny54xlgprdp327za2gy0nnc6xj69"))))
> +    (build-system python-build-system)
> +    (home-page "http://github.com/verigak/progress/")
> +    (synopsis "Progress reporting bars for Python")
> +    (description "Progress reporting bars for Python")
> +    (license license:isc)))

The description looks like it could be improved here, plus same comment
about not adding new package definitions to the bottom of files.

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 55637 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: peter <at> polidoro.io
Cc: 55637 <at> debbugs.gnu.org
Subject: Re: [bug#55637] [PATCH] gnu: Add python-pylink-square.
Date: Fri, 27 May 2022 10:26:07 +0100

[Message part 1 (text/plain, inline)]

peter <at> polidoro.io writes:

> From: Peter Polidoro <peter <at> polidoro.io>
>
> * gnu/packages/embedded.scm (python-pylink-square): New variable.
> ---
>  gnu/packages/embedded.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm
> index 010f5b84d2..75675c2698 100644
> --- a/gnu/packages/embedded.scm
> +++ b/gnu/packages/embedded.scm
> @@ -1699,3 +1699,34 @@ (define-public mbed-tools
>  connected by USB, checkout Mbed projects and perform builds amongst other
>  operations.")
>      (license license:asl2.0)))
> +
> +(define-public python-pylink-square
> +  (package
> +    (name "python-pylink-square")
> +    (version "0.12.0")
> +    (source
> +     ;; The tests suite appears to be incomplete in the PyPI archive.
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "http://www.github.com/Square/pylink")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "0w0pi91gvaw9k2r267kpc1ryd74v19iq5ysn4j7pf4g2069gbgxf"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'patch-setup
> +                    (lambda _
> +                      (substitute* "setup.py"
> +                        (("mock == 2.0.0") "mock")))))))
> +    (native-inputs (list python-mock))
> +    (propagated-inputs (list python-future
> +                             python-psutil
> +                             python-six
> +                             libjaylink))
> +    (home-page "http://www.github.com/Square/pylink")
> +    (synopsis "Python interface for SEGGER J-Link.")
> +    (description "Python interface for SEGGER J-Link.")
> +    (license license:asl2.0)))

The description here also looks like it could be improved a bit.

Are you able to send some updated patches?

Also, when sending a few related patches, it's helpful if you get git
send-email to send them as a series, so something like:

  git send-email HEAD~3

To send patches for the last 3 commits.

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 55637 <at> debbugs.gnu.org (full text, mbox):

From: Peter Polidoro <peter <at> polidoro.io>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 55637 <at> debbugs.gnu.org
Subject: Re: [bug#55637] [PATCH] gnu: Add python-pylink-square.
Date: Fri, 27 May 2022 10:50:41 -0400

Christopher Baines <mail <at> cbaines.net> writes:

> The description here also looks like it could be improved a bit.
>
> Are you able to send some updated patches?
>
> Also, when sending a few related patches, it's helpful if you 
> get git
> send-email to send them as a series, so something like:
>
>   git send-email HEAD~3
>
> To send patches for the last 3 commits.

Thank you for your great suggestions, I will send updated patches 
as soon as I get a chance.

I misnamed this patch series. I thought, at first, that I was 
adding more dependencies to the 'west' package, but that is not 
quite correct.

West is a Python tool that can help build Zephyr RTOS projects. 
West is only optional for building Zephyr RTOS projects, though, 
and much of its functionality could perhaps be replaced by Guix. 
West provides a multiple repository management system, inspired by 
Google's Repo tool and Git submodules. I think it would be much 
more elegant to use Guix for managing the multiple repositories 
and their dependencies instead of West. I do not yet know enough 
about how the Zephyr ecosystem works, nor am I yet a good enough 
Guix package writer, to figure out how to replace totally replace 
West with Guix.

An intermediate step might be for me to create a simple Zephyr 
package that installs the dependencies needed to build Zephyr 
projects. Normally these dependencies are installed using apt 
packages and Python requirements.txt files, as you can see in this 
Zephyr getting started guide:

https://docs.zephyrproject.org/latest/develop/getting_started/index.html

I am not yet sure how many dependencies I will need to write Guix 
packages for and how long it will take. Should I just keep 
emailing patches to this debbug number until I get to the final 
zephyr package patch or is that annoying? Would you prefer I wait 
until I have all of the packages figured out and then send them 
all as one big patch series using git send-email as you suggested?

On a side note, do you happen to know how to setup git send-email 
to work with pass, the standard unix password manager, instead of 
the normal .git-credentials file? I would prefer not having my 
password stored in a plain text file in my home directory. I tried 
following this guide, but could not get it to work:

https://ryanlue.com/posts/2019-04-19-git-credential-with-pass

Thank you for your time!

Message #29 received at 55637 <at> debbugs.gnu.org (full text, mbox):

From: peter <at> polidoro.io
To: 55637 <at> debbugs.gnu.org
Cc: Peter Polidoro <peter <at> polidoro.io>
Subject: [PATCH] gnu: Add python-canopen.
Date: Fri, 27 May 2022 14:37:22 -0400

From: Peter Polidoro <peter <at> polidoro.io>

* gnu/packages/python-xyz.scm (python-canopen): New variable.
---
 gnu/packages/python-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 44eeb0d7fe..3ae14765dc 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -2248,6 +2248,27 @@ (define-public python-can
 sending and receiving messages on a CAN bus.")
     (license license:lgpl3+)))
 
+(define-public python-canopen
+  (package
+    (name "python-canopen")
+    (version "2.0.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "canopen" version))
+       (sha256
+        (base32 "1nb543wb37kj95v6bhh272lm5gkpi41q3pnsl1fxlyizm2gamj5w"))))
+    (build-system python-build-system)
+    (native-inputs (list python-packaging))
+    (propagated-inputs (list python-can))
+    (home-page "https://github.com/christiansandberg/canopen")
+    (synopsis "CANopen stack implementation")
+    (description "A Python implementation of the CANopen standard.  The aim of
+the project is to support the most common parts of the CiA 301 standard in a
+simple Pythonic interface.  It is mainly targeted for testing and automation
+tasks rather than a standard compliant master implementation.")
+    (license license:expat)))
+
 (define-public python-caniusepython3
   (package
     (name "python-caniusepython3")
-- 
2.36.0

Message #32 received at 55637 <at> debbugs.gnu.org (full text, mbox):

From: peter <at> polidoro.io
To: 55637 <at> debbugs.gnu.org
Cc: Peter Polidoro <peter <at> polidoro.io>
Subject: [PATCH] gnu: Add python-progress.
Date: Fri, 27 May 2022 14:57:26 -0400

From: Peter Polidoro <peter <at> polidoro.io>

* gnu/packages/python-xyz.scm (python-progress): New variable.
---
 gnu/packages/python-xyz.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 44eeb0d7fe..d226ff94b5 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -15226,6 +15226,25 @@ (define-public python-promise
      "Promises/A+ implementation for Python")
     (license license:expat)))
 
+(define-public python-progress
+  (package
+    (name "python-progress")
+    (version "1.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "progress" version))
+       (sha256
+        (base32 "1k9lpb7lqr6mywpnqcz71y6qny54xlgprdp327za2gy0nnc6xj69"))))
+    (build-system python-build-system)
+    (home-page "http://github.com/verigak/progress/")
+    (synopsis "Progress reporting bars for Python")
+    (description "This Python package provides progress reporting for visual
+of progress of long running operations.  There are multiple choices of
+progress bars and spinners, with customizable options, such as width, fill
+character, and suffix.")
+    (license license:isc)))
+
 (define-public python-progressbar2
   (package
     (name "python-progressbar2")
-- 
2.36.0

Message #35 received at 55637 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: peter <at> polidoro.io
Cc: 55637 <at> debbugs.gnu.org
Subject: Re: bug#55637: Add west requirements.txt dependencies
Date: Mon, 06 Jun 2022 22:19:39 +0200

[Message part 1 (text/plain, inline)]

Hi,

peter <at> polidoro.io skribis:

> From: Peter Polidoro <peter <at> polidoro.io>
>
> * gnu/packages/python-xyz.scm (python-canopen): New variable.

Applied with the changes below (see
<https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html>).

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 312a365fb7..56552b12c5 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -2086,9 +2086,12 @@ (define-public python-canopen
     (propagated-inputs (list python-can))
     (home-page "https://github.com/christiansandberg/canopen")
     (synopsis "CANopen stack implementation")
-    (description "A Python implementation of the CANopen standard.  The aim of
-the project is to support the most common parts of the CiA 301 standard in a
-simple Pythonic interface.  It is mainly targeted for testing and automation
+    (description
+     "This package provides a Python implementation of the
+@uref{https://www.can-cia.org/canopen/,CANopen standard} for
+@acronym{CAN, controller-area networks}.  The aim of the project is to
+support the most common parts of the CiA 301 standard in a simple
+Pythonic interface.  It is mainly targeted for testing and automation
 tasks rather than a standard compliant master implementation.")
     (license license:expat)))
 

Message #40 received at 55637-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: peter <at> polidoro.io
Cc: 55637-done <at> debbugs.gnu.org
Subject: Re: bug#55637: Add west requirements.txt dependencies
Date: Mon, 06 Jun 2022 22:21:47 +0200

peter <at> polidoro.io skribis:

> From: Peter Polidoro <peter <at> polidoro.io>
>
> * gnu/packages/python-xyz.scm (python-progress): New variable.

Applied, thanks!

Please open a new issue if there are followup patches.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.