GNU bug report logs - #55675
[PATCH 1/2] gnu: emacs-elm-mode: Update to 0.21.0-1.1e27768.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55675 in the body.
You can then email your comments to 55675 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Erik Šabič <erik.sab <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/2] gnu: emacs-elm-mode: Update to 0.21.0-1.1e27768.
Date: Fri, 27 May 2022 14:52:41 +0200

* gnu/packages/emacs-xyz.scm (emacs-elm-mode): Update to 0.21.0-1.1e27768.
---
 gnu/packages/emacs-xyz.scm | 43 +++++++++++++++++++-------------------
 1 file changed, 22 insertions(+), 21 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f7fb6aac35..f62c733fb5 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -19692,26 +19692,27 @@ (define-public emacs-ibuffer-vc
     (license license:gpl3+)))
 
 (define-public emacs-elm-mode
-  (package
-    (name "emacs-elm-mode")
-    (version "0.21.0")
-    (source
-     (origin
-       (method git-fetch)
-       (uri
-        (git-reference
-         (url "https://github.com/jcollard/elm-mode")
-         (commit (string-append "v" version))))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32 "0iwk4fmw8hq3ry4ky1zc7lgl4cpbnrjyk74c2xzddfspi3ks41fd"))))
-    (propagated-inputs
-     (list emacs-dash emacs-f emacs-reformatter emacs-s))
-    (build-system emacs-build-system)
-    (home-page "https://github.com/jcollard/elm-mode")
-    (synopsis "Emacs major mode for editing Elm source code")
-    (description
-     "This package provides a major mode for editing Elm source code, and
+  ;; Version tag 0.21.0 was made Jan 14 2020. It doesn't work with Emacs 28
+  ;; due to missing, now-mandatory "when" arg for obsolete function alias.
+  (let ((commit "1e277684d8a6681a2410cce2dd589ee30a998369"))
+    (package
+      (name "emacs-elm-mode")
+      (version (git-version "0.21.0" "1" commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/jcollard/elm-mode")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1gnr61ibzcznfqy5f8capmbz75rcfikwy106rjdmp45qz2jwp4di"))))
+      (propagated-inputs (list emacs-f emacs-reformatter emacs-s))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/jcollard/elm-mode")
+      (synopsis "Emacs major mode for editing Elm source code")
+      (description
+       "This package provides a major mode for editing Elm source code, and
 working with common core and third-party Elm tools.  Its features are:
 
 @itemize
@@ -19725,7 +19726,7 @@ (define-public emacs-elm-mode
 @item Integration with elm-format
 @item Integration with elm-test
 @end itemize")
-    (license license:gpl3+)))
+      (license license:gpl3+))))
 
 (define-public emacs-helm-mode-manager
   (package

base-commit: d37c7f7ad4134cc15d1558eb6c0bc4c59a0db1af
-- 
2.36.1

Message #8 received at 55675 <at> debbugs.gnu.org (full text, mbox):

From: Erik Šabič <erik.sab <at> gmail.com>
To: 55675 <at> debbugs.gnu.org
Subject: Question
Date: Fri, 27 May 2022 15:21:52 +0200

[Message part 1 (text/plain, inline)]

I forgot to mention the removal of emacs-dash from propagated-inputs.

These are two unrelated updates in a patchset. I didn't know git send-email
would do this automatically. Is this okay? Or should I have submitted them
separately?

Thank you!

[Message part 2 (text/html, inline)]

Message #11 received at 55675 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Erik Šabič <erik.sab <at> gmail.com>
Cc: 55675 <at> debbugs.gnu.org
Subject: Re: [bug#55674] [PATCH 2/2] gnu: emacs-helpful: Update to 0.19.
Date: Fri, 27 May 2022 15:48:16 +0200

[Message part 1 (text/plain, inline)]

[Please keep 55675 <at> debbugs.gnu.org in CC]

Erik Šabič schreef op vr 27-05-2022 om 15:32 [+0200]:
> Well it fails on a test defined like this:
> (ert-deftest helpful--docstring ()
>   "Basic docstring fetching."
>   (should
>    (equal
>     (helpful--docstring #'test-foo t)
>     "Docstring here.")))
> 
> And fails like so:
> ...............s...s..Test helpful--docstring-advice backtrace:


> 
> Test helpful--docstring-advice condition:
> 
>     (ert-test-failed
>      ((should
>        (equal
>         (helpful--docstring ... t)
>         "Docstring here too."))
>       :form
>       (equal "Docstring here too.\n\nThis function has :around
> advice: `ad-Advice-test-foo-advised'." "Docstring here too.")
>       :value nil :explanation
>       (arrays-of-different-length 84 19 "Docstring here too.\n\nThis
> function has :around advice: `ad-Advice-test-foo-advised'."
> "Docstring here too." first-mismatch-at 19)))
> 
> F............................................................s......

Looks like a bug.

> I don't know anything about emacs-ert. And I wasn't able to
> figure out if it works for the upstream author.
>
> WDYT?

I don't know if it fails for the upstream author, but I don't think
that's relevant to Guix.  More relevant I think, is that this bug
appears in Guix, so it can cause problems for Guix users, so some
fixing might be necessary.

I don't know much about Emacs though, so you might need to contact
upstream about the bug.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 55675 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Erik Šabič <erik.sab <at> gmail.com>, 
 55675 <at> debbugs.gnu.org
Subject: Re: [bug#55675] Question
Date: Fri, 27 May 2022 15:49:46 +0200

[Message part 1 (text/plain, inline)]

Erik Šabič schreef op vr 27-05-2022 om 15:21 [+0200]:
> These are two unrelated updates in a patchset. I didn't know git
> send-email would do this automatically.

"git send-email" just sends the commits you made, it is up to the user
to split the commits appropriately, it doesn't do any cleanups.

> Is this okay? Or should I have submitted them

Depends, is it actually an unrelated change?  Why is emacs-dash
removed?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 55675 <at> debbugs.gnu.org (full text, mbox):

From: Erik Šabič <erik.sab <at> gmail.com>
To: 55675 <at> debbugs.gnu.org
Subject: emacs-dash
Date: Fri, 27 May 2022 16:27:28 +0200

[Message part 1 (text/plain, inline)]

Elm-mode dropped the usage of dash.el in favor of seq.el

Merged upstream with commit:
70734a1eed6f008135c197e115ca5f197e47ee0b

Author:     Steve Purcell <steve <at> sanityinc.com>
AuthorDate: Mon Feb 21 05:57:33 2022 +1300

[Message part 2 (text/html, inline)]

Message #22 received at 55675-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Erik Šabič <erik.sab <at> gmail.com>
Cc: 55675-done <at> debbugs.gnu.org
Subject: Re: bug#55675: [PATCH 1/2] gnu: emacs-elm-mode: Update to
 0.21.0-1.1e27768.
Date: Sun, 05 Jun 2022 23:34:37 +0200

Hi Erik,

Erik Šabič <erik.sab <at> gmail.com> skribis:

> * gnu/packages/emacs-xyz.scm (emacs-elm-mode): Update to 0.21.0-1.1e27768.

It has been updated to 0.22 in the meantime.

Thank you,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.