GNU bug report logs - #55678
29.0.50; C-c C-w and errors in major-mode-hook

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55678 in the body.
You can then email your comments to 55678 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; C-c C-w and errors in major-mode-hook
Date: Fri, 27 May 2022 20:21:56 +0530

I have paredit-mode in emacs-lisp-mode-hook, and when the buffer has
mismatched parens [(check-paren)=nil], it signals an error.  This makes
`diff-add-log-current-entries' not add any of the entries.

For a simple reproducer,

    1. emacs -Q
   
    2. M-: (add-hook 'emacs-lisp-mode-hook (defun test () (error "test error")))

    3. Create a temporary git repo, commit an initial change by adding
       an elisp file.

    4. Add some more text.  C-x v v.

    5. C-c C-w.  Note "test error" in the echo-area.

I narrowed down the problem to `diff-add-log-current-entries' and I
*think* the problem is in goto-otherbuf function but when I added an
ignore-error around (funcall (buffer-local-value 'major-mode buf)), I
noticed no change.  :-/

I can work around my specific problem but it would be nice if this was
handled in a generic way.

In GNU Emacs 29.0.50 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw scroll bars)
 of 2022-05-23 built on astatine
Repository revision: 9e088656c48b894f54bbc9265dbe37d2164b3d5f
Repository branch: imenu-xref
Windowing system distributor 'The X.Org Foundation', version 11.0.12013000
System Description: NixOS 21.11 (Porcupine)

Configured using:
 'configure --with-sqlite3 --with-x-toolkit=lucid --with-json
 --without-gsettings --without-native-compilation --with-x
 --without-libsystemd --with-modules CC=gcc PKG_CONFIG=pkg-config
 PKG_CONFIG_PATH=/nix/store/5k90yvmpm21l5ixdrmq6ws5w80px81zv-ncurses-6.2-dev/lib/pkgconfig:/nix/store/bhipd7yvydnd9kipm8mipcx2wz11n0m3-libxml2-2.9.12-dev/lib/pkgconfig:/nix/store/qvig6hmlrlzkf9xycaxgf9q9z2n860fz-zlib-1.2.11-dev/lib/pkgconfig:/nix/store/yzd7fygl42rk371qgizj7wvjb2w8xv0j-gnutls-3.7.2-dev/lib/pkgconfig:/nix/store/2bzryb38hp400syhb9spf342izwyk352-nettle-3.7.3-dev/lib/pkgconfig:/nix/store/zj2j583xdbdbgdiywsf70nadwmmgipp0-gmp-6.2.1-dev/lib/pkgconfig:/nix/store/cxgxk7dpnxqyifc26c61k6jpm3y1p614-alsa-lib-1.2.5.1-dev/lib/pkgconfig:/nix/store/l3x89d9m4c7gfmpzx85m6bxy8ba00dik-acl-2.3.1-dev/lib/pkgconfig:/nix/store/lmdf37gyl6qgppcjad844plvwdlynhpr-jansson-2.13.1/lib/pkgconfig:/nix/store/3isra62c8fbpq65ssnx352809z0amy4r-sqlite-3.36.0-dev/lib/pkgconfig:/nix/store/qrbyjc5d4l3fv5ah0jbc23z8c3sfrch0-harfbuzz-3.0.0-dev/lib/pkgconfig:/nix/store/b1kham6y11a48fns6pk00wsp3r9fqh8v-graphite2-1.3.14/lib/pkgconfig:/nix/store/6v2iszxdg0wg6xbgsqp3ffl6ig03khqb-dbus-1.12.20-dev/lib/pkgconfig:/nix/store/rwr4h8lgbkcw88bs3hni30bmfl2x026c-expat-2.4.1-dev/lib/pkgconfig:/nix/store/399gf40rn1fy6siiislhczrhanpllkk3-libXpm-3.5.13-dev/lib/pkgconfig:/nix/store/p7w05daijr9pjl0qjb5khsj366jsr61a-libX11-1.7.2-dev/lib/pkgconfig:/nix/store/02c1pc5gyl1hbsjlsls9l0l5z8n3fv54-xorgproto-2021.5/share/pkgconfig:/nix/store/6yx5h8aipxlp7k1syd1yfa04yplkirg8-libxcb-1.14-dev/lib/pkgconfig:/nix/store/swsbajyr5f73hd9ymsszhbwx3gqk9c3y-libXaw-1.0.14-dev/lib/pkgconfig:/nix/store/bbsk8mw8c98i2cv91q5bv1p1li8mwkjr-libXmu-1.1.3-dev/lib/pkgconfig:/nix/store/zr0k3yvv3yi5biyxrsyh9axd2z9ra115-libXt-1.2.1-dev/lib/pkgconfig:/nix/store/4p3js3kb4bg9kjwg5q87sm0gg41s8vd8-libSM-1.2.3-dev/lib/pkgconfig:/nix/store/abca9avlx51wapyr57p7p7sfkcvkr45y-libICE-1.0.10-dev/lib/pkgconfig:/nix/store/zkd7dwp7l8fcvy3h8lxxklrg0f7biy9x-libpng-apng-1.6.37-dev/lib/pkgconfig:/nix/store/xxkjk5ggh6prmh1lnmba4glc5ba824l5-libjpeg-turbo-2.1.0-dev/lib/pkgconfig:/nix/store/687qmmzbclh8z10i8b1ljlfs2s8qs81d-libtiff-4.3.0-dev/lib/pkgconfig:/nix/store/2aaxgx9vhi315wbgj2ga3zvzpg85y0z7-xz-5.2.5-dev/lib/pkgconfig:/nix/store/znb9fyipj2zd25ij7lbk019c370xg0vc-libXft-2.3.4-dev/lib/pkgconfig:/nix/store/razd37j6h3jm5jyqbqnarzzwxff9x2cz-libXrender-0.9.10-dev/lib/pkgconfig:/nix/store/ni0vwqhfcv5c12xiqrvj4ab30mrigvlr-freetype-2.11.0-dev/lib/pkgconfig:/nix/store/hrrqv6dkjhhvmhwbal8vqvs223kmajyq-bzip2-1.0.6.0.2-dev/lib/pkgconfig:/nix/store/l8ixkdjjbq3ys34538pfbma67awz983y-fontconfig-2.13.94-dev/lib/pkgconfig:/nix/store/qzhqyy9nxvricxlzw8hwvxjjj63d234a-cairo-1.16.0-dev/lib/pkgconfig:/nix/store/9y3ngjj6y1zd4x1zjr2jz9wn839qp1rk-pixman-0.38.4/lib/pkgconfig:/nix/store/k7iasqqnn0yy02kmzjjmwmhxxcykk9la-libXext-1.3.4-dev/lib/pkgconfig:/nix/store/q21wvil6q0xrkrfqc92nvvin099k4wrc-libXau-1.0.9-dev/lib/pkgconfig:/nix/store/mfvidpc3vwminp5brcp50rhxxkxdkk0m-xcb-util-0.4.0-dev/lib/pkgconfig:/nix/store/abgmwq47jf084fb6j78caxwrx37vvf20-glib-2.70.1-dev/lib/pkgconfig:/nix/store/pqvrbmm1lmb3b57vrlafhvc1svfa9aa3-libffi-3.4.2-dev/lib/pkgconfig:/nix/store/rvyacf3qskrj6zbxf0kvm8h1szphx0xl-libGL-1.3.4-dev/lib/pkgconfig:/nix/store/hc3ggwm6f6xr75sm5kkyg8gksalb0byr-libglvnd-1.3.4-dev/lib/pkgconfig:/nix/store/z9x1hmnipnv1apz5xg3iwm6ziygbxyxp-librsvg-2.52.3-dev/lib/pkgconfig:/nix/store/0qxyb17izckxg55q88vmp2l43sgaib62-gdk-pixbuf-2.42.6-dev/lib/pkgconfig:/nix/store/njkv4xknb9aa2l9897jv7wwlyhif7vs8-m17n-lib-1.8.0/lib/pkgconfig:/nix/store/78avypy02zd274715krlri2zrj11kidn-libotf-0.9.16-dev/lib/pkgconfig:/nix/store/2689dl5i07ir0i08mqfayk82a15q0b75-libXi-1.8-dev/lib/pkgconfig:/nix/store/aqwsbsg1liim17cvk7dsm1fawk6szpas-libXfixes-6.0.0-dev/lib/pkgconfig:/nix/store/8w9fh8fgza2vclh09admvjb7w0jgx463-libwebp-1.1.0/lib/pkgconfig
 CXX=g++'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM HARFBUZZ JPEG JSON
LIBOTF LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP
SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2
XPM LUCID ZLIB

Important settings:
  value of $LC_MONETARY: ta_IN.UTF-8
  value of $LC_NUMERIC: ta_IN.UTF-8
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Group

Minor modes in effect:
  shell-dirtrack-mode: t
  recentf-mode: t
  gnus-undo-mode: t
  eros-mode: t
  pdf-occur-global-minor-mode: t
  minibuffer-depth-indicate-mode: t
  repeat-mode: t
  display-time-mode: t
  display-battery-mode: t
  winner-mode: t
  straight-use-package-mode: t
  straight-package-neutering-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tab-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  undelete-frame-mode: t
  buffer-read-only: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow eudc-capf eudc eudc-vars emacsbug find-dired files-x grep vc-dir
cus-start edebug debug backtrace descr-text reposition skeleton
shell-command+ help-at-pt ffap proced pcmpl-unix info-look expand-region
text-mode-expansions cc-mode-expansions the-org-mode-expansions
er-basic-expansions expand-region-core expand-region-custom lua-mode
vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs dired-aux
gnus-dired term/st term/xterm xterm flymake-shellcheck sh-script smie
autoload view ement-taxy svg-lib emacs-news-mode tabify man ob-C cc-mode
cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars
cc-defs ob-shell ob-racket async ob-async cdlatex texmathp ol-eww
ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view
ol-bibtex ol-bbdb ol-w3m ol-doi org-link-doi org-tempo tempo org-id
org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro
org-footnote org-src ob-comint org-pcomplete org-list org-faces
org-entities org-version ob-emacs-lisp ob-core ob-eval org-table
oc-basic bibtex ol org-keys oc org-compat org-macs org-loaddefs
cal-islam holidays hol-loaddefs cal-move timezone display-line-numbers
ement-room-list ement taxy-magit-section taxy ement-notify notifications
ement-room ewoc ement-api ement-structs ement-macros plz magit-section
dash dns ts whitespace misearch multi-isearch thai-util thai-word
url-http url-gw url-cache url-auth eww xdg url-queue mm-url log-edit
add-log pulse shell pcomplete time-stamp dabbrev reveal recentf
tree-widget face-remap noutline outline vc-git bug-reference refill
executable vc-backup log-view pcvs-util vc vc-dispatcher ind-util
shortdoc cl-print help-fns radix-tree flyspell ispell goto-addr
ecomplete smerge-mode diff diff-mode flow-fill gnus-fun mule-util sort
gnus-cite shr-color color mm-archive mail-extr textsec uni-scripts
idna-mapping ucs-normalize uni-confusable textsec-check gnus-async
gnus-bcklg qp gnus-ml network-stream nsm cursor-sensor nndraft nnmh
nnfolder nnmaildir nnagent nnml nnnil gnus-agent gnus-srvr gnus-score
score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime
smime gnutls dig nntp gnus-cache gnus-sum shr pixel-fill kinsoku
url-file url-dired svg dom gnus-group gnus-undo gnus-start gnus-dbus
gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time iso8601
gnus-spec gnus-int gnus-range message sendmail yank-media rmc puny
rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies
mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev
gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range
mm-util mail-prsvr server paredit edmacro kmacro eros time-date checkdoc
lisp-mnt flymake-proc flymake warnings thingatpt hl-todo
wordel-autoloads sokoban-autoloads ement-autoloads ts-autoloads
svg-lib-autoloads taxy-magit-section-autoloads taxy-autoloads
plz-autoloads nov-autoloads esxml-autoloads kv-autoloads
transmission-autoloads lua-mode-autoloads nix-mode-autoloads
magit-section-autoloads dash-autoloads racket-mode-autoloads
eros-autoloads flymake-shellcheck-autoloads writegood-mode-autoloads
siege-mode-autoloads paredit-autoloads puni-autoloads
expand-region-autoloads filladapt-autoloads compose quail
scroll-other-window org-pdftools-autoloads org-noter-autoloads
change-env-autoloads math-delimiters-autoloads doct-autoloads
ob-async-autoloads async-autoloads emacs-ob-racket-autoloads
valign-autoloads org-starless-autoloads cdlatex-autoloads
auctex-autoloads tex-site easy-mmode pdf-occur ibuf-ext ibuffer
ibuffer-loaddefs tablist advice tablist-filter semantic/wisent/comp
semantic/wisent semantic/wisent/wisent semantic/util-modes semantic/util
semantic semantic/tag semantic/lex semantic/fw mode-local find-func
cedet pdf-isearch let-alist pdf-misc imenu xref project pdf-tools
package browse-url url url-proxy url-privacy url-expand url-methods
url-history url-cookie url-domsuf url-util mailcap url-handlers
url-parse auth-source eieio eieio-core eieio-loaddefs json map url-vars
compile comint ansi-color cus-edit wid-edit pdf-view password-cache
jka-compr pdf-cache pdf-info tq pdf-util pdf-macs image-mode dired-x
dired dired-loaddefs exif pdf-tools-autoloads tablist-autoloads derived
mb-depth cus-load repeat visual-fill-autoloads olivetti-autoloads
hl-todo-autoloads time format-spec battery dbus filenotify xml
disp-table lacarte-autoloads shell-command-plus-autoloads winner avy
ring avy-autoloads vc-backup-autoloads icalendar diary-lib
diary-loaddefs cal-menu calendar cal-loaddefs rx filecache
flymake-grammarly-autoloads grammarly-autoloads websocket-autoloads
finder-inf request-autoloads s-autoloads chemtable-autoloads
molar-mass-autoloads saveplace-pdf-view saveplace bookmark
text-property-search pp saveplace-pdf-view-autoloads pcase
straight-autoloads info cl-seq cl-extra help-mode seq byte-opt straight
subr-x cl-macs gv cl-loaddefs cl-lib bytecomp byte-compile cconv
vz-nh-theme iso-transl tooltip eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice simple cl-generic philippine cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop
case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs faces cus-face macroexp files window
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget keymap hashtable-print-readable backquote threads dbusbind
inotify dynamic-setting font-render-setting cairo x-toolkit xinput2 x
multi-tty make-network-process emacs)

Memory information:
((conses 16 1736372 212992)
 (symbols 48 58982 78)
 (strings 32 349829 30200)
 (string-bytes 1 10809395)
 (vectors 16 149464)
 (vector-slots 8 3302695 190323)
 (floats 8 1390 1788)
 (intervals 56 159319 6836)
 (buffers 992 128))

Message #8 received at 55678 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 55678 <at> debbugs.gnu.org
Subject: Re: bug#55678: 29.0.50; C-c C-w and errors in major-mode-hook
Date: Sat, 28 May 2022 12:52:58 +0200

Visuwesh <visuweshm <at> gmail.com> writes:

> I have paredit-mode in emacs-lisp-mode-hook, and when the buffer has
> mismatched parens [(check-paren)=nil], it signals an error.  This makes
> `diff-add-log-current-entries' not add any of the entries.
>
> For a simple reproducer,
>
>     1. emacs -Q
>
>     2. M-: (add-hook 'emacs-lisp-mode-hook (defun test () (error "test error")))
>
>     3. Create a temporary git repo, commit an initial change by adding
>        an elisp file.
>
>     4. Add some more text.  C-x v v.
>
>     5. C-c C-w.  Note "test error" in the echo-area.
>
> I narrowed down the problem to `diff-add-log-current-entries' and I
> *think* the problem is in goto-otherbuf function but when I added an
> ignore-error around (funcall (buffer-local-value 'major-mode buf)), I
> noticed no change.  :-/

Isn't the problem here that paredit-mode signals an error when being
switched on?  Modes aren't supposed to do that.

For reference, here's the backtrace in the test case:

Debugger entered--Lisp error: (error "test error")
  signal(error ("test error"))
  error("test error")
  test()
  run-hooks(change-major-mode-after-body-hook prog-mode-hook lisp-data-mode-hook emacs-lisp-mode-hook)
  apply(run-hooks (change-major-mode-after-body-hook prog-mode-hook lisp-data-mode-hook emacs-lisp-mode-hook))
  run-mode-hooks(emacs-lisp-mode-hook)
  emacs-lisp-mode()
  #f(compiled-function () #<bytecode 0x1cc9cff9c51917ea>)()
  #f(compiled-function (&optional get-current) #<bytecode 0xba06c773444f87>)()
  diff-add-log-current-defuns()
  log-edit-generate-changelog-from-diff()
  funcall-interactively(log-edit-generate-changelog-from-diff)
  call-interactively(log-edit-generate-changelog-from-diff nil nil)
  command-execute(log-edit-generate-changelog-from-diff)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 55678 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 55678 <at> debbugs.gnu.org
Subject: Re: bug#55678: 29.0.50; C-c C-w and errors in major-mode-hook
Date: Sat, 28 May 2022 16:44:06 +0530

[சனி மே 28, 2022] Lars Ingebrigtsen wrote:

> Visuwesh <visuweshm <at> gmail.com> writes:
>
>> I have paredit-mode in emacs-lisp-mode-hook, and when the buffer has
>> mismatched parens [(check-paren)=nil], it signals an error.  This makes
>> `diff-add-log-current-entries' not add any of the entries.
>>
>> [...]
>> I narrowed down the problem to `diff-add-log-current-entries' and I
>> *think* the problem is in goto-otherbuf function but when I added an
>> ignore-error around (funcall (buffer-local-value 'major-mode buf)), I
>> noticed no change.  :-/
>
> Isn't the problem here that paredit-mode signals an error when being
> switched on?  Modes aren't supposed to do that.
>

If that is indeed the norm, then I can go complain elsewhere I guess.

> For reference, here's the backtrace in the test case:
> [...]

Message #14 received at 55678 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 55678 <at> debbugs.gnu.org
Subject: Re: bug#55678: 29.0.50; C-c C-w and errors in major-mode-hook
Date: Sat, 28 May 2022 18:46:18 +0200

Visuwesh <visuweshm <at> gmail.com> writes:

> If that is indeed the norm, then I can go complain elsewhere I guess.

For the record, I'm unable to reproduce any problems if I say

(add-hook 'emacs-lisp-mode-hook 'paredit-mode)

and then otherwise follow your recipe.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 55678 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 55678 <at> debbugs.gnu.org
Subject: Re: bug#55678: 29.0.50; C-c C-w and errors in major-mode-hook
Date: Sat, 28 May 2022 22:35:13 +0530

[சனி மே 28, 2022] Lars Ingebrigtsen wrote:

> Visuwesh <visuweshm <at> gmail.com> writes:
>
>> If that is indeed the norm, then I can go complain elsewhere I guess.
>
> For the record, I'm unable to reproduce any problems if I say
>
> (add-hook 'emacs-lisp-mode-hook 'paredit-mode)
>
> and then otherwise follow your recipe.

That's because paredit-mode only signals an error if there's a paren or
quote mismatch---whenever `check-parens' errors.  paredit-mode signals
an error for the following chunk for me,

;;; Xref backend
;;;

;;;###autoload
(defun imenu-xref-backend ()
  (unless imenu--index-alist
    (imenu--make-index-alist))
  (when (and imenu--index-alist
             (not (progn (require 'etags) tags-table-files)))
    'imenu))

(cl-defmethod xref-backend-identifier-at-point ((_backend (eql 'imenu)))

I can work around the problem by doing,

    (setq paredit-override-check-parens-function #'always)

Message #20 received at 55678 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Visuwesh <visuweshm <at> gmail.com>
Cc: 55678 <at> debbugs.gnu.org
Subject: Re: bug#55678: 29.0.50; C-c C-w and errors in major-mode-hook
Date: Sun, 29 May 2022 15:07:15 +0200

Visuwesh <visuweshm <at> gmail.com> writes:

> That's because paredit-mode only signals an error if there's a paren or
> quote mismatch---whenever `check-parens' errors.  paredit-mode signals
> an error for the following chunk for me,

Ah, yes of course.  And I think that's indeed a bug in paredit-mode --
a minor mode should not signal errors in this way, because it'll break
in exactly the scenarios like this.

I understand you've reported this to the paredit people, so I'm closing
this in the Emacs bug tracker.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.