GNU bug report logs - #55728
[PATCH] gnu: python-mock: Update to 4.0.3.

Previous Next

To reply to this bug, email your comments to 55728 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: peter <at> polidoro.io
To: guix-patches <at> gnu.org
Cc: Peter Polidoro <peter <at> polidoro.io>
Subject: [PATCH] gnu: python-mock: Update to 4.0.3.
Date: Mon, 30 May 2022 10:15:05 -0400

From: Peter Polidoro <peter <at> polidoro.io>

* gnu/packages/check.scm (python-mock): Update to 4.0.3.
---
 gnu/packages/check.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 8df5d87476..535c68cacc 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -855,14 +855,14 @@ (define-public python2-minimock
 (define-public python-mock
   (package
     (name "python-mock")
-    (version "3.0.5")
+    (version "4.0.3")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "mock" version))
        (sha256
         (base32
-         "1hrp6j0yrx2xzylfv02qa8kph661m6yq4p0mc8fnimch9j4psrc3"))))
+         "1g67p9a2by5j5d6yncpf1m68nigsvxfa86giy7r4z3r233gbngvx"))))
     (propagated-inputs
      (list python-six))
     (build-system python-build-system)
-- 
2.36.0

Message #8 received at 55728 <at> debbugs.gnu.org (full text, mbox):

From: jbranso <at> dismail.de
To: "Skyler Ferris" <skyvine <at> protonmail.com>, guix-devel <at> gnu.org,
 peter <at> polidoro.io, 55728 <at> debbugs.gnu.org
Subject: Re: Handling expensive packages
Date: Tue, 12 Mar 2024 19:59:04 +0000

Hey Peter!

Your patch found its way on onto the guix devel list!

Thanks for contributing to guix!  We want to add your patch, and we are wondering what your motivation was for sending this patch?  Is your patch a prerequisite for a package you want to add?  Or do you have some other reason?

Thanks,

Joshua
https://gnucode.me

March 11, 2024 at 3:06 PM, "Skyler Ferris" <skyvine <at> protonmail.com> wrote:



> 
> Hello,
>  
>  I am looking through the backlog of open patch submissions https://issues.guix.gnu.org/search?query=is%3Aopen+tag%3Apatch  to see if any are actionable on my end. One such patch is issue 55728 which updates python-mock https://issues.guix.gnu.org/55728 . Based on the output of `guix refresh --list-dependent python-mock | wc`, this will impact more than 2000 packages. While this submission is very old, neither the master nor python-team branches have updated this package yet. In section 22.8.2 "Managing Patches and Branches" https://guix.gnu.org/en/manual/devel/en/html_node/Managing-Patches-and-Branches.html , there is a recommendation that changes which effect more than 300 dependents are added to a different branch for testing.
>  
>  These dependents presumably still work, as there are not 2000 build failures or a flood of related bug reports. So I think it would make sense to first ask the submitter for their motivation for sending the patch (for example, it might be a prerequisite for a package they want to add and they did not send it as a series for some reason). Depending on their response it might make sense to do something other than apply the update as given (for example, by providing both versions of the package so that a new package can be added without impacting existing branches). But there also might be some reason why it makes sense to apply the update everywhere (for example, if significant optimizations in the update reduces build times for all of the dependent packages).
>  
>  So my main question is whether or not people agree that it makes sense to ask the submitter for more information and take no other action at this time. And as a secondary question, if it does make sense to update the package everywhere is there anything actionable on my end?
>  
>  Regards,
>  Skyler
>

Message #11 received at 55728 <at> debbugs.gnu.org (full text, mbox):

From: Peter Polidoro <peter <at> polidoro.io>
To: jbranso <at> dismail.de
Cc: guix-devel <at> gnu.org, 55728 <at> debbugs.gnu.org,
 Skyler Ferris <skyvine <at> protonmail.com>
Subject: Re: Handling expensive packages
Date: Tue, 12 Mar 2024 16:45:47 -0400

You can ignore or delete this patch if it is causing problems.

If I remember correctly, that was a patch I submitted a couple of years ago when I was attempting to package some embedded software tools, either the zephyr west tool or platformio, both written in python. That sent me down the rabbit hole of dependency updates, the python-mock package being one of them.

I would still love to have both west and platformio packaged in guix. Perhaps those exist now in Guix or another channel, I have not checked in a while. If not, I will attempt to package them again at some point. 

Thanks!

> On Mar 12, 2024, at 15:59, jbranso <at> dismail.de wrote:
> Hey Peter!
> 
> Your patch found its way on onto the guix devel list!
> 
> Thanks for contributing to guix!  We want to add your patch, and we are wondering what your motivation was for sending this patch?  Is your patch a prerequisite for a package you want to add?  Or do you have some other reason?
> 
> Thanks,
> 
> Joshua
> https://gnucode.me

Message #14 received at 55728 <at> debbugs.gnu.org (full text, mbox):

From: Skyler Ferris <skyvine <at> protonmail.com>
To: Peter Polidoro <peter <at> polidoro.io>, jbranso <at> dismail.de
Cc: guix-devel <at> gnu.org, 55728 <at> debbugs.gnu.org
Subject: Re: Handling expensive packages
Date: Wed, 13 Mar 2024 00:15:20 +0000

[Message part 1 (text/plain, inline)]

On 3/12/24 13:45, Peter Polidoro wrote:

> If I remember correctly, that was a patch I submitted a couple of years ago when I was attempting to package some embedded software tools, either the zephyr west tool or platformio, both written in python. That sent me down the rabbit hole of dependency updates, the python-mock package being one of them.
>
> I would still love to have both west and platformio packaged in guix. Perhaps those exist now in Guix or another channel, I have not checked in a while. If not, I will attempt to package them again at some point.

Thank you for the information. I see that west is packaged in gnu/packages/embedded.scm, but the only reference to platformio is an emacs plugin which I suspect is not what you are referring to. So it sounds like there is no particular reason to process this patch immediately but it makes sense to leave open because it might be used down the line.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.