GNU bug report logs - #55774
[PATCH] gnu: quodlibet: Add dependencies for plugins to work.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55774 in the body.
You can then email your comments to 55774 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Wamm K. D" <jaft.r <at> outlook.com>
To: guix-patches <at> gnu.org
Cc: "Wamm K. D" <jaft.r <at> outlook.com>
Subject: [PATCH] gnu: quodlibet: Add dependencies for plugins to work.
Date: Fri,  3 Jun 2022 00:02:55 -0500

* gnu/packages/music.scm (quodlibet): Add dependencies for plugins to work.
---
 gnu/packages/music.scm | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 554d70f266..3751305b3c 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -47,6 +47,7 @@
 ;;; Copyright © 2022 Sughosha <sughosha <at> disroot.org>
 ;;; Copyright © 2022 Remco van 't Veer <remco <at> remworks.net>
 ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2022 Wamm K. D. <jaft.r <at> outlook.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -179,6 +180,7 @@ (define-module (gnu packages music)
   #:use-module (gnu packages vim)       ;for 'xxd'
   #:use-module (gnu packages web)
   #:use-module (gnu packages webkit)
+  #:use-module (gnu packages wm)
   #:use-module (gnu packages wxwidgets)
   #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xml)
@@ -6752,7 +6754,16 @@ (define-public quodlibet
            python-pygobject
            python-pytest
            python-sgmllib3k
-           python-toml))
+           python-toml
+           ;; optional but needed for multimedia keys not under Gnome
+           keybinder-3.0
+           ;; optional but needed for Undo/Redo
+           ;; support for multiline text fields
+           gtksourceview
+           ;; optional but needed for the auto library update plugin
+           python-pyinotify
+           ;; optional but needed for the Musicbrainz plugin
+           python-musicbrainzngs))
     (home-page "https://github.com/quodlibet/quodlibet")
     (synopsis "Music manager and player")
     (description "Quod Libet provides several ways to browse and view your
-- 
2.36.1

Message #8 received at 55774 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: "Wamm K. D" <jaft.r <at> outlook.com>, 55774 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: quodlibet: Add dependencies for plugins to work.
Date: Fri, 03 Jun 2022 08:04:10 +0200

Am Freitag, dem 03.06.2022 um 00:02 -0500 schrieb Wamm K. D:
> * gnu/packages/music.scm (quodlibet): Add dependencies for plugins to
> work.
Should be ... (quodlibet)[inputs]: Add ACTUAL_INPUTS...

> ---
>  gnu/packages/music.scm | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 554d70f266..3751305b3c 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -47,6 +47,7 @@
>  ;;; Copyright © 2022 Sughosha <sughosha <at> disroot.org>
>  ;;; Copyright © 2022 Remco van 't Veer <remco <at> remworks.net>
>  ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> +;;; Copyright © 2022 Wamm K. D. <jaft.r <at> outlook.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -179,6 +180,7 @@ (define-module (gnu packages music)
>    #:use-module (gnu packages vim)       ;for 'xxd'
>    #:use-module (gnu packages web)
>    #:use-module (gnu packages webkit)
> +  #:use-module (gnu packages wm)
>    #:use-module (gnu packages wxwidgets)
>    #:use-module (gnu packages xdisorg)
>    #:use-module (gnu packages xml)
> @@ -6752,7 +6754,16 @@ (define-public quodlibet
>             python-pygobject
>             python-pytest
>             python-sgmllib3k
> -           python-toml))
> +           python-toml
> +           ;; optional but needed for multimedia keys not under
> Gnome
> +           keybinder-3.0
> +           ;; optional but needed for Undo/Redo
> +           ;; support for multiline text fields
> +           gtksourceview
> +           ;; optional but needed for the auto library update plugin
> +           python-pyinotify
> +           ;; optional but needed for the Musicbrainz plugin
> +           python-musicbrainzngs))
YMMV, but it's better for inputs to be sorted alphabetically.  Use line
comments to demarcate specific features, e.g. 
  keybinder-3.0 ; keybindings outside of GNOME
  gtksourceview ; undo, redo, multiline text fields
  ...
Don't forget the 79 character limit; when in doubt claim less features.
If possible, try to line up the comments.

Also, comments like "musicbrainz plugin needs python-musicbrainz" are
not as informative as you'd think and can probably be dropped :)

Cheers

Message #11 received at 55774 <at> debbugs.gnu.org (full text, mbox):

From: "Wamm K. D." <jaft.r <at> outlook.com>
To: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
Cc: 55774 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: quodlibet: Add dependencies for plugins to work.
Date: Fri, 03 Jun 2022 08:13:00 -0500

On Fri. (Jun 03, 2022) at 08:04:10 AM +02, Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at> wrote:
> Am Freitag, dem 03.06.2022 um 00:02 -0500 schrieb Wamm K. D:
>> * gnu/packages/music.scm (quodlibet): Add dependencies for plugins to
>> work.
> Should be ... (quodlibet)[inputs]: Add ACTUAL_INPUTS...

👍; I'll get that updated.

> YMMV, but it's better for inputs to be sorted alphabetically.  Use line
> comments to demarcate specific features, e.g. 
>   keybinder-3.0 ; keybindings outside of GNOME
>   gtksourceview ; undo, redo, multiline text fields
>   ...
> Don't forget the 79 character limit; when in doubt claim less features.
> If possible, try to line up the comments.

Fair; I'll get those updated, as well. Yeah, I was trying to weigh what
to include vs. not but, due to the installation structure of Guix, you
wouldn't be able to use these features by just installing the
dependencies (leastwise, with just a naïve straightforward install, when
I tried) so I figured they were worth including, from that perspective.

> Also, comments like "musicbrainz plugin needs python-musicbrainz" are
> not as informative as you'd think and can probably be dropped :)

Haha; fair. While I could see repeating "musicbrainz" as being
repetitive, I was figuring it's easy to lose track that the dependency
was present specifically due to a plugin, for future developers who
might work on the package, and was mostly trying to capture it was
plugin-related. Thanks for pointing it out and I'll that adjusted.

I'll try making the updates later tonight; thanks a ton.

Message #14 received at 55774 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: "Wamm K. D." <jaft.r <at> outlook.com>
Cc: 55774 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: quodlibet: Add dependencies for plugins to work.
Date: Fri, 03 Jun 2022 15:22:14 +0200

Am Freitag, dem 03.06.2022 um 08:13 -0500 schrieb Wamm K. D.:
> 
> > YMMV, but it's better for inputs to be sorted alphabetically.  Use
> > line
> > comments to demarcate specific features, e.g. 
> >   keybinder-3.0 ; keybindings outside of GNOME
> >   gtksourceview ; undo, redo, multiline text fields
> >   ...
> > Don't forget the 79 character limit; when in doubt claim less
> > features.
> > If possible, try to line up the comments.
> 
> Fair; I'll get those updated, as well. Yeah, I was trying to weigh
> what to include vs. not but, due to the installation structure of
> Guix, you wouldn't be able to use these features by just installing
> the dependencies (leastwise, with just a naïve straightforward
> install, when I tried) so I figured they were worth including, from
> that perspective.
Oh, you understood me wrongly.  Do add all the inputs, but per input
you might not have enough space to describe *all* that it enables, so
if you run out of horizontal space, stick to the most useful features.

> > Also, comments like "musicbrainz plugin needs python-musicbrainz"
> > are not as informative as you'd think and can probably be dropped
> > :)
> 
> Haha; fair. While I could see repeating "musicbrainz" as being
> repetitive, I was figuring it's easy to lose track that the
> dependency was present specifically due to a plugin, for future
> developers who might work on the package, and was mostly trying to
> capture it was plugin-related. Thanks for pointing it out and I'll
> that adjusted.
IIUC much of quodlibet is actually just plugins, so future packagers
looking into it shouldn't be too confused.  Plus we aim for complete
feature sets in pretty much everything except -minimal package variants
:)

Cheers

Message #17 received at 55774 <at> debbugs.gnu.org (full text, mbox):

From: "Wamm K. D" <jaft.r <at> outlook.com>
To: 55774 <at> debbugs.gnu.org
Cc: liliana.prikler <at> ist.tugraz.at, "Wamm K. D" <jaft.r <at> outlook.com>
Subject: [PATCH v2] gnu: quodlibet: Add dependencies for plugins to work.
Date: Fri,  3 Jun 2022 17:59:08 -0500

* gnu/packages/music.scm (quodlibet)[inputs]: Add gtksourceview, keybinder-3.0,
python-musicbrainzngs, and python-pyinotify for plugins to work.
---
 gnu/packages/music.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 554d70f266..afd7ff40cf 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -47,6 +47,7 @@
 ;;; Copyright © 2022 Sughosha <sughosha <at> disroot.org>
 ;;; Copyright © 2022 Remco van 't Veer <remco <at> remworks.net>
 ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2022 Wamm K. D. <jaft.r <at> outlook.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -179,6 +180,7 @@ (define-module (gnu packages music)
   #:use-module (gnu packages vim)       ;for 'xxd'
   #:use-module (gnu packages web)
   #:use-module (gnu packages webkit)
+  #:use-module (gnu packages wm)
   #:use-module (gnu packages wxwidgets)
   #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xml)
@@ -6738,7 +6740,9 @@ (define-public quodlibet
            gst-plugins-ugly
            gstreamer
            gtk+
+           gtksourceview ; undo, redo, multiline text fields
            hicolor-icon-theme
+           keybinder-3.0 ; keybindings outside of GNOME
            librsvg
            libsoup-minimal-2
            python
@@ -6747,9 +6751,11 @@ (define-public quodlibet
            python-feedparser
            python-gst
            python-iniconfig
+           python-musicbrainzngs
            python-mutagen
            python-pycairo
            python-pygobject
+           python-pyinotify
            python-pytest
            python-sgmllib3k
            python-toml))
-- 
2.36.1

Message #20 received at 55774 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: "Wamm K. D" <jaft.r <at> outlook.com>, 55774 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: quodlibet: Add dependencies for plugins to work.
Date: Sat, 04 Jun 2022 09:50:15 +0200

Am Freitag, dem 03.06.2022 um 17:59 -0500 schrieb Wamm K. D:
> * gnu/packages/music.scm (quodlibet)[inputs]: Add gtksourceview,
> keybinder-3.0, python-musicbrainzngs, and python-pyinotify for
> plugins to work.
Pushed with a slight change in the commit message.  

Thanks

Message #25 received at 55774-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: "Wamm K. D" <jaft.r <at> outlook.com>, 55774-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: quodlibet: Add dependencies for plugins to work.
Date: Sat, 04 Jun 2022 10:35:02 +0200

Am Samstag, dem 04.06.2022 um 09:50 +0200 schrieb Liliana Marie
Prikler:
> Am Freitag, dem 03.06.2022 um 17:59 -0500 schrieb Wamm K. D:
> > * gnu/packages/music.scm (quodlibet)[inputs]: Add gtksourceview,
> > keybinder-3.0, python-musicbrainzngs, and python-pyinotify for
> > plugins to work.
> Pushed with a slight change in the commit message.  
> 
> Thanks
Forgot to mark as done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.