GNU bug report logs - #55805
[PATCH] gnu: linux-libre: enable hidraw by default

Previous Next

To reply to this bug, email your comments to 55805 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tom Fitzhenry <tom <at> tom-fitzhenry.me.uk>
To: guix-patches <at> gnu.org
Cc: Tom Fitzhenry <tom <at> tom-fitzhenry.me.uk>
Subject: [PATCH] gnu: linux-libre: enable hidraw by default
Date: Sun,  5 Jun 2022 14:02:22 +0200

* gnu/packages/linux.scm (%default-extra-linux-options): Enable CONFIG_HIDRAW.

hidraw is needed to create /dev/hidraw* devices, commonly used for U2F
devices, e.g. via libu2f-host.

CONFIG_HIDRAW is not enabled in the mainline arm64 defconfig, but is enabled
on:
* the mainline x86_64 defconfig
* gnu/packages/aux-files/linux-libre/*arm64.conf

HIDRAW's Kconfig documentation advises "If unsure, say Y."[0]

Tested by compiling and running linux-libre-arm64-generic, and observing that
/dev/hidraw* devices are created, and SSH-via-U2F now works.

0. Linux kernel, drivers/hid/Kconfig

Link: https://www.kernel.org/doc/Documentation/hid/hidraw.txt
Signed-off-by: Tom Fitzhenry <tom <at> tom-fitzhenry.me.uk>
---
 gnu/packages/linux.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 4fc0ac16af..12e0db23c4 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -687,6 +687,8 @@ (define %default-extra-linux-options
     ("CONFIG_MEMCG_KMEM" . #t)
     ("CONFIG_CPUSETS" . #t)
     ("CONFIG_PROC_PID_CPUSET" . #t)
+    ;; Enable hidraw by default
+    ("CONFIG_HIDRAW" . #t)
     ;; Allow disk encryption by default
     ("CONFIG_DM_CRYPT" . m)
     ;; Modules required for initrd:

base-commit: 8334e7c36ba7266fdbcf783d80c02a072cf1347b
-- 
2.36.1

Message #8 received at 55805 <at> debbugs.gnu.org (full text, mbox):

From: Pavel Shlyak <p.shlyak <at> pantherx.org>
To: 55805 <at> debbugs.gnu.org
Subject: [PATCH] gnu: linux-libre: enable hidraw by default
Date: Sun, 5 Jun 2022 15:23:37 +0300

Nice idea. Good to merge.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Tom Fitzhenry <tom <at> tom-fitzhenry.me.uk>
Cc: 55805 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#55805] [PATCH] gnu: linux-libre: enable hidraw by default
Date: Sun, 05 Jun 2022 15:15:09 +0200

[Message part 1 (text/plain, inline)]

Hi Tom,

Tom Fitzhenry 写道：
> +    ;; Enable hidraw by default
> +    ("CONFIG_HIDRAW" . #t)

I agree with the content of this change, but why add it here & not 
to the kernel configuration aux-files?

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tom Fitzhenry <tom <at> tom-fitzhenry.me.uk>
To: Tobias Geerinckx-Rice via Guix-patches via <guix-patches <at> gnu.org>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 55805 <at> debbugs.gnu.org
Subject: Re: [bug#55805] [PATCH] gnu: linux-libre: enable hidraw by default
Date: Sun, 05 Jun 2022 15:46:02 +0200

Tobias Geerinckx-Rice via Guix-patches via <guix-patches <at> gnu.org>
writes:

> I agree with the content of this change, but why add it here & not to
> the kernel configuration aux-files?

My understanding of gnu/packages/linux.scm is that kernels come in two
forms:

i. "-generic" kernels, which build their .config via mainline defconfig +
  #:extra-options.
  
ii. non "-generic" kernels, which use "#:configuration-file
  kernel-config" to use the config from aux-files.

This patch solely addresses (i) kernels, since (ii) kernels already have
CONFIG_HIDRAW, as we can see by inspecting the aux-files:

$ ls gnu/packages/aux-files/linux-libre/* | wc -l
25
$ grep CONFIG_HIDRAW=y gnu/packages/aux-files/linux-libre/* | wc -l
25

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.