GNU bug report logs - #55827
[PATCH] gnu: Add kismet.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55827 in the body.
You can then email your comments to 55827 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add kismet.
Date: Tue, 07 Jun 2022 07:41:08 +0000

[Message part 1 (text/plain, inline)]

Hi,

this patch adds Kismet package.

----
Petr

[Message part 2 (text/html, inline)]

[0001-gnu-Add-kismet.patch (text/x-patch, attachment)]

Message #8 received at 55827 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 55827 <at> debbugs.gnu.org
Subject: Re: [bug#55827] [PATCH] gnu: Add kismet.
Date: Tue, 07 Jun 2022 09:50:24 +0200

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op di 07-06-2022 om 07:41 [+0000]:
> +	   (url "https://github.com/kismetwireless/kismet")

According  to <https://www.kismetwireless.net/downloads/#kismet-git>,
the main location is https://www.kismetwireless.net/git/kismet.git, the
other one is only a mirror.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 55827 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 55827 <at> debbugs.gnu.org
Subject: Re: [bug#55827] [PATCH] gnu: Add kismet.
Date: Tue, 07 Jun 2022 10:06:30 +0200

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op di 07-06-2022 om 07:41 [+0000]:
> +	(inputs (list openssl libpcap libusb protobuf protobuf-c
> libwebsockets sqlite zlib))
[...]
> +    (license license:gpl2+)))

libwebsockets is lgpl2.1 according to the package definition.
Its dependency openssl is asl2.0.  According to the FSF, asl2.0 and
gpl2.0 are incompatible.  So possibly asl2.0 and lgpl2.1 are
incompatible (though I haven't seen any reliable claim for
compatibility or incompatibility for _l_gpl, maybe it is compatible)
and hence libwebsockets needs to be removed from kismet and Guix.

However, according to v4.0.0 in the changelog, it is Expat (‘MIT’)
licensed, so maybe all that's needed is correcting the license
information?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 55827 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 55827 <at> debbugs.gnu.org
Subject: Re: [bug#55827] [PATCH v2] gnu: Add kismet.
Date: Tue, 07 Jun 2022 09:57:02 +0000

[Message part 1 (text/plain, inline)]

Hi Maxime,


sorry about the mirror, it's fixed in the patch.

> phodina via Guix-patches via schreef op di 07-06-2022 om 07:41 [+0000]:
>
> > + (inputs (list openssl libpcap libusb protobuf protobuf-c
> > libwebsockets sqlite zlib))
>
> [...]
>
> > +    (license license:gpl2+)))
>
>
> libwebsockets is lgpl2.1 according to the package definition.
> Its dependency openssl is asl2.0. According to the FSF, asl2.0 and
> gpl2.0 are incompatible. So possibly asl2.0 and lgpl2.1 are
> incompatible (though I haven't seen any reliable claim for
> compatibility or incompatibility for _l_gpl, maybe it is compatible)
> and hence libwebsockets needs to be removed from kismet and Guix.
>
> However, according to v4.0.0 in the changelog, it is Expat (‘MIT’)
> licensed, so maybe all that's needed is correcting the license
> information?
>
> Greetings,
> Maxime.

Well regarding the license. They have the following statement:

** UNLESS OTHERWISE NOTED IN THE FILE OR DIRECTORY, KISMET
   IS RELEASED UNDER THE GPL2 LICENSE

   SPECIFIC SUBCOMPONENTS AND FILES MAY BE UNDER LESS RESTRICTIVE
   LICENSES.  THESE DIFFERENCES ARE NOTED IN THE FILE OR IN THE
   LICENSE FILE OF THOSE SUBDIRECTORIES **

I'm not a laywer so can't really say if they are compatible or not in this case. Therefore the websockets are now removed by configuration flag.

However, if I think the best approach would be to create issue/bring this issue to the developers of Kismet.

The unfortunate thing with the current patch is it does not build as the boost library has been unbundled and the include headers fixed. What's missing is to add boost in the AutoConf scripts.

I don't have that kind of experience. If you know about some project that uses boost that could serve as reference it would be most welcome.

----
Petr

[v2-0001-gnu-Add-kismet.patch (text/x-patch, attachment)]

Message #17 received at 55827 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>
Cc: 55827 <at> debbugs.gnu.org
Subject: Re: [bug#55827] [PATCH v2] gnu: Add kismet.
Date: Tue, 07 Jun 2022 13:04:44 +0200

[Message part 1 (text/plain, inline)]

phodina schreef op di 07-06-2022 om 09:57 [+0000]:
> I'm not a laywer so can't really say if they are compatible or not in
> this case. Therefore the websockets are now removed by configuration
> flag.
> 
> However, if I think the best approach would be to create issue/bring
> this issue to the developers of Kismet.

I don't think this is necessary, because of ...

> However, according to v4.0.0 in the changelog, [libwebsockets] is
> Expat (‘MIT’) licensed, so maybe all that's needed is correcting the
> license information?

(basically, the license information in the package definition and the
LICENSE file of libwebsockets do not seem to agree).

WDYT?

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 55827 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 55827 <at> debbugs.gnu.org, "pierre.langlois <at> gmx.com" <pierre.langlois <at> gmx.com>
Subject: Re: [bug#55827] [PATCH v2] gnu: Add kismet.
Date: Fri, 10 Jun 2022 08:44:24 +0000

[Message part 1 (text/plain, inline)]

Hi,

> phodina schreef op di 07-06-2022 om 09:57 [+0000]:
>
> > I'm not a laywer so can't really say if they are compatible or not in
> > this case. Therefore the websockets are now removed by configuration
> > flag.
> >
> > However, if I think the best approach would be to create issue/bring
> > this issue to the developers of Kismet.
>
>
> I don't think this is necessary, because of ...
>
> > However, according to v4.0.0 in the changelog, [libwebsockets] is
> > Expat (‘MIT’) licensed, so maybe all that's needed is correcting the
> > license information?
>
>
> (basically, the license information in the package definition and the
> LICENSE file of libwebsockets do not seem to agree).
>
> WDYT?
>
> Greetings,
> Maxime.

Yeah seems there isn't an issue since v4.0 libwebsockets license was changed to MIT as stated here [1].

It was last updated in commit acd953bd64b72cf7185f1d97f33cb6770ff8bfaf.

So I include libwesockets in kismet inputs and provide patch for license of libwesockets.

1 https://github.com/warmcat/libwebsockets/tree/v4.1.6#v40-is-released

----
Petr

[v2-0002-gnu-libwesockets-Update-license.patch (text/x-patch, attachment)]

[v2-0001-gnu-Add-kismet.patch (text/x-patch, attachment)]

Message #23 received at 55827 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: phodina <phodina <at> protonmail.com>, 55827 <at> debbugs.gnu.org
Subject: Re: [bug#55827] [PATCH] gnu: Add kismet.
Date: Fri, 10 Jun 2022 17:30:37 +0200

[Message part 1 (text/plain, inline)]

phodina via Guix-patches via schreef op di 07-06-2022 om 07:41 [+0000]:
> Hi,
> 
> this patch adds Kismet package.
> 
> ----
> Petr

I have looked at how other distros package it:

* http://deb.debian.org/debian/pool/main/k/kismet/kismet_2016.07.R1-1.debian.tar.xz

  has a fix_manpage, fix_typos patch, openssl_1.1.0.
  The 'copyright' file that says some of it is gpl-2-only or BSD3.
  Adds a .desktop file.
  Are they still relevant for the 2022 version?

* fedora has a patch

  https://src.fedoraproject.org/rpms/kismet/blob/rawhide/f/kismet-install.patch

  is it relevant to Guix?

Greetings,
Maxime

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 55827-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: phodina <phodina <at> protonmail.com>
Cc: 55827-done <at> debbugs.gnu.org,
 "pierre.langlois <at> gmx.com" <pierre.langlois <at> gmx.com>,
 Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#55827: [PATCH] gnu: Add kismet.
Date: Wed, 15 Jun 2022 22:19:27 +0200

Hi,

Pushed!

  887b23a73c gnu: Add kismet.
  e51517d077 gnu: libwesockets: Update license.

I removed the “--disable-libwebsockets” configure flags for kismet.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.