GNU logs - #55854, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#55854: "guix refresh" doesn't handle older versions like gtk+@2
Resent-From: Kaelyn <kaelyn.alexi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Wed, 08 Jun 2022 17:20:02 +0000
Resent-Message-ID: <handler.55854.B.165470875122238 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 55854 <at> debbugs.gnu.org
Reply-To: Kaelyn <kaelyn.alexi@HIDDEN>
Date: Wed, 08 Jun 2022 17:18:54 +0000
From: Kaelyn <kaelyn.alexi@HIDDEN>
Message-ID: <bpII8BMbxEJbaiPdFNKwLKOzgKF3fpl3t_Fl8yesV6QnyKVgD_Wl2z5Ip8rT8KIOHULjf9wIi_qbDshR2aC2gxdwwAUARVmWQxZ9H8JIiRg=@protonmail.com>
Feedback-ID: 34709329:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=185.70.40.130;
 envelope-from=kaelyn.alexi@HIDDEN; helo=mail-40130.protonmail.ch
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.2 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

When attempting a mass "guix refresh -ru" of system and home profile packag=
es, some bogus updates were encountered. One category of those is older/mul=
tiple versions of a package all being updated to the latest, as was seen wi=
th gtk+@2, libsigc++@2, and the gtkmm packages. For example:


$  guix refresh gtk+@2
gnu/packages/gtk.scm:851:13: gtk+ would be upgraded from 2.24.33 to 3.94.0


Per the IRC discussion at https://logs.guix.gnu.org/guix/2022-06-08.log#185=
744, those packages should only be upgraded within the same major version. =
Maxime suggested adding a REQUIRED-MAJOR-VERSION field to such packages so =
they are updated correctly: https://logs.guix.gnu.org/guix/2022-06-08.log#1=
85842

(Side note: I believe gtk+ uses a numbering scheme of x.9y.0 for pre-releas=
es of the (x+1).0.0 release; i.e. gtk+ 3.94.0 is a pre-release of gtk 4.)

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Kaelyn <kaelyn.alexi@HIDDEN>
Subject: bug#55854: Acknowledgement ("guix refresh" doesn't handle older
 versions like gtk+@2)
Message-ID: <handler.55854.B.165470875122238.ack <at> debbugs.gnu.org>
References: <bpII8BMbxEJbaiPdFNKwLKOzgKF3fpl3t_Fl8yesV6QnyKVgD_Wl2z5Ip8rT8KIOHULjf9wIi_qbDshR2aC2gxdwwAUARVmWQxZ9H8JIiRg=@protonmail.com>
X-Gnu-PR-Message: ack 55854
X-Gnu-PR-Package: guix
Reply-To: 55854 <at> debbugs.gnu.org
Date: Wed, 08 Jun 2022 17:20:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 55854 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
55854: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D55854
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#55854: [PATCH 1/2] import: Check that GNOME minor version is not a semver prerelease.
References: <bpII8BMbxEJbaiPdFNKwLKOzgKF3fpl3t_Fl8yesV6QnyKVgD_Wl2z5Ip8rT8KIOHULjf9wIi_qbDshR2aC2gxdwwAUARVmWQxZ9H8JIiRg=@protonmail.com>
In-Reply-To: <bpII8BMbxEJbaiPdFNKwLKOzgKF3fpl3t_Fl8yesV6QnyKVgD_Wl2z5Ip8rT8KIOHULjf9wIi_qbDshR2aC2gxdwwAUARVmWQxZ9H8JIiRg=@protonmail.com>
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Fri, 17 Jun 2022 13:53:02 +0000
Resent-Message-ID: <handler.55854.B55854.165547394630581 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 55854 <at> debbugs.gnu.org
Cc: Kaelyn <kaelyn.alexi@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Fri, 17 Jun 2022 15:44:02 +0200
Content-Transfer-Encoding: 7bit
Message-ID: <8f37e2ae72f4e532f05f8cd010099a8e87e57c47.camel@HIDDEN>
MIME-Version: 1.0
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* guix/import/gnome.scm (latest-gnome-release)[even-minor-version]: Rename
to...
[stable-minor-version?]: ... this.  Also check that minor < 90.
---
 guix/import/gnome.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/guix/import/gnome.scm b/guix/import/gnome.scm
index 43966c1028..1a0786ab8d 100644
--- a/guix/import/gnome.scm
+++ b/guix/import/gnome.scm
@@ -60,10 +60,10 @@ (define (latest-gnome-release package)
   (define %not-dot
     (char-set-complement (char-set #\.)))

-  (define (even-minor-version? version)
+  (define (stable-minor-version? version)
     (match (string-tokenize version %not-dot)
       (((= string->number major) (= string->number minor) . rest)
-       (and minor (even? minor)))
+       (and minor (even? minor) (< minor 90)))
       (((= string->number major) . _)
        ;; It should at last start with a digit.
        major)))
@@ -94,7 +94,7 @@ (define upstream-name
          (let* ((releases (assoc-ref releases upstream-name))
                 (latest   (fold (match-lambda*
                                   (((key . value) result)
-                                   (cond ((even-minor-version? key)
+                                   (cond ((stable-minor-version? key)
                                           (match result
                                             (#f
                                              (cons key value))
-- 
2.36.1

Message sent to bug-guix@HIDDEN:

Subject: bug#55854: [PATCH 2/2] gnu: Restrict gtk+ updaters to their major versions.
References: <bpII8BMbxEJbaiPdFNKwLKOzgKF3fpl3t_Fl8yesV6QnyKVgD_Wl2z5Ip8rT8KIOHULjf9wIi_qbDshR2aC2gxdwwAUARVmWQxZ9H8JIiRg=@protonmail.com>
In-Reply-To: <bpII8BMbxEJbaiPdFNKwLKOzgKF3fpl3t_Fl8yesV6QnyKVgD_Wl2z5Ip8rT8KIOHULjf9wIi_qbDshR2aC2gxdwwAUARVmWQxZ9H8JIiRg=@protonmail.com>
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Fri, 17 Jun 2022 13:53:02 +0000
Resent-Message-ID: <handler.55854.B55854.165547394830590 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 55854 <at> debbugs.gnu.org
Cc: Kaelyn <kaelyn.alexi@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Fri, 17 Jun 2022 15:46:29 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Message-ID: <8d1df21d42539c5a0690be407e60e90c7335697a.camel@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

* gnu/packages/gtk.scm (gtk+-2, gtk+)[properties]: Add update-major-version.
* guix/import/gnome.scm (lastest-gnome-release): Add ‘allowed-major-version?’
and use it to filter latest releases.
---
 gnu/packages/gtk.scm  |  6 ++++--
 guix/import/gnome.scm | 33 +++++++++++++++++++++++----------
 2 files changed, 27 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 4d6a690fbb..73b313520f 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -939,7 +939,8 @@ (define-public gtk+-2
 suitable for projects ranging from small one-off tools to complete
 application suites.")
     (license license:lgpl2.0+)
-    (home-page "https://www.gtk.org/")))
+    (home-page "https://www.gtk.org/")
+    (properties `((update-major-version . 2)))))
 
 (define-public gtk+
   (package
@@ -1073,7 +1074,8 @@ (define-public gtk+
     (native-search-paths
      (list (search-path-specification
             (variable "GUIX_GTK3_PATH")
-            (files '("lib/gtk-3.0")))))))
+            (files '("lib/gtk-3.0")))))
+    (properties `((update-major-version . 3)))))
 
 (define-public gtk
   (package
diff --git a/guix/import/gnome.scm b/guix/import/gnome.scm
index 1a0786ab8d..94a2598ab2 100644
--- a/guix/import/gnome.scm
+++ b/guix/import/gnome.scm
@@ -68,6 +68,17 @@ (define (stable-minor-version? version)
        ;; It should at last start with a digit.
        major)))
 
+  (define allowed-major-version?
+    (let ((fixed-major (assoc-ref (package-properties package)
+                                  'update-major-version)))
+      (if fixed-major
+          (lambda (version)
+            (match (string-tokenize version %not-dot)
+              (((= string->number major) . _)
+               (= major fixed-major))
+              (_ #f)))
+          (const #t))))
+
   (define upstream-name
     ;; Some packages like "NetworkManager" have camel-case names.
     (package-upstream-name package))
@@ -94,16 +105,18 @@ (define upstream-name
          (let* ((releases (assoc-ref releases upstream-name))
                 (latest   (fold (match-lambda*
                                   (((key . value) result)
-                                   (cond ((stable-minor-version? key)
-                                          (match result
-                                            (#f
-                                             (cons key value))
-                                            ((newest . _)
-                                             (if (version>? key newest)
-                                                 (cons key value)
-                                                 result))))
-                                         (else
-                                          result))))
+                                   (cond
+                                    ((not (allowed-major-version? key))
+                                     result)
+                                    ((stable-minor-version? key)
+                                     (match result
+                                       (#f
+                                        (cons key value))
+                                       ((newest . _)
+                                        (if (version>? key newest)
+                                            (cons key value)
+                                            result))))
+                                    (else result))))
                                 #f
                                 releases)))
            (and latest
-- 
2.36.1

Last modified: Fri, 17 Jun 2022 14:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.