GNU bug report logs - #5586
23.1.92.1; Electric indentation and hungry backspace deletion in JavaScript mode (js-mode)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5586 in the body.
You can then email your comments to 5586 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Pogonyshev <pogonyshev <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1.92.1;
	Electric indentation and hungry backspace deletion in JavaScript mode
	(js-mode)
Date: Wed, 17 Feb 2010 00:31:45 +0200

Package: emacs
Severity: wishlist

JavaScript is quite similar in syntax to C-like languages (Java, C++
etc.), so it's natural to use the same editing techniques for it.  It
would be nice if Emacs gave JS mode a more "familiar" feel.

For me, the most wanted features are electric indentation and hungry
backspace.  I.e. when typing '{', '(' or a similar control character
the current line would be automatically reindented.  And backspace
would delete all space characters to the left of the point, not just
one.

Paul

Message #8 received at 5586 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Colascione <dan.colascione <at> gmail.com>
To: Paul Pogonyshev <pogonyshev <at> gmx.net>
Cc: 5586 <at> debbugs.gnu.org
Subject: Re: bug#5586: 23.1.92.1; Electric indentation and hungry backspace
	deletion in JavaScript mode (js-mode)
Date: Fri, 26 Mar 2010 01:03:00 -0400

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/16/10 5:31 PM, Paul Pogonyshev wrote:
> Package: emacs
> Severity: wishlist
> 
> JavaScript is quite similar in syntax to C-like languages (Java, C++
> etc.), so it's natural to use the same editing techniques for it.  It
> would be nice if Emacs gave JS mode a more "familiar" feel.
> 
> For me, the most wanted features are electric indentation and hungry
> backspace.  I.e. when typing '{', '(' or a similar control character
> the current line would be automatically reindented.  And backspace
> would delete all space characters to the left of the point, not just
> one.
> 
> Paul

espresso-mode actually had electric indentation when I submitted it for
inclusion in Emacs. Can we restore that functionality?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (Darwin)

iEYEARECAAYFAkusQAQACgkQ17c2LVA10VsA1ACeMwZPtnZnw3aEm3B6/sb+8A5T
hhAAnjM99lr4a5arx69ehVxBM/sv9n6P
=trl7
-----END PGP SIGNATURE-----

Message #11 received at 5586 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Daniel Colascione <dan.colascione <at> gmail.com>
Cc: 5586 <at> debbugs.gnu.org, Paul Pogonyshev <pogonyshev <at> gmx.net>
Subject: Re: bug#5586: 23.1.92.1;
	Electric indentation and hungry backspace deletion in JavaScript mode
	(js-mode)
Date: Sun, 28 Mar 2010 16:46:45 -0400

> espresso-mode actually had electric indentation when I submitted it
> for inclusion in Emacs. Can we restore that functionality?

You're right, it was a mistake to take that out, since CC mode also has
electric punctuation.

I am still not happy about the way it's implemented in either mode---I
think Emacs needs some kind of centralized mechanism for this---but that
is a longer-term project.  In the meantime, I've restored the deleted
code in the branch.

One difference, however, is that espresso-mode did electric punctuation
for `+-.'.  I didn't restore this yet, since CC mode does not do
electric punctuation for these characters.  Is there any reason we need
to do this specially for Javascript?

Message #14 received at 5586 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Colascione <dan.colascione <at> gmail.com>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 5586 <at> debbugs.gnu.org, Paul Pogonyshev <pogonyshev <at> gmx.net>
Subject: Re: bug#5586: 23.1.92.1; Electric indentation and hungry backspace
	deletion in JavaScript mode (js-mode)
Date: Sun, 28 Mar 2010 16:58:49 -0400

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/28/10 4:46 PM, Chong Yidong wrote:
> I am still not happy about the way it's implemented in either mode---I
> think Emacs needs some kind of centralized mechanism for this---but that
> is a longer-term project.  

The chief difficulty I see is that in some modes, indentation isn't
idempotent: if you ran indent-line-function from some generic electric
code, it might change the indentation of the current line in unwanted
ways. (Imagine python-mode, where indent-line-function cycles through
feasible indentation levels for a given line.)

At best, modes would have to opt-in, and if each mode needs some glue
anyway, why not just let each mode handle electric characters itself?

> In the meantime, I've restored the deleted
> code in the branch.

Thanks.

> One difference, however, is that espresso-mode did electric punctuation
> for `+-.'.  I didn't restore this yet, since CC mode does not do
> electric punctuation for these characters.  Is there any reason we need
> to do this specially for Javascript?

There's no particular reason, no. The cc-mode set of electric characters
is probably fine.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (Darwin)

iEYEARECAAYFAkuvwwkACgkQ17c2LVA10VtXIACgmgSYoR4WMmxkOF4l7QoEATYQ
b8oAoNwNRjoQvMSkmd6gWIyNy/8IZBnW
=8XTU
-----END PGP SIGNATURE-----

Message #17 received at 5586 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Colascione <dan.colascione <at> gmail.com>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 5586 <at> debbugs.gnu.org, Paul Pogonyshev <pogonyshev <at> gmx.net>
Subject: Re: bug#5586: 23.1.92.1; Electric indentation and hungry backspace
	deletion in JavaScript mode (js-mode)
Date: Sun, 28 Mar 2010 16:59:14 -0400

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/28/10 4:46 PM, Chong Yidong wrote:
> I am still not happy about the way it's implemented in either mode---I
> think Emacs needs some kind of centralized mechanism for this---but that
> is a longer-term project.  

The chief difficulty I see is that in some modes, indentation isn't
idempotent: if you ran indent-line-function from some generic electric
code, it might change the indentation of the current line in unwanted
ways. (Imagine python-mode, where indent-line-function cycles through
feasible indentation levels for a given line.)

At best, modes would have to opt-in, and if each mode needs some glue
anyway, why not just let each mode handle electric characters itself?

> In the meantime, I've restored the deleted
> code in the branch.

Thanks.

> One difference, however, is that espresso-mode did electric punctuation
> for `+-.'.  I didn't restore this yet, since CC mode does not do
> electric punctuation for these characters.  Is there any reason we need
> to do this specially for Javascript?

There's no particular reason, no. The cc-mode set of electric characters
is probably fine.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (Darwin)

iEYEARECAAYFAkuvwyIACgkQ17c2LVA10VtH3gCeOCAeJGGzWDM1NATJ5HzOakbJ
Ix8Ani2twtZPGkUe0G8uQs5v+w0XQmjx
=1shD
-----END PGP SIGNATURE-----

Message #20 received at 5586 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Daniel Colascione <dan.colascione <at> gmail.com>
Cc: Chong Yidong <cyd <at> stupidchicken.com>, 5586 <at> debbugs.gnu.org,
	Paul Pogonyshev <pogonyshev <at> gmx.net>
Subject: Re: bug#5586: 23.1.92.1; Electric indentation and hungry backspace 
	deletion in JavaScript mode (js-mode)
Date: Mon, 29 Mar 2010 00:37:24 +0200

On Sun, Mar 28, 2010 at 10:58 PM, Daniel Colascione
<dan.colascione <at> gmail.com> wrote:
>
> The chief difficulty I see is that in some modes, indentation isn't
> idempotent: if you ran indent-line-function from some generic electric
> code, it might change the indentation of the current line in unwanted
> ways. (Imagine python-mode, where indent-line-function cycles through
> feasible indentation levels for a given line.)
>
> At best, modes would have to opt-in, and if each mode needs some glue
> anyway, why not just let each mode handle electric characters itself?


Because without something like indent-line-function you can not handle
it in a more generic way.

The absense of this in some major modes has for example costed me a
lot of burden in mumamo (the framework in nXhtml for mult major modes
in a buffer). Actually indent-line-function is not generic enough. One
more level is needed: one that computes the desirable indentation.

Message #23 received at 5586 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Daniel Colascione <dan.colascione <at> gmail.com>
Cc: Chong Yidong <cyd <at> stupidchicken.com>, 5586 <at> debbugs.gnu.org,
	Paul Pogonyshev <pogonyshev <at> gmx.net>
Subject: Re: bug#5586: 23.1.92.1;
	Electric indentation and hungry backspace deletion in JavaScript mode
	(js-mode)
Date: Sun, 28 Mar 2010 21:49:40 -0400

> At best, modes would have to opt-in, and if each mode needs some glue
> anyway, why not just let each mode handle electric characters itself?

For one, it would allow users to turn it on/off globally rather than
having to do it for every mode.  Also every mode shouldn't have to
reinvent it.


        Stefan

Message #26 received at 5586 <at> debbugs.gnu.org (full text, mbox):

From: Tom Tromey <tom <at> tromey.com>
To: 5586 <at> debbugs.gnu.org
Subject: is this bug still valid?
Date: Sun, 06 Aug 2017 18:25:11 -0600

js.el now has:

  (setq-local electric-indent-chars
	      (append "{}():;," electric-indent-chars)) ;FIXME: js2-mode adds "[]*".

... so I think the original request for electric indentation has been
met.

Maybe the FIXME should be addressed by moving "[]" (and "*" - I don't
know that this one is so useful) out of the comment and into the string?

Hungry deletion seems like something that should be done generically in
electric.el.

Tom

Message #29 received at 5586 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tom Tromey <tom <at> tromey.com>
Cc: 5586 <at> debbugs.gnu.org
Subject: Re: bug#5586: 23.1.92.1; Electric indentation and hungry backspace
 deletion in JavaScript mode (js-mode)
Date: Mon, 31 Jan 2022 18:08:06 +0100

Tom Tromey <tom <at> tromey.com> writes:

> js.el now has:
>
>   (setq-local electric-indent-chars
> 	      (append "{}():;," electric-indent-chars)) ;FIXME: js2-mode adds "[]*".
>
> ... so I think the original request for electric indentation has been
> met.

I guess so, so I'm closing this bug report.  (If there's more to be done
here, please respond to the debbugs address and we'll reopen.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.