GNU bug report logs -
#55874
[PATCH] Add timewarrior 1.4.3
Previous Next
Reported by: Zac Berkowitz <zac.berkowitz <at> gmail.com>
Date: Thu, 9 Jun 2022 15:12:02 UTC
Severity: normal
Tags: patch
Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55874 in the body.
You can then email your comments to 55874 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Thu, 09 Jun 2022 15:12:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Zac Berkowitz <zac.berkowitz <at> gmail.com>:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org.
(Thu, 09 Jun 2022 15:12:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
[0001-gnu-Add-timewarrior.patch (text/x-patch, attachment)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Thu, 09 Jun 2022 19:51:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Zac Berkowitz schreef op do 09-06-2022 om 11:11 [-0400]:
> + (method url-fetch)
> + (uri (string-append
> +
> "https://github.com/GothenburgBitFactory/timewarrior/releases/download/v
> " version
> + "/timew-" version ".tar.gz"))
> + (sha256 (base32
> +
> "0lyaqzcg8np2fpsmih0hlkjxd3qbadc7khr24m1pq9lsdhq7xpy4"))))
I can confirm the hash matches, and hashing the file with sha256sum
agrees with the hash mentioned on <https://timewarrior.net/releases/>.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Thu, 09 Jun 2022 19:54:01 GMT)
Full text and
rfc822 format available.
Message #11 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Zac Berkowitz schreef op do 09-06-2022 om 11:11 [-0400]:
> + (native-inputs
> + `(("ruby-asciidoctor" ,ruby-asciidoctor)
> + ("python" ,python)))
> + (inputs
> + `(("gnutls" ,gnutls)
> + ("util-linux:lib" ,util-linux "lib")))
Nowadays, these can be simplified to.
(native-inputs (list ruby-asciidoctor python))
Where did you learn about the old form?
Likewise (if I remember the syntax right):
(list gnutls `(,util-linux "lib"))
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Thu, 09 Jun 2022 19:56:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Zac Berkowitz schreef op do 09-06-2022 om 11:11 [-0400]:
+ (delete 'install-license-files) ; Already installed by
package
Not a problem I think -- at worst, the license file will appear twice,
but identical files are automatically deduplicated, and even if not, they
are relatively small files anyway.
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Thu, 09 Jun 2022 19:57:01 GMT)
Full text and
rfc822 format available.
Message #17 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Zac Berkowitz schreef op do 09-06-2022 om 11:11 [-0400]:
> + (substitute* "src/commands/CMakeLists.txt"
> + (("/bin/sh") (which "sh"))))))))
In this context, (which "sh") can maybe be simplified to just "sh", not
that it really matters.
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Thu, 09 Jun 2022 20:02:02 GMT)
Full text and
rfc822 format available.
Message #20 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Zac Berkowitz schreef op do 09-06-2022 om 11:11 [-0400]:
> * gnu/packages/task-management.scm (timewarrior): New variable
This contains a binary src/libshared/src/wcwidth.h, which should be
built from source with the generator
https://github.com/ridiculousfish/widecharwidth/ instead.
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Thu, 09 Jun 2022 20:07:01 GMT)
Full text and
rfc822 format available.
Message #23 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Zac Berkowitz schreef op do 09-06-2022 om 11:11 [-0400]:
> * gnu/packages/task-management.scm (timewarrior): New variable
This package is irreproducible, see
https://salsa.debian.org/tasktools-team/timew/-/blob/master/debian/patches/time-sensitive-tests.patch
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Thu, 09 Jun 2022 20:09:02 GMT)
Full text and
rfc822 format available.
Message #26 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Zac Berkowitz schreef op do 09-06-2022 om 11:11 [-0400]:
> + (native-inputs
> + `(("ruby-asciidoctor" ,ruby-asciidoctor)
> + ("python" ,python)))
According to Debian, additional (native-)inputs are required:
https://salsa.debian.org/tasktools-team/timew/-/blob/master/debian/tests/control
Are the tests actually run and can the man page be read?
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Thu, 09 Jun 2022 20:10:01 GMT)
Full text and
rfc822 format available.
Message #29 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Zac Berkowitz schreef op do 09-06-2022 om 11:11 [-0400]:
> + (method url-fetch)
> + (uri (string-append
> +
> "https://github.com/GothenburgBitFactory/timewarrior/releases/download/v
> " version
> + "/timew-" version ".tar.gz"))
> + (sha256 (base32
The tests are missing:
https://salsa.debian.org/tasktools-team/timew/-/blob/master/debian/README.source
so maybe use the source code on git instead?
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Thu, 09 Jun 2022 20:11:01 GMT)
Full text and
rfc822 format available.
Message #32 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Zac Berkowitz schreef op do 09-06-2022 om 11:11 [-0400]:
> + (origin
> + (method url-fetch)
> + (uri (string-append
> +
> "https://github.com/GothenburgBitFactory/timewarrior/releases/download/v
> " version
> + "/timew-" version ".tar.gz"))
> + (sha256 (base32
Is the bash completion installed in the right location?
According to Debian, it isn't:
https://salsa.debian.org/tasktools-team/timew/-/blob/master/debian/timewarrior.bash-completion
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Thu, 09 Jun 2022 20:13:02 GMT)
Full text and
rfc822 format available.
Message #35 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Zac Berkowitz schreef op do 09-06-2022 om 11:11 [-0400]:
> + (native-inputs
> + `(("ruby-asciidoctor" ,ruby-asciidoctor)
> + ("python" ,python)))
Are the scripts in ext/*.py installed somewhere? If so, 'python' needs
to be in 'inputs' instead for cross-compilation.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Thu, 09 Jun 2022 20:18:02 GMT)
Full text and
rfc822 format available.
Message #38 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
According to archlinux, there are some bogus man pages:
https://archlinuxarm.org/packages/aarch64/timew/files/PKGBUILD
are they absent here? (Also, archlinux has the same hash!)
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Fri, 10 Jun 2022 01:38:02 GMT)
Full text and
rfc822 format available.
Message #41 received at 55874 <at> debbugs.gnu.org (full text, mbox):
Maxime,
Thanks for all of the great feedback -- seems like "works for me"
wasn't nearly good enough in this case! I'll chip away at these
issues next week when I've got some time. Is submitting a new patch
on this bug # the best way forward? Or should I close this and open a
new patch issue when it's ready?
Cheers,
Zac
On Thu, Jun 9, 2022 at 4:17 PM Maxime Devos <maximedevos <at> telenet.be> wrote:
>
> According to archlinux, there are some bogus man pages:
>
> https://archlinuxarm.org/packages/aarch64/timew/files/PKGBUILD
>
> are they absent here? (Also, archlinux has the same hash!)
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Fri, 10 Jun 2022 07:50:02 GMT)
Full text and
rfc822 format available.
Message #44 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Zac Berkowitz schreef op do 09-06-2022 om 21:36 [-0400]:
> Maxime,
>
> Thanks for all of the great feedback -- seems like "works for me"
> wasn't nearly good enough in this case! I'll chip away at these
> issues next week when I've got some time. Is submitting a new patch
> on this bug # the best way forward? Or should I close this and open a
> new patch issue when it's ready?
Send it as a v2 to 55874@, then all the relevant information is kept
together at <https://issues.guix.gnu.org/55874>.
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Fri, 10 Jun 2022 14:05:01 GMT)
Full text and
rfc822 format available.
Message #47 received at 55874 <at> debbugs.gnu.org (full text, mbox):
Maxime,
Ended up having a bit of time today to look through what you brought
up. Thanks again for it!
>> + (native-inputs
>> + `(("ruby-asciidoctor" ,ruby-asciidoctor)
>> + ("python" ,python)))
>
> According to Debian, additional (native-)inputs are required:
>
> https://salsa.debian.org/tasktools-team/timew/-/blob/master/debian/tests/control
>
> Are the tests actually run and can the man page be read?
According to the source
(https://github.com/GothenburgBitFactory/timewarrior/blob/develop/INSTALL)
asciidoctor is required to build the docs, but python is not a
requirement at runtime.
I'm able to run the timew executable in a pure shell without moving
python to the input list, so this seems to be a debian issue?
The python scripts in ext/ are completely optional according to the
README in that same directory. Like taskwarrior, timewarrior can
execute python scripts as hooks in response to various commands, but
they're not necessary for base use.
Maybe this is why debian adds the python requirement? So hooks just
work out of the box? How does guix deal with optional dependencies
like this?
Tests are run and pass, but that doesn't rule out determinism issues,
I'll see what debian did to address that.
man pages are not available, I'll correct that.
>> + (native-inputs
>> + `(("ruby-asciidoctor" ,ruby-asciidoctor)
>> + ("python" ,python)))
>> + (inputs
>> + `(("gnutls" ,gnutls)
>> + ("util-linux:lib" ,util-linux "lib")))
>
> Nowadays, these can be simplified to.
>
> (native-inputs (list ruby-asciidoctor python))
>
> Where did you learn about the old form?
Wouldn't say "learn" - I'm very new to lisps! The code here is mostly
adapted from taskwarrior (same developer) and other snippets from
gnu/packages. I'm sure I grep'd for another package that required
asciidoctor and adapted their portion of the code.
>>+ (delete 'install-license-files) ; Already installed by
>> package
>
> Not a problem I think -- at worst, the license file will appear twice,
> but identical files are automatically deduplicated, and even if not, they
> are relatively small files anyway.
This is from taskwarrior from the same developer and has a similar
build setup. Seems like both packages should be consistent, but I'm
happy to remove this directive if needed.
>> + (substitute* "src/commands/CMakeLists.txt"
>> + (("/bin/sh") (which "sh"))))))))
>
> In this context, (which "sh") can maybe be simplified to just "sh", not
> that it really matters.
Ok.
On Fri, Jun 10, 2022 at 3:49 AM Maxime Devos <maximedevos <at> telenet.be> wrote:
>
> Zac Berkowitz schreef op do 09-06-2022 om 21:36 [-0400]:
> > Maxime,
> >
> > Thanks for all of the great feedback -- seems like "works for me"
> > wasn't nearly good enough in this case! I'll chip away at these
> > issues next week when I've got some time. Is submitting a new patch
> > on this bug # the best way forward? Or should I close this and open a
> > new patch issue when it's ready?
>
> Send it as a v2 to 55874@, then all the relevant information is kept
> together at <https://issues.guix.gnu.org/55874>.
>
> Greetings,
> Maxime.
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Fri, 10 Jun 2022 14:55:01 GMT)
Full text and
rfc822 format available.
Message #50 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Zac Berkowitz schreef op vr 10-06-2022 om 10:04 [-0400]:
> The python scripts in ext/ are completely optional according to the
> README in that same directory. Like taskwarrior, timewarrior can
> execute python scripts as hooks in response to various commands, but
> they're not necessary for base use.
> Maybe this is why debian adds the python requirement? So hooks just
> work out of the box? How does guix deal with optional dependencies
> like this?
>
If it increases the closure size a lot and does not provide much extra
functionality, the extra dependency (and the components that require
that dependency) is removed. (Alternatively the ext/ scripts can be
changed to use the 'python' in $PATH instead of a baked-in 'python',
though such things are avoided where feasible for robustness).
Even if they are optional, adding python might be required such that
the _correct_ python is used when cross-compiling. As a test, you
could try running "guix gc --references" on the timewarrior store item
-- if the output contains python, the ext/... is installed with python.
Probably most people would have python anyway, so I don't think it has
to be removed.
Looking at the output of "guix gc --references", it does indeed use
python from somewhere.
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Fri, 10 Jun 2022 14:57:02 GMT)
Full text and
rfc822 format available.
Message #53 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Zac Berkowitz schreef op vr 10-06-2022 om 10:04 [-0400]:
> According to the source
> (https://github.com/GothenburgBitFactory/timewarrior/blob/develop/INSTALL)
> asciidoctor is required to build the docs, but python is not a
> requirement at runtime.
Then something appears to be broken somewhere, because I'm not seeing
any docs (except for some README) in
</gnu/store/n2hl121g9qgvdpmx4qmsfr1d77hrpxps-timewarrior-1.4.3/>.
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Fri, 10 Jun 2022 15:01:02 GMT)
Full text and
rfc822 format available.
Message #56 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Zac Berkowitz schreef op vr 10-06-2022 om 10:04 [-0400]:
> The python scripts in ext/ are completely optional according to the
> README in that same directory. Like taskwarrior, timewarrior can
> execute python scripts as hooks in response to various commands, but
> they're not necessary for base use.
Two comments:
* the scripts are installed in share/doc/timew, so I don't think they
are actually automatically or discoverable by the user, so FWIW
as-is they can be removed (removing the reference to python).
Alternatively you could look into making them functional, as some
other distros do.
* the scripts do subprocess.call(['timew', ...]). For robustness,
if these scripts are kept, the 'timew' needs to be replaced by the
/gnu/store/.../bin/timew (by using 'substitute*' in a phase).
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Fri, 10 Jun 2022 15:01:02 GMT)
Full text and
rfc822 format available.
Message #59 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Zac Berkowitz schreef op vr 10-06-2022 om 10:04 [-0400]:
> Wouldn't say "learn" - I'm very new to lisps! The code here is mostly
> adapted from taskwarrior (same developer) and other snippets from
> gnu/packages. I'm sure I grep'd for another package that required
> asciidoctor and adapted their portion of the code.
>
Ok, not all old packages have been converted yet.
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
guix-patches <at> gnu.org:
bug#55874; Package
guix-patches.
(Mon, 13 Jun 2022 18:16:01 GMT)
Full text and
rfc822 format available.
Message #62 received at 55874 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
A new patch that addresses many of the issues from the first attempt:
- python moved to an input dependency. Eases use of bundled but
optional python scripts
- man pages built and installed in share/man/man1/ and share/man/man7/
- bash completions installed to etc/bash_completion.d/
- non-deterministic tests skipped using same patch from debian
That last one I'm sure if it's the best way to go. It still has the
original attribution within the patch file itself, which is good.
Alternatives would be equivalent changes through snippets (hard) or
re-implementing the patch ourselves (silly).
Zac
On Fri, Jun 10, 2022 at 11:00 AM Maxime Devos <maximedevos <at> telenet.be> wrote:
>
> Zac Berkowitz schreef op vr 10-06-2022 om 10:04 [-0400]:
> > Wouldn't say "learn" - I'm very new to lisps! The code here is mostly
> > adapted from taskwarrior (same developer) and other snippets from
> > gnu/packages. I'm sure I grep'd for another package that required
> > asciidoctor and adapted their portion of the code.
> >
>
> Ok, not all old packages have been converted yet.
[0001-gnu-Add-timewarrior.patch (text/x-patch, attachment)]
Reply sent
to
Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility.
(Sat, 28 Jan 2023 10:09:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
Zac Berkowitz <zac.berkowitz <at> gmail.com>:
bug acknowledged by developer.
(Sat, 28 Jan 2023 10:09:01 GMT)
Full text and
rfc822 format available.
Message #67 received at 55874-done <at> debbugs.gnu.org (full text, mbox):
Hello,
Zac Berkowitz <zac.berkowitz <at> gmail.com> writes:
> A new patch that addresses many of the issues from the first attempt:
>
> - python moved to an input dependency. Eases use of bundled but
> optional python scripts
> - man pages built and installed in share/man/man1/ and share/man/man7/
> - bash completions installed to etc/bash_completion.d/
> - non-deterministic tests skipped using same patch from debian
Thank you.
> That last one I'm sure if it's the best way to go.
I don't know either, but I think your current proposal has merits.
> Subject: [PATCH] gnu: Add timewarrior.
I added a proper commit message, used G-expressions in the package
definition, registered the patch in local.mk and applied everything.
Sorry for the delay!
Regards,
--
Nicolas Goaziou
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Sat, 25 Feb 2023 12:24:13 GMT)
Full text and
rfc822 format available.
This bug report was last modified 1 year and 54 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.