GNU bug report logs - #55896
[PATCH] gnu: Add python-pybare.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: guix-patches; Reported by: jgart <jgart@HIDDEN>; Keywords: moreinfo patch; dated Sat, 11 Jun 2022 04:29:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Added tag(s) moreinfo. Request was from Maxim Cournoyer <maxim.cournoyer@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 55896 <at> debbugs.gnu.org:


Received: (at 55896) by debbugs.gnu.org; 7 Jul 2022 20:33:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 07 16:33:31 2022
Received: from localhost ([127.0.0.1]:58101 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o9YBn-000248-FD
	for submit <at> debbugs.gnu.org; Thu, 07 Jul 2022 16:33:31 -0400
Received: from mail-qt1-f179.google.com ([209.85.160.179]:42577)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1o9YBj-00023o-F5
 for 55896 <at> debbugs.gnu.org; Thu, 07 Jul 2022 16:33:29 -0400
Received: by mail-qt1-f179.google.com with SMTP id g14so24510371qto.9
 for <55896 <at> debbugs.gnu.org>; Thu, 07 Jul 2022 13:33:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version;
 bh=2E9tMyi1amJ6JGKMgPOnQ4B1sakk4RhQkuA1mKB7ImY=;
 b=nA2oLpE8B0VcHbHee7sEa/xZtgBNGDiEpAZtkdhw2kukKgPf3H6+lAYAV7ZKFYKY7o
 asBiSnM6Nqi1oIFTBijwG4gcSl4vN1G6/yHOLoPQRRwoZcqzfVOAyXwQFhJ4gGrX3oxU
 gcyNXj2SqffoeobiFStLNd5hZA7TZJwvUZgOn+IQvRakQG1xt67Saa6xegP5/SPEH4Xe
 6JRG+WLgtSz8CRJ6vSVTC4MyUiqnuxiTdb3oGrIyyi1ubQKu8prSgi8ZzJ2M5N+/ft/V
 Ssz1/pwxKUnFmCghtW9ZGJJsIKh0FsbbrlEM+fMcM/64Sf6LTzSjbil3uZNJq8agbJDa
 TGZg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version;
 bh=2E9tMyi1amJ6JGKMgPOnQ4B1sakk4RhQkuA1mKB7ImY=;
 b=RMEFT7NQQ/z0owxqavYB5aqQiC+fyTwM/vhrQ+0HdPRv9VEn77XnvkdHNyDI83+Zj5
 YgB9A9kMp33a4odrx+QaA4nShKfWhN540UohQYeTShzH0gMYxq8QHULiawOqeuzgvmsW
 BCprVdWHMcftU479m2Ypjz3wys020EYB9V4ZVytmCjl+G5IGvl3P7groSF0v08yOrUXU
 AVoyTM2B9JsFXNi8oUyAPxLRt9Mgf2lPXmssInywr2xAtIt+QMDxRlSv9z0qlpk1VVkr
 +NH5M+33LY37bs9ZUlLTOhBIuYzMeSUJE534mnN5ofCSp+7FRh8p6zy8eetbDOehfESf
 lxnQ==
X-Gm-Message-State: AJIora8SfqrhVIxdHX4mI76xeK9h/mwqvrAIeMADGN08mniMmv6CxAvB
 Nzvg9p2Q492j5+JWBs2LY9cMTPycSGRkn0kq
X-Google-Smtp-Source: AGRyM1vpTFrRNtos3vCJDugEmXCdaWCZoozXy4OtODkAqqRkx6rpPppZl34kF628Y76M390QrwuXXQ==
X-Received: by 2002:a05:6214:29e9:b0:473:63b:5c61 with SMTP id
 jv9-20020a05621429e900b00473063b5c61mr12717082qvb.99.1657226001791; 
 Thu, 07 Jul 2022 13:33:21 -0700 (PDT)
Received: from hurd (dsl-153-127.b2b2c.ca. [66.158.153.127])
 by smtp.gmail.com with ESMTPSA id
 dm15-20020a05620a1d4f00b006b555509398sm1668465qkb.136.2022.07.07.13.33.21
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 07 Jul 2022 13:33:21 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: jgart <jgart@HIDDEN>
Subject: Re: bug#55896: [PATCH] gnu: Add python-pybare.
References: <20220611202700.5655-1-jgart@HIDDEN>
 <fa829031dd0a11841914052a5277b3852e99db82.camel@HIDDEN>
 <20220612155418.GC1648@gac>
Date: Thu, 07 Jul 2022 16:33:20 -0400
In-Reply-To: <20220612155418.GC1648@gac> (jgart@HIDDEN's message of "Sun, 
 12 Jun 2022 15:54:18 -0500")
Message-ID: <87h73swtm7.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 55896
Cc: 55896 <at> debbugs.gnu.org, Maxime Devos <maximedevos@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

jgart <jgart@HIDDEN> writes:

[...]

> Hi Maxime, no worries. Take your time. The review is much appreciated.
>
> I just looked at the sources again myself and noticed that the tests
> use pre-generated BARE binaries to test against.
>
> See here:
>
> https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/test_encoder.py#L225
>
> and here:
>
> https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/_examples
>
> Should I ask the author if they can provide a way to generate those
> binaries for testing instead of vendoring the pre-compiled binaries
> without their sources?

Yes, please ask.  Otherwise, we'll have to delete the binaries from
unknown source in a source snippet and not run the test suite...

Thank you!

Maxim
Information forwarded to guix-patches@HIDDEN:
bug#55896; Package guix-patches. Full text available.

Message received at 55896 <at> debbugs.gnu.org:


Received: (at 55896) by debbugs.gnu.org; 12 Jun 2022 20:54:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 12 16:54:31 2022
Received: from localhost ([127.0.0.1]:56569 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o0UbP-0005NR-DP
	for submit <at> debbugs.gnu.org; Sun, 12 Jun 2022 16:54:31 -0400
Received: from mx1.dismail.de ([78.46.223.134]:17822)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jgart@HIDDEN>) id 1o0UbK-0005N9-Eq
 for 55896 <at> debbugs.gnu.org; Sun, 12 Jun 2022 16:54:30 -0400
Received: from mx1.dismail.de (localhost [127.0.0.1])
 by mx1.dismail.de (OpenSMTPD) with ESMTP id ff10eaf6;
 Sun, 12 Jun 2022 22:54:19 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=date
 :message-id:from:to:cc:subject:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding; s=
 20190914; bh=fkbydiEBP45xbnJG1RiCAGlgyP3LP51VGYiZx3YaLQA=; b=Bk9
 QBrw99M15esQfm7X7/QuImG/1XduO5Fj2RbMiUhTN4WvuvofhLHBXNSWcr9l25aN
 zqWZCDED61TFeefNbjg8zuNAyfKxoWvtgpfcShHcmY/NIxgveKpl2GVcMCbrKYos
 cdgffgGo2CJtmoKNHvzUluhK/mFORInC+aT0ZZ/o4Ve/AJd0d0gR5tB2v+11Li3B
 41Yz6L+RMueHVy2nrrfOA+orFQ0cgXdJfl7probqMOfUte10het9GIDVtxB6Emgs
 ggP+ECE8DEqKCs2s7VVE6YG11/oAmy/WeutfZPhPvOafv6uG2809u5eHzFW4cKSa
 k0uhdodDwhVSF+U6z6Q==
Received: from smtp1.dismail.de (<unknown> [10.240.26.11])
 by mx1.dismail.de (OpenSMTPD) with ESMTP id eaa1c5bb;
 Sun, 12 Jun 2022 22:54:18 +0200 (CEST)
Received: from smtp1.dismail.de (localhost [127.0.0.1])
 by smtp1.dismail.de (OpenSMTPD) with ESMTP id 576a657d;
 Sun, 12 Jun 2022 22:54:18 +0200 (CEST)
Received: by dismail.de (OpenSMTPD) with ESMTPSA id 26ad4fc4
 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); 
 Sun, 12 Jun 2022 22:54:17 +0200 (CEST)
Date: Sun, 12 Jun 2022 15:54:18 -0500
Message-ID: <20220612155418.GC1648@gac>
From: jgart <jgart@HIDDEN>
To: Maxime Devos <maximedevos@HIDDEN>
Subject: Re: [PATCH v2] gnu: Add python-pybare.
In-Reply-To: <fa829031dd0a11841914052a5277b3852e99db82.camel@HIDDEN>
References: <20220611202700.5655-1-jgart@HIDDEN>
 <fa829031dd0a11841914052a5277b3852e99db82.camel@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 55896
Cc: 55896 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Sun, 12 Jun 2022 17:41:57 +0200 Maxime Devos <maximedevos@HIDDEN> wrote:
> jgart schreef op za 11-06-2022 om 15:27 [-0500]:
> > +(define-public python-pybare
> > +  (package
> > +    (name "python-pybare")
> > +    (version "0.1.1")
> > +    (source
> > +      (origin
> > +        (method git-fetch)
> > +        (uri
> > +         (git-reference
> > +          (url "https://git.sr.ht/~chiefnoah/pybare")
> > +          (commit (string-append "v" version))))
> > +        (file-name (git-file-name name version))
> > +        (sha256
> > +         (base32 "1ibmwwf1rdxlwyxlzhv3v1i0ybsqg0kppim90sm8rsbns86yy4by"))))
> > +    (build-system python-build-system)
> > +    (arguments
> > +      (list #:phases
> > +            #~(modify-phases %standard-phases
> > +                (replace 'check
> > +                  (lambda* (#:key tests? #:allow-other-keys)
> > +                    (when tests?
> > +                      (chdir "bare")
> > +                      (invoke "pytest" "-vv" ".")))))))
> > +    (native-inputs
> > +      (list python-pytest))
> > +    (home-page "https://sr.ht/~chiefnoah/PyBARE/")
> > +    (synopsis "Declarative implementation of BARE for Python")
> > +    (description
> > +"@code{python-pybare} is a general purpose library for strongly typed
> > +primitives in Python that supports serializing to and from @acronym{BARE,
> > +Binary Application Record Encoding} messages.")
> > +    (license license:expat
> 
> 
> Package definition LGTM, but I have only looked at the definition, not
> the sources etc.

Hi Maxime, no worries. Take your time. The review is much appreciated.

I just looked at the sources again myself and noticed that the tests
use pre-generated BARE binaries to test against.

See here:

https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/test_encoder.py#L225

and here:

https://git.sr.ht/~chiefnoah/pybare/tree/master/item/bare/_examples

Should I ask the author if they can provide a way to generate those
binaries for testing instead of vendoring the pre-compiled binaries
without their sources?

all best,

jgart
Information forwarded to guix-patches@HIDDEN:
bug#55896; Package guix-patches. Full text available.

Message received at 55896 <at> debbugs.gnu.org:


Received: (at 55896) by debbugs.gnu.org; 12 Jun 2022 15:42:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 12 11:42:07 2022
Received: from localhost ([127.0.0.1]:56365 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o0Pj5-0003nR-ND
	for submit <at> debbugs.gnu.org; Sun, 12 Jun 2022 11:42:07 -0400
Received: from michel.telenet-ops.be ([195.130.137.88]:44230)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1o0Pj2-0003nG-Tc
 for 55896 <at> debbugs.gnu.org; Sun, 12 Jun 2022 11:42:07 -0400
Received: from [172.20.10.5] ([188.188.255.8])
 by michel.telenet-ops.be with bizsmtp
 id iFi22700F0BeyFQ06Fi3AE; Sun, 12 Jun 2022 17:42:03 +0200
Message-ID: <fa829031dd0a11841914052a5277b3852e99db82.camel@HIDDEN>
Subject: Re: [PATCH v2] gnu: Add python-pybare.
From: Maxime Devos <maximedevos@HIDDEN>
To: jgart <jgart@HIDDEN>, 55896 <at> debbugs.gnu.org
Date: Sun, 12 Jun 2022 17:41:57 +0200
In-Reply-To: <20220611202700.5655-1-jgart@HIDDEN>
References: <20220611202700.5655-1-jgart@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-KTuBE4fayLPodAI6yOqY"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1655048523; bh=GRfh4FYo48fTqPjoLYSKPJ5ioCeZVw8H6mq/HV0uFO0=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=IhBlIwgxvLMgnrM6f4isdHCx8BJ1mGt/mDgXrA4sAeEncJ2KHuD5dHGdJcZ+dgeVN
 JquGhA27nSGc/AnvwKWvqqEu1cJxaWP+hbv9NzS/ZccCXflCelIzi/qncqpb5kubdk
 Oy4r7fQwJIpwJSlDthuDvcoeJ1jv/RbMmuLW/9kF3PfI+lC08AydaTo3mFIrH2TK8m
 1rqbbuisCRJQcxrB7s/QDIiEp9IZIg0rL0DSxaa/xl3Ej2/AEEtrjAwIeidscGkCgB
 MaFdhksu2z+vDb8L7QR6PRxkpBtcZl6gZCgrSR67RidFLhjyzurjDA7SneB1DXNLiq
 aZlApexTgiKUw==
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 55896
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-KTuBE4fayLPodAI6yOqY
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: base64

amdhcnQgc2NocmVlZiBvcCB6YSAxMS0wNi0yMDIyIG9tIDE1OjI3IFstMDUwMF06Cj4gKyhkZWZp
bmUtcHVibGljIHB5dGhvbi1weWJhcmUKPiArwqAgKHBhY2thZ2UKPiArwqDCoMKgIChuYW1lICJw
eXRob24tcHliYXJlIikKPiArwqDCoMKgICh2ZXJzaW9uICIwLjEuMSIpCj4gK8KgwqDCoCAoc291
cmNlCj4gK8KgwqDCoMKgwqAgKG9yaWdpbgo+ICvCoMKgwqDCoMKgwqDCoCAobWV0aG9kIGdpdC1m
ZXRjaCkKPiArwqDCoMKgwqDCoMKgwqAgKHVyaQo+ICvCoMKgwqDCoMKgwqDCoMKgIChnaXQtcmVm
ZXJlbmNlCj4gK8KgwqDCoMKgwqDCoMKgwqDCoCAodXJsICJodHRwczovL2dpdC5zci5odC9+Y2hp
ZWZub2FoL3B5YmFyZSIpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoCAoY29tbWl0IChzdHJpbmctYXBw
ZW5kICJ2IiB2ZXJzaW9uKSkpKQo+ICvCoMKgwqDCoMKgwqDCoCAoZmlsZS1uYW1lIChnaXQtZmls
ZS1uYW1lIG5hbWUgdmVyc2lvbikpCj4gK8KgwqDCoMKgwqDCoMKgIChzaGEyNTYKPiArwqDCoMKg
wqDCoMKgwqDCoCAoYmFzZTMyICIxaWJtd3dmMXJkeGx3eXhsemh2M3YxaTB5YnNxZzBrcHBpbTkw
c204cnNibnM4Nnl5NGJ5IikpKSkKPiArwqDCoMKgIChidWlsZC1zeXN0ZW0gcHl0aG9uLWJ1aWxk
LXN5c3RlbSkKPiArwqDCoMKgIChhcmd1bWVudHMKPiArwqDCoMKgwqDCoCAobGlzdCAjOnBoYXNl
cwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICN+KG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBo
YXNlcwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHJlcGxhY2UgJ2NoZWNrCj4g
K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGxhbWJkYSogKCM6a2V5IHRlc3Rz
PyAjOmFsbG93LW90aGVyLWtleXMpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgICh3aGVuIHRlc3RzPwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqAgKGNoZGlyICJiYXJlIikKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgIChpbnZva2UgInB5dGVzdCIgIi12diIgIi4iKSkpKSkpKQo+ICvCoMKgwqAg
KG5hdGl2ZS1pbnB1dHMKPiArwqDCoMKgwqDCoCAobGlzdCBweXRob24tcHl0ZXN0KSkKPiArwqDC
oMKgIChob21lLXBhZ2UgImh0dHBzOi8vc3IuaHQvfmNoaWVmbm9haC9QeUJBUkUvIikKPiArwqDC
oMKgIChzeW5vcHNpcyAiRGVjbGFyYXRpdmUgaW1wbGVtZW50YXRpb24gb2YgQkFSRSBmb3IgUHl0
aG9uIikKPiArwqDCoMKgIChkZXNjcmlwdGlvbgo+ICsiQGNvZGV7cHl0aG9uLXB5YmFyZX0gaXMg
YSBnZW5lcmFsIHB1cnBvc2UgbGlicmFyeSBmb3Igc3Ryb25nbHkgdHlwZWQKPiArcHJpbWl0aXZl
cyBpbiBQeXRob24gdGhhdCBzdXBwb3J0cyBzZXJpYWxpemluZyB0byBhbmQgZnJvbSBAYWNyb255
bXtCQVJFLAo+ICtCaW5hcnkgQXBwbGljYXRpb24gUmVjb3JkIEVuY29kaW5nfSBtZXNzYWdlcy4i
KQo+ICvCoMKgwqAgKGxpY2Vuc2UgbGljZW5zZTpleHBhdAoKClBhY2thZ2UgZGVmaW5pdGlvbiBM
R1RNLCBidXQgSSBoYXZlIG9ubHkgbG9va2VkIGF0IHRoZSBkZWZpbml0aW9uLCBub3QKdGhlIHNv
dXJjZXMgZXRjLgo=


--=-KTuBE4fayLPodAI6yOqY
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYqYJRRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hezAQC/XkoJAQOnNwntQeQW7BPAW0uh
m+pBIO5wvQlbGj2oFQEAgBOkupg9vagjuCGaLg8ObX/IT74Xp1xeUAtyGFCYwAY=
=Dqgi
-----END PGP SIGNATURE-----

--=-KTuBE4fayLPodAI6yOqY--
Information forwarded to guix-patches@HIDDEN:
bug#55896; Package guix-patches. Full text available.

Message received at 55896 <at> debbugs.gnu.org:


Received: (at 55896) by debbugs.gnu.org; 11 Jun 2022 20:36:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 11 16:36:34 2022
Received: from localhost ([127.0.0.1]:54129 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1o07qU-0006yh-BS
	for submit <at> debbugs.gnu.org; Sat, 11 Jun 2022 16:36:34 -0400
Received: from mx1.dismail.de ([78.46.223.134]:43030)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jgart@HIDDEN>) id 1o07qR-0006yT-87
 for 55896 <at> debbugs.gnu.org; Sat, 11 Jun 2022 16:36:32 -0400
Received: from mx1.dismail.de (localhost [127.0.0.1])
 by mx1.dismail.de (OpenSMTPD) with ESMTP id a74625d2;
 Sat, 11 Jun 2022 22:36:24 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc
 :subject:date:message-id:mime-version:content-transfer-encoding;
 s=20190914; bh=lObytaXnokMYLO9BPndJyNpGjK2hFQsOllulik77hCc=; b=
 bXAc8bWtZnbMzveMAMFnMU+TeYxTaT1EZuAlv7TrEtlk2Hz5wxmyJOwWQ4W+O4oH
 MLhGzqQiiFOP5Z/XusScUN2bI/xpImGEy/w7+0J/Klqxhu+rsXQsmKR0IGTw/T68
 yJcs1d1/tTqumVK0cMthzLZJ6CTNqc9IRj8VbFjzIC2wa5CPhU0gYuprQ8dO3368
 E29DdPCwDqFBmx68vE19yHmnS1TSCR+WytiTkUzPuU/kR2+PLAUq+fQHYHHeQlZV
 DdFszcLqBT+D0+6mhOxfq339oMGLrQ8E5OGmWluMTLomFfBmDtcxZC1mLfL7KxeW
 17t5bO/zn2RJd2RV/aHJeA==
Received: from smtp1.dismail.de (<unknown> [10.240.26.11])
 by mx1.dismail.de (OpenSMTPD) with ESMTP id 358bee3a;
 Sat, 11 Jun 2022 22:36:23 +0200 (CEST)
Received: from smtp1.dismail.de (localhost [127.0.0.1])
 by smtp1.dismail.de (OpenSMTPD) with ESMTP id 3794d611;
 Sat, 11 Jun 2022 22:36:23 +0200 (CEST)
Received: by dismail.de (OpenSMTPD) with ESMTPSA id d55c8da8
 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); 
 Sat, 11 Jun 2022 22:36:22 +0200 (CEST)
From: jgart <jgart@HIDDEN>
To: 55896 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: Add python-pybare.
Date: Sat, 11 Jun 2022 15:27:01 -0500
Message-Id: <20220611202700.5655-1-jgart@HIDDEN>
X-Mailer: git-send-email 2.36.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 55896
Cc: Maxime Devos <maximedevos@HIDDEN>, jgart <jgart@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

* gnu/packages/python-xyz.scm (python-pybare): New variable.

Hi Maxime,

Thanks for the review. It is much appreciated.

Here is version 2 with your requested changes.

all best,

jgart
---
 gnu/packages/python-xyz.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 4104472848..5109434cbf 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -29418,6 +29418,39 @@ (define-public python-gatt
 Currently, Linux is the only platform supported by this library.")
     (license license:expat)))
 
+(define-public python-pybare
+  (package
+    (name "python-pybare")
+    (version "0.1.1")
+    (source
+      (origin
+        (method git-fetch)
+        (uri
+         (git-reference
+          (url "https://git.sr.ht/~chiefnoah/pybare")
+          (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32 "1ibmwwf1rdxlwyxlzhv3v1i0ybsqg0kppim90sm8rsbns86yy4by"))))
+    (build-system python-build-system)
+    (arguments
+      (list #:phases
+            #~(modify-phases %standard-phases
+                (replace 'check
+                  (lambda* (#:key tests? #:allow-other-keys)
+                    (when tests?
+                      (chdir "bare")
+                      (invoke "pytest" "-vv" ".")))))))
+    (native-inputs
+      (list python-pytest))
+    (home-page "https://sr.ht/~chiefnoah/PyBARE/")
+    (synopsis "Declarative implementation of BARE for Python")
+    (description
+"@code{python-pybare} is a general purpose library for strongly typed
+primitives in Python that supports serializing to and from @acronym{BARE,
+Binary Application Record Encoding} messages.")
+    (license license:expat)))
+
 (define-public python-musical-scales
   (package
     (name "python-musical-scales")
-- 
2.36.1
Information forwarded to guix-patches@HIDDEN:
bug#55896; Package guix-patches. Full text available.

Message received at 55896 <at> debbugs.gnu.org:


Received: (at 55896) by debbugs.gnu.org; 11 Jun 2022 08:21:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 11 04:21:43 2022
Received: from localhost ([127.0.0.1]:51814 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nzwNL-0003w9-B2
	for submit <at> debbugs.gnu.org; Sat, 11 Jun 2022 04:21:43 -0400
Received: from albert.telenet-ops.be ([195.130.137.90]:60182)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1nzwNJ-0003w1-EG
 for 55896 <at> debbugs.gnu.org; Sat, 11 Jun 2022 04:21:41 -0400
Received: from [172.20.10.9] ([188.189.218.39])
 by albert.telenet-ops.be with bizsmtp
 id hkMg270080rbbE406kMgKK; Sat, 11 Jun 2022 10:21:40 +0200
Message-ID: <31595048a784bc8cefeb42951c790cf8a654cd05.camel@HIDDEN>
Subject: Re: [bug#55896] [PATCH] gnu: Add python-pybare.
From: Maxime Devos <maximedevos@HIDDEN>
To: jgart <jgart@HIDDEN>, 55896 <at> debbugs.gnu.org
Date: Sat, 11 Jun 2022 10:21:36 +0200
In-Reply-To: <20220611042737.15082-1-jgart@HIDDEN>
References: <20220611042737.15082-1-jgart@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha512";
 protocol="application/pgp-signature"; boundary="=-zK4aJ/Hw2MEV+JbN3Ato"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22;
 t=1654935700; bh=X2XaUQmYFa8EX2Emg4HOKLjjFWlu9wDFPtZvEbyU/Ag=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=SzDYnF+EodtgrcTXDSRYaL+ktlUhr1MJlrEjscNgjIVS5O0jWXKkvkzliAmaPGEao
 VS8NYdGKCHt7xWyBrL/8aSpM70j3Yu0pasVczv/eMNjOsrC+LTG3+mg5aRKaRAdAEy
 LdYsf0TMAGTohbsHozOrf3ICYiT/CfwWhXf7xOSlFkosV6dV1e+Ct8roOSCmIScrzk
 hKr5f8zE4vi4oiRIR3hioBIqAkKL13feYsCJJg5EHmx6lZ49iLhWeBKbDBcOY0aJqf
 qwhSHKtGguYZTS6zR7KEtacg0RT1PmHvftaI6F0BcYNEVj4Hx9z39SZz6CXV2vFeFx
 VWrIH5XIx/Zpw==
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 55896
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--=-zK4aJ/Hw2MEV+JbN3Ato
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

jgart via Guix-patches via schreef op vr 10-06-2022 om 23:27 [-0500]:
> +=C2=A0=C2=A0=C2=A0 (arguments
> +=C2=A0=C2=A0=C2=A0=C2=A0 `(#:phases
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (modify-phases %standard-phases
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (replace 'check
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (lambda _
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 (chdir "bare")
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 (invoke "pytest" "."))))))

"./pre-inst-env guix lint python-pybare" will have a warning about
this.  Also, apparently 'list' is considered more readable than
quasiquote/unquote, see [1], so maybe eliminate the quasiquote in
favour of 'list'?

> BARE

Looks like a not well-known acronym, maybe use @acronym?

[1] https://logs.guix.gnu.org/guix/2022-06-09.log#194339

Otherwise the package definition LGTM, but I haven't built or tested it
or read the source code.

Greetings,
Maxime.

--=-zK4aJ/Hw2MEV+JbN3Ato
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYqRQkBccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qCgAP9Q1yU1khgacVHShcqnMkyEpRZe
DCB78jXtC+fDz4BtiAEAvBkNC+ZvQWuq2j9pokBQFanJ7fhXWJo7+7QKbhIPYwQ=
=TnDM
-----END PGP SIGNATURE-----

--=-zK4aJ/Hw2MEV+JbN3Ato--
Information forwarded to guix-patches@HIDDEN:
bug#55896; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 11 Jun 2022 04:28:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 11 00:28:49 2022
Received: from localhost ([127.0.0.1]:51667 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1nzsjw-0005qk-9Z
	for submit <at> debbugs.gnu.org; Sat, 11 Jun 2022 00:28:49 -0400
Received: from lists.gnu.org ([209.51.188.17]:39130)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jgart@HIDDEN>) id 1nzsjq-0005qZ-Rv
 for submit <at> debbugs.gnu.org; Sat, 11 Jun 2022 00:28:47 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:34290)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jgart@HIDDEN>) id 1nzsjq-0007cg-H9
 for guix-patches@HIDDEN; Sat, 11 Jun 2022 00:28:42 -0400
Received: from mx1.dismail.de ([78.46.223.134]:17491)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jgart@HIDDEN>) id 1nzsjo-0006Wg-13
 for guix-patches@HIDDEN; Sat, 11 Jun 2022 00:28:42 -0400
Received: from mx1.dismail.de (localhost [127.0.0.1])
 by mx1.dismail.de (OpenSMTPD) with ESMTP id 384aba7d
 for <guix-patches@HIDDEN>; Sat, 11 Jun 2022 06:28:00 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc
 :subject:date:message-id:mime-version:content-transfer-encoding;
 s=20190914; bh=eXLzSLRHdOOfkpkzKO4POLpndVA6OyUZNemboIq3Cxo=; b=
 F7foIOukg7Sm/Trgus1rqbrDr/VqcuZiGwv/DNOWYh4W8MVldTD9z0cbKffRu+JU
 atG4ODbrgRm4ZpZCKbawtxhxd3KA2GMQa4/Hj7g8vUPIRlpXrvfRSuKqrbATb7iS
 awJqI93+H+n8KWoj2SnOjn6EM1LslqOkl8zcDgAaQb3C2fB3FBab5cxYEelVDnlQ
 klK7toZxI409dfFERNwBkwbyr3nS3U4Bt+pzAapgWKFZWJn8GBo8SPOobhZILntm
 2USJC+kdeBxvZ8OC2TGbLSjpRLcvpvgNYts4TninxIfkD3pvdB1gW+EYzJXR9hCL
 zR2k81wRq3jypAnoDMWtzQ==
Received: from smtp1.dismail.de (<unknown> [10.240.26.11])
 by mx1.dismail.de (OpenSMTPD) with ESMTP id b5adacd9
 for <guix-patches@HIDDEN>; Sat, 11 Jun 2022 06:28:00 +0200 (CEST)
Received: from smtp1.dismail.de (localhost [127.0.0.1])
 by smtp1.dismail.de (OpenSMTPD) with ESMTP id f6373ed3
 for <guix-patches@HIDDEN>; Sat, 11 Jun 2022 06:28:00 +0200 (CEST)
Received: by dismail.de (OpenSMTPD) with ESMTPSA id 962a6e2b
 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); 
 Sat, 11 Jun 2022 06:27:54 +0200 (CEST)
From: jgart <jgart@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: Add python-pybare.
Date: Fri, 10 Jun 2022 23:27:37 -0500
Message-Id: <20220611042737.15082-1-jgart@HIDDEN>
X-Mailer: git-send-email 2.36.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=78.46.223.134; envelope-from=jgart@HIDDEN;
 helo=mx1.dismail.de
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: jgart <jgart@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

* gnu/packages/python-xyz.scm (python-pybare): New variable.
---
 gnu/packages/python-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 4104472848..ceedacd714 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -29418,6 +29418,38 @@ (define-public python-gatt
 Currently, Linux is the only platform supported by this library.")
     (license license:expat)))
 
+(define-public python-pybare
+  (package
+    (name "python-pybare")
+    (version "0.1.1")
+    (source
+      (origin
+        (method git-fetch)
+        (uri
+         (git-reference
+          (url "https://git.sr.ht/~chiefnoah/pybare")
+          (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32 "1ibmwwf1rdxlwyxlzhv3v1i0ybsqg0kppim90sm8rsbns86yy4by"))))
+    (build-system python-build-system)
+    (native-inputs
+      (list python-pytest))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (chdir "bare")
+             (invoke "pytest" "."))))))
+    (home-page "https://sr.ht/~chiefnoah/PyBARE/")
+    (synopsis "Declarative implementation of BARE for Python")
+    (description
+"@code{python-pybare} is a general purpose library for strongly
+typed primitives in Python that supports serializing to and from BARE
+messages.")
+    (license license:expat)))
+
 (define-public python-musical-scales
   (package
     (name "python-musical-scales")
-- 
2.36.1
Acknowledgement sent to jgart <jgart@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#55896; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 7 Jul 2022 20:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.