GNU bug report logs - #55916
[PATCH 1/2] gnu: Add emacs-corfu-doc-terminal.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Sun, 12 Jun 2022 01:07:02 UTC

Severity: normal

Tags: patch

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55916 in the body.
You can then email your comments to 55916 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#55916; Package guix-patches. (Sun, 12 Jun 2022 01:07:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to jgart <jgart <at> dismail.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 12 Jun 2022 01:07:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH 1/2] gnu: Add emacs-corfu-doc-terminal.
Date: Sat, 11 Jun 2022 20:05:48 -0500
Hi Guixers,

These two packages supports corfu in the terminal with doc popups and all.

all best,

jgart





Information forwarded to guix-patches <at> gnu.org:
bug#55916; Package guix-patches. (Sun, 12 Jun 2022 01:09:01 GMT) Full text and rfc822 format available.

Message #8 received at 55916 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 55916 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH 1/2] gnu: Add emacs-corfu-terminal.
Date: Sat, 11 Jun 2022 20:08:15 -0500
* gnu/packages/emacs-xyz.scm (emacs-corfu-terminal): New variable.
---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 469579792a..dff0d99632 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -31656,6 +31656,34 @@ (define-public emacs-osm
 parallel fetching of tiles with cURL, and more.")
     (license license:gpl3+)))
 
+(define-public emacs-corfu-terminal
+  (let ((commit "7c5a8a1c07b6c1a41b358b083d5bf7773701d26b")
+        (revision "0"))
+    (package
+      (name "emacs-corfu-terminal")
+      (version (git-version "0.4" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://codeberg.org/akib/emacs-corfu-terminal")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0pk5vfcz8w4hiqrwzwpxdjzlbhla0bw7a1h6v0mqxad0j9y7v3nw"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+        (list emacs-corfu emacs-popon))
+      (home-page "https://codeberg.org/akib/emacs-corfu-terminal/")
+      (synopsis "Corfu popup in terminal")
+      (description
+"@code{emacs-corfu} uses child frames to display candidates.  This makes
+it unusable in the terminal.  @code{emacs-corfu-popup} replaces that with
+popup/popon, which works everywhere.  Use @code{M-x corfu-popup-mode}
+to enable.  You'll probably want to enable it only in the terminal.")
+      (license license:gpl3+))))
+
 (define-public emacs-popon
   ;; Upstream does not tag releases.  The commit below matches the version
   ;; bump.
-- 
2.36.1





Information forwarded to guix-patches <at> gnu.org:
bug#55916; Package guix-patches. (Sun, 12 Jun 2022 01:09:02 GMT) Full text and rfc822 format available.

Message #11 received at 55916 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 55916 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH 2/2] gnu: Add emacs-corfu-doc-terminal.
Date: Sat, 11 Jun 2022 20:08:16 -0500
* gnu/packages/emacs-xyz.scm (emacs-corfu-doc-terminal): New variable.
---
 gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index dff0d99632..eca0423216 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -31684,6 +31684,34 @@ (define-public emacs-corfu-terminal
 to enable.  You'll probably want to enable it only in the terminal.")
       (license license:gpl3+))))
 
+(define-public emacs-corfu-doc-terminal
+  (let ((commit "d8945c64b52d76e864b767b3048674f222daf80b")
+        (revision "0"))
+    (package
+      (name "emacs-corfu-doc-terminal")
+      (version (git-version "0.5" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://codeberg.org/akib/emacs-corfu-doc-terminal")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0j0dd8np5x93wic22bc5i9h7bq2gj700n4fh11dzzgsj14lv2r5k"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+        (list emacs-corfu emacs-corfu-doc emacs-corfu-terminal emacs-popon))
+      (home-page "https://codeberg.org/akib/emacs-corfu-doc-terminal/")
+      (synopsis "Documentation popup in terminal provided by corfu")
+      (description
+"@code{emacs-corfu-doc} uses child frames to display
+candidates.  This makes @code{emacs-corfu-doc} unusable on
+terminal.  @code{emac-corfu-doc-terminal} replaces that with
+@code{emacs-popon}, which works everywhere.")
+      (license license:gpl3+))))
+
 (define-public emacs-popon
   ;; Upstream does not tag releases.  The commit below matches the version
   ;; bump.
-- 
2.36.1





Information forwarded to guix-patches <at> gnu.org:
bug#55916; Package guix-patches. (Sun, 12 Jun 2022 11:24:02 GMT) Full text and rfc822 format available.

Message #14 received at 55916 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: jgart <jgart <at> dismail.de>, 55916 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/2] gnu: Add emacs-corfu-doc-terminal.
Date: Sun, 12 Jun 2022 13:23:36 +0200
Am Samstag, dem 11.06.2022 um 20:05 -0500 schrieb jgart:
> Hi Guixers,
> 
> These two packages supports corfu in the terminal with doc popups and
> all.
I cleaned up the definitions and pushed them.  Cheers




Reply sent to Liliana Marie Prikler <liliana.prikler <at> gmail.com>:
You have taken responsibility. (Sun, 12 Jun 2022 11:43:02 GMT) Full text and rfc822 format available.

Notification sent to jgart <jgart <at> dismail.de>:
bug acknowledged by developer. (Sun, 12 Jun 2022 11:43:03 GMT) Full text and rfc822 format available.

Message #19 received at 55916-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: jgart <jgart <at> dismail.de>, 55916-done <at> debbugs.gnu.org
Subject: Re: [PATCH 1/2] gnu: Add emacs-corfu-doc-terminal.
Date: Sun, 12 Jun 2022 13:42:36 +0200
Am Sonntag, dem 12.06.2022 um 13:23 +0200 schrieb Liliana Marie
Prikler:
> Am Samstag, dem 11.06.2022 um 20:05 -0500 schrieb jgart:
> > Hi Guixers,
> > 
> > These two packages supports corfu in the terminal with doc popups
> > and
> > all.
> I cleaned up the definitions and pushed them.  Cheers
Always forgetting to add -done...




Information forwarded to guix-patches <at> gnu.org:
bug#55916; Package guix-patches. (Sun, 12 Jun 2022 20:56:01 GMT) Full text and rfc822 format available.

Message #22 received at 55916-done <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 55916-done <at> debbugs.gnu.org
Subject: Re: [PATCH 1/2] gnu: Add emacs-corfu-doc-terminal.
Date: Sun, 12 Jun 2022 15:55:23 -0500
On Sun, 12 Jun 2022 13:42:36 +0200 Liliana Marie Prikler <liliana.prikler <at> gmail.com> wrote:

Hi lilyp,

Thanks for taking the time to review and help with merging this package.

It's much appreciated.

all best,

jgart




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 11 Jul 2022 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 290 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.