GNU bug report logs - #55931
[PATCH] gnu: java-commons-lang3: Update to 3.12.0

Previous Next

Package: guix-patches;

Reported by: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>

Date: Sun, 12 Jun 2022 19:41:02 UTC

Severity: normal

Tags: patch

Done: Julien Lepiller <julien <at> lepiller.eu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 55931 in the body.
You can then email your comments to 55931 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#55931; Package guix-patches. (Sun, 12 Jun 2022 19:41:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 12 Jun 2022 19:41:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: java-commons-lang3: Update to 3.12.0
Date: Sun, 12 Jun 2022 22:40:35 +0300
[Message part 1 (text/plain, inline)]
Hello,

this patch updates 'java-commons-lang3' to 3.12.0.

The update is required to add 'java-commons-text' package.

Thanks,

- Artyom

[0001-gnu-java-commons-lang3-Update-to-3.12.0.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#55931; Package guix-patches. (Sun, 12 Jun 2022 20:51:01 GMT) Full text and rfc822 format available.

Message #8 received at 55931 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 55931 <at> debbugs.gnu.org
Subject: Re: [bug#55931] [PATCH] gnu: java-commons-lang3: Update to 3.12.0
Date: Sun, 12 Jun 2022 22:50:29 +0200
Le Sun, 12 Jun 2022 22:40:35 +0300,
"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> a écrit :

> Hello,
> 
> this patch updates 'java-commons-lang3' to 3.12.0.
> 
> The update is required to add 'java-commons-text' package.
> 
> Thanks,
> 
> - Artyom
> 

Hi!

The patch looks good and almost works. Unfortunately, the pom file
makes java-jmh fail eventually:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce
(enforce-maven) on project jmh-parent: Execution enforce-maven of goal
org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce failed:
Plugin org.apache.maven.plugins:maven-enforcer-plugin:3.0.0 or one of
its dependencies could not be resolved: Failed to collect dependencies
at org.apache.maven.plugins:maven-enforcer-plugin:jar:3.0.0 ->
org.apache.maven:maven-artifact:jar:3.8.5 ->
org.apache.commons:commons-lang3:jar:3.12.0: Failed to read artifact
descriptor for org.apache.commons:commons-lang3:jar:3.12.0: Cannot
access central (https://repo.maven.apache.org/maven2) in offline mode
and the artifact org.junit:junit-bom:pom:5.7.1 has not been downloaded
from it before. -> [Help 1]

From what I understand, maven tries to get org.junit:junit-bom because
it is referenced in commons-lang3's pom file, but we don't have it. This
is the only reference to junit-bom though:

<dependencyManagement>
<dependencies>
 <dependency>
  <groupId>org.junit</groupId>
  <artifactId>junit-bom</artifactId>
  <version>5.7.1</version>
  <type>pom</type>
  <scope>import</scope>
 </dependency>
</dependencies>
</dependencyManagement>

I don't know maven well enough, so I'm not sure what that means, but is
junit-bom really needed? Do you think you could add a phase to remove
this dependencyManagement part of the pom file? It wouldn't be the
first time we modify a pom file to make maven happy later in the
dependency chain.

Otherwise, all packages build fine with this update :)




Information forwarded to guix-patches <at> gnu.org:
bug#55931; Package guix-patches. (Mon, 13 Jun 2022 07:27:01 GMT) Full text and rfc822 format available.

Message #11 received at 55931 <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 55931 <at> debbugs.gnu.org
Subject: Re: [bug#55931] [PATCH] gnu: java-commons-lang3: Update to 3.12.0
Date: Mon, 13 Jun 2022 10:26:19 +0300
[Message part 1 (text/plain, inline)]
Hello Julien,

I've added a patch that removes 'junit-bom' from 'pom.xml' and tried to
build 'java-jmh' as you did; it seems that everything now builds without
errors.

Please find the updated patch attached.

- Artyom
[0001-gnu-java-commons-lang3-Update-to-3.12.0.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F
[signature.asc (application/pgp-signature, inline)]

Reply sent to Julien Lepiller <julien <at> lepiller.eu>:
You have taken responsibility. (Mon, 13 Jun 2022 20:51:01 GMT) Full text and rfc822 format available.

Notification sent to "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>:
bug acknowledged by developer. (Mon, 13 Jun 2022 20:51:02 GMT) Full text and rfc822 format available.

Message #16 received at 55931-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
Cc: 55931-done <at> debbugs.gnu.org
Subject: Re: [bug#55931] [PATCH] gnu: java-commons-lang3: Update to 3.12.0
Date: Mon, 13 Jun 2022 22:50:31 +0200
[Message part 1 (text/plain, inline)]
Le Mon, 13 Jun 2022 10:26:19 +0300,
"Artyom V. Poptsov" <poptsov.artyom <at> gmail.com> a écrit :

> Hello Julien,
> 
> I've added a patch that removes 'junit-bom' from 'pom.xml' and tried
> to build 'java-jmh' as you did; it seems that everything now builds
> without errors.
> 
> Please find the updated patch attached.
> 
> - Artyom

Great! Pushed to master as 4ff9f1689d0d8f3c7555c472ce67aaa928af564d.

Before pushing, I applied a few changes. First, when you add a patch,
don't forget to add it to gnu/local.mk. This ensures "make dist" will
generate a complete tarball. Otherwise, the tarball won't contain the
patch. Second, I added a short comment in the patch to explain its
purpose. Finally, I slightly reworded the changelog text about the
patch, in the commit message.

Thanks!
[Message part 2 (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 12 Jul 2022 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 260 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.